To detect that a sequence number is done, we are doing math on unsigned
integers so the result is unsigned too. Not what was intended for the =
comparison. The result is user stuck forever in flush call.
Convert to int to fix this.
Further, get rid of ({}) to make code clearer.
Signed-off-by:
This series has three major topics:
- add required kernel reentry after IO exits
- provide MCE forwarding under !CONFIG_IOTHREAD
- prepare kvm_cpu_exec for qemu-kvm reuse
Along these lines, several cleanups and simplifcations are applied to
cpus.c and the KVM VCPU execution bits. The first
From: Jan Kiszka jan.kis...@siemens.com
We do not use the timeout, so drop its logic. As we always poll our
signals, we do not need to drop the global lock. Removing those calls
allows some further simplifications. Also fix the error processing of
sigpending at this chance.
Signed-off-by: Jan
From: Jan Kiszka jan.kis...@siemens.com
Move {tcg,kvm}_init_ipi and block_io_signals to avoid prototypes, rename
the former two to clarify that they deal with more than SIG_IPI. No
functional changes.
The forward declaration of sigbus_handler is just temporarily, it will
be moved in a succeeding
From: Jan Kiszka jan.kis...@siemens.com
Provide arch-independent kvm_on_sigbus* stubs to remove the #ifdef'ery
from cpus.c. This patch also fixes --disable-kvm build by providing the
missing kvm_on_sigbus_vcpu kvm-stub.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
CC: Huang Ying
From: Jan Kiszka jan.kis...@siemens.com
Pure interface cosmetics: Ensure that only kvm core services (as
declared in kvm.h) start with kvm_. Prepend qemu_ to those that
violate this rule in cpus.c. Also rename the corresponding tcg functions
for the sake of consistency.
Signed-off-by: Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com
No functional changes.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
cpus.c | 96 ++-
1 files changed, 58 insertions(+), 38 deletions(-)
diff --git a/cpus.c b/cpus.c
index
From: Jan Kiszka jan.kis...@siemens.com
The reset we issue on KVM_EXIT_SHUTDOWN implies that we should also
leave the VCPU loop. As we now check for exit_request which is set by
qemu_system_reset_request, this bug is no longer critical. Still it's an
unneeded extra turn.
Signed-off-by: Jan
From: Jan Kiszka jan.kis...@siemens.com
KVM requires to reenter the kernel after IO exits in order to complete
instruction emulation. Failing to do so will leave the kernel state
inconsistently behind. To ensure that we will get back ASAP, we issue a
self-signal that will cause KVM_RUN to return
From: Jan Kiszka jan.kis...@siemens.com
Do not ignore errors of kvm_init_vcpu, they are fatal.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
cpus.c | 14 --
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index b6f1cfb..33b604e 100644
---
From: Jan Kiszka jan.kis...@siemens.com
Effectively no functional change yet as kvm_irqchip_in_kernel still only
returns 0, but this patch will allow qemu-kvm to adopt the VCPU loop of
upsteam KVM.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
target-i386/kvm.c | 78
From: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
cpus.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index 4c9928e..8af53a9 100644
--- a/cpus.c
+++ b/cpus.c
@@ -597,8 +597,8 @@ static void
From: Jan Kiszka jan.kis...@siemens.com
This reverts commit e60806755e2b74a34813c73ec61c33d38d102286.
---
kvm-all.c |6 --
kvm-stub.c |4 ++--
kvm.h |2 +-
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index a5e9246..4ab5f5c 100644
---
From: Jan Kiszka jan.kis...@siemens.com
Improve the readability of the exit dispatcher by moving the static
return value of kvm_handle_io to its caller.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
kvm-all.c | 17 -
1 files changed, 8 insertions(+), 9 deletions(-)
From: Jan Kiszka jan.kis...@siemens.com
Currently, we only configure and process MCE-related SIGBUS events if
CONFIG_IOTHREAD is enabled. Fix this by factoring out the required
handler registration and system configuration. Make sure that events
happening over a VCPU context in non-threaded mode
From: Jan Kiszka jan.kis...@siemens.com
Introduce qemu_cpu_kick_self to send SIG_IPI to the calling VCPU
context. First user will be kvm.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
cpus.c| 19 ++-
qemu-common.h |1 +
2 files changed, 19 insertions(+), 1
From: Jan Kiszka jan.kis...@siemens.com
Align with qemu-kvm and prepare for IO exit fix: There is no need to run
kvm_arch_process_irqchip_events in the inner VCPU loop. Any state change
this service processes will first cause an exit from kvm_cpu_exec
anyway. And we will have to reenter the
From: Jan Kiszka jan.kis...@siemens.com
Block SIG_IPI and SIGBUS, unblock them during KVM_RUN, just like in
io-thread mode. This will be required to process SIGBUS and for
self-IPIs. As Windows doesn't support signal services, we need to
provide a stub for the init function.
Signed-off-by: Jan
From: Jan Kiszka jan.kis...@siemens.com
Mixing up TCG bits with KVM already led to problems around eflags
emulation on x86. Moreover, quite some code that TCG requires on cpu
enty/exit is useless for KVM. So dispatch between tcg_cpu_exec and
kvm_cpu_exec as early as possible.
The core logic of
From: Jan Kiszka jan.kis...@siemens.com
We do not check them, and the only arch with non-empty implementations
always returns 0 (this is also true for qemu-kvm).
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
CC: Alexander Graf ag...@suse.de
---
kvm.h |5 ++---
Linus, please pull from
git://git.kernel.org/pub/scm/virt/kvm/kvm.git kvm-updates/2.6.38
to receive the KVM updates for the 2.6.38 merge window. Major features
include
- asynchronous page faults, which allow a guest to continue processing
interrupts even when its memory is being paged
On 01/09/2011 10:10 PM, Nikola Ciprich wrote:
Hi Avi,
sorry it took so long.
running chkdsk from windows is OK, runs pretty fast.
so there must be something different in this preboot environment.
Let's try to see what's the difference between the working machine and
the bad one.
Please
cpu-index is better name.
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
diff --git a/hmp-commands.hx b/hmp-commands.hx
index df134f8..99b96a8 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -721,7 +721,7 @@ ETEXI
#if defined(TARGET_I386)
{
.name = nmi,
-
On Fri, Jan 07, 2011 at 10:23:58AM +0900, Simon Horman wrote:
On Thu, Jan 06, 2011 at 05:38:01PM -0500, Jesse Gross wrote:
[ snip ]
I know that everyone likes a nice netperf result but I agree with
Michael that this probably isn't the right question to be asking. I
don't think that
Make we can inject NMI via qemu-monitor-protocol.
We use inject-nmi for the qmp command name, the meaning is clearer.
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
diff --git a/hmp-commands.hx b/hmp-commands.hx
index a49fcd4..4db413d 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@
When the argument cpu-index is not given,
then nmi command will inject NMI on all CPUs.
This simulate the nmi button on physical machine.
Thanks to Markus Armbruster for correcting the logic
detecting cpu-index is given or not.
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
diff --git
When cpu-index is found invalid in runtime, it will report
QERR_INVALID_PARAMETER_VALUE.
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
diff --git a/monitor.c b/monitor.c
index 1bee840..7402c0f 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2535,6 +2535,7 @@ static int do_inject_nmi(Monitor
Signed-off-by: Gleb Natapov g...@redhat.com
diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index e97f565..0038526 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -40,6 +40,7 @@
#include monitor.h
#include range.h
#include pci/header.h
+#include sysemu.h
/*
Am 10.01.2011 09:31, Jan Kiszka wrote:
This series has three major topics:
- add required kernel reentry after IO exits
- provide MCE forwarding under !CONFIG_IOTHREAD
- prepare kvm_cpu_exec for qemu-kvm reuse
Along these lines, several cleanups and simplifcations are applied to
cpus.c
On 01/10/2011 09:31 AM, Jan Kiszka wrote:
+int kvm_on_sigbus_vcpu(CPUState *env, int code, void *addr)
+{
+return kvm_on_sigbus_vcpu(env, code, addr);
+}
+
+int kvm_on_sigbus(int code, void *addr)
+{
+return kvm_on_sigbus(code, addr);
+}
Missing arch_ here?
Paolo
--
To unsubscribe
On 01/10/2011 09:31 AM, Jan Kiszka wrote:
From: Jan Kiszkajan.kis...@siemens.com
We do not use the timeout, so drop its logic. As we always poll our
signals, we do not need to drop the global lock. Removing those calls
allows some further simplifications. Also fix the error processing of
Am 10.01.2011 11:13, Paolo Bonzini wrote:
On 01/10/2011 09:31 AM, Jan Kiszka wrote:
+int kvm_on_sigbus_vcpu(CPUState *env, int code, void *addr)
+{
+return kvm_on_sigbus_vcpu(env, code, addr);
+}
+
+int kvm_on_sigbus(int code, void *addr)
+{
+return kvm_on_sigbus(code, addr);
+}
From: Qingtang Zhou qz...@redhat.com
Introduce qmp_monitor property can help us easily get a qmp monitor
of guest.
CC to Luiz and kvm@vger.kernel.org
Signed-off-by: Qingtang Zhou qz...@redhat.com
---
client/tests/kvm/kvm_vm.py | 10 ++
client/tests/kvm/tests/qmp_basic.py |
From: Qingtang Zhou qz...@redhat.com
QMP in qemu-kvm-0.12.* has some difference from QMP in qemu-kvm-0.13.*.
These difference cause 'qmp_basic' test fail while running on older qemu-kvm.
This patch will fix these failures, make 'qmp_basic' runs happily.
Changelog from v1:
- fix errors in
On Thu, Jan 06, 2011 at 12:10:44AM -1000, Zachary Amsden wrote:
+static void svm_set_tsc_trapping(struct kvm_vcpu *vcpu, bool trap)
+{
+ struct vcpu_svm *svm = to_svm(vcpu);
+ if (trap)
+ svm-vmcb-control.intercept |= 1ULL INTERCEPT_RDTSC;
+ else
+
Juan Quintela quint...@redhat.com wrote:
Now sent it to the right kvm list. Sorry for the second sent.
Please send any agenda items you are interested in covering.
- KVM Forum 2011 (Jes).
thanks, Juan.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message
On 01/10/11 12:59, Juan Quintela wrote:
Juan Quintela quint...@redhat.com wrote:
Now sent it to the right kvm list. Sorry for the second sent.
Please send any agenda items you are interested in covering.
- KVM Forum 2011 (Jes).
Just to add a bit more background. Last year we discussed
Juan Quintela quint...@redhat.com wrote:
Juan Quintela quint...@redhat.com wrote:
Now sent it to the right kvm list. Sorry for the second sent.
Please send any agenda items you are interested in covering.
- KVM Forum 2011 (Jes).
thanks, Juan.
- migration and block devices: a mess.
*
On Mon, Jan 10, 2011 at 1:05 PM, Jes Sorensen jes.soren...@redhat.com wrote:
On 01/10/11 12:59, Juan Quintela wrote:
Juan Quintela quint...@redhat.com wrote:
Now sent it to the right kvm list. Sorry for the second sent.
Please send any agenda items you are interested in covering.
- KVM
On Fri, Jan 07, 2011 at 10:44:20AM -1000, Zachary Amsden wrote:
On 01/07/2011 12:48 AM, Marcelo Tosatti wrote:
On Thu, Jan 06, 2011 at 12:10:45AM -1000, Zachary Amsden wrote:
Use an MSR to allow soft migration to hosts which do not support
TSC trapping. Rather than make this a required
On 01/07/2011 12:41 AM, a...@linux-foundation.org wrote:
The mm-of-the-moment snapshot 2011-01-06-15-41 has been uploaded to
Hi, something of the following breaks qemu-kvm:
thp-add-pmd-mangling-generic-functions.patch
thp-add-pmd-mangling-generic-functions-fix-pgtableh-build-for-um.patch
On Mon, Jan 10, 2011 at 03:37:57PM +0100, Jiri Slaby wrote:
On 01/07/2011 12:41 AM, a...@linux-foundation.org wrote:
The mm-of-the-moment snapshot 2011-01-06-15-41 has been uploaded to
Hi, something of the following breaks qemu-kvm:
Thanks for the report. It's already fixed and I posted
So we don't have errors when the monitor function info
fails, leading to an undefined variable error.
Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com
---
client/tests/kvm/tests/physical_resources_check.py |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git
On 10 January 2011 07:45, Stefan Hajnoczi stefa...@gmail.com wrote:
On Mon, Jan 10, 2011 at 1:05 PM, Jes Sorensen jes.soren...@redhat.com wrote:
Just to add a bit more background. Last year we discussed the issue of
whether to aim for a KVM Forum in the same style as we had in 2010, or
whether
On Mon, 10 Jan 2011, Kirill A. Shutemov wrote:
Every time I run qemu with KVM enabled I get this in dmesg:
[ 182.878328] BUG: sleeping function called from invalid context at
mm/slub.c:793
[ 182.878339] in_atomic(): 1, irqs_disabled(): 0, pid: 4992, name: qemu
[ 182.878355] Pid: 4992,
Am 04.01.2011 14:14, Avi Kivity wrote:
'goto done' leads to a maze of checks and actions, all pointless. Bail
out immediately if we can't decode.
Signed-off-by: Avi Kivity a...@redhat.com
---
arch/x86/kvm/x86.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
On 01/10/2011 12:47 PM, qz...@redhat.com wrote:
From: Qingtang Zhouqz...@redhat.com
Introduce qmp_monitor property can help us easily get a qmp monitor
of guest.
CC to Luiz and kvm@vger.kernel.org
Signed-off-by: Qingtang Zhouqz...@redhat.com
The monitor property returns the main monitor.
On Mon, Jan 10, 2011 at 10:52:05AM -0600, Christoph Lameter wrote:
On Mon, 10 Jan 2011, Kirill A. Shutemov wrote:
Every time I run qemu with KVM enabled I get this in dmesg:
[ 182.878328] BUG: sleeping function called from invalid context at
mm/slub.c:793
[ 182.878339]
On 01/08/2011 02:47 AM, Jan Kiszka wrote:
OK, but I don't want to argue about the ioeventfd API. So let's put this
case aside. :)
I often reply too quickly without explaining myself. Let me use
ioeventfd as an example to highlight why KVMState is a good thing.
In real life, PIO and
Am 10.01.2011 20:59, Anthony Liguori wrote:
On 01/08/2011 02:47 AM, Jan Kiszka wrote:
Am 08.01.2011 00:27, Anthony Liguori wrote:
On 01/07/2011 03:03 AM, Jan Kiszka wrote:
Am 06.01.2011 20:24, Anthony Liguori wrote:
On 01/06/2011 11:56 AM, Marcelo Tosatti wrote:
Am 10.01.2011 21:11, Anthony Liguori wrote:
On 01/08/2011 02:47 AM, Jan Kiszka wrote:
OK, but I don't want to argue about the ioeventfd API. So let's put this
case aside. :)
I often reply too quickly without explaining myself. Let me use
ioeventfd as an example to highlight why
On 01/10/2011 02:12 PM, Jan Kiszka wrote:
Am 10.01.2011 20:59, Anthony Liguori wrote:
On 01/08/2011 02:47 AM, Jan Kiszka wrote:
Am 08.01.2011 00:27, Anthony Liguori wrote:
On 01/07/2011 03:03 AM, Jan Kiszka wrote:
Am 06.01.2011 20:24, Anthony Liguori wrote:
On 01/06/2011 11:56 AM, Marcelo Tosatti wrote:
From: Jan Kiszkajan.kis...@siemens.com
If kvmclock is used, which implies the kernel supports it, register a
kvmclock device with the sysbus. Its main purpose is to save and restore
the kernel state on migration, but this will also allow to
Am 10.01.2011 21:23, Anthony Liguori wrote:
On 01/10/2011 02:12 PM, Jan Kiszka wrote:
Am 10.01.2011 20:59, Anthony Liguori wrote:
On 01/08/2011 02:47 AM, Jan Kiszka wrote:
Am 08.01.2011 00:27, Anthony Liguori wrote:
On 01/07/2011 03:03 AM, Jan Kiszka wrote:
Am
On 01/10/2011 04:01 PM, Andrea Arcangeli wrote:
On Mon, Jan 10, 2011 at 03:37:57PM +0100, Jiri Slaby wrote:
On 01/07/2011 12:41 AM, a...@linux-foundation.org wrote:
The mm-of-the-moment snapshot 2011-01-06-15-41 has been uploaded to
Hi, something of the following breaks qemu-kvm:
Thanks
Am 10.01.2011 21:31, Anthony Liguori wrote:
On 01/06/2011 11:56 AM, Marcelo Tosatti wrote:
From: Jan Kiszkajan.kis...@siemens.com
If kvmclock is used, which implies the kernel supports it, register a
kvmclock device with the sysbus. Its main purpose is to save and restore
the kernel state on
Am 10.01.2011 22:06, Jan Kiszka wrote:
kvmclock should be created with
kvm_state as a parameter and kvm_vm_ioctl() is passed the stored
reference. Taking a global reference to kvm_state in machine_init is
not a bad thing, obviously the machine initialization function needs
access to the
On 01/10/2011 04:21 PM, Jan Kiszka wrote:
Am 10.01.2011 22:06, Jan Kiszka wrote:
kvmclock should be created with
kvm_state as a parameter and kvm_vm_ioctl() is passed the stored
reference. Taking a global reference to kvm_state in machine_init is
not a bad thing, obviously the machine
On 01/10/2011 03:06 PM, Jan Kiszka wrote:
Am 10.01.2011 21:31, Anthony Liguori wrote:
On 01/06/2011 11:56 AM, Marcelo Tosatti wrote:
From: Jan Kiszkajan.kis...@siemens.com
If kvmclock is used, which implies the kernel supports it, register a
kvmclock device with the sysbus. Its main
On Thu, 2011-01-06 at 14:12 -0200, Eduardo Habkost wrote:
From: Eduardo Habkost ehabk...@raisama.net
Useful for syntax or other errors on the config file. We want to tell
the user on which file:line the error is located.
Signed-off-by: Eduardo Habkost ehabk...@raisama.net
---
- Original Message -
From: Michael Goldish mgold...@redhat.com
To: qz...@redhat.com
Cc: autot...@test.kernel.org, kvm@vger.kernel.org, lcapitul...@redhat.com
Sent: Monday, January 10, 2011 3:52:53 PM
Subject: Re: [PATCH 1/2 RESEND] KVM Test: Introduce qmp_monitor property in
'kvm_vm.VM'
On Mon, 2011-01-10 at 19:52 +0200, Michael Goldish wrote:
On 01/10/2011 12:47 PM, qz...@redhat.com wrote:
From: Qingtang Zhouqz...@redhat.com
Introduce qmp_monitor property can help us easily get a qmp monitor
of guest.
CC to Luiz and kvm@vger.kernel.org
Signed-off-by: Qingtang
This patch also checks failures in dd commands executed inside
the guest. It also gets rid of the commands API usage and uses
utils.run.
Signed-off-by: Amos Kong ak...@redhat.com
Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com
---
client/tests/kvm/tests/ethtool.py | 17
From: Jason Wang jasow...@redhat.com
It's helpful to test the installation during migration. So patch just reuse the
unattended installation tests and migrate the vm during the wait loop. The
params of -initrd, -kernel and -append were also dropped as they may
break the migration.
Changes from
From: Jason Wang jasow...@redhat.com
Run some workload in the background and do the migration would be helpful to
verfiy the correctness, so this patch use the Thread class to wait for the
completion of autotest cmd -- bin/autotest control and do the migration in
parallel.
Changes from v1:
- Use
Am 11.01.2011 00:02, Anthony Liguori wrote:
On 01/10/2011 04:21 PM, Jan Kiszka wrote:
Am 10.01.2011 22:06, Jan Kiszka wrote:
kvmclock should be created with
kvm_state as a parameter and kvm_vm_ioctl() is passed the stored
reference. Taking a global reference to kvm_state in
Am 11.01.2011 00:04, Anthony Liguori wrote:
kvmclock should be created with
kvm_state as a parameter and kvm_vm_ioctl() is passed the stored
reference. Taking a global reference to kvm_state in machine_init is
not a bad thing, obviously the machine initialization function needs
access to
On 01/10/2011 11:21 PM, Jan Kiszka wrote:
Am 10.01.2011 22:06, Jan Kiszka wrote:
kvmclock should be created with
kvm_state as a parameter and kvm_vm_ioctl() is passed the stored
reference. Taking a global reference to kvm_state in machine_init is
not a bad thing, obviously the machine
On 07.01.2011, at 14:38, Dushyant Bansal wrote:
On Friday 07 January 2011 06:07 PM, Alexander Graf wrote:
My aim is to install kvm on a powerpc system. I will give a detailed
description of the environment.
Host arch: x86
kernel: 2.6.32.25 (ubuntu 10.04 32 bit)
I have emulated powerpc
69 matches
Mail list logo
