Re: KVM induced panic on 2.6.38[2367] 2.6.39

2011-06-01 Thread Brad Campbell
On 01/06/11 12:52, Hugh Dickins wrote: I guess Brad could try SLUB debugging, boot with slub_debug=P for poisoning perhaps; though it might upset alignments and drive the problem underground. Or see if the same happens with SLAB instead of SLUB. Not much use I'm afraid. This is all I get in

Re: [PATCH v2 3/4] kvm tools: Use ioeventfd in virtio-net

2011-06-01 Thread Sasha Levin
On Wed, 2011-06-01 at 09:41 +0800, Asias He wrote: On 06/01/2011 12:32 AM, Sasha Levin wrote: On Tue, 2011-05-31 at 10:18 +0300, Pekka Enberg wrote: On Tue, May 31, 2011 at 2:53 AM, Asias He asias.he...@gmail.com wrote: TAP based network performance with ioeventfd Heh, so how did it

Re: KVM induced panic on 2.6.38[2367] 2.6.39

2011-06-01 Thread Avi Kivity
On 06/01/2011 09:31 AM, Brad Campbell wrote: On 01/06/11 12:52, Hugh Dickins wrote: I guess Brad could try SLUB debugging, boot with slub_debug=P for poisoning perhaps; though it might upset alignments and drive the problem underground. Or see if the same happens with SLAB instead of SLUB.

RE: [Patch v5 1/4] Remove SMEP bit from CR4_RESERVED_BITS

2011-06-01 Thread Tian, Kevin
From: Ingo Molnar Sent: Monday, May 30, 2011 3:41 PM * Yang, Wei Y wei.y.y...@intel.com wrote: This patch removes SMEP bit from CR4_RESERVED_BITS. I'm wondering, what is the best-practice way for tools/kvm/ to set SMEP for the guest kernel automatically, even if the guest kernel

[PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index

2011-06-01 Thread Mark Wu
Current index allocation in virtio-blk is based on a monotonically increasing variable index. It could cause some confusion about disk name in the case of hot-plugging disks. And it's impossible to find the lowest available index by just maintaining a simple index. So it's changed to use ida to

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Gerd Hoffmann
Hi, 0xE000 is hard-coded in the DSDT for both piix and q35 as below. If the range is determined dynamically, the area also needs to be updated somehow dynamically. ... Name (_CRS, ResourceTemplate () ... DWordMemory (ResourceProducer, PosDecode, MinFixed,

Re: [Patch v5 1/4] Remove SMEP bit from CR4_RESERVED_BITS

2011-06-01 Thread Ingo Molnar
* Tian, Kevin kevin.t...@intel.com wrote: From: Ingo Molnar Sent: Monday, May 30, 2011 3:41 PM * Yang, Wei Y wei.y.y...@intel.com wrote: This patch removes SMEP bit from CR4_RESERVED_BITS. I'm wondering, what is the best-practice way for tools/kvm/ to set SMEP for the

Re: [PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index

2011-06-01 Thread Mark Wu
On 06/01/2011 03:24 AM, Mark Wu wrote: - if (index_to_minor(index)= 1 MINORBITS) - return -ENOSPC; + do { + if (!ida_pre_get(vd_index_ida, GFP_KERNEL)) + return err; + There's a problem in above code: err is not initialized before

[PATCH] Revert qemu-kvm: Update kvm_check_many_ioeventfds for qemu-kvm use

2011-06-01 Thread Jan Kiszka
This reverts commit cad7c5d76b30d30fc91dea049fef7340fd96ff3c. We migrated to upstream io-thread, so this hack became obsolete. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm-all.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index

[PATCH] qemu-kvm: Remove some spurious diffs to upstream

2011-06-01 Thread Jan Kiszka
No functional changes. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Makefile.target|3 --- block/raw-posix.c |2 -- cutils.c |5 - dma-helpers.c |4 fpu/softfloat-native.c |1 - hw/i8259.c |5 + sysemu.h

Re: [PATCH v6 3/4] Mask function7 ebx against host capability word9

2011-06-01 Thread Avi Kivity
On 05/30/2011 06:17 PM, Yang, Wei Y wrote: This patch masks CPUID leaf 7 ebx against host capability word9. @@ -2404,6 +2408,15 @@ static void do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function, } break; } + case 7: { + /*

Re: KVM induced panic on 2.6.38[2367] 2.6.39

2011-06-01 Thread Avi Kivity
On 06/01/2011 12:29 PM, Brad Campbell wrote: On 01/06/11 14:56, Avi Kivity wrote: On 06/01/2011 09:31 AM, Brad Campbell wrote: On 01/06/11 12:52, Hugh Dickins wrote: I guess Brad could try SLUB debugging, boot with slub_debug=P for poisoning perhaps; though it might upset alignments and

Re: KVM induced panic on 2.6.38[2367] 2.6.39

2011-06-01 Thread Avi Kivity
On 06/01/2011 12:40 PM, Avi Kivity wrote: bridge and netfilter, IIRC this was also the problem last time. Do you have any ebtables loaded? Can you try building a kernel without ebtables? Without netfilter at all? Please run all tests with slub_debug=FZPU. -- error compiling

Re: [PATCH v1 0/5] KVM in-guest performance monitoring

2011-06-01 Thread Avi Kivity
On 05/17/2011 12:52 PM, Avi Kivity wrote: On 05/11/2011 06:55 PM, Avi Kivity wrote: perf maintainers: please consider the first three patches for merging (the first two make sense even without the rest). If you're familiar with the Intel PMU, please review patch 5 as well - it effectively

[PATCH RFC 1/3] virtio_ring: add capacity check API

2011-06-01 Thread Michael S. Tsirkin
Add API to check ring capacity. Because of the option to use indirect buffers, this returns the worst case, not the normal case capacity. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/virtio/virtio_ring.c |8 include/linux/virtio.h |5 + 2 files

[PATCH RFC 2/3] virtio_net: fix tx capacity checks using new API

2011-06-01 Thread Michael S. Tsirkin
In the (rare) case where new descriptors are used while virtio_net enables vq callback for the TX vq, virtio_net uses the number of sg entries in the skb it frees to calculate how many descriptors in the ring have just been made available. But this value is an overestimate: with indirect buffers

[PATCH RFC 3/3] virtio_net: limit xmit polling

2011-06-01 Thread Michael S. Tsirkin
Current code might introduce a lot of latency variation if there are many pending bufs at the time we attempt to transmit a new one. This is bad for real-time applications and can't be good for TCP either. Free up just enough to both clean up all buffers eventually and to be able to xmit the next

[PATCH RFC 0/3] virtio and vhost-net capacity handling

2011-06-01 Thread Michael S. Tsirkin
OK, here's a new attempt to use the new capacity api. I also added more comments to clarify the logic. Hope this is more readable. Let me know pls. This is on top of the patches applied by Rusty. Note: there are now actually 2 calls to fee_old_xmit_skbs on data path so instead of passing flag

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Alexander Graf
On 01.06.2011, at 09:30, Gerd Hoffmann wrote: Hi, 0xE000 is hard-coded in the DSDT for both piix and q35 as below. If the range is determined dynamically, the area also needs to be updated somehow dynamically. ... Name (_CRS, ResourceTemplate () ...

[PATCHv3] virtio-spec: 64 bit features, used/avail event, fixes

2011-06-01 Thread Michael S. Tsirkin
Add an option to modify the notificatin hand-off in virtio to be basically like Xen: each side published an index, the other side only triggers an event when it crosses that index value (Xen event indexes start at 1, ours start at 0 for backward-compatiblity, but that's minor). Since we've run

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Rudolf Marek
Sorry I forgot to include all addresses. I don't know how much work it would be to generate the DSDT dynamically from Qemu, but IMHO that's the sanest way to make things flexible. We could probably even extract most information from the Qdev tree. Well I have written for coreboot a ACPI

Re: [PATCH 31/31] nVMX: Documentation

2011-06-01 Thread Jan Kiszka
On 2011-05-25 22:17, Nadav Har'El wrote: This patch includes a brief introduction to the nested vmx feature in the Documentation/kvm directory. The document also includes a copy of the vmcs12 structure, as requested by Avi Kivity. Signed-off-by: Nadav Har'El n...@il.ibm.com ---

Re: [PATCH] kvm: Document KVM_IOEVENTFD

2011-06-01 Thread Jan Kiszka
On 2011-05-31 15:44, Marcelo Tosatti wrote: On Sat, May 28, 2011 at 02:12:30PM +0300, Sasha Levin wrote: Document KVM_IOEVENTFD that can be used to receive notifications of PIO/MMIO events without triggering an exit. Cc: Avi Kivity a...@redhat.com Cc: Marcelo Tosatti mtosa...@redhat.com

Re: KVM induced panic on 2.6.38[2367] 2.6.39

2011-06-01 Thread Brad Campbell
On 01/06/11 17:41, Avi Kivity wrote: On 06/01/2011 12:40 PM, Avi Kivity wrote: bridge and netfilter, IIRC this was also the problem last time. Do you have any ebtables loaded? Never heard of them, but making a cursory check just in case.. brad@srv:/raid10/src/linux-2.6.39$ grep EBTABLE

[PATCH] KVM: VMX: Silence warning on 32-bit hosts

2011-06-01 Thread Jan Kiszka
a is unused now on CONFIG_X86_32. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- arch/x86/kvm/vmx.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index b3496ef..1e7a649 100644 --- a/arch/x86/kvm/vmx.c +++

Re: KVM induced panic on 2.6.38[2367] 2.6.39

2011-06-01 Thread Avi Kivity
On 06/01/2011 01:53 PM, Brad Campbell wrote: On 01/06/11 17:41, Avi Kivity wrote: On 06/01/2011 12:40 PM, Avi Kivity wrote: bridge and netfilter, IIRC this was also the problem last time. Do you have any ebtables loaded? Never heard of them, but making a cursory check just in case..

Re: [PATCH v2 3/4] kvm tools: Use ioeventfd in virtio-net

2011-06-01 Thread Asias He
On 06/01/2011 02:35 PM, Sasha Levin wrote: On Wed, 2011-06-01 at 09:41 +0800, Asias He wrote: On 06/01/2011 12:32 AM, Sasha Levin wrote: On Tue, 2011-05-31 at 10:18 +0300, Pekka Enberg wrote: On Tue, May 31, 2011 at 2:53 AM, Asias He asias.he...@gmail.com wrote: TAP based network performance

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Avi Kivity
On 06/01/2011 12:56 PM, Alexander Graf wrote: On 01.06.2011, at 09:30, Gerd Hoffmann wrote: Hi, 0xE000 is hard-coded in the DSDT for both piix and q35 as below. If the range is determined dynamically, the area also needs to be updated somehow dynamically. ... Name

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Alexander Graf
On 01.06.2011, at 13:13, Avi Kivity wrote: On 06/01/2011 12:56 PM, Alexander Graf wrote: On 01.06.2011, at 09:30, Gerd Hoffmann wrote: Hi, 0xE000 is hard-coded in the DSDT for both piix and q35 as below. If the range is determined dynamically, the area also needs to be

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Avi Kivity
On 06/01/2011 02:16 PM, Alexander Graf wrote: Generating the DSDT dynamically is hard, but the DSDT itself is dynamic. You can make any function talk to the firmware configuration interface and return results that depend on the information there. Does that hold true for nodes as well? I

Re: [PATCH v1 0/5] KVM in-guest performance monitoring

2011-06-01 Thread Avi Kivity
On 06/01/2011 01:26 PM, Peter Zijlstra wrote: Re-ping? Still struggling with merge window fallout, this is soon after that. Thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: KVM induced panic on 2.6.38[2367] 2.6.39

2011-06-01 Thread CaT
On Wed, Jun 01, 2011 at 06:53:31PM +0800, Brad Campbell wrote: I rebooted into a netfilter kernel, and did all the steps I'd used on the no-netfilter kernel and it ticked along happily. So the result of the experiment is inconclusive. Having said that, the backtraces certainly smell

Re: KVM induced panic on 2.6.38[2367] 2.6.39

2011-06-01 Thread Brad Campbell
On 01/06/11 19:18, CaT wrote: On Wed, Jun 01, 2011 at 06:53:31PM +0800, Brad Campbell wrote: I rebooted into a netfilter kernel, and did all the steps I'd used on the no-netfilter kernel and it ticked along happily. So the result of the experiment is inconclusive. Having said that, the

Re: [PATCH v1 0/5] KVM in-guest performance monitoring

2011-06-01 Thread Peter Zijlstra
On Wed, 2011-06-01 at 12:45 +0300, Avi Kivity wrote: On 05/17/2011 12:52 PM, Avi Kivity wrote: On 05/11/2011 06:55 PM, Avi Kivity wrote: perf maintainers: please consider the first three patches for merging (the first two make sense even without the rest). If you're familiar with the

Re: [Patch v4 2/4] Add SMEP handling when setting CR4

2011-06-01 Thread Marcelo Tosatti
On Tue, May 31, 2011 at 10:03:26PM +0300, Avi Kivity wrote: On 05/31/2011 09:48 PM, Marcelo Tosatti wrote: On Tue, May 31, 2011 at 09:05:35PM +0300, Avi Kivity wrote: if (is_long_mode(vcpu)) { if (!(cr4 X86_CR4_PAE)) return 1; A

[PATCH 0/2] Kill decode_cache

2011-06-01 Thread Avi Kivity
This mostly mindless patchset folds decode_cache into its enclosing struct, x86_emulate_context. The point is to remove tons of pointless struct decode_cache *c = ctxt-decode; lines from the code, which contribute absolutely nothing. Avi Kivity (2): KVM: x86 emulator: rename

[PATCH 1/2] KVM: x86 emulator: rename decode_cache::eip to _eip

2011-06-01 Thread Avi Kivity
The name eip conflicts with a field of the same name in x86_emulate_ctxt, which we plan to fold decode_cache into. The name _eip is unfortunate, but what's really needed is a refactoring here, not a better name. Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/include/asm/kvm_emulate.h |

Re: [Patch v4 2/4] Add SMEP handling when setting CR4

2011-06-01 Thread Avi Kivity
On 06/01/2011 03:32 PM, Marcelo Tosatti wrote: On Tue, May 31, 2011 at 10:03:26PM +0300, Avi Kivity wrote: On 05/31/2011 09:48 PM, Marcelo Tosatti wrote: On Tue, May 31, 2011 at 09:05:35PM +0300, Avi Kivity wrote: if (is_long_mode(vcpu)) { if (!(cr4

Re: [PATCH 0/2] Kill decode_cache

2011-06-01 Thread Gleb Natapov
On Wed, Jun 01, 2011 at 03:34:23PM +0300, Avi Kivity wrote: This mostly mindless patchset folds decode_cache into its enclosing struct, x86_emulate_context. The point is to remove tons of pointless struct decode_cache *c = ctxt-decode; lines from the code, which contribute

Re: [PATCH 0/2] Kill decode_cache

2011-06-01 Thread Avi Kivity
On 06/01/2011 03:47 PM, Gleb Natapov wrote: On Wed, Jun 01, 2011 at 03:34:23PM +0300, Avi Kivity wrote: This mostly mindless patchset folds decode_cache into its enclosing struct, x86_emulate_context. The point is to remove tons of pointless struct decode_cache *c =ctxt-decode;

[PATCH v7 0/4] Enable SMEP feature support for KVM

2011-06-01 Thread Yang, Wei Y
This patchset enables a new CPU feature SMEP (Supervisor Mode Execution Protection) in KVM. SMEP prevents kernel from executing code in application. Updated Intel SDM describes this CPU feature. The document will be published soon. This patchset is based on Fenghua's SMEP patch series, as

[PATCH v7 1/4] Remove SMEP bit from CR4_RESERVED_BITS

2011-06-01 Thread Yang, Wei Y
This patch removes SMEP bit from CR4_RESERVED_BITS. Signed-off-by: Yang, Wei wei.y.y...@intel.com Signed-off-by: Shan, Haitao haitao.s...@intel.com Signed-off-by: Li, Xin xin...@intel.com --- arch/x86/include/asm/kvm_host.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH v7 2/4] Add SMEP support when setting CR4

2011-06-01 Thread Yang, Wei Y
This patch adds SMEP handling when setting CR4. Signed-off-by: Yang, Wei wei.y.y...@intel.com Signed-off-by: Shan, Haitao haitao.s...@intel.com Signed-off-by: Li, Xin xin...@intel.com --- arch/x86/kvm/x86.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff

[PATCH v7 3/4] Mask function7 ebx against host capability word9

2011-06-01 Thread Yang, Wei Y
This patch masks CPUID leaf 7 ebx against host capability word9. Signed-off-by: Yang, Wei wei.y.y...@intel.com Signed-off-by: Shan, Haitao haitao.s...@intel.com Signed-off-by: Li, Xin xin...@intel.com --- arch/x86/kvm/x86.c | 21 - 1 files changed, 20 insertions(+), 1

[PATCH v7 4/4] Add instruction fetch checking when walking guest page table

2011-06-01 Thread Yang, Wei Y
This patch adds instruction fetch checking when walking guest page table. Signed-off-by: Yang, Wei wei.y.y...@intel.com Signed-off-by: Shan, Haitao haitao.s...@intel.com Signed-off-by: Li, Xin xin...@intel.com --- arch/x86/kvm/paging_tmpl.h |9 - 1 files changed, 8

[PATCH v7] Enable CPU SMEP feature for QEMU-KVM

2011-06-01 Thread Yang, Wei Y
This patchset enables a new CPU feature SMEP (Supervisor Mode Execution Protection) in QEMU-KVM. SMEP prevents kernel from executing code in application. Updated Intel SDM describes this CPU feature. The document will be published soon. SMEP is identified by CPUID leaf 7 EBX[7], which is 0

Re: [PATCH v6] Enable CPU SMEP feature for QEMU-KVM

2011-06-01 Thread Marcelo Tosatti
On Mon, May 30, 2011 at 11:17:42PM +0800, Yang, Wei Y wrote: This patchset enables a new CPU feature SMEP (Supervisor Mode Execution Protection) in QEMU-KVM. SMEP prevents kernel from executing code in application. Updated Intel SDM describes this CPU feature. The document will be published

Re: [PATCH uq/master V3] kvm: Add CPUID support for VIA CPU

2011-06-01 Thread Marcelo Tosatti
On Wed, Jun 01, 2011 at 09:59:52AM +0800, BrillyWu wrote: From: brill...@viatech.com.cn When KVM is running on VIA CPU with host cpu's model, the feautures of VIA CPU will be passed into kvm guest by calling the CPUID instruction for Centaur. Signed-off-by: BrillyWubrill...@viatech.com.cn

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

2011-06-01 Thread Vivek Goyal
On Tue, May 31, 2011 at 06:30:09PM -0500, Anthony Liguori wrote: [..] The level of consistency will then depend on whether you overcommit your hardware and how you have it configured. Agreed. Consistency is very hard because at the end of the day, you still have shared resources. Even

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

2011-06-01 Thread Vivek Goyal
On Wed, Jun 01, 2011 at 11:19:58AM +0800, Zhi Yong Wu wrote: On Tue, May 31, 2011 at 03:55:49PM -0400, Vivek Goyal wrote: Date: Tue, 31 May 2011 15:55:49 -0400 From: Vivek Goyal vgo...@redhat.com To: Zhi Yong Wu wu...@linux.vnet.ibm.com Cc: kw...@redhat.com, aligu...@us.ibm.com,

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Gerd Hoffmann
On 06/01/11 12:20, Rudolf Marek wrote: Sorry I forgot to include all addresses. I don't know how much work it would be to generate the DSDT dynamically from Qemu, but IMHO that's the sanest way to make things flexible. We could probably even extract most information from the Qdev tree. Well

Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface

2011-06-01 Thread Richard Henderson
On 05/31/2011 06:38 PM, Eduard - Gabriel Munteanu wrote: +static inline void dma_memory_rw(DMADevice *dev, + dma_addr_t addr, + void *buf, + dma_addr_t len, + int

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Isaku Yamahata
On Wed, Jun 01, 2011 at 09:30:12AM +0200, Gerd Hoffmann wrote: Hi, 0xE000 is hard-coded in the DSDT for both piix and q35 as below. If the range is determined dynamically, the area also needs to be updated somehow dynamically. ... Name (_CRS, ResourceTemplate () ...

Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface

2011-06-01 Thread Avi Kivity
On 06/01/2011 05:01 PM, Richard Henderson wrote: +err = dev-mmu-translate(dev, addr,paddr,plen, is_write); I see you didn't take my suggestion for using an opaque callback pointer. Really and truly, I won't be able to use this as-is for Alpha. Rather than opaques, please pass the

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Jan Kiszka
On 2011-06-01 16:20, Isaku Yamahata wrote: On Wed, Jun 01, 2011 at 09:30:12AM +0200, Gerd Hoffmann wrote: Hi, 0xE000 is hard-coded in the DSDT for both piix and q35 as below. If the range is determined dynamically, the area also needs to be updated somehow dynamically. ...

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Alex Williamson
On Wed, 2011-06-01 at 16:31 +0200, Jan Kiszka wrote: On 2011-06-01 16:20, Isaku Yamahata wrote: On Wed, Jun 01, 2011 at 09:30:12AM +0200, Gerd Hoffmann wrote: Hi, 0xE000 is hard-coded in the DSDT for both piix and q35 as below. If the range is determined dynamically, the area also

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Rudolf Marek
Having a brief look at the coreboot code it seems static stuff (compiled by iasl) and dynamic bits are combined into the final dsdt table, is that correct? Yes the dsdt is static, it has just external references to ssdt which is dynamically generated using the acpigen. Acpigen can generate

Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface

2011-06-01 Thread Eduard - Gabriel Munteanu
On Wed, Jun 01, 2011 at 07:01:42AM -0700, Richard Henderson wrote: On 05/31/2011 06:38 PM, Eduard - Gabriel Munteanu wrote: +static inline void dma_memory_rw(DMADevice *dev, + dma_addr_t addr, + void *buf, +

[PATCH] kvm tools: Add support for PS/2 keyboard system

2011-06-01 Thread Sasha Levin
From: John Floren j...@jfloren.net Add support for PS/2 keyboard system with AUX device (aka mouse). The device works with vnc, the guest must be started with the '--vnc' parameter for the device to be initialized. Signed-off-by: John Floren j...@jfloren.net [ turn into patch and clean up code ]

Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface

2011-06-01 Thread Richard Henderson
On 06/01/2011 07:52 AM, Eduard - Gabriel Munteanu wrote: The main selling point is there are more chances to screw up if every bus layer implements these manually. And it's really convenient, especially if we get to add another ld/st. If we drop the ld/st, we're talking about 5 lines for every

[PATCH] kvm tools: Use vesa reserved space for strings and modes

2011-06-01 Thread Sasha Levin
As defined in the spec, the reserved space in struct vesa_general_info should be used to store vesa oem string an a list of possible modes. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/bios/int10.c | 27 ++- 1 files changed, 14 insertions(+), 13

Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface

2011-06-01 Thread Richard Henderson
On 06/01/2011 07:29 AM, Avi Kivity wrote: On 06/01/2011 05:01 PM, Richard Henderson wrote: +err = dev-mmu-translate(dev, addr,paddr,plen, is_write); I see you didn't take my suggestion for using an opaque callback pointer. Really and truly, I won't be able to use this as-is for

Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface

2011-06-01 Thread Eduard - Gabriel Munteanu
On Wed, Jun 01, 2011 at 08:09:29AM -0700, Richard Henderson wrote: On 06/01/2011 07:52 AM, Eduard - Gabriel Munteanu wrote: The main selling point is there are more chances to screw up if every bus layer implements these manually. And it's really convenient, especially if we get to add

Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface

2011-06-01 Thread Richard Henderson
On 06/01/2011 08:35 AM, Eduard - Gabriel Munteanu wrote: Maybe it's not nice, but you're missing the fact upcasting gives you some type safety. With opaques you have none. Lol. Do you understand what container_of does? This is not dynamic_cast with RTTI. You can put any type name in there

[PATCH 0/2] [PULL] qemu-kvm.git uq/master queue

2011-06-01 Thread Marcelo Tosatti
The following changes since commit 578c7b2ca8ee9e97fa8693b1a83d517e8e3f962e: audio: fix integer overflow expression (2011-06-01 00:14:07 +0400) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Yang, Wei Y (1): kvm: Enable CPU SMEP

[PATCH 2/2] kvm: Enable CPU SMEP feature

2011-06-01 Thread Marcelo Tosatti
From: Yang, Wei Y wei.y.y...@intel.com This patchset enables a new CPU feature SMEP (Supervisor Mode Execution Protection) in QEMU-KVM. SMEP prevents kernel from executing code in application. Updated Intel SDM describes this CPU feature. The document will be published soon. SMEP is identified

[PATCH 1/2] kvm: Add CPUID support for VIA CPU

2011-06-01 Thread Marcelo Tosatti
From: brill...@viatech.com.cn brill...@viatech.com.cn When KVM is running on VIA CPU with host cpu's model, the feautures of VIA CPU will be passed into kvm guest by calling the CPUID instruction for Centaur. Signed-off-by: BrillyWubrill...@viatech.com.cn Signed-off-by:

Re: [Qemu-devel] [RFC PATCH 00/13] AMD IOMMU emulation patches, another try

2011-06-01 Thread Richard Henderson
On 05/31/2011 06:38 PM, Eduard - Gabriel Munteanu wrote: Hi, Again, sorry for taking so long, but I just don't send stuff without looking through it. This is meant to go into Michael's PCI branch, if it does. Some of the changes include: - some fixes (one thanks to David Gibson) and

[PATCH v2] kvm tools: Add QCOW level2 caching support

2011-06-01 Thread Prasad Joshi
QCOW uses two tables level1 (L1) table and level2 (L2) table. The L1 table points to offset of L2 table. When a QCOW image is probed, the L1 table is cached in the memory to avoid reading it from disk on every access. This caching improves the performance. The similar performance improvement can

Re: [Autotest] [PATCH 0/4] Make possible to run client tests as subtests

2011-06-01 Thread Lucas Meneghel Rodrigues
Ok, I have applied patches from 1 to 3, after verifying the unittests. I haven't applied patch 4, as this would bring some loss of functionality of the current netperf test. I count on you guys (Jiri and Lukas) to write the tests that actually use the functionality. Cheers, On Tue, May 24, 2011

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

2011-06-01 Thread Stefan Hajnoczi
On Wed, Jun 1, 2011 at 2:20 PM, Vivek Goyal vgo...@redhat.com wrote: On Tue, May 31, 2011 at 06:30:09PM -0500, Anthony Liguori wrote: [..] The level of consistency will then depend on whether you overcommit your hardware and how you have it configured. Agreed. Consistency is very hard

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

2011-06-01 Thread Vivek Goyal
On Wed, Jun 01, 2011 at 10:15:30PM +0100, Stefan Hajnoczi wrote: On Wed, Jun 1, 2011 at 2:20 PM, Vivek Goyal vgo...@redhat.com wrote: On Tue, May 31, 2011 at 06:30:09PM -0500, Anthony Liguori wrote: [..] The level of consistency will then depend on whether you overcommit your hardware

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Kevin O'Connor
On Wed, Jun 01, 2011 at 04:40:15PM +0200, Rudolf Marek wrote: Having a brief look at the coreboot code it seems static stuff (compiled by iasl) and dynamic bits are combined into the final dsdt table, is that correct? Yes the dsdt is static, it has just external references to ssdt which is

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

2011-06-01 Thread Stefan Hajnoczi
On Wed, Jun 1, 2011 at 10:42 PM, Vivek Goyal vgo...@redhat.com wrote: On Wed, Jun 01, 2011 at 10:15:30PM +0100, Stefan Hajnoczi wrote: One issue that concerns me is how effective iops and throughput are as capping mechanisms.  If you cap throughput then you're likely to affect sequential I/O

Re: [SeaBIOS] Graphics card pass-through working with two pass pci-initialization

2011-06-01 Thread Kevin O'Connor
On Wed, Jun 01, 2011 at 11:20:29PM +0900, Isaku Yamahata wrote: On Wed, Jun 01, 2011 at 09:30:12AM +0200, Gerd Hoffmann wrote: Hi, 0xE000 is hard-coded in the DSDT for both piix and q35 as below. If the range is determined dynamically, the area also needs to be updated somehow

Re: KVM induced panic on 2.6.38[2367] 2.6.39

2011-06-01 Thread CaT
On Wed, Jun 01, 2011 at 07:52:33PM +0800, Brad Campbell wrote: Unfortunately the only interface that is mentioned by name anywhere in my firewall is $DMZ (which is ppp0 and not part of any bridge). All of the nat/dnat and other horrible hacks are based on IP addresses. Damn. Not referencing

Re: [PATCHv3] virtio-spec: 64 bit features, used/avail event, fixes

2011-06-01 Thread Rusty Russell
On Wed, 1 Jun 2011 13:25:48 +0300, Michael S. Tsirkin m...@redhat.com wrote: Add an option to modify the notificatin hand-off in virtio to be basically like Xen: each side published an index, the other side only triggers an event when it crosses that index value (Xen event indexes start at 1,

Re: [PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index

2011-06-01 Thread Rusty Russell
On Wed, 1 Jun 2011 03:24:29 -0400, Mark Wu d...@redhat.com wrote: Current index allocation in virtio-blk is based on a monotonically increasing variable index. It could cause some confusion about disk name in the case of hot-plugging disks. And it's impossible to find the lowest available

Looking to contribute

2011-06-01 Thread samriti katoch
Hi, We were looking to contribute to the KVM development and wanted to check if someone is working on this item listed in the KVM to-do: Improve mmu page eviction algorithm (currently FIFO, change to approximate LRU). Thanks! -- To unsubscribe from this list: send the line unsubscribe kvm in the

Re: [PATCH RFC 1/3] virtio_ring: add capacity check API

2011-06-01 Thread Rusty Russell
On Wed, 1 Jun 2011 12:49:46 +0300, Michael S. Tsirkin m...@redhat.com wrote: Add API to check ring capacity. Because of the option to use indirect buffers, this returns the worst case, not the normal case capacity. Can we drop the silly add_buf() returns capacity hack then? Thanks, Rusty. --

Re: [PATCH RFC 3/3] virtio_net: limit xmit polling

2011-06-01 Thread Rusty Russell
On Wed, 1 Jun 2011 12:50:03 +0300, Michael S. Tsirkin m...@redhat.com wrote: Current code might introduce a lot of latency variation if there are many pending bufs at the time we attempt to transmit a new one. This is bad for real-time applications and can't be good for TCP either. Free up

Re: [PATCH RFC 2/3] virtio_net: fix tx capacity checks using new API

2011-06-01 Thread Rusty Russell
On Wed, 1 Jun 2011 12:49:54 +0300, Michael S. Tsirkin m...@redhat.com wrote: In the (rare) case where new descriptors are used while virtio_net enables vq callback for the TX vq, virtio_net uses the number of sg entries in the skb it frees to calculate how many descriptors in the ring have

[PATCH 0/5] Create private bridge, get rid of qemu ifup scripts v3

2011-06-01 Thread Lucas Meneghel Rodrigues
This patchset changes the default of KVM autotest networking to use TAP, and create a private bridge, that behaves very much like the libvirt bridge, making KVM autotest users to have a nw setup much closer to a real life scenario. The last bugs observed were ironed out, the patchset now works

[PATCH 1/5] KVM test: Adding framework code to control bridge creation

2011-06-01 Thread Lucas Meneghel Rodrigues
Provide in framework utility code to control the creation of a bridge, in order to provide TAP functionality for autotest users without relying on previous setup made by the user. This is a reimplementation of Amos's code, the differences are: * Implemented as a setup class, taking advantage of

[PATCH 2/5] KVM test: Add helpers to control the TAP/bridge

2011-06-01 Thread Lucas Meneghel Rodrigues
This patch adds some helpers to assist virt test to setup the bridge or macvtap based guest networking. Changes from v1: * Fixed undefined variable errors on the exception class definitions Changes from v2: * On RHEL5, the io operation TUNGETFEATURES = 0x800454cf may return an integer bigger

[PATCH 3/5] KVM test: virt_env_process: Setup private bridge during postprocessing

2011-06-01 Thread Lucas Meneghel Rodrigues
Call bridge setup at preprocessing and cleanup at postprocessing. The bridge can be cleaned up when no tap interfaces are using it. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/virt/virt_env_process.py |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff

[PATCH 4/5] KVM test: setup tap fd and pass it to qemu-kvm v3

2011-06-01 Thread Lucas Meneghel Rodrigues
We used to use qemu-ifup to manage the tap which have several limitations: 1) If we want to specify a bridge, we must create a customized qemu-ifup file as the default script always match the first bridge. 2) It's hard to add support for macvtap device. So this patch let kvm subtest control the

[PATCH 5/5] KVM test: Changing KVM autotest default to private bridge

2011-06-01 Thread Lucas Meneghel Rodrigues
Rather than the unsupported userspace mode, which still is an option. This way we are giving users a default setup much closer to a real world usage scenario, and enable people to run all the network tests that don't work properly in user mode. Signed-off-by: Lucas Meneghel Rodrigues