Re: [PATCH v6 11/15] nEPT: Add nEPT violation/misconfigration support

2013-08-02 Thread Xiao Guangrong
On 08/01/2013 10:08 PM, Gleb Natapov wrote: From: Yang Zhang yang.z.zh...@intel.com Inject nEPT fault to L1 guest. This patch is original from Xinhao. Reviewed-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a

Re: [PATCH v6 12/15] nEPT: MMU context for nested EPT

2013-08-02 Thread Xiao Guangrong
On 08/01/2013 10:08 PM, Gleb Natapov wrote: From: Nadav Har'El n...@il.ibm.com KVM's existing shadow MMU code already supports nested TDP. To use it, we need to set up a new MMU context for nested EPT, and create a few callbacks for it (nested_ept_*()). This context should also use the EPT

Re

2013-08-02 Thread Email Helpdesk Center
Dear Email User, Your Mailbox Has Exceeded It Storage Limit As Set By Your Email Administrator, And You Will Not Be Able To Receive New Mails Until You Re-Validate It. Click Here http://tututw.phpforms.net/f/firstform and Login to your email account to Activate it. Webmail Help Desk Center.

Re: [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte

2013-08-02 Thread “tiejun.chen”
On 08/01/2013 07:12 PM, Bharat Bhushan wrote: KVM uses same WIM tlb attributes as the corresponding qemu pte. For this we now search the linux pte for the requested page and get these cache caching/coherency attributes from pte. Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com ---

Re: kernel 3.10.1 - NMI received for unknown reason

2013-08-02 Thread Stefan Pietsch
On 31.07.2013 11:20, Gleb Natapov wrote: On Wed, Jul 31, 2013 at 11:10:01AM +0200, Stefan Pietsch wrote: On 30.07.2013 07:31, Gleb Natapov wrote: What happen if you run perf on your host (perf record -a)? Do you see same NMI messages? It seems that perf record -a triggers some delayed NMI

Re: [PATCH v6 14/15] nEPT: Some additional comments

2013-08-02 Thread Xiao Guangrong
On 08/01/2013 10:08 PM, Gleb Natapov wrote: From: Nadav Har'El n...@il.ibm.com Some additional comments to preexisting code: Explain who (L0 or L1) handles EPT violation and misconfiguration exits. Don't mention shadow on either EPT or shadow as the only two options. Reviewed-by: Xiao

[Bug 60679] New: L2 can't boot up when creating L1 with '-cpu host' qemu option

2013-08-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60679 Bug ID: 60679 Summary: L2 can't boot up when creating L1 with '-cpu host' qemu option Product: Virtualization Version: unspecified Kernel Version: 3.11.0-RC1 Hardware:

Re: [PATCH v6 01/15] nEPT: Support LOAD_IA32_EFER entry/exit controls for L1

2013-08-02 Thread Jan Kiszka
On 2013-08-02 05:04, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-01: From: Nadav Har'El n...@il.ibm.com Recent KVM, since http://kerneltrap.org/mailarchive/linux-kvm/2010/5/2/6261577 switch the EFER MSR when EPT is used and the host and guest have different NX bits. So if we add

Re: [PATCH 3/6 v2] kvm: powerpc: allow guest control G attribute in mas2

2013-08-02 Thread “tiejun.chen”
On 08/01/2013 07:12 PM, Bharat Bhushan wrote: G bit in MAS2 indicates whether the page is Guarded. There is no reason to stop guest setting E, so allow him. Could we merge patch 2 and 3 into only one. Tiejun Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com --- v1-v2 - no

Re: [PATCH v6 15/15] nEPT: Miscelleneous cleanups

2013-08-02 Thread Xiao Guangrong
On 08/01/2013 10:08 PM, Gleb Natapov wrote: From: Nadav Har'El n...@il.ibm.com Some trivial code cleanups not really related to nested EPT. Reviewed-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

KVM Test report, kernel bf640876... qemu 0779caeb...

2013-08-02 Thread Ren, Yongjie
Hi All, This is KVM upstream test result against kvm.git next branch and qemu-kvm.git uq/master branch. kvm.git next branch: bf640876e21fe603f7f52b0c27d66b7716da0384  based on kernel 3.11.0-rc1 qemu-kvm.git uq/master branch: 0779caeb1a17f4d3ed14e2925b36ba09b084fb7b We found

RE: [PATCH v6 01/15] nEPT: Support LOAD_IA32_EFER entry/exit controls for L1

2013-08-02 Thread Zhang, Yang Z
Jan Kiszka wrote on 2013-08-02: On 2013-08-02 05:04, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-01: From: Nadav Har'El n...@il.ibm.com Recent KVM, since http://kerneltrap.org/mailarchive/linux-kvm/2010/5/2/6261577 switch the EFER MSR when EPT is used and the host and guest have

Re: [PATCH v6 01/15] nEPT: Support LOAD_IA32_EFER entry/exit controls for L1

2013-08-02 Thread Jan Kiszka
On 2013-08-02 09:27, Zhang, Yang Z wrote: Jan Kiszka wrote on 2013-08-02: On 2013-08-02 05:04, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-01: From: Nadav Har'El n...@il.ibm.com Recent KVM, since http://kerneltrap.org/mailarchive/linux-kvm/2010/5/2/6261577 switch the EFER MSR when

Re: [PATCH v6 10/15] nEPT: Nested INVEPT

2013-08-02 Thread Xiao Guangrong
On 08/01/2013 10:08 PM, Gleb Natapov wrote: +/* Emulate the INVEPT instruction */ +static int handle_invept(struct kvm_vcpu *vcpu) +{ + u32 vmx_instruction_info; + bool ok; + unsigned long type; + gva_t gva; + struct x86_exception e; + struct { + u64

Re: [PATCH v6 13/15] nEPT: Advertise EPT to L1

2013-08-02 Thread Xiao Guangrong
On 08/01/2013 10:08 PM, Gleb Natapov wrote: From: Nadav Har'El n...@il.ibm.com Advertise the support of EPT to the L1 guest, through the appropriate MSR. This is the last patch of the basic Nested EPT feature, so as to allow bisection through this patch series: The guest will not see EPT

Re: [PATCH RFC V11 15/18] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor

2013-08-02 Thread Ingo Molnar
* Raghavendra K T raghavendra...@linux.vnet.ibm.com wrote: On 08/01/2013 02:34 PM, Raghavendra K T wrote: On 08/01/2013 01:15 PM, Gleb Natapov wrote: Shall I consider this as an ack for kvm part? For everything except 18/18. For that I still want to see numbers. But 18/18 is pretty

Re: [PATCH v6 02/15] nEPT: Fix cr3 handling in nested exit and entry

2013-08-02 Thread Xiao Guangrong
On 08/01/2013 10:08 PM, Gleb Natapov wrote: From: Nadav Har'El n...@il.ibm.com The existing code for handling cr3 and related VMCS fields during nested exit and entry wasn't correct in all cases: If L2 is allowed to control cr3 (and this is indeed the case in nested EPT), during nested

Re: [PATCH RFC V11 15/18] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor

2013-08-02 Thread Ingo Molnar
* Raghavendra K T raghavendra...@linux.vnet.ibm.com wrote: On 07/31/2013 11:54 AM, Gleb Natapov wrote: On Tue, Jul 30, 2013 at 10:13:12PM +0530, Raghavendra K T wrote: On 07/25/2013 03:08 PM, Raghavendra K T wrote: On 07/25/2013 02:45 PM, Gleb Natapov wrote: On Thu, Jul 25, 2013 at

Re: [PATCH RFC V11 15/18] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor

2013-08-02 Thread Raghavendra K T
On 08/02/2013 02:53 PM, Ingo Molnar wrote: * Raghavendra K T raghavendra...@linux.vnet.ibm.com wrote: On 08/01/2013 02:34 PM, Raghavendra K T wrote: On 08/01/2013 01:15 PM, Gleb Natapov wrote: Shall I consider this as an ack for kvm part? For everything except 18/18. For that I still want

Re: [PATCH RFC V11 15/18] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor

2013-08-02 Thread Gleb Natapov
On Fri, Aug 02, 2013 at 11:25:39AM +0200, Ingo Molnar wrote: Ingo, Do you have any concerns reg this series? please let me know if this looks good now to you. I'm inclined to NAK it for excessive quotation - who knows how many people left the discussion in disgust? Was it done to

Re: [PATCH v6 10/15] nEPT: Nested INVEPT

2013-08-02 Thread Gleb Natapov
On Fri, Aug 02, 2013 at 04:06:00PM +0800, Xiao Guangrong wrote: On 08/01/2013 10:08 PM, Gleb Natapov wrote: +/* Emulate the INVEPT instruction */ +static int handle_invept(struct kvm_vcpu *vcpu) +{ + u32 vmx_instruction_info; + bool ok; + unsigned long type; + gva_t gva;

[Bug 60620] guest loses frequently (multiple times per day!) connectivity to network device

2013-08-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60620 --- Comment #7 from Folkert van Heusden folk...@vanheusden.com --- Moments ago an other(!) guest on this system lost its connectivity. I did a tcpdump on its network interface from within the host/hypervisor/dom0 and saw that traffic goes in but

Re: [PATCH RFC V11 15/18] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor

2013-08-02 Thread Raghavendra K T
On 08/02/2013 03:24 PM, Gleb Natapov wrote: On Fri, Aug 02, 2013 at 11:25:39AM +0200, Ingo Molnar wrote: Ingo, Do you have any concerns reg this series? please let me know if this looks good now to you. I'm inclined to NAK it for excessive quotation - who knows how many people left the

[Bug 60620] guest loses frequently (multiple times per day!) connectivity to network device

2013-08-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60620 --- Comment #8 from Folkert van Heusden folk...@vanheusden.com --- And now the firewall lost connectivity again. - I removed all iptables rules and set the default to ACCEPT - from within the guest I started tcpdump - from the host I started ping

Re: FAQ on linux-kvm.org has broken link

2013-08-02 Thread folkert
Hi, If the result is #2, check firewalls on host and guest. Also try the following inside the guest: disable the network interface, rmmod virtio_net, modprobe virtio_net again, and bring the network up. I pinged, I sniffed, I updated the bug report (it also happens with other guests now!).

Re: KVM Test report, kernel bf640876... qemu 0779caeb...

2013-08-02 Thread Gleb Natapov
On Fri, Aug 02, 2013 at 07:19:28AM +, Ren, Yongjie wrote: Hi All, This is KVM upstream test result against kvm.git next branch and qemu-kvm.git uq/master branch. kvm.git next branch: bf640876e21fe603f7f52b0c27d66b7716da0384  based on kernel 3.11.0-rc1 qemu-kvm.git

Re: [Bug 60620] guest loses frequently (multiple times per day!) connectivity to network device

2013-08-02 Thread Stefan Hajnoczi
On Fri, Aug 02, 2013 at 11:28:45AM +, bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=60620 --- Comment #9 from Folkert van Heusden folk...@vanheusden.com --- Good news! If I - bring down all interfaces in the guest (ifdown eth0...) - rmmod

Re: [Qemu-devel] KVM call agenda for 2013-08-06

2013-08-02 Thread Eduardo Habkost
On Tue, Jul 23, 2013 at 06:31:45PM +0200, Juan Quintela wrote: Hi Please, send any topic that you are interested in covering. * libvirt requirements for: * Checking which CPU features are exposed/required by each CPU model + machine-type * Checking which CPU features are

Re: [PATCH 03/12] KVM: MMU: lazily drop large spte

2013-08-02 Thread Marcelo Tosatti
On Tue, Jul 30, 2013 at 09:02:01PM +0800, Xiao Guangrong wrote: Currently, kvm zaps the large spte if write-protected is needed, the later read can fault on that spte. Actually, we can make the large spte readonly instead of making them un-present, the page fault caused by read access can be

Re: FAQ on linux-kvm.org has broken link

2013-08-02 Thread Stefan Hajnoczi
On Fri, Aug 2, 2013 at 1:37 PM, folkert folk...@vanheusden.com wrote: If the result is #2, check firewalls on host and guest. Also try the following inside the guest: disable the network interface, rmmod virtio_net, modprobe virtio_net again, and bring the network up. I pinged, I sniffed, I

Re: [PATCH 03/12] KVM: MMU: lazily drop large spte

2013-08-02 Thread Xiao Guangrong
On Aug 2, 2013, at 10:55 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Tue, Jul 30, 2013 at 09:02:01PM +0800, Xiao Guangrong wrote: Currently, kvm zaps the large spte if write-protected is needed, the later read can fault on that spte. Actually, we can make the large spte readonly

Re: RFC: vfio-pci API for PCI bus/slot (hot) resets

2013-08-02 Thread Alex Williamson
On Fri, 2013-08-02 at 15:10 +1000, Benjamin Herrenschmidt wrote: On Thu, 2013-08-01 at 16:18 -0600, Alex Williamson wrote: vfio-pci needs to support an interface to do hot resets (PCI parent bridge secondary bus reset). We need this to support reset of co-assigned devices where one or

Re: FAQ on linux-kvm.org has broken link

2013-08-02 Thread folkert
Hi Stefan, I pinged, I sniffed, I updated the bug report (it also happens with other guests now!). And the bring down interfaces / rmmod / modprobe / ifup works! So I think something is wrong with virtio_net! What shall I do now? I wrote a reply earlier today but it was

Re: RFC: vfio-pci API for PCI bus/slot (hot) resets

2013-08-02 Thread Benjamin Herrenschmidt
On Fri, 2013-08-02 at 10:36 -0600, Alex Williamson wrote: Also in some cases, at least for us, we have a problem where the scope of the reset can be larger than the group ... in this case I think we need to forbid the reset. Interesting, I would have ventured to guess that resets are

Re: RFC: vfio-pci API for PCI bus/slot (hot) resets

2013-08-02 Thread Bjorn Helgaas
[+cc linux-pci] On Fri, Aug 2, 2013 at 3:28 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: Right. Another use case is, I know of devices that need a fundamental reset (PERST) after applying a FW update. This is a tangent from the real discussion here, but the question of resetting

Re: [PATCH 03/12] KVM: MMU: lazily drop large spte

2013-08-02 Thread Marcelo Tosatti
On Fri, Aug 02, 2013 at 11:42:19PM +0800, Xiao Guangrong wrote: On Aug 2, 2013, at 10:55 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Tue, Jul 30, 2013 at 09:02:01PM +0800, Xiao Guangrong wrote: Currently, kvm zaps the large spte if write-protected is needed, the later read can

Re: [PATCH 03/12] KVM: MMU: lazily drop large spte

2013-08-02 Thread Xiao Guangrong
On Aug 3, 2013, at 4:27 AM, Marcelo Tosatti mtosa...@redhat.com wrote: On Fri, Aug 02, 2013 at 11:42:19PM +0800, Xiao Guangrong wrote: On Aug 2, 2013, at 10:55 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Tue, Jul 30, 2013 at 09:02:01PM +0800, Xiao Guangrong wrote: Currently, kvm

Re: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-02 Thread Scott Wood
On Thu, 2013-08-01 at 16:42 +0530, Bharat Bhushan wrote: KVM need to lookup linux pte for getting TLB attributes (WIMGE). This is similar to how book3s does. This will be used in follow-up patches. Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com --- v1-v2 - This is a new

Re: RFC: vfio-pci API for PCI bus/slot (hot) resets

2013-08-02 Thread Benjamin Herrenschmidt
On Fri, 2013-08-02 at 16:49 -0600, Bjorn Helgaas wrote: [+cc linux-pci] On Fri, Aug 2, 2013 at 3:28 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: Right. Another use case is, I know of devices that need a fundamental reset (PERST) after applying a FW update. This is a

Re: [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte

2013-08-02 Thread Scott Wood
On Thu, Aug 01, 2013 at 04:42:38PM +0530, Bharat Bhushan wrote: diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c index 17722d8..eb2 100644 --- a/arch/powerpc/kvm/booke.c +++ b/arch/powerpc/kvm/booke.c @@ -697,7 +697,7 @@ int kvmppc_vcpu_run(struct kvm_run *kvm_run, struct

Re: RFC: vfio-pci API for PCI bus/slot (hot) resets

2013-08-02 Thread Alex Williamson
On Sat, 2013-08-03 at 09:15 +1000, Benjamin Herrenschmidt wrote: On Fri, 2013-08-02 at 16:49 -0600, Bjorn Helgaas wrote: [+cc linux-pci] On Fri, Aug 2, 2013 at 3:28 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: Right. Another use case is, I know of devices that need a

Re: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-02 Thread Benjamin Herrenschmidt
On Fri, 2013-08-02 at 17:58 -0500, Scott Wood wrote: What about 64-bit PTEs on 32-bit kernels? In any case, this code does not belong in KVM. It should be in the main PPC mm code, even if KVM is the only user. Also don't we do similar things in BookS KVM ? At the very least that sutff

Re: RFC: vfio-pci API for PCI bus/slot (hot) resets

2013-08-02 Thread Benjamin Herrenschmidt
On Fri, 2013-08-02 at 17:37 -0600, Alex Williamson wrote: Yes. We have that similar issue with error handling, when the driver doesn't have the right hooks, we simulate an unplug, reset, then replug. Maybe we could provide generic helpers to do that... Devices going away and

RE: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-02 Thread Bhushan Bharat-R65777
-Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Saturday, August 03, 2013 4:47 AM To: Wood Scott-B07421 Cc: Bhushan Bharat-R65777; ag...@suse.de; kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Bhushan

RE: [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte

2013-08-02 Thread Bhushan Bharat-R65777
-Original Message- From: Wood Scott-B07421 Sent: Saturday, August 03, 2013 5:05 AM To: Bhushan Bharat-R65777 Cc: b...@kernel.crashing.org; ag...@suse.de; kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Bhushan Bharat-R65777 Subject: Re: [PATCH 6/6 v2]

Re: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-02 Thread Benjamin Herrenschmidt
On Sat, 2013-08-03 at 02:58 +, Bhushan Bharat-R65777 wrote: One of the problem I saw was that if I put this code in asm/pgtable-32.h and asm/pgtable-64.h then pte_persent() and other friend function (on which this code depends) are defined in pgtable.h. And pgtable.h includes

Re: [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte

2013-08-02 Thread Benjamin Herrenschmidt
On Sat, 2013-08-03 at 03:11 +, Bhushan Bharat-R65777 wrote: Could you explain why we need to set dirty/referenced on the PTE, when we didn't need to do that before? All we're getting from the PTE is wimg. We have MMU notifiers to take care of the page being unmapped, and we've

Re: [RFC PATCH 00/12] KVM: MMU: locklessly wirte-protect

2013-08-02 Thread Takuya Yoshikawa
On Tue, 30 Jul 2013 21:01:58 +0800 Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com wrote: Background == Currently, when mark memslot dirty logged or get dirty page, we need to write-protect large guest memory, it is the heavy work, especially, we need to hold mmu-lock which is also

Re: [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte

2013-08-02 Thread “tiejun.chen”
On 08/01/2013 07:12 PM, Bharat Bhushan wrote: KVM uses same WIM tlb attributes as the corresponding qemu pte. For this we now search the linux pte for the requested page and get these cache caching/coherency attributes from pte. Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com ---

Re: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-02 Thread “tiejun.chen”
On 08/01/2013 07:12 PM, Bharat Bhushan wrote: KVM need to lookup linux pte for getting TLB attributes (WIMGE). This is similar to how book3s does. This will be used in follow-up patches. Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com --- v1-v2 - This is a new change in this

Re: [PATCH 3/6 v2] kvm: powerpc: allow guest control G attribute in mas2

2013-08-02 Thread “tiejun.chen”
On 08/01/2013 07:12 PM, Bharat Bhushan wrote: G bit in MAS2 indicates whether the page is Guarded. There is no reason to stop guest setting E, so allow him. Could we merge patch 2 and 3 into only one. Tiejun Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com --- v1-v2 - no

Re: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-02 Thread Scott Wood
On Thu, 2013-08-01 at 16:42 +0530, Bharat Bhushan wrote: KVM need to lookup linux pte for getting TLB attributes (WIMGE). This is similar to how book3s does. This will be used in follow-up patches. Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com --- v1-v2 - This is a new

Re: [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte

2013-08-02 Thread Scott Wood
On Thu, Aug 01, 2013 at 04:42:38PM +0530, Bharat Bhushan wrote: diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c index 17722d8..eb2 100644 --- a/arch/powerpc/kvm/booke.c +++ b/arch/powerpc/kvm/booke.c @@ -697,7 +697,7 @@ int kvmppc_vcpu_run(struct kvm_run *kvm_run, struct

Re: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-02 Thread Benjamin Herrenschmidt
On Fri, 2013-08-02 at 17:58 -0500, Scott Wood wrote: What about 64-bit PTEs on 32-bit kernels? In any case, this code does not belong in KVM. It should be in the main PPC mm code, even if KVM is the only user. Also don't we do similar things in BookS KVM ? At the very least that sutff

RE: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-02 Thread Bhushan Bharat-R65777
-Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Saturday, August 03, 2013 4:47 AM To: Wood Scott-B07421 Cc: Bhushan Bharat-R65777; ag...@suse.de; kvm-ppc@vger.kernel.org; k...@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Bhushan

RE: [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte

2013-08-02 Thread Bhushan Bharat-R65777
-Original Message- From: Wood Scott-B07421 Sent: Saturday, August 03, 2013 5:05 AM To: Bhushan Bharat-R65777 Cc: b...@kernel.crashing.org; ag...@suse.de; kvm-ppc@vger.kernel.org; k...@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Bhushan Bharat-R65777 Subject: Re: [PATCH 6/6 v2]

Re: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-02 Thread Benjamin Herrenschmidt
On Sat, 2013-08-03 at 02:58 +, Bhushan Bharat-R65777 wrote: One of the problem I saw was that if I put this code in asm/pgtable-32.h and asm/pgtable-64.h then pte_persent() and other friend function (on which this code depends) are defined in pgtable.h. And pgtable.h includes

Re: [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte

2013-08-02 Thread Benjamin Herrenschmidt
On Sat, 2013-08-03 at 03:11 +, Bhushan Bharat-R65777 wrote: Could you explain why we need to set dirty/referenced on the PTE, when we didn't need to do that before? All we're getting from the PTE is wimg. We have MMU notifiers to take care of the page being unmapped, and we've