Re: [GIT PULL 05/11] KVM: s390: refactor interrupt injection code

2014-12-01 Thread Christian Borntraeger
Am 28.11.2014 um 18:16 schrieb Paolo Bonzini: On 28/11/2014 14:25, Christian Borntraeger wrote: +static int __inject_prog_irq(struct kvm_vcpu *vcpu, + struct kvm_s390_interrupt_info *inti) +{ Why the __s? :) In this case because its called with a lock already

Re: [GIT PULL 09/11] KVM: s390: add bitmap for handling cpu-local interrupts

2014-12-01 Thread Jens Freimann
Excerpts from Paolo Bonzini's message of 2014-11-28 18:18:53 +0100: On 28/11/2014 14:25, Christian Borntraeger wrote: +struct kvm_s390_irq_payload { +struct kvm_s390_io_info io; +struct kvm_s390_ext_info ext; +struct kvm_s390_pgm_info pgm; +struct

Re: [GIT PULL 10/11] KVM: s390: handle pending local interrupts via bitmap

2014-12-01 Thread Heiko Carstens
On Fri, Nov 28, 2014 at 02:25:38PM +0100, Christian Borntraeger wrote: +static int __must_check __deliver_mchk_floating(struct kvm_vcpu *vcpu, +struct kvm_s390_interrupt_info *inti) +{ + struct kvm_s390_mchk_info *mchk = inti-mchk; + int rc; +

Re: [GIT PULL 05/11] KVM: s390: refactor interrupt injection code

2014-12-01 Thread Jens Freimann
Excerpts from Paolo Bonzini's message of 2014-11-28 18:16:03 +0100: On 28/11/2014 14:25, Christian Borntraeger wrote: +static int __inject_prog_irq(struct kvm_vcpu *vcpu, + struct kvm_s390_interrupt_info *inti) +{ Why the __s? :) I used the __s here to say careful,

Re: [PATCH 1/2] arm/arm64: kvm: drop inappropriate use of kvm_is_mmio_pfn()

2014-12-01 Thread Ard Biesheuvel
On 21 November 2014 at 12:24, Christoffer Dall christoffer.d...@linaro.org wrote: On Mon, Nov 10, 2014 at 09:33:55AM +0100, Ard Biesheuvel wrote: Instead of using kvm_is_mmio_pfn() to decide whether a host region should be stage 2 mapped with device attributes, add a new static function

Re: [PATCH net-next] vhost: remove unnecessary forward declarations in vhost.h

2014-12-01 Thread Michael S. Tsirkin
On Thu, Nov 27, 2014 at 02:41:21PM +0800, Jason Wang wrote: Signed-off-by: Jason Wang jasow...@redhat.com Applied, thanks. --- drivers/vhost/vhost.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h index 3eda654..7d039ef 100644 ---

Re: [PATCH v7 28/46] vhost: make features 64 bit

2014-12-01 Thread Michael S. Tsirkin
On Mon, Dec 01, 2014 at 04:12:37AM +, Ben Hutchings wrote: On Sun, 2014-11-30 at 18:44 +0300, Sergei Shtylyov wrote: Hello. On 11/30/2014 6:11 PM, Michael S. Tsirkin wrote: We need to use bit 32 for virtio 1.0 Signed-off-by: Michael S. Tsirkin m...@redhat.com

[PATCH] kvm: x86: remove vmx_vm_has_apicv() outside of hwapic_isr_update()

2014-12-01 Thread Tiejun Chen
In most cases calling hwapic_isr_update(), actually we always check if kvm_apic_vid_enabled() == 1, and also actually, kvm_apic_vid_enabled() - kvm_x86_ops-vm_has_apicv() - vmx_vm_has_apicv() or '0' in svm case So its unnecessary to recall this inside hwapic_isr_update(), here just

Re: [PATCH net] Revert drivers/net: Disable UFO through virtio in macvtap and tun

2014-12-01 Thread Michael S. Tsirkin
On Tue, Nov 11, 2014 at 05:12:58PM +, Ben Hutchings wrote: This reverts commit 88e0e0e5aa722b193c8758c8b45d041de5316924 for the tap drivers, but leaves UFO disabled in virtio_net. libvirt at least assumes that tap features will never be dropped in new kernel versions, and doing so

Re: [GIT PULL 10/11] KVM: s390: handle pending local interrupts via bitmap

2014-12-01 Thread Jens Freimann
Excerpts from Heiko Carstens's message of 2014-12-01 09:19:16 +0100: On Fri, Nov 28, 2014 at 02:25:38PM +0100, Christian Borntraeger wrote: +static int __must_check __deliver_mchk_floating(struct kvm_vcpu *vcpu, + struct kvm_s390_interrupt_info *inti) +{ +struct

Re: [PATCH RFC 1/2] KVM: don't check for PF_VCPU when yielding

2014-12-01 Thread David Hildenbrand
On 11/28/2014 04:28 PM, Christian Borntraeger wrote: Am 28.11.2014 um 11:08 schrieb Raghavendra KT: Was able to test the patch, here is the result: I have not tested with bigger VMs though. Results make it difficult to talk about any side effect of patch if any. Thanks a log. If

Re: [PATCH 1/2] arm/arm64: kvm: drop inappropriate use of kvm_is_mmio_pfn()

2014-12-01 Thread Paolo Bonzini
On 01/12/2014 10:16, Ard Biesheuvel wrote: On 21 November 2014 at 12:24, Christoffer Dall christoffer.d...@linaro.org wrote: On Mon, Nov 10, 2014 at 09:33:55AM +0100, Ard Biesheuvel wrote: Instead of using kvm_is_mmio_pfn() to decide whether a host region should be stage 2 mapped with

Re: [RFC PATCH v2 1/2] KVM: kvm-vfio: User API for VT-d Posted-Interrupts

2014-12-01 Thread Eric Auger
On 11/25/2014 05:10 PM, Alex Williamson wrote: On Tue, 2014-11-25 at 16:01 +0100, Eric Auger wrote: On 11/25/2014 01:23 PM, Feng Wu wrote: This patch adds and documents a new attribute KVM_DEV_VFIO_DEVICE_POSTING_IRQ in KVM_DEV_VFIO_DEVICE group. This new attribute is used for VT-d

Re: [Xen-devel] [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-12-01 Thread David Vrabel
On 28/11/14 04:49, Juergen Gross wrote: On 11/27/2014 07:50 PM, Andrew Cooper wrote: XenServer uses https://github.com/xenserver/linux-3.x.pg/blob/master/master/0001-x86-xen-allow-privcmd-hypercalls-to-be-preempted.patch to deal with these issues. That patch is based on 3.10. Clever.

Re: [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-12-01 Thread David Vrabel
On 27/11/14 18:36, Luis R. Rodriguez wrote: On Thu, Nov 27, 2014 at 07:36:31AM +0100, Juergen Gross wrote: On 11/26/2014 11:26 PM, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@suse.com Some folks had reported that some xen hypercalls take a long time to complete when issued from

Re: [PATCH 2/7] KVM: arm: guest debug, define API headers

2014-12-01 Thread Alex Bennée
Christoffer Dall christoffer.d...@linaro.org writes: On Wed, Nov 26, 2014 at 03:04:10PM +, Alex Bennée wrote: Peter Maydell peter.mayd...@linaro.org writes: On 25 November 2014 at 16:10, Alex Bennée alex.ben...@linaro.org wrote: +/* Exit types which define why we did a debug exit

Re: [PATCH 4/7] KVM: arm64: guest debug, add SW break point support

2014-12-01 Thread Alex Bennée
Christoffer Dall christoffer.d...@linaro.org writes: On Tue, Nov 25, 2014 at 04:10:02PM +, Alex Bennée wrote: This adds support for SW breakpoints inserted by userspace. First we need to trap all BKPT exceptions in the hypervisor (ELS). This in controlled through the MDCR_EL2 register.

Re: [PATCH] kvm: x86: remove vmx_vm_has_apicv() outside of hwapic_isr_update()

2014-12-01 Thread Paolo Bonzini
On 01/12/2014 10:28, Tiejun Chen wrote: In most cases calling hwapic_isr_update(), actually we always check if kvm_apic_vid_enabled() == 1, and also actually, kvm_apic_vid_enabled() - kvm_x86_ops-vm_has_apicv() - vmx_vm_has_apicv() or '0' in svm case So its unnecessary to

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-12-01 Thread Alex Bennée
Christoffer Dall christoffer.d...@linaro.org writes: On Tue, Nov 25, 2014 at 04:10:03PM +, Alex Bennée wrote: This adds support for single-stepping the guest. As userspace can and will manipulate guest registers before restarting any tweaking of the registers has to occur just before

Re: [PATCH 6/7] KVM: arm64: re-factor hyp.S debug register code

2014-12-01 Thread Alex Bennée
Christoffer Dall christoffer.d...@linaro.org writes: On Tue, Nov 25, 2014 at 04:10:04PM +, Alex Bennée wrote: This is a pre-cursor to sharing the code with the guest debug support. This replaces the big macro that fishes data out of a fixed location with a more general helper macro to

Re: [PATCH 7/7] KVM: arm64: guest debug, HW assisted debug support

2014-12-01 Thread Alex Bennée
Christoffer Dall christoffer.d...@linaro.org writes: On Tue, Nov 25, 2014 at 04:10:05PM +, Alex Bennée wrote: snip --- a/arch/arm64/kvm/hyp.S +++ b/arch/arm64/kvm/hyp.S @@ -18,6 +18,7 @@ #include linux/linkage.h #include linux/kvm.h +#include uapi/asm/kvm.h #include

Re: [PATCH v7 29/46] vhost: add memory access wrappers

2014-12-01 Thread Cornelia Huck
On Sun, 30 Nov 2014 17:11:39 +0200 Michael S. Tsirkin m...@redhat.com wrote: Add guest memory access wrappers to handle virtio endianness conversions. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Jason Wang jasow...@redhat.com --- drivers/vhost/vhost.h | 31

Re: [PATCH v7 30/46] vhost/net: force len for TX to host endian

2014-12-01 Thread Cornelia Huck
On Sun, 30 Nov 2014 17:11:44 +0200 Michael S. Tsirkin m...@redhat.com wrote: vhost/net keeps a copy of some used ring but (ab)uses length field for internal house-keeping. This works because for tx used length is always 0. Suppress sparse errors: we use native endian-ness internally but never

Re: [PATCH 1/2] arm/arm64: kvm: drop inappropriate use of kvm_is_mmio_pfn()

2014-12-01 Thread Christoffer Dall
On Mon, Dec 01, 2014 at 10:54:44AM +0100, Paolo Bonzini wrote: On 01/12/2014 10:16, Ard Biesheuvel wrote: On 21 November 2014 at 12:24, Christoffer Dall christoffer.d...@linaro.org wrote: On Mon, Nov 10, 2014 at 09:33:55AM +0100, Ard Biesheuvel wrote: Instead of using

Re: [PATCH v7 30/46] vhost/net: force len for TX to host endian

2014-12-01 Thread Michael S. Tsirkin
On Mon, Dec 01, 2014 at 01:20:51PM +0100, Cornelia Huck wrote: On Sun, 30 Nov 2014 17:11:44 +0200 Michael S. Tsirkin m...@redhat.com wrote: vhost/net keeps a copy of some used ring but (ab)uses length field for internal house-keeping. This works because for tx used length is always 0.

Re: [PATCH v7 31/46] vhost: virtio 1.0 endian-ness support

2014-12-01 Thread Cornelia Huck
On Sun, 30 Nov 2014 17:11:49 +0200 Michael S. Tsirkin m...@redhat.com wrote: Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/vhost/vhost.c | 93 +++ 1 file changed, 56 insertions(+), 37 deletions(-) @@ -1113,18 +1120,19 @@

Re: [PATCH v7 32/46] vhost/net: virtio 1.0 byte swap

2014-12-01 Thread Cornelia Huck
On Sun, 30 Nov 2014 17:11:54 +0200 Michael S. Tsirkin m...@redhat.com wrote: Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/vhost/net.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com -- To unsubscribe

Re: [PATCH v7 33/46] vhost/net: larger header for virtio 1.0

2014-12-01 Thread Cornelia Huck
On Sun, 30 Nov 2014 17:11:59 +0200 Michael S. Tsirkin m...@redhat.com wrote: Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Jason Wang jasow...@redhat.com --- drivers/vhost/net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Cornelia Huck

Re: [PATCH v7 31/46] vhost: virtio 1.0 endian-ness support

2014-12-01 Thread Michael S. Tsirkin
On Mon, Dec 01, 2014 at 01:33:53PM +0100, Cornelia Huck wrote: On Sun, 30 Nov 2014 17:11:49 +0200 Michael S. Tsirkin m...@redhat.com wrote: Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/vhost/vhost.c | 93 +++ 1 file

Re: [PATCH v7 36/46] vhost/net: suppress compiler warning

2014-12-01 Thread Cornelia Huck
On Sun, 30 Nov 2014 17:12:13 +0200 Michael S. Tsirkin m...@redhat.com wrote: len is always initialized since function is called with size 0. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/vhost/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

freebsd 10 under linux with kvm and apicv

2014-12-01 Thread Vasiliy Tolstov
Hello. I found some issues with enable_apicv=Y and freebsd, does this problem solved or no? I'm have latest linux 3.10.x. -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru jabber: v...@selfip.ru -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH v7 31/46] vhost: virtio 1.0 endian-ness support

2014-12-01 Thread Cornelia Huck
On Mon, 1 Dec 2014 14:37:01 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Dec 01, 2014 at 01:33:53PM +0100, Cornelia Huck wrote: On Sun, 30 Nov 2014 17:11:49 +0200 Michael S. Tsirkin m...@redhat.com wrote: Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

Re: [PATCH v7 31/46] vhost: virtio 1.0 endian-ness support

2014-12-01 Thread Michael S. Tsirkin
On Mon, Dec 01, 2014 at 01:42:47PM +0100, Cornelia Huck wrote: On Mon, 1 Dec 2014 14:37:01 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Dec 01, 2014 at 01:33:53PM +0100, Cornelia Huck wrote: On Sun, 30 Nov 2014 17:11:49 +0200 Michael S. Tsirkin m...@redhat.com wrote:

Re: [Xen-devel] [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-12-01 Thread Luis R. Rodriguez
On Mon, Dec 01, 2014 at 11:01:18AM +, David Vrabel wrote: On 28/11/14 04:49, Juergen Gross wrote: On 11/27/2014 07:50 PM, Andrew Cooper wrote: XenServer uses https://github.com/xenserver/linux-3.x.pg/blob/master/master/0001-x86-xen-allow-privcmd-hypercalls-to-be-preempted.patch

Re: [PATCH 0/5] Improve PSCI system events and fix reboot bugs

2014-12-01 Thread Andrew Jones
On Thu, Nov 27, 2014 at 07:40:55PM +0100, Christoffer Dall wrote: Several people have reported problems with rebooting ARM VMs, especially on 32-bit ARM. This is mainly due to the same reason we were seeing boot errors in the past, namely that the ram, dcache, and icache weren't coherent on

Re: freebsd 10 under linux with kvm and apicv

2014-12-01 Thread Vasiliy Tolstov
2014-12-01 15:38 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru: Hello. I found some issues with enable_apicv=Y and freebsd, does this problem solved or no? I'm have latest linux 3.10.x. Also i'm succeseful run freebsd 10 with 1Gb memory, but failed to boot with 4gb memory. But in this case i

Re: [PATCH] KVM: Introduce dynamically registered hypercall capability

2014-12-01 Thread Radim Krčmář
2014-11-28 17:29-0800, Phil White: Good questions. One thing that prompted this code is the presence and proliferation of architecture specific hypercalls in include/uapi/linux/kvm_para.h. I'm not sure why the tree has continued on for as long as it has with a list of reserved hypercall

Re: [PATCH v7 36/46] vhost/net: suppress compiler warning

2014-12-01 Thread Michael S. Tsirkin
On Mon, Dec 01, 2014 at 01:37:40PM +0100, Cornelia Huck wrote: On Sun, 30 Nov 2014 17:12:13 +0200 Michael S. Tsirkin m...@redhat.com wrote: len is always initialized since function is called with size 0. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/vhost/net.c | 2

Re: [PATCH v7 36/46] vhost/net: suppress compiler warning

2014-12-01 Thread Cornelia Huck
On Mon, 1 Dec 2014 15:48:39 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Dec 01, 2014 at 01:37:40PM +0100, Cornelia Huck wrote: On Sun, 30 Nov 2014 17:12:13 +0200 Michael S. Tsirkin m...@redhat.com wrote: len is always initialized since function is called with size 0.

Re: [PATCH v3 3/8] VFIO: platform: forwarded state tested when selecting IRQ handler

2014-12-01 Thread Eric Auger
Hi Christoffer, On 11/30/2014 01:47 PM, Christoffer Dall wrote: The subject reads strangely, perhaps just: VFIO: platform: test forward state when selecting IRQ handler OK On Sun, Nov 23, 2014 at 07:35:55PM +0100, Eric Auger wrote: In case the IRQ is forwarded, the VFIO platform IRQ

Re: [Xen-devel] [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-12-01 Thread Juergen Gross
On 12/01/2014 02:32 PM, Luis R. Rodriguez wrote: On Mon, Dec 01, 2014 at 11:01:18AM +, David Vrabel wrote: On 28/11/14 04:49, Juergen Gross wrote: On 11/27/2014 07:50 PM, Andrew Cooper wrote: XenServer uses

Re: [PATCH v3 4/8] KVM: kvm-vfio: User API for IRQ forwarding

2014-12-01 Thread Eric Auger
On 11/30/2014 01:53 PM, Christoffer Dall wrote: On Sun, Nov 23, 2014 at 07:35:56PM +0100, Eric Auger wrote: This patch adds and document a new KVM_DEV_VFIO_DEVICE group documents OK and 2 device attributes: KVM_DEV_VFIO_DEVICE_FORWARD_IRQ, KVM_DEV_VFIO_DEVICE_UNFORWARD_IRQ. The purpose is

Re: [PATCH v3 2/8] KVM: arm64: Enable the KVM-VFIO device

2014-12-01 Thread Eric Auger
On 11/30/2014 01:14 PM, Christoffer Dall wrote: On Sun, Nov 23, 2014 at 07:35:54PM +0100, Eric Auger wrote: Used by KVM-enabled VFIO-based device passthrough support in QEMU. Signed-off-by: Joel Schopp joel.sch...@amd.com Signed-off-by: Eric Auger eric.au...@linaro.org --- Extracted from

Re: [GIT PULL 09/11] KVM: s390: add bitmap for handling cpu-local interrupts

2014-12-01 Thread Jens Freimann
Excerpts from Christian Borntraeger's message of 2014-11-29 22:05:10 +0100: Am 28.11.2014 um 18:18 schrieb Paolo Bonzini: On 28/11/2014 14:25, Christian Borntraeger wrote: +struct kvm_s390_irq_payload { +struct kvm_s390_io_info io; +struct kvm_s390_ext_info ext; +

Re: [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-12-01 Thread Luis R. Rodriguez
On Mon, Dec 01, 2014 at 11:11:43AM +, David Vrabel wrote: On 27/11/14 18:36, Luis R. Rodriguez wrote: On Thu, Nov 27, 2014 at 07:36:31AM +0100, Juergen Gross wrote: On 11/26/2014 11:26 PM, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@suse.com Some folks had reported that

Re: [PATCH v7 36/46] vhost/net: suppress compiler warning

2014-12-01 Thread Michael S. Tsirkin
On Mon, Dec 01, 2014 at 03:21:03PM +0100, Cornelia Huck wrote: On Mon, 1 Dec 2014 15:48:39 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Dec 01, 2014 at 01:37:40PM +0100, Cornelia Huck wrote: On Sun, 30 Nov 2014 17:12:13 +0200 Michael S. Tsirkin m...@redhat.com wrote:

Re: [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-12-01 Thread David Vrabel
On 01/12/14 15:05, Luis R. Rodriguez wrote: On Mon, Dec 01, 2014 at 11:11:43AM +, David Vrabel wrote: On 27/11/14 18:36, Luis R. Rodriguez wrote: On Thu, Nov 27, 2014 at 07:36:31AM +0100, Juergen Gross wrote: On 11/26/2014 11:26 PM, Luis R. Rodriguez wrote: From: Luis R. Rodriguez

Re: [PATCH v7 36/46] vhost/net: suppress compiler warning

2014-12-01 Thread Cornelia Huck
On Mon, 1 Dec 2014 17:12:08 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Dec 01, 2014 at 03:21:03PM +0100, Cornelia Huck wrote: On Mon, 1 Dec 2014 15:48:39 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Dec 01, 2014 at 01:37:40PM +0100, Cornelia Huck wrote: On

Re: [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-12-01 Thread Luis R. Rodriguez
On Mon, Dec 1, 2014 at 10:18 AM, David Vrabel david.vra...@citrix.com wrote: On 01/12/14 15:05, Luis R. Rodriguez wrote: On Mon, Dec 01, 2014 at 11:11:43AM +, David Vrabel wrote: On 27/11/14 18:36, Luis R. Rodriguez wrote: On Thu, Nov 27, 2014 at 07:36:31AM +0100, Juergen Gross wrote: On

Re: [PATCH v7 31/46] vhost: virtio 1.0 endian-ness support

2014-12-01 Thread Michael S. Tsirkin
On Mon, Dec 01, 2014 at 01:33:53PM +0100, Cornelia Huck wrote: On Sun, 30 Nov 2014 17:11:49 +0200 Michael S. Tsirkin m...@redhat.com wrote: Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/vhost/vhost.c | 93 +++ 1 file

Re: [Xen-devel] [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-12-01 Thread Luis R. Rodriguez
On Mon, Dec 01, 2014 at 03:42:33PM +0100, Juergen Gross wrote: On 12/01/2014 02:32 PM, Luis R. Rodriguez wrote: On Mon, Dec 01, 2014 at 11:01:18AM +, David Vrabel wrote: On 28/11/14 04:49, Juergen Gross wrote: On 11/27/2014 07:50 PM, Andrew Cooper wrote: XenServer uses

Re: [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-12-01 Thread David Vrabel
On 01/12/14 15:44, Luis R. Rodriguez wrote: On Mon, Dec 1, 2014 at 10:18 AM, David Vrabel david.vra...@citrix.com wrote: On 01/12/14 15:05, Luis R. Rodriguez wrote: On Mon, Dec 01, 2014 at 11:11:43AM +, David Vrabel wrote: On 27/11/14 18:36, Luis R. Rodriguez wrote: On Thu, Nov 27, 2014

[PATCH v8 36/50] vhost/net: enable virtio 1.0

2014-12-01 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/vhost/net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 8ff4a6d..a935c25 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -61,7 +61,8 @@

[PATCH v8 32/50] vhost: switch to __get/__put_user exclusively

2014-12-01 Thread Michael S. Tsirkin
Most places in vhost can use __get/__put_user rather than get/put_user since addresses are pre-validated. This should be good for performance, but this also will help make code sparse-clean: get/put_user macros don't play well with __virtioXX bitwise tags. Switch to get/put_user to __ variants

[PATCH v8 45/50] vhost/scsi: partial virtio 1.0 support

2014-12-01 Thread Michael S. Tsirkin
Include all endian conversions as required by virtio 1.0. Don't set virtio 1.0 yet, since that requires ANY_LAYOUT which we don't yet support. Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Paolo Bonzini pbonz...@redhat.com --- drivers/vhost/scsi.c | 22 -- 1

[PATCH v8 29/50] vhost: make features 64 bit

2014-12-01 Thread Michael S. Tsirkin
We need to use bit 32 for virtio 1.0. Make vhost_has_feature bool to avoid discarding high bits. Cc: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Cc: Ben Hutchings b...@decadent.org.uk Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Jason Wang jasow...@redhat.com ---

[PATCH v8 31/50] vhost/net: force len for TX to host endian

2014-12-01 Thread Michael S. Tsirkin
vhost/net keeps a copy of the used ring in host memory but (ab)uses the length field for internal house-keeping. This works because the length in the used ring for tx is always 0. In order to suppress sparse warnings, we force native endianness here. Note that these values are never exposed to

[PATCH v8 30/50] vhost: add memory access wrappers

2014-12-01 Thread Michael S. Tsirkin
Add guest memory access wrappers to handle virtio endianness conversions. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Jason Wang jasow...@redhat.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com --- drivers/vhost/vhost.h | 31 +++ 1 file

Re: [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-12-01 Thread Luis R. Rodriguez
On Mon, Dec 01, 2014 at 03:54:24PM +, David Vrabel wrote: On 01/12/14 15:44, Luis R. Rodriguez wrote: On Mon, Dec 1, 2014 at 10:18 AM, David Vrabel david.vra...@citrix.com wrote: On 01/12/14 15:05, Luis R. Rodriguez wrote: On Mon, Dec 01, 2014 at 11:11:43AM +, David Vrabel wrote:

[PATCH v8 33/50] vhost: virtio 1.0 endian-ness support

2014-12-01 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/vhost/vhost.c | 86 +-- 1 file changed, 49 insertions(+), 37 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 6a40837..ed71b53 100644 ---

Re: [PATCH 0/4] KVM: x86: APIC fixes

2014-12-01 Thread Paolo Bonzini
On 27/11/2014 20:03, Radim Krčmář wrote: The interesting one is [3/4], which improves upon a previous CVE fix; we also handle logical destination wrapping in it, so [2/4] does the same for physical; and to make it nicer, [1/4] removes a condition. [4/4] makes our fast path return true when

Re: [PATCH] kvm: x86: vmx: add checks on guest RIP

2014-12-01 Thread Paolo Bonzini
On 29/11/2014 16:27, Eugene Korenevsky wrote: Signed-off-by: Eugene Korenevsky ekorenev...@gmail.com --- Notes: This patch adds checks on Guest RIP specified in Intel Software Developer Manual. The following checks are performed on processors that support Intel 64

Re: [PATCH 14/21] KVM: x86: Software disabled APIC should still deliver NMIs

2014-12-01 Thread Paolo Bonzini
On 27/11/2014 23:26, Radim Krčmář wrote: We can't deliver xAPIC and x2APIC broadcasts/logical messages at the same time with current KVM and this patch just switches the working case in favour of x2APIC, which is why I didn't think it was necessary ... (And I didn't understand why prefer

[PATCH v8 35/50] vhost/net: larger header for virtio 1.0

2014-12-01 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Jason Wang jasow...@redhat.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com --- drivers/vhost/net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index

[PATCH v8 34/50] vhost/net: virtio 1.0 byte swap

2014-12-01 Thread Michael S. Tsirkin
I had to add an explicit tag to suppress compiler warning: gcc isn't smart enough to notice that len is always initialized since function is called with size 0. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com --- drivers/vhost/net.c | 15

Re: [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-12-01 Thread Juergen Gross
On 12/01/2014 05:19 PM, Luis R. Rodriguez wrote: On Mon, Dec 01, 2014 at 03:54:24PM +, David Vrabel wrote: On 01/12/14 15:44, Luis R. Rodriguez wrote: On Mon, Dec 1, 2014 at 10:18 AM, David Vrabel david.vra...@citrix.com wrote: On 01/12/14 15:05, Luis R. Rodriguez wrote: On Mon, Dec 01,

[PATCH 5/5] kvm: optimize GFN to memslot lookup with large slots amount

2014-12-01 Thread Igor Mammedov
Current linear search doesn't scale well when large amount of memslots is used and looked up slot is not in the beginning memslots array. Taking in account that memslots don't overlap, it's possible to switch sorting order of memslots array from 'npages' to 'base_gfn' and use binary search for

[PATCH 4/5] kvm: change memslot sorting rule from size to GFN

2014-12-01 Thread Igor Mammedov
it will allow to use binary search for GFN - memslot lookups, reducing lookup cost with large slots amount. Signed-off-by: Igor Mammedov imamm...@redhat.com --- virt/kvm/kvm_main.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/virt/kvm/kvm_main.c

[PATCH 3/5] kvm: search_memslots: add simple LRU memslot caching

2014-12-01 Thread Igor Mammedov
In typical guest boot workload only 2-3 memslots are used extensively, and at that it's mostly the same memslot lookup operation. Adding LRU cache improves average lookup time from 46 to 28 cycles (~40%) for this workload. Signed-off-by: Igor Mammedov imamm...@redhat.com ---

[PATCH 1/5] kvm: update_memslots: drop not needed check for the same number of pages

2014-12-01 Thread Igor Mammedov
if number of pages haven't changed sorting algorithm will do nothing, so there is no need to do extra check to avoid entering sorting logic. Signed-off-by: Igor Mammedov imamm...@redhat.com --- virt/kvm/kvm_main.c | 28 +--- 1 file changed, 13 insertions(+), 15

[PATCH 0/5] kvm: memslots lookup optimization

2014-12-01 Thread Igor Mammedov
Series speed-ups GFN to memslot lookup time by: * introducing LRU cache, which improves looukup time for same slot workload (typically boot time of Windows and Linux guest) * switching to binary search for GFN to memslot lookup, improving lookup time with large amount of memory slots Igor

[PATCH 2/5] kvm: update_memslots: drop not needed check for the same slot

2014-12-01 Thread Igor Mammedov
UP/DOWN shift loops will shift array in needed direction and stop at place where new slot should be placed regardless of old slot size. Signed-off-by: Igor Mammedov imamm...@redhat.com --- virt/kvm/kvm_main.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff

Re: [PATCH 0/5] kvm: memslots lookup optimization

2014-12-01 Thread Paolo Bonzini
On 01/12/2014 18:29, Igor Mammedov wrote: Series speed-ups GFN to memslot lookup time by: * introducing LRU cache, which improves looukup time for same slot workload (typically boot time of Windows and Linux guest) * switching to binary search for GFN to memslot lookup, improving

Re: [PATCH 14/21] KVM: x86: Software disabled APIC should still deliver NMIs

2014-12-01 Thread Radim Krčmář
2014-12-01 17:30+0100, Paolo Bonzini: On 27/11/2014 23:26, Radim Krčmář wrote: We can't deliver xAPIC and x2APIC broadcasts/logical messages at the same time with current KVM and this patch just switches the working case in favour of x2APIC, which is why I didn't think it was necessary ...

Re: [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-12-01 Thread Luis R. Rodriguez
On Mon, Dec 01, 2014 at 06:07:48PM +0100, Juergen Gross wrote: On 12/01/2014 05:19 PM, Luis R. Rodriguez wrote: On Mon, Dec 01, 2014 at 03:54:24PM +, David Vrabel wrote: On 01/12/14 15:44, Luis R. Rodriguez wrote: On Mon, Dec 1, 2014 at 10:18 AM, David Vrabel david.vra...@citrix.com

Re: [PATCH 0/4] KVM: x86: APIC fixes

2014-12-01 Thread Radim Krčmář
2014-12-01 17:22+0100, Paolo Bonzini: On 27/11/2014 20:03, Radim Krčmář wrote: The interesting one is [3/4], which improves upon a previous CVE fix; we also handle logical destination wrapping in it, so [2/4] does the same for physical; and to make it nicer, [1/4] removes a condition.

Re: [PATCH 0/4] KVM: x86: APIC fixes

2014-12-01 Thread Paolo Bonzini
On 01/12/2014 18:55, Radim Krčmář wrote: 2014-12-01 17:22+0100, Paolo Bonzini: On 27/11/2014 20:03, Radim Krčmář wrote: The interesting one is [3/4], which improves upon a previous CVE fix; we also handle logical destination wrapping in it, so [2/4] does the same for physical; and to make

Re: [PATCH 5/5] arm/arm64: KVM: Turn off vcpus and flush stage-2 pgtables on sytem exit events

2014-12-01 Thread Peter Maydell
On 27 November 2014 at 23:10, Peter Maydell peter.mayd...@linaro.org wrote: It seems odd to have this unmap happen on attempted system reset/powerdown, not on cpu init/start. Here's a concrete case that I think requires the unmap to be done on cpu init: * start a VM and run it for a bit *

Re: [Xen-devel] [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-12-01 Thread David Vrabel
On 01/12/14 16:19, Luis R. Rodriguez wrote: On Mon, Dec 01, 2014 at 03:54:24PM +, David Vrabel wrote: On 01/12/14 15:44, Luis R. Rodriguez wrote: On Mon, Dec 1, 2014 at 10:18 AM, David Vrabel david.vra...@citrix.com wrote: On 01/12/14 15:05, Luis R. Rodriguez wrote: On Mon, Dec 01, 2014

Re: [PATCH v3 3/8] VFIO: platform: forwarded state tested when selecting IRQ handler

2014-12-01 Thread Christoffer Dall
On Mon, Dec 01, 2014 at 03:39:24PM +0100, Eric Auger wrote: Hi Christoffer, On 11/30/2014 01:47 PM, Christoffer Dall wrote: The subject reads strangely, perhaps just: VFIO: platform: test forward state when selecting IRQ handler OK On Sun, Nov 23, 2014 at 07:35:55PM +0100, Eric

[PATCH v3] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-12-01 Thread Chen Gang
kvm_register_device_ops() may fail, so need process the related failure case. Since it is related with neither vgic_arch_setup() nor on_each_cpu(), can move it before them, then simplify the related failure processing code. Signed-off-by: Chen Gang gang.chen.5...@gmail.com ---

Re: [PATCH v3 3/8] VFIO: platform: forwarded state tested when selecting IRQ handler

2014-12-01 Thread Eric Auger
On 12/01/2014 09:10 PM, Christoffer Dall wrote: On Mon, Dec 01, 2014 at 03:39:24PM +0100, Eric Auger wrote: Hi Christoffer, On 11/30/2014 01:47 PM, Christoffer Dall wrote: The subject reads strangely, perhaps just: VFIO: platform: test forward state when selecting IRQ handler OK On Sun,

Re: [PATCH v12 09/11] pvqspinlock, x86: Add para-virtualization support

2014-12-01 Thread Konrad Rzeszutek Wilk
On Tue, Nov 25, 2014 at 07:33:58PM -0500, Waiman Long wrote: On 10/27/2014 02:02 PM, Konrad Rzeszutek Wilk wrote: On Mon, Oct 27, 2014 at 01:38:20PM -0400, Waiman Long wrote: My concern is that spin_unlock() can be called in many places, including loadable kernel modules. Can the

Re: [PATCH v13 09/11] pvqspinlock, x86: Add para-virtualization support

2014-12-01 Thread Konrad Rzeszutek Wilk
On Wed, Oct 29, 2014 at 04:19:09PM -0400, Waiman Long wrote: This patch adds para-virtualization support to the queue spinlock code base with minimal impact to the native case. There are some minor code changes in the generic qspinlock.c file which should be usable in other architectures. The

Re: [PATCH] x86, microcode: Don't initialize microcode code on paravirt

2014-12-01 Thread Konrad Rzeszutek Wilk
On Mon, Dec 01, 2014 at 04:27:44PM -0500, Boris Ostrovsky wrote: Paravirtual guests are not expected to load microcode into processors and therefore it is not necessary to initialize microcode loading logic. CC-ing the KVM folks since they use the paravirt interface too. In fact, under

Re: [PATCH] x86, microcode: Don't initialize microcode code on paravirt

2014-12-01 Thread Paolo Bonzini
On 01/12/2014 22:57, Konrad Rzeszutek Wilk wrote: On Mon, Dec 01, 2014 at 04:27:44PM -0500, Boris Ostrovsky wrote: Paravirtual guests are not expected to load microcode into processors and therefore it is not necessary to initialize microcode loading logic. CC-ing the KVM folks since they

Re: [PATCH] x86, microcode: Don't initialize microcode code on paravirt

2014-12-01 Thread Boris Ostrovsky
On 12/01/2014 05:00 PM, Borislav Petkov wrote: On Mon, Dec 01, 2014 at 04:27:44PM -0500, Boris Ostrovsky wrote: Paravirtual guests are not expected to load microcode into processors and therefore it is not necessary to initialize microcode loading logic. In fact, under certain circumstances

Re: [PATCH] x86, microcode: Don't initialize microcode code on paravirt

2014-12-01 Thread Borislav Petkov
On Mon, Dec 01, 2014 at 11:12:38PM +0100, Paolo Bonzini wrote: We also do not want to load microcode. :) Thanks for the heads-up. You don't need to :P -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line

Re: [Xen-devel] [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-12-01 Thread Luis R. Rodriguez
On Mon, Dec 01, 2014 at 06:16:28PM +, David Vrabel wrote: On 01/12/14 16:19, Luis R. Rodriguez wrote: On Mon, Dec 01, 2014 at 03:54:24PM +, David Vrabel wrote: On 01/12/14 15:44, Luis R. Rodriguez wrote: On Mon, Dec 1, 2014 at 10:18 AM, David Vrabel david.vra...@citrix.com wrote:

Re: [PATCH] x86, microcode: Don't initialize microcode code on paravirt

2014-12-01 Thread Borislav Petkov
On Mon, Dec 01, 2014 at 05:31:56PM -0500, Boris Ostrovsky wrote: I think so. The problem we have now is __pa() macro that we only use on 32-bit. I'll queue this for overnight tests to make sure and if it indeed works then 3.19 should be fine. Cool, thanks. I'd still take your patch for 3.19

Re: [PATCH] KVM: Introduce dynamically registered hypercall capability

2014-12-01 Thread Phil White
On Mon, Dec 1, 2014 at 5:47 AM, Radim Krčmář rkrc...@redhat.com wrote: 2014-11-28 17:29-0800, Phil White: Good questions. One thing that prompted this code is the presence and proliferation of architecture specific hypercalls in include/uapi/linux/kvm_para.h. I'm not sure why the tree has

Re: [PATCH] KVM: PPC: Book3S HV: Tracepoints for KVM HV guest interactions

2014-12-01 Thread Suresh E. Warrier
On 11/20/2014 08:01 AM, Steven Rostedt wrote: On Thu, 20 Nov 2014 13:10:12 +0100 Alexander Graf ag...@suse.de wrote: On 20.11.14 11:40, Aneesh Kumar K.V wrote: Suresh E. Warrier warr...@linux.vnet.ibm.com writes: This patch adds trace points in the guest entry and exit code and also

RE: [RFC PATCH v2 1/2] KVM: kvm-vfio: User API for VT-d Posted-Interrupts

2014-12-01 Thread Wu, Feng
-Original Message- From: Eric Auger [mailto:eric.au...@linaro.org] Sent: Monday, December 01, 2014 6:10 PM To: Alex Williamson Cc: Wu, Feng; pbonz...@redhat.com; g...@kernel.org; kvm@vger.kernel.org Subject: Re: [RFC PATCH v2 1/2] KVM: kvm-vfio: User API for VT-d Posted-Interrupts

Re: Question about physical page allocation to the guest

2014-12-01 Thread Steven
On Wed, Oct 22, 2014 at 12:39 PM, Xiao Guangrong xiaoguangrong.e...@gmail.com wrote: On 10/20/14 2:09 AM, Steven wrote: Hi, Eric, I am trying to understand how KVM allocates physical pages to the guest and your slides clarify a lot of questions.

Re: [RFC PATCH v2 1/2] KVM: kvm-vfio: User API for VT-d Posted-Interrupts

2014-12-01 Thread Alex Williamson
On Tue, 2014-12-02 at 02:08 +, Wu, Feng wrote: -Original Message- From: Eric Auger [mailto:eric.au...@linaro.org] Sent: Monday, December 01, 2014 6:10 PM To: Alex Williamson Cc: Wu, Feng; pbonz...@redhat.com; g...@kernel.org; kvm@vger.kernel.org Subject: Re: [RFC PATCH v2

RE: [RFC PATCH v2 1/2] KVM: kvm-vfio: User API for VT-d Posted-Interrupts

2014-12-01 Thread Wu, Feng
-Original Message- From: Alex Williamson [mailto:alex.william...@redhat.com] Sent: Tuesday, December 02, 2014 12:48 PM To: Wu, Feng Cc: Eric Auger; pbonz...@redhat.com; g...@kernel.org; kvm@vger.kernel.org Subject: Re: [RFC PATCH v2 1/2] KVM: kvm-vfio: User API for VT-d

[PATCH 2/2] KVM: vmx: Enable Intel xsaves for guest

2014-12-01 Thread Wanpeng Li
Expose Intel xsaves feature to guest. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- arch/x86/include/asm/kvm_host.h | 1 + arch/x86/include/asm/vmx.h | 3 +++ arch/x86/include/uapi/asm/vmx.h | 6 +- arch/x86/kvm/vmx.c | 30 +- 4

[PATCH 1/2] kvm: x86: revert mask out xsaves

2014-12-01 Thread Wanpeng Li
xsaves will be exported to guest in the next patch, so revert the mask out xsaves patch. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- arch/x86/kvm/cpuid.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index

Re: [CFT PATCH v2 0/2] KVM: support XSAVES usage in the host

2014-12-01 Thread Wanpeng Li
Hi Paolo, On Tue, Nov 25, 2014 at 04:50:06PM +0200, Nadav Amit wrote: [...] I am just worried that Wanpeng reported it fails, while I report it works... I just get a real skylake-client machine on hand, both the two patches from you can run normally, it seems that the silly emulator which I used

[PATCH v2 2/2] kvm: vmx: enable intel xsaves for guest

2014-12-01 Thread Wanpeng Li
Expose intel xsaves feature to guest. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- v1 - v2: *auto switch msr ia32_xss if this msr is present arch/x86/include/asm/kvm_host.h | 1 + arch/x86/include/asm/vmx.h | 3 +++ arch/x86/include/uapi/asm/vmx.h | 6 +-

  1   2   >