Re: KVM call minutes for Nov 30

2010-11-30 Thread Anthony Liguori
the current bandwidth limit. And while setting a migration limit does increase migration, it's the only solution that preserves fairness unless we stick migration into a separate thread. Regards, Anthony Liguori - run Anthony's test load and discuss on list -- To unsubscribe from

Re: [PATCH 09/10] Exit loop if we have been there too long

2010-11-30 Thread Anthony Liguori
On 11/30/2010 07:58 AM, Avi Kivity wrote: On 11/30/2010 03:47 PM, Anthony Liguori wrote: On 11/30/2010 01:15 AM, Paolo Bonzini wrote: On 11/30/2010 03:11 AM, Anthony Liguori wrote: BufferedFile should hit the qemu_file_rate_limit check when the socket buffer gets filled up. The problem is

Re: [PATCH 09/10] Exit loop if we have been there too long

2010-11-30 Thread Anthony Liguori
On 11/30/2010 08:12 AM, Paolo Bonzini wrote: On 11/30/2010 02:47 PM, Anthony Liguori wrote: On 11/30/2010 01:15 AM, Paolo Bonzini wrote: On 11/30/2010 03:11 AM, Anthony Liguori wrote: BufferedFile should hit the qemu_file_rate_limit check when the socket buffer gets filled up. The problem

Re: [PATCH 09/10] Exit loop if we have been there too long

2010-11-30 Thread Anthony Liguori
On 11/30/2010 08:27 AM, Avi Kivity wrote: On 11/30/2010 04:17 PM, Anthony Liguori wrote: What's the problem with burning that cpu? per guest page, compressing takes less than sending. Is it just an issue of qemu mutex hold time? If you have a 512GB guest, then you have a 16MB dirty b

Re: [PATCH 09/10] Exit loop if we have been there too long

2010-11-30 Thread Anthony Liguori
On 11/30/2010 01:15 AM, Paolo Bonzini wrote: On 11/30/2010 03:11 AM, Anthony Liguori wrote: BufferedFile should hit the qemu_file_rate_limit check when the socket buffer gets filled up. The problem is that the file rate limit is not hit because work is done elsewhere. The rate can limit

Re: [Qemu-devel] [PATCH 00/21] Kemari for KVM 0.2

2010-11-29 Thread Anthony Liguori
work with Kemari, that's okay as long as the non-Kemari case is essentially a nop. Regards, Anthony Liguori Paul -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Qemu-devel] [PATCH 00/21] Kemari for KVM 0.2

2010-11-29 Thread Anthony Liguori
r idea of why a separate interface is needed--to distinguish between device accesses and internal accesses. BTW, dev_aio_multiwrite should take a DeviceState * and a BlockDriverState. Regards, Anthony Liguori Paul -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-29 Thread Anthony Liguori
On 11/29/2010 02:04 AM, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 05:13:41PM -0600, Anthony Liguori wrote: On 11/28/2010 04:28 PM, Michael S. Tsirkin wrote: But rather need to use ugly factory functions with all sorts of DO_UPCAST. This is really unfriendly

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-29 Thread Anthony Liguori
e seem to care about building with an old migw compiler in Debian stable which is unlikely to have tr1. If we drop this we'll also have a working %llx in printf :) Boost has a very compatible tr1 library. Regards, Anthony Liguori -- error compiling committee.c: too many arguments

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Anthony Liguori
And that's really my motivation for using C++. I get tired of doing the work that the compiler should be doing for me. I want to spend my time doing interesting things like writing device model test cases instead of writing code to work around the fact that the C type system is about as powerful as a Vespa. Regars, Anthony Liguori -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Anthony Liguori
ctually has __attribute__((warn_unused_result)) which might help catch common errors. No such tool to catch exception-unsafe code AFAIK. I tend to agree that writing exception safe code and using exceptions for expected errors is a bad idea. I think exceptions should be used primarily for

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Anthony Liguori
On 11/28/2010 06:27 AM, Michael S. Tsirkin wrote: On Wed, Nov 24, 2010 at 08:41:26AM -0600, Anthony Liguori wrote: On 11/24/2010 06:59 AM, Alexander Graf wrote: On 24.11.2010, at 11:52, Avi Kivity wrote: Introduce exception-safe objects for calling system, vm, and vcpu

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
C++ and I also agree that it's uglier than the same implementation in C. I am glad we agree on that :) Regards, Anthony Liguori very few memory allocations. This is largely due to the fact that I don't overly abstract busses and rely on simple composition where appropriate

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
On 11/24/2010 11:33 AM, Gleb Natapov wrote: On Wed, Nov 24, 2010 at 10:40:05AM -0600, Anthony Liguori wrote: On 11/24/2010 10:12 AM, Gleb Natapov wrote: Why would we specify a PIIX3 device based on a configuration file? There is only one PIIX3 device in the world. I don&#

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
On 11/24/2010 11:45 AM, Jes Sorensen wrote: On 11/24/10 18:43, Anthony Liguori wrote: On 11/24/2010 11:36 AM, Jes Sorensen wrote: On 11/24/10 18:27, Anthony Liguori wrote: The compiler won't generate an error. Only upon a call to file_release() will a null po

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
On 11/24/2010 11:36 AM, Jes Sorensen wrote: On 11/24/10 18:27, Anthony Liguori wrote: The compiler won't generate an error. Only upon a call to file_release() will a null pointer dereference happens whereas in C++, because this paradigm is structured in the language, the compiler can

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
ler won't generate an error. Only upon a call to file_release() will a null pointer dereference happens whereas in C++, because this paradigm is structured in the language, the compiler can help assist you. Regards, Anthony Liguori Jes -- To unsubscribe from this list: send the li

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
class PIIX3 { private: class isa_bridge { }; isa_bridge isa_bridge; No, PIIX3 is an PCI-to-ISA bridge. It's a fundamental part of the definition of it as a PCI device. Regards, Anthony Liguori i8042 kbc; ... } So the thing becomes just a glue layer

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
MU, rather than pretend it is something that it isn't. Does anyone have any evidence that the i8042 has anything to do with the ISA bus at all other than the fact that people have some weird notion in their head that if a pio/mmio operation isn't for a PCI device, it must be ISA?

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
VSEL# and then routes the request to the write part of the chip to handle it. For unhandled transactions, it then forwards them to the ISA bus. Regards, Anthony Liguori -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kerne

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
27;t have written the unittest code to use classes or exceptions at all. I don't think it's a good fit. Regards, Anthony Liguori Jes -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
eing behind the ISA bus but you could also model them as being behind the PCI bus. Regards, Anthony Liguori We have fw_cfg on ISA bus too which does not exits on real HW and we may want to have other devices. We should be able to add them without changing PIIX3 class. fw_cfg should cer

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
ers, you can be leak free without every worrying about explicit freeing. There are, of course, possibilities of having circular references but it's not too hard to avoid that in practice. Regards, Anthony Liguori -- Gleb. -- To unsubscribe from thi

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
On 11/24/2010 09:40 AM, Gleb Natapov wrote: On Wed, Nov 24, 2010 at 08:41:26AM -0600, Anthony Liguori wrote: On 11/24/2010 06:59 AM, Alexander Graf wrote: On 24.11.2010, at 11:52, Avi Kivity wrote: Introduce exception-safe objects for calling system, vm, and vcpu ioctls

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
ctly. I don't want things to happen automatically here, this is for a test framework. That's fine. Regards, Anthony Liguori -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
On 11/24/2010 08:29 AM, Avi Kivity wrote: On 11/24/2010 04:10 PM, Anthony Liguori wrote: On 11/24/2010 04:52 AM, Avi Kivity wrote: Introduce exception-safe objects for calling system, vm, and vcpu ioctls. + +namespace kvm { + +static long check_error(long r) +{ +if (r == -1) { +throw

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
ement different behaviors. Combined with template specialization and an Array wrapper, the same thing works for arrays too. Regards, Anthony Liguori Regards, Anthony Liguori Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@v

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
On 11/24/2010 08:18 AM, Anthony Liguori wrote: On 11/24/2010 06:59 AM, Alexander Graf wrote: On 24.11.2010, at 11:52, Avi Kivity wrote: Introduce exception-safe objects for calling system, vm, and vcpu ioctls. Signed-off-by: Avi Kivity FWIW, I still disagree with C++ and believe this code

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
precise. There are also three different catch up algorithms that are selectable at run time. This is all tested with a time simulation that can simulate random amounts of drift over random periods of time. Regards, Anthony Liguori Alex -- To unsubscribe from this list: send the line

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-24 Thread Anthony Liguori
p; other); +~fd() { ::close(_fd); } +int get() { return _fd; } +long ioctl(unsigned nr, long arg); +long ioctlp(unsigned nr, void *arg) { + return ioctl(nr, reinterpret_cast(arg)); +} I think mixing inline definitions with declarations is bad form. Regards,

Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-11-24 Thread Anthony Liguori
On 11/24/2010 02:18 AM, Avi Kivity wrote: On 11/23/2010 06:49 PM, Anthony Liguori wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them to respond to these signals (which cannot be trapped), use SIGUSR1 to approximate the behavior of SIGSTOP/SIGCONT.

Re: [Qemu-devel] [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-11-23 Thread Anthony Liguori
On 11/23/2010 05:43 PM, Paolo Bonzini wrote: On 11/23/2010 10:46 PM, Anthony Liguori wrote: +static __thread int sigusr1_wfd; While OpenBSD finally updated the default compiler to 4.2.1 from 3.x series, thread local storage is still not supported: Hrm, is there a portable way to do this

Re: [Qemu-devel] [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-11-23 Thread Anthony Liguori
On 11/23/2010 01:35 PM, Blue Swirl wrote: On Tue, Nov 23, 2010 at 4:49 PM, Anthony Liguori wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them to respond to these signals (which cannot be trapped), use SIGUSR1 to approximate the behavior of SI

[PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-11-23 Thread Anthony Liguori
feature to carry in QEMU? Signed-off-by: Anthony Liguori diff --git a/cpu-defs.h b/cpu-defs.h index 51533c6..6434dca 100644 --- a/cpu-defs.h +++ b/cpu-defs.h @@ -220,6 +220,7 @@ struct KVMCPUState { const char *cpu_model_str; \ struct KVMState

Re: [PATCHv6 00/16] boot order specification

2010-11-23 Thread Anthony Liguori
On 11/23/2010 09:31 AM, Gleb Natapov wrote: Anthony, Blue No comments on this patch series for almost a week. Can it be applied? Does that mean everyone's happy or have folks not gotten around to review it? IOW, last call if you have objections :-) Regards, Anthony Liguori O

Re: [Qemu-devel] [PATCH] qemu-kvm: introduce cpu_start/cpu_stop commands

2010-11-23 Thread Anthony Liguori
second? Each vcpu gets 300M cycles per second. You could monitor threads separately but stop the entire process. Stopping individual threads will break apart as soon as they start taking locks. I don't think so.. PLE should work as expected. It's no different than a normally con

Re: [Qemu-devel] [PATCH] qemu-kvm: introduce cpu_start/cpu_stop commands

2010-11-23 Thread Anthony Liguori
On 11/23/2010 02:16 AM, Dor Laor wrote: On 11/23/2010 08:41 AM, Avi Kivity wrote: On 11/23/2010 01:00 AM, Anthony Liguori wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them to respond to these signals, introduce monitor commands that stop and

Re: [Qemu-devel] [PATCH] qemu-kvm: introduce cpu_start/cpu_stop commands

2010-11-23 Thread Anthony Liguori
On 11/23/2010 12:41 AM, Avi Kivity wrote: On 11/23/2010 01:00 AM, Anthony Liguori wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them to respond to these signals, introduce monitor commands that stop and start individual vcpus. The purpose of

Re: [PATCH] qemu-kvm: introduce cpu_start/cpu_stop commands

2010-11-22 Thread Anthony Liguori
On 11/22/2010 05:56 PM, Chris Wright wrote: * Anthony Liguori (aligu...@linux.vnet.ibm.com) wrote: On 11/22/2010 05:04 PM, Chris Wright wrote: * Anthony Liguori (aligu...@us.ibm.com) wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching th

Re: [PATCH] qemu-kvm: introduce cpu_start/cpu_stop commands

2010-11-22 Thread Anthony Liguori
On 11/22/2010 05:04 PM, Chris Wright wrote: * Anthony Liguori (aligu...@us.ibm.com) wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them to respond to these signals, introduce monitor commands that stop and start individual vcpus. In the

Re: [PATCH] qemu-kvm: introduce cpu_start/cpu_stop commands

2010-11-22 Thread Anthony Liguori
On 11/22/2010 05:00 PM, Anthony Liguori wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them to respond to these signals, introduce monitor commands that stop and start individual vcpus. The purpose of these commands are to implement CPU hard limits usi

[PATCH] qemu-kvm: introduce cpu_start/cpu_stop commands

2010-11-22 Thread Anthony Liguori
ption and stops the CPU as appropriate. The monitor commands provide a more elegant solution that signals because it ensures that a stopped vcpu isn't holding the qemu_mutex. I'll reply to this note with an example tool. Signed-off-by: Anthony Liguori diff --git a/hmp-commands.hx b/

Re: [Qemu-devel] KVM call agenda for Nov 23

2010-11-22 Thread Anthony Liguori
On 11/22/2010 03:45 PM, Chris Wright wrote: * Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you are interested in covering. usb-ccid - vcpu hard limits Regards, Anthony Liguori -- To unsubscribe from this list: send the line "unsubscribe kv

Re: [Qemu-devel] KVM call agenda for Nov 23

2010-11-22 Thread Anthony Liguori
d be a lot simpler just to include the emulation in qemu like we do for every other device... Regards, Anthony Liguori -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [Qemu-devel] [PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-21 Thread Anthony Liguori
:2905: error: 'UTIME_OMIT' undeclared (first use in this function) v3: - Use better alternative handling for UTIME_NOW/OMIT - Move qemu_utimensat() to cutils.c V2: - Introduce qemu_utimensat() Signed-off-by: Hidetoshi Seto Applied. Thanks. Regards, Anthony Liguori --

Re: [Qemu-devel] [PATCH] optionrom: fix bugs in signrom.sh

2010-11-21 Thread Anthony Liguori
e checksum happened to be zero, we calculated the correction byte to be 256 Instead of rewriting this in half a line of python, this patch fixes the bugs. Signed-off-by: Avi Kivity Applied. Thanks. Regards, Anthony Liguori --- pc-bios/optionrom/signrom.sh |7 +++ 1 files

Re: [Qemu-devel] [PATCH v3 0/2] Type-safe ioport callbacks

2010-11-21 Thread Anthony Liguori
the other 300-odd registrations is left as an excercise to the community. Applied all. Thanks. Regards, Anthony Liguori v3: - define a common IORange that can also be used for mmio - move start/length into IORange - make access width a parameter of the access functions instead

Re: [Qemu-devel] [PATCH 0/1] [PULL] qemu-kvm.git uq/master queue

2010-11-20 Thread Anthony Liguori
On 11/05/2010 07:44 PM, Marcelo Tosatti wrote: The following changes since commit d33ea50a958b2e050d2b28e5f17e3b55e91c6d74: scsi-disk: Fix immediate failure of bdrv_aio_* (2010-11-04 13:54:37 +0100) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-18 Thread Anthony Liguori
On 11/18/2010 09:57 AM, Avi Kivity wrote: On 11/18/2010 05:46 PM, Anthony Liguori wrote: On 11/18/2010 09:22 AM, Avi Kivity wrote: On 11/18/2010 01:42 AM, Anthony Liguori wrote: Gack. For the benefit of those that want to join the fun without digging up the spec, these magic flippable

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-18 Thread Anthony Liguori
On 11/18/2010 09:22 AM, Avi Kivity wrote: On 11/18/2010 01:42 AM, Anthony Liguori wrote: Gack. For the benefit of those that want to join the fun without digging up the spec, these magic flippable segments the i440fx can toggle are 12 fixed 16k segments from 0xc to 0xe and a single 64k

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-18 Thread Anthony Liguori
e this, but the basic concept is, RAM always exists but if a device tries to access it, it may or may not be accessible as RAM at any given point in time. Regards, Anthony Liguori #endif -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a messa

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-17 Thread Anthony Liguori
On 11/16/2010 03:24 PM, Alex Williamson wrote: On Tue, 2010-11-16 at 08:58 -0600, Anthony Liguori wrote: On 11/01/2010 10:14 AM, Alex Williamson wrote: Register the actual VM RAM using the new API Signed-off-by: Alex Williamson --- hw/pc.c | 12 ++-- 1 files changed

Re: [Qemu-devel] [PATCH v2 1/2] Minimal RAM API support

2010-11-17 Thread Anthony Liguori
} +} +return 0; +} diff --git a/memory.h b/memory.h new file mode 100644 index 000..0c17ff9 --- /dev/null +++ b/memory.h @@ -0,0 +1,18 @@ +#ifndef QEMU_MEMORY_H +#define QEMU_MEMORY_H + +#include "qemu-common.h" +#include "cpu-common.h" Header needs c

Re: Hitting 29 NIC limit

2010-11-16 Thread Anthony Liguori
On 11/16/2010 11:23 AM, Michael S. Tsirkin wrote: On Thu, Oct 14, 2010 at 05:17:36PM -0500, Anthony Liguori wrote: On 10/14/2010 05:12 PM, Anjali Kulkarni wrote: Thanks. Does this work for e1000 as well? Haven't tried. I don't know how various e1000 drivers w

Re: [Qemu-devel] [PATCH v2 1/2] Minimal RAM API support

2010-11-16 Thread Anthony Liguori
rt_addr&& slot->size == size) { +return slot; +} + +if (ranges_overlap(start_addr, size, slot->start_addr, slot->size)) { +abort(); Should display a message before aborting. Why not use hw_error? Another good sugges

Re: [PATCH -v2] Monitor command: pfa2hva, translate guest physical address to host virtual address

2010-11-10 Thread Anthony Liguori
hva, I'm not sure we want to guarantee that it won't. We can't universally either. Memory hot remove potentially breaks the mapping and some non-x86 architectures (like ARM) can alias RAM via a guest triggered mechanism. Regards, Anthony Liguori -- To unsubscribe from t

Re: KVM call agenda for Nov 9

2010-11-08 Thread Anthony Liguori
On 11/08/2010 08:23 AM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. For once I start: - report from linux plumbers virt track (jes?, anthony?) - report from linux kernel summit (avi?) Good thinking. Regards, Anthony Liguori Cheers, Juan. -- To

Re: [PATCH -v2] Monitor command: pfa2hva, translate guest physical address to host virtual address

2010-11-07 Thread Anthony Liguori
On 11/07/2010 07:29 PM, Huang Ying wrote: On Sun, 2010-11-07 at 00:24 +0800, Avi Kivity wrote: On 11/01/2010 03:22 PM, Anthony Liguori wrote: On 11/01/2010 02:20 PM, Huang Ying wrote: Yes. As general interface, it may not work so well, but as test interface, it works quite

Re: [PATCH -v2] Monitor command: pfa2hva, translate guest physical address to host virtual address

2010-11-07 Thread Anthony Liguori
On 11/06/2010 11:24 AM, Avi Kivity wrote: On 11/01/2010 03:22 PM, Anthony Liguori wrote: On 11/01/2010 02:20 PM, Huang Ying wrote: Yes. As general interface, it may not work so well, but as test interface, it works quite well and useful. Do we have any mechanism to add a test only interface

Re: [PATCH -v2] Monitor command: pfa2hva, translate guest physical address to host virtual address

2010-11-01 Thread Anthony Liguori
rface and probably prefix the command with a 'x-' prefix to indicate that it's not a supported interface. The documentation should be very clear about the limitations of the interface and the intended use-case. Regards, Anthony Liguori Best Regards, Huang Ying -- To u

Re: [PATCH -v2] Monitor command: pfa2hva, translate guest physical address to host virtual address

2010-11-01 Thread Anthony Liguori
submitted. Regards, Anthony Liguori Signed-off-by: Max Asbock Signed-off-by: Jiajia Zheng Signed-off-by: Huang Ying --- hmp-commands.hx | 15 +++ monitor.c | 22 ++ qmp-commands.hx | 27 +++ 3 files changed, 64 insertions(+) -

Re: [PATCH] APIC/IOAPIC EOI callback

2010-10-29 Thread Anthony Liguori
nt_list, list) { +if (client->irq == gsi) { + client->eoi(client); +} +} +} I think this all goes away with a NotifierList. Regards, Anthony Liguori + static void ioapic_service(IOAPICState *s) { uint8_t i; @@ -90,8

Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks

2010-10-26 Thread Anthony Liguori
s a region of I/O address space". I think an IORegion should contain an IOPort structure though. I think the name needs rethinking. Maybe: struct PortIOHandler; struct MemoryIOHandler; And it would be good to add a memory callback to this series too. Regards, Anthony Liguori >> The

Re: KVM call agenda for Oct 26

2010-10-26 Thread Anthony Liguori
On 10/26/2010 08:04 AM, Avi Kivity wrote: On 10/26/2010 02:49 PM, Anthony Liguori wrote: On 10/26/2010 03:20 AM, Avi Kivity wrote: On 10/25/2010 09:51 PM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. 0.13.1 At least two fatal issues: - vmmouse is

Re: KVM call agenda for Oct 26

2010-10-26 Thread Anthony Liguori
ng to also get the hotplug fixes because tose are pretty important IMHO. I don't want to wait too long though. What's the assertion in the block layer? Regards, Anthony Liguori -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to

Re: [Qemu-devel] Re: [PATCH 0/2] Type-safe ioport callbacks

2010-10-25 Thread Anthony Liguori
On 10/25/2010 08:52 AM, Paolo Bonzini wrote: On 10/25/2010 03:46 PM, Anthony Liguori wrote: Should we create a Documentation/ file with incomplete transitions and the commit(s) that introduced them, for volunteers who wish to do some dirty work or to learn Coccinelle? If we have a TODO, we

Re: [Qemu-devel] [PATCH 0/2] Type-safe ioport callbacks

2010-10-25 Thread Anthony Liguori
300-odd registrations is left as an excercise to the community. Avi Kivity (2): Type-safe ioport callbacks piix4 acpi: convert io BAR to type-safe ioport callbacks Makes sense. Acked-by: Anthony Liguori Regards, Anthony Liguori hw/acpi_piix4.c |

Re: [Qemu-devel] Re: [PATCH 0/2] Type-safe ioport callbacks

2010-10-25 Thread Anthony Liguori
ome dirty work or to learn Coccinelle? If we have a TODO, we could add a janitor section there. That's unnecessary work. The vast majority of the callers of register_ioport* should be using a bus specific interface instead. Regards, Anthony Liguori -- To unsubscribe from this list:

Re: [Qemu-devel] KVM call minutes for Oct 19

2010-10-22 Thread Anthony Liguori
On 10/22/2010 01:20 PM, Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: On 10/22/2010 12:29 PM, Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: The first step is just identifying what interfaces we need in a guest agent. So far, I

Re: [Qemu-devel] KVM call minutes for Oct 19

2010-10-22 Thread Anthony Liguori
On 10/22/2010 12:29 PM, Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: The first step is just identifying what interfaces we need in a guest agent. So far, I think we can get away with a very small number of interfaces (mainly read/write files, execute command

Re: [Qemu-devel] [PATCH 0/7] [PULL] qemu-kvm.git uq/master queue

2010-10-22 Thread Anthony Liguori
On 10/21/2010 01:25 PM, Marcelo Tosatti wrote: The following changes since commit 633aa0acfe2c4d3e56acfe28c912796bf54de6d3: Fix pci hotplug to generate level triggered interrupt. (2010-10-20 17:23:28 -0500) Pulled. Thanks. Regards, Anthony Liguori are available in the git

Re: [Qemu-devel] KVM call minutes for Oct 19

2010-10-21 Thread Anthony Liguori
mmunication window locations to enable "coherence" mode in the QEMU GUI is something that makes no sense as a network management interface. This is something that only makes sense between QEMU and the guest agent. Regards, Anthony Liguori Thats probably enough for the moment, I&#x

Re: [Qemu-devel] KVM call minutes for Oct 19

2010-10-21 Thread Anthony Liguori
On 10/21/2010 08:18 AM, Daniel P. Berrange wrote: On Thu, Oct 21, 2010 at 08:09:44AM -0500, Anthony Liguori wrote: Hi Andrew, On 10/21/2010 05:22 AM, Andrew Beekhof wrote: Hello from the Matahari tech-lead... Is there any documentation on the capabilities provided guest agent

Re: [Qemu-devel] KVM call minutes for Oct 19

2010-10-21 Thread Anthony Liguori
n support probably won't work. Regards, Anthony Liguori -- Andrew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from

Re: [Qemu-devel] KVM call minutes for Oct 19

2010-10-21 Thread Anthony Liguori
ace. The core QEMU agent would use org.qemu.guest-agent and a spice against could use org.spice-space.guest-agent. The QEMU agent should have an interface that terminates in QEMU itself. Regards, Anthony Liguori Paolo -- To unsubscribe from this list: send the line "unsubscribe kv

Re: [PATCH 08/10] MCE: Relay UCR MCE to guest

2010-10-20 Thread Anthony Liguori
On 10/20/2010 04:56 PM, Paolo Bonzini wrote: On 10/20/2010 09:51 PM, Anthony Liguori wrote: I don't understand why this loop is needed but we specifically wait for a signal to get delivered that's either SIG_IPI or SIGBUS. We then check whether a SIG_IPI or SIGBUS is pending and lo

Re: [PATCH 00/10] [PULL] qemu-kvm.git uq/master queue

2010-10-20 Thread Anthony Liguori
/master Pulled (with additional build fixes). Regards, Anthony Liguori Huang Ying (1): Add RAM -> physical addr mapping in MCE simulation Joerg Roedel (2): Set cpuid definition to 0 before initializing it Add svm cpuid features Marcelo Tosatti (7): signa

Re: [PATCH 08/10] MCE: Relay UCR MCE to guest

2010-10-20 Thread Anthony Liguori
On 10/20/2010 02:51 PM, Anthony Liguori wrote: +} + static void qemu_kvm_eat_signal(CPUState *env, int timeout) { struct timespec ts; int r, e; siginfo_t siginfo; sigset_t waitset; +sigset_t chkset; ts.tv_sec = timeout / 1000; ts.tv_nsec = (timeout

Re: [PATCH 05/10] kvm: x86: add mce support

2010-10-20 Thread Anthony Liguori
"); +else +env->mcg_cap = mcg_cap; CODING_STYLE. +} +} +#endif + return kvm_vcpu_ioctl(env, KVM_SET_CPUID2,&cpuid_data); } diff --git a/target-i386/kvm_x86.h b/target-i386/kvm_x86.h new file mode 100644 index 000..c1ebd24 --- /

Re: [PATCH 07/10] Add RAM -> physical addr mapping in MCE simulation

2010-10-20 Thread Anthony Liguori
art_addr + (ram_addr - mem->phys_offset); +return 1; +} +} This is bogus. There isn't one mapping from ram_addr_t to target_phys_addr_t. There may be many because or RAM aliasing. Using KVMSlot is also wrong. This is a function that belongs in exec.c. Regards, Ant

Re: [PATCH 09/10] Add savevm/loadvm support for MCE

2010-10-20 Thread Anthony Liguori
for (i = 0; i< (env->mcg_cap& 0xff) * 4; i++) +msrs[n++].index = MSR_MC0_CTL + i; +} +#endif + This patch does not respect CODING_STYLE with respect to single line ifs at all. Regards, Anthony Liguori msr_data.info.nmsrs = n; ret = kvm_vcpu_ioctl(env, KV

Re: [PATCH 00/10] [PULL] qemu-kvm.git uq/master queue

2010-10-20 Thread Anthony Liguori
mce support Export qemu_ram_addr_from_host MCE: Relay UCR MCE to guest Add savevm/loadvm support for MCE Fix memory leak in register save load due to xsave support The MCE doesn't look to be ready for prime time yet. Regards, Anthony Liguori Makef

Re: [PATCH 08/10] MCE: Relay UCR MCE to guest

2010-10-20 Thread Anthony Liguori
EERR_AO) { +return 0; +} else if (code == BUS_MCEERR_AR) { +hardware_memory_error(); +} else { +return 1; +} +} +return 0; +} diff --git a/target-i386/kvm_x86.h b/target-i386/kvm_x86.h index c1ebd24..04932cf 100644 --- a/target-i386/kvm_x86.h +++ b/target-i386/kvm_x86.h @@ -16,6 +16,7 @@ #define __KVM_X86_H__ void kvm_inject_x86_mce(CPUState *cenv, int bank, uint64_t status, -uint64_t mcg_status, uint64_t addr, uint64_t misc); +uint64_t mcg_status, uint64_t addr, uint64_t misc, +int abort_on_error); #endif Regards, Anthony Liguori -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/10] [PULL] qemu-kvm.git uq/master queue

2010-10-20 Thread Anthony Liguori
On 10/20/2010 02:05 PM, Marcelo Tosatti wrote: On Wed, Oct 20, 2010 at 02:01:18PM -0500, Anthony Liguori wrote: On 10/20/2010 12:43 PM, Marcelo Tosatti wrote: The following changes since commit 38cc9b607f85017b095793cab6c129bc9844f441: issue snd_pcm_start() when capturing audio

Re: [PATCH 00/10] [PULL] qemu-kvm.git uq/master queue

2010-10-20 Thread Anthony Liguori
rds, ANthony Liguori Makefile.objs |1 + compatfd.c| 117 ++ compatfd.h| 43 +++ configure | 18 +++ cpu-common.h |3 +- cpus.c| 156 ++-- exec-all.h|

Re: [Qemu-devel] KVM call minutes for Oct 19

2010-10-20 Thread Anthony Liguori
don't think we want to have a common agent for physical and virtual systems. The requirements are actually very different. The virtual agent exists solely to support hypervisor functionality. Not to provide general purpose system management support. Regards, Anthony Liguori Regar

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-20 Thread Anthony Liguori
On 10/20/2010 04:18 AM, Kevin Wolf wrote: Am 19.10.2010 19:09, schrieb Anthony Liguori: On 10/19/2010 11:54 AM, Ayal Baron wrote: - "Anthony Liguori" wrote: On 10/19/2010 07:48 AM, Dor Laor wrote: On 10/19/2010 04:11 AM, Chris Wr

Re: [Qemu-devel] KVM call minutes for Oct 19

2010-10-20 Thread Anthony Liguori
ing a single agent (not an agent framework) is important if we want these interfaces to be ubiquitous. This really means that the guest agent should be part of the QEMU source tree IMHO so that there is always a standard version of the agent. Regards, Anthony Liguori Alex -- To unsubscribe from

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Anthony Liguori
ntation. But in the long term, I think the most elegant solution would be to expose the freeze api via QMP and let a management tool freeze multiple devices, then start taking snapshots, then unfreeze them when all snapshots are complete. Regards, Anthony Liguori qemu should call the f

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Anthony Liguori
On 10/19/2010 11:54 AM, Ayal Baron wrote: - "Anthony Liguori" wrote: On 10/19/2010 07:48 AM, Dor Laor wrote: On 10/19/2010 04:11 AM, Chris Wright wrote: * Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you are int

Re: [Qemu-devel] [PATCH 00/10] [PULL] qemu-kvm.git uq/master queue

2010-10-19 Thread Anthony Liguori
--build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu Thread model: posix gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5) Regards, Anthony Liguori Huang Ying (1): Add RAM -> physical addr mapping in MCE simulation Joerg Roedel (2): Set cpuid definition to 0 befo

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Anthony Liguori
On 10/19/2010 08:27 AM, Avi Kivity wrote: On 10/19/2010 03:22 PM, Anthony Liguori wrote: I had assumed that this would involve: qemu -hda windows.img (qemu) snapshot ide0-disk0 snap0.img 1) create snap0.img internally by doing the equivalent of `qemu-img create -f qcow2 -b windows.img

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Anthony Liguori
ould avoid external device models because of difficulty integrating QEMU features with external device models. However, I'd like to hear opinions from a wider audience. Regards, Anthony Liguori -- To unsubscribe from this list: send the line "unsubscribe kvm" in the bo

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Anthony Liguori
x27;snap0.img', 'windows.img') 7) rename('windows.img.tmp', 'snap0.img') Regards, Anthony Liguori - Integration with FS freeze for consistent guest app snapshot Many apps do not sync their ram state to disk correctly or frequent enough. Physical world

Re: [Qemu-devel] Re: KVM call agenda for Oct 19

2010-10-19 Thread Anthony Liguori
r later this week but for those that are interested the repo is at http://repo.or.cz/w/qemu/mdroth.git Regards, Anthony Liguori What about FS that span over LVM with multiple drives? IDE/SCSI? Good points. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the b

Re: [PATCH] virtio: Use ioeventfd for virtqueue notify

2010-10-19 Thread Anthony Liguori
On 10/19/2010 08:07 AM, Stefan Hajnoczi wrote: Is there anything stopping this patch from being merged? Michael, any objections? If not, I'll merge it. Regards, Anthony Liguori Thanks, Stefan -- To unsubscribe from this list: send the line "unsubscribe kvm" i

Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

2010-10-18 Thread Anthony Liguori
On 10/18/2010 03:22 AM, Roedel, Joerg wrote: (Sorry for the late reply) On Thu, Oct 07, 2010 at 08:48:06AM -0400, Anthony Liguori wrote: On 10/07/2010 03:42 AM, Roedel, Joerg wrote: On Wed, Oct 06, 2010 at 03:24:59PM -0400, Anthony Liguori wrote: +qemu_compat_version

Re: Passing in additional info to guest OS and e1000 test suite?

2010-10-15 Thread Anthony Liguori
On 10/15/2010 01:49 PM, Anjali Kulkarni wrote: Hi, - If I want to pass in additional arguments to the guest OS while booting(in particular which slot I want to map a nic to) - is there any way to do it? Some kind of configuration file that I can pass in would also be ok for me. - Is there a KVM/

Re: [Qemu-devel] Hitting 29 NIC limit

2010-10-14 Thread Anthony Liguori
On 10/14/2010 05:12 PM, Anjali Kulkarni wrote: Thanks. Does this work for e1000 as well? Haven't tried. I don't know how various e1000 drivers would react. Also, does it support pci hotplug? No, but that's fixable down the road. Regards, Anthony Liguori Anjali

Re: [Qemu-devel] Hitting 29 NIC limit

2010-10-14 Thread Anthony Liguori
a PCI address that includes a function number. Then you can pack 8 virtio PCI devices into a single slot. Regards, Anthony Liguori Anjali On 10/14/10 2:57 PM, "Anthony Liguori" wrote: On 10/14/2010 04:42 PM, Richard W.M. Jones wrote: On Thu, Oct 14, 2010 at 01:10:47PM

<    4   5   6   7   8   9   10   11   12   13   >