[KVM-AUTOTEST PATCH 3/5] KVM test: kvm_utils.load_env(): do not fail if env file is corrupted

2010-03-21 Thread Michael Goldish
- Include the unpickling code in the 'try' block, so that an exception raised during unpickling will not fail the test. - Change the default env (returned by load_env() when the file is missing or corrupt) to {}. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm

[KVM-AUTOTEST PATCH 5/5] KVM test: take frequent screendumps during all tests

2010-03-21 Thread Michael Goldish
place.) Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py | 85 +-- client/tests/kvm/tests_base.cfg.sample | 13 - 2 files changed, 89 insertions(+), 9 deletions(-) diff --git a/client/tests/kvm/kvm_preprocessing.py b

[KVM-AUTOTEST PATCH] KVM test: support TAP networking mode when executing tests in parallel

2010-03-19 Thread Michael Goldish
- Add kvm_utils.get_sub_pool() which splits a MAC-IP pool in several pieces. - Use get_sub_pool() in kvm_scheduler immediately before launching a test. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_scheduler.py |1 + client/tests/kvm/kvm_utils.py | 55

[KVM-AUTOTEST PATCH] KVM test: kvm_config: remove -f command line option

2010-03-19 Thread Michael Goldish
This patch changes the command line invokation of kvm_config.py from this: ./kvm_config.py --verbose -f filename to this: ./kvm_config.py --verbose filename and also makes the dict printing code slightly shorter. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm

Re: [PATCH] KVM test: Make sure check_image script runs on VMs turned off

2010-03-10 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: As it is hard to guarantee that a qcow2 image will be in a consistent state with a VM turned on, take an extra safety step and make sure the preprocessor shuts down the VMs before the post process command check_image.py runs.

Re: [PATCH] [Autotest] [KVM-AUTOTEST] fix tap interface for parallel execution

2010-03-10 Thread Michael Goldish
- Yogananth Subramanian anant...@linux.vnet.ibm.com wrote: Adds support to create guests with different MAC address during parallel execution of autotest, this is done by creating worker dicts with different address_index Signed-off-by: Yogananth Subramanian

Re: [KVM-AUTOTEST PATCH v4] KVM test: A memory efficient kvm_config implementation

2010-03-03 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: On Tue, 2010-03-02 at 19:30 +0200, Michael Goldish wrote: This patch: - Makes kvm_config use less memory during parsing, by storing config data compactly in arrays during parsing, and generating the final dicts only when

[KVM-AUTOTEST PATCH v4] KVM test: A memory efficient kvm_config implementation

2010-03-02 Thread Michael Goldish
a dict generator instead of a list. This should save some more memory and will make tests start sooner. - Use get_generator() in control. - Call waitpid() at the end of fork_and_parse(). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/control | 30 +- client

[KVM-AUTOTEST PATCH] [RFC] KVM test: A memory efficient kvm_config implementation

2010-02-25 Thread Michael Goldish
. This patch has only been tested outside autotest so it may contain bugs. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/control | 16 +- client/tests/kvm/control.parallel |2 +- client/tests/kvm/kvm_config.py| 652 ++--- 3

[KVM-AUTOTEST PATCH v2] [RFC] KVM test: A memory efficient kvm_config implementation

2010-02-25 Thread Michael Goldish
(). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/control | 30 +- client/tests/kvm/control.parallel | 21 +- client/tests/kvm/kvm_config.py| 669 +++-- 3 files changed, 440 insertions(+), 280 deletions(-) diff --git a/client

Re: [PATCH] [RFC] KVM test: Control files automatic generation to save memory

2010-02-18 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: On Sun, 2010-02-14 at 12:07 -0500, Michael Goldish wrote: - Lucas Meneghel Rodrigues l...@redhat.com wrote: As our configuration system generates a list of dicts with test parameters, and that list might be potentially

Re: [PATCH] KVM test: Modifying finish.exe to support parallel installs

2010-02-14 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: In order to adapt all the OS unattended installs to parallel installs, finish.exe also had to be adapted to be a server instead of a client. These are the modifications needed. Once the whole patchset is worked out, an updated version

Re: [PATCH] [RFC] KVM test: Control files automatic generation to save memory

2010-02-14 Thread Michael Goldish
/kvm/control +++ /dev/null @@ -1,64 +0,0 @@ -AUTHOR = -u...@redhat.com (Uri Lublin) -dru...@redhat.com (Dror Russo) -mgold...@redhat.com (Michael Goldish) -dh...@redhat.com (David Huff) -aerom...@redhat.com (Alexey Eromenko) -mbu...@redhat.com (Mike Burns) - -TIME = 'MEDIUM' -NAME

Re: [PATCH] KVM test: Ensure multiple pre/post commands can run

2010-02-07 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: The way tests are currently defined, running unattended install + hugepages will allways skip unattended install setup step (coincidentally the tests on our test farm were working because previous executions of the unattended install

Re: [PATCH] KVM: tests_base.cfg: major guest OS cleanup

2010-02-07 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: Major update and cleanup on guest OS definition: * Fedora 8, 9, 10 dropped * RHEL versions bumped to the latest stable versions * Windows 2008, Vista and 7 bumped to the last versions * Some duplicate information re-organized

[KVM-AUTOTEST PATCH 1/1] KVM test: kvm_vm.py: shorten VM.destroy()

2010-02-03 Thread Michael Goldish
Call self.pci_assignable.release_devs() in the finally block. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 6731927

[KVM-AUTOTEST PATCH 1/1] KVM test: make sure the boot test does what it's supposed to

2010-02-03 Thread Michael Goldish
Currently the boot test starts the VM only if it isn't already running. If the VM is running, the boot test is essentially a login test. 'restart_vm = yes' will make the preprocessor restart the VM anyway. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm

Re: [PATCH 6/6] KVM test: Add a get_started.py script

2010-02-03 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: In order to make it easier to get started with KVM testing, add a script that helps with setting up directories, paths and iso files for the default test configuration (Fedora 12 guest install, boot test, shutdown). Once the first idea

Re: [Autotest] [PATCH 3/6] KVM test: Make sure reset and shutdown are the last ones

2010-02-03 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: system_reset, system_powerdown and shutdown *must* be the last ones defined, since the effect of such tests can leave the VM on a bad state. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com ---

Re: [Autotest] [RFC] KVM test: Ship rss.exe and finish.exe binaries with KVM test

2010-02-03 Thread Michael Goldish
- Uri Lublin u...@redhat.com wrote: On 02/02/2010 01:48 PM, Lucas Meneghel Rodrigues wrote: Hi folks: We're on an effort of streamlining the KVM test experience, by choosing sane defaults and helper scripts that can overcome the initial barrier with getting the KVM test running.

Re: [PATCH AUTOTEST] kvm: timedrift test: fix typo (host_delta_t)

2010-02-03 Thread Michael Goldish
- Uri Lublin u...@redhat.com wrote: Signed-off-by: Uri Lublin u...@redhat.com --- client/tests/kvm/tests/timedrift.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/tests/timedrift.py b/client/tests/kvm/tests/timedrift.py index

[KVM-AUTOTEST PATCH] KVM test: automate handling of cdkeys in unattended_install scripts

2010-02-03 Thread Michael Goldish
, for WinVista, Win2008 and Win7. These must be replaced manually by the user. Warning: this patch has undergone zero testing. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/cdkeys.cfg.sample | 13 +++-- client/tests/kvm/scripts/unattended.py

Re: [Autotest] [Autotest PATCH] KVM-test: Add a subtest 'qemu_img'

2010-01-27 Thread Michael Goldish
- Yolkfull Chow yz...@redhat.com wrote: On Tue, Jan 26, 2010 at 03:11:34PM -0200, Lucas Meneghel Rodrigues wrote: On Tue, 2010-01-26 at 11:25 +0800, Yolkfull Chow wrote: This is designed to test all subcommands of 'qemu-img' however so far 'commit' is not implemented. Hi

Re: [PATCH 1/2] KVM test: Make sure setup does not execute on unattended install

2010-01-20 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: If we are going unattended install, make sure the step based setup doesn't run, as the unattended install procedure already takes care of guest setup. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com ---

Re: [PATCH] KVM test: Enable qemu upstream testing

2010-01-20 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: qemu upstream has slight differences regarding qemu-kvm on the set of flags it supports. One of the most important differences is that on qemu we have to set -enable-kvm explicitely. Take this into consideration on the base configuration

Re: [PATCH] KVM test: tests_base.cfg updated with windows unattended install

2010-01-20 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: Update the config file tests_base.cfg with the recently added windows unattended install files (r4109), so one is actually able to use them on tests. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com ---

Re: [Autotest] [AUTOTEST PATCH 1/2] KVM-test: Fix a bug that about list slice in scan_results.py

2009-12-31 Thread Michael Goldish
GOOD/FAIL/ERROR lines are always preceded by START lines, and info_list is appended a when parsing a START line, so it seems unreasonable for info_list to be empty when parsing a GOOD/FAIL/ERROR line. What file did you parse when you got that exception? Can you reproduce the problem and show me

Re: [Autotest PATCH] KVM test: No need close session when login timeout

2009-12-26 Thread Michael Goldish
- Amos Kong ak...@redhat.com wrote: On Fri, Dec 25, 2009 at 08:28:18AM -0500, Michael Goldish wrote: - Amos Kong ak...@redhat.com wrote: If login timeout, wait_for() returned 'None' and assigned to 'session'. When call session.close(), this prlblem was caused

Re: [Autotest PATCH] KVM test: No need close session when login timeout

2009-12-25 Thread Michael Goldish
- Amos Kong ak...@redhat.com wrote: If login timeout, wait_for() returned 'None' and assigned to 'session'. When call session.close(), this prlblem was caused: AttributeError: 'NoneType' object has no attribute 'close' Signed-off-by: Amos Kong ak...@redhat.com ---

[KVM-AUTOTEST PATCH 1/2] KVM test: add proper prefixes to image, iso and step file paths

2009-12-23 Thread Michael Goldish
-Autotest expect isos, images and step files under their respective subdirectories, by adding prefixes to the paths in tests_base.cfg.sample. 2. Removes unnecessary prefixes from tests.cfg.sample. 3. Fixes comments in tests.cfg.sample. Signed-off-by: Michael Goldish mgold...@redhat.com --- client

[KVM-AUTOTEST PATCH 2/2] KVM test: warn about corrupt PPM files after each test

2009-12-23 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_preprocessing.py b/client/tests/kvm/kvm_preprocessing.py index 5bae2bd..4e45c76 100644 --- a/client/tests

Re: [PATCH] KVM test: Fix subtest imports

2009-12-02 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: The KVM test was breaking when trying to import the subtest 'autotest', as a naming clash was happening (client/bin/autotest was being imported instead of the autotest subtest), so to make naming clashes less likely, import test.[type]

[KVM-AUTOTEST PATCH] KVM test: step file tests: apply timeout_multiplier to 'sleep' as well as barriers

2009-12-02 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/steps.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/tests/steps.py b/client/tests/kvm/tests/steps.py index 11b2ae1..456fb44 100644 --- a/client/tests/kvm/tests/steps.py

[KVM-AUTOTEST PATCH] KVM test: use the imp module to import subtest module by filename

2009-12-02 Thread Michael Goldish
This fixes a problem with importing the autotest subtest. It may be safer than importing tests.testname because, according to the Python documentation, imp.find_module() searches only the given path, regardless of what's in sys.path. Signed-off-by: Michael Goldish mgold...@redhat.com --- client

Re: [KVM-AUTOTEST PATCH] Improve kvm subtest AutoIt - add option to download script from remote server

2009-11-30 Thread Michael Goldish
- Chen Cao k...@redhat.com wrote: Add an option to let user download the .au3 script from a remote server, and keep the original method to prepare the script. This makes it possible to employ AutoIt tests that involve several files. new variants: 1. download, if

Re: [Autotest] [PATCH] KVM test: Change the way subtests are loaded

2009-11-25 Thread Michael Goldish
- sudhir kumar smalik...@gmail.com wrote: On Sat, Oct 31, 2009 at 3:37 AM, Lucas Meneghel Rodrigues l...@redhat.com wrote: Recently autoserv changed its default behavior of rsyncing the whole client directory to the test machine, now it will copy only the needed tests to the client

Re: [PATCH] Increase waiting time before first session check in kvm_test_utils.reboot

2009-11-25 Thread Michael Goldish
- Chen Cao k...@redhat.com wrote: Increase the sleeping time before the first check to 10 seconds, and try every 2 seconds. But increasing these values cannot really solve the following problem: Guest is too heavy loaded, and have no time to response the rebooting

Re: [PATCH] KVM test: migration subtest: Handle case where session2 does not exist

2009-11-15 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: In one of the code blocks of the migration test, a finally clause tries to send a command to a session. However, if we are not successful in actually creating a session, that object will hold None, which doesn't have an is_alive

[KVM-AUTOTEST PATCH 1/6] KVM test: disable password prompt on resume for Windows guests

2009-11-04 Thread Michael Goldish
Add a command to setuprss.bat that disables the password prompt on resuming from hibernation. Note that for this change to take effect the local winutils.iso should be updated as well. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/deps/setuprss.bat |1 + 1 files

[KVM-AUTOTEST PATCH 2/6] KVM test: fix 2 barriers in WinXP-32.steps

2009-11-04 Thread Michael Goldish
Don't select the start word, which is usually rendered with antialiased characters, but is sometimes aliased for some reason. I'm not sure if this is just weird Windows behavior or some sort of qemu/KVM bug. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/steps/WinXP-32

[KVM-AUTOTEST PATCH 3/6] KVM test: migration: rely on background process instead of timing

2009-11-04 Thread Michael Goldish
will not keep running. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample |6 ++ client/tests/kvm/tests/migration.py| 84 +-- client/tests/kvm/tests/timedrift_with_migration.py |2 +- 3 files changed, 64

[KVM-AUTOTEST PATCH 4/6] KVM test: fix WinVista setup step files

2009-11-04 Thread Michael Goldish
Use the file browser to run setuprss.bat as administrator. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/steps/WinVista-32-rss.steps | 59 +- client/tests/kvm/steps/WinVista-64-rss.steps | 59 +- 2 files changed, 58

[KVM-AUTOTEST PATCH 5/6] KVM test: kvm_subprocess.py: avoid double-closing file descriptors

2009-11-04 Thread Michael Goldish
Also, properly handle closed file descriptors in read_until_output_matches(). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm/kvm_subprocess.py b/client

[KVM-AUTOTEST PATCH 6/6] KVM test: add -o PreferredAuthentications=password to SSH options

2009-11-04 Thread Michael Goldish
This speeds up SSH logins because by default other time consuming authentication methods are attempted first. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-31 Thread Michael Goldish
- Ryan Harper ry...@us.ibm.com wrote: * Lucas Meneghel Rodrigues l...@redhat.com [2009-10-28 14:48]: Ryan, Michael: I absolutely agree that the ability to debug stuff is important, but the ability to make things straightforward to use from the web interface or cli is also

Re: [Autotest] [KVM-AUTOTEST PATCH 3/7] KVM test: new test timedrift_with_migration

2009-10-28 Thread Michael Goldish
- Dor Laor dl...@redhat.com wrote: On 10/12/2009 05:28 PM, Lucas Meneghel Rodrigues wrote: Hi Michael, I am reviewing your patchset and have just a minor remark to make here: On Wed, Oct 7, 2009 at 2:54 PM, Michael Goldishmgold...@redhat.com wrote: This patch adds a new test

Re: [PATCH] KVM Test: Add re.IGNORECASE to re.compile to verify_ip_address_ in kvm_utils.py

2009-10-28 Thread Michael Goldish
Thanks for catching this. While we're at it, why not remove the 2 occurrences of re.IGNORECASE that have no effect? We can also replace re.search(regex, o) with the slightly shorter regex.search(o), but that's just a cosmetic change. - Original Message - From: Chen Cao k...@redhat.com To:

Re: [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
I think this patch is a good idea. Comments: - If we've decided to put all the configuration in config files (rather than the control file) let's split up the main one into kvm_test_library.cfg and kvm_tests.cfg.sample. The latter should look like this: include kvm_test_library.cfg include

Re: [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
-0400, Michael Goldish wrote: I think this patch is a good idea. Comments: - If we've decided to put all the configuration in config files (rather than the control file) let's split up the main one into kvm_test_library.cfg and kvm_tests.cfg.sample. The latter should look like

Re: [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
the user replaced 'noinstall' with something else). Alternatively, we can disable installation in the control file by commenting out some line. - Original Message - From: Lucas Meneghel Rodrigues l...@redhat.com To: Michael Goldish mgold...@redhat.com Cc: kvm@vger.kernel.org, u...@redhat.com

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: On Wed, Oct 28, 2009 at 1:43 PM, Michael Goldish mgold...@redhat.com wrote: Sounds great, except it won't allow you to debug your configuration using kvm_config.py.  So the question now is what's more important -- the ability

Re: [Autotest] [PATCH] KVM test: Add new program cd_hash.py

2009-10-28 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: A new program that evaluates hash strings, intended to help kvm autotest administrators was added, cd_hash. Usage: cd_hash.py [options] Options: -h, --helpshow this help message and exit -i FILENAME, --iso=FILENAME

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
it with a fake job object whose run_test() method will just print the params dict instead of running the test. - Original Message - From: Lucas Meneghel Rodrigues l...@redhat.com To: Ryan Harper ry...@us.ibm.com Cc: Michael Goldish mgold...@redhat.com, autot...@test.kernel.org, u

Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-21 Thread Michael Goldish
- Amos Kong ak...@redhat.com wrote: On Tue, Oct 20, 2009 at 09:19:50AM -0400, Michael Goldish wrote: See comments below. Hi all, Thanks for your reply. - Dor Laor dl...@redhat.com wrote: On 10/15/2009 11:48 AM, Amos Kong wrote: Test 802.1Q vlan of nic, config

Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-20 Thread Michael Goldish
See comments below. - Dor Laor dl...@redhat.com wrote: On 10/15/2009 11:48 AM, Amos Kong wrote: Test 802.1Q vlan of nic, config it by vconfig command. 1) Create two VMs 2) Setup guests in different vlan by vconfig and test communication by ping using hard-coded ip

[KVM-AUTOTEST PATCH 1/3] KVM test: VM.send_monitor_cmd() minor cleanup

2009-10-15 Thread Michael Goldish
- Move some of the code into a try..finally block - Shutdown the socket before closing it Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 45 --- 1 files changed, 25 insertions(+), 20 deletions(-) diff --git a/client

[KVM-AUTOTEST PATCH 3/3] KVM test: modify messages in kvm_test_utils.wait_for_login()

2009-10-15 Thread Michael Goldish
Use logged into guest instead of logged in guest. AFAIK this is more correct. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_test_utils.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/kvm_test_utils.py b/client/tests

[KVM-AUTOTEST PATCH 2/3] KVM test: corrections to guest_s4

2009-10-15 Thread Michael Goldish
guests with an annoying welcome screen. - Make the logging messages more consistent with the style of other tests. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample | 23 - client/tests/kvm/tests/guest_s4.py| 45

[KVM-AUTOTEST PATCH 1/3] KVM test: kvm_subprocess.py: do not start tail thread by default

2009-10-13 Thread Michael Goldish
Start the tail thread only if the user specifies a non-None output_func or termination_func. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm

[KVM-AUTOTEST PATCH 2/3] KVM test: kvm_subprocess.py: use only unbound methods as close() hooks

2009-10-13 Thread Michael Goldish
, and if the method is bound to the same instance then we have a self-reference that prevents garbage collection. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm

[KVM-AUTOTEST PATCH 3/3] KVM test: kvm_subprocess.py: automatically close unreferenced shell sessions

2009-10-13 Thread Michael Goldish
Note that if a session has a tracking thread (i.e. if output_func or termination_func are set to something other than None) then the session will not be garbage collected (it must be closed explicitly by the test). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm

Re: [KVM-AUTOTEST,01/17] Add new module kvm_subprocess

2009-10-13 Thread Michael Goldish
- Chen Cao k...@redhat.com wrote: On Mon, Oct 12, 2009 at 09:07:45AM -0400, Michael Goldish wrote: You're right, currently the sessions must be closed explicitly. This is due to the fact that both qemu and ssh/telnet are handled by the same code, and qemu has to keep running

Re: [KVM-AUTOTEST,01/17] Add new module kvm_subprocess

2009-10-12 Thread Michael Goldish
in one big try..finally block: session = ... try: try: except: try: except: ... finally: session.close() - Original Message - From: Chen Cao k...@redhat.com To: Michael Goldish mgold...@redhat.com Cc: autot...@test.kernel.org, kvm@vger.kernel.org Sent: Monday, October 12, 2009 8

Re: [Autotest] [KVM-AUTOTEST PATCH 3/7] KVM test: new test timedrift_with_migration

2009-10-12 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: Hi Michael, I am reviewing your patchset and have just a minor remark to make here: On Wed, Oct 7, 2009 at 2:54 PM, Michael Goldish mgold...@redhat.com wrote: This patch adds a new test that checks the timedrift introduced

[KVM-AUTOTEST PATCH 1/7] KVM test: migration test: move the bulk of the code to a utility function

2009-10-07 Thread Michael Goldish
Move most of the code to a utility function in kvm_test_utils.py, in order to make it reusable. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_test_utils.py | 72 +++ client/tests/kvm/tests/migration.py | 62

[KVM-AUTOTEST PATCH 2/7] KVM test: timedrift test: move the get_time() helper function to kvm_test_utils.py

2009-10-07 Thread Michael Goldish
Move get_time() to kvm_test_utils.py to make it reusable. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_test_utils.py | 27 ++ client/tests/kvm/tests/timedrift.py | 164 -- 2 files changed, 104 insertions(+), 87 deletions

[KVM-AUTOTEST PATCH 4/7] KVM test: move the reboot code to kvm_test_utils.py

2009-10-07 Thread Michael Goldish
Move the reboot code from the boot test (tests/boot.py) to kvm_test_utils.py in order to make it reusable. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_test_utils.py | 44 client/tests/kvm/tests/boot.py | 33

[KVM-AUTOTEST PATCH 6/7] KVM test: add option to kill all unresponsive VMs at the end of each test

2009-10-07 Thread Michael Goldish
This is useful for tests that may leave VMs in a bad state but can't afford to use kill_vm_on_error = yes. For example, timedrift.with_reboot can fail because the reboot failed or because the time drift was too large. In the latter case there's no reason to kill the VM. Signed-off-by: Michael

[KVM-AUTOTEST PATCH 3/7] KVM test: new test timedrift_with_migration

2009-10-07 Thread Michael Goldish
This patch adds a new test that checks the timedrift introduced by migrations. It uses the same parameters used by the timedrift test to get the guest time. In addition, the number of migrations the test performs is controlled by the parameter 'migration_iterations'. Signed-off-by: Michael

[KVM-AUTOTEST PATCH 7/7] KVM test: kvm_preprocessing.py: fix indentation and logging messages in postprocess_vm

2009-10-07 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm/kvm_preprocessing.py b/client/tests/kvm/kvm_preprocessing.py index e624a42..5bae2bd 100644 --- a/client

[KVM-AUTOTEST PATCH 5/7] KVM test: new test timedrift_with_reboot

2009-10-07 Thread Michael Goldish
Checks the time drift introduced by several reboots (default 1). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample |5 ++ client/tests/kvm/tests/timedrift_with_reboot.py | 88 +++ 2 files changed, 93 insertions(+), 0

[KVM-AUTOTEST PATCH 1/6] KVM test: kvm_subprocess: use read_nonblocking(0) instead of read_nonblocking (0.1)

2009-09-29 Thread Michael Goldish
() to send commands (because the former waits for the prompt to return, whereas the latter returns immediately). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm

[KVM-AUTOTEST PATCH 2/6] KVM test: AutoIt and Autotest wrappers: use get_command_output() instead of sendline()

2009-09-29 Thread Michael Goldish
to complete, and this will make the wrapper exit as if the test has completed. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/autoit.py |7 +++ client/tests/kvm/tests/autotest.py |9 - 2 files changed, 7 insertions(+), 9 deletions(-) diff --git

[KVM-AUTOTEST PATCH 4/6] KVM test: step file tests: add parameter timeout_multiplier

2009-09-29 Thread Michael Goldish
the test more time to complete. In addition to modifying tests/steps.py, this patch adds a usage example to control and control.parallel. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/control |1 + client/tests/kvm/control.parallel |1 + client/tests/kvm/tests

[KVM-AUTOTEST PATCH 3/6] KVM test: kvm_vm.py: change qemu-img timeout to 120 seconds

2009-09-29 Thread Michael Goldish
The timeout of qemu-img commands is currently 30 seconds. This may not suffice under heavy load (e.g. when multiple tests run in parallel and use the same physical disk). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py |2 +- 1 files changed, 1 insertions

[KVM-AUTOTEST PATCH 5/6] KVM test: tests/steps.py: simplify barrier_2()

2009-09-29 Thread Michael Goldish
= float(params.get(timeout_multiplier, 1)) will raise an exception if timeout_multiplier is . Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/steps.py | 32 ++-- 1 files changed, 10 insertions(+), 22 deletions(-) diff --git a/client/tests/kvm

[KVM-AUTOTEST PATCH 6/6] KVM test: kvm_subprocess: use select() in read_until_output_matches()

2009-09-29 Thread Michael Goldish
until there's output to read from the child process. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/kvm_subprocess.py b/client/tests/kvm/kvm_subprocess.py

Re: [Autotest] [KVM-AUTOTEST PATCH] Adding NAS Parallel Benchmarks(NPB) as client test [1/2]

2009-09-21 Thread Michael Goldish
- Chen Cao k...@redhat.com wrote: - Using NPB OpenMP implementaion. Signed-off-by: Cao, Chen k...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample |4 + client/tests/npb/control| 28 client/tests/npb/enable-all-tests.patch | 233

Re: [Autotest] [KVM-AUTOTEST PATCH 2/4] KVM test: rss.cpp: send characters to the console window rather than directly to STDIN

2009-09-21 Thread Michael Goldish
- Yolkfull Chow yz...@redhat.com wrote: On Sun, Sep 20, 2009 at 06:16:28PM +0300, Michael Goldish wrote: Some Windows programs behave badly when their STDIN is redirected to a pipe (most notably wmic). Therefore, keep STDIN unredirected, and send input to the console window

[KVM-AUTOTEST PATCH v3] [RFC] KVM test: client parallel test execution

2009-09-20 Thread Michael Goldish
it yet. scan_results.py can be used to list the test results during and after execution. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/control.parallel | 176 client/tests/kvm/kvm_scheduler.py | 229 + 2

[KVM-AUTOTEST PATCH 1/4] KVM test: allow setting shell line separator string in the config file

2009-09-20 Thread Michael Goldish
The shell line separator string is appended to strings sent by sendline(). The string is controlled by the parameter shell_linesep. It defaults to \n. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample |1 + client/tests/kvm/kvm_utils.py

[KVM-AUTOTEST PATCH 2/4] KVM test: rss.cpp: send characters to the console window rather than directly to STDIN

2009-09-20 Thread Michael Goldish
Some Windows programs behave badly when their STDIN is redirected to a pipe (most notably wmic). Therefore, keep STDIN unredirected, and send input to the console window as a series of WM_CHAR messages. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/deps/rss.cpp | 54

[KVM-AUTOTEST PATCH 3/4] KVM test: WinXP-64-rss.steps: modify first barrier

2009-09-20 Thread Michael Goldish
The start menu button seems to have two possible appearances. Therefore change the barrier to test the center of the screen (including the mouse cursor) instead. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/steps/WinXP-64-rss.steps |2 +- 1 files changed, 1

Re: [Autotest] [KVM-AUTOTEST PATCH 0/7] KVM test: support for the new remote shell server for Windows

2009-09-17 Thread Michael Goldish
- Michael Goldish mgold...@redhat.com wrote: - Yolkfull Chow yz...@redhat.com wrote: On Tue, Aug 18, 2009 at 06:30:14PM -0400, Michael Goldish wrote: - Lucas Meneghel Rodrigues l...@redhat.com wrote: On Tue, Aug 18, 2009 at 7:15 AM, Michael Goldishmgold

Re: [Autotest] [PATCH 12/19] KVM test: Add new module kvm_test_utils.py

2009-09-14 Thread Michael Goldish
- Uri Lublin u...@redhat.com wrote: On 09/14/2009 08:26 AM, Yolkfull Chow wrote: On Wed, Sep 09, 2009 at 09:12:05PM +0300, Michael Goldish wrote: This module is meant to reduce code size by performing common test procedures. Generally, code here should look like test code. +def

[KVM-AUTOTEST PATCH 1/4] KVM test: migration test: destroy dest_vm if test fails

2009-09-14 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.py | 94 ++--- 1 files changed, 50 insertions(+), 44 deletions(-) diff --git a/client/tests/kvm/kvm_tests.py b/client/tests/kvm/kvm_tests.py index b61d98c..446b415 100644

[KVM-AUTOTEST PATCH 2/4] KVM test: wait_for_login(): include the VM's name in log messages

2009-09-14 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_test_utils.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/kvm_test_utils.py b/client/tests/kvm/kvm_test_utils.py index 39e92b9..9924232 100644 --- a/client/tests/kvm

[KVM-AUTOTEST PATCH 3/4] KVM test: kvm_vm.py: wrap VM.destroy() in a try-finally block

2009-09-14 Thread Michael Goldish
This makes the function a little shorter or at least a little cleaner. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 84 ++-- 1 files changed, 42 insertions(+), 42 deletions(-) diff --git a/client/tests/kvm

Re: [PATCH] Adding a userspace application crash handling system to autotest

2009-09-14 Thread Michael Goldish
I think this is a very useful feature to have. Please see some very minor comments below. - Lucas Meneghel Rodrigues l...@redhat.com wrote: This patch adds a system to watch user space segmentation faults, writing core dumps and some degree of core dump analysis report. We believe that

Re: [Autotest] [KVM-AUTOTEST PATCH 0/7] KVM test: support for the new remote shell server for Windows

2009-09-14 Thread Michael Goldish
- Yolkfull Chow yz...@redhat.com wrote: On Tue, Aug 18, 2009 at 06:30:14PM -0400, Michael Goldish wrote: - Lucas Meneghel Rodrigues l...@redhat.com wrote: On Tue, Aug 18, 2009 at 7:15 AM, Michael Goldishmgold...@redhat.com wrote: - Lucas Meneghel Rodrigues l

[KVM-AUTOTEST PATCH v2 1/3] KVM test: use a better source for random numbers

2009-09-11 Thread Michael Goldish
and is probably done by default anyway. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm.py |5 + client/tests/kvm/kvm_utils.py |3 ++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/client/tests/kvm/kvm.py b/client/tests/kvm/kvm.py index 4930e80

[KVM-AUTOTEST PATCH v2 2/3] [RFC] KVM test: kvm_tests.cfg.sample: add some scheduler params

2009-09-11 Thread Michael Goldish
of CPUs required for a test. used_mem denotes the amount of RAM required for a test. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm

[KVM-AUTOTEST PATCH v2 3/3] [RFC] KVM test: client parallel test execution

2009-09-11 Thread Michael Goldish
the test results during and after execution. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/control.parallel | 330 + 1 files changed, 330 insertions(+), 0 deletions(-) create mode 100644 client/tests/kvm/control.parallel diff --git

[PATCH 1/3] KVM test: use a better source for random numbers

2009-09-10 Thread Michael Goldish
and is probably done by default anyway. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm.py |5 + client/tests/kvm/kvm_utils.py |3 ++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/client/tests/kvm/kvm.py b/client/tests/kvm/kvm.py index 4930e80

[PATCH 2/3] [RFC] KVM test: kvm_tests.cfg.sample: add some scheduler params

2009-09-10 Thread Michael Goldish
used_cpus denotes the number of CPUs required for a test. used_mem denotes the amount of RAM required for a test. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/client

[PATCH 3/3] [RFC] KVM test: client parallel test execution

2009-09-10 Thread Michael Goldish
between the queues (workers). This should be straightforward to do but I haven't had the time to do it yet. scan_results.py can be used to list the test results during and after execution. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/control.parallel | 320

[PATCH 02/19] KVM test: Migration test cleanup

2009-09-09 Thread Michael Goldish
This should hopefully make the test code a little more readable. The test is now also more similar to other tests in that it uses a single 'main_vm', which gets cloned, instead of a source and a destination VM. (This will allow to easily run multiple migration iterations.) Signed-off-by: Michael

[PATCH 03/19] KVM test: scan_results.py: allow parsing and printing of multiple result files

2009-09-09 Thread Michael Goldish
This is useful for printing results of several jobs executing in parallel (using job.parallel()). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/scan_results.py | 42 +++-- 1 files changed, 22 insertions(+), 20 deletions(-) diff --git

[PATCH 01/19] KVM test: kvm_utils.py: make verify_ip_address_ownership() more robust

2009-09-09 Thread Michael Goldish
Use arping in addition to querying the arp cache. Under certain circumstances a TCP connection may not trigger an ARP request so it must be triggered explicitly using arping. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py | 40

[PATCH 05/19] KVM test: kvm_subprocess: use kill_process_tree() to close child processes

2009-09-09 Thread Michael Goldish
This is safer than just killing the session leader because some processes seem to remain alive after their session leader has exited. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py |7 ++- client/tests/kvm/kvm_vm.py |2 +- 2 files

<    1   2   3   4   5   6   7   >