Re: [PATCH] Ignore DEBUGCTL MSRs

2008-07-22 Thread Alexander Graf
Avi Kivity wrote: Alexander Graf wrote: +pr_unimpl(vcpu, %s: MSR_IA32_DEBUGCTLMSR 0x%llx, nop\n, +__func__, data); We can avoid the printout if data == 0, since we support that case fully. I was thinking a lot about that. Even though we support data == 0, usually

Re: [PATCH] Ignore DEBUGCTL MSRs

2008-07-22 Thread Avi Kivity
Alexander Graf wrote: Corrected patch follows... --- Netware writes to DEBUGCTL and reads from the DEBUGCTL and LAST*IP MSRs without further checks and is really confused to receive a #GP during that. To make it happy we should just make them stubs, which is exactly what SVM already does.

Re: [PATCH] Ignore DEBUGCTL MSRs

2008-07-21 Thread Avi Kivity
Alexander Graf wrote: +pr_unimpl(vcpu, %s: MSR_IA32_DEBUGCTLMSR 0x%llx, nop\n, +__func__, data); We can avoid the printout if data == 0, since we support that case fully. I was thinking a lot about that. Even though we support data == 0, usually the kernel log

Re: [PATCH] Ignore DEBUGCTL MSRs

2008-07-16 Thread Alexander Graf
Avi Kivity wrote: Alexander Graf wrote: Avi Kivity wrote: Alexander Graf wrote: Netware writes and reads to the DEBUGCTL and LAST*IP MSRs without further checks and is really confused to receive a #GP during that. To make it happy we should just make them stubs, which is exactly what SVM

Re: [PATCH] Ignore DEBUGCTL MSRs

2008-07-10 Thread Avi Kivity
Alexander Graf wrote: Avi Kivity wrote: Alexander Graf wrote: Netware writes and reads to the DEBUGCTL and LAST*IP MSRs without further checks and is really confused to receive a #GP during that. To make it happy we should just make them stubs, which is exactly what SVM already does. To

Re: [PATCH] Ignore DEBUGCTL MSRs

2008-07-09 Thread Alexander Graf
Avi Kivity wrote: Alexander Graf wrote: Netware writes and reads to the DEBUGCTL and LAST*IP MSRs without further checks and is really confused to receive a #GP during that. To make it happy we should just make them stubs, which is exactly what SVM already does. To support VMX too, I put

Re: [PATCH] Ignore DEBUGCTL MSRs

2008-07-05 Thread Avi Kivity
Joerg Roedel wrote: Hi Alex, On Tue, Jun 24, 2008 at 07:04:45AM +0200, Alexander Graf wrote: Netware writes and reads to the DEBUGCTL and LAST*IP MSRs without further checks and is really confused to receive a #GP during that. To make it happy we should just make them stubs, which is

Re: [PATCH] Ignore DEBUGCTL MSRs

2008-07-05 Thread Avi Kivity
Alexander Graf wrote: Netware writes and reads to the DEBUGCTL and LAST*IP MSRs without further checks and is really confused to receive a #GP during that. To make it happy we should just make them stubs, which is exactly what SVM already does. To support VMX too, I put these in the generic

Re: [PATCH] Ignore DEBUGCTL MSRs

2008-06-25 Thread Alexander Graf
Hi Joerg, On Jun 24, 2008, at 3:40 PM, Joerg Roedel wrote: Hi Alex, On Tue, Jun 24, 2008 at 07:04:45AM +0200, Alexander Graf wrote: Netware writes and reads to the DEBUGCTL and LAST*IP MSRs without further checks and is really confused to receive a #GP during that. To make it happy we

Re: [PATCH] Ignore DEBUGCTL MSRs

2008-06-24 Thread Joerg Roedel
Hi Alex, On Tue, Jun 24, 2008 at 07:04:45AM +0200, Alexander Graf wrote: Netware writes and reads to the DEBUGCTL and LAST*IP MSRs without further checks and is really confused to receive a #GP during that. To make it happy we should just make them stubs, which is exactly what SVM already