Re: [PATCH 2/4] KVM: Add accessor for reading cr4 (or some bits of cr4)

2009-12-08 Thread Avi Kivity
On 12/08/2009 09:57 AM, Sheng Yang wrote: vcpu-arch.cr0 = cr0; - vmx_set_cr4(vcpu, vcpu-arch.cr4); + vmx_set_cr4(vcpu, kvm_read_cr4(vcpu)); } Another place accessed cr4 directly, in ept_update_paging_mode_cr4() That one is called from

Re: [PATCH 2/4] KVM: Add accessor for reading cr4 (or some bits of cr4)

2009-12-08 Thread Sheng Yang
On Tue, Dec 08, 2009 at 11:36:59AM +0200, Avi Kivity wrote: On 12/08/2009 09:57 AM, Sheng Yang wrote: vcpu-arch.cr0 = cr0; - vmx_set_cr4(vcpu, vcpu-arch.cr4); + vmx_set_cr4(vcpu, kvm_read_cr4(vcpu)); } Another place accessed cr4 directly, in

Re: [PATCH 2/4] KVM: Add accessor for reading cr4 (or some bits of cr4)

2009-12-08 Thread Avi Kivity
On 12/08/2009 04:40 PM, Sheng Yang wrote: But you are right, I should have placed a comment. I'll add a patch that inlines ept_update_paging_mode_cr4 into its caller so it can access the cr4 parameter directly instead of vcpu-arch.cr4. Just notice another thing, seems the

[PATCH 2/4] KVM: Add accessor for reading cr4 (or some bits of cr4)

2009-12-07 Thread Avi Kivity
Some bits of cr4 can be owned by the guest on vmx, so when we read them, we copy them to the vcpu structure. In preparation for making the set of guest-owned bits dynamic, use helpers to access these bits so we don't need to know where the bit resides. No changes to svm since all bits are

Re: [PATCH 2/4] KVM: Add accessor for reading cr4 (or some bits of cr4)

2009-12-07 Thread Sheng Yang
On Monday 07 December 2009 18:47:10 Avi Kivity wrote: Some bits of cr4 can be owned by the guest on vmx, so when we read them, we copy them to the vcpu structure. In preparation for making the set of guest-owned bits dynamic, use helpers to access these bits so we don't need to know where the