Re: [PATCH] kvm-unit-tests : The first version of VMX nested test case

2013-07-16 Thread Arthur Chunqi Li
Hi there, This is a version calling for comments. Some minor changes should be done before final commitment (TODOs in it), because these places are related to the bugs I have commited in the previous weeks and the relevant patches are not accpeted. But these bugs are all about some unexpected

Re: [PATCH] kvm-unit-tests : The first version of VMX nested test case

2013-07-16 Thread Gleb Natapov
On Tue, Jul 16, 2013 at 05:35:16PM +0800, Arthur Chunqi Li wrote: Hi there, This is a version calling for comments. Some minor changes should be Add RFC before PATCH for such submission please. done before final commitment (TODOs in it), because these places are related to the bugs I have

Re: [PATCH] kvm-unit-tests : The first version of VMX nested test case

2013-07-16 Thread Arthur Chunqi Li
On Tue, Jul 16, 2013 at 5:45 PM, Gleb Natapov g...@redhat.com wrote: On Tue, Jul 16, 2013 at 05:35:16PM +0800, Arthur Chunqi Li wrote: Hi there, This is a version calling for comments. Some minor changes should be Add RFC before PATCH for such submission please. done before final commitment

Re: [PATCH] kvm-unit-tests : The first version of VMX nested test case

2013-07-16 Thread Gleb Natapov
On Tue, Jul 16, 2013 at 05:53:56PM +0800, Arthur Chunqi Li wrote: On Tue, Jul 16, 2013 at 5:45 PM, Gleb Natapov g...@redhat.com wrote: On Tue, Jul 16, 2013 at 05:35:16PM +0800, Arthur Chunqi Li wrote: Hi there, This is a version calling for comments. Some minor changes should be Add RFC

Re: [PATCH] kvm-unit-tests : The first version of VMX nested test case

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 11:27, Arthur Chunqi Li ha scritto: This is the first version for VMX nested environment test case. It contains the basic VMX instructions test cases, including VMXON/ VMXOFF/VMXPTRLD/VMXPTRST/VMCLEAR/VMLAUNCH/VMRESUME/VMCALL. This patch also tests the basic execution routine in

Re: [PATCH] kvm-unit-tests : The first version of VMX nested test case

2013-07-16 Thread Arthur Chunqi Li
Hi Paolo, On Tue, Jul 16, 2013 at 6:28 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 16/07/2013 11:27, Arthur Chunqi Li ha scritto: This is the first version for VMX nested environment test case. It contains the basic VMX instructions test cases, including VMXON/

Re: [PATCH] kvm-unit-tests : The first version of VMX nested test case

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 13:47, Arthur Chunqi Li ha scritto: setjmp and longjmp is not implemented in our test environment, and these two functions are highly depend on architecture. Do you think we need to write a general code for both 32bit and 64bit, or just write specific one just for this test case?

Re: [PATCH] kvm-unit-tests : The first version of VMX nested test case

2013-07-16 Thread Arthur Chunqi Li
On Tue, Jul 16, 2013 at 11:20 PM, Gleb Natapov g...@redhat.com wrote: On Tue, Jul 16, 2013 at 12:28:05PM +0200, Paolo Bonzini wrote: +void vmx_exit(void) +{ + test_vmxoff(); + printf(\nSUMMARY: %d tests, %d failures\n, tests, fails); + exit(fails ? -1 : 0); +} Can you try to

Re: [PATCH] kvm-unit-tests : The first version of VMX nested test case

2013-07-16 Thread Gleb Natapov
On Tue, Jul 16, 2013 at 12:28:05PM +0200, Paolo Bonzini wrote: +void vmx_exit(void) +{ + test_vmxoff(); + printf(\nSUMMARY: %d tests, %d failures\n, tests, fails); + exit(fails ? -1 : 0); +} Can you try to jump back to main, and do test_vmxoff there? This will avoid having

Re: [PATCH] kvm-unit-tests : The first version of VMX nested test case

2013-07-16 Thread Gleb Natapov
On Tue, Jul 16, 2013 at 11:29:20PM +0800, Arthur Chunqi Li wrote: On Tue, Jul 16, 2013 at 11:20 PM, Gleb Natapov g...@redhat.com wrote: On Tue, Jul 16, 2013 at 12:28:05PM +0200, Paolo Bonzini wrote: +void vmx_exit(void) +{ + test_vmxoff(); + printf(\nSUMMARY: %d tests, %d

Re: [PATCH] kvm-unit-tests : The first version of VMX nested test case

2013-07-16 Thread Arthur Chunqi Li
On Wed, Jul 17, 2013 at 12:45 AM, Gleb Natapov g...@redhat.com wrote: On Tue, Jul 16, 2013 at 11:29:20PM +0800, Arthur Chunqi Li wrote: On Tue, Jul 16, 2013 at 11:20 PM, Gleb Natapov g...@redhat.com wrote: On Tue, Jul 16, 2013 at 12:28:05PM +0200, Paolo Bonzini wrote: +void vmx_exit(void)

Re: [PATCH] kvm-unit-tests : The first version of VMX nested test case

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 19:13, Arthur Chunqi Li ha scritto: On Wed, Jul 17, 2013 at 12:45 AM, Gleb Natapov g...@redhat.com wrote: On Tue, Jul 16, 2013 at 11:29:20PM +0800, Arthur Chunqi Li wrote: On Tue, Jul 16, 2013 at 11:20 PM, Gleb Natapov g...@redhat.com wrote: On Tue, Jul 16, 2013 at 12:28:05PM

Re: [PATCH] kvm-unit-tests : The first version of VMX nested test case

2013-07-16 Thread Gleb Natapov
On Wed, Jul 17, 2013 at 01:13:56AM +0800, Arthur Chunqi Li wrote: On Wed, Jul 17, 2013 at 12:45 AM, Gleb Natapov g...@redhat.com wrote: On Tue, Jul 16, 2013 at 11:29:20PM +0800, Arthur Chunqi Li wrote: On Tue, Jul 16, 2013 at 11:20 PM, Gleb Natapov g...@redhat.com wrote: On Tue, Jul 16,