Re: [PATCH] use upstream cpuid code

2009-08-03 Thread Avi Kivity
On 07/28/2009 11:05 PM, Glauber Costa wrote: use cpuid code from upstream. By doing that, we lose the following snippet in kvm_get_supported_cpuid(): ret |= 1 12; /* MTRR */ ret |= 1 16; /* PAT */ ret |= 1 7; /* MCE */ ret |= 1 14; /* MCA */ A quick search in mailing

Re: [PATCH] use upstream cpuid code

2009-08-03 Thread Glauber Costa
On Mon, Aug 03, 2009 at 02:57:47PM +0300, Avi Kivity wrote: On 07/28/2009 11:05 PM, Glauber Costa wrote: use cpuid code from upstream. By doing that, we lose the following snippet in kvm_get_supported_cpuid(): ret |= 1 12; /* MTRR */ ret |= 1 16; /* PAT */ ret |= 1 7; /*

Re: [PATCH] use upstream cpuid code

2009-08-03 Thread Avi Kivity
On 08/03/2009 04:22 PM, Glauber Costa wrote: On Mon, Aug 03, 2009 at 02:57:47PM +0300, Avi Kivity wrote: On 07/28/2009 11:05 PM, Glauber Costa wrote: use cpuid code from upstream. By doing that, we lose the following snippet in kvm_get_supported_cpuid(): ret |= 1 12; /* MTRR

Re: [PATCH] use upstream cpuid code

2009-08-03 Thread Glauber Costa
On Mon, Aug 03, 2009 at 05:06:28PM +0300, Avi Kivity wrote: On 08/03/2009 04:22 PM, Glauber Costa wrote: On Mon, Aug 03, 2009 at 02:57:47PM +0300, Avi Kivity wrote: On 07/28/2009 11:05 PM, Glauber Costa wrote: use cpuid code from upstream. By doing that, we lose the following

Re: [PATCH] use upstream cpuid code

2009-08-03 Thread Avi Kivity
On 08/03/2009 05:12 PM, Glauber Costa wrote: If qemu-kvm with this patch works on Fedora 10 (latest kernel) and the equivalent opensuse and Ubuntu kernels, then we can safely remove the bug workaround. If not, if we apply the patch we just cause users needless pain. Again, since it was