Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Kevin Wolf
Am 13.04.2011 21:26, schrieb Prasad Joshi: The patch only implements the basic read write support for QCOW version 1 images. Many of the QCOW features are not implmented, for example - image creation - snapshot - copy-on-write - encryption Yay, more forks, more code duplication! Have

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Ingo Molnar
* Kevin Wolf kw...@redhat.com wrote: Also at least your qcow1.c is lacking the copyright header. Please add this, otherwise you're violating the license. AFAICT it's not a copy, it's a reimplementation - and he credited you in the CREDITS file, for providing a reference implementation. But

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Kevin Wolf
Am 14.04.2011 10:07, schrieb Ingo Molnar: * Kevin Wolf kw...@redhat.com wrote: Also at least your qcow1.c is lacking the copyright header. Please add this, otherwise you're violating the license. AFAICT it's not a copy, it's a reimplementation - and he credited you in the CREDITS

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Pekka Enberg
* Kevin Wolf kw...@redhat.com wrote: Also at least your qcow1.c is lacking the copyright header. Please add this, otherwise you're violating the license. Am 14.04.2011 10:07, schrieb Ingo Molnar: AFAICT it's not a copy, it's a reimplementation - and he credited you in the CREDITS file, for

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Pekka Enberg
On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote: Have you thought about a way to actually share code with qemu instead of repeating Xen's mistake of copying code, modifying it until merges are no longer possible and then let it bitrot? No we haven't and we're not planning

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Kevin Wolf
Am 14.04.2011 10:15, schrieb Pekka Enberg: * Kevin Wolf kw...@redhat.com wrote: Also at least your qcow1.c is lacking the copyright header. Please add this, otherwise you're violating the license. Am 14.04.2011 10:07, schrieb Ingo Molnar: AFAICT it's not a copy, it's a reimplementation -

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Ingo Molnar
* Kevin Wolf kw...@redhat.com wrote: Am 14.04.2011 10:07, schrieb Ingo Molnar: * Kevin Wolf kw...@redhat.com wrote: Also at least your qcow1.c is lacking the copyright header. Please add this, otherwise you're violating the license. AFAICT it's not a copy, it's a

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Ingo Molnar
* Kevin Wolf kw...@redhat.com wrote: Am 14.04.2011 10:15, schrieb Pekka Enberg: * Kevin Wolf kw...@redhat.com wrote: Also at least your qcow1.c is lacking the copyright header. Please add this, otherwise you're violating the license. Am 14.04.2011 10:07, schrieb Ingo Molnar:

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Kevin Wolf
Am 14.04.2011 10:21, schrieb Pekka Enberg: On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote: Have you thought about a way to actually share code with qemu instead of repeating Xen's mistake of copying code, modifying it until merges are no longer possible and then let it

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Pekka Enberg
Hi Kevin! Am 14.04.2011 10:21, schrieb Pekka Enberg: On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote: Have you thought about a way to actually share code with qemu instead of repeating Xen's mistake of copying code, modifying it until merges are no longer possible and then

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Alon Levy
On Thu, Apr 14, 2011 at 11:32:21AM +0300, Pekka Enberg wrote: Hi Kevin! Am 14.04.2011 10:21, schrieb Pekka Enberg: On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote: Have you thought about a way to actually share code with qemu instead of repeating Xen's mistake of

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Kevin Wolf
Am 14.04.2011 10:32, schrieb Pekka Enberg: Hi Kevin! Am 14.04.2011 10:21, schrieb Pekka Enberg: On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote: Have you thought about a way to actually share code with qemu instead of repeating Xen's mistake of copying code, modifying it

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Prasad Joshi
On Thu, Apr 14, 2011 at 9:27 AM, Ingo Molnar mi...@elte.hu wrote: * Kevin Wolf kw...@redhat.com wrote: Am 14.04.2011 10:15, schrieb Pekka Enberg: * Kevin Wolf kw...@redhat.com wrote: Also at least your qcow1.c is lacking the copyright header. Please add this, otherwise you're

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 14.04.2011 10:32, schrieb Pekka Enberg: Hi Kevin! Am 14.04.2011 10:21, schrieb Pekka Enberg: On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote: Have you thought about a way to actually share code with qemu instead of repeating Xen's

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Ingo Molnar
* Prasad Joshi prasadjoshi...@gmail.com wrote: Speaking about the code of finding the cluster offset is so basic, that I thought it should be implemented the way it is done in the QEMU. But none of the code is copied from the QEMU sources. The complete code is written from scratch with

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Kevin Wolf
Am 14.04.2011 11:26, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 14.04.2011 10:32, schrieb Pekka Enberg: Hi Kevin! Am 14.04.2011 10:21, schrieb Pekka Enberg: On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote: Have you thought about a way to actually

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Stefan Hajnoczi
On Thu, Apr 14, 2011 at 11:26:07AM +0200, Markus Armbruster wrote: Kevin Wolf kw...@redhat.com writes: Am 14.04.2011 10:32, schrieb Pekka Enberg: Hi Kevin! Am 14.04.2011 10:21, schrieb Pekka Enberg: On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote: Have you

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Pekka Enberg
On 4/14/11 12:23 PM, Prasad Joshi wrote: Oh God. I was walking to university on seventh cloud, hoping to work on caching the l2 table. Now I find myslef under the controversy. Again, it's my fault, not yours. I asked to remove the license banner on top of qcow1.c because it doesn't contain

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 14.04.2011 11:26, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 14.04.2011 10:32, schrieb Pekka Enberg: Hi Kevin! Am 14.04.2011 10:21, schrieb Pekka Enberg: On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote:

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Anthony Liguori
On 04/14/2011 03:52 AM, Kevin Wolf wrote: Well, copying in itself is not a big problem as long as the copies are kept in sync. It's a bit painful, but manageable. Implementing every image format twice (and implementing image formats in a reliable and performing way isn't trivial) is much more

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-13 Thread Pekka Enberg
On Wed, 13 Apr 2011, Prasad Joshi wrote: The patch only implements the basic read write support for QCOW version 1 images. Many of the QCOW features are not implmented, for example Applied, thanks! Pekka -- To unsubscribe from this list: send the line unsubscribe kvm