RE: [PATCH] [RESEND] VT-d: Support multiple device assignment to one guest

Avi Kivity wrote: Han, Weidong wrote: If we devolve this to the iommu API, the same io page table can be shared by all iommus, so long as they all use the same page table format. I don't understand how to handle this by iommu API. Let me explain my thoughts more clearly: VT-d spec

[ kvm-Bugs-2143498 ] FreeBSD fails to reboot

Bugs item #2143498, was opened at 2008-10-03 05:38 Message generated for change (Comment added) made by rtg20 You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2143498group_id=180599 Please note that this message will contain a full copy of the comment

[PATCH] x86 emulator: Add Src2 decode set

Instruction like shld has three operands, so we need to add a Src2 decode set. We start with Src2None, Src2CL, and Src2Imm8 to support shld and we will expand it later. Signed-off-by: Guillaume Thouvenin [EMAIL PROTECTED] --- arch/x86/kvm/x86_emulate.c| 47

[PATCH 2/6] x86: Export some definition of MTRR

For KVM can reuse the type define, and need them to support shadow MTRR. Signed-off-by: Sheng Yang [EMAIL PROTECTED] --- arch/x86/kernel/cpu/mtrr/generic.c | 12 +++- arch/x86/kernel/cpu/mtrr/mtrr.h| 17 - include/asm-x86/mtrr.h | 25

[PATCH 0/6] MTRR/PAT support for EPT (v3)

Hi, Avi Here is the latest update of MTRR/PAT support. Change from v2: Discard the using of MSR bitmap, add MSR_IA32_CR_PAT to save/restore, as well as rebase on latest upstream. Thanks! -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a

[PATCH 6/6] Enable MTRR for EPT

The effective memory type of EPT is the mixture of MSR_IA32_CR_PAT and memory type field of EPT entry. Signed-off-by: Sheng Yang [EMAIL PROTECTED] --- arch/x86/kvm/mmu.c | 11 ++- arch/x86/kvm/svm.c |6 ++ arch/x86/kvm/vmx.c | 12 +---

[PATCH 4/6] KVM: VMX: Add PAT support for EPT

GUEST_PAT support is a new feature introduced by Intel Core i7 architecture. With this, cpu would save/load guest and host PAT automatically, for EPT memory type in guest depends on MSR_IA32_CR_PAT. Also add save/restore for MSR_IA32_CR_PAT. Signed-off-by: Sheng Yang [EMAIL PROTECTED] ---

[PATCH 1/6] x86: Rename mtrr_state struct and macro names

Prepare for exporting them. Signed-off-by: Sheng Yang [EMAIL PROTECTED] --- arch/x86/kernel/cpu/mtrr/generic.c |8 arch/x86/kernel/cpu/mtrr/main.c|4 ++-- arch/x86/kernel/cpu/mtrr/mtrr.h|7 --- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git

[PATCH 3/6] KVM: Improve MTRR structure

As well as reset mmu context when set MTRR. Signed-off-by: Sheng Yang [EMAIL PROTECTED] --- arch/x86/kvm/x86.c | 61 ++- include/asm-x86/kvm_host.h |5 +++- 2 files changed, 63 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/x86.c

Re: [PATCH] x86 emulator: Add Src2 decode set

Guillaume Thouvenin wrote: Instruction like shld has three operands, so we need to add a Src2 decode set. We start with Src2None, Src2CL, and Src2Imm8 to support shld and we will expand it later. Please add Src2One (implied '1') as well, so we can switch the existing shift operators to

[PATCH 1/1] KVM: IRQ ACK notifier should be used with in-kernel irqchip

Also remove unnecessary parameter of unregister irq ack notifier. Signed-off-by: Sheng Yang [EMAIL PROTECTED] --- include/linux/kvm_host.h |3 +-- virt/kvm/irq_comm.c |8 ++-- virt/kvm/kvm_main.c |2 +- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] x86 emulator: Add Src2 decode set

Avi Kivity wrote: #define SrcMask (74) +/* Source 2 operand type */ +#define Src2None(07) +#define Src2CL (17) +#define Src2Imm8(27) Src2ImmByte like SrcImmByte. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To

Re: [PATCH] [RESEND] VT-d: Support multiple device assignment to one guest

Han, Weidong wrote: There is a missed optimization here. Suppose we have two devices each under a different iommu. With the patch, each will be in a different dmar_domain and so will have a different page table. The amount of memory used is doubled. You cannot let two devices each

Re: [PATCH 1/1] KVM: IRQ ACK notifier should be used with in-kernel irqchip

Sheng Yang wrote: Also remove unnecessary parameter of unregister irq ack notifier. diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c index d0169f5..54b251d 100644 --- a/virt/kvm/irq_comm.c +++ b/virt/kvm/irq_comm.c @@ -50,11 +50,15 @@ void kvm_notify_acked_irq(struct kvm *kvm,

Re: [PATCH 6/6] Enable MTRR for EPT

Sheng Yang wrote: The effective memory type of EPT is the mixture of MSR_IA32_CR_PAT and memory type field of EPT entry. @@ -168,6 +168,7 @@ static u64 __read_mostly shadow_x_mask; /* mutual exclusive with nx_mask */ static u64 __read_mostly shadow_user_mask; static u64

Re: [PATCH 1/1] KVM: IRQ ACK notifier should be used with in-kernel irqchip

On Thursday 09 October 2008 16:34:47 Avi Kivity wrote: Sheng Yang wrote: Also remove unnecessary parameter of unregister irq ack notifier. diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c index d0169f5..54b251d 100644 --- a/virt/kvm/irq_comm.c +++ b/virt/kvm/irq_comm.c @@

Re: [PATCH] x86 emulator: Add a Src2 decode set and SrcOne operand type

Instruction like shld has three operands, so we need to add a Src2 decode set. We start with Src2None, Src2CL, and Src2Imm8 to support shld and we will expand it later. Operand type of Src2 are placed at the end of the set to avoid renumbering. For Src2CL we mask to a single byte and set the

Re: [PATCH] [RESEND] VT-d: Support multiple device assignment to one guest

Han, Weidong wrote: I don't want then to share dmar_domains (these are implementation details anyway), just io page tables. kvm --- something (owns io page table) --- dmar_domain (uses shared io page table) --- device Let dmar_domains share io page table is not allowed. VT-d spec

Call for help: moving the kvm wiki

As you may have noticed, the kvm wiki is overrun by spammers. It the past I've regularly cleaned up the spam, but some time ago I've given up. So I'm looking for a volunteer to locate a spam-free public wiki host (candidates include wiki.kernel.org and fedorahosted.org) and transfer the contents

Broken userspace module Makefile

Hi, Avi After Xiantao's irq_common patches were checked in, we found that it's impossible to compile with VT-d userspace now. Essentially the problem is Makefile missed a $ since unifdef patch checked in half an years ago... But after I fix it, I found it's still impossible to get unifdef run

RE: [PATCH] [RESEND] VT-d: Support multiple device assignment to one guest

Avi Kivity wrote: Han, Weidong wrote: I don't want then to share dmar_domains (these are implementation details anyway), just io page tables. kvm --- something (owns io page table) --- dmar_domain (uses shared io page table) --- device Let dmar_domains share io page table is not

Re: [PATCH 6/6] Enable MTRR for EPT

On Thursday 09 October 2008 16:44:19 Avi Kivity wrote: Sheng Yang wrote: The effective memory type of EPT is the mixture of MSR_IA32_CR_PAT and memory type field of EPT entry. @@ -168,6 +168,7 @@ static u64 __read_mostly shadow_x_mask; /* mutual exclusive with nx_mask */ static u64

Re: [PATCH 0/6] MTRR/PAT support for EPT (v3)

Sheng Yang wrote: On Thursday 09 October 2008 17:03:24 Avi Kivity wrote: Sheng Yang wrote: Hi, Avi Here is the latest update of MTRR/PAT support. Change from v2: Discard the using of MSR bitmap, add MSR_IA32_CR_PAT to save/restore, as well as rebase on latest upstream.

Re: Compile faillure with 2.6.27-rc9-git1

On Wed, Oct 08, 2008 at 05:55:47PM +0200, Xavier Gnata wrote: Hi, I'm trying to compile kvm-76 on a box running 2.6.27-rc9-git1 (yeah ok...rc+git...). I get this error: In file included from /usr/local/src/kvm-76/kernel/x86/svm.c:16:

Re: [PATCH 0/6] MTRR/PAT support for EPT (v3)

On Thursday 09 October 2008 17:03:24 Avi Kivity wrote: Sheng Yang wrote: Hi, Avi Here is the latest update of MTRR/PAT support. Change from v2: Discard the using of MSR bitmap, add MSR_IA32_CR_PAT to save/restore, as well as rebase on latest upstream. Applied all; my comments

Re: [ Re: unhandled vm exit: 0x80000021 vcpu_id 0]

On Wed, Oct 8, 2008 at 7:16 AM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Hi Yang, I often hibernate my Linux, so may be that the loadmodule message is missing in the dmesg because it is too old. I have rebooted the system and I attach a clean dmesg. Yeah, now I can see the load info of

RE: [PATCH] [RESEND] VT-d: Support multiple device assignment to one guest

Avi Kivity wrote: Han, Weidong wrote: There is a missed optimization here. Suppose we have two devices each under a different iommu. With the patch, each will be in a different dmar_domain and so will have a different page table. The amount of memory used is doubled. You cannot let

Re: [PATCH] x86 emulator: Add Src2 decode set

On Thu, 09 Oct 2008 11:06:50 +0200 Avi Kivity [EMAIL PROTECTED] wrote: The regular shift instructions (shl, rcl, etc) come in three varieties: shift by 1, shift by imm8, and shift by CL. Right now they use SrcImmByte and decode the implied '1' and CL by hand. If we change them to use

Re: [PATCH] x86 emulator: Add Src2 decode set

Guillaume Thouvenin wrote: I will add Src2One but I don't understand exactly what you mean by switching shift operators to Src2 later. I also applied other remarks, thanks for your help. The patch follows. The regular shift instructions (shl, rcl, etc) come in three varieties: shift by 1,

Re: [PATCH 0/6] MTRR/PAT support for EPT (v3)

Sheng Yang wrote: Hi, Avi Here is the latest update of MTRR/PAT support. Change from v2: Discard the using of MSR bitmap, add MSR_IA32_CR_PAT to save/restore, as well as rebase on latest upstream. Applied all; my comments about shadow can be addressed later. There is also the danger

Re: [PATCH] x86 emulator: Add Src2 decode set

On Thu, 09 Oct 2008 10:11:57 +0200 Avi Kivity [EMAIL PROTECTED] wrote: Guillaume Thouvenin wrote: Instruction like shld has three operands, so we need to add a Src2 decode set. We start with Src2None, Src2CL, and Src2Imm8 to support shld and we will expand it later. Please add

Re: KVM rpm/deb packages for recent releases.

Daniel P. Berrange wrote: On Wed, Oct 08, 2008 at 12:06:43PM -0700, jd wrote: Hi - I am looking for installable packages (both rpms and deb) for recent versions of KVM (kvm-70 and above). For SUSE/SLES I found, which seems useful (looks official)

Re: KVM rpm/deb packages for recent releases.

On Wed, Oct 8, 2008 at 4:06 PM, jd [EMAIL PROTECTED] wrote: Hi - I am looking for installable packages (both rpms and deb) for recent versions of KVM (kvm-70 and above). kvm-72 is in debian testing/unstable. You say for etch and a half ? I didn't find it in backports.org, but you could

RE: Broken userspace module Makefile

CONFIG_X86 is defined to compile every qemu's objects, so even if unifdef doesn't work, we shouldn't meet the problems related to this header file. Maybe other pential issues casues the problem you met. Anyway we had better enable unifdef to work in its right way. :) BTW, seems unifdef can't

Re: Broken userspace module Makefile

On Friday 10 October 2008 09:47:15 Zhang, Xiantao wrote: CONFIG_X86 is defined to compile every qemu's objects, so even if unifdef doesn't work, we shouldn't meet the problems related to this header file. Maybe other pential issues casues the problem you met. Anyway we had better enable

RE: Broken userspace module Makefile

The following patch should solve the issue you met before unifdef gets work again. diff --git a/libkvm/config-i386.mak b/libkvm/config-i386.mak index 2706b70..3579985 100644 --- a/libkvm/config-i386.mak +++ b/libkvm/config-i386.mak @@ -1,6 +1,6 @@ LIBDIR := /lib CFLAGS += -m32 -CFLAGS +=

RE: [PATCH] [RESEND] VT-d: Support multiple device assignment to one guest

Han, Weidong wrote: Avi Kivity wrote: Han, Weidong wrote: I don't want then to share dmar_domains (these are implementation details anyway), just io page tables. kvm --- something (owns io page table) --- dmar_domain (uses shared io page table) --- device Let dmar_domains share

[PATCH] x86: Rename mtrr_state struct and macro names

From: Sheng Yang [EMAIL PROTECTED] Prepare for exporting them. Signed-off-by: Sheng Yang [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c index cb7d3b6..b9574a6 100644 ---

Re: exit timing analysis v1 - commentsdiscussions welcome

I modified the code according to your comments and my ideas, the new values are shown in column impISF (irq delivery, Stat, FindFirstBit) I changed some code of the statistic updating and the interrupt delivery and got this: base - impirq (d3) - impstat (d5) - impboth - impISF a) 12.57%