Re: [PATCH 08/16] x86: Emergency virtualization disable function

2008-11-06 Thread Avi Kivity
Eduardo Habkost wrote: We could move the set_virt_disable_func() calls to vmx.c and svm.c (on hardware_setup/hardware_unsetup). One could argue that it is sort of a coincidence that we need the code for both vmx and svm. I don't share this fear of function calls, but perhaps that's due to

Re: [PATCH 00/14] x86: disable virt on kdump and emergency_restart

2008-11-06 Thread Avi Kivity
Vivek Goyal wrote: Is there a way we can prevent any other module from using virt disable callback incase kvm is not loaded? We can inline the kvm specific code (which will make it useful for other hypervisors, and remove the hook). -- error compiling committee.c: too many arguments to

Re: [PATCH] virtio: Define and use per-architecture pfn shift constants

2008-11-06 Thread Mark McLoughlin
On Wed, 2008-11-05 at 22:49 -0600, Hollis Blanchard wrote: - info-queue = kzalloc(PAGE_ALIGN(vring_size(num,PAGE_SIZE)), GFP_KERNEL); + vring_bytes = PAGE_ALIGN(vring_size(num, VRING_PAGE_SIZE)); + info-queue = kzalloc(vring_bytes, GFP_KERNEL); You're still aligning the

Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT

2008-11-06 Thread Mark McLoughlin
On Wed, 2008-11-05 at 22:49 -0600, Hollis Blanchard wrote: diff --git a/qemu/hw/virtio.c b/qemu/hw/virtio.c --- a/qemu/hw/virtio.c +++ b/qemu/hw/virtio.c @@ -56,6 +56,10 @@ */ #define wmb() do { } while (0) +#define VRING_PAGE_SIZE (112) + +#define ALIGN(x, a) (((x)+(a)-1)

Re: [PATCH 00/14] x86: disable virt on kdump and emergency_restart

2008-11-06 Thread Eduardo Habkost
On Thu, Nov 06, 2008 at 11:49:57AM +0200, Avi Kivity wrote: Ingo Molnar wrote: general ack for the x86 bits, but i'm not sure whether we should be pushing this upstream so late in the cycle. If we do it in the next cycle then it's best we do it in the x86 tree, the KVM impact seems much

Re: [PATCH] KVM: VMX: Set IGMT bit in EPT entry

2008-11-06 Thread Avi Kivity
Sheng Yang wrote: (Patch for 2.6.27, based on kvm-updates/2.6.27) There is a potential issue that, when guest using pagetable without vmexit when EPT enabled, guest would use PAT/PCD/PWT bits to index PAT msr for it's memory, which would be inconsistent with host side and would cause host MCE

Re: [Patch 1] thread/core siblings info for guests

2008-11-06 Thread Avi Kivity
Nitin A Kamble wrote: Hi Avi, Attached is the patch for the bugfix1, as we discussed in the earlier email. For cpuid leaf 0xb the bits 8-15 in ECX register define the end of counting leaf. The previous code was using bits 0-7 for this purpose, which is a bug. Applied, thanks. --

Re: [patch 2] thread/core siblings info for guests

2008-11-06 Thread Avi Kivity
Nitin A Kamble wrote: Hi Avi, This patches the 2nd bug in the kernel code. The code to traverse the cpuid data array list for counting type of leaves is currently broken. This patches fixes the 2 things in it. 1. Set the 1st counting entry's flag KVM_CPUID_FLAG_STATE_READ_NEXT. Without it

[PATCH] x86 CPUID extended family/model

2008-11-06 Thread Andre Przywara
Hi, (at least) AMD CPUs feature extended family/model bits in CPUID leaf _0001|EAX. Refer to page 10 in: http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/25481.pdf Those bits are necessary to model newer AMD CPUs: -cpu qemu64,family=15,model=65,stepping=3 or -cpu

Re: [PATCH 08/16] x86: Emergency virtualization disable function

2008-11-06 Thread Eric W. Biederman
Avi Kivity [EMAIL PROTECTED] writes: Eduardo Habkost wrote: We could move the set_virt_disable_func() calls to vmx.c and svm.c (on hardware_setup/hardware_unsetup). One could argue that it is sort of a coincidence that we need the code for both vmx and svm. I don't share this fear of

Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT

2008-11-06 Thread Anthony Liguori
Hollis Blanchard wrote: # HG changeset patch # User Hollis Blanchard [EMAIL PROTECTED] # Date 1225946837 21600 # Node ID 43a111ea61b542d3823e2a11d017e7b06b7ec254 # Parent b63967268af119e0faa4adc3086cdef857815548 qemu: define and use VIRTIO_PFN_SHIFT The virtio front and back ends must agree

Re: [PATCH 15/16] kvm: x86: set kdump virt_disable function on initialization

2008-11-06 Thread Avi Kivity
Eric W. Biederman wrote: + r = set_virt_disable_func(crash_hardware_disable); Can we make this say: set_virt_disable_func(kvm_x86_ops-crash_hardware_disable); So we can avoid going through 2 levels of function pointers? I find that a little scary in code that might be running at the

Re: [PATCH 15/15] Revert x86: default to reboot via ACPI

2008-11-06 Thread Eduardo Habkost
On Thu, Nov 06, 2008 at 08:14:45AM +0100, Ingo Molnar wrote: * Eduardo Habkost [EMAIL PROTECTED] wrote: This reverts commit c7ffa6c26277b403920e2255d10df849bd613380. Now that we have the hooks to disable virtualization on emergency_restart(), we can get back to the BOOT_KBD

Re: [PATCH 00/14] x86: disable virt on kdump and emergency_restart

2008-11-06 Thread Avi Kivity
Ingo Molnar wrote: general ack for the x86 bits, but i'm not sure whether we should be pushing this upstream so late in the cycle. If we do it in the next cycle then it's best we do it in the x86 tree, the KVM impact seems much smaller than the general x86 impact. It certainly doesn't

Re: [PATCH] KVM: VMX: Set IGMT bit in EPT entry

2008-11-06 Thread Anthony Liguori
Sheng Yang wrote: (Patch for 2.6.27, based on kvm-updates/2.6.27) There is a potential issue that, when guest using pagetable without vmexit when EPT enabled, guest would use PAT/PCD/PWT bits to index PAT msr for it's memory, which would be inconsistent with host side and would cause host MCE

Re: [PATCH] Activate Virtualization On Demand v3

2008-11-06 Thread Alexander Graf
On 05.11.2008, at 21:58, Eduardo Habkost wrote: On Wed, Nov 05, 2008 at 11:41:04AM +0100, Alexander Graf wrote: X86 CPUs need to have some magic happening to enable the virtualization extensions on them. This magic can result in unpleasant results for users, like blocking other VMMs from

Re: [PATCH 15/15] Revert x86: default to reboot via ACPI

2008-11-06 Thread Ingo Molnar
* Eduardo Habkost [EMAIL PROTECTED] wrote: On Thu, Nov 06, 2008 at 08:14:45AM +0100, Ingo Molnar wrote: * Eduardo Habkost [EMAIL PROTECTED] wrote: This reverts commit c7ffa6c26277b403920e2255d10df849bd613380. Now that we have the hooks to disable virtualization on

[ kvm-Bugs-2229083 ] RHES4 32bit with kernel 2.6.9-78.0.1 doesn't boot up

2008-11-06 Thread SourceForge.net
Bugs item #2229083, was opened at 2008-11-06 10:41 Message generated for change (Comment added) made by glommer You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2229083group_id=180599 Please note that this message will contain a full copy of the comment

Re: [PATCH 08/16] x86: Emergency virtualization disable function

2008-11-06 Thread Avi Kivity
Eric W. Biederman wrote: If you want to be extra simple and safe, remove kvm from the equation. Make the disabling code part of kdump/emergency_restart and only rely on the convention that cr3.vmxe == vmxon. Convention? There is a de-facto convention supported by at least vmware

Re: [PATCH 15/15] Revert x86: default to reboot via ACPI

2008-11-06 Thread Ingo Molnar
* Ingo Molnar [EMAIL PROTECTED] wrote: Andrey Borzenkov's patch, for example, adds a new DMI entry because reboot=acpi breaks his keyboard (even without KVM, I guess). Andrey, was that the case? hm, IIRC the problem was KVM in his case too. actually, Andrey's problem seems to be

Re: [PATCH] x86 CPUID extended family/model

2008-11-06 Thread Avi Kivity
Andre Przywara wrote: P.S. I heard of a way to propagate the host CPUID bits to the guest, like -cpu=host, but couldn't find any code. Did I miss something? Only ideas exist, not code, at the moment. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this

Re: Boot Problem (and fix)

2008-11-06 Thread Avi Kivity
the uni wrote: Starting with version 77 (I believe) I can no longer boot any of my virtual machines. Just hangs at press f12 for boot menu. My specs: core2duo, gentoo 2008 stable/current,x86_64, 6gigs ram. I managed to solve the problem by replacing the bios.bin in /usr/share/kvm/ with an

Re: [PATCH 09/15] x86: Emergency virtualization disable function

2008-11-06 Thread Eduardo Habkost
On Wed, Nov 05, 2008 at 11:27:32PM +0100, Pavel Machek wrote: On Wed 2008-11-05 17:56:52, Eduardo Habkost wrote: This patch adds an interface to set a function that can be used to disable virtualization extensions on the CPU on emergency cases, such as on kdump or emergency reboot. The

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread H L
Greetings (from a new lurker to the list), To your question Greg, yes and sort of ;-). I have started taking a look at these patches with a strong interest in understanding how they work. I've built a kernel with them and tried out a few things with real SR-IOV hardware. -- Lance Hartmann

Re: [PATCH 15/15] Revert x86: default to reboot via ACPI

2008-11-06 Thread Eric W. Biederman
Ingo Molnar [EMAIL PROTECTED] writes: * Ingo Molnar [EMAIL PROTECTED] wrote: Andrey Borzenkov's patch, for example, adds a new DMI entry because reboot=acpi breaks his keyboard (even without KVM, I guess). Andrey, was that the case? hm, IIRC the problem was KVM in his case too.

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Greg KH
On Thu, Nov 06, 2008 at 07:40:12AM -0800, H L wrote: Greetings (from a new lurker to the list), Welcome! To your question Greg, yes and sort of ;-). I have started taking a look at these patches with a strong interest in understanding how they work. I've built a kernel with them and

Re: How to do an automated backup?

2008-11-06 Thread Avi Kivity
Steve Lorimer wrote: Ok, should be a simple question here: How to backup a KVM host image. My first plan - failure: 1) Suspend / hibernate (using virsh ... save) image to disk 2) Backup vm disk image suspend file 3) Backup .xml 4) Restore suspended image This would accomplish a backup that

Re: [PATCH] virtio: Define and use per-architecture pfn shift constants

2008-11-06 Thread Hollis Blanchard
On Thu, 2008-11-06 at 10:49 +, Mark McLoughlin wrote: On Wed, 2008-11-05 at 22:49 -0600, Hollis Blanchard wrote: - info-queue = kzalloc(PAGE_ALIGN(vring_size(num,PAGE_SIZE)), GFP_KERNEL); + vring_bytes = PAGE_ALIGN(vring_size(num, VRING_PAGE_SIZE)); + info-queue =

Re: [PATCH 15/15] Revert x86: default to reboot via ACPI

2008-11-06 Thread Avi Kivity
Eric W. Biederman wrote: If there are a number of problems with reboot and reset I'm wondering if we should investigate using an outb to port 0x92. With the right bit set you can trigger a toggle of the reset line on many motherboards. Most likely that's what the ACPI reset describes. --

Re: Monitoring access to a guest page?

2008-11-06 Thread Avi Kivity
Brendan Dolan-Gavitt wrote: Hi, I'm working on a patch to let me monitor reads and writes to a particular guest page. The overall strategy is: 1. Mark the guest page as non-present. 2. In the PF handler, if the access is to the monitored page, log, and emulate the instruction. When I asked

Re: Fix to issues with kvm.h and g++

2008-11-06 Thread Avi Kivity
Daniel Godás wrote: Hello, I am writing a kvm-based emulation framework in c++. When I included linux/kvm.h I got the following errors: /usr/include/linux/kvm.h:89: error: 'struct kvm_run::anonymous union::kvm_io' invalid; an anonymous union can only have non-static data members

Re: qemu bios does not bootup

2008-11-06 Thread Avi Kivity
Jan Zimmek wrote: hi kvm-list, i am testing kvm for some days now but i cannot get it really working. setup: - host running gentoo 2.6.25-gentoo-r8 - core2duo T5600 - kvm-77 - guest gentoo2008 minimal iso command: kvm -cdrom install-x86-minimal-2008.0.iso -hda gentoo-i686.img -m 512M -curses

Re: [ANNOUNCE] kvm-78 release

2008-11-06 Thread Avi Kivity
Alberto Treviño wrote: On Sunday 02 November 2008 01:39:41 am Avi Kivity wrote: Changes from kvm-77: - merge qemu-svn - new live migration implementation - migration fixes Can anyone tell me if these migration fixes now allow for live migration of VM's with more than 4 GB of

Re: KVM_CAP_DEVICE_ASSIGNMENT should depend on CONFIG_PCI

2008-11-06 Thread Avi Kivity
Daniel Godás wrote: Hello, if you compile the kernel with KVM activated and without PCI support you get the following crash: CC arch/x86/kvm/../../../virt/kvm/kvm_main.o arch/x86/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_free_assigned_device':

Re: [ANNOUNCE] kvm-78 release

2008-11-06 Thread Anthony Liguori
Avi Kivity wrote: Alberto Treviño wrote: On Sunday 02 November 2008 01:39:41 am Avi Kivity wrote: Changes from kvm-77: - merge qemu-svn - new live migration implementation - migration fixes Can anyone tell me if these migration fixes now allow for live migration of VM's with

Re: [PATCH] virtio: Define and use per-architecture pfn shift constants

2008-11-06 Thread Anthony Liguori
Hollis Blanchard wrote: On Thu, 2008-11-06 at 10:49 +, Mark McLoughlin wrote: But actually, why do we align the size anyway? I assume it's so that the last page in the ring (containing the used fields) could be safely mapped into another guest's address space, without fear of

preempt.c not in hack-files

2008-11-06 Thread Alexander Graf
Hi, is there any particular reason x86/preempt.c is not in the hack-files? When I accidently tried to compile KVM on a kernel that does not have PREEMPT_NOTIFIERS, I got an error claiming that on_each_cpu is wrong. So basically we should use kvm_on_each_cpu here, right? This transition

Re: preempt.c not in hack-files

2008-11-06 Thread Avi Kivity
Alexander Graf wrote: Hi, is there any particular reason x86/preempt.c is not in the hack-files? Mainly because it doesn't come from kvm.git. When I accidently tried to compile KVM on a kernel that does not have PREEMPT_NOTIFIERS, I got an error claiming that on_each_cpu is wrong. So

Re: [PATCH 0/6] Kill off the virtio_net tx mitigation timer

2008-11-06 Thread Mark McLoughlin
Hey, So, I went off and spent some time gathering more data on this stuff and putting it together in a more consumable fashion. Here are some graphs showing the effect some of these changes have on throughput, cpu utilization and vmexit rate:

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread H L
I have not modified any existing drivers, but instead I threw together a bare-bones module enabling me to make a call to pci_iov_register() and then poke at an SR-IOV adapter's /sys entries for which no driver was loaded. It appears from my perusal thus far that drivers using these new SR-IOV

git repository for SR-IOV development?

2008-11-06 Thread H L
Has anyone initiated or given consideration to the creation of a git repository (say, on kernel.org) for SR-IOV development? -- Lance Hartmann -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Greg KH
A: No. Q: Should I include quotations after my reply? On Thu, Nov 06, 2008 at 08:41:53AM -0800, H L wrote: I have not modified any existing drivers, but instead I threw together a bare-bones module enabling me to make a call to pci_iov_register() and then poke at an SR-IOV adapter's /sys

Re: git repository for SR-IOV development?

2008-11-06 Thread Greg KH
On Thu, Nov 06, 2008 at 08:51:09AM -0800, H L wrote: Has anyone initiated or given consideration to the creation of a git repository (say, on kernel.org) for SR-IOV development? Why? It's only a few patches, right? Why would it need a whole new git tree? thanks, greg k-h -- To unsubscribe

Re: [PATCH 5/6] kvm: qemu: virtio-net: handle all tx in I/O thread without timer

2008-11-06 Thread Mark McLoughlin
On Tue, 2008-11-04 at 08:23 -0700, David S. Ahern wrote: Mark McLoughlin wrote: Note also that when tuning for a specific workload, which CPU the I/O thread is pinned to is important. Hi Mark: Can you give an example of when that has a noticeable affect? For example, if the

Re: [PATCH 5/6] kvm: qemu: virtio-net: handle all tx in I/O thread without timer

2008-11-06 Thread David S. Ahern
Mark McLoughlin wrote: On Tue, 2008-11-04 at 08:23 -0700, David S. Ahern wrote: Mark McLoughlin wrote: Note also that when tuning for a specific workload, which CPU the I/O thread is pinned to is important. Hi Mark: Can you give an example of when that has a noticeable affect? For

Re: [PATCH 15/15] Revert x86: default to reboot via ACPI

2008-11-06 Thread Andrey Borzenkov
[I had to trim direct recipients as my provider would refuse deliver claiming it is spam] On Thursday 06 November 2008, Ingo Molnar wrote: * Ingo Molnar [EMAIL PROTECTED] wrote: Andrey Borzenkov's patch, for example, adds a new DMI entry because reboot=acpi breaks his keyboard (even

Re: Boot Problem (and fix)

2008-11-06 Thread the uni
What are the parameters you use to launch your guests (memory size, smp)? Nothing special. kvm disk.img is enough to freeze the VM. Memory, smp, etc can all be changed with no effect. The only parameter that allows me to boot is -no-kvm As I stated before, everything is normal with an older

Re: [PATCH 0/6] Kill off the virtio_net tx mitigation timer

2008-11-06 Thread Avi Kivity
Mark McLoughlin wrote: Hey, So, I went off and spent some time gathering more data on this stuff and putting it together in a more consumable fashion. Here are some graphs showing the effect some of these changes have on throughput, cpu utilization and vmexit rate:

RE: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Fischer, Anna
On Thu, Nov 06, 2008 at 08:41:53AM -0800, H L wrote: I have not modified any existing drivers, but instead I threw together a bare-bones module enabling me to make a call to pci_iov_register() and then poke at an SR-IOV adapter's /sys entries for which no driver was loaded. It

Re: [PATCH 5/6] kvm: qemu: virtio-net: handle all tx in I/O thread without timer

2008-11-06 Thread Avi Kivity
Mark McLoughlin wrote: My machine has four CPUs, with two 6Mb L2 caches - each cache is shared between two of the CPUs, so I set things up as follows: pcpu#3 - netserver, I/O thread, vcpu#0 pcup#4 - vcpu#1, virtio_net irq, netperf which (hopefully) ensures that we're only doing one copy

Re: Boot Problem (and fix)

2008-11-06 Thread Avi Kivity
the uni wrote: What are the parameters you use to launch your guests (memory size, smp)? Nothing special. kvm disk.img is enough to freeze the VM. Memory, smp, etc can all be changed with no effect. The only parameter that allows me to boot is -no-kvm As I stated before, everything is

Re: [PATCH 08/16] x86: Emergency virtualization disable function

2008-11-06 Thread Eduardo Habkost
On Thu, Nov 06, 2008 at 12:30:51PM +0200, Avi Kivity wrote: Eric W. Biederman wrote: If you want to be extra simple and safe, remove kvm from the equation. Make the disabling code part of kdump/emergency_restart and only rely on the convention that cr3.vmxe == vmxon. Convention?

Re: [PATCH 0/6] Kill off the virtio_net tx mitigation timer

2008-11-06 Thread Mark McLoughlin
Hi Avi, Just thinking about your variable window suggestion ... On Mon, 2008-11-03 at 14:40 +0200, Avi Kivity wrote: Mark McLoughlin wrote: On Sun, 2008-11-02 at 11:48 +0200, Avi Kivity wrote: Where does the benefit come from? There are two things going on here, I think.

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Matthew Wilcox
On Thu, Nov 06, 2008 at 08:49:19AM -0800, Greg KH wrote: On Thu, Nov 06, 2008 at 08:41:53AM -0800, H L wrote: I have not modified any existing drivers, but instead I threw together a bare-bones module enabling me to make a call to pci_iov_register() and then poke at an SR-IOV adapter's /sys

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Greg KH
On Thu, Nov 06, 2008 at 10:47:41AM -0700, Matthew Wilcox wrote: On Thu, Nov 06, 2008 at 08:49:19AM -0800, Greg KH wrote: On Thu, Nov 06, 2008 at 08:41:53AM -0800, H L wrote: I have not modified any existing drivers, but instead I threw together a bare-bones module enabling me to make a

RE: [Patch 3] thread/core siblings info for guests

2008-11-06 Thread Kamble, Nitin A
The capability itself can return the count; for example case KVM_CAP_NR_CPUID_LEAVES: return KVM_MAX_CPUID_ENTRIES; which is simpler to use and shorter. Avi, Yes, it is simpler and shorter, but is returning a constant. It will be wasting space for the unused entries. Also it put's a

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Greg KH
On Thu, Nov 06, 2008 at 05:38:16PM +, Fischer, Anna wrote: On Thu, Nov 06, 2008 at 08:41:53AM -0800, H L wrote: I have not modified any existing drivers, but instead I threw together a bare-bones module enabling me to make a call to pci_iov_register() and then poke at an SR-IOV

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread H L
--- On Thu, 11/6/08, Greg KH [EMAIL PROTECTED] wrote: On Thu, Nov 06, 2008 at 08:41:53AM -0800, H L wrote: I have not modified any existing drivers, but instead I threw together a bare-bones module enabling me to make a call to pci_iov_register() and then poke at an SR-IOV adapter's

Re: [PATCH 09/15] x86: Emergency virtualization disable function

2008-11-06 Thread Pavel Machek
Hi! --- /dev/null +++ b/arch/x86/kernel/virtext.c @@ -0,0 +1,89 @@ +/* Core CPU virtualization extensions handling + * + * This should carry the code for handling CPU virtualization extensions + * that needs to live in the kernel core. + * + * Author: Eduardo Habkost

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Matthew Wilcox
[Anna, can you fix your word-wrapping please? Your lines appear to be infinitely long which is most unpleasant to reply to] On Thu, Nov 06, 2008 at 05:38:16PM +, Fischer, Anna wrote: Where would the VF drivers have to be associated? On the pci_dev level or on a higher one? A VF

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Greg KH
On Thu, Nov 06, 2008 at 10:05:39AM -0800, H L wrote: --- On Thu, 11/6/08, Greg KH [EMAIL PROTECTED] wrote: On Thu, Nov 06, 2008 at 08:41:53AM -0800, H L wrote: I have not modified any existing drivers, but instead I threw together a bare-bones module enabling me to make a call to

Re: Boot Problem (and fix)

2008-11-06 Thread the uni
Please post what 'info registers' and 'x/40b $eip' produce on the monitor ('-monitor stdio' helps). while hung on non-functioning bios: (gdb) info registers rax0xfdfe -514 rbx0xe 14 rcx0x -1 rdx

[PATCH] restart search at beggining of vmalloc address

2008-11-06 Thread Glauber Costa
Current vmalloc restart search for a free area in case we can't find one. The reason is there are areas which are lazily freed, and could be possibly freed now. However, current implementation start searching the tree from the last failing address, which is pretty much by definition at the end of

Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT

2008-11-06 Thread Hollis Blanchard
On Thu, 2008-11-06 at 08:01 -0600, Anthony Liguori wrote: Hollis Blanchard wrote: # HG changeset patch # User Hollis Blanchard [EMAIL PROTECTED] # Date 1225946837 21600 # Node ID 43a111ea61b542d3823e2a11d017e7b06b7ec254 # Parent b63967268af119e0faa4adc3086cdef857815548 qemu: define

Re: git repository for SR-IOV development?

2008-11-06 Thread H L
--- On Thu, 11/6/08, Greg KH [EMAIL PROTECTED] wrote: On Thu, Nov 06, 2008 at 08:51:09AM -0800, H L wrote: Has anyone initiated or given consideration to the creation of a git repository (say, on kernel.org) for SR-IOV development? Why? It's only a few patches, right? Why would it

Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT

2008-11-06 Thread Anthony Liguori
Hollis Blanchard wrote: I wanted to make sure people on non-x86 architectures couldn't run into vring-size related problems that didn't also appear on x86. Having a VRING_SHIFT and a VRING_PAGE_SIZE where VRING_PAGE_SIZE != (1 VRING_SHIFT) is almost certainly going to break things in

RE: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Fischer, Anna
Subject: Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support On Thu, Nov 06, 2008 at 05:38:16PM +, Fischer, Anna wrote: On Thu, Nov 06, 2008 at 08:41:53AM -0800, H L wrote: I have not modified any existing drivers, but instead I threw together a bare-bones module enabling me

Re: [PATCH] virtio: Define and use per-architecture pfn shift constants

2008-11-06 Thread Anthony Liguori
Hollis Blanchard wrote: # HG changeset patch # User Hollis Blanchard [EMAIL PROTECTED] # Date 1225946980 21600 # Node ID f58566dfe20e841604e1377ff41e9e0501c1cf18 # Parent f776b102380286dd173a3b89f7dc976140812517 virtio: Define and use per-architecture pfn shift constants Both sides of the

Re: [PATCH 15/15] Revert x86: default to reboot via ACPI

2008-11-06 Thread Matthew Garrett
On Thu, Nov 06, 2008 at 02:50:06PM -0500, Len Brown wrote: My expectation is that with the ACPI default, our problem is working around a finite list of old machines that don't work; while with the default KBD, our problem is working around a potentially unbounded list of yet to be shipped

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Simon Horman
On Thu, Nov 06, 2008 at 09:53:08AM -0800, Greg KH wrote: On Thu, Nov 06, 2008 at 10:47:41AM -0700, Matthew Wilcox wrote: On Thu, Nov 06, 2008 at 08:49:19AM -0800, Greg KH wrote: On Thu, Nov 06, 2008 at 08:41:53AM -0800, H L wrote: I have not modified any existing drivers, but instead I

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Anthony Liguori
Matthew Wilcox wrote: [Anna, can you fix your word-wrapping please? Your lines appear to be infinitely long which is most unpleasant to reply to] On Thu, Nov 06, 2008 at 05:38:16PM +, Fischer, Anna wrote: Where would the VF drivers have to be associated? On the pci_dev level or on a

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Anthony Liguori
Greg KH wrote: On Thu, Nov 06, 2008 at 10:47:41AM -0700, Matthew Wilcox wrote: I don't think we really know what the One True Usage model is for VF devices. Chris Wright has some ideas, I have some ideas and Yu Zhao has some ideas. I bet there's other people who have other ideas too.

Re: git repository for SR-IOV development?

2008-11-06 Thread Simon Horman
On Thu, Nov 06, 2008 at 11:58:25AM -0800, H L wrote: --- On Thu, 11/6/08, Greg KH [EMAIL PROTECTED] wrote: On Thu, Nov 06, 2008 at 08:51:09AM -0800, H L wrote: Has anyone initiated or given consideration to the creation of a git repository (say, on kernel.org) for SR-IOV

Re: [PATCH 15/15] Revert x86: default to reboot via ACPI

2008-11-06 Thread Len Brown
My expectation is that with the ACPI default, our problem is working around a finite list of old machines that don't work; while with the default KBD, our problem is working around a potentially unbounded list of yet to be shipped machines who may only be tested and work using the ACPI

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Matthew Wilcox
On Thu, Nov 06, 2008 at 04:38:40PM -0600, Anthony Liguori wrote: It's not clear thats the right solution. If the VF devices are _only_ going to be used by the guest, then arguably, we don't want to create pci_devs for them in the host. (I think it _is_ the right answer, but I want to make it

Re: [PATCH 15/15] Revert x86: default to reboot via ACPI

2008-11-06 Thread Matthew Garrett
On Thu, Nov 06, 2008 at 05:17:25PM -0500, Len Brown wrote: Does Windows default to using the ACPI method now? That is my guess, based on the fact that we've seen newer machines that don't reboot w/o using the ACPI reset reg. We've seen machines that won't reboot for a variety of reasons in

Re: dynamic virtio page size

2008-11-06 Thread Hollis Blanchard
On Thu, 2008-11-06 at 14:02 -0600, Anthony Liguori wrote: Hollis Blanchard wrote: I wanted to make sure people on non-x86 architectures couldn't run into vring-size related problems that didn't also appear on x86. Having a VRING_SHIFT and a VRING_PAGE_SIZE where VRING_PAGE_SIZE != (1

Re: dynamic virtio page size

2008-11-06 Thread Hollis Blanchard
On Thu, 2008-11-06 at 17:27 -0600, Hollis Blanchard wrote: In the patch I sent, they are named VIRTIO_PFN_SHIFT and VRING_PAGE_SIZE. In fact, the first could really be named VIRTIO_PCI_PFN_SHIFT or even more specific, which hopefully would alleviate the confusion. Anyways, I've been

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Chris Wright
* Greg KH ([EMAIL PROTECTED]) wrote: On Thu, Nov 06, 2008 at 10:47:41AM -0700, Matthew Wilcox wrote: On Thu, Nov 06, 2008 at 08:49:19AM -0800, Greg KH wrote: On Thu, Nov 06, 2008 at 08:41:53AM -0800, H L wrote: I have not modified any existing drivers, but instead I threw together a

Re: [PATCH] restart search at beggining of vmalloc address

2008-11-06 Thread Nick Piggin
Excellent, thank you! Good catch If you agree my previous patch was also good in combination with this one, then I'll send them all to be merged. Thanks, Nick On Thu, Nov 06, 2008 at 06:58:26PM -0200, Glauber Costa wrote: Current vmalloc restart search for a free area in case we can't find

Re: [PATCH 15/15] Revert x86: default to reboot via ACPI

2008-11-06 Thread Matthew Garrett
On Fri, Nov 07, 2008 at 09:01:19AM +0800, Zhao Yakui wrote: With the help of KVM I find that the windows will be rebooted by writing RESET_VALUE to RESET_REG I/O port if the RESET_REG_SUP bit is not zero(It indicates whether ACPI reboot is supported). IMO maybe the ACPI reboot is the first

Re: [PATCH] KVM: VMX: Set IGMT bit in EPT entry

2008-11-06 Thread Sheng Yang
On Thursday 06 November 2008 21:47:59 Anthony Liguori wrote: Sheng Yang wrote: (Patch for 2.6.27, based on kvm-updates/2.6.27) There is a potential issue that, when guest using pagetable without vmexit when EPT enabled, guest would use PAT/PCD/PWT bits to index PAT msr for it's memory,

Re: [PATCH 15/15] Revert x86: default to reboot via ACPI

2008-11-06 Thread Robert Hancock
Matthew Garrett wrote: On Fri, Nov 07, 2008 at 09:01:19AM +0800, Zhao Yakui wrote: With the help of KVM I find that the windows will be rebooted by writing RESET_VALUE to RESET_REG I/O port if the RESET_REG_SUP bit is not zero(It indicates whether ACPI reboot is supported). IMO maybe the ACPI

RE: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT

2008-11-06 Thread Zhang, Xiantao
Hollis Blanchard wrote: On Thu, 2008-11-06 at 08:01 -0600, Anthony Liguori wrote: Hollis Blanchard wrote: # HG changeset patch # User Hollis Blanchard [EMAIL PROTECTED] # Date 1225946837 21600 # Node ID 43a111ea61b542d3823e2a11d017e7b06b7ec254 # Parent

Re: [PATCH 15/15] Revert x86: default to reboot via ACPI

2008-11-06 Thread Matthew Garrett
On Thu, Nov 06, 2008 at 07:30:43PM -0600, Robert Hancock wrote: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8fd145917fb62368a9b80db59562c20576238f5a This patch ignores the RESET_REG_SUP flag and just tries using the reset register anyway if it thinks it's

RE: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Dong, Eddie
What we would rather do in KVM, is have the VFs appear in the host as standard network devices. We would then like to back our existing PV driver to this VF directly bypassing the host networking stack. A key feature here is being able to fill the VF's receive queue with guest memory

Re: [PATCH 15/15] Revert x86: default to reboot via ACPI

2008-11-06 Thread Len Brown
On Fri, 7 Nov 2008, Matthew Garrett wrote: On Thu, Nov 06, 2008 at 07:30:43PM -0600, Robert Hancock wrote: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8fd145917fb62368a9b80db59562c20576238f5a This patch ignores the RESET_REG_SUP flag and just tries

Re: git repository for SR-IOV development?

2008-11-06 Thread Greg KH
On Thu, Nov 06, 2008 at 11:58:25AM -0800, H L wrote: --- On Thu, 11/6/08, Greg KH [EMAIL PROTECTED] wrote: On Thu, Nov 06, 2008 at 08:51:09AM -0800, H L wrote: Has anyone initiated or given consideration to the creation of a git repository (say, on kernel.org) for SR-IOV

RE: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Nakajima, Jun
On 11/6/2008 2:38:40 PM, Anthony Liguori wrote: Matthew Wilcox wrote: [Anna, can you fix your word-wrapping please? Your lines appear to be infinitely long which is most unpleasant to reply to] On Thu, Nov 06, 2008 at 05:38:16PM +, Fischer, Anna wrote: Where would the VF

Re: [PATCH 16/16 v6] PCI: document the new PCI boot parameters

2008-11-06 Thread Greg KH
On Fri, Nov 07, 2008 at 10:37:55AM +0800, Zhao, Yu wrote: Greg KH wrote: On Wed, Oct 22, 2008 at 04:45:31PM +0800, Yu Zhao wrote: Documentation/kernel-parameters.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/Documentation/kernel-parameters.txt

Re: [PATCH 15/16 v6] PCI: document the SR-IOV sysfs entries

2008-11-06 Thread Zhao, Yu
Greg KH wrote: On Wed, Nov 05, 2008 at 08:33:18PM -0800, Greg KH wrote: On Wed, Oct 22, 2008 at 04:45:15PM +0800, Yu Zhao wrote: Documentation/ABI/testing/sysfs-bus-pci | 33 +++ 1 files changed, 33 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 15/16 v6] PCI: document the SR-IOV sysfs entries

2008-11-06 Thread Greg KH
On Fri, Nov 07, 2008 at 11:01:29AM +0800, Zhao, Yu wrote: Greg KH wrote: On Wed, Nov 05, 2008 at 08:33:18PM -0800, Greg KH wrote: On Wed, Oct 22, 2008 at 04:45:15PM +0800, Yu Zhao wrote: Documentation/ABI/testing/sysfs-bus-pci | 33 +++ 1 files changed, 33

Re: [PATCH 16/16 v6] PCI: document the new PCI boot parameters

2008-11-06 Thread Zhao, Yu
Greg KH wrote: On Fri, Nov 07, 2008 at 10:37:55AM +0800, Zhao, Yu wrote: Greg KH wrote: On Wed, Oct 22, 2008 at 04:45:31PM +0800, Yu Zhao wrote: Documentation/kernel-parameters.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 16/16 v6] PCI: document the new PCI boot parameters

2008-11-06 Thread Matthew Wilcox
On Fri, Nov 07, 2008 at 11:40:21AM +0800, Zhao, Yu wrote: Greg KH wrote: We've thought about this in the past, and even Microsoft said it was going to happen for Vista, but they realized in the end, like we did a few years previously, that it would require full support of all PCI drivers as

Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT

2008-11-06 Thread Hollis Blanchard
On Thursday 06 November 2008 19:38:40 Zhang, Xiantao wrote: Hi, Hollis Currenlty, kvm-qemu only supports the only case which is host page_size = qemu's target page size for ia64. Does your patch meets the requirement ? For ia64, current linux support 4K, 16K and 64k page size, and 1M

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Zhao, Yu
Greg KH wrote: On Wed, Oct 22, 2008 at 04:38:09PM +0800, Yu Zhao wrote: Greetings, Following patches are intended to support SR-IOV capability in the Linux kernel. With these patches, people can turn a PCI device with the capability into multiple ones from software perspective, which will

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Zhao, Yu
Greg KH wrote: On Thu, Nov 06, 2008 at 10:05:39AM -0800, H L wrote: --- On Thu, 11/6/08, Greg KH [EMAIL PROTECTED] wrote: On Thu, Nov 06, 2008 at 08:41:53AM -0800, H L wrote: I have not modified any existing drivers, but instead I threw together a bare-bones module enabling me to make a

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Greg KH
On Fri, Nov 07, 2008 at 01:18:52PM +0800, Zhao, Yu wrote: Greg KH wrote: On Wed, Oct 22, 2008 at 04:38:09PM +0800, Yu Zhao wrote: Greetings, Following patches are intended to support SR-IOV capability in the Linux kernel. With these patches, people can turn a PCI device with the capability

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Greg KH
On Thu, Nov 06, 2008 at 03:54:06PM -0800, Chris Wright wrote: * Greg KH ([EMAIL PROTECTED]) wrote: On Thu, Nov 06, 2008 at 10:47:41AM -0700, Matthew Wilcox wrote: On Thu, Nov 06, 2008 at 08:49:19AM -0800, Greg KH wrote: On Thu, Nov 06, 2008 at 08:41:53AM -0800, H L wrote: I have not

Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support

2008-11-06 Thread Greg KH
On Thu, Nov 06, 2008 at 04:40:21PM -0600, Anthony Liguori wrote: Greg KH wrote: On Thu, Nov 06, 2008 at 10:47:41AM -0700, Matthew Wilcox wrote: I don't think we really know what the One True Usage model is for VF devices. Chris Wright has some ideas, I have some ideas and Yu Zhao has

  1   2   >