Re: [PATCH 3/9] Remove irq_pending bitmap

On Wednesday 06 May 2009 13:55:44 Sheng Yang wrote: On Tuesday 05 May 2009 16:14:29 Gleb Natapov wrote: Only one interrupt vector can be injected from userspace irqchip at any given time so no need to store it in a bitmap. Put it into interrupt queue directly. Signed-off-by: Gleb

Re: [PATCH 5/9] [VMX] Do not re-execute INTn instruction.

On Tuesday 05 May 2009 16:14:31 Gleb Natapov wrote: Re-inject event instead. This is what Intel suggest. Also use correct instruction length when re-injecting soft fault/interrupt. Thanks for fixing this! Signed-off-by: Gleb Natapov g...@redhat.com --- arch/x86/include/asm/kvm_host.h |

Re: [PATCH] virtio-net: Fix save/load

Alex Williamson wrote: We can't rely on build switches to tell us if a save image includes a given field. We also need to save status since it's visible to the guest. Draw another line in the sand for broken save versions. The version number should always be updated when new values are saved

Re: [RFC PATCH 0/3] generic hypercall support

* Gregory Haskins (ghask...@novell.com) wrote: Chris Wright wrote: But a free-form hypercall(unsigned long nr, unsigned long *args, size_t count) means hypercall number and arg list must be the same in order for code to call hypercall() in a hypervisor agnostic way. Yes, and that is

Re: qemu/hw/device-assignment: questions about msix_table_page

On Wed, May 06, 2009 at 10:35:27AM +0800, Sheng Yang wrote: On Tuesday 05 May 2009 20:46:04 Michael S. Tsirkin wrote: On Tue, May 05, 2009 at 07:49:10AM -0300, Marcelo Tosatti wrote: On Tue, May 05, 2009 at 01:34:50PM +0300, Michael S. Tsirkin wrote: On Tue, May 05, 2009 at 07:19:45AM

Re: [PATCH] deal with interrupt shadow state for emulated instruction

On Tue, May 05, 2009 at 02:40:11PM -0400, Glauber Costa wrote: diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 8e680c3..a49d07b 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -510,6 +510,8 @@ struct kvm_x86_ops {

[ kvm-Bugs-2525768 ] kvm image corruption

Bugs item #2525768, was opened at 2009-01-21 16:03 Message generated for change (Comment added) made by danv You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2525768group_id=180599 Please note that this message will contain a full copy of the comment

Re: qemu/hw/device-assignment: questions about msix_table_page

On Wednesday 06 May 2009 15:31:18 Michael S. Tsirkin wrote: On Wed, May 06, 2009 at 10:35:27AM +0800, Sheng Yang wrote: On Tuesday 05 May 2009 20:46:04 Michael S. Tsirkin wrote: On Tue, May 05, 2009 at 07:49:10AM -0300, Marcelo Tosatti wrote: On Tue, May 05, 2009 at 01:34:50PM +0300,

[ kvm-Bugs-2525768 ] kvm image corruption

Bugs item #2525768, was opened at 2009-01-21 16:03 Message generated for change (Settings changed) made by danv You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2525768group_id=180599 Please note that this message will contain a full copy of the comment

Re: virtio-net not working with the latest qemu-kvm git

Sridhar Samudrala wrote: When i moved to the latest qemu-kvm git tree from kvm-85, i noticed that networking stopped working between the host and the guest. It started working when i put the device in promiscuos mode by running tcpdump in background on the guest. After browsing through the

Allocating Extra Memory To Guest

Hi, 1. How should we allocate extra memory to guest other than memory allocated through qemu_alloc_physram?? 2. How to register the extra allocated memory with KVM? I have tried to allocate an extra one page to Guest but couldn't succeed; probably somebody had already done this exercise. 1.

Re: [PATCH 5/9] [VMX] Do not re-execute INTn instruction.

On Wed, May 06, 2009 at 02:57:10PM +0800, Sheng Yang wrote: On Tuesday 05 May 2009 16:14:31 Gleb Natapov wrote: Re-inject event instead. This is what Intel suggest. Also use correct instruction length when re-injecting soft fault/interrupt. Thanks for fixing this! Signed-off-by: Gleb

Re: [Qemu-devel] Re: Question about KVM and PC speaker

Sebastian Herbszt wrote: Simon Bienlein wrote: Is a support for BIOS worked on right now? The vgabios (vgabios.c) has a FIXME should beep. Volker, do you plan to fix this? Which frequency should be used for the beep? Which delay? I would try 1 KHz and some hundred milliseconds. Getting

Re: [PATCH] deal with interrupt shadow state for emulated instruction

Gleb Natapov wrote: On Tue, May 05, 2009 at 02:40:11PM -0400, Glauber Costa wrote: diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 8e680c3..a49d07b 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -510,6 +510,8 @@

Re: [PATCH 5/9] [VMX] Do not re-execute INTn instruction.

Hi Gleb, Gleb Natapov wrote: Re-inject event instead. This is what Intel suggest. Also use correct instruction length when re-injecting soft fault/interrupt. Signed-off-by: Gleb Natapov g...@redhat.com --- arch/x86/include/asm/kvm_host.h |5 - arch/x86/kvm/svm.c |

Re: Allocating Extra Memory To Guest

Kumar, Venkat wrote: Hi, 1. How should we allocate extra memory to guest other than memory allocated through qemu_alloc_physram?? qemu_alloc_physram() is obsolete. I've just removed it to avoid confusion (and a warning). I presume you want to give kvm memory which is not real RAM -

Re: [KVM PATCH v4 2/2] kvm: add support for irqfd via eventfd-notification interface

Al, Davide, Gregory Haskins wrote: + +int +kvm_irqfd(struct kvm *kvm, int gsi, int flags) +{ + struct _irqfd *irqfd; + struct file *file = NULL; + int fd = -1; + int ret; + + irqfd = kzalloc(sizeof(*irqfd), GFP_KERNEL); + if (!irqfd) + return

Re: [PATCH 5/9] [VMX] Do not re-execute INTn instruction.

Here is updated patch with hopefully all comments addressed. Re-inject event instead. This is what Intel suggest. Also use correct instruction length when re-injecting soft fault/interrupt. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/arch/x86/include/asm/kvm_host.h

Re: [PATCH 1/6] kvm-s390: Fix memory slot versus run

ehrha...@linux.vnet.ibm.com wrote: From: Carsten Otte co...@de.ibm.com This patch fixes an incorrectness in the kvm backend for s390. In case virtual cpus are being created before the corresponding memory slot is being registered, we need to update the sie control blocks for the virtual cpus.

Re: [PATCH 2/6] kvm-s390: use hrtimer for clock wakeup from idle

ehrha...@linux.vnet.ibm.com wrote: From: Christian Borntraeger borntrae...@de.ibm.com This patch reworks the s390 clock comparator wakeup to hrtimer. The clock comparator is a per-cpu value that is compared against the TOD clock. If ckc = TOD an external interrupt 1004 is triggered. Since the

Re: [PATCH 4/6] kvm-s390: Unlink vcpu on destroy

ehrha...@linux.vnet.ibm.com wrote: From: Carsten Otte co...@de.ibm.com This patch makes sure we do unlink a vcpu's sie control block from the system control area in kvm_arch_vcpu_destroy. This prevents illegal accesses to the sie control block from other virtual cpus after free. Reported-by:

[KVM PATCH v5 0/2] irqfd

(Applies to kvm.git:66b0aed4, plus you will also need Davide Libenzi's eventfd_file_create() patch, which you can find here: http://www.mail-archive.com/kvm@vger.kernel.org/msg13923.html You can find my complete tree with kvm.git, Davide's patch, and this series here:

[KVM PATCH v5 1/2] eventfd: export eventfd interfaces for module use

We will re-use eventfd for implmenting irqfd later in the series, and the irqfd users will potentially live in modules. Signed-off-by: Gregory Haskins ghask...@novell.com --- fs/eventfd.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/fs/eventfd.c b/fs/eventfd.c

[KVM PATCH v5 2/2] kvm: add support for irqfd via eventfd-notification interface

KVM provides a complete virtual system environment for guests, including support for injecting interrupts modeled after the real exception/interrupt facilities present on the native platform (such as the IDT on x86). Virtual interrupts can come from a variety of sources (emulated devices,

Re: Allocating Extra Memory To Guest

Kumar, Venkat wrote: Kumar, Venkat wrote: Hi, 1. How should we allocate extra memory to guest other than memory allocated through qemu_alloc_physram?? qemu_alloc_physram() is obsolete. I've just removed it to avoid confusion (and a warning). == If kvm-85 is the latest

Re: [PATCH 2/6] kvm-s390: use hrtimer for clock wakeup from idle

Am Wednesday 06 May 2009 14:10:07 schrieb Avi Kivity: ehrha...@linux.vnet.ibm.com wrote: From: Christian Borntraeger borntrae...@de.ibm.com This patch reworks the s390 clock comparator wakeup to hrtimer. The clock comparator is a per-cpu value that is compared against the TOD clock. If

Re: [RFC PATCH 0/3] generic hypercall support

Chris Wright wrote: * Gregory Haskins (ghask...@novell.com) wrote: Chris Wright wrote: But a free-form hypercall(unsigned long nr, unsigned long *args, size_t count) means hypercall number and arg list must be the same in order for code to call hypercall() in a hypervisor agnostic

Re: [RFC PATCH 1/3] add generic hypercall support

Gregory Haskins wrote: We add a generic hypercall() mechanism for use by IO code which is compatible with a variety of hypervisors, but which prefers to use hypercalls over other types of hypervisor traps for performance and/or feature reasons. For instance, consider an emulated PCI device in

Re: [PATCH] execute kvm_init_vcpu in the end of pc_new_cpu

On Tue, May 05, 2009 at 11:16:19PM -0400, Glauber Costa wrote: When we create a new vcpu, we need to make sure that all of the state it is going to use (apic state, for example) already exists. We can do it nicely by making sure kvm_init_vcpu is executed after everything else in cpu creation.

Re: [RFC PATCH 0/3] generic hypercall support

Gregory Haskins wrote: Chris Wright wrote: * Gregory Haskins (gregory.hask...@gmail.com) wrote: So you would never have someone making a generic hypercall(KVM_HC_MMU_OP). I agree. Which is why I think the interface proposal you've made is wrong. I respectfully

Re: [PATCH] execute kvm_init_vcpu in the end of pc_new_cpu

On Wed, May 06, 2009 at 10:53:06AM -0300, Marcelo Tosatti wrote: On Tue, May 05, 2009 at 11:16:19PM -0400, Glauber Costa wrote: When we create a new vcpu, we need to make sure that all of the state it is going to use (apic state, for example) already exists. We can do it nicely by making

Re: [PATCH] virtio-net: Fix save/load

Anthony Liguori wrote: Avi Kivity wrote: Alex Williamson wrote: We can't rely on build switches to tell us if a save image includes a given field. We also need to save status since it's visible to the guest. Draw another line in the sand for broken save versions. The version number should

[PATCH] execute kvm_init_vcpu in the end of pc_new_cpu

When we create a new vcpu, we need to make sure that all of the state it is going to use (apic state, for example) already exists. We can do it nicely by making sure kvm_init_vcpu is executed after everything else in cpu creation. After that, the first call to KVM_SET_LAPIC ioctl will not find an

[patch] fix irq routing by moving it to the correct place

Hi, Some freak :-) put x86 specific irq routing into the generic code path, which obviously won't work on non-x86 systems. This patch creates kvm_arch_init_irq_routing() and moves the x86 gibberish to it's correct location :-) Now I have networking again! Cheers, Jes Platform specific IRQ

Re: [PATCH] execute kvm_init_vcpu in the end of pc_new_cpu

Glauber Costa wrote: When we create a new vcpu, we need to make sure that all of the state it is going to use (apic state, for example) already exists. We can do it nicely by making sure kvm_init_vcpu is executed after everything else in cpu creation. After that, the first call to

[ kvm-Bugs-2506814 ] TAP network lockup after some traffic

Bugs item #2506814, was opened at 2009-01-14 11:38 Message generated for change (Comment added) made by mellen You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2506814group_id=180599 Please note that this message will contain a full copy of the comment

Re: [PATCH] execute kvm_init_vcpu in the end of pc_new_cpu

diff --git a/qemu-kvm.c b/qemu-kvm.c index 8c0d463..8fd80c1 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -435,6 +435,9 @@ static void *ap_main_loop(void *_env) kvm_create_vcpu(kvm_context, env-cpu_index); kvm_qemu_init_env(env); +/* APIC state creation takes place

Re: [RFC PATCH 1/3] add generic hypercall support

Anthony Liguori wrote: Gregory Haskins wrote: We add a generic hypercall() mechanism for use by IO code which is compatible with a variety of hypervisors, but which prefers to use hypercalls over other types of hypervisor traps for performance and/or feature reasons. For instance, consider

Re: [KVM PATCH v4 2/2] kvm: add support for irqfd via eventfd-notification interface

On Wed, 6 May 2009, Gregory Haskins wrote: Al, Davide, Gregory Haskins wrote: + +int +kvm_irqfd(struct kvm *kvm, int gsi, int flags) +{ + struct _irqfd *irqfd; + struct file *file = NULL; + int fd = -1; + int ret; + + irqfd = kzalloc(sizeof(*irqfd), GFP_KERNEL);

Re: [KVM PATCH v4 2/2] kvm: add support for irqfd via eventfd-notification interface

Davide Libenzi wrote: On Wed, 6 May 2009, Gregory Haskins wrote: Al, Davide, Gregory Haskins wrote: + +int +kvm_irqfd(struct kvm *kvm, int gsi, int flags) +{ + struct _irqfd *irqfd; + struct file *file = NULL; + int fd = -1; + int ret; + + irqfd =

[patch] fix qemu-kvm to build when gdbstub is disabled

Hi, The latest changes to qemu-kvm breaks miserably if one tries to build without CONFIG_GDBSTUB. Jes Make qemu-kvm build again when CONFIG_GDBSTUB is not set. Signed-off-by: Jes Sorensen j...@sgi.com --- gdbstub.h |6 ++ vl.c |2 -- 2 files changed, 6 insertions(+), 2

Re: [PATCH] execute kvm_init_vcpu in the end of pc_new_cpu

Glauber Costa wrote: diff --git a/qemu-kvm.c b/qemu-kvm.c index 8c0d463..8fd80c1 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -435,6 +435,9 @@ static void *ap_main_loop(void *_env) kvm_create_vcpu(kvm_context, env-cpu_index); kvm_qemu_init_env(env); +/* APIC state creation

[patch] qemu-kvm define cpu_has_work() for ia64

Hi, This one is needed to build on ia64. Cheers, Jes Defined cpu_has_work() for ia64. Signed-off-by: Jes Sorensen j...@sgi.com --- target-ia64/exec.h |5 + 1 file changed, 5 insertions(+) Index: qemu-kvm/target-ia64/exec.h

[PATCH 0/2] device-assignment: option ROM support

This short series adds support for exposing PCI option ROMs on pass-through devices. I'm hoping that someone with more BIOS-foo can make use of this to dynamically load option ROMs from within the BIOS such that we might be able to boot from a pass-through device. I guess it's theoretically

[PATCH 2/2] kvm: device-assignment: Add PCI option ROM support

The PCI code already knows about option ROMs, so we just need to mmap some space for it, load it with a copy of the contents, and complete the plubming to the generic code. Signed-off-by: Alex Williamson alex.william...@hp.com --- hw/device-assignment.c | 59

[PATCH 1/2] kvm: bios: Use a different mask to size the option ROM BAR

Bit 0 is the enable bit, which we not only don't want to set, but it will stick and make us think it's an I/O port resource. Signed-off-by: Alex Williamson alex.william...@hp.com --- kvm/bios/rombios32.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] virtio-net: Fix save/load

On Wed, 2009-05-06 at 10:21 +0300, Avi Kivity wrote: Alex Williamson wrote: We can't rely on build switches to tell us if a save image includes a given field. We also need to save status since it's visible to the guest. Draw another line in the sand for broken save versions. The

Re: [RFC PATCH 0/3] generic hypercall support

Anthony Liguori wrote: Gregory Haskins wrote: Today, there is no equivelent of a platform agnostic iowrite32() for hypercalls so the driver would look like the pseudocode above except substitute with kvm_hypercall(), lguest_hypercall(), etc. The proposal is to allow the hypervisor to assign

Re: [RFC PATCH 0/3] generic hypercall support

* Gregory Haskins (ghask...@novell.com) wrote: Chris Wright wrote: VF drivers can also have this issue (and typically use mmio). I at least have a better idea what your proposal is, thanks for explanation. Are you able to demonstrate concrete benefit with it yet (improved latency numbers

Re: [RFC PATCH 1/3] add generic hypercall support

On Wednesday 06 May 2009, Gregory Haskins wrote: Ok, so we would need to come up with these pio_calls for x86, and no other arch can use the infrastructure (but wait, PPC can use PCI too, so how does that work? It must be either MMIO emulation or its not supported? That puts us back to

tg3 driver in guest fails for VT-d passthrough NIC

Hi, I am running the KVM kernel userspace downloaded on 4/24 with Fedora 10 host Linux on a Dell T7400 Xeon with VT-x and VT-d enabled. The T7400 has an onboard Broadcom NIC, but when I use VT-d to assign this NIC to a Fedora 10 guest, the NIC's tg3 driver in the guest aborts because it

Re: KVM x86_64 with SR-IOV..? (device passthrough with LIO-Target v3.0)

On Wed, 2009-05-06 at 11:51 +0800, Sheng Yang wrote: On Wednesday 06 May 2009 01:45:47 Nicholas A. Bellinger wrote: On Tue, 2009-05-05 at 04:28 -0700, Nicholas A. Bellinger wrote: On Tue, 2009-05-05 at 03:43 -0700, Nicholas A. Bellinger wrote: On Tue, 2009-05-05 at 09:42 +0800, Yu Zhao

Re: tg3 driver in guest fails for VT-d passthrough NIC

On Wed, May 6, 2009 at 11:31 AM, Nadolski, Ed ed.nadol...@lsi.com wrote: Hi, I am running the KVM kernel userspace downloaded on 4/24 with Fedora 10 host Linux on a Dell T7400 Xeon with VT-x and VT-d enabled. The T7400 has an onboard Broadcom NIC, but when I use VT-d to assign this NIC to

Re: [Qemu-devel] Re: Question about KVM and PC speaker

Jan Kiszka wrote: Sebastian Herbszt wrote: Simon Bienlein wrote: Is a support for BIOS worked on right now? The vgabios (vgabios.c) has a FIXME should beep. Volker, do you plan to fix this? Which frequency should be used for the beep? Which delay? I would try 1 KHz and some hundred

Re: [PATCH 1/4] BIOS changes for configuring irq0-inti2 override

Sebastian Herbszt wrote: Beth Kon wrote: @@ -477,6 +480,7 @@ void wrmsr_smp(uint32_t index, uint64_t val) #define QEMU_CFG_SIGNATURE 0x00 #define QEMU_CFG_ID 0x01 #define QEMU_CFG_UUID 0x02 +#define QEMU_CFG_IRQ0_OVERRIDE 0x0e Small thing to consider before you resubmit: In his

Re: Linux x86 guest panics in skb_copy_bits

On Tue, May 5, 2009 at 3:29 PM, Justin Dossey j...@justindossey.com wrote: On Mon, May 4, 2009 at 3:40 PM, Marcelo Tosatti mtosa...@redhat.com wrote: Justin, On Sun, May 03, 2009 at 11:40:47AM -0700, Justin Dossey wrote: [snip] Seems to be an issue with paravirt mmu. Do you happen to have

[ kvm-Bugs-2624842 ] kernel BUG at /kvm-84/kernel/x86/kvm_main.c:2148!

Bugs item #2624842, was opened at 2009-02-21 13:27 Message generated for change (Comment added) made by jb17bsome You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2624842group_id=180599 Please note that this message will contain a full copy of the comment

RE: [patch] fix irq routing by moving it to the correct place

Aha, good catch! I think it should fix irq routting for pci irq of ia64 ? Xiantao -Original Message- From: Jes Sorensen [mailto:j...@sgi.com] Sent: Wednesday, May 06, 2009 10:12 PM To: Avi Kivity Cc: Zhang, Xiantao; kvm-i...@vger.kernel.org; kvm@vger.kernel.org Subject: [patch] fix irq

RE: [patch] fix qemu-kvm to build when gdbstub is disabled

Jes Sorensen wrote: Hi, The latest changes to qemu-kvm breaks miserably if one tries to build without CONFIG_GDBSTUB. Jes --- qemu-kvm.orig/vl.c +++ qemu-kvm/vl.c @@ -4417,13 +4417,11 @@ } if (cpu_can_run(env)) ret = qemu_cpu_exec(env); -#ifndef

Re: [KVM PATCH v4 2/2] kvm: add support for irqfd via eventfd-notification interface

On Wed, 6 May 2009, Gregory Haskins wrote: I think we are ok in this regard (at least in v5) without the callback. kvm holds irqfd, which holds eventfd. In a normal situation, we will have eventfd with 2 references. If userspace closes the eventfd, it will drop 1 of the 2 eventfd file

Re: [KVM PATCH v4 2/2] kvm: add support for irqfd via eventfd-notification interface

Davide Libenzi wrote: On Wed, 6 May 2009, Gregory Haskins wrote: I think we are ok in this regard (at least in v5) without the callback. kvm holds irqfd, which holds eventfd. In a normal situation, we will have eventfd with 2 references. If userspace closes the eventfd, it will drop 1

Re: Linux x86 guest panics in skb_copy_bits

Justin, On Wed, May 06, 2009 at 04:35:24PM -0700, Justin Dossey wrote: On Tue, May 5, 2009 at 3:29 PM, Justin Dossey j...@justindossey.com wrote: On Mon, May 4, 2009 at 3:40 PM, Marcelo Tosatti mtosa...@redhat.com wrote: Justin, On Sun, May 03, 2009 at 11:40:47AM -0700, Justin Dossey

Re: [PATCH 1/4] BIOS changes for configuring irq0-inti2 override

On Wed, May 06, 2009 at 06:35:20PM -0400, Beth Kon wrote: Sebastian Herbszt wrote: Beth Kon wrote: @@ -477,6 +480,7 @@ void wrmsr_smp(uint32_t index, uint64_t val) #define QEMU_CFG_SIGNATURE 0x00 #define QEMU_CFG_ID 0x01 #define QEMU_CFG_UUID 0x02 +#define

[COMMIT stable-0.10] kvm: Build all files with kvm headers

From: Avi Kivity a...@redhat.com Too many to list independently. Signed-off-by: Avi Kivity a...@redhat.com diff --git a/Makefile.target b/Makefile.target index be97e6b..a8b198c 100644 --- a/Makefile.target +++ b/Makefile.target @@ -140,8 +140,7 @@ endif kvm.o: CFLAGS+=$(KVM_CFLAGS) kvm-all.o: