Re: [Qemu-commits] [COMMIT ddd9bbd] Support for multiple -monitor devices

2009-09-09 Thread Jan Kiszka
Avi Kivity wrote: On 09/04/2009 05:43 PM, Anthony Liguori wrote: From: Jan Kiszkajan.kis...@siemens.com Rebased version of Anthony's patch: Allow to specify more than one monitor terminal via the -monitor command line switch. This is particularly useful when libvirt or some other management

Re: [Qemu-commits] [COMMIT ddd9bbd] Support for multiple -monitor devices

2009-09-09 Thread Avi Kivity
On 09/09/2009 02:32 PM, Jan Kiszka wrote: This (as merged into kvm-next) breaks autotest. Autotest starts qemu-kvm with -monitor unix:/tmp/blah,server,nowait; with this patch it no longer opens the socket (as seen with lsof). I haven't yet found out why. Ok, will have a look. I

Re: [Qemu-commits] [COMMIT ddd9bbd] Support for multiple -monitor devices

2009-09-09 Thread Avi Kivity
On 09/09/2009 02:42 PM, Avi Kivity wrote: On 09/09/2009 02:32 PM, Jan Kiszka wrote: This (as merged into kvm-next) breaks autotest. Autotest starts qemu-kvm with -monitor unix:/tmp/blah,server,nowait; with this patch it no longer opens the socket (as seen with lsof). I haven't yet found

Re: [Qemu-commits] [COMMIT ddd9bbd] Support for multiple -monitor devices

2009-09-09 Thread Jan Kiszka
Avi Kivity wrote: On 09/09/2009 02:42 PM, Avi Kivity wrote: On 09/09/2009 02:32 PM, Jan Kiszka wrote: This (as merged into kvm-next) breaks autotest. Autotest starts qemu-kvm with -monitor unix:/tmp/blah,server,nowait; with this patch it no longer opens the socket (as seen with lsof). I

Re: qemu-kvm: kqemu - R.I.P.

2009-09-09 Thread Avi Kivity
On 09/09/2009 02:08 PM, Jan Kiszka wrote: Signed-off-by: Jan Kiszkajan.kis...@siemens.com Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org

Re: [PATCH] Use propeer way to compile with HELPER_CFLAGS

2009-09-09 Thread Avi Kivity
On 09/09/2009 02:04 PM, Juan Quintela wrote: This makes the build quiet. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo

Re: KVM: SVM: remove needless mmap_sem acquision from nested_svm_map

2009-09-09 Thread Avi Kivity
On 09/08/2009 08:47 PM, Marcelo Tosatti wrote: nested_svm_map unnecessarily takes mmap_sem around gfn_to_page, since gfn_to_page / get_user_pages are responsible for it. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list:

Re: [PATCH -v2] QEMU-KVM: MCE: Relay UCR MCE to guest

2009-09-09 Thread Avi Kivity
On 09/09/2009 05:28 AM, Huang Ying wrote: UCR (uncorrected recovery) MCE is supported in recent Intel CPUs, where some hardware error such as some memory error can be reported without PCC (processor context corrupted). To recover from such MCE, the corresponding memory will be unmapped, and all

Re: [PATCH] qemu-kvm: fix error handling in msix vector add

2009-09-09 Thread Avi Kivity
On 09/07/2009 10:05 AM, Mark McLoughlin wrote: On Sat, 2009-07-25 at 12:30 -0300, Marcelo Tosatti wrote: On Thu, Jul 23, 2009 at 04:34:13PM +0300, Michael S. Tsirkin wrote: When adding a vector fails, the used counter should not be incremented, otherwise on vector change we will try

Re: [PATCH] QEMU-KVM: MCE: Relay UCR MCE to guest

2009-09-09 Thread Avi Kivity
On 09/08/2009 11:11 AM, Andi Kleen wrote: Does this potentially open a security hole for us? Consider the following: 1) We happen to read guest memory and that causes an MCE. For instance, say we're in virtio.c and we read the virtio ring. 2) That should trigger the kernel to generate a

Re: [PATCH -v2] QEMU-KVM: MCE: Relay UCR MCE to guest

2009-09-09 Thread Avi Kivity
On 09/09/2009 03:06 PM, Avi Kivity wrote: On 09/09/2009 05:28 AM, Huang Ying wrote: UCR (uncorrected recovery) MCE is supported in recent Intel CPUs, where some hardware error such as some memory error can be reported without PCC (processor context corrupted). To recover from such MCE, the

Re: [PATCH -v2] QEMU-KVM: MCE: Relay UCR MCE to guest

2009-09-09 Thread Avi Kivity
On 09/09/2009 03:16 PM, Avi Kivity wrote: Oh and I forgot - please make MCE injection optional. Some installations may prefer to kill the guest and have the virtualization management system restart it rather than trust the guest to handle the MCE properly. Thinking a little more about it,

Re: R/W HG memory mappings with kvm?

2009-09-09 Thread Avi Kivity
On 09/01/2009 12:13 AM, Stephen Donnelly wrote: I'm totally confused now. Sorry about that. The issue is the BUG in gfn_to_pgn where the pfn is not calculated correctly after looking up the vma. I still don't see how to get the physical address from the vma, since vm_pgoff is zero, and

Re: Live migration between Intel Q6600 and AMD Phenom II

2009-09-09 Thread Andre Przywara
Sterling Windmill wrote: I've read that it's possible to live migrate KVM guests between Intel and AMD CPUs, is it also possible to migrate from a CPU without NPT/EPT to the Phenom II that supports NPT? Yes. Will I lose out on any of the benefits NPT allows without shutting down and

Upstream build problem

2009-09-09 Thread Lucas Meneghel Rodrigues
Hi folks, it seems that we are still hitting the problem of qemu-kvm being unable to find the option roms? -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

qemu-kvm still unable to load option rom extboot.bin

2009-09-09 Thread Lucas Meneghel Rodrigues
Hi folks, seems like we are still facing a build problem on qemu-kvm: The option rom is failing to boot: 09/04 11:12:08 DEBUG|kvm_vm:0384| Running qemu command: /usr/local/autotest/tests/kvm/qemu -name 'vm1' -monitor unix:/tmp/monitor-20090904-111208-9nyy,server,nowait -drive

Re: qemu-kvm still unable to load option rom extboot.bin

2009-09-09 Thread Dor Laor
On 09/09/2009 04:47 PM, Lucas Meneghel Rodrigues wrote: Hi folks, seems like we are still facing a build problem on qemu-kvm: The option rom is failing to boot: 09/04 11:12:08 DEBUG|kvm_vm:0384| Running qemu command: /usr/local/autotest/tests/kvm/qemu -name 'vm1' -monitor

[PATCH] Activate Virtualization On Demand

2009-09-09 Thread Alexander Graf
X86 CPUs need to have some magic happening to enable the virtualization extensions on them. This magic can result in unpleasant results for users, like blocking other VMMs from working (vmx) or using invalid TLB entries (svm). Currently KVM activates virtualization when the respective kernel

Re: [PATCH 3/9] virt/kvm: correct error-handling code

2009-09-09 Thread Avi Kivity
On 07/28/2009 06:53 PM, Julia Lawall wrote: From: Julia Lawallju...@diku.dk This code is not executed before file has been initialized to the result of calling eventfd_fget. This function returns an ERR_PTR value in an error case instead of NULL. Thus the test that file is not NULL is always

[PATCH] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Gleb Natapov
regs_modified logic doesn't work if io thread calls kvm_cpu_synchronize_state() since kvm_arch_get_registers() returns only after vcpu thread is back to kernel. Setting regs_modified to 1 at this stage causes loading of wrong vcpu state on the next vcpu_run(). Signed-off-by: Gleb Natapov

Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Avi Kivity
On 09/09/2009 06:33 PM, Gleb Natapov wrote: regs_modified logic doesn't work if io thread calls kvm_cpu_synchronize_state() since kvm_arch_get_registers() returns only after vcpu thread is back to kernel. Setting regs_modified to 1 at this stage causes loading of wrong vcpu state on the next

Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Jan Kiszka
Gleb Natapov wrote: regs_modified logic doesn't work if io thread calls kvm_cpu_synchronize_state() since kvm_arch_get_registers() returns only after vcpu thread is back to kernel. Setting regs_modified to 1 at this stage causes loading of wrong vcpu state on the next vcpu_run(). We need

Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Gleb Natapov
On Wed, Sep 09, 2009 at 05:47:13PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: regs_modified logic doesn't work if io thread calls kvm_cpu_synchronize_state() since kvm_arch_get_registers() returns only after vcpu thread is back to kernel. Setting regs_modified to 1 at this stage causes

Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Sep 09, 2009 at 05:47:13PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: regs_modified logic doesn't work if io thread calls kvm_cpu_synchronize_state() since kvm_arch_get_registers() returns only after vcpu thread is back to kernel. Setting regs_modified to 1 at

[PATCH v2] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Gleb Natapov
regs_modified logic doesn't work if io thread calls kvm_cpu_synchronize_state() since kvm_arch_get_registers() returns only after vcpu thread is back to kernel. Setting regs_modified to 1 at this stage causes loading of wrong vcpu state on the next vcpu_run(). -- v1-v2: do not remove

Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Gleb Natapov
On Wed, Sep 09, 2009 at 05:57:40PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Sep 09, 2009 at 05:47:13PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: regs_modified logic doesn't work if io thread calls kvm_cpu_synchronize_state() since kvm_arch_get_registers() returns only

Re: [PATCH v2] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Avi Kivity
On 09/09/2009 07:01 PM, Gleb Natapov wrote: regs_modified logic doesn't work if io thread calls kvm_cpu_synchronize_state() since kvm_arch_get_registers() returns only after vcpu thread is back to kernel. Setting regs_modified to 1 at this stage causes loading of wrong vcpu state on the next

Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Sep 09, 2009 at 05:57:40PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Sep 09, 2009 at 05:47:13PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: regs_modified logic doesn't work if io thread calls kvm_cpu_synchronize_state() since kvm_arch_get_registers()

Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Gleb Natapov
On Wed, Sep 09, 2009 at 06:21:48PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Sep 09, 2009 at 05:57:40PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Sep 09, 2009 at 05:47:13PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: regs_modified logic doesn't work if io thread

Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Sep 09, 2009 at 06:21:48PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Sep 09, 2009 at 05:57:40PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Sep 09, 2009 at 05:47:13PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: regs_modified logic doesn't

[PATCH] sync halt state into env

2009-09-09 Thread Gleb Natapov
Was dropped somewhere during merge. Without this info cpus doesn't show cpu halted state. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/qemu-kvm.h b/qemu-kvm.h index 1c42e82..4be6afd 100644 --- a/qemu-kvm.h +++ b/qemu-kvm.h @@ -1157,6 +1157,7 @@ static inline void

Re: [PATCH] sync halt state into env

2009-09-09 Thread Avi Kivity
On 09/09/2009 07:33 PM, Gleb Natapov wrote: Was dropped somewhere during merge. Without this info cpus doesn't show cpu halted state. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the

Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Gleb Natapov
On Wed, Sep 09, 2009 at 06:32:57PM +0200, Jan Kiszka wrote: The patch doesn't touch shared code. (it is almost impossible to tell what code is shared and what's not nowadays) cpu_dump_state() is definitely shared. Ah this one line. Yes it is. But I have not good commit message for this

buildbot failure in qemu-kvm on disable_kvm_x86_64_debian_5_0

2009-09-09 Thread qemu-kvm
The Buildbot has detected a new failure of disable_kvm_x86_64_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/disable_kvm_x86_64_debian_5_0/builds/42 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build:

buildbot failure in qemu-kvm on disable_kvm_i386_debian_5_0

2009-09-09 Thread qemu-kvm
The Buildbot has detected a new failure of disable_kvm_i386_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/disable_kvm_i386_debian_5_0/builds/44 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build:

New kvm.git branch for linux-next

2009-09-09 Thread Avi Kivity
Stephen, please pick up the 'linux-next' branch of kvm.git instead 'master' as you do now. This will better reflect what is actually going to -next, will cause fewer merge errors, and will improve -next bisectability. (this is actually a symbolic ref to kvm-updates/2.6.32 which will be

[ kvm-Bugs-2351676 ] Guests hang periodically on Ubuntu-8.10

2009-09-09 Thread SourceForge.net
Bugs item #2351676, was opened at 2008-11-26 17:59 Message generated for change (Comment added) made by jlokier You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2351676group_id=180599 Please note that this message will contain a full copy of the comment

[PATCH 02/19] KVM test: Migration test cleanup

2009-09-09 Thread Michael Goldish
This should hopefully make the test code a little more readable. The test is now also more similar to other tests in that it uses a single 'main_vm', which gets cloned, instead of a source and a destination VM. (This will allow to easily run multiple migration iterations.) Signed-off-by: Michael

[PATCH 03/19] KVM test: scan_results.py: allow parsing and printing of multiple result files

2009-09-09 Thread Michael Goldish
This is useful for printing results of several jobs executing in parallel (using job.parallel()). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/scan_results.py | 42 +++-- 1 files changed, 22 insertions(+), 20 deletions(-) diff --git

[PATCH 01/19] KVM test: kvm_utils.py: make verify_ip_address_ownership() more robust

2009-09-09 Thread Michael Goldish
Use arping in addition to querying the arp cache. Under certain circumstances a TCP connection may not trigger an ARP request so it must be triggered explicitly using arping. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py | 40

[PATCH 05/19] KVM test: kvm_subprocess: use kill_process_tree() to close child processes

2009-09-09 Thread Michael Goldish
This is safer than just killing the session leader because some processes seem to remain alive after their session leader has exited. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py |7 ++- client/tests/kvm/kvm_vm.py |2 +- 2 files

[PATCH 04/19] KVM test: kvm_utils.py: add kill_process_tree()

2009-09-09 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py index f046810..f686a53 100644 ---

[PATCH 07/19] KVM test: kvm_subprocess: get rid of get_pid() (replace it with get_shell_pid())

2009-09-09 Thread Michael Goldish
Don't differentiate between the PID of the subprocess and the PID of the shell running it. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py | 38 +-- client/tests/kvm/kvm_tests.py |2 +- 2 files changed, 7

[PATCH 09/19] KVM test: kvm_config.py: remove unused function get_match_block_indices()

2009-09-09 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_config.py | 27 --- 1 files changed, 0 insertions(+), 27 deletions(-) diff --git a/client/tests/kvm/kvm_config.py b/client/tests/kvm/kvm_config.py index da7988b..405de4b 100755 ---

[PATCH 08/19] KVM test: remove unused function is_sshd_running()

2009-09-09 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py | 46 - client/tests/kvm/kvm_vm.py| 15 - 2 files changed, 0 insertions(+), 61 deletions(-) diff --git a/client/tests/kvm/kvm_utils.py

[PATCH 06/19] KVM test: timedrift test: set CPU affinity recursively for all children

2009-09-09 Thread Michael Goldish
In addition to setting the CPU affinity of the given process, set it for all of its children too. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.py | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/client/tests/kvm/kvm_tests.py

[PATCH 10/19] KVM test: boot test: add option to reboot using system_reset

2009-09-09 Thread Michael Goldish
The boot test now behaves as follows: - Normally it just waits for the guest to go up and logs into it. - If reboot_method is specified and equals shell, the guest is sent a reboot shell command, and the test waits until the guest comes back up. - If reboot method is specified and equals

[PATCH 11/19] KVM test: shutdown test: allow shutting down using system_powerdown

2009-09-09 Thread Michael Goldish
In addition to using the shutdown command/program, allow using the system_powerdown monitor command. The behavior is controlled using the shutdown_method parameter, which may equal either shell or system_powerdown. If shutdown_method equals system_powerdown, the test sleeps a given amount of

[PATCH 12/19] KVM test: Add new module kvm_test_utils.py

2009-09-09 Thread Michael Goldish
This module is meant to reduce code size by performing common test procedures. Generally, code here should look like test code. More specifically: - Functions in this module should raise exceptions if things go wrong (unlike functions in kvm_utils.py and kvm_vm.py which report failure

[PATCH 13/19] KVM test: kvm_tests.py: save test code by using utilities in kvm_test_utils.py

2009-09-09 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.py | 148 - 1 files changed, 27 insertions(+), 121 deletions(-) diff --git a/client/tests/kvm/kvm_tests.py b/client/tests/kvm/kvm_tests.py index 863b863..35666cf 100644 ---

[PATCH 14/19] KVM test: kvm_preprocessing.py: don't explicitly print failure messages

2009-09-09 Thread Michael Goldish
This is taken care of elsewhere, so currently when something fails during pre/post-processing, messages get logged twice. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff

[PATCH 16/19] KVM test: kvm_subprocess: robustify the test for child process termination

2009-09-09 Thread Michael Goldish
Don't rely on os.read() raising an exception; use waitpid() to check for child termination: - every 0.5 seconds, or - when os.read() raises an exception, or - when os.read() returns a zero-length string. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py |

[PATCH 15/19] KVM test: Autotest test wrapper cleanup

2009-09-09 Thread Michael Goldish
Make the code shorter and simpler. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.py | 153 +++-- 1 files changed, 72 insertions(+), 81 deletions(-) diff --git a/client/tests/kvm/kvm_tests.py b/client/tests/kvm/kvm_tests.py

[PATCH 17/19] KVM test: kvm_vm.py: add macaddr= to command line only if a MAC address is given

2009-09-09 Thread Michael Goldish
(Avoid adding weird things like 'macaddr=None' to the command line.) Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index

[PATCH 18/19] KVM test: kvm_tests.cfg.sample: get all Windows test utilities from a single ISO

2009-09-09 Thread Michael Goldish
Instead of rss.iso, vlc.iso and autoit.iso -- look for everything in winutils.iso by default. This make maintenance a little easier, and eliminates the need to restart VMs between tests just in order to change the cdrom. Also, expect vlc.exe in D:\vlc\vlc.exe instead of D:\vlc.exe. 'install'

[PATCH 19/19] KVM test: kvm_preprocessing.py: verify PPM file validity before passing to PIL

2009-09-09 Thread Michael Goldish
Passing PIL an invalid PPM file makes it throw an IOError. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm/kvm_preprocessing.py

[PATCH] Fix --disable-kvm build regression of commit 8c7d4cb

2009-09-09 Thread Daniel Gollub
qemu-kvm --disable-kvm build regression of commit 8c7d4cb spotted by qemu-kvm buildbot: http://buildbot.b1-systems.de/qemu-kvm/builders/disable_kvm_i386_debian_5_0/builds/44 http://buildbot.b1-systems.de/qemu-kvm/builders/disable_kvm_x86_64_debian_5_0/builds/42 Signed-off-by: Daniel Gollub

Re: New kvm.git branch for linux-next

2009-09-09 Thread Stephen Rothwell
Hi Avi, On Wed, 09 Sep 2009 20:55:18 +0300 Avi Kivity a...@redhat.com wrote: Stephen, please pick up the 'linux-next' branch of kvm.git instead 'master' as you do now. This will better reflect what is actually going to -next, will cause fewer merge errors, and will improve -next

Re: [Autotest] [PATCH 18/19] KVM test: kvm_tests.cfg.sample: get all Windows test utilities from a single ISO

2009-09-09 Thread Lucas Meneghel Rodrigues
On Wed, Sep 9, 2009 at 3:12 PM, Michael Goldish mgold...@redhat.com wrote: Instead of rss.iso, vlc.iso and autoit.iso -- look for everything in winutils.iso by default. This make maintenance a little easier, and eliminates the need to restart VMs between tests just in order to change the

Re: [Autotest] [PATCH 19/19] KVM test: kvm_preprocessing.py: verify PPM file validity before passing to PIL

2009-09-09 Thread Lucas Meneghel Rodrigues
On Wed, Sep 9, 2009 at 3:12 PM, Michael Goldish mgold...@redhat.com wrote: Passing PIL an invalid PPM file makes it throw an IOError. This one was missing a ppm_utils import. Applied with minimal corrections. Signed-off-by: Michael Goldish mgold...@redhat.com ---  

Re: [Autotest] [PATCH 01/19] KVM test: kvm_utils.py: make verify_ip_address_ownership() more robust

2009-09-09 Thread Lucas Meneghel Rodrigues
As the changes were mostly bugfixes and short, I managed to review and apply them all. Thank you very much Michael! On Wed, Sep 9, 2009 at 3:11 PM, Michael Goldish mgold...@redhat.com wrote: Use arping in addition to querying the arp cache. Under certain circumstances a TCP connection may not

Multiple Port Support for virtio-console

2009-09-09 Thread Amit Shah
Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications. I've tested for compatibility (old qemu new kernel, new qemu old kernel, new qemu new kernel) and it all works fine*. Migration works with the patch Juan just posted. There

[PATCH] virtio_console: Add support for multiple ports for generic guest and host communication

2009-09-09 Thread Amit Shah
Expose multiple char devices (ports) for simple communication between the host userspace and guest. Sample offline usages can be: poking around in a guest to find out the file systems used, applications installed, etc. Online usages can be sharing of clipboard data between the guest and the host,

[PATCH 1/5] char: Emit 'OPENED' events on char device open

2009-09-09 Thread Amit Shah
Notify users of the char interface whenever the file / connection is opened. The existing RESET event is triggered when the qemu char state is reset as well; which may not be as interesting as char device open events. Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.c | 14

[PATCH 2/5] virtio-console: Add support for multiple ports for generic guest-host communication

2009-09-09 Thread Amit Shah
This interface extends the virtio-console device to handle multiple ports that present a char device from which bits can be sent and read. Sample uses for such a device can be obtaining info from the guest like the file systems used, apps installed, etc. for offline usage and logged-in users,

[PATCH 3/5] virtio-console: in-qemu api for open/read/write/close ports

2009-09-09 Thread Amit Shah
This is a simple-to-use api for opening a port, registering a callback for reading stuff, writing to a port and closing it. Another api for hot-adding a port can be provided. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c | 61

[PATCH 4/5] vnc: add a is_vnc_active() helper

2009-09-09 Thread Amit Shah
This helper is introduced to query the status of vnc. Signed-off-by: Amit Shah amit.s...@redhat.com --- vnc.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/vnc.c b/vnc.c index 5eaef6a..ff2d4a8 100644 --- a/vnc.c +++ b/vnc.c @@ -178,9 +178,17 @@ static void

[PATCH 5/5] vnc: Send / receive guest clipboard if virtio-console connected to clipboard port

2009-09-09 Thread Amit Shah
If a connection to the guest clipboard is open, send the host clipboard to the guest and guest clipboard to the host on any change Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.h |1 + vnc.c | 33 + 2 files changed, 34

Re: KVM: SVM: remove needless mmap_sem acquision from nested_svm_map

2009-09-09 Thread Alexander Graf
On 08.09.2009, at 19:47, Marcelo Tosatti wrote: nested_svm_map unnecessarily takes mmap_sem around gfn_to_page, since gfn_to_page / get_user_pages are responsible for it. Looks good. Sorry I didn't send it out yet. (not tested, only looked at the code) Acked-By: Alexander Graf

[ kvm-Bugs-2351676 ] Guests hang periodically on Ubuntu-8.10

2009-09-09 Thread SourceForge.net
Bugs item #2351676, was opened at 2008-11-26 17:59 Message generated for change (Comment added) made by jlokier You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2351676group_id=180599 Please note that this message will contain a full copy of the comment

[ kvm-Bugs-2351676 ] Guests hang periodically on Ubuntu-8.10

2009-09-09 Thread SourceForge.net
Bugs item #2351676, was opened at 2008-11-26 17:59 Message generated for change (Comment added) made by jlokier You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2351676group_id=180599 Please note that this message will contain a full copy of the comment

[ kvm-Bugs-2351676 ] Guests hang periodically on Ubuntu-8.10

2009-09-09 Thread SourceForge.net
Bugs item #2351676, was opened at 2008-11-26 17:59 Message generated for change (Comment added) made by jlokier You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2351676group_id=180599 Please note that this message will contain a full copy of the comment

Re: Modifying RAM during runtime on guest

2009-09-09 Thread Daniel Bareiro
Hi Brian. On Tuesday, 08 September 2009 16:18:09 -0500, Brian Jackson wrote: I'm trying to modify the amount of RAM that has some of guests. Host has 2.6.30 kernel with KVM-88. In one of guest I didn't have problems when decreasing the amount of memory from 3584 MIB to 1024 MiB. This

[PATCH] Use propeer way to compile with HELPER_CFLAGS

2009-09-09 Thread Juan Quintela
This makes the build quiet. Signed-off-by: Juan Quintela quint...@redhat.com --- Makefile.target |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/Makefile.target b/Makefile.target index 221cc2f..1d0fa11 100644 --- a/Makefile.target +++ b/Makefile.target @@ -91,9 +91,7

qemu-kvm: kqemu - R.I.P.

2009-09-09 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com diff --git a/configure b/configure index c4231a5..309f8ae 100755 --- a/configure +++ b/configure @@ -359,7 +359,6 @@ AIX) if [ $cpu = i386 -o $cpu = x86_64 ] ; then audio_possible_drivers=$audio_possible_drivers fmod kvm=yes -

Re: [Qemu-commits] [COMMIT ddd9bbd] Support for multiple -monitor devices

2009-09-09 Thread Avi Kivity
On 09/04/2009 05:43 PM, Anthony Liguori wrote: From: Jan Kiszkajan.kis...@siemens.com Rebased version of Anthony's patch: Allow to specify more than one monitor terminal via the -monitor command line switch. This is particularly useful when libvirt or some other management tool already occupies

[COMMIT master] Remove unneeded printf() in kvm_run()

2009-09-09 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Snuck in during debugging. Signed-off-by: Avi Kivity a...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/qemu-kvm.c b/qemu-kvm.c index d554749..7349c8d 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -965,7 +965,6 @@ int

[COMMIT master] qemu-kvm: Install built option roms

2009-09-09 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com Based on Avi's version: Pick up option roms from the build directory if available. As we do not ship a extboot.bin binary, this also fixes the installation of this rom. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti

[COMMIT master] Handle emulation failure in userspace

2009-09-09 Thread Avi Kivity
From: Mohammed Gamal m.gamal...@gmail.com Since we return to userspace from KVM on invalid state emulation failure, let qemu handle it. Signed-off-by: Mohammed Gamal m.gamal...@gmail.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/qemu-kvm.c b/qemu-kvm.c index

[COMMIT master] Update kvm.h in qemu-kvm tree

2009-09-09 Thread Avi Kivity
From: Mohammed Gamal m.gamal...@gmail.com Update struct kvm_run and KVM_EXIT_* constants to match the one in the kernel-space tree Signed-off-by: Mohammed Gamal m.gamal...@gmail.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/kvm/include/linux/kvm.h b/kvm/include/linux/kvm.h

[COMMIT master] vmxcap: Add tool to query vmx capabilities

2009-09-09 Thread Avi Kivity
From: Avi Kivity a...@redhat.com This should really be in the kernel, but there are too many of them. Signed-off-by: Avi Kivity a...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/kvm/scripts/vmxcap b/kvm/scripts/vmxcap new file mode 100755 index 000..50f094b ---

[COMMIT master] Fix kvm initialization introduced by bad merge ea571d06d8

2009-09-09 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/vl.c b/vl.c index 557c7dd..c791b07 100644 --- a/vl.c +++ b/vl.c @@ -5839,20 +5839,6 @@ int main(int argc, char **argv, char **envp) signal(SIGTTIN, SIG_IGN); } -if (kvm_enabled()) { -

[COMMIT master] Merge branch 'upstream-merge'

2009-09-09 Thread Avi Kivity
From: Avi Kivity a...@redhat.com * upstream-merge: (68 commits) USB: use opaque parameter passing for monitor handle Sparc64: use ISA bus for i8042 Sparc64: remove unused variables Make ioport default tables const Fix indentation When targeting PPU use rlwinm instead of andi. if

[COMMIT master] KVM: VMX: Check cpl before emulating debug register access

2009-09-09 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Debug registers may only be accessed from cpl 0. Unfortunately, vmx will code to emulate the instruction even though it was issued from guest userspace, possibly leading to an unexpected trap later. Cc: sta...@kernel.org Signed-off-by: Avi Kivity a...@redhat.com

[COMMIT master] KVM: fix misreporting of coalesced interrupts by kvm tracer

2009-09-09 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index fd9e166..5694997 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.c @@ -376,7 +376,7 @@

[COMMIT master] KVM: VMX: call vmx_load_host_state() only if msr is cached

2009-09-09 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com No need to call it before each kvm_(set|get)_msr_common() Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 78101dd..49ef7f5 100644 --- a/arch/x86/kvm/vmx.c

[COMMIT master] KVM: x86 emulator: Add pusha and popa instructions

2009-09-09 Thread Avi Kivity
From: Mohammed Gamal m.gamal...@gmail.com This adds pusha and popa instructions (opcodes 0x60-0x61), this enables booting MINIX with invalid guest state emulation on. Signed-off-by: Mohammed Gamal m.gamal...@gmail.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git

[COMMIT master] KVM: VMX: Enhance invalid guest state emulation

2009-09-09 Thread Avi Kivity
From: Mohammed Gamal m.gamal...@gmail.com - Change returned handle_invalid_guest_state() to return relevant exit codes - Move triggering the emulation from vmx_vcpu_run() to vmx_handle_exit() - Return to userspace instead of repeatedly trying to emulate instructions that have already failed

[COMMIT master] KVM: fix compile warnings on s390

2009-09-09 Thread Avi Kivity
From: Heiko Carstens heiko.carst...@de.ibm.com CC arch/s390/kvm/../../../virt/kvm/kvm_main.o arch/s390/kvm/../../../virt/kvm/kvm_main.c: In function '__kvm_set_memory_region': arch/s390/kvm/../../../virt/kvm/kvm_main.c:485: warning: unused variable 'j'

[COMMIT master] KVM: SVM: Don't map nested_vmcb on INTERCEPT_MSR_PROT

2009-09-09 Thread Avi Kivity
From: Alexander Graf ag...@suse.de Thanks to Joerg's previous series of cleanups, we now have almost all information we need to decide what to do on #VMEXIT because we get the variables from the VMCB on VMRUN. Unfortunately there's one piece that slipped through the conversion, namely the MSR

[COMMIT master] KVM: Fix coalesced interrupt reporting in IOAPIC

2009-09-09 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com This bug was introduced by b4a2f5e723e4f7df46731106faf9e2405673c073 Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c index e9de458..38a2d20 100644 ---

[COMMIT master] KVM: remove emulate_popa unused variable

2009-09-09 Thread Avi Kivity
From: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 4ffe1b7..d226dff 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -1245,7 +1245,6 @@ static int emulate_popa(struct

[COMMIT master] KVM: Use thread debug register storage instead of kvm specific data

2009-09-09 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Instead of saving the debug registers from the processor to a kvm data structure, rely in the debug registers stored in the thread structure. This allows us not to save dr6 and dr7. Reduces lightweight vmexit cost by 350 cycles, or 11 percent. Signed-off-by: Avi