Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Michael S. Tsirkin
On Sat, Nov 27, 2010 at 11:12:58AM +0200, Avi Kivity wrote: On 11/26/2010 12:16 PM, Michael S. Tsirkin wrote: On Wed, Nov 24, 2010 at 12:52:11PM +0200, Avi Kivity wrote: Introduce exception-safe objects for calling system, vm, and vcpu ioctls. Signed-off-by: Avi Kivitya...@redhat.com

Re: [PATCH kvm-unit-tests 3/4] Add support for calling a function in guest mode

2010-11-28 Thread Michael S. Tsirkin
On Sat, Nov 27, 2010 at 11:15:18AM +0200, Avi Kivity wrote: On 11/26/2010 04:17 PM, Michael S. Tsirkin wrote: + +#include kvmxx.h +#includeboost/function.hpp This seems to use boost, which is not part of the standard library. Do we want this dependency? We'd need a configure check

Re: [PATCH kvm-unit-tests 4/4] Add sample test using the api test harness

2010-11-28 Thread Avi Kivity
On 11/28/2010 11:04 AM, Michael S. Tsirkin wrote: On Sat, Nov 27, 2010 at 11:15:54AM +0200, Avi Kivity wrote: On 11/26/2010 04:17 PM, Michael S. Tsirkin wrote: + +int main(int ac, char **av) +{ +kvm::system system; +kvm::vm vm(system); +

Re: [PATCH kvm-unit-tests 3/4] Add support for calling a function in guest mode

2010-11-28 Thread Avi Kivity
On 11/28/2010 10:59 AM, Michael S. Tsirkin wrote: On Sat, Nov 27, 2010 at 11:15:18AM +0200, Avi Kivity wrote: On 11/26/2010 04:17 PM, Michael S. Tsirkin wrote: + +#include kvmxx.h +#includeboost/function.hpp This seems to use boost, which is not part of the standard

Re: [PATCH kvm-unit-tests 4/4] Add sample test using the api test harness

2010-11-28 Thread Michael S. Tsirkin
On Sat, Nov 27, 2010 at 11:15:54AM +0200, Avi Kivity wrote: On 11/26/2010 04:17 PM, Michael S. Tsirkin wrote: + +int main(int ac, char **av) +{ +kvm::system system; +kvm::vm vm(system); +identity::setup_vm(vm); +kvm::vcpu vcpu(vm, 0); +identity::vcpu

Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-11-28 Thread Michael S. Tsirkin
On Thu, Nov 25, 2010 at 03:06:44PM +0900, Yoshiaki Tamura wrote: Modify inuse type to uint16_t, let save/load to handle, and revert last_avail_idx with inuse if there are outstanding emulation. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp This changes migration format, so it

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Avi Kivity
On 11/28/2010 10:58 AM, Michael S. Tsirkin wrote: On Sat, Nov 27, 2010 at 11:12:58AM +0200, Avi Kivity wrote: On 11/26/2010 12:16 PM, Michael S. Tsirkin wrote: On Wed, Nov 24, 2010 at 12:52:11PM +0200, Avi Kivity wrote: Introduce exception-safe objects for calling system, vm, and vcpu

Re: [PATCH 15/21] virtio-net: replace qemu_sendv_packet_async() with qemu_sendv_packet_async_proxy().

2010-11-28 Thread Michael S. Tsirkin
On Thu, Nov 25, 2010 at 03:06:54PM +0900, Yoshiaki Tamura wrote: Replace replace qemu_sendv_packet_async() with qemu_sendv_packet_async_proxy() to let event-tap capture events from virtio-net. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Why does every device need to know

Re: [PATCH 13/21] dma-helpers: replace bdrv_aio_writev() with bdrv_aio_writev_proxy().

2010-11-28 Thread Michael S. Tsirkin
On Thu, Nov 25, 2010 at 03:06:52PM +0900, Yoshiaki Tamura wrote: Replace bdrv_aio_writev() with bdrv_aio_writev_proxy() to let event-tap capture events from dma-helpers. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Same comment as -net here: it's not clear when should a

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Avi Kivity
On 11/28/2010 09:54 AM, Gleb Natapov wrote: On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: On 11/23/2010 06:12 PM, Anthony Liguori wrote: On 11/23/2010 09:31 AM, Gleb Natapov wrote: Anthony, Blue No comments on this patch series for almost a week. Can it be applied?

Re: [PATCH 11/21] ioport: insert event_tap_ioport() to ioport_write().

2010-11-28 Thread Michael S. Tsirkin
On Thu, Nov 25, 2010 at 03:06:50PM +0900, Yoshiaki Tamura wrote: Record ioport event to replay it upon failover. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Interesting. This will have to be extended to support ioeventfd. Since each eventfd is really just a binary trigger it

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Gleb Natapov
On Sun, Nov 28, 2010 at 11:38:36AM +0200, Avi Kivity wrote: On 11/28/2010 09:54 AM, Gleb Natapov wrote: On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: On 11/23/2010 06:12 PM, Anthony Liguori wrote: On 11/23/2010 09:31 AM, Gleb Natapov wrote: Anthony, Blue No comments

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Michael S. Tsirkin
On Sun, Nov 28, 2010 at 11:31:09AM +0200, Avi Kivity wrote: On 11/28/2010 10:58 AM, Michael S. Tsirkin wrote: On Sat, Nov 27, 2010 at 11:12:58AM +0200, Avi Kivity wrote: On 11/26/2010 12:16 PM, Michael S. Tsirkin wrote: On Wed, Nov 24, 2010 at 12:52:11PM +0200, Avi Kivity wrote:

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Avi Kivity
On 11/28/2010 11:50 AM, Michael S. Tsirkin wrote: Another problem is that there seem to be two memory allocations and a copy here, apparently just to simplify error handling. It might be fine for this test but won't scale for when performance matters. When it matters, we can fix it.

Can't run qemu-kvm with recent kernels in PAE mode

2010-11-28 Thread Dan Higgins
Hi KVM Gurus. I need some help with this problem that has existed for the past several kernel update releases. It used to work fine, probably back around kernel 2.6.33, but now I can't run any of my usual VM's in KVM with a PAE-enabled kernel. WITH PAE enabled, and WITHOUT KVM enabled (by

Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-11-28 Thread Yoshiaki Tamura
2010/11/28 Michael S. Tsirkin m...@redhat.com: On Thu, Nov 25, 2010 at 03:06:44PM +0900, Yoshiaki Tamura wrote: Modify inuse type to uint16_t, let save/load to handle, and revert last_avail_idx with inuse if there are outstanding emulation. Signed-off-by: Yoshiaki Tamura

Re: [PATCH 15/21] virtio-net: replace qemu_sendv_packet_async() with qemu_sendv_packet_async_proxy().

2010-11-28 Thread Yoshiaki Tamura
2010/11/28 Michael S. Tsirkin m...@redhat.com: On Thu, Nov 25, 2010 at 03:06:54PM +0900, Yoshiaki Tamura wrote: Replace replace qemu_sendv_packet_async() with qemu_sendv_packet_async_proxy() to let event-tap capture events from virtio-net. Signed-off-by: Yoshiaki Tamura

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Michael S. Tsirkin
On Sun, Nov 28, 2010 at 11:54:26AM +0200, Avi Kivity wrote: On 11/28/2010 11:50 AM, Michael S. Tsirkin wrote: Another problem is that there seem to be two memory allocations and a copy here, apparently just to simplify error handling. It might be fine for this test but won't scale

Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-11-28 Thread Michael S. Tsirkin
On Sun, Nov 28, 2010 at 08:27:58PM +0900, Yoshiaki Tamura wrote: 2010/11/28 Michael S. Tsirkin m...@redhat.com: On Thu, Nov 25, 2010 at 03:06:44PM +0900, Yoshiaki Tamura wrote: Modify inuse type to uint16_t, let save/load to handle, and revert last_avail_idx with inuse if there are

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Michael S. Tsirkin
On Wed, Nov 24, 2010 at 12:52:11PM +0200, Avi Kivity wrote: Introduce exception-safe objects for calling system, vm, and vcpu ioctls. Signed-off-by: Avi Kivity a...@redhat.com --- api/kvmxx.cc | 168 ++ api/kvmxx.h | 80

Re: [PATCH 13/21] dma-helpers: replace bdrv_aio_writev() with bdrv_aio_writev_proxy().

2010-11-28 Thread Yoshiaki Tamura
2010/11/28 Michael S. Tsirkin m...@redhat.com: On Thu, Nov 25, 2010 at 03:06:52PM +0900, Yoshiaki Tamura wrote: Replace bdrv_aio_writev() with bdrv_aio_writev_proxy() to let event-tap capture events from dma-helpers. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Same comment

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Michael S. Tsirkin
On Wed, Nov 24, 2010 at 01:59:14PM +0100, Alexander Graf wrote: On 24.11.2010, at 11:52, Avi Kivity wrote: Introduce exception-safe objects for calling system, vm, and vcpu ioctls. Signed-off-by: Avi Kivity a...@redhat.com FWIW, I still disagree with C++ and believe this code to

Re: [PATCH 11/21] ioport: insert event_tap_ioport() to ioport_write().

2010-11-28 Thread Yoshiaki Tamura
2010/11/28 Michael S. Tsirkin m...@redhat.com: On Thu, Nov 25, 2010 at 03:06:50PM +0900, Yoshiaki Tamura wrote: Record ioport event to replay it upon failover. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Interesting. This will have to be extended to support ioeventfd. Since

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Michael S. Tsirkin
On Wed, Nov 24, 2010 at 08:41:26AM -0600, Anthony Liguori wrote: On 11/24/2010 06:59 AM, Alexander Graf wrote: On 24.11.2010, at 11:52, Avi Kivity wrote: Introduce exception-safe objects for calling system, vm, and vcpu ioctls. Signed-off-by: Avi Kivitya...@redhat.com FWIW, I still

Re: [PATCH 13/21] dma-helpers: replace bdrv_aio_writev() with bdrv_aio_writev_proxy().

2010-11-28 Thread Michael S. Tsirkin
On Sun, Nov 28, 2010 at 08:55:28PM +0900, Yoshiaki Tamura wrote: 2010/11/28 Michael S. Tsirkin m...@redhat.com: On Thu, Nov 25, 2010 at 03:06:52PM +0900, Yoshiaki Tamura wrote: Replace bdrv_aio_writev() with bdrv_aio_writev_proxy() to let event-tap capture events from dma-helpers.

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Blue Swirl
On Sun, Nov 28, 2010 at 7:54 AM, Gleb Natapov g...@redhat.com wrote: On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: On 11/23/2010 06:12 PM, Anthony Liguori wrote: On 11/23/2010 09:31 AM, Gleb Natapov wrote: Anthony, Blue No comments on this patch series for almost a week. Can

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Avi Kivity
On 11/28/2010 01:59 PM, Michael S. Tsirkin wrote: FWIW, I still disagree with C++ and believe this code to be hardly readable. A major issue is existing tools. Using C++ would prevent us from using sparce for static code checking. C++ static checking is way better than anything sparse

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Gleb Natapov
On Sun, Nov 28, 2010 at 12:39:13PM +, Blue Swirl wrote: On Sun, Nov 28, 2010 at 7:54 AM, Gleb Natapov g...@redhat.com wrote: On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: On 11/23/2010 06:12 PM, Anthony Liguori wrote: On 11/23/2010 09:31 AM, Gleb Natapov wrote: Anthony,

Re: suggested vhost link speed settings

2010-11-28 Thread Michael Tokarev
28.11.2010 05:26, linux_...@proinbox.com wrote: Hi list, Being that the virtio interfaces are stated as acheiving 5-8 Gb throughput now with vhost, as opposed to 1Gb without, how should their link speed be defined when the choices are 2500M or 1M? The reported link speed for _any_

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Avi Kivity
On 11/28/2010 01:44 PM, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 11:54:26AM +0200, Avi Kivity wrote: On 11/28/2010 11:50 AM, Michael S. Tsirkin wrote: Another problem is that there seem to be two memory allocations and a copy here, apparently just to simplify error

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Michael S. Tsirkin
On Sun, Nov 28, 2010 at 09:54:04AM +0200, Gleb Natapov wrote: On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: On 11/23/2010 06:12 PM, Anthony Liguori wrote: On 11/23/2010 09:31 AM, Gleb Natapov wrote: Anthony, Blue No comments on this patch series for almost a week. Can it

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Avi Kivity
On 11/28/2010 01:49 PM, Michael S. Tsirkin wrote: +++ b/api/kvmxx.cc @@ -0,0 +1,168 @@ +#include kvmxx.h +#includefcntl.h +#includesys/ioctl.h +#includesys/mman.h I just realized this is wrong: I think you should wrap the headers in extern C. Same for other headers. I think system

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Gleb Natapov
On Sun, Nov 28, 2010 at 03:13:52PM +0200, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 09:54:04AM +0200, Gleb Natapov wrote: On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: On 11/23/2010 06:12 PM, Anthony Liguori wrote: On 11/23/2010 09:31 AM, Gleb Natapov wrote:

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Blue Swirl
On Sun, Nov 28, 2010 at 1:19 PM, Gleb Natapov g...@redhat.com wrote: On Sun, Nov 28, 2010 at 03:13:52PM +0200, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 09:54:04AM +0200, Gleb Natapov wrote: On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: On 11/23/2010 06:12 PM, Anthony

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Gleb Natapov
On Sun, Nov 28, 2010 at 03:13:52PM +0200, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 09:54:04AM +0200, Gleb Natapov wrote: On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: On 11/23/2010 06:12 PM, Anthony Liguori wrote: On 11/23/2010 09:31 AM, Gleb Natapov wrote:

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Michael S. Tsirkin
On Sun, Nov 28, 2010 at 03:02:18PM +0200, Avi Kivity wrote: On 11/28/2010 01:59 PM, Michael S. Tsirkin wrote: FWIW, I still disagree with C++ and believe this code to be hardly readable. A major issue is existing tools. Using C++ would prevent us from using sparce for static code

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Avi Kivity
On 11/28/2010 03:57 PM, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 03:02:18PM +0200, Avi Kivity wrote: On 11/28/2010 01:59 PM, Michael S. Tsirkin wrote: FWIW, I still disagree with C++ and believe this code to be hardly readable. A major issue is existing tools.

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Michael S. Tsirkin
On Sun, Nov 28, 2010 at 03:14:17PM +0200, Avi Kivity wrote: On 11/28/2010 01:44 PM, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 11:54:26AM +0200, Avi Kivity wrote: On 11/28/2010 11:50 AM, Michael S. Tsirkin wrote: Another problem is that there seem to be two memory

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Michael S. Tsirkin
On Sun, Nov 28, 2010 at 03:15:52PM +0200, Avi Kivity wrote: On 11/28/2010 01:49 PM, Michael S. Tsirkin wrote: +++ b/api/kvmxx.cc @@ -0,0 +1,168 @@ +#include kvmxx.h +#includefcntl.h +#includesys/ioctl.h +#includesys/mman.h I just realized this is wrong: I think you should

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Michael S. Tsirkin
On Sun, Nov 28, 2010 at 04:34:39PM +0200, Avi Kivity wrote: On 11/28/2010 03:57 PM, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 03:02:18PM +0200, Avi Kivity wrote: On 11/28/2010 01:59 PM, Michael S. Tsirkin wrote: FWIW, I still disagree with C++ and believe this code to be

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Michael S. Tsirkin
On Sun, Nov 28, 2010 at 01:22:42PM +, Blue Swirl wrote: On Sun, Nov 28, 2010 at 1:19 PM, Gleb Natapov g...@redhat.com wrote: On Sun, Nov 28, 2010 at 03:13:52PM +0200, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 09:54:04AM +0200, Gleb Natapov wrote: On Sat, Nov 27, 2010 at

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Kevin O'Connor
On Sun, Nov 28, 2010 at 09:45:34AM +0200, Gleb Natapov wrote: On Sat, Nov 27, 2010 at 04:07:45PM -0500, Kevin O'Connor wrote: On Sat, Nov 27, 2010 at 09:04:24PM +0200, Gleb Natapov wrote: Suppose we add SCSI support to Seabios and suppose SCSI card Seabios can natively boot from has

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Michael S. Tsirkin
On Sun, Nov 28, 2010 at 03:19:00PM +0200, Gleb Natapov wrote: On Sun, Nov 28, 2010 at 03:13:52PM +0200, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 09:54:04AM +0200, Gleb Natapov wrote: On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: On 11/23/2010 06:12 PM, Anthony

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Gleb Natapov
On Sun, Nov 28, 2010 at 12:15:44PM -0500, Kevin O'Connor wrote: On Sun, Nov 28, 2010 at 09:45:34AM +0200, Gleb Natapov wrote: On Sat, Nov 27, 2010 at 04:07:45PM -0500, Kevin O'Connor wrote: On Sat, Nov 27, 2010 at 09:04:24PM +0200, Gleb Natapov wrote: Suppose we add SCSI support to

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Gleb Natapov
On Sun, Nov 28, 2010 at 07:23:20PM +0200, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 03:19:00PM +0200, Gleb Natapov wrote: On Sun, Nov 28, 2010 at 03:13:52PM +0200, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 09:54:04AM +0200, Gleb Natapov wrote: On Sat, Nov 27, 2010 at

Re: [SeaBIOS] [PATCHv6 00/16] boot order specification

2010-11-28 Thread Peter Stuge
Gleb Natapov wrote: There is no way for qemu to know about BCVs or BEVs This is very much the key point. In order to have command line control over the boot process, the machine and the firmware must agree on things. I see two options: 1. QEMU works very very hard to provide a machine that

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Michael S. Tsirkin
On Sun, Nov 28, 2010 at 08:54:38PM +0200, Gleb Natapov wrote: On Sun, Nov 28, 2010 at 07:23:20PM +0200, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 03:19:00PM +0200, Gleb Natapov wrote: On Sun, Nov 28, 2010 at 03:13:52PM +0200, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at

Re: [SeaBIOS] [PATCHv6 00/16] boot order specification

2010-11-28 Thread Peter Stuge
Peter Stuge wrote: Specifying boot device using PCI BDF is a great example of using common structured data. That BDF exists both in machine and firmware data models. Gleb Natapov wrote: Bus numbers are assigned by a guest. Qemu knows nothing about them, so it specify device path by topology.

Re: [SeaBIOS] [PATCHv6 00/16] boot order specification

2010-11-28 Thread Gleb Natapov
On Sun, Nov 28, 2010 at 08:00:29PM +0100, Peter Stuge wrote: Gleb Natapov wrote: There is no way for qemu to know about BCVs or BEVs This is very much the key point. In order to have command line control over the boot process, the machine and the firmware must agree on things. I see

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Gleb Natapov
On Sun, Nov 28, 2010 at 09:09:48PM +0200, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 08:54:38PM +0200, Gleb Natapov wrote: On Sun, Nov 28, 2010 at 07:23:20PM +0200, Michael S. Tsirkin wrote: On Sun, Nov 28, 2010 at 03:19:00PM +0200, Gleb Natapov wrote: On Sun, Nov 28, 2010 at

Re: [SeaBIOS] [PATCHv6 00/16] boot order specification

2010-11-28 Thread Gleb Natapov
On Sun, Nov 28, 2010 at 08:11:45PM +0100, Peter Stuge wrote: Peter Stuge wrote: Specifying boot device using PCI BDF is a great example of using common structured data. That BDF exists both in machine and firmware data models. Gleb Natapov wrote: Bus numbers are assigned by a guest.

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Anthony Liguori
On 11/28/2010 06:27 AM, Michael S. Tsirkin wrote: On Wed, Nov 24, 2010 at 08:41:26AM -0600, Anthony Liguori wrote: On 11/24/2010 06:59 AM, Alexander Graf wrote: On 24.11.2010, at 11:52, Avi Kivity wrote: Introduce exception-safe objects for calling system, vm, and vcpu

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Anthony Liguori
On 11/28/2010 08:40 AM, Michael S. Tsirkin wrote: This code is not reusable. Everywhere you use an fd, you have to repeat this code. But that's not a lot of code. And you can abstract it away at a higher level. For example kvm_init and kvm_cleanup would setup/cleanup state in a

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Michael S. Tsirkin
On Sun, Nov 28, 2010 at 04:04:34PM -0600, Anthony Liguori wrote: To create an object on the stack, you must have the class definition in a public header and a public constructor/destructor. This is exactly the same in C. It's really more of a design statement than a statement about C++ vs.

Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

2010-11-28 Thread Anthony Liguori
On 11/28/2010 04:28 PM, Michael S. Tsirkin wrote: But rather need to use ugly factory functions with all sorts of DO_UPCAST. This is really unfriendly especially for writing test cases. Yes, I agree. Just moving memory allocation out of there will fix most of the ugliness. So

Re: limiting guest block i/o for qos

2010-11-28 Thread T Johnson
Hello, On Thu, Nov 25, 2010 at 3:33 AM, Nikola Ciprich extmaill...@linuxbox.cz wrote: Hello Thomas, I t hink blkio-cgroup really can't help You here, but since NFS is network protocol, why not just consider some kind of network shaping? n. I thought about this, but it's rather imprecise I

[ kvm-Bugs-2432316 ] hotplug inexistent device will kill guest

2010-11-28 Thread SourceForge.net
Bugs item #2432316, was opened at 2008-12-16 10:44 Message generated for change (Comment added) made by haoxudong You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2432316group_id=180599 Please note that this message will contain a full copy of the comment

[PATCH] common_lib: Adding software_manager.py

2010-11-28 Thread Lucas Meneghel Rodrigues
This patch adds a software management abstraction layer on top of popular distro package management abstraction layers. Frequently we want to install a given distro provided software package, but there's no single interface to do so. The software manager API tries to expose conveniently the main

Re: [PATCH] common_lib: Adding software_manager.py

2010-11-28 Thread Lucas Meneghel Rodrigues
On Mon, 2010-11-29 at 00:44 -0200, Lucas Meneghel Rodrigues wrote: This patch adds a software management abstraction layer on top of popular distro package management abstraction layers. Frequently we want to install a given distro provided software package, but there's no single interface to

KVM Test report, kernel 9ee00410... qemu b377474e...

2010-11-28 Thread Hao, Xudong
Hi, all, This is KVM test result against kvm.git 9ee00410d82a7c5cab5ae347d97fbf8a95c55506 based on kernel 2.6.37-rc2, and qemu-kvm.git b377474e589e5a1fe2abc7b13fafa8bad802637a. We found a new bug which qemu processor will be defunct process by be killed, this bug block nightly testing, we got

[PATCH] vhost: correctly set bits of dirty pages

2010-11-28 Thread Jason Wang
When counting pages we should increase it by 1 instead of VHOST_PAGE_SIZE, and also make log_write() can correctly process the request across pages with write_address not start at page boundary. Signed-off-by: Jason Wang jasow...@redhat.com --- drivers/vhost/vhost.c | 20 +---

[PATCH] vhost: fix typos in comment

2010-11-28 Thread Jason Wang
Signed-off-by: Jason Wang jasow...@redhat.com --- drivers/vhost/net.c |2 +- drivers/vhost/vhost.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index d10da28..14fc189 100644 --- a/drivers/vhost/net.c +++

[ kvm-Bugs-2525768 ] kvm image corruption

2010-11-28 Thread SourceForge.net
Bugs item #2525768, was opened at 2009-01-21 08:03 Message generated for change (Comment added) made by jessorensen You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2525768group_id=180599 Please note that this message will contain a full copy of the comment

[ kvm-Bugs-2796640 ] KVM Regression from 2.6.28-11 to 2.6.30-rc5

2010-11-28 Thread SourceForge.net
Bugs item #2796640, was opened at 2009-05-26 03:00 Message generated for change (Comment added) made by jessorensen You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2796640group_id=180599 Please note that this message will contain a full copy of the comment

[ kvm-Bugs-1885747 ] KVM halts, when starting Fedora8 SMP guest

2010-11-28 Thread SourceForge.net
Bugs item #1885747, was opened at 2008-02-03 16:34 Message generated for change (Comment added) made by jessorensen You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=1885747group_id=180599 Please note that this message will contain a full copy of the comment