Newer versions of GCC notice the following unused variables:
qcow.c: In function ‘qcow_read_l1_table’:
qcow.c:56:7: error: variable ‘page_offset’ set but not used
[-Werror=unused-but-set-variable]
qcow.c:54:6: error: variable ‘map_offset’ set but not used
[-Werror=unused-but-set-variable]
Blue Swirl blauwir...@gmail.com writes:
On Wed, Apr 13, 2011 at 4:08 PM, Luiz Capitulino lcapitul...@redhat.com
wrote:
On Tue, 12 Apr 2011 21:31:18 +0300
Blue Swirl blauwir...@gmail.com wrote:
On Tue, Apr 12, 2011 at 10:52 AM, Avi Kivity a...@redhat.com wrote:
On 04/11/2011 08:15 PM,
On Thu, Mar 31, 2011 at 12:06:41PM +0200, Gleb Natapov wrote:
Currently we sync registers back and forth before/after exiting
to userspace for IO, but during IO device model shouldn't need to
read/write the registers, so we can as well skip those sync points. The
only exaception is broken
On 04/14/2011 06:14 AM, brill...@viatech.com.cn wrote:
On 04/13/2011 02:05 PM, brill...@viatech.com.cn wrote:
+/* cpuid 0xC001.edx */
+ const u32 kvm_supported_word5_x86_features =
+F(XSTORE) | F(XSTORE_EN) | F(XCRYPT) | F(XCRYPT_EN)
|
Am 13.04.2011 21:26, schrieb Prasad Joshi:
The patch only implements the basic read write support for QCOW version 1
images. Many of the QCOW features are not implmented, for example
- image creation
- snapshot
- copy-on-write
- encryption
Yay, more forks, more code duplication!
Have
* Kevin Wolf kw...@redhat.com wrote:
Also at least your qcow1.c is lacking the copyright header. Please add this,
otherwise you're violating the license.
AFAICT it's not a copy, it's a reimplementation - and he credited you in the
CREDITS file, for providing a reference implementation. But
Am 14.04.2011 10:07, schrieb Ingo Molnar:
* Kevin Wolf kw...@redhat.com wrote:
Also at least your qcow1.c is lacking the copyright header. Please add this,
otherwise you're violating the license.
AFAICT it's not a copy, it's a reimplementation - and he credited you in the
CREDITS
* Kevin Wolf kw...@redhat.com wrote:
Also at least your qcow1.c is lacking the copyright header. Please add this,
otherwise you're violating the license.
Am 14.04.2011 10:07, schrieb Ingo Molnar:
AFAICT it's not a copy, it's a reimplementation - and he credited you in the
CREDITS file, for
On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote:
Have you thought about a way to actually share code with qemu instead of
repeating Xen's mistake of copying code, modifying it until merges are
no longer possible and then let it bitrot?
No we haven't and we're not planning
Am 14.04.2011 10:15, schrieb Pekka Enberg:
* Kevin Wolf kw...@redhat.com wrote:
Also at least your qcow1.c is lacking the copyright header. Please add
this,
otherwise you're violating the license.
Am 14.04.2011 10:07, schrieb Ingo Molnar:
AFAICT it's not a copy, it's a reimplementation -
* Kevin Wolf kw...@redhat.com wrote:
Am 14.04.2011 10:07, schrieb Ingo Molnar:
* Kevin Wolf kw...@redhat.com wrote:
Also at least your qcow1.c is lacking the copyright header. Please add
this,
otherwise you're violating the license.
AFAICT it's not a copy, it's a
* Kevin Wolf kw...@redhat.com wrote:
Am 14.04.2011 10:15, schrieb Pekka Enberg:
* Kevin Wolf kw...@redhat.com wrote:
Also at least your qcow1.c is lacking the copyright header. Please add
this,
otherwise you're violating the license.
Am 14.04.2011 10:07, schrieb Ingo Molnar:
Am 14.04.2011 10:21, schrieb Pekka Enberg:
On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote:
Have you thought about a way to actually share code with qemu instead of
repeating Xen's mistake of copying code, modifying it until merges are
no longer possible and then let it
Hi Kevin!
Am 14.04.2011 10:21, schrieb Pekka Enberg:
On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote:
Have you thought about a way to actually share code with qemu instead of
repeating Xen's mistake of copying code, modifying it until merges are
no longer possible and then
On Thu, Apr 14, 2011 at 11:32:21AM +0300, Pekka Enberg wrote:
Hi Kevin!
Am 14.04.2011 10:21, schrieb Pekka Enberg:
On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote:
Have you thought about a way to actually share code with qemu instead of
repeating Xen's mistake of
Am 14.04.2011 10:32, schrieb Pekka Enberg:
Hi Kevin!
Am 14.04.2011 10:21, schrieb Pekka Enberg:
On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote:
Have you thought about a way to actually share code with qemu instead of
repeating Xen's mistake of copying code, modifying it
On Thu, Apr 14, 2011 at 9:27 AM, Ingo Molnar mi...@elte.hu wrote:
* Kevin Wolf kw...@redhat.com wrote:
Am 14.04.2011 10:15, schrieb Pekka Enberg:
* Kevin Wolf kw...@redhat.com wrote:
Also at least your qcow1.c is lacking the copyright header. Please add
this,
otherwise you're
Kevin Wolf kw...@redhat.com writes:
Am 14.04.2011 10:32, schrieb Pekka Enberg:
Hi Kevin!
Am 14.04.2011 10:21, schrieb Pekka Enberg:
On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote:
Have you thought about a way to actually share code with qemu instead of
repeating Xen's
* Prasad Joshi prasadjoshi...@gmail.com wrote:
Speaking about the code of finding the cluster offset is so basic, that I
thought it should be implemented the way it is done in the QEMU. But none of
the code is copied from the QEMU sources. The complete code is written from
scratch with
Am 14.04.2011 11:26, schrieb Markus Armbruster:
Kevin Wolf kw...@redhat.com writes:
Am 14.04.2011 10:32, schrieb Pekka Enberg:
Hi Kevin!
Am 14.04.2011 10:21, schrieb Pekka Enberg:
On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote:
Have you thought about a way to actually
On Thu, Apr 14, 2011 at 11:26:07AM +0200, Markus Armbruster wrote:
Kevin Wolf kw...@redhat.com writes:
Am 14.04.2011 10:32, schrieb Pekka Enberg:
Hi Kevin!
Am 14.04.2011 10:21, schrieb Pekka Enberg:
On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote:
Have you
On 4/14/11 12:23 PM, Prasad Joshi wrote:
Oh God. I was walking to university on seventh cloud, hoping to work
on caching the l2 table. Now I find myslef under the controversy.
Again, it's my fault, not yours. I asked to remove the license banner on
top of qcow1.c because it doesn't contain
On 04/14/2011 06:14 AM, brill...@viatech.com.cn wrote:
On 04/13/2011 02:05 PM, brill...@viatech.com.cn wrote:
+/* cpuid 0xC001.edx */
+ const u32 kvm_supported_word5_x86_features =
+F(XSTORE) | F(XSTORE_EN) |
F(XCRYPT) |
On Wed, Apr 13, 2011 at 10:56:21PM +0300, Blue Swirl wrote:
On Wed, Apr 13, 2011 at 4:08 PM, Luiz Capitulino lcapitul...@redhat.com
wrote:
On Tue, 12 Apr 2011 21:31:18 +0300
Blue Swirl blauwir...@gmail.com wrote:
On Tue, Apr 12, 2011 at 10:52 AM, Avi Kivity a...@redhat.com wrote:
On
Kevin Wolf kw...@redhat.com writes:
Am 14.04.2011 11:26, schrieb Markus Armbruster:
Kevin Wolf kw...@redhat.com writes:
Am 14.04.2011 10:32, schrieb Pekka Enberg:
Hi Kevin!
Am 14.04.2011 10:21, schrieb Pekka Enberg:
On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote:
On 04/14/2011 12:54 PM, brill...@viatech.com.cn wrote:
On 04/14/2011 06:14 AM, brill...@viatech.com.cn wrote:
On 04/13/2011 02:05 PM, brill...@viatech.com.cn wrote:
+ /* cpuid 0xC001.edx */
+ const u32 kvm_supported_word5_x86_features =
On Tue, 12 Apr 2011 23:01:12 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Thu, Mar 10, 2011 at 12:19:42PM +1030, Rusty Russell wrote:
Here's an old patch where I played with implementing this:
...
virtio: put last_used and last_avail index into ring itself.
Generally, the
On 04/14/2011 01:24 PM, Sasha Levin wrote:
Use ioctls to assign IP address and bring interface up instead of using
ifconfig.
Not breaking aliasing rules this time.
Signed-off-by: Sasha Levin levinsasha...@gmail.com
---
tools/kvm/virtio-net.c | 29 ++---
1 files
On 04/14/2011 03:52 AM, Kevin Wolf wrote:
Well, copying in itself is not a big problem as long as the copies are
kept in sync. It's a bit painful, but manageable. Implementing every
image format twice (and implementing image formats in a reliable and
performing way isn't trivial) is much more
On Thu, Apr 14, 2011 at 08:58:41PM +0930, Rusty Russell wrote:
On Tue, 12 Apr 2011 23:01:12 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Thu, Mar 10, 2011 at 12:19:42PM +1030, Rusty Russell wrote:
Here's an old patch where I played with implementing this:
...
virtio:
From: Prasad Joshi prasadjoshi...@gmail.com
The patch only implements the basic read-only support for QCOW version 1
images. Many of the QCOW features are not implemented:
- write
- image creation
- snapshot
- copy-on-write
- encryption
The code is based on the following QCOW 1 image
Add support for booting guests to host block devices in read-only mode.
Cc: Asias He asias.he...@gmail.com
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Prasad Joshi prasadjoshi...@gmail.com
Cc: Sasha Levin levinsasha...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Signed-off-by: Pekka Enberg
Changed the function names from sect_to_l1_offset(), sect_to_l2_offset() to
get_l1_index(), get_l2_index() as they return index into their respective table.
Signed-off-by: Prasad Joshi prasadjoshi...@gmail.com
---
tools/kvm/qcow.c | 103 ++
1
On Thu, 2011-04-14 at 20:23 +0100, Prasad Joshi wrote:
Changed the function names from sect_to_l1_offset(), sect_to_l2_offset() to
get_l1_index(), get_l2_index() as they return index into their respective
table.
This patch does a lot more than what's described above. Please split the
changes
On Thu, Apr 14, 2011 at 8:59 PM, Pekka Enberg penb...@kernel.org wrote:
On Thu, 2011-04-14 at 20:23 +0100, Prasad Joshi wrote:
Changed the function names from sect_to_l1_offset(), sect_to_l2_offset() to
get_l1_index(), get_l2_index() as they return index into their respective
table.
This
On Wed, Apr 13, 2011 at 08:01:58PM +0100, Prasad Joshi wrote:
The patch only implements the basic read write support for QCOW version 1
images. Many of the QCOW features are not implmented, for example
What's the point? Qcow1 has been deprecated for a long time.
--
To unsubscribe from this
This means that the truncation behavior in linearize needs to grow an additional
slight piece of complexity: when fetching, truncation is dependent on the
execution mode, instead of the current address size.
Signed-off-by: Nelson Elhage nelh...@ksplice.com
---
arch/x86/include/asm/kvm_emulate.h
37 matches
Mail list logo
