Re: Is AMD rev F the same thing as socket F?

2009-10-19 Thread Chris Lalancette
Neil Aggarwal wrote: I forgot to mention that I have an AMD Opteron 2210 processor. When I get cat /proc/cpuinfo, I get this output for the first core (The second core is the same): vendor_id : AuthenticAMD cpu family : 15 ^^ means that you have a Rev F (cpu_family 15 == 0xf

Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-19 Thread Dor Laor
On 10/15/2009 11:48 AM, Amos Kong wrote: Test 802.1Q vlan of nic, config it by vconfig command. 1) Create two VMs 2) Setup guests in different vlan by vconfig and test communication by ping using hard-coded ip address 3) Setup guests in same vlan and test communication by ping

nice value is ignored on cpu time accounting of a guest?

2009-10-19 Thread Ryota Ozaki
Hi, I have a question on cputime accounting of a guest. CPU time of a guest is always accounted as 'user' time of cpustat even if nice value of the guest is higher than 0. Is there a reason to do so? I think the cpu time of the guest should be accounted into 'nice' as same as a normal process. Am

Re: Nested VMX support v3

2009-10-19 Thread Gleb Natapov
On Thu, Oct 15, 2009 at 04:41:41PM +0200, or...@il.ibm.com wrote: Avi, We have addressed all of the comments, please apply. Doesn't apply to current kvm master. -- Gleb. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

[PATCH 04/12] Fix build without CONFIG_MMU_NOTIFIER

2009-10-19 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- external-module-compat-comm.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/external-module-compat-comm.h b/external-module-compat-comm.h index 8f56f11..fd3aab7 100644 --- a/external-module-compat-comm.h +++

[PATCH 09/12] Drop now unused config.kbuild

2009-10-19 Thread Jan Kiszka
This was used to carry CONFIG_KVM_TRACE into the build. We no longer have such switches, so drop the infrastructure. We can easily reintroduce it once required. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- .gitignore |1 - Makefile |3 +-- configure |3 --- x86/Kbuild |

[PATCH 02/12] Use DESTDIR consitently on installation

2009-10-19 Thread Jan Kiszka
Apply DESTDIR also on old module renaming and depmod. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Makefile |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 37a14e1..8314833 100644 --- a/Makefile +++ b/Makefile @@ -49,11 +49,11 @@

[PATCH 08/12] Cleanup unused CONFIG_KVM_TRACE control

2009-10-19 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Makefile |6 +- configure |6 -- external-module-compat-comm.h |7 --- 3 files changed, 1 insertions(+), 18 deletions(-) diff --git a/Makefile b/Makefile index 8614449..8420d11

[PATCH 03/12] Add udev rule

2009-10-19 Thread Jan Kiszka
Ported from OpenSUSE: Provide an udev rule that not only sets the group of /dev/kvm but also triggers automatic loading of the kernel modules during boot. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Makefile |1 + scripts/65-kvm.rules |2 ++ 2 files changed, 3

[PATCH 01/12] Provide schedule_hrtimeout for pre-2.6.28 kernels

2009-10-19 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- external-module-compat-comm.h |4 +++ external-module-compat.c | 59 + 2 files changed, 63 insertions(+), 0 deletions(-) diff --git a/external-module-compat-comm.h

[PATCH 11/12] x86: Install compat wrapper for thread_struct.debugreg

2009-10-19 Thread Jan Kiszka
preempt.c already has one, now x86.c need it too. Generalize it and make it more robust against potential naming conflicts. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- sync |2 ++ x86/external-module-compat.h |6 ++ x86/preempt.c|

[PATCH 06/12] Add compat version of native_read_tsc

2009-10-19 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- x86/external-module-compat.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h index 2545ce9..a1a21a5 100644 --- a/x86/external-module-compat.h +++

[PULL REQUEST] kvm-kmod

2009-10-19 Thread Jan Kiszka
The following changes since commit bf860c9b3aa0803ee98d096b33a3ab72f576d79e: Jan Kiszka (1): Update source link are available in the git repository at: git://git.kiszka.org/kvm-kmod.git queue Jan Kiszka (12): Provide schedule_hrtimeout for pre-2.6.28 kernels Use DESTDIR

[PATCH 05/12] Fix kvm_vma_kernel_pagesize for pre-2.6.27 kernels

2009-10-19 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- external-module-compat-comm.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/external-module-compat-comm.h b/external-module-compat-comm.h index fd3aab7..2892ace 100644 --- a/external-module-compat-comm.h +++

[PATCH 12/12] Update source link

2009-10-19 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- linux-2.6 |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-2.6 b/linux-2.6 index 8fdcaf6..f3ed8d8 16 --- a/linux-2.6 +++ b/linux-2.6 @@ -1 +1 @@ -Subproject commit 8fdcaf60d3e7d96450f3ae05c56f1046327fb3fe

[PATCH 07/12] Define X86_FEATURE_GBPAGES if missing

2009-10-19 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- x86/external-module-compat.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h index a1a21a5..7056aa1 100644 --- a/x86/external-module-compat.h +++

[PATCH 10/12] Add compat version of hlist_del_init_rcu

2009-10-19 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- external-module-compat-comm.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/external-module-compat-comm.h b/external-module-compat-comm.h index a8f8a2f..cec117b 100644 --- a/external-module-compat-comm.h

Re: [PATCH 3/5] Nested VMX patch 3 implements vmptrld and vmptrst

2009-10-19 Thread Gleb Natapov
On Thu, Oct 15, 2009 at 04:41:44PM +0200, or...@il.ibm.com wrote: From: Orit Wasserman or...@il.ibm.com --- arch/x86/kvm/vmx.c | 468 ++-- arch/x86/kvm/x86.c |3 +- 2 files changed, 459 insertions(+), 12 deletions(-) diff --git

lspci says: SCSI storage controller: Qumranet, Inc. Virtio block device. Is it really?

2009-10-19 Thread Tomasz Chmielewski
lspci implies that the virtio block device is a SCSI storage controller, i.e.: 00:05.0 SCSI storage controller: Qumranet, Inc. Virtio block device However, virtio block devide does not have much to do with SCSI (in sense: sdparm does not think it is a SCSI device; virtio_blk does not depend

Re: [PATCH 3/5] Nested VMX patch 3 implements vmptrld and vmptrst

2009-10-19 Thread Gleb Natapov
On Thu, Oct 15, 2009 at 04:41:44PM +0200, or...@il.ibm.com wrote: +static struct page *nested_get_page(struct kvm_vcpu *vcpu, + u64 vmcs_addr) +{ + struct page *vmcs_page = NULL; + + down_read(current-mm-mmap_sem); + vmcs_page =

Re: lspci says: SCSI storage controller: Qumranet, Inc. Virtio block device. Is it really?

2009-10-19 Thread Luca Tettamanti
On Mon, Oct 19, 2009 at 2:14 PM, Tomasz Chmielewski man...@wpkg.org wrote: lspci implies that the virtio block device is a SCSI storage controller, i.e.: 00:05.0 SCSI storage controller: Qumranet, Inc. Virtio block device However, virtio block devide does not have much to do with SCSI (in

Re: [PATCH 4/5] Nested VMX patch 4 implements vmread and vmwrite

2009-10-19 Thread Gleb Natapov
On Thu, Oct 15, 2009 at 04:41:45PM +0200, or...@il.ibm.com wrote: From: Orit Wasserman or...@il.ibm.com --- arch/x86/kvm/vmx.c | 591 +++- 1 files changed, 589 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/vmx.c

Re: [PATCH 03/12] Add udev rule

2009-10-19 Thread Michael Tokarev
Jan Kiszka wrote: Ported from OpenSUSE: Provide an udev rule that not only sets the group of /dev/kvm but also triggers automatic loading of the kernel modules during boot. [] diff --git a/Makefile b/Makefile index 8314833..8614449 100644 --- a/Makefile +++ b/Makefile @@ -54,6 +54,7 @@

[PATCH 1/3] use handle_io upstream version.

2009-10-19 Thread Glauber Costa
We can use upstream version of handle_io, there called kvm_handle_io() Signed-off-by: Glauber Costa glom...@redhat.com --- kvm-all.c |2 ++ qemu-kvm.c | 58 +- 2 files changed, 7 insertions(+), 53 deletions(-) diff --git a/kvm-all.c

[PATCH 2/3] change pre and post kvm_run signatures.

2009-10-19 Thread Glauber Costa
Intention is to merge with upstream version in the following patch. Doing as a separate step to help identify any further issues. Signed-off-by: Glauber Costa glom...@redhat.com --- qemu-kvm-x86.c |6 -- qemu-kvm.c |4 ++-- qemu-kvm.h |4 ++-- 3 files changed, 8

[PATCH 3/3] use upstream version of kvm_arch_post_run

2009-10-19 Thread Glauber Costa
Replace ours with qemu.git version. A couple of functions go unused, and are deleted. Signed-off-by: Glauber Costa glom...@redhat.com --- qemu-kvm-x86.c| 22 -- qemu-kvm.c|5 - qemu-kvm.h| 11 --- target-i386/kvm.c |2 ++ 4 files

[PATCH 0/3] Further integration with qemu.git

2009-10-19 Thread Glauber Costa
A couple of more functions are used from qemu.git. Merging keeps going... -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/12] Add udev rule

2009-10-19 Thread Jan Kiszka
Michael Tokarev wrote: Jan Kiszka wrote: Ported from OpenSUSE: Provide an udev rule that not only sets the group of /dev/kvm but also triggers automatic loading of the kernel modules during boot. [] diff --git a/Makefile b/Makefile index 8314833..8614449 100644 --- a/Makefile +++

Re: [PATCH 03/12] Add udev rule

2009-10-19 Thread Luca Tettamanti
On Mon, Oct 19, 2009 at 12:59 PM, Jan Kiszka jan.kis...@siemens.com wrote: Ported from OpenSUSE: Provide an udev rule that not only sets the group of /dev/kvm but also triggers automatic loading of the kernel modules during boot. Loading kvm used to block other virtualization software from

[PATCH] move tpr stuff to qemu-kvm-x86.c

2009-10-19 Thread Glauber Costa
this whole tpr thing does not belong in common code. Move it to i386 specific files. Signed-off-by: Glauber Costa glom...@redhat.com --- qemu-kvm-x86.c |7 +++ qemu-kvm.c |6 -- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/qemu-kvm-x86.c b/qemu-kvm-x86.c

Re: lspci says: SCSI storage controller: Qumranet, Inc. Virtio block device. Is it really?

2009-10-19 Thread Tomasz Chmielewski
Luca Tettamanti wrote: On Mon, Oct 19, 2009 at 2:14 PM, Tomasz Chmielewski man...@wpkg.org wrote: lspci implies that the virtio block device is a SCSI storage controller, i.e.: 00:05.0 SCSI storage controller: Qumranet, Inc. Virtio block device However, virtio block devide does not have much

Re: [PATCH 03/12] Add udev rule

2009-10-19 Thread Jan Kiszka
Luca Tettamanti wrote: On Mon, Oct 19, 2009 at 12:59 PM, Jan Kiszka jan.kis...@siemens.com wrote: Ported from OpenSUSE: Provide an udev rule that not only sets the group of /dev/kvm but also triggers automatic loading of the kernel modules during boot. Loading kvm used to block other

Re: lspci says: SCSI storage controller: Qumranet, Inc. Virtio block device. Is it really?

2009-10-19 Thread Luca Tettamanti
On Mon, Oct 19, 2009 at 3:31 PM, Tomasz Chmielewski man...@wpkg.org wrote: Luca Tettamanti wrote: On Mon, Oct 19, 2009 at 2:14 PM, Tomasz Chmielewski man...@wpkg.org wrote: lspci implies that the virtio block device is a SCSI storage controller, i.e.: 00:05.0 SCSI storage controller:

Re: lspci says: SCSI storage controller: Qumranet, Inc. Virtio block device. Is it really?

2009-10-19 Thread Tomasz Chmielewski
Luca Tettamanti wrote: So why was SCSI storage controller any better than IDE interface or SATA controller for virtio block device, if it does not talk SCSI protocol (other than SCSI storage controller being the first on the list of subclasses)? Because both ATA and SATA classes have a

Re: lspci says: SCSI storage controller: Qumranet, Inc. Virtio block device. Is it really?

2009-10-19 Thread Vadim Rozenfeld
On 10/19/2009 03:42 PM, Tomasz Chmielewski wrote: Luca Tettamanti wrote: So why was SCSI storage controller any better than IDE interface or SATA controller for virtio block device, if it does not talk SCSI protocol (other than SCSI storage controller being the first on the list of

Re: guest .img files

2009-10-19 Thread Cole Robinson
On 10/17/2009 06:52 PM, Kenni Lund wrote: 2009/10/17 Lynn Wilborn l...@hotrodpc.com: I have a windows 2003 server guest that's been registered with MS, and it probably won't let me do that many more times. So I want to save the guest, erase fedora, and install centos 5.4 when it comes out.

RE: Is AMD rev F the same thing as socket F?

2009-10-19 Thread Neil Aggarwal
Chris: cpu family : 15 ^^ means that you have a Rev F (cpu_family 15 == 0xf in hex). That is good to know. Thanks for the info. I am actually quite surprised this processor does not have the constant time stamp counter because the RHEL virtualization guide states it is a feature of

Re: [PATCH 03/12] Add udev rule

2009-10-19 Thread Anthony Liguori
Jan Kiszka wrote: Ported from OpenSUSE: Provide an udev rule that not only sets the group of /dev/kvm but also triggers automatic loading of the kernel modules during boot. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Makefile |1 + scripts/65-kvm.rules |2 ++ 2

Re: [PATCH 03/12] Add udev rule

2009-10-19 Thread Jan Kiszka
Anthony Liguori wrote: Jan Kiszka wrote: Ported from OpenSUSE: Provide an udev rule that not only sets the group of /dev/kvm but also triggers automatic loading of the kernel modules during boot. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Makefile |1 +

Re: [PATCH 03/12] Add udev rule

2009-10-19 Thread Anthony Liguori
Jan Kiszka wrote: Anthony Liguori wrote: I believe F12 is installing it 666. If we think it's safe, it's probably the right thing to do. Err, you mean /dev/kvm, not this rules file, right? Yeah, not enough caffeine yet.. Well, in theory it should be safe, but I would

Re: [PATCH 5/5] Nested VMX patch 5 implements vmlaunch and vmresume

2009-10-19 Thread Gleb Natapov
On Thu, Oct 15, 2009 at 04:41:46PM +0200, or...@il.ibm.com wrote: From: Orit Wasserman or...@il.ibm.com --- arch/x86/kvm/vmx.c | 1173 ++-- 1 files changed, 1148 insertions(+), 25 deletions(-) diff --git a/arch/x86/kvm/vmx.c

Re: [PATCH v2 0/3] get rid of vcpu structure

2009-10-19 Thread Marcelo Tosatti
On Thu, Oct 15, 2009 at 01:50:34PM -0300, Glauber Costa wrote: Same as before, fixing test for ioctl return values as suggested by Marcelo. Applied 1 and 2, thanks. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] KVM: SVM: Cleanup NMI singlestep

2009-10-19 Thread Marcelo Tosatti
On Sun, Oct 18, 2009 at 01:24:54PM +0200, Jan Kiszka wrote: Push the NMI-related singlestep variable into vcpu_svm. It's dealing with an AMD-specific deficit, nothing generic for x86. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Applied, thanks. -- To unsubscribe from this list: send

Re: [PATCH][REPOST] Xen PV-on-HVM guest support (v3)

2009-10-19 Thread Marcelo Tosatti
On Thu, Oct 15, 2009 at 03:21:43PM -0700, Ed Swierk wrote: [Repost; the patch was garbled in my previous attempt.] Support for Xen PV-on-HVM guests can be implemented almost entirely in userspace, except for handling one annoying MSR that maps a Xen hypercall blob into guest address space.

Re: [PATCH] KVM: x86: Fix guest single-stepping while interruptible

2009-10-19 Thread Marcelo Tosatti
On Sun, Oct 18, 2009 at 01:24:44PM +0200, Jan Kiszka wrote: Commit 705c5323 opened the doors of hell by unconditionally injecting single-step flags as long as guest_debug signaled this. This doesn't work when the guest branches into some interrupt or exception handler and triggers a vmexit

Re: lspci says: SCSI storage controller: Qumranet, Inc. Virtio block device. Is it really?

2009-10-19 Thread Gerd Hoffmann
C 01 Mass storage controller 00 SCSI storage controller 01 IDE interface 02 Floppy disk controller 03 IPI bus controller 04 RAID bus controller 05 ATA controller 20 ADMA single stepping 30 ADMA continuous operation 06 SATA controller 00 Vendor specific 01 AHCI 1.0 07 Serial Attached SCSI

Re: [PULL REQUEST] kvm-kmod

2009-10-19 Thread Marcelo Tosatti
On Mon, Oct 19, 2009 at 12:59:24PM +0200, Jan Kiszka wrote: The following changes since commit bf860c9b3aa0803ee98d096b33a3ab72f576d79e: Jan Kiszka (1): Update source link are available in the git repository at: git://git.kiszka.org/kvm-kmod.git queue Jan Kiszka (12):

Re: Is AMD rev F the same thing as socket F?

2009-10-19 Thread Brian Jackson
On Monday 19 October 2009 09:21:48 am Neil Aggarwal wrote: Chris: cpu family : 15 ^^ means that you have a Rev F (cpu_family 15 == 0xf in hex). That is good to know. Thanks for the info. I am actually quite surprised this processor does not have the constant time stamp counter

Re: [PATCH] v5: allow userspace to adjust kvmclock offset

2009-10-19 Thread Marcelo Tosatti
On Fri, Oct 16, 2009 at 03:28:36PM -0400, Glauber Costa wrote: When we migrate a kvm guest that uses pvclock between two hosts, we may suffer a large skew. This is because there can be significant differences between the monotonic clock of the hosts involved. When a new host with a much larger

Re: [PATCH 0/3] Fix migration of linux guests using kvmclock

2009-10-19 Thread Marcelo Tosatti
On Fri, Oct 16, 2009 at 03:27:36PM -0400, Glauber Costa wrote: This series uses the new ioctl I've just posted to the kernel. It is pretty straightforward usage. We first have to save and restore kvm msr registers, and later, which is done in patch 2. It has nothing to do with our ioctls,

Re: [PATCH v2 4/4] KVM: x86: Add VCPU substate for NMI states

2009-10-19 Thread Marcelo Tosatti
On Thu, Oct 15, 2009 at 07:05:36PM +0200, Jan Kiszka wrote: This plugs an NMI-related hole in the VCPU synchronization between kernel and user space. So far, neither pending NMIs nor the inhibit NMI mask was properly read/set which was able to cause problems on vmsave/restore, live migration

Re: [PATCH v2 4/4] KVM: x86: Add VCPU substate for NMI states

2009-10-19 Thread Gleb Natapov
On Mon, Oct 19, 2009 at 06:32:54PM -0200, Marcelo Tosatti wrote: On Thu, Oct 15, 2009 at 07:05:36PM +0200, Jan Kiszka wrote: This plugs an NMI-related hole in the VCPU synchronization between kernel and user space. So far, neither pending NMIs nor the inhibit NMI mask was properly read/set

Re: vhost-net patches

2009-10-19 Thread Sridhar Samudrala
On Sun, 2009-10-18 at 19:32 +0200, Michael S. Tsirkin wrote: On Sun, Oct 18, 2009 at 12:53:56PM +0200, Michael S. Tsirkin wrote: On Fri, Oct 16, 2009 at 12:29:29PM -0700, Sridhar Samudrala wrote: Hi Michael, We are trying out your vhost-net patches from your git trees on

Re: [PATCH v2 4/4] KVM: x86: Add VCPU substate for NMI states

2009-10-19 Thread Avi Kivity
On 10/20/2009 05:39 AM, Gleb Natapov wrote: BTW, what happens to exceptions that fail to be delivered? Can't see where they are saved/restored across migration. The instruction that caused an exception will be re-executed after migration and exception will be regenerated. Except for

Re: [PATCH] v5: allow userspace to adjust kvmclock offset

2009-10-19 Thread Avi Kivity
On 10/17/2009 04:28 AM, Glauber Costa wrote: When we migrate a kvm guest that uses pvclock between two hosts, we may suffer a large skew. This is because there can be significant differences between the monotonic clock of the hosts involved. When a new host with a much larger monotonic time

Re: [PATCH 1/3] introduce VMSTATE_U64

2009-10-19 Thread Avi Kivity
On 10/17/2009 04:27 AM, Glauber Costa wrote: This is a patch actually written by Juan, which, according to him, he plans on posting to qemu.git. Problem is that linux defines u64 in a way that is type-uncompatible with uint64_t. I am including it here, because it is a dependency to my patch

Re: [PATCH 0/3] Further integration with qemu.git

2009-10-19 Thread Avi Kivity
On 10/19/2009 10:20 PM, Glauber Costa wrote: A couple of more functions are used from qemu.git. Merging keeps going... Looks good. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. -- To unsubscribe from this list: send the line

Re: [PATCH] move tpr stuff to qemu-kvm-x86.c

2009-10-19 Thread Avi Kivity
On 10/19/2009 10:29 PM, Glauber Costa wrote: this whole tpr thing does not belong in common code. Move it to i386 specific files. Ack, but: @@ -157,6 +157,10 @@ int kvm_arch_create(kvm_context_t kvm, unsigned long phys_mem_bytes, if (r 0) return r; +#ifdef

Re: [PATCH 1/3] introduce VMSTATE_U64

2009-10-19 Thread Glauber Costa
On Tue, Oct 20, 2009 at 08:40:26AM +0900, Avi Kivity wrote: On 10/17/2009 04:27 AM, Glauber Costa wrote: This is a patch actually written by Juan, which, according to him, he plans on posting to qemu.git. Problem is that linux defines u64 in a way that is type-uncompatible with uint64_t. I

Do I set up separate bridges for each guest?

2009-10-19 Thread Neil Aggarwal
Hello: I am installing KVM on top of CentOS 5.4 so I can have two guests running on my host. I would like to have the host and guests accessible from my network. Do I set up separate bridges for each guest or would they somehow be shared? If I set up separate bridges, I think I need to do in

Re: Nested VMX support v3

2009-10-19 Thread Avi Kivity
On 10/15/2009 11:41 PM, or...@il.ibm.com wrote: Avi, We have addressed all of the comments, please apply. The following patches implement nested VMX support. The patches enable a guest to use the VMX APIs in order to run its own nested guest (i.e., enable running other hypervisors which use VMX

Re: [PATCH 1/5] Nested VMX patch 1 implements vmon and vmoff

2009-10-19 Thread Avi Kivity
On 10/15/2009 11:41 PM, or...@il.ibm.com wrote: /* + * Handles msr read for nested virtualization + */ +static int nested_vmx_get_msr(struct kvm_vcpu *vcpu, u32 msr_index, + u64 *pdata) +{ + u64 vmx_msr = 0; + + switch (msr_index) { + case

Re: [PATCH 2/5] Nested VMX patch 2 implements vmclear

2009-10-19 Thread Avi Kivity
On 10/15/2009 11:41 PM, or...@il.ibm.com wrote: From: Orit Wassermanor...@il.ibm.com --- arch/x86/kvm/vmx.c | 70 --- 1 files changed, 65 insertions(+), 5 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index

Re: [PATCH 3/5] Nested VMX patch 3 implements vmptrld and vmptrst

2009-10-19 Thread Avi Kivity
On 10/15/2009 11:41 PM, or...@il.ibm.com wrote: + +struct __attribute__ ((__packed__)) shadow_vmcs { Since this is in guest memory, we need it packed so the binary format is preserved across migration. Please add a comment so it isn't changed (at least without changing the

Re: [PATCH 4/5] Nested VMX patch 4 implements vmread and vmwrite

2009-10-19 Thread Avi Kivity
On 10/15/2009 11:41 PM, or...@il.ibm.com wrote: +static int nested_map_shadow_vmcs(struct kvm_vcpu *vcpu) +{ + struct vcpu_vmx *vmx = to_vmx(vcpu); + struct page *vmcs_page = nested_get_page(vcpu, vmx-nested.vmptr); + + if (vmcs_page == NULL) { + printk(KERN_INFO

Re: [PATCH 5/5] Nested VMX patch 5 implements vmlaunch and vmresume

2009-10-19 Thread Avi Kivity
On 10/15/2009 11:41 PM, or...@il.ibm.com wrote: From: Orit Wassermanor...@il.ibm.com --- arch/x86/kvm/vmx.c | 1173 ++-- 1 files changed, 1148 insertions(+), 25 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index

Re: nice value is ignored on cpu time accounting of a guest?

2009-10-19 Thread Avi Kivity
On 10/19/2009 06:46 PM, Ryota Ozaki wrote: Hi, I have a question on cputime accounting of a guest. CPU time of a guest is always accounted as 'user' time of cpustat even if nice value of the guest is higher than 0. Is there a reason to do so? I think the cpu time of the guest should be

Re: linux-next: tree build failure

2009-10-19 Thread Hollis Blanchard
On Thu, 2009-10-15 at 08:27 +0100, Jan Beulich wrote: Hollis Blanchard holl...@us.ibm.com 15.10.09 00:57 On Fri, 2009-10-09 at 12:14 -0700, Hollis Blanchard wrote: Rusty's version of BUILD_BUG_ON() does indeed fix the build break, and also exposes the bug in kvmppc_account_exit_stat(). So

Re: linux-next: tree build failure

2009-10-19 Thread Rusty Russell
On Tue, 20 Oct 2009 04:49:29 am Hollis Blanchard wrote: On Thu, 2009-10-15 at 08:27 +0100, Jan Beulich wrote: My perspective is that it just uncovered already existing brokenness. Sorry, I thought it was clear, but to be more explicit: I propose the following patch, which replaces the

Re: linux-next: tree build failure

2009-10-19 Thread Hollis Blanchard
On Tue, 2009-10-20 at 11:42 +1030, Rusty Russell wrote: On Tue, 20 Oct 2009 04:49:29 am Hollis Blanchard wrote: On Thu, 2009-10-15 at 08:27 +0100, Jan Beulich wrote: My perspective is that it just uncovered already existing brokenness. Sorry, I thought it was clear, but to be more

[PATCH] BUILD_BUG_ON: make it handle more cases

2009-10-19 Thread Rusty Russell
BUILD_BUG_ON used to use the optimizer to do code elimination or fail at link time; it was changed to first the size of a negative array (a nicer compile time error), then (in 8c87df457cb58fe75b9b893007917cf8095660a0) to a bitfield. bitfields: needs a literal constant at parse time, and can't be