Re: [PATCH] Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS

Joerg Roedel writes: > On Mon, Oct 05, 2015 at 12:54:43PM -0400, Bandan Das wrote: >> Joerg Roedel writes: >> The problems is that the next_rip field could be stale. If the processor >> supports >> next_rip, then it will clear it out on the next entry. If it

RE: [RFT - PATCH v2 0/2] KVM/arm64: add fp/simd lazy switch support

Will do, I'll get them over to you. -Original Message- From: Christoffer Dall [mailto:christoffer.d...@linaro.org] Sent: Monday, October 05, 2015 10:26 AM To: Mario Smarduch Cc: kvm...@lists.cs.columbia.edu; marc.zyng...@arm.com; kvm@vger.kernel.org; linux-arm-ker...@lists.infradead.org

Re: [PATCH 04/12] KVM: x86: Replace call-back set_tsc_khz() with a common function

2015-09-28 13:38+0800, Haozhong Zhang: > Both VMX and SVM propagate virtual_tsc_khz in the same way, so this > patch removes the call-back set_tsc_khz() and replaces it with a common > function. > > Signed-off-by: Haozhong Zhang > --- > diff --git a/arch/x86/kvm/x86.c

Re: [PATCH 08/12] KVM: x86: Use the correct vcpu's TSC rate to compute time scale

2015-09-28 13:38+0800, Haozhong Zhang: > This patch makes KVM use virtual_tsc_khz rather than the host TSC rate > as vcpu's TSC rate to compute the time scale if TSC scaling is enabled. > > Signed-off-by: Haozhong Zhang > --- > diff --git a/arch/x86/kvm/x86.c

Re: [PATCH] Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS

> So the right fix would be to just set the guests next_rip to 0 when we > emulate vmrun, just like real hardware does, no? Like this? (Note: I’m not sure what I’m doing here..). I Agree with you that the warning for this seems excessive, I’ve just removed it.

Re: [PATCH 04/12] KVM: x86: Replace call-back set_tsc_khz() with a common function

On Mon, Oct 5, 2015 at 12:53 PM, Radim Krčmář wrote: > 2015-09-28 13:38+0800, Haozhong Zhang: >> Both VMX and SVM propagate virtual_tsc_khz in the same way, so this >> patch removes the call-back set_tsc_khz() and replaces it with a common >> function. >> >> Signed-off-by:

RE: [RFC PATCH 2/6] iommu: Add interface to get msi-pages mapping attributes

> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Saturday, October 03, 2015 4:16 AM > To: Bhushan Bharat-R65777 > Cc: kvm...@lists.cs.columbia.edu; kvm@vger.kernel.org; > christoffer.d...@linaro.org;

Re: [PATCH 1/3] Target-microblaze: Remove unnecessary variable

05.10.2015 08:18, Markus Armbruster wrote: > Michael Tokarev writes: > >> 25.09.2015 11:37, Shraddha Barke wrote: >>> Compress lines and remove the variable . >> >> Applied to -trivial, removing this piece of commit message: >> >> --- >>> Change made using Coccinelle script

RE: [RFC PATCH 5/6] vfio-pci: Create iommu mapping for msi interrupt

> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Saturday, October 03, 2015 4:17 AM > To: Bhushan Bharat-R65777 > Cc: kvm...@lists.cs.columbia.edu; kvm@vger.kernel.org; > christoffer.d...@linaro.org;

Re: [Qemu-devel] [PATCH 1/3] Target-microblaze: Remove unnecessary variable

On 5 October 2015 at 08:18, Michael Tokarev wrote: > 05.10.2015 08:18, Markus Armbruster wrote: >> Why? I like having the semantic patch in the commit message when >> there's any chance we'll want do the same mechanical change again later. >> >> You could save space and include

RE: [RFC PATCH 3/6] vfio: Extend iommu-info to return MSIs automap state

> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Saturday, October 03, 2015 4:16 AM > To: Bhushan Bharat-R65777 > Cc: kvm...@lists.cs.columbia.edu; kvm@vger.kernel.org; > christoffer.d...@linaro.org;

RE: [RFC PATCH 4/6] vfio: Add interface to iommu-map/unmap MSI pages

> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Saturday, October 03, 2015 4:16 AM > To: Bhushan Bharat-R65777 > Cc: kvm...@lists.cs.columbia.edu; kvm@vger.kernel.org; > christoffer.d...@linaro.org;

RE: [RFC PATCH 6/6] arm-smmu: Allow to set iommu mapping for MSI

> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Saturday, October 03, 2015 4:17 AM > To: Bhushan Bharat-R65777 > Cc: kvm...@lists.cs.columbia.edu; kvm@vger.kernel.org; > christoffer.d...@linaro.org;

Re: [PATCH] Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS

On Thu, Oct 01, 2015 at 06:31:27PM -0400, Bandan Das wrote: > Paolo Bonzini writes: > > > On 01/10/2015 13:43, Dirk Müller wrote: > >> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > >> index 94b7d15..0a42859 100644 > >> --- a/arch/x86/kvm/svm.c > >> +++

Re: [PATCH 3/3] kvm-all: notice KVM of vcpu's TSC rate after migration

On Wed, Sep 30, 2015 at 05:36:11PM -0300, Eduardo Habkost wrote: > On Wed, Sep 30, 2015 at 08:32:26AM +0800, Haozhong Zhang wrote: > > > [...] > > > > > Or maybe we shouldn't treat this as VM state, but as configuration, > > > > > and > > > > > let management configure the TSC frequency

Re: [Qemu-devel] [PATCH 1/3] target-i386: add a subsection of vcpu's TSC rate in vmstate_x86_cpu

On Wed, Sep 30, 2015 at 09:07:08AM +0100, Dr. David Alan Gilbert wrote: > * Haozhong Zhang (haozhong.zh...@intel.com) wrote: > > On Tue, Sep 29, 2015 at 08:00:13PM +0100, Dr. David Alan Gilbert wrote: > > > * Haozhong Zhang (haozhong.zh...@intel.com) wrote: > > > > The newly added subsection

Re: [PATCH 02/12] KVM: x86: Add a common TSC scaling ratio field in kvm_vcpu_arch

On Mon, Oct 05, 2015 at 09:26:30PM +0200, Radim Krčmář wrote: > 2015-09-28 13:38+0800, Haozhong Zhang: > > This patch moves the field of TSC scaling ratio from the architecture > > struct vcpu_svm to the common struct kvm_vcpu_arch. > > > > Signed-off-by: Haozhong Zhang

Re: [kvm-unit-tests PATCHv2] arm: Add PMU test

On 10/02/2015 10:48 AM, Christopher Covington wrote: > Add test the ARM Performance Monitors Unit (PMU). The informational > fields from the control register are printed, but not checked, and > the number of cycles it takes to run a known-instruction-count loop > is printed, but not checked.

Re: [PATCH] Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS

Dirk Müller writes: >> So the right fix would be to just set the guests next_rip to 0 when we >> emulate vmrun, just like real hardware does, no? > > Like this? (Note: I’m not sure what I’m doing here..). I Agree with you that > the warning > for this seems excessive, I’ve

Re: [PATCH 02/12] KVM: x86: Add a common TSC scaling ratio field in kvm_vcpu_arch

2015-09-28 13:38+0800, Haozhong Zhang: > This patch moves the field of TSC scaling ratio from the architecture > struct vcpu_svm to the common struct kvm_vcpu_arch. > > Signed-off-by: Haozhong Zhang > --- > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > @@

Re: [RFC PATCH 1/6] vfio: Add interface for add/del reserved iova region

On Mon, 2015-10-05 at 04:55 +, Bhushan Bharat wrote: > Hi Alex, > > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Saturday, October 03, 2015 4:16 AM > > To: Bhushan Bharat-R65777 > > Cc:

Re: [RFC PATCH 5/6] vfio-pci: Create iommu mapping for msi interrupt

On Mon, 2015-10-05 at 07:20 +, Bhushan Bharat wrote: > > > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Saturday, October 03, 2015 4:17 AM > > To: Bhushan Bharat-R65777 > > Cc:

Re: [RFC PATCH 3/6] vfio: Extend iommu-info to return MSIs automap state

On Mon, 2015-10-05 at 06:00 +, Bhushan Bharat wrote: > > -1138,6 +1156,8 @@ > > > static long vfio_iommu_type1_ioctl(void *iommu_data, > > > } > > > } else if (cmd == VFIO_IOMMU_GET_INFO) { > > > struct vfio_iommu_type1_info info; > > > + struct

Re: [RFC PATCH 4/6] vfio: Add interface to iommu-map/unmap MSI pages

On Mon, 2015-10-05 at 06:27 +, Bhushan Bharat wrote: > > > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Saturday, October 03, 2015 4:16 AM > > To: Bhushan Bharat-R65777 > > Cc:

Re: [RFC PATCH 6/6] arm-smmu: Allow to set iommu mapping for MSI

On Mon, 2015-10-05 at 08:33 +, Bhushan Bharat wrote: > > > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Saturday, October 03, 2015 4:17 AM > > To: Bhushan Bharat-R65777 > > Cc:

[PATCH v2 0/2] KVM/arm64: add fp/simd lazy switch support

This patch series is a followup to the armv7 fp/simd lazy switch implementation, uses similar approach and depends on the series - https://lists.cs.columbia.edu/pipermail/kvmarm/2015-September/016567.html Patches are based on 4.3-rc2 commit 1f93e4a96c91093 Patches are based on earlier arm64

[PATCH v2 1/2] add hooks for armv8 fp/simd lazy switch

This patch adds hooks to support fp/simd lazy switch. A vcpu flag to track fp/simd state, and flag offset in vcpu structure. Signed-off-by: Mario Smarduch --- arch/arm64/include/asm/kvm_host.h | 3 +++ arch/arm64/kernel/asm-offsets.c | 1 + 2 files changed, 4

[PATCH v2 2/2] enable armv8 fp/simd lazy switch

This patch enables arm64 lazy fp/simd switch. Removes the ARM constraint, and follows the same approach as armv7 version - found here. https://lists.cs.columbia.edu/pipermail/kvmarm/2015-September/016567.html To summarize - provided the guest accesses fp/simd unit we limit number of fp/simd

Re: [PATCH 04/12] KVM: x86: Replace call-back set_tsc_khz() with a common function

On Mon, Oct 05, 2015 at 09:53:26PM +0200, Radim Krčmář wrote: > 2015-09-28 13:38+0800, Haozhong Zhang: > > Both VMX and SVM propagate virtual_tsc_khz in the same way, so this > > patch removes the call-back set_tsc_khz() and replaces it with a common > > function. > > > > Signed-off-by: Haozhong

Re: [PATCH 09/15] arm64: Add page size to the kernel image header

On 5 October 2015 at 14:02, Suzuki K. Poulose wrote: > On 02/10/15 16:49, Catalin Marinas wrote: >> >> On Tue, Sep 15, 2015 at 04:41:18PM +0100, Suzuki K. Poulose wrote: >>> >>> From: Ard Biesheuvel >>> >>> This patch adds the page size to the

Re: [PATCH 09/15] arm64: Add page size to the kernel image header

On 02/10/15 16:49, Catalin Marinas wrote: On Tue, Sep 15, 2015 at 04:41:18PM +0100, Suzuki K. Poulose wrote: From: Ard Biesheuvel This patch adds the page size to the arm64 kernel image header so that one can infer the PAGESIZE used by the kernel. This will be

Re: [RFT - PATCH v2 0/2] KVM/arm64: add fp/simd lazy switch support

Hi Christoffer, I just managed to boot qemu arm32 up on arm64 (last Fri - thanks for the tip - there were few other issue to clean up), so let me retest it again. Also I noticed some refactoring would help both 32 and 64 bit patches. Yes I could provide a the user space tests as well. Thanks-

Re: [PATCH] Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS

On Mon, Oct 05, 2015 at 12:54:43PM -0400, Bandan Das wrote: > Joerg Roedel writes: > The problems is that the next_rip field could be stale. If the processor > supports > next_rip, then it will clear it out on the next entry. If it doesn't, > an old value just sits there (no

Re: [RFT - PATCH v2 0/2] KVM/arm64: add fp/simd lazy switch support

On Mon, Oct 05, 2015 at 09:14:57AM -0700, Mario Smarduch wrote: > Hi Christoffer, >I just managed to boot qemu arm32 up on arm64 (last Fri - thanks for the > tip > - there were few other issue to clean up), so let me retest it again. Also I > noticed some refactoring would help both 32 and 64

Re: [PATCH] Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS

Joerg Roedel writes: > On Thu, Oct 01, 2015 at 06:31:27PM -0400, Bandan Das wrote: >> Paolo Bonzini writes: >> >> > On 01/10/2015 13:43, Dirk Müller wrote: >> >> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c >> >> index 94b7d15..0a42859 100644 >> >>

Re: [RFT - PATCH v2 0/2] KVM/arm64: add fp/simd lazy switch support

On Tue, Sep 22, 2015 at 04:34:01PM -0700, Mario Smarduch wrote: > This is a 2nd itteration for arm64, v1 patches were posted by mistake from an > older branch which included several bugs. Hopefully didn't waste too much of > anyones time. > > This patch series is a followup to the armv7 fp/simd

Re: [PATCH 09/15] arm64: Add page size to the kernel image header

On Fri, Oct 02, 2015 at 05:50:38PM +0100, Marc Zyngier wrote: > On 02/10/15 17:31, Catalin Marinas wrote: > > On Fri, Oct 02, 2015 at 04:49:01PM +0100, Catalin Marinas wrote: > >> On Tue, Sep 15, 2015 at 04:41:18PM +0100, Suzuki K. Poulose wrote: > >>> From: Ard Biesheuvel