[PATCH] KVM: x86: MMU: Use clear_page() instead of init_shadow_page_table()

Not just in order to clean up the code, but to make it faster by using enhanced instructions: the initialization became 20-30% faster on our testing machine. Signed-off-by: Takuya Yoshikawa --- arch/x86/kvm/mmu.c | 10 +- 1 file changed, 1

Re: [PATCH v7 19/19] KVM: ARM64: Add a new kvm ARM PMU device

On Thu, Dec 17, 2015 at 03:22:50PM +0800, Shannon Zhao wrote: > > > On 2015/12/17 4:33, Christoffer Dall wrote: > > On Wed, Dec 16, 2015 at 04:06:49PM +0800, Shannon Zhao wrote: > >> Hi, > >> > >> On 2015/12/16 15:31, Shannon Zhao wrote: > > But in this case, you're returning an error if

RE: [RFC PATCH 3/3] vfio-pci: Allow to mmap MSI-X table if EEH is supported

From: Alex Williamson > Sent: 17 December 2015 21:07 ... > > Is this all related to the statements in the PCI(e) spec that the > > MSI-X table and Pending bit array should in their own BARs? > > (ISTR it even suggests a BAR each.) > > > > Since the MSI-X table exists in device memory/registers

Re: [RFC PATCH 2/3] vfio-pci: Allow to mmap sub-page MMIO BARs if all MMIO BARs are page aligned

On 2015/12/18 5:46, Alex Williamson wrote: On Thu, 2015-12-17 at 18:26 +0800, yongji xie wrote: On 2015/12/17 4:04, Alex Williamson wrote: On Fri, 2015-12-11 at 16:53 +0800, Yongji Xie wrote: Current vfio-pci implementation disallows to mmap sub-page(size < PAGE_SIZE) MMIO BARs because

Re: [PATCH kvm-unit-tests v2 01/12] run_tests: move run() to scripts/

2015-12-17 12:45-0600, Andrew Jones: > On Thu, Dec 17, 2015 at 06:53:32PM +0100, Radim Krčmář wrote: >> We'll be using it from scripts/mkstandalone later. >> >> Signed-off-by: Radim Krčmář >> --- >> v2: new >> >> run_tests.sh | 53

[PATCH v4 2/7] mips/kvm: Implement PRid CP0 register

Implement saving and restoring to KVM state of the Processor ID (PRid) CP0 register. This allows QEMU to control the PRid exposed to the guest instead of using the default set by KVM. Signed-off-by: James Hogan Reviewed-by: Leon Alrae Cc: Paolo

[PATCH v4 6/7] mips/kvm: Support FPU in MIPS KVM guests

Support the new KVM_CAP_MIPS_FPU capability, which allows the host's FPU to be exposed to the KVM guest. The capability is enabled if the guest core has an FPU according to its Config1 register. Various config bits are now writeable so that KVM is aware of the configuration (Config1.FP) and so

[PATCH v4 7/7] mips/kvm: Support MSA in MIPS KVM guests

Support the new KVM_CAP_MIPS_MSA capability, which allows MIPS SIMD Architecture (MSA) to be exposed to the KVM guest. The capability is enabled if the guest core has MSA according to its Config3 register. Various config bits are now writeable so that KVM is aware of the configuration

[PATCH v4 5/7] mips/kvm: Support signed 64-bit KVM registers

Rename kvm_mips_{get,put}_one_reg64() to kvm_mips_{get,put}_one_ureg64() since they take an int64_t pointer, and add separate signed 64-bit accessors. These will be used for double precision floating point registers. Signed-off-by: James Hogan Cc: Paolo Bonzini

[PATCH v4 0/7] mips/kvm: Support FPU & SIMD (MSA) in MIPS KVM guests

Here's a v4 refresh of my FPU/MSA patchset for v2.6. Thanks to all who have taken the time to review it so far. This patchset primarily adds support for FPU and MIPS SIMD Architecture (MSA) in MIPS KVM guests to QEMU. It depends on Linux v4.1, specifically my KVM patchset to add the corresponding

[PATCH v4 4/7] mips/kvm: Support unsigned KVM registers

Add KVM register access functions for the uint32_t type. This is required for FP and MSA control registers, which are represented as unsigned 32-bit integers. Signed-off-by: James Hogan Cc: Paolo Bonzini Cc: Leon Alrae Cc:

[PATCH v4 1/7] mips/kvm: Remove a couple of noisy DPRINTFs

The DPRINTFs in cpu_mips_io_interrupts_pending() and kvm_arch_pre_run() are particularly noisy during normal execution, and also not particularly helpful. Remove them so that more important debug messages can be more easily seen. Signed-off-by: James Hogan Reviewed-by:

[PATCH v4 3/7] mips/kvm: Implement Config CP0 registers

Implement saving and restoring to KVM state of the Config CP0 registers (namely Config, Config1, Config2, Config3, Config4, and Config5). These control the features available to a guest, and a few of the fields will soon be writeable by a guest so QEMU needs to know about them so as not to clobber

Re: [PATCH kvm-unit-tests v2 02/12] run_tests: prepare for changes in scripts/mkstandalone

2015-12-17 12:53-0600, Andrew Jones: > On Thu, Dec 17, 2015 at 06:53:33PM +0100, Radim Krčmář wrote: >> mkstandalone has a different mechanism for running tests as well as a >> different handling of output and return codes. >> - create two shell function to capture test execution and logging >>

Re: [PATCH kvm-unit-tests v2 03/12] scripts/mkstandalone: use common run function

2015-12-17 13:09-0600, Andrew Jones: > On Thu, Dec 17, 2015 at 06:53:34PM +0100, Radim Krčmář wrote: >> The biggest change is dependency on bash. An alternative would be to >> rewrite `run` in POSIX shell, but I think it's ok to presume that KVM >> unit tests will run on a system where installing

Re: [PATCH kvm-unit-tests v2 05/12] lib/report: allow test skipping

2015-12-17 13:37-0600, Andrew Jones: > On Thu, Dec 17, 2015 at 01:30:23PM -0600, Andrew Jones wrote: >> On Thu, Dec 17, 2015 at 06:53:36PM +0100, Radim Krčmář wrote: >> > We can now explicitly mark a unit-test as skipped. >> > If all unit-tests were skipped, the whole test is reported as skipped

Re: [PATCH v6] arm/arm64: KVM: Detect vGIC presence at runtime

On Tue, Dec 01, 2015 at 02:11:44PM +0300, Pavel Fedin wrote: > Before commit 662d9715840aef44dcb573b0f9fab9e8319c868a > ("arm/arm64: KVM: Kill CONFIG_KVM_ARM_{VGIC,TIMER}") is was possible to > compile the kernel without vGIC and vTimer support. Commit message says > about possibility to detect

RE: [PATCH v6] arm/arm64: KVM: Detect vGIC presence at runtime

Hello! > > This patch does not touch any virtual timer code, suggesting that timer > > hardware is actually in place. Normally on boards in question it is true, > > however since vGIC is missing, it is impossible to correctly utilize > > interrupts from the virtual timer. Since virtual timer

Re: [PATCH kvm-unit-tests v2 10/12] run_tests: print summary

2015-12-17 13:55-0600, Andrew Jones: > On Thu, Dec 17, 2015 at 06:53:41PM +0100, Radim Krčmář wrote: >> Might be interesting and hopefully won't break too many scripts. >> >> Signed-off-by: Radim Krčmář >> --- >> v2: >> - don't print "0 unexpected failures" in run_tests'

Re: [PATCH kvm-unit-tests v2 10/12] run_tests: print summary

2015-12-17 14:06-0600, Andrew Jones: > On Thu, Dec 17, 2015 at 06:53:41PM +0100, Radim Krčmář wrote: >> Might be interesting and hopefully won't break too many scripts. >> >> Signed-off-by: Radim Krčmář >> --- >> v2: >> - don't print "0 unexpected failures" in run_tests'

Re: [PATCH kvm-unit-tests v2 09/12] x86/hyperv_synic: check for support before testing

2015-12-17 13:42-0600, Andrew Jones: > On Thu, Dec 17, 2015 at 06:53:40PM +0100, Radim Krčmář wrote: >> It's not easy to distinguish successful unit-test from failed QEMU, so >> we check for presence of the needed feature before hand. >> >> Signed-off-by: Radim Krčmář >> ---

Re: [PATCH v7] arm/arm64: KVM: Detect vGIC presence at runtime

On Fri, 18 Dec 2015 14:38:43 +0300 Pavel Fedin wrote: > Before commit 662d9715840aef44dcb573b0f9fab9e8319c868a > ("arm/arm64: KVM: Kill CONFIG_KVM_ARM_{VGIC,TIMER}") is was possible to > compile the kernel without vGIC and vTimer support. Commit message says > about

Re: [PATCH kvm-unit-tests v2 00/12] Improve the output of test runners

2015-12-17 14:04-0600, Andrew Jones: > On Thu, Dec 17, 2015 at 06:53:31PM +0100, Radim Krčmář wrote: >> v1: http://www.spinics.net/lists/kvm/msg125202.html >> >> Drew brought up the existence of scripts/mkstandalone.sh, which >> significantly expanded v2 (and my set of curses) ... >> I didn't

[PATCH] KVM: arm/arm64: vgic-new: Try to insert multi-source SGIs at once

Improve handling of multi-source SGIs: instead of only inserting one source per SGI per run, try to insert them all at once. Hopefully this is a rare case. Signed-off-by: Marc Zyngier --- virt/kvm/arm/vgic/vgic.c | 30 ++ 1 file changed, 26

[PULL] KVM/ARM fixes for v4.4-rc6

Hi Paolo, We have a one line fix for the VGIC this time around, fixing a patch that went in -rc2. Oh well. Hopefully this is the last one for v4.4. Please pull! Thanks, M. The following changes since commit 0de58f852875a0f0dcfb120bb8433e4e73c7803b: ARM/arm64: KVM: correct PTE

Re: [PATCH v5 1/3] KVM/arm: add hooks for armv7 fp/simd lazy switch support

On Sun, Dec 06, 2015 at 05:07:12PM -0800, Mario Smarduch wrote: > This patch adds vcpu fields to configure hcptr trap register which is also > used > to determine if fp/simd registers are dirty. Adds a field to save host FPEXC, > and offsets associated offsets. offsets offsets? > >

Review & Reply

Greetings, My name is Mr.Michael J. Tynan, I am a banker with Bank Of America. It is true that we have not meet each other in person, but I strongly believe in trust and friendship in every business. I have a Lebanese deceased customer's abandoned fund, which I am his personal financial adviser

Review & Reply

Greetings, My name is Mr.Michael J. Tynan, I am a banker with Bank Of America. It is true that we have not meet each other in person, but I strongly believe in trust and friendship in every business. I have a Lebanese deceased customer's abandoned fund, which I am his personal financial adviser

Re: [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

On 12/18/2015 06:19 PM, Pavel Fedin wrote: Hello! I realize that it's perhaps too late, because patches are already on Linux-next, but i have one concern... May be it's not too late... I dislike implementing architecture-dependent exit code where we could implement an

Re: [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

On 18/12/2015 16:19, Pavel Fedin wrote: > As far as i understand this code, KVM_EXIT_HYPERV is called when one > of three MSRs are accessed. But, shouldn't we have implemented > instead something more generic, like KVM_EXIT_REG_IO, which would > work similar to KVM_EXIT_PIO or KVM_EXIT_MMIO,

Re: [PATCH v5 3/3] KVM/arm/arm64: enable enhanced armv8 fp/simd lazy switch

On Sun, Dec 06, 2015 at 05:07:14PM -0800, Mario Smarduch wrote: > This patch tracks armv7 and armv8 fp/simd hardware state with cptr_el2 > register. > On vcpu_load for 32 bit guests enable FP access, and enable fp/simd > trapping for 32 and 64 bit guests. On first fp/simd access trap to handler

Re: [PATCH v5 2/3] KVM/arm/arm64: enable enhanced armv7 fp/simd lazy switch

On Sun, Dec 06, 2015 at 05:07:13PM -0800, Mario Smarduch wrote: > This patch tracks armv7 fp/simd hardware state with hcptr register. > On vcpu_load saves host fpexc, enables FP access, and sets trapping > on fp/simd access. On first fp/simd access trap to handler to save host and > restore guest

RE: [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

Hello! I realize that it's perhaps too late, because patches are already on Linux-next, but i have one concern... May be it's not too late... I dislike implementing architecture-dependent exit code where we could implement an architecture-independent one. As far as i understand this code,

Re: [PULL] KVM/ARM fixes for v4.4-rc6

Idiot alert, sending the wrong patch... On 18/12/15 13:00, Marc Zyngier wrote: > Hi Paolo, > > We have a one line fix for the VGIC this time around, fixing a patch > that went in -rc2. Oh well. Hopefully this is the last one for v4.4. > > Please pull! Or don't, actually. Sorry about the

Re: [PATCH] KVM: x86: MMU: Use clear_page() instead of init_shadow_page_table()

On 18/12/2015 10:54, Takuya Yoshikawa wrote: > Not just in order to clean up the code, but to make it faster by using > enhanced instructions: the initialization became 20-30% faster on our > testing machine. > > Signed-off-by: Takuya Yoshikawa Applied

Re: [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

On Fri, Dec 18, 2015 at 8:01 AM, Paolo Bonzini wrote: > > > On 18/12/2015 16:19, Pavel Fedin wrote: >> As far as i understand this code, KVM_EXIT_HYPERV is called when one >> of three MSRs are accessed. But, shouldn't we have implemented >> instead something more generic,

Re: [PULL take #2] KVM/ARM fixes for v4.4-rc6

On 18/12/2015 15:05, Marc Zyngier wrote: > Hi Paolo, > > We have a one line fix for the VGIC this time around, fixing a patch > that went in -rc2. Oh well. Hopefully this is the last one for v4.4. > And yes, the right patch is following the pull-request this time... > > Please pull! Pulled,

Re: [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

On Fri, Dec 18, 2015 at 06:19:25PM +0300, Pavel Fedin wrote: > I dislike implementing architecture-dependent exit code where we could > implement an architecture-independent one. > > As far as i understand this code, KVM_EXIT_HYPERV is called when one of > three MSRs are accessed. But,

Re: [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

On Fri, Dec 18, 2015 at 05:01:59PM +0100, Paolo Bonzini wrote: > On 18/12/2015 16:19, Pavel Fedin wrote: > > As far as i understand this code, KVM_EXIT_HYPERV is called when one > > of three MSRs are accessed. But, shouldn't we have implemented > > instead something more generic, like

Re: [PATCH kvm-unit-tests v2 05/12] lib/report: allow test skipping

On Fri, Dec 18, 2015 at 12:18:19PM +0100, Radim Krčmář wrote: > 2015-12-17 13:37-0600, Andrew Jones: > > On Thu, Dec 17, 2015 at 01:30:23PM -0600, Andrew Jones wrote: > >> On Thu, Dec 17, 2015 at 06:53:36PM +0100, Radim Krčmář wrote: > >> > We can now explicitly mark a unit-test as skipped. > >> >

Re: kvmclock doesn't work, help?

[cc: John Stultz -- maybe you have ideas on how this should best integrate with the core code] On Fri, Dec 18, 2015 at 11:45 AM, Marcelo Tosatti wrote: > On Fri, Dec 18, 2015 at 11:27:13AM -0800, Andy Lutomirski wrote: >> On Fri, Dec 18, 2015 at 3:47 AM, Marcelo Tosatti

Re: kvmclock doesn't work, help?

On Fri, Dec 18, 2015 at 11:27:13AM -0800, Andy Lutomirski wrote: > On Fri, Dec 18, 2015 at 3:47 AM, Marcelo Tosatti wrote: > > On Thu, Dec 17, 2015 at 05:12:59PM -0800, Andy Lutomirski wrote: > >> On Thu, Dec 17, 2015 at 11:08 AM, Marcelo Tosatti > >>

Re: [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

On Fri, Dec 18, 2015 at 10:10:11AM -0800, Peter Hornyack wrote: > On Fri, Dec 18, 2015 at 8:01 AM, Paolo Bonzini wrote: > > On 18/12/2015 16:19, Pavel Fedin wrote: > >> As far as i understand this code, KVM_EXIT_HYPERV is called when one > >> of three MSRs are accessed. But,

Re: [PATCH kvm-unit-tests v2 00/12] Improve the output of test runners

On Fri, Dec 18, 2015 at 01:38:31PM +0100, Radim Krčmář wrote: > 2015-12-17 14:04-0600, Andrew Jones: > > On Thu, Dec 17, 2015 at 06:53:31PM +0100, Radim Krčmář wrote: > >> v1: http://www.spinics.net/lists/kvm/msg125202.html > >> > >> Drew brought up the existence of scripts/mkstandalone.sh, which

Re: kvmclock doesn't work, help?

On Fri, Dec 18, 2015 at 3:47 AM, Marcelo Tosatti wrote: > On Thu, Dec 17, 2015 at 05:12:59PM -0800, Andy Lutomirski wrote: >> On Thu, Dec 17, 2015 at 11:08 AM, Marcelo Tosatti >> wrote: >> > On Thu, Dec 17, 2015 at 08:33:17AM -0800, Andy Lutomirski

Re: kvmclock doesn't work, help?

On Thu, Dec 17, 2015 at 05:12:59PM -0800, Andy Lutomirski wrote: > On Thu, Dec 17, 2015 at 11:08 AM, Marcelo Tosatti wrote: > > On Thu, Dec 17, 2015 at 08:33:17AM -0800, Andy Lutomirski wrote: > >> On Wed, Dec 16, 2015 at 1:57 PM, Marcelo Tosatti > >>

Re: [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

On 18/12/2015 19:10, Peter Hornyack wrote: > On brief inspection of Andrey's patch (I have not been following > closely) it looks like the kvm_hyperv_exit struct that's returned to > userspace contains more data (control, evt_page, and msg_page fields) > than simply the value of the MSR, so

Re: [PATCH kvm-unit-tests v2 01/12] run_tests: move run() to scripts/

On Fri, Dec 18, 2015 at 11:42:40AM +0100, Radim Krčmář wrote: > 2015-12-17 12:45-0600, Andrew Jones: > > On Thu, Dec 17, 2015 at 06:53:32PM +0100, Radim Krčmář wrote: > >> We'll be using it from scripts/mkstandalone later. > >> > >> Signed-off-by: Radim Krčmář > >> --- > >>

Re: [RFC PATCH 2/5] KVM: add KVM_EXIT_MSR exit reason and capability.

On Fri, Dec 18, 2015 at 1:25 PM, Paolo Bonzini wrote: > > > On 18/08/2015 20:46, Peter Hornyack wrote: >> Define KVM_EXIT_MSR, a new exit reason for accesses to MSRs that kvm >> does not handle. Define KVM_CAP_UNHANDLED_MSR_EXITS, a vm-wide >> capability that guards the new

Re: [PATCH v5 2/3] KVM/arm/arm64: enable enhanced armv7 fp/simd lazy switch

On 12/18/2015 5:49 AM, Christoffer Dall wrote: > On Sun, Dec 06, 2015 at 05:07:13PM -0800, Mario Smarduch wrote: >> This patch tracks armv7 fp/simd hardware state with hcptr register. >> On vcpu_load saves host fpexc, enables FP access, and sets trapping >> on fp/simd access. On first fp/simd

Re: [PATCH v5 3/3] KVM/arm/arm64: enable enhanced armv8 fp/simd lazy switch

On 12/18/2015 5:54 AM, Christoffer Dall wrote: > On Sun, Dec 06, 2015 at 05:07:14PM -0800, Mario Smarduch wrote: >> This patch tracks armv7 and armv8 fp/simd hardware state with cptr_el2 >> register. >> On vcpu_load for 32 bit guests enable FP access, and enable fp/simd >> trapping for 32 and 64

Re: kvmclock doesn't work, help?

On Fri, Dec 18, 2015 at 12:25 PM, Andy Lutomirski wrote: > [cc: John Stultz -- maybe you have ideas on how this should best > integrate with the core code] > > On Fri, Dec 18, 2015 at 11:45 AM, Marcelo Tosatti wrote: >> On Fri, Dec 18, 2015 at 11:27:13AM

RE: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

Hi Kevin & Paolo, Luckily, I reproduced this problem last night. And I got the below log when SeaBIOS is stuck. [BTW, the whole SeaBIOS log attached] [2015-12-18 10:38:10] >gonglei: enter smp_setup()... [2015-12-18 10:38:10] >gonglei: begine to enable local APIC... [2015-12-18

[PATCH] KVM: arm/arm64: vgic: Fix kvm_vgic_map_is_active's dist check

From: Christoffer Dall External inputs to the vgic from time to time need to poke into the state of a virtual interrupt, the prime example is the architected timer code. Since the IRQ's active state can be represented in two places; the LR or the distributor, we

[PULL take #2] KVM/ARM fixes for v4.4-rc6

Hi Paolo, We have a one line fix for the VGIC this time around, fixing a patch that went in -rc2. Oh well. Hopefully this is the last one for v4.4. And yes, the right patch is following the pull-request this time... Please pull! Thanks, M. The following changes since commit

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

On Fri, Dec 18, 2015 at 03:04:58AM +, Gonglei (Arei) wrote: > Hi Kevin & Paolo, > > Luckily, I reproduced this problem last night. And I got the below log when > SeaBIOS is stuck. [...] > [2015-12-18 10:38:10] gonglei: finish while [...] > <...>-31509 [035] 154753.180077: kvm_exit:

Re: [RFC PATCH 2/5] KVM: add KVM_EXIT_MSR exit reason and capability.

On 18/08/2015 20:46, Peter Hornyack wrote: > Define KVM_EXIT_MSR, a new exit reason for accesses to MSRs that kvm > does not handle. Define KVM_CAP_UNHANDLED_MSR_EXITS, a vm-wide > capability that guards the new exit reason and which can be enabled via > the KVM_ENABLE_CAP ioctl. > >

Re: [PATCH v5 1/3] KVM/arm: add hooks for armv7 fp/simd lazy switch support

On 12/18/2015 5:07 AM, Christoffer Dall wrote: > On Sun, Dec 06, 2015 at 05:07:12PM -0800, Mario Smarduch wrote: >> This patch adds vcpu fields to configure hcptr trap register which is also >> used >> to determine if fp/simd registers are dirty. Adds a field to save host >> FPEXC, >> and

Re: [PATCH v5 3/3] KVM/arm/arm64: enable enhanced armv8 fp/simd lazy switch

On Fri, Dec 18, 2015 at 05:17:00PM -0800, Mario Smarduch wrote: > On 12/18/2015 5:54 AM, Christoffer Dall wrote: > > On Sun, Dec 06, 2015 at 05:07:14PM -0800, Mario Smarduch wrote: > >> This patch tracks armv7 and armv8 fp/simd hardware state with cptr_el2 > >> register. > >> On vcpu_load for 32

RE: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

> > From: Kevin O'Connor [mailto:ke...@koconnor.net] > Sent: Saturday, December 19, 2015 7:13 AM > To: Gonglei (Arei) > Cc: Xulei (Stone); Paolo Bonzini; qemu-devel; seab...@seabios.org; > Huangweidong (C); kvm@vger.kernel.org > Subject: Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure