parameters.
This is mainly meant to bypass Python's refusal to pickle instance methods.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_subprocess.py | 60 +++
1 files changed, 53 insertions(+), 7 deletions(-)
diff --git a/client/tests/kvm
How can we set the verbosity level for stand-alone execution, e.g.
enable/disable debug output when running ./kvm_config.py kvm_tests.cfg?
- Original Message -
From: Lucas Meneghel Rodrigues l...@redhat.com
To: autot...@test.kernel.org
Cc: kvm@vger.kernel.org, mgold...@redhat.com, Lucas
- Lucas Meneghel Rodrigues look...@gmail.com wrote:
On Sat, Aug 8, 2009 at 3:32 PM, Michael Goldishmgold...@redhat.com
wrote:
How can we set the verbosity level for stand-alone execution, e.g.
enable/disable debug output when running ./kvm_config.py
kvm_tests.cfg?
On the main
This patch set modifies the names and functionality of several config
parameters and adds new ones.
It also adds support for Netcat as a remote shell client.
It breaks compatibility with existing test configurations.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of
This is useful for Windows guests that will use the homemade remote shell
server.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_utils.py | 17 +
client/tests/kvm/kvm_vm.py|3 +++
2 files changed, 20 insertions(+), 0 deletions(-)
diff
- shutdown_command
cmd_reboot - reboot_command
Also, new parameters were added:
shell_client (ssh, telnet or nc)
file_transfer_client (currently only scp)
file_transfer_port
The parameter use_telnet was removed, as well as the function VM.ssh().
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client
If a user specified path is an absolute one, it is returned as is.
If it's relative, it's appended to a certain base path.
This function is meant to allow framework and test code to treat all user
specified paths equally.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm
filenames should begin with 'steps/'.
This patch modifies kvm_vm.py, kvm_preprocessing.py, kvm_guest_wizard.py,
stepmaker.py and and kvm_tests.cfg.sample.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_guest_wizard.py |2 +-
client/tests/kvm/kvm_preprocessing.py
-installed qemu and qemu-img that reside somewhere
outside the Autotest dir, e.g. in /usr/bin.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_preprocessing.py | 18 +++---
client/tests/kvm/kvm_tests.cfg.sample |2 ++
client/tests/kvm/kvm_vm.py
Use a much shorter and simpler is_alive() instead of the current one.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_subprocess.py | 25 +
1 files changed, 1 insertions(+), 24 deletions(-)
diff --git a/client/tests/kvm/kvm_subprocess.py
b
This patch set adds the source code of rss.exe as well as a batch file that
prepares Windows guests for remote access (using rss.exe).
It adds 3 files under deps/ dir: rss.cpp, setuprss.bat and rss.reg.
The latter is required for Windows 2000 which seems to lack the reg command.
This set also
This server provides clients with an interactive cmd.exe shell.
It uses no encryption or authentication.
Usage: rss.exe [port]
The default port is 22.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/deps/rss.cpp | 467 +
1 files
to executable]
e.g.: setuptrss.bat D:\rss.exe
If used without parameters, rss.exe will be copied from the directory in which
setuprss.bat resides.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/deps/rss.reg | 15 +++
client/tests/kvm/deps/setuprss.bat | 19
-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/steps/Win2000-32-rss.steps | 52 +
client/tests/kvm/steps/Win2003-32-rss.steps | 49 +++
client/tests/kvm/steps/Win2003-64-rss.steps | 47 ++
client/tests/kvm
Warn, instead of failing, when receiving an invalid PPM screendump.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_guest_wizard.py | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/client/tests/kvm/kvm_guest_wizard.py
b/client/tests
The version variable is used even though it is no longer defined. This patch
fixes this.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/stepmaker.py |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/client/tests/kvm/stepmaker.py b/client/tests
If the session is closed immediately after a command is sent, the command may
not be executed.
To overcome this, first wait for the guest to shut down, and then close
the session.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_tests.py | 18 ++
1
. Currently WinVista.32, WinVista.64, Win2008.64, Win2003.64 and WinXP.64 can
run only the install test. This patch makes them run all available tests,
like the other Windows guests.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_tests.cfg.sample | 70
Add a sample autoit script under autoit/.
The script is a modified version of the notepad1.au3 example script that ships
with AutoIt.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/autoit/notepad1.au3 | 44 ++
1 files changed, 44
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_tests.cfg.sample | 12 +++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/client/tests/kvm/kvm_tests.cfg.sample
b/client/tests/kvm/kvm_tests.cfg.sample
index 12e907b..05a1ca7 100644
parameters to send to the script.
autoit_script_timeout: The time duration (in seconds) to wait for the script to
exit.
The test code can be extended later to add more features.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm.py |1 +
client/tests/kvm
This is the AutoIt patch set with some minor corrections:
- Use read_up_to_prompt() instead of read_nonblocking() before running the
AutoIt command
- autoit_script_params defaults to in the test code as well
- Indentation fix in notepad1.au3
--
To unsubscribe from this list: send the line
Add a sample autoit script under autoit/.
The script is a modified version of the notepad1.au3 example script that ships
with AutoIt.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/autoit/notepad1.au3 | 44 ++
1 files changed, 44
parameters to send to the script.
autoit_script_timeout: The time duration (in seconds) to wait for the script to
exit.
The test code can be extended later to add more features.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm.py |1 +
client/tests/kvm
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_tests.cfg.sample | 12 +++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/client/tests/kvm/kvm_tests.cfg.sample
b/client/tests/kvm/kvm_tests.cfg.sample
index 12e907b..05a1ca7 100644
explicitly.
This patch also makes the postprocessor call the function for all VMs.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_preprocessing.py |4
client/tests/kvm/kvm_subprocess.py| 12
client/tests/kvm/kvm_vm.py|8
3
Require that shell prompts start at the beginning of the line (^) and be
followed by nothing more than whitespace (\s*$).
Also remove the length limitation from Windows prompts, and do not restrict
them to C:\.
Also do not require RHEL and Fedora prompts to contain 'root@'.
Signed-off-by: Michael
- Yolkfull Chow yz...@redhat.com wrote:
On Tue, Aug 11, 2009 at 03:10:42PM +0300, Michael Goldish wrote:
Currently the test only logs in, runs a given script and fails if
the script
takes too long to exit or if its exit status is nonzero.
The test expects these parameters
that IP
addresses be taken from the dynamic cache.
To force the system to obtain IP addresses from the dynamic cache
even when
static base addresses are provided by the user, specify
'always_use_tcpdump = yes'.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm
- look...@gmail.com wrote:
Reviewers: lmr,
Message:
Michael, the patchset looks mostly good to me, congrats!
I have a few comments to make. I believe it's enough to make you send
me
a full
updated set with 9 patches:
1,2,3,4,5,8,9,11,12. 3 of them were already applied.
After
- Chen Cao k...@redhat.com wrote:
On Tue, Aug 11, 2009 at 03:10:44PM +0300, Michael Goldish wrote:
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_tests.cfg.sample | 12 +++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git
- Avi Kivity a...@redhat.com wrote:
This is faster since we don't need to fork/exec/wait for an external
program each time.
Signed-off-by: Avi Kivity a...@redhat.com
---
client/tests/kvm/kvm_guest_wizard.py |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff
-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_utils.py | 106 +
1 files changed, 106 insertions(+), 0 deletions(-)
diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py
index e897e78..4891592 100644
--- a/client/tests
. 'script_dir' should normally be the directory 'scripts' under the
main KVM test directory.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_preprocessing.py |8 ++-
client/tests/kvm/kvm_tests.cfg.sample |6 ++
client/tests/kvm/kvm_vm.py| 95
be done inside 'qemu-ifup' as well, but this sample script
doesn't do it.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/scripts/qemu-ifup |8
1 files changed, 8 insertions(+), 0 deletions(-)
create mode 100755 client/tests/kvm/scripts/qemu-ifup
diff --git
, use 'default_host'.
- While we're at it, add a comment informing the user where to modify the test
configration, if that is desirable
- (Also add a missing space somewhere in the control file, and remove a few
extra ones)
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm
').
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_cdkeys.cfg.sample | 16
client/tests/kvm/kvm_tests.cfg.sample | 10 +++---
2 files changed, 19 insertions(+), 7 deletions(-)
create mode 100644 client/tests/kvm/kvm_cdkeys.cfg.sample
diff --git
Instead of failing, just print a warning. Included files may not always be
crucial for tests to run (kvm_cdkeys.cfg for example).
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_config.py | 21 +++--
1 files changed, 11 insertions(+), 10 deletions
parameters.
This is mainly meant to bypass Python's refusal to pickle instance methods.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_subprocess.py | 60 +++
1 files changed, 53 insertions(+), 7 deletions(-)
diff --git a/client/tests/kvm
Run tcpdump in the background at all times and listen for DHCP communication.
Whenever a DHCP server assigns an IP address to a MAC address, cache it for
future reference.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_preprocessing.py | 41
format_str_for_message() sometimes adds an extra newline. Fix that.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_utils.py |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py
command 'ps aux' with 'uname -a'. The silly reason for this
is that DSL-4.2.5 doesn't like 'ps aux'. Since 'uname -a' is just as good
(AFAIK), use it instead.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_tests.cfg.sample |7 ++-
client/tests/kvm/kvm_tests.py
are provided by the user, specify
'always_use_tcpdump = yes'.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_address_pools.cfg.sample |8 +++
client/tests/kvm/kvm_preprocessing.py |3 +-
client/tests/kvm/kvm_utils.py | 37
filenames should begin with 'steps/'.
This patch modifies kvm_vm.py, kvm_preprocessing.py, kvm_guest_wizard.py,
stepmaker.py and and kvm_tests.cfg.sample.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_guest_wizard.py |2 +-
client/tests/kvm/kvm_preprocessing.py
- Jason Wang jasow...@redhat.com wrote:
On Tue, Aug 11, 2009 at 1:16 PM, Michael
Goldishmgold...@redhat.com wrote:
- Jason Wang jasow...@redhat.com wrote:
Hello Michael:
Based on our experiences with TAP networking scripts, the
verify_mac_ip_pair() could not work
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
Ok, very good, similarly to the previous patchset, I rebased one of
the patches and applied the set, I am making tests with an rss binary
generated by the cross compiler.
I am testing with Winxp 32 bit, so far so good and rss.exe works
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
On Tue, Aug 18, 2009 at 7:15 AM, Michael Goldishmgold...@redhat.com
wrote:
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
Ok, very good, similarly to the previous patchset, I rebased one
of
the patches and applied the set,
- yogi anant...@linux.vnet.ibm.com wrote:
Hello everyone,
I like to submit patch to add support for remote migration in
kvm-autotest.
Sounds like a good idea.
Also, the patch isn't too big, which I personally appreciate very much (makes
it easier to read).
To use this patch the
- supriya kannery supri...@in.ibm.com wrote:
Uri Lublin wrote:
supriya kannery wrote:
A patch for iterating over VM reboot
I think adding iterations capability belongs to the infrastructure,
not the test itself. Implement it once in the infrastructure,
instead
of once per
Thanks for the new patch. I'll comment on it later because I want to take some
more time to review it.
The login prompt problem is my fault -- please see my comment below.
- yogi anant...@linux.vnet.ibm.com wrote:
Hello everyone,
I like to resubmit patch to add support for remote
- Mike Burns mbu...@redhat.com wrote:
Eduardo Habkost wrote:
Hi,
Excerpts from Michael Burns's message of Fri May 08 15:55:30 -0300
2009:
--- a/client/tests/kvm_runtest_2/kvm_install.py
+++ b/client/tests/kvm_runtest_2/kvm_install.py
@@ -77,6 +77,17 @@ def
- Eduardo Habkost ehabk...@redhat.com wrote:
On Mon, May 11, 2009 at 01:36:26PM -0400, Michael Goldish wrote:
- Mike Burns mbu...@redhat.com wrote:
Eduardo Habkost wrote:
snip
Maybe something like (untested):
for k in params.keys():
os.putenv
The patches look good, but I haven't tested them yet to make sure
they leave everything at a functional state (will test them and let
you know).
I have a somewhat related question: how is KVM-Autotest development
going to proceed after the upstream merge? Currently I have
comfortable access to
- sudhir kumar smalik...@gmail.com wrote:
Hi Uri/Lucas,
Do you have any plans for enhancing kvm-autotest?
I was looking mainly on the following 2 aspects:
(1).
we have standalone migration only. Is there any plans of enhancing
kvm-autotest so that we can trigger migration while a
- Lucas Meneghel Rodrigues mrodr...@redhat.com wrote:
On Wed, 2009-05-13 at 12:23 -0400, Michael Goldish wrote:
The patches look good, but I haven't tested them yet to make sure
they leave everything at a functional state (will test them and let
you know).
Thanks Michael! I
- jason wang jasow...@redhat.com wrote:
sudhir kumar 写道:
Hi Uri/Lucas,
Do you have any plans for enhancing kvm-autotest?
I was looking mainly on the following 2 aspects:
(1).
we have standalone migration only. Is there any plans of enhancing
kvm-autotest so that we can
Hi Jason,
We already have patches that implement similar functionality here in
TLV, as mentioned in the to-do list (item #4 under 'Framework').
They're not yet committed upstream because they're still quite fresh.
Still, your patch looks good and is quite similar to mine. The main
difference is
- sudhir kumar smalik...@gmail.com wrote:
On Thu, May 14, 2009 at 12:22 PM, jason wang jasow...@redhat.com
wrote:
sudhir kumar 写道:
Hi Uri/Lucas,
Do you have any plans for enhancing kvm-autotest?
I was looking mainly on the following 2 aspects:
(1).
we have standalone
- sudhir kumar smalik...@gmail.com wrote:
On Wed, May 13, 2009 at 11:30 PM, Michael Goldish
mgold...@redhat.com wrote:
- sudhir kumar smalik...@gmail.com wrote:
Hi Uri/Lucas,
Do you have any plans for enhancing kvm-autotest?
I was looking mainly on the following 2 aspects
Hi all,
We've recently implemented a very simple form of parallel test execution into
KVM-Autotest and we'd like some feedback on it. This suggestion allows the user
to manually assign tests to hosts/queues. It also takes care of assigning
different MAC address ranges to hosts/queues. By
Hi Lucas,
Since I consider you our Autotest reference I direct the following question to
you.
Currently our Autotest servers run tests in client mode using the same control
file on all hosts. We want to move on to dispatching tests from the server,
using a server control file, so that each
- Mike Burns mbu...@redhat.com wrote:
Avi Kivity wrote:
Michael Goldish wrote:
Drawbacks:
- requires some initial work to be done by the user -- the user
has
to define exactly where each test should run
For me, this is a major drawback. I'd really like a
fire-and-forget
- Mike Burns mbu...@redhat.com wrote:
See comments and example in control file for details.
Signed-off-by: Mike Burns mbu...@redhat.com
---
client/tests/kvm_runtest_2/control|6 ++
client/tests/kvm_runtest_2/kvm_install.py |7 +++
2 files changed, 13
Looks good to me. See some comments below.
- David Huff dh...@redhat.com wrote:
This patch will run pre and post scripts
defined in config file with the parameter pre_command
and post_command post_command.
Also exports all the prameters in preprocess for passing
arguments to the
Fix the first barrier to include the 'boot:' prompt. This is crucial because
the guest accepts keyboard input only after this prompt appears.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
.../tests/kvm_runtest_2/steps/RHEL-4.7-i386.steps |2 +-
.../kvm_runtest_2/steps/RHEL-4.7
Fix the initial boot barriers to include the 'boot:' prompt.
Also fix a barrier in 5.3 of a dialog that sometimes appears at an unexpected
location.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
.../tests/kvm_runtest_2/steps/RHEL-5.3-i386.steps | 12 ++--
.../kvm_runtest_2
Signed-off-by: Michael Goldish mgold...@redhat.com
---
.../kvm_runtest_2/steps/WinXP-32-setupssh.steps| 10 --
client/tests/kvm_runtest_2/steps/WinXP-32.steps|4 +++-
client/tests/kvm_runtest_2/steps/WinXP-64.steps|3 +--
3 files changed, 12 insertions(+), 5
-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm_runtest_2/stepeditor.py | 59 ++
1 files changed, 28 insertions(+), 31 deletions(-)
diff --git a/client/tests/kvm_runtest_2/stepeditor.py
b/client/tests/kvm_runtest_2/stepeditor.py
index de9a2b1
kvm_vm.py: add function VM.get_name().
kvm_preprocessing.py: use VM.get_name() instead of directly accessing the .name
attribute.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm_runtest_2/kvm_preprocessing.py |6 +++---
client/tests/kvm_runtest_2/kvm_vm.py
This will reduce the number of monitor files left in /tmp, because the
constructor is called fewer times than VM.create().
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm_runtest_2/kvm_vm.py | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff
Also, don't do it in kvm_preprocessing.py since it's now done in kvm_vm.py.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm_runtest_2/kvm_preprocessing.py |1 -
client/tests/kvm_runtest_2/kvm_vm.py|2 ++
2 files changed, 2 insertions(+), 1 deletions
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm_runtest_2/kvm_vm.py | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/client/tests/kvm_runtest_2/kvm_vm.py
b/client/tests/kvm_runtest_2/kvm_vm.py
index af06693..9571a3b 100644
VM.create() does a few things (such as finding free ports) which are not safe
to execute in parallel. Use a lock file to make sure this doesn't happen. The
lock is released only after the VM is started or fails to start.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests
1. Make the 'login:' regular expression stricter so it doesn't match
'Last login: ...' messages.
2. Make the 'password:' regular expression stricter.
3. Handle 'Connection refused' messages.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm_runtest_2/kvm_utils.py | 13
Do not use hardcoded environment filename 'env'. Instead use the value
specified by the 'env' parameter. If unspecified, use 'env' as the filename.
This is important for parallel execution; it may be necessary to use a separate
environment file for each process.
Signed-off-by: Michael Goldish
If x11_display is specified, the DISPLAY environment variable is set to this
value for the QEMU process. This may be useful for SDL rendering.
Also add some comments.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm_runtest_2/kvm_vm.py | 12 +++-
1 files changed
once per test
(such a class will be introduced in a future patch).
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm_runtest_2/kvm_runtest_2.py | 29 --
1 files changed, 22 insertions(+), 7 deletions(-)
diff --git a/client/tests/kvm_runtest_2
and 30 will probably work
well enough.
On Sun, May 24, 2009 at 9:16 PM, Michael Goldish mgold...@redhat.com
wrote:
1. Make the 'login:' regular expression stricter so it doesn't
match
'Last login: ...' messages.
2. Make the 'password:' regular expression stricter.
3. Handle 'Connection
- sudhir kumar smalik...@gmail.com wrote:
On Sun, May 24, 2009 at 9:16 PM, Michael Goldish mgold...@redhat.com
wrote:
VM.create() does a few things (such as finding free ports) which are
not safe
to execute in parallel. Use a lock file to make sure this doesn't
happen. The
lock
not absolutely sure we'll have Windows 7 step files. It
depends on how well unattended installations will work, and how important it
will be to simulate user interaction with Windows 7.
On Sun, May 24, 2009 at 9:16 PM, Michael Goldish mgold...@redhat.com
wrote:
Signed-off-by: Michael Goldish mgold
(assuming it gets some testing to make sure it doesn't
break anything).
On Tue, May 5, 2009 at 1:12 AM, Michael Goldish mgold...@redhat.com
wrote:
Thanks for the new patch. I'll comment on it later because I want to
take some more time to review it.
The login prompt problem is my fault -- please
- Avi Kivity a...@redhat.com wrote:
Michael Goldish wrote:
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm_runtest_2/kvm_vm.py | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/client/tests/kvm_runtest_2/kvm_vm.py
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
On Sun, 2009-05-24 at 18:46 +0300, Michael Goldish wrote:
kvm_vm.py: add function VM.get_name().
kvm_preprocessing.py: use VM.get_name() instead of directly
accessing the .name
attribute.
Are there any advantages of creating
Regardless of whether the idea should be implemented, I think the code
can be simplified a bit, to look something like this:
type = params.get(type)
routine_obj = self.test_routines.get(type)
if routine_obj:
module_name = routine_obj.module_name
routine_name = routine_obj.routine_name
else:
- Avi Kivity a...@redhat.com wrote:
David Huff wrote:
This patch will run pre and post scripts
defined in config file with the parameter pre_command
and post_command post_command.
Also exports all the prameters in preprocess for passing
arguments to the script.
+
- Uri Lublin u...@redhat.com wrote:
On 05/10/2009 08:15 PM, sudhir kumar wrote:
Hi Uri,
Any comments?
-- Forwarded message --
From: sudhir kumarsmalik...@gmail.com
The kvm-autotest shows the following PASS results for migration,
while the VM was crashed and
- Avi Kivity a...@redhat.com wrote:
Michael Goldish wrote:
- Avi Kivity a...@redhat.com wrote:
David Huff wrote:
This patch will run pre and post scripts
defined in config file with the parameter pre_command
and post_command post_command.
Also exports all
- Avi Kivity a...@redhat.com wrote:
Michael Goldish wrote:
- What if we're interested in the status for some reason? Its
value
may indicate what went wrong with the child process.
Put it in the exception string.
But I want its value
- Avi Kivity a...@redhat.com wrote:
Michael Goldish wrote:
I think it's very rare to want to let the test continue even if
some
command fails.
Can you give examples?
Some commands are not critical, like one that converts the
screendumps
from PPM to PNG format. We
it.
- Original Message -
From: sudhir kumar smalik...@gmail.com
To: kvm-devel kvm@vger.kernel.org
Cc: Uri Lublin u...@redhat.com, Michael Goldish mgold...@redhat.com,
David Huff dh...@redhat.com, Lucas Meneghel Rodrigues
mrodr...@redhat.com, Ryan Harper ry...@us.ibm.com
Sent: Saturday, June 6
1. It would also be nice to add a '#!/usr/bin/python' line at the beginning of
the file, so I can make the file executable and run it without the 'python'
prefix.
2. I think you missed the exception raised in parse_file().
3. Wouldn't it be a good idea to define our own ConfigError exception
1. Inside parentheses there is no need to fix anything. e.g. the following code
is fine:
logging.info(Copying %s.tar.bz2 to guest (file is missing or has a
different size)... % test_name)
and also looks cleaner than the new version with the backslash and weird
format_str_for_message() is meant to be appended to the end of a string, with
no spaces or newlines immediately preceding it -- its job is to add spaces or
newlines as necessary.
So instead of:
logging.debug(Timeout elapsed or process terminated. Output: %s,
Small correction to 1: '#!/usr/bin/env python' instead of '#!/usr/bin/python'.
I'm not really sure what's better, but we used the one with 'env' before the
merge. We still use it in stepeditor.
Also CCing Autotest.
- Original Message -
From: Michael Goldish mgold...@redhat.com
with Autotest):
- For kvm_vm.py, kvm_utils.py, kvm_tests.py:
Uri Lublin (u...@redhat.com)
Dror Russo (dru...@redhat.com)
Michael Goldish (mgold...@redhat.com)
- For make_html_report.py:
Dror Russo (dru...@redhat.com)
(may already be there)
- For scan_results.py, calc_md5sum_1m.py, fix_cdkeys.py:
Uri Lublin
Looks good to me -- thanks.
- Original Message -
From: Yolkfull Chow yz...@redhat.com
To: kvm@vger.kernel.org
Cc: sudhir kumar smalik...@gmail.com, yogi anant...@linux.vnet.ibm.com,
Uri Lublin u...@redhat.com, kvm@vger.kernel.org
Sent: Tuesday, May 26, 2009 5:35:35 AM (GMT+0200)
Hi Lucas,
Before the merge with Autotest we used kvm_log.py to log formatted messages.
Each message contained the current test's 'shortname' (e.g.
Fedora.8.32.install), the current date and time (down to a 1 sec resolution)
and the message itself. In addition, debug messages contained the name
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
On Mon, 2009-06-08 at 11:15 -0700, Martin Bligh wrote:
if it's specific to one test or whatever, you could also just put
it inside the message?
No, because the test's 'shortname' contains both the test type and some
minimal information
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
On Mon, 2009-06-08 at 04:48 -0400, Michael Goldish wrote:
Hi Lucas,
I'm bothering you with technicalities again unfortunately:
1. I'm not sure if it's customary to add @author tags to other
modules except the main kvm.py one
The test looks pretty nicely written. Comments:
1. Consider making all the cloned VMs use image snapshots:
curr_vm = vm1.clone()
curr_vm.get_params()[extra_params] += -snapshot
I'm not sure it's a good idea to let all VMs use the same disk image.
Or maybe you shouldn't add -snapshot yourself,
501 - 600 of 630 matches
Mail list logo
