[RFC v9 11/27] virtio-blk: Indirect vring and flush support

2012-07-18 Thread Stefan Hajnoczi
does not support Linux AIO fdsync. Work around this by performing fdatasync() synchronously for now. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/dataplane/ioq.h | 18 - hw/dataplane/vring.h | 103 +++--- hw/virtio

[RFC v9 16/27] virtio-blk: Kick data plane thread using event notifier set

2012-07-18 Thread Stefan Hajnoczi
--- hw/virtio-blk.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 1616be5..d75c187 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -339,8 +339,7 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq)

[RFC v9 06/27] virtio-blk: Take PCI memory range into account

2012-07-18 Thread Stefan Hajnoczi
Support 4 GB physical memory accesses. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/virtio-blk.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index abd9386..99654f1 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -64,6

[RFC v9 15/27] notifier: Add a function to set the notifier

2012-07-18 Thread Stefan Hajnoczi
Although past users only needed to test and clear event notifiers, it is useful to be able to set them too. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- event_notifier.c |7 +++ event_notifier.h |1 + 2 files changed, 8 insertions(+) diff --git a/event_notifier.c b

[RFC v9 23/27] virtio-blk: Stub out SCSI commands

2012-07-18 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/virtio-blk.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 51807b5..8734029 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -215,14

[RFC v9 13/27] virtio-blk: Increase max requests for indirect vring

2012-07-18 Thread Stefan Hajnoczi
With indirect vring descriptors, one can no longer assume that the maximum number of requests is VRING_MAX / 2 (outhdr and inhdr). Now a single indirect descriptor can contain the outhdr and inhdr so max requests becomes VRING_MAX. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com

[RFC v9 20/27] virtio-blk: Add ioscheduler to detect mergable requests

2012-07-18 Thread Stefan Hajnoczi
--- hw/dataplane/iosched.h | 78 hw/virtio-blk.c|5 2 files changed, 83 insertions(+) create mode 100644 hw/dataplane/iosched.h diff --git a/hw/dataplane/iosched.h b/hw/dataplane/iosched.h new file mode 100644 index

[RFC v9 25/27] msix: fix irqchip breakage in msix_try_notify_from_thread()

2012-07-18 Thread Stefan Hajnoczi
is not defined. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/msix.c |2 -- 1 file changed, 2 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 3308604..0ed1013 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -511,12 +511,10 @@ bool msix_try_notify_from_thread(PCIDevice *dev

[RFC v9 27/27] virtio-blk: add EVENT_IDX support to dataplane

2012-07-18 Thread Stefan Hajnoczi
This patch adds support for the VIRTIO_RING_F_EVENT_IDX feature for interrupt mitigation. virtio-blk doesn't do anything fancy with it so we may not see a performance improvement. This patch will allow newer guest kernels to run successfully. Signed-off-by: Stefan Hajnoczi stefa

[RFC v9 24/27] virtio-blk: fix incorrect length

2012-07-18 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/virtio-blk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 8734029..cff2298 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -131,7 +131,7 @@ static void

[RFC v9 26/27] msix: use upstream kvm_irqchip_set_irq()

2012-07-18 Thread Stefan Hajnoczi
Commit 9507e305ec54062fccc88fcf6fccf1898a7e7141 changed the kvm_set_irq() function to kvm_irqchip_set_irq(). Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/msix.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/msix.c b/hw/msix.c index 0ed1013

[RFC v9 21/27] virtio-blk: Add basic request merging

2012-07-18 Thread Stefan Hajnoczi
This commit adds an I/O scheduler that sorts requests and merges adjacent requests if they have the same operation type (read/write). The code is ugly and not very well factored but it does merge successfully. --- hw/dataplane/ioq.h |3 +- hw/dataplane/iosched.h | 51

[RFC v9 22/27] virtio-blk: Fix request merging

2012-07-18 Thread Stefan Hajnoczi
Khoa Huynh k...@us.ibm.com discovered that request merging is broken. The merged iocb is not updated to reflect the total number of iovecs and the offset is also outdated. This patch fixes request merging. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/virtio-blk.c | 10

[RFC v9 19/27] virtio-blk: Disable guest-host notifies while processing vring

2012-07-18 Thread Stefan Hajnoczi
--- hw/dataplane/vring.h | 28 +++- hw/virtio-blk.c | 47 +++ 2 files changed, 58 insertions(+), 17 deletions(-) diff --git a/hw/dataplane/vring.h b/hw/dataplane/vring.h index 44ef4a9..cdd4d4a 100644 ---

[RFC v9 18/27] virtio-blk: Call ioctl() directly instead of irqfd

2012-07-18 Thread Stefan Hajnoczi
Optimize for the MSI-X enabled and vector unmasked case where it is possible to issue the KVM ioctl() directly instead of using irqfd. This patch introduces a new virtio binding function which tries to notify in a thread-safe way. If this is not possible, the function returns false. Virtio

[RFC v9 10/27] virtio-blk: Stop data plane thread cleanly

2012-07-18 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/dataplane/event-poll.h | 79 --- hw/dataplane/ioq.h| 65 +-- hw/dataplane/vring.h |6 +- hw/virtio-blk.c | 154 +++-- 4

[RFC v9 14/27] virtio-blk: Use pthreads instead of qemu-thread

2012-07-18 Thread Stefan Hajnoczi
Using qemu-thread.h seemed like a nice idea but it has two limitations: 1. QEMU needs to be built with --enable-io-thread 2. qemu-kvm doesn't build with --enable-io-thread For now just copy the pthread_create() code straight into virtio-blk.c. Signed-off-by: Stefan Hajnoczi stefa

Re: [PATCH 0/5] Add vhost-blk support

2012-07-17 Thread Stefan Hajnoczi
On Tue, Jul 17, 2012 at 10:21 AM, Asias He as...@redhat.com wrote: On 07/17/2012 04:52 PM, Paolo Bonzini wrote: Il 17/07/2012 10:29, Asias He ha scritto: So, vhost-blk at least saves ~6 syscalls for us in each request. Are they really 6? If I/O is coalesced by a factor of 3, for example

Re: [PATCH 0/5] Add vhost-blk support

2012-07-17 Thread Stefan Hajnoczi
On Tue, Jul 17, 2012 at 9:29 AM, Asias He as...@redhat.com wrote: On 07/16/2012 07:58 PM, Stefan Hajnoczi wrote: Does the vhost-blk implementation do anything fundamentally different from userspace? Where is the overhead that userspace virtio-blk has? Currently, no. But we could play

Re: [PATCH 0/5] Add vhost-blk support

2012-07-17 Thread Stefan Hajnoczi
On Tue, Jul 17, 2012 at 12:26 PM, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jul 17, 2012 at 12:11:15PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 17, 2012 at 10:21 AM, Asias He as...@redhat.com wrote: On 07/17/2012 04:52 PM, Paolo Bonzini wrote: Il 17/07/2012 10:29, Asias He ha

Re: [PATCH 0/5] Add vhost-blk support

2012-07-17 Thread Stefan Hajnoczi
On Tue, Jul 17, 2012 at 12:42 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Jul 17, 2012 at 12:26 PM, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jul 17, 2012 at 12:11:15PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 17, 2012 at 10:21 AM, Asias He as...@redhat.com wrote: On 07/17

Re: How to get the real device in guest os after attached a disk?

2012-07-17 Thread Stefan Hajnoczi
On Tue, Jul 17, 2012 at 4:40 AM, Wangpan hzwang...@corp.netease.com wrote: I have a question as the subject above, the reason I want to know this is that, if I attach some disks on the guest, for example, I specified /dev/vdc/dev/vdd(target device) at the cmd line by using 'virsh

Re: [PATCH 0/5] Add vhost-blk support

2012-07-17 Thread Stefan Hajnoczi
On Tue, Jul 17, 2012 at 12:54 PM, Michael S. Tsirkin m...@redhat.com wrote: Knowing the answer to that is important before anyone can say whether this approach is good or not. Stefan Why is it? Because there might be a fix to kvmtool which closes the gap. It would be embarassing if

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-28 Thread Stefan Hajnoczi
On Wed, Jun 27, 2012 at 12:19 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Wed, Jun 27, 2012 at 08:41:49AM +0100, Stefan Hajnoczi wrote: On Wed, Jun 27, 2012 at 8:39 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Jun 26, 2012 at 8:34 PM, Marcelo Tosatti mtosa...@redhat.com wrote

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-27 Thread Stefan Hajnoczi
On Tue, Jun 26, 2012 at 8:34 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote: net.txt iothread flow = 1) Skip-work-if-device-locked select(tap fd ready) tap_send    if (trylock(TAPState-NetClientState-dev))

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-27 Thread Stefan Hajnoczi
On Wed, Jun 27, 2012 at 8:39 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Jun 26, 2012 at 8:34 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote: net.txt iothread flow = 1) Skip-work-if-device-locked

Re: Bug? 100% load on core after physically removing USB storage from host

2012-06-25 Thread Stefan Hajnoczi
On Sat, Jun 23, 2012 at 7:08 AM, Emmanuel Noobadmin centos.ad...@gmail.com wrote: On 6/22/12, Stefan Hajnoczi stefa...@gmail.com wrote: Thanks for investigating and sharing the information you've found. It's archived on the list so anyone who hits it in the future or wants to reproduce it can

Re: Bug? 100% load on core after physically removing USB storage from host

2012-06-22 Thread Stefan Hajnoczi
On Thu, Jun 21, 2012 at 2:49 PM, Emmanuel Noobadmin centos.ad...@gmail.com wrote: On 6/20/12, Stefan Hajnoczi stefa...@gmail.com wrote: Anyway, once you've tried qemu.git/master we'll know whether the bug still exists and with all the info you've shared maybe Gerd (USB maintainer) will know

Re: Bug? 100% load on core after physically removing USB storage from host

2012-06-20 Thread Stefan Hajnoczi
On Wed, Jun 20, 2012 at 10:40 AM, Emmanuel Noobadmin centos.ad...@gmail.com wrote: On 6/18/12, Stefan Hajnoczi stefa...@gmail.com wrote: I believe the call is coming from hw/usb/host-linux.c:async_complete() but am not using the same source tree as your qemu-kvm so I could be off.  The code

Re: [PATCH v2 0/3] Improve virtio-blk performance

2012-06-19 Thread Stefan Hajnoczi
On Tue, Jun 19, 2012 at 5:24 AM, Asias He as...@redhat.com wrote: On 06/18/2012 06:58 PM, Stefan Hajnoczi wrote: As long as the latency is decreasing that's good.  But It's worth keeping in mind that these percentages are probably wildly different on real storage devices and/or qemu-kvm

Re: Bug? 100% load on core after physically removing USB storage from host

2012-06-18 Thread Stefan Hajnoczi
On Sat, Jun 16, 2012 at 6:16 AM, Emmanuel Noobadmin centos.ad...@gmail.com wrote: On 6/13/12, Stefan Hajnoczi stefa...@gmail.com wrote: Since system time is a large chunk you could use strace -f -p $(pgrep qemu-kvm) or other system call tracing tools to see what the qemu-kvm process is doing

Re: [PATCH v2 0/3] Improve virtio-blk performance

2012-06-18 Thread Stefan Hajnoczi
On Mon, Jun 18, 2012 at 7:53 AM, Asias He as...@redhat.com wrote: Fio test shows it gives, 28%, 24%, 21%, 16% IOPS boost and 32%, 17%, 21%, 16% latency improvement for sequential read/write, random read/write respectively. Sounds great. What storage configuration did you use (single spinning

Re: [PATCH 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-06-18 Thread Stefan Hajnoczi
On Mon, Jun 18, 2012 at 7:53 AM, Asias He as...@redhat.com wrote: +static void virtblk_add_buf_wait(struct virtio_blk *vblk, +                                struct virtblk_req *vbr, +                                unsigned long out, +                                unsigned long in) +{ +  

Re: [PATCH 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-06-18 Thread Stefan Hajnoczi
On Mon, Jun 18, 2012 at 11:21 AM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Jun 18, 2012 at 02:53:10PM +0800, Asias He wrote: +static void virtblk_make_request(struct request_queue *q, struct bio *bio) +{ +     struct virtio_blk *vblk = q-queuedata; +     unsigned int num, out = 0, in

Re: [PATCH v2 0/3] Improve virtio-blk performance

2012-06-18 Thread Stefan Hajnoczi
On Mon, Jun 18, 2012 at 10:39 AM, Asias He as...@redhat.com wrote: On 06/18/2012 05:14 PM, Stefan Hajnoczi wrote: On Mon, Jun 18, 2012 at 7:53 AM, Asias He as...@redhat.com wrote: Fio test shows it gives, 28%, 24%, 21%, 16% IOPS boost and 32%, 17%, 21%, 16% latency improvement

Re: [Qemu-devel] [PATCH] trace: added ability to comment out events in the list

2012-06-15 Thread Stefan Hajnoczi
On Fri, Jun 15, 2012 at 5:36 AM, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 14/06/12 23:18, Stefan Hajnoczi wrote: On Thu, Jun 14, 2012 at 02:41:40PM +1000, Alexey Kardashevskiy wrote: It is convenient for debug to be able to switch on/off some events easily. The only possibility now

Re: [Qemu-devel] [PATCH] trace: added ability to comment out events in the list

2012-06-14 Thread Stefan Hajnoczi
On Thu, Jun 14, 2012 at 02:41:40PM +1000, Alexey Kardashevskiy wrote: It is convenient for debug to be able to switch on/off some events easily. The only possibility now is to remove event name from the file completely and type it again when we want it back. The patch adds '#' symbol

Re: Bug? 100% load on core after physically removing USB storage from host

2012-06-13 Thread Stefan Hajnoczi
On Wed, Jun 13, 2012 at 8:23 AM, Emmanuel Noobadmin centos.ad...@gmail.com wrote: On 6/12/12, Stefan Hajnoczi stefa...@gmail.com wrote: Further tests done on the following set only qemu-kvm-0.12.1.2-2.209.el6_2.4.x86_64 on SLES 6, 2.6.32-220.7.1.el.x86_64  (Intel 82801JI ICH10) 1. VMM add

Re: Bug? 100% load on core after physically removing USB storage from host

2012-06-12 Thread Stefan Hajnoczi
On Tue, Jun 12, 2012 at 6:02 AM, Emmanuel Noobadmin centos.ad...@gmail.com wrote: After removing a USB flash drive using virtual machine manager, I notice that the core assigned to the VM guest goes up to 100% load. Within the guest itself, there is no significant activity. This also prompted

Re: Biweekly KVM Test report, kernel 51bfd299... qemu a1fce560...

2012-06-07 Thread Stefan Hajnoczi
On Wed, Jun 6, 2012 at 3:17 AM, Ren, Yongjie yongjie@intel.com wrote: -Original Message- From: Kevin Wolf [mailto:kw...@redhat.com] Sent: Monday, June 04, 2012 9:51 PM To: Ren, Yongjie Cc: Marcelo Tosatti; Avi Kivity; kvm@vger.kernel.org; Liu, RongrongX Subject: Re: Biweekly KVM

Re: [PATCH v3] virtio_blk: unlock vblk-lock during kick

2012-06-06 Thread Stefan Hajnoczi
On Mon, Jun 4, 2012 at 12:15 PM, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Jun 01, 2012 at 10:13:06AM +0100, Stefan Hajnoczi wrote: Other block drivers (cciss, rbd, nbd) use spin_unlock_irq() so I followed that. To me this seems wrong: blk_run_queue() uses spin_lock_irqsave() but we

Re: [PATCH v3] virtio_blk: unlock vblk-lock during kick

2012-06-06 Thread Stefan Hajnoczi
On Mon, Jun 4, 2012 at 12:11 PM, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Jun 01, 2012 at 10:13:06AM +0100, Stefan Hajnoczi wrote: diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 774c31d..d674977 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block

Re: [PATCH v2] virtio_blk: unlock vblk-lock during kick

2012-06-04 Thread Stefan Hajnoczi
On Mon, Jun 04, 2012 at 11:27:39AM +0930, Rusty Russell wrote: On Wed, 30 May 2012 15:39:05 +0200, Christian Borntraeger borntrae...@de.ibm.com wrote: On 30/05/12 15:19, Stefan Hajnoczi wrote: Holding the vblk-lock across kick causes poor scalability in SMP guests. If one CPU is doing

Re: [PATCH v2] virtio_blk: unlock vblk-lock during kick

2012-06-01 Thread Stefan Hajnoczi
On Fri, Jun 1, 2012 at 5:38 AM, Asias He as...@redhat.com wrote: On 05/30/2012 09:19 PM, Stefan Hajnoczi wrote: Could you use vblk-disk-queue-queue_lock to reference the lock so that this patch will work on top of this one:   virtio-blk: Use block layer provided spinlock Absolutely. I'll

[PATCH v3] virtio_blk: unlock vblk-lock during kick

2012-06-01 Thread Stefan Hajnoczi
group_reporting norandommap ioscheduler=noop thread bs=512 size=4MB direct=1 filename=/dev/vdb numjobs=256 ioengine=aio iodepth=64 loops=3 Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- Other block drivers (cciss, rbd, nbd) use spin_unlock_irq() so I followed that. To me this seems

[PATCH v2] virtio_blk: unlock vblk-lock during kick

2012-05-30 Thread Stefan Hajnoczi
- [global] exec_prerun=echo 3 /proc/sys/vm/drop_caches group_reporting norandommap ioscheduler=noop thread bs=512 size=4MB direct=1 filename=/dev/vdb numjobs=256 ioengine=aio iodepth=64 loops=3 Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- drivers

Re: [Bug 43311] New: Windows XP Guest crashes when doing recursive grep in a Clearcase environment

2012-05-29 Thread Stefan Hajnoczi
On Mon, May 28, 2012 at 4:18 PM, bugzilla-dae...@bugzilla.kernel.org wrote: When I am doing a recursive grep on my Clearcase view using a 3rd party program called Windows Grep. On every run, the VM would crash (windows kernel crash where the cause is reported as unknown by Microsoft) up

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-28 Thread Stefan Hajnoczi
On Fri, May 25, 2012 at 10:56:28AM -0300, Luiz Capitulino wrote: On Fri, 25 May 2012 15:47:28 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 25/05/2012 15:43, Luiz Capitulino ha scritto: Yeah, VDE probably includes something like an hub. But then we could drop even -net socket,

Re: UDP problem with virtio...

2012-05-28 Thread Stefan Hajnoczi
On Sat, May 26, 2012 at 11:23 AM, Erik Brakkee e...@brakkee.org wrote: I have done some more experiments and it does work when using a Centos 6.2 guest. Therefore, it is most likely a compatibility issues between the guest and host virtio implementation. I read somewhere there is some sort of

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Stefan Hajnoczi
On Thu, May 24, 2012 at 05:53:21PM -0300, Luiz Capitulino wrote: On Fri, 25 May 2012 01:59:06 +0800 zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com The patchset implements network hub stead of vlan. The main work was done by stefan, and i rebased it to latest

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Stefan Hajnoczi
On Fri, May 25, 2012 at 12:18 PM, Markus Armbruster arm...@redhat.com wrote: Stefan Hajnoczi stefa...@linux.vnet.ibm.com writes: On Thu, May 24, 2012 at 05:53:21PM -0300, Luiz Capitulino wrote: On Fri, 25 May 2012 01:59:06 +0800 zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu

Re: [PATCH v4 16/16] hub: add the support for hub own flow control

2012-05-25 Thread Stefan Hajnoczi
On Fri, May 25, 2012 at 06:52:14PM +0800, zwu.ker...@gmail.com wrote: @@ -59,16 +60,16 @@ static ssize_t net_hub_receive_iov(NetHub *hub, NetHubPort *source_port, const struct iovec *iov, int iovcnt) { NetHubPort *port; -ssize_t ret = 0; +

Re: [Qemu-devel] Adding an IPMI BMC device to KVM

2012-05-18 Thread Stefan Hajnoczi
On Mon, May 7, 2012 at 3:30 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 05/06/2012 09:39 AM, Avi Kivity wrote: On 05/06/2012 05:35 PM, Anthony Liguori wrote: So what's really the use case here?  Would an IPMI - libvirt bridge get you what you need?  I really think that's the best path

Re: writeback cache + h700 controller w/1gb nvcache, corruption on power loss

2012-04-17 Thread Stefan Hajnoczi
On Mon, Apr 16, 2012 at 9:51 AM, Ron Edison r...@idthq.com wrote: I would be very interested in how to ensure the guests are sending flushes. I'm unfamiliar with the example you gave, where is that configured? mount -o barrier=1 /dev/sda /mnt is a mount option for ext3 and ext4 file systems.

Re: writeback cache + h700 controller w/1gb nvcache, corruption on power loss

2012-04-16 Thread Stefan Hajnoczi
On Sun, Apr 15, 2012 at 5:16 AM, Ron Edison r...@idthq.com wrote: The server is a Dell R710 with an H700 controller with 1gb of nvcache. Writeback cache is enabled on the controller. There is a mix of linux and windows guests, some with qcow2 format vdisks and others with raw format vdisks.

Re: vhost-blk development

2012-04-12 Thread Stefan Hajnoczi
On Wed, Apr 11, 2012 at 5:52 PM, Michael Baysek mbay...@liquidweb.com wrote: I am purposefully not using O_DIRECT since most workloads will not be using it, although I did notice better performance when I did use it.  I did already identify the page cache as a hinderance as well. If you do not

Re: vhost-blk development

2012-04-11 Thread Stefan Hajnoczi
On Tue, Apr 10, 2012 at 6:25 PM, Michael Baysek mbay...@liquidweb.com wrote: Well, I'm trying to determine which I/O method currently has the very least performance overhead and gives the best performance for both reads and writes. I am doing my testing by putting the entire guest onto a

Re: source for virt io backend driver

2012-04-10 Thread Stefan Hajnoczi
On Tue, Apr 10, 2012 at 4:47 AM, Steven wangwangk...@gmail.com wrote: I found this post http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/89334 So the current block driver seems completely emulated by the qemu driver. That's right: qemu/hw/virtio-blk.c Stefan -- To unsubscribe from

Re: [PATCH 0/2] adding tracepoints to vhost

2012-04-10 Thread Stefan Hajnoczi
On Tue, Apr 10, 2012 at 3:58 AM, Jason Wang jasow...@redhat.com wrote: To help in vhost analyzing, the following series adding basic tracepoints to vhost. Operations of both virtqueues and vhost works were traced in current implementation, net code were untouched. A top-like satistics

Re: Question about emulation of KVM?

2012-04-10 Thread Stefan Hajnoczi
On Sat, Apr 7, 2012 at 6:18 AM, R 1989012...@gmail.com wrote:             I try to use the x86_emulate_instruction() function.             But it seems like that it fails to emulate some instruction.             My program gets stuck in somewhere. It keeps emulating one instructions.          

Re: vhost-blk development

2012-04-10 Thread Stefan Hajnoczi
On Mon, Apr 9, 2012 at 11:59 PM, Michael Baysek mbay...@liquidweb.com wrote: Hi all.  I'm interested in any developments on the vhost-blk in kernel accelerator for disk i/o. I had seen a patchset on LKML https://lkml.org/lkml/2011/7/28/175 but that is rather old.  Are there any newer

Re: [PATCH 0/2] adding tracepoints to vhost

2012-04-10 Thread Stefan Hajnoczi
On Tue, Apr 10, 2012 at 1:42 PM, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 10, 2012 at 12:40:50PM +0100, Stefan Hajnoczi wrote: On Tue, Apr 10, 2012 at 3:58 AM, Jason Wang jasow...@redhat.com wrote: To help in vhost analyzing, the following series adding basic tracepoints

Re: [PATCH] virtio_blk: Drop unused request tracking list

2012-04-02 Thread Stefan Hajnoczi
On Sat, Mar 31, 2012 at 11:22 AM, Asias He asias.he...@gmail.com wrote: Hi, Stefan On Fri, Mar 30, 2012 at 6:14 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Mar 30, 2012 at 4:24 AM, Asias He as...@redhat.com wrote: Benchmark shows small performance improvement on fusion io device

Re: [PATCH] virtio_blk: Drop unused request tracking list

2012-03-30 Thread Stefan Hajnoczi
. It's a bit scary that this unused list has an impact...I'm sure we have worse things elsewhere in the KVM storage code path. Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org

Re: [PATCH 2/2] block: disable I/O throttling on sync api

2012-03-27 Thread Stefan Hajnoczi
On Tue, Mar 27, 2012 at 6:56 AM, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com ---  block.c |    6 ++  1 files changed, 6 insertions(+), 0 deletions

Re: kvm io performance after kernel 3.2/3.3

2012-03-26 Thread Stefan Hajnoczi
On Fri, Mar 23, 2012 at 11:43 PM, Michael michael.auckl...@gmail.com wrote: I found after update my kernel from 3.0.25 to 3.2.12 or same with kernel 3.3 Disk performance inside VM reduced by 10x times!!! ( for both kvm 0.12.5 and qemu 1.0.1) It sounds like you are updating the host kernel.

Re: [PATCH kvm-unit-tests] emulator: test for MMX movq raising #MF if pending x87 exceptions exist

2012-03-26 Thread Stefan Hajnoczi
On Sun, Mar 25, 2012 at 2:52 PM, Avi Kivity a...@redhat.com wrote: Test that a pending #MF is raised correctly if encountered by the emulator (and that the host isn't trashed by an unexpected exception).  The approach here exploits the TLB and so will only work on more modern processors.

Re: vhost question

2012-03-25 Thread Stefan Hajnoczi
On Sun, Mar 25, 2012 at 1:29 PM, Steve Glass stevie.gl...@gmail.com wrote: On 22 March 2012 19:52, Stefan Hajnoczi stefa...@gmail.com wrote: Can you queue a tx-rx kick on the vhost work queue with vhost_work_queue()? Stefan I've been looking at this and trying to work out how to achieve

Re: vhost question

2012-03-22 Thread Stefan Hajnoczi
On Thu, Mar 22, 2012 at 1:48 AM, Steve Glass stevie.gl...@gmail.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Just some further information concerning my earlier question concerning vhost and virtio. I'm using virtio to implement an emulated mac80211 device in the guest. A

[PATCH] KVM: x86: emulate movdqa

2012-03-22 Thread Stefan Hajnoczi
code modified by another vcpu while the emulator is executing). Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- This is the patch I tested against the movdqa kvm-unit-test that I submitted. It still doesn't include #GP on unaligned memory. I'm not sure of the appropriate place

Re: [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-19 Thread Stefan Hajnoczi
On Fri, Mar 16, 2012 at 04:59:35PM +0800, Amos Kong wrote: On 14/03/12 19:46, Stefan Hajnoczi wrote: On Wed, Mar 14, 2012 at 10:46 AM, Avi Kivitya...@redhat.com wrote: On 03/14/2012 12:39 PM, Stefan Hajnoczi wrote: On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivitya...@redhat.com wrote: On 03/14

QEMU was not selected for Google Summer of Code this year

2012-03-16 Thread Stefan Hajnoczi
Sad news - QEMU was not accepted for Google Summer of Code 2012. Students can consider other organizations in the accepted organizations list here: http://www.google-melange.com/gsoc/accepted_orgs/google/gsoc2012 The list is currently not complete but should be finalized over the next few days

Re: [Qemu-devel] QEMU was not selected for Google Summer of Code this year

2012-03-16 Thread Stefan Hajnoczi
On Fri, Mar 16, 2012 at 7:44 PM, Natalia Portillo clau...@claunia.com wrote: Really sad news :( On 16/03/2012, at 19:29, Stefan Hajnoczi wrote: Sad news - QEMU was not accepted for Google Summer of Code 2012. Students can consider other organizations in the accepted organizations list here

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 12:30 AM, Amos Kong ak...@redhat.com wrote: - Original Message - On Tue, Mar 13, 2012 at 2:47 PM, Amos Kong ak...@redhat.com wrote: ... Hi, Stefan diff --git a/kvm-all.c b/kvm-all.c index 77eadf6..7157e78 100644 --- a/kvm-all.c +++ b/kvm-all.c @@

Re: [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity a...@redhat.com wrote: On 03/13/2012 12:42 PM, Amos Kong wrote: Boot up guest with 232 virtio-blk disk, qemu will abort for fail to allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), and check if available ioeventfd exists. If not,

Re: [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivity a...@redhat.com wrote: On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity a...@redhat.com wrote: On 03/13/2012 12:42 PM, Amos Kong wrote: Boot up guest with 232 virtio-blk disk, qemu will abort for fail

Re: [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-14 Thread Stefan Hajnoczi
On Wed, Mar 14, 2012 at 10:46 AM, Avi Kivity a...@redhat.com wrote: On 03/14/2012 12:39 PM, Stefan Hajnoczi wrote: On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivity a...@redhat.com wrote: On 03/14/2012 11:59 AM, Stefan Hajnoczi wrote: On Wed, Mar 14, 2012 at 9:22 AM, Avi Kivity a...@redhat.com

Re: [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-13 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 10:42 AM, Amos Kong ak...@redhat.com wrote: Boot up guest with 232 virtio-blk disk, qemu will abort for fail to allocate ioeventfd. This patchset changes kvm_has_many_ioeventfds(), and check if available ioeventfd exists. If not, virtio-pci will fallback to userspace,

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-13 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 11:51 AM, Amos Kong ak...@redhat.com wrote: On 13/03/12 19:23, Stefan Hajnoczi wrote: On Tue, Mar 13, 2012 at 10:42 AM, Amos Kongak...@redhat.com  wrote: Boot up guest with 232 virtio-blk disk, qemu will abort for fail to allocate ioeventfd. This patchset changes

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-13 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 2:47 PM, Amos Kong ak...@redhat.com wrote: - Original Message - On Tue, Mar 13, 2012 at 11:51 AM, Amos Kong ak...@redhat.com wrote: On 13/03/12 19:23, Stefan Hajnoczi wrote: On Tue, Mar 13, 2012 at 10:42 AM, Amos Kongak...@redhat.com  wrote: Boot up

Re: [PATCH] kvm: add flightrecorder script

2012-03-12 Thread Stefan Hajnoczi
On Mon, Mar 12, 2012 at 02:08:10PM +0200, Avi Kivity wrote: On 03/09/2012 04:13 PM, Stefan Hajnoczi wrote: The kvm kernel module includes a number of trace events which can be useful when debugging system behavior. Even on production systems these trace events can be used to observe guest

Re: building with today qemu-kvm git fail (vcard_emul_nss.c)

2012-03-09 Thread Stefan Hajnoczi
On Thu, Mar 8, 2012 at 3:27 PM, Alexandre DERUMIER aderum...@odiso.com wrote: Hi, i'm trying to build the last kvm git, ./configure --prefix=/usr --datadir=/usr/share/kvm --docdir=/usr/share/doc/pve-qemu-kvm --sysconfdir=/etc --disable-xen --enable-vnc-tls --enable-sdl --enable-uuid

Re: Virtio Block Device Queue Depth

2012-03-09 Thread Stefan Hajnoczi
On Thu, Mar 8, 2012 at 5:48 PM, George Bottas gbot...@juniper.net wrote: I have a question regarding changing the queue size that is set in virtio_blk_init(). The current value is 128, which results in setting the queue depth in the Windows guest device to 8. Does anyone know if changing

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-03-09 Thread Stefan Hajnoczi
On Thu, Mar 8, 2012 at 11:56 PM, Ross Becker ross.bec...@gmail.com wrote: I just joined in order to chime in here- I'm seeing the exact same thing as Reeted;  I've got a machine with a storage subsystem capable of 400k IOPs, and when I punch the storage up to VMs, each VM seems to top out at

[PATCH] kvm: add flightrecorder script

2012-03-09 Thread Stefan Hajnoczi
for development and to ensure that the guest is indeed running. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- scripts/kvm/kvm_flightrecorder | 126 1 files changed, 126 insertions(+), 0 deletions(-) create mode 100755 scripts/kvm

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-03-07 Thread Stefan Hajnoczi
On Tue, Mar 6, 2012 at 10:07 PM, Reeted ree...@shiftmail.org wrote: On 03/06/12 13:59, Stefan Hajnoczi wrote: On Mon, Mar 5, 2012 at 4:44 PM, Martin Mailandmar...@tuxadero.com  wrote: Am 05.03.2012 17:35, schrieb Stefan Hajnoczi: 1. Test on i7 Laptop with Cpu governor ondemand.  v0.14.1

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-03-07 Thread Stefan Hajnoczi
On Wed, Mar 7, 2012 at 2:21 PM, Reeted ree...@shiftmail.org wrote: On 03/07/12 09:04, Stefan Hajnoczi wrote: On Tue, Mar 6, 2012 at 10:07 PM, Reetedree...@shiftmail.org  wrote: On 03/06/12 13:59, Stefan Hajnoczi wrote: BTW, I'll take the opportunity to say that 15.8 or 20.3 k IOPS are very

Re: virtio-blk performance regression and qemu-kvm

2012-03-06 Thread Stefan Hajnoczi
On Mon, Mar 5, 2012 at 4:44 PM, Martin Mailand mar...@tuxadero.com wrote: Am 05.03.2012 17:35, schrieb Stefan Hajnoczi: 1. Test on i7 Laptop with Cpu governor ondemand.  v0.14.1  bw=63492KB/s iops=15873  bw=63221KB/s iops=15805  v1.0  bw=36696KB/s iops=9173  bw=37404KB/s iops

Re: virtio-blk performance regression and qemu-kvm

2012-03-05 Thread Stefan Hajnoczi
On Mon, Mar 5, 2012 at 4:13 PM, Martin Mailand mar...@tuxadero.com wrote: Am 10.02.2012 15:36, schrieb Dongsu Park: Recently I observed performance regression regarding virtio-blk, especially different IO bandwidths between qemu-kvm 0.14.1 and 1.0. So I want to share the benchmark results,

Re: virtio-blk performance regression and qemu-kvm

2012-02-29 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 5:15 PM, Martin Mailand mar...@tuxadero.com wrote: Hi Stefan, I was bisecting qemu-kvm.git. qemu-kvm.git regularly merges from qemu.git. The history of the qemu-kvm.git repository is not linear because of these periodic merges from the qemu.git tree. I think what

Re: virtio-blk performance regression and qemu-kvm

2012-02-29 Thread Stefan Hajnoczi
On Wed, Feb 29, 2012 at 1:12 PM, Martin Mailand mar...@tuxadero.com wrote: Hi Stefan, you are right, the performance for the commits 0b9b128530b and 4fefc55ab04d are both good. What is the best approach to stay in the qemu-kvm.git history? I didn't know the answer so I asked on #git on

Re: virtio-blk performance regression and qemu-kvm

2012-02-29 Thread Stefan Hajnoczi
On Wed, Feb 29, 2012 at 1:44 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Feb 29, 2012 at 1:12 PM, Martin Mailand mar...@tuxadero.com wrote: Hi Stefan, you are right, the performance for the commits 0b9b128530b and 4fefc55ab04d are both good. What is the best approach to stay

Re: [Qemu-devel] linux guests and ksm performance

2012-02-28 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 11:46 AM, Peter Lieven p...@dlh.net wrote: On 24.02.2012 08:23, Stefan Hajnoczi wrote: On Fri, Feb 24, 2012 at 6:53 AM, Stefan Hajnoczistefa...@gmail.com  wrote: On Fri, Feb 24, 2012 at 6:41 AM, Stefan Hajnoczistefa...@gmail.com  wrote: On Thu, Feb 23, 2012 at 7:08

Re: Hosts crashed

2012-02-28 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 11:50 AM, Germain Maurice gmaur...@linkfluence.net wrote: I don't know if someone has already seen my request… If you're not getting responses it could be because you are using Proxmox VE, so the kernel and qemu-kvm might have patches. Have you asked the Proxmox

Re: [Qemu-devel] KVM call agenda for Tuesday 28th

2012-02-28 Thread Stefan Hajnoczi
On Mon, Feb 27, 2012 at 10:06 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 02/27/2012 03:58 PM, Paolo Bonzini wrote: Il 27/02/2012 18:21, Eric Blake ha scritto: Please send in any agenda items you are interested in covering. Given all the threads on snapshot/mirror/migrate/reopen in

Re: [Qemu-devel] KVM call agenda for Tuesday 28th

2012-02-28 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 2:47 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 28/02/2012 15:39, Stefan Hajnoczi ha scritto: I'm not a fan of transactions or freeze/thaw (if used to atomically perform other commands). We should not export low-level block device operations so that external

Re: virtio-blk performance regression and qemu-kvm

2012-02-28 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 4:39 PM, Martin Mailand mar...@tuxadero.com wrote: I could reproduce it and I bisected it down to this commit. 12d4536f7d911b6d87a766ad7300482ea663cea2 is the first bad commit commit 12d4536f7d911b6d87a766ad7300482ea663cea2 Author: Anthony Liguori aligu...@us.ibm.com

Add GSoC project ideas to the wiki!

2012-02-24 Thread Stefan Hajnoczi
This is a reminder that QEMU will apply for Google Summer of Code 2012 and we need project ideas and mentors. Libvirt and kvm.ko projects are also welcome! http://wiki.qemu.org/Google_Summer_of_Code_2012 Please add yourself to the wiki now if you want to mentor a project this summer. I will

Re: [libvirt] Add GSoC project ideas to the wiki!

2012-02-24 Thread Stefan Hajnoczi
On Fri, Feb 24, 2012 at 10:38 AM, Michal Privoznik mpriv...@redhat.com wrote: On 24.02.2012 10:19, Stefan Hajnoczi wrote: Thank you for the opportunity. I was personally thinking about something libvirt-snmp related. Nowdays, it is difficult to add new elements to MIB, as some parts of code

Re: linux guests and ksm performance

2012-02-23 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieven p...@dlh.net wrote: However, in a virtual machine I have not observed the above slow down to that extend while the benefit of zero after free in a virtualisation environment is obvious: 1) zero pages can easily be merged by ksm or other

<    1   2   3   4   5   6   7   8   9   >