Re: Perf trace event parse errors for KVM events

On Fri, 2010-05-28 at 17:42 +0100, Stefan Hajnoczi wrote: I get parse errors when using Steven Rostedt's trace-cmd tool, too. Any ideas what is going on here? I can provide more info (e.g. trace files) if necessary. Does trace-cmd fail on the same tracepoints? Have you checkout the latest

Re: Perf trace event parse errors for KVM events

On Sat, 2010-05-29 at 14:50 +0300, Avi Kivity wrote: On 05/29/2010 12:45 AM, Steven Rostedt wrote: On Fri, 2010-05-28 at 17:42 +0100, Stefan Hajnoczi wrote: I get parse errors when using Steven Rostedt's trace-cmd tool, too. Any ideas what is going on here? I can provide more info

Re: Perf trace event parse errors for KVM events

On Sun, 2010-05-30 at 11:10 +0300, Avi Kivity wrote: On 05/29/2010 04:19 PM, Steven Rostedt wrote: The pretty printing from the kernel handles this fine. But there's pressure to pass the format to userspace in binary and have the tool parse it. Currently it uses the print fmt

Re: Perf trace event parse errors for KVM events

On Sun, 2010-05-30 at 17:07 +0300, Avi Kivity wrote: On 05/30/2010 05:03 PM, Steven Rostedt wrote: Right. The tools can fall back to %x/%s based on the structure descriptor if they can't parse the format string. trace-cmd has plugin support to override how to read the format

Re: Perf trace event parse errors for KVM events

On Tue, 2010-06-01 at 11:39 +0300, Avi Kivity wrote: On 05/30/2010 06:34 PM, Steven Rostedt wrote: Cool. May make sense to use simpler formatting in the kernel, and use trace-cmd plugins for the complicated cases. It does raise issues with ABIs. Can trace-cmd read plugins from /lib

Re: Perf trace event parse errors for KVM events

On Tue, 2010-06-01 at 15:39 +0300, Avi Kivity wrote: On 06/01/2010 02:59 PM, Steven Rostedt wrote: I meant that viewing would be slowed down. It's an important part of using ftrace! How long does the Python formatter take to process 100k or 1M events? I finally got around to testing

Re: Perf trace event parse errors for KVM events

On Sun, 2010-06-06 at 11:08 +0300, Avi Kivity wrote: Also, I kicked this off in kernelshark, and it made no difference that I can see. This is because kernelshark only evaluates the viewable area of the screen. Neat. Can it also search? Where can I find it? googles, finds, gawks

Re: kvmmmu tracing

On Mon, 2009-11-23 at 12:06 +0100, Johannes Berg wrote: Commit f691fe1da7e2715137d21ae5a80bec64db4625db is really broken wrt. the userspace interface for tracing because of the weird KVM_MMU_PAGE_PRINTK macro. Maybe we should have a unsafe for export flag for events, if they do strange

Re: [BUG] kvm crashes in 2.6.28-rc6-00007-ged31348

[ added Ingo too ] On Tue, 2008-12-02 at 19:46 +, Luis Henriques wrote: (I am CC'ing to Steven Rostedt since he might be interested on this) On Tue, Dec 02, 2008 at 07:09:14PM +, Luis Henriques wrote: I have some other information to had to my previous email. However, I do

Re: [BUG] kvm crashes in 2.6.28-rc6-00007-ged31348

On Tue, 2008-12-02 at 22:38 +0200, Avi Kivity wrote: Steven Rostedt wrote: The following must be available without recursion for the function tracer to work: local_irq_save/restore smp_processor_id preempt_enable/disable_notrace atomic_inc/dec In arch/x86/kvm/svm.c

Re: [BUG] kvm crashes in 2.6.28-rc6-00007-ged31348

On Tue, 2 Dec 2008, Luis Henriques wrote: Unfortunately, I have only my laptop (where the crash is occuring) and no serial port on it (I am not able to get any output from the console). Do you have any suggestion on how to collect information on the crash? I can try to configure Kdump

Re: [PATCH] expose kvmclock upper msr set.

On Thu, 2011-02-24 at 20:48 -0300, Glauber Costa wrote: On Thu, 2011-02-24 at 18:24 -0500, Steven Rostedt wrote: On Wed, Feb 23, 2011 at 12:44:14PM -0500, Glauber Costa wrote: We've been supporting kvmclock MSRs in the 0x4b564d00-0x4b564dff range for a while now, but we're not exposing

Re: [PATCH 07/15] ftrace: fix event alignment: kvm:kvm_hv_hypercall

Hi Avi, This patch set got lost in the shuffle, and I'm not looking to include it. On Wed, 2010-12-08 at 11:18 +0200, Avi Kivity wrote: On 12/07/2010 11:16 PM, David Sharp wrote: I don't understand this. Can you elaborate? What does 32-bit addressable mean? The ring buffer

Re: [PATCH 07/15] ftrace: fix event alignment: kvm:kvm_hv_hypercall

On Wed, 2011-03-09 at 10:50 +0200, Avi Kivity wrote: On 03/09/2011 01:55 AM, Steven Rostedt wrote: Hi Avi, This patch set got lost in the shuffle, and I'm not looking to include Nasty typo: s/not/now/ it. Anything I need to do? Yeah, give me your Acked-by ;) -- Steve

Re: [ANNOUNCE] Native Linux KVM tool

On Thu, Mar 31, 2011 at 08:30:56PM +0300, Pekka Enberg wrote: The goal of this tool is to provide a clean, from-scratch, lightweight KVM host tool implementation that can boot Linux guest images (just a hobby, won't be big and professional like QEMU) That line looks very familiar... I'm

Re: trace_printk() support in trace-cmd

On Mon, 2010-11-15 at 19:09 +0200, Avi Kivity wrote: trace-cmd doesn't like trace_printk(): ...-23775 [000] 26343.288803: kvm_emulate_insn: 0:f14e9: rep insb ...-23775 [000] 26343.288804: bprint: x86_emulate_insn : (NO FORMAT FOUND at a0131460) ...-23775 [000]

Re: trace_printk() support in trace-cmd

On Tue, 2010-11-16 at 11:19 +0200, Avi Kivity wrote: On 11/15/2010 08:33 PM, Steven Rostedt wrote: On Mon, 2010-11-15 at 19:31 +0200, Avi Kivity wrote: On 11/15/2010 07:11 PM, Steven Rostedt wrote: Which kernel are you using, and/or which trace-cmd? It works fine for me

Re: trace_printk() support in trace-cmd

On Tue, 2010-11-16 at 08:11 -0500, Steven Rostedt wrote: On Tue, 2010-11-16 at 11:19 +0200, Avi Kivity wrote: On 11/15/2010 08:33 PM, Steven Rostedt wrote: On Mon, 2010-11-15 at 19:31 +0200, Avi Kivity wrote: On 11/15/2010 07:11 PM, Steven Rostedt wrote: Which kernel are you

Re: trace_printk() support in trace-cmd

On Mon, 2010-11-15 at 19:09 +0200, Avi Kivity wrote: trace-cmd doesn't like trace_printk(): ...-23775 [000] 26343.288803: kvm_emulate_insn: 0:f14e9: rep insb ...-23775 [000] 26343.288804: bprint: x86_emulate_insn : (NO FORMAT FOUND at a0131460) ...-23775 [000]

Re: trace_printk() support in trace-cmd

On Tue, 2010-11-23 at 13:04 +0200, Avi Kivity wrote: On 11/16/2010 05:13 PM, Steven Rostedt wrote: BTW, what does /debug/tracing/printk_formats show? Empty. So you have real trace_printk's not bprintk's? That is, if the format is not a const, then we fall back to __trace_printk

Re: trace_printk() support in trace-cmd

On Tue, 2010-11-23 at 16:37 +0200, Avi Kivity wrote: On 11/23/2010 04:30 PM, Steven Rostedt wrote: On Tue, 2010-11-23 at 13:04 +0200, Avi Kivity wrote: On 11/16/2010 05:13 PM, Steven Rostedt wrote: BTW, what does /debug/tracing/printk_formats show? Empty. So you

Re: [PATCH trace-cmd 0/3] kvm plugin updates

On Tue, 2010-11-23 at 12:58 +0200, Avi Kivity wrote: Currently the kvm plugin only decodes vmx exit reasons; the first patch in this series adds support for the svm instruction set. Second patch fixes a typo. A couple of fields were added to the kvm_exit tracepoint; the third patch prints

Re: [PATCH] Don't spam trace report about missing fields

On Mon, 2010-11-29 at 18:20 +0200, Avi Kivity wrote: Instead of spamming the output with complaints about missing fields, simply return an error to the caller, which can print something out or do something more intelligent about them. Fixes kvm plugin tracing older kernels. Hmm, what about

Re: [PATCH trace-cmd] kvm: don't warn on new fields

On Mon, 2010-11-29 at 19:25 +0200, Avi Kivity wrote: The kvm plugin understands a few new fields; don't warn if they are missing, as expected on older kernels. Signed-off-by: Avi Kivity a...@redhat.com --- plugin_kvm.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)

Re: trace_printk() support in trace-cmd

On Sun, 2010-12-12 at 18:10 +0200, Avi Kivity wrote: On 11/23/2010 12:52 PM, Avi Kivity wrote: I see a trace_printk() commit in trace-cmd.git. Is that related? If not, I'll work on getting a small sample of the problem. Sample: http://people.redhat.com/akivity/trace.dat.bz2 You

Re: trace_printk() support in trace-cmd

On Mon, 2010-12-13 at 17:43 +0200, Avi Kivity wrote: What's your work flow? Do you load kvm modules after you start the trace, or are they always loaded? Loaded on boot. Via initramfs? Are the trace_printk's in the core kernel too, and not being printed? I don't have any

Re: ftrace/perf_event leak

On Wed, 2010-09-01 at 14:15 +0200, Frederic Weisbecker wrote: Thanks for fixing this. However, can we split this in two patches to ease the backport? The lack of a module_put() after perf_trace_init() failure is there for a while (the backport needs to start in 2.6.32). But the lack

Re: kernelshark plugins and ftrace array fields

On Thu, 2010-09-02 at 15:19 +0300, Avi Kivity wrote: I'd like to add enhance kvm_emulate_insn display in kernelshark to show the disassembly of the instruction being emulated. However, pevent_get_field_val() doesn't support arrays (the instruction is provided in a 15-byte array). Can

Re: kernelshark plugins and ftrace array fields

On Thu, 2010-09-02 at 17:34 +0300, Avi Kivity wrote: On 09/02/2010 05:25 PM, Steven Rostedt wrote: On Thu, 2010-09-02 at 15:19 +0300, Avi Kivity wrote: I'd like to add enhance kvm_emulate_insn display in kernelshark to show the disassembly of the instruction being emulated. However

Re: kernelshark plugins and ftrace array fields

On Thu, 2010-09-02 at 19:06 +0300, Avi Kivity wrote: On 09/02/2010 06:52 PM, Steven Rostedt wrote: plugin_kvm.c: kvm_emulate_insn_handler() { fetch insn array and len field feed into disassembler trace_seq_printf() the disassembled instruction } I don't have

Re: kernelshark plugins and ftrace array fields

On Thu, 2010-09-02 at 17:34 +0300, Avi Kivity wrote: On 09/02/2010 05:25 PM, Steven Rostedt wrote: On Thu, 2010-09-02 at 15:19 +0300, Avi Kivity wrote: I'd like to add enhance kvm_emulate_insn display in kernelshark to show the disassembly of the instruction being emulated. However

Re: kernelshark plugins and ftrace array fields

On Thu, 2010-09-02 at 14:16 -0400, Steven Rostedt wrote: On Thu, 2010-09-02 at 17:34 +0300, Avi Kivity wrote: OK, with no modification of what I have already, I just created this handler: static int kvm_emulate_insn_handler(struct trace_seq *s, struct record *record

Re: kernelshark plugins and ftrace array fields

On Thu, 2010-09-02 at 14:38 -0400, Steven Rostedt wrote: I think I will add a: void *pevent_get_field_raw(stuct trace_seq *s, struct event_format *event, char *field_name, struct record *record, int

Re: [PATCH trace-cmd] plugin_kvm: disassemble instructions for kvm_emulate_insn

On Mon, 2010-09-20 at 11:51 +0200, Avi Kivity wrote: On 09/19/2010 04:33 PM, Avi Kivity wrote: Override kvm_emulate_insn formatting to use a disassembler to format the emulated instruction. If a disassembler (udis86) is not available, fall back to showing the instruction bytes in hex.

Re: [PATCH trace-cmd] plugin_kvm: disassemble instructions for kvm_emulate_insn

On Sun, 2010-09-19 at 16:33 +0200, Avi Kivity wrote: Override kvm_emulate_insn formatting to use a disassembler to format the emulated instruction. If a disassembler (udis86) is not available, fall back to showing the instruction bytes in hex. Signed-off-by: Avi Kivity a...@redhat.com ---

Re: [PATCH] plugin_kvm: fix kvm_exit rip formatting

On Mon, 2010-10-11 at 10:58 +0200, Avi Kivity wrote: %0xlx is not a valid printf format. Signed-off-by: Avi Kivity a...@redhat.com Applied, thanks! -- Steve --- plugin_kvm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugin_kvm.c b/plugin_kvm.c index

Re: [BUG] kvm: guest can not startup due to triple fault

On Mon, 2010-10-18 at 10:58 +0200, Avi Kivity wrote: Doesn't parse here. I get a bus error. Steven, is trace.dat meant to be transportable? What does it depend on? Jan, can you upload your parsed data somewhere? I want to have a look as well. Never mind, user error here.

Re: [RFC PATCH 0/2] kvm/vmx: Output TSC offset

On Wed, 2012-11-14 at 10:36 +0900, Yoshihiro YUNOMAE wrote: To merge the data like previous pattern, we apply this patch set. Then, we can get TSC offset of the guest as follows: $ dmesg | grep kvm [ 57.717180] kvm: (2687) write TSC offset 18446743360465545001, now clock ##

Re: [RFC PATCH 0/2] kvm/vmx: Output TSC offset

On Tue, 2012-11-13 at 18:03 -0800, David Sharp wrote: On Tue, Nov 13, 2012 at 6:00 PM, Steven Rostedt rost...@goodmis.org wrote: On Wed, 2012-11-14 at 10:36 +0900, Yoshihiro YUNOMAE wrote: To merge the data like previous pattern, we apply this patch set. Then, we can get TSC offset

Re: Re: [RFC PATCH 0/2] kvm/vmx: Output TSC offset

On Wed, 2012-11-14 at 17:26 +0900, Yoshihiro YUNOMAE wrote: Thank you for commenting on my patch set. (2012/11/14 11:31), Steven Rostedt wrote: On Tue, 2012-11-13 at 18:03 -0800, David Sharp wrote: On Tue, Nov 13, 2012 at 6:00 PM, Steven Rostedt rost...@goodmis.org wrote: On Wed, 2012

Re: [PATCH] trace-cmd: fix kvm_mmu_prepare_zap_page even name and kvm_mmu_get_page event output in kvm plugin

On Tue, 2012-12-25 at 13:46 +0200, Gleb Natapov wrote: kvm_mmu_zap_page even was renamed to kvm_mmu_prepare_zap_page. Print out created field for kvm_mmu_get_page event. trace-cmd needs to be backward compatible with older kernels. If older kernels used kvm_mmu_zap_page, then please add a check

Re: [PATCH] trace-cmd: fix kvm_mmu_prepare_zap_page even name and kvm_mmu_get_page event output in kvm plugin

On Wed, 2012-12-26 at 16:13 +0200, Gleb Natapov wrote: On Wed, Dec 26, 2012 at 08:58:30AM -0500, Steven Rostedt wrote: On Tue, 2012-12-25 at 13:46 +0200, Gleb Natapov wrote: kvm_mmu_zap_page even was renamed to kvm_mmu_prepare_zap_page. Print out created field for kvm_mmu_get_page event

Re: [RFC 0/2] KVM: Fix kvm_exit trace event format

On Wed, 2011-07-27 at 15:59 +0300, Avi Kivity wrote: On 07/27/2011 03:55 PM, Stefan Hajnoczi wrote: trace-cmd has a plugin API (and a kvm plugin) that you can use for this, and I expect perf either does as well or can make use of one. I don't think it's useful to complicate the

Re: Testing tracer wakeup_rt: .. no entries found ..FAILED!

On Wed, 2012-08-01 at 07:57 +0800, Fengguang Wu wrote: What was the next lines? I bet you it was PASSED. Which means it did not fail. This is the second bug you found that has to do with RCU being called in 'idle'. The one that Paul posted a patch for. Yeah, PASSED! I have this patch

Re: [PATCH -tip v5 2/7] kprobes: checks probe address is instruction boudary on x86

On Fri, 8 May 2009, Masami Hiramatsu wrote: Ensure safeness of inserting kprobes by checking whether the specified address is at the first byte of a instruction on x86. This is done by decoding probed function from its head to the probe point. Signed-off-by: Masami Hiramatsu

Re: [PATCH -tip v5 7/7] tracing: add arguments support on kprobe-based event tracer

memory at SYM +|- offs (SYM should be a data symbol) aN: Fetch function argument. (N = 0) rv: Fetch return value. ra: Fetch return address. +|-offs(FETCHARG) : fetch memory at FETCHARG +|- offs address. Signed-off-by: Masami Hiramatsu mhira...@redhat.com Cc: Steven Rostedt

Re: [PATCH -tip v5 0/7] tracing: kprobe-based event tracer and x86 instruction decoder

On Mon, 11 May 2009, Masami Hiramatsu wrote: Two high-level comments: - There's no self-test - would it be possible to add one? See trace_selftest* in kernel/trace/ I'm not so sure. Currently, it seems that those self-tests are only for tracers which define new event-entry on

Re: [PATCH -tip v5 2/7] kprobes: checks probe address is instruction boudary on x86

On Mon, 11 May 2009, Masami Hiramatsu wrote: + * by fix_riprel(). + */ + memcpy(buf, kp-addr, MAX_INSN_SIZE * sizeof(kprobe_opcode_t)); + buf[0] = kp-opcode; Why is it OK to copy addr to buf and then rewrite the first character of buf? Does it have something to do with

Re: [PATCH -tip v8 6/7] tracing: ftrace dynamic ftrace_event_call support

among several ftrace_event_calls. Signed-off-by: Masami Hiramatsu mhira...@redhat.com Cc: Steven Rostedt rost...@goodmis.org Cc: Ingo Molnar mi...@elte.hu Cc: Tom Zanussi tzanu...@gmail.com Cc: Frederic Weisbecker fweis...@gmail.com --- include/linux/ftrace_event.h | 13

Re: [PATCH -tip v8 7/7] tracing: add kprobe-based event tracer

solved TODO. - Support per-probe event filtering. Signed-off-by: Masami Hiramatsu mhira...@redhat.com Cc: Christoph Hellwig h...@infradead.org Cc: Steven Rostedt rost...@goodmis.org Cc: Ananth N Mavinakayanahalli ana...@in.ibm.com Cc: Ingo Molnar mi...@elte.hu Cc: Frederic Weisbecker fweis

Re: [PATCH -tip v8 7/7] tracing: add kprobe-based event tracer

On Thu, 28 May 2009, Masami Hiramatsu wrote: +#undef SHOW_FIELD +#define SHOW_FIELD(type, item, name) \ + do {\ + ret = trace_seq_printf(s, \tfield: #type %s;\t\ +

Re: [PATCH] KVM: add localversion to avoid confusion and conflicts

On Fri, May 29, 2009 at 02:13:46PM +0530, Jaswinder Singh Rajput wrote: On Fri, 2009-05-29 at 09:48 +0200, Christian Bornträger wrote: Am Freitag 29 Mai 2009 09:18:14 schrieb Jaswinder Singh Rajput: Adding localversion avoids confusion in kernel images : like Linux version 2.6.30-rc7

Re: [PATCH] KVM: add localversion to avoid confusion and conflicts

On Mon, 1 Jun 2009, Avi Kivity wrote: localversion would show up in linux-next, not sure if that's a problem. On the other hand, I'm not sure what it's worth. If a localversion file with -kvm showed up in linux-next, I would consider that a problem. -- Steve -- To unsubscribe from this

Re: [patch 1/2] KVM: convert custom marker based tracing to event traces

On Mon, 15 Jun 2009, Marcelo Tosatti wrote: This allows use of the powerful ftrace infrastructure. See Documentation/trace/ for usage information. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/svm.c

Re: [patch 1/2] KVM: convert custom marker based tracing to event traces

On Tue, 16 Jun 2009, Marcelo Tosatti wrote: One suggestion. Instead of putting in arch specific trace points into generic code, you can put these into arch/x86/kvm/trace.h ? Then you can in the Makefile add: CFLAGS_x86.o := -I. CFLAGS_svm.o := -I. CFLAGS_vmx.o := -I.

Re: [PATCH 2/4] KVM: Use __print_hex() for kvm_emulate_insn tracepoint

[ Added Avi] On Wed, 2012-06-27 at 09:41 +0900, Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com The kvm_emulate_insn tracepoint used __print_insn() for printing its instructions. However it makes the format of the event hard to parse as it reveals TP internals. Fortunately,

Re: [PATCH 2/4] KVM: Use __print_hex() for kvm_emulate_insn tracepoint

On Wed, 2012-06-27 at 15:54 +0300, Avi Kivity wrote: Acked-by: Avi Kivity a...@redhat.com Thanks Avi! Some time ago we discussed moving the trace-cmd plugins to /lib/modules, which would make this trace display as mov %edx,(%eax) instead of 89 10, even for non-trace-cmd users. Was there

Re: [PATCH 2/4] KVM: Use __print_hex() for kvm_emulate_insn tracepoint

On Thu, 2012-06-28 at 10:16 +0900, Namhyung Kim wrote: [CC'ing David] Hi, Steve On Wed, 27 Jun 2012 09:20:24 -0400, Steven Rostedt wrote: On Wed, 2012-06-27 at 15:54 +0300, Avi Kivity wrote: Acked-by: Avi Kivity a...@redhat.com Thanks Avi! Can you give me your ack's too

Re: [PATCH 2/4] KVM: Use __print_hex() for kvm_emulate_insn tracepoint

On Thu, 2012-06-28 at 10:59 +0900, Namhyung Kim wrote: Ok, thanks. But how about other ones? Did you add all of 4 into you queue? Ah, no I didn't. I actually would like Arnaldo to do that. Arnaldo, Can you pull patches 1,3 4 into your repo, and add my: Acked-by: Steven Rostedt rost

Re: Testing tracer wakeup_rt: .. no entries found ..FAILED!

On Tue, 2012-07-31 at 15:37 +0300, Avi Kivity wrote: On 07/31/2012 03:17 PM, Fengguang Wu wrote: It's good to quickly get to the root cause :) Can we possibly detect whether we are in a virtual machine and hence skip this particular test case? cpu_has(boot_cpu, X86_FEATURE_HYPERVISOR)

Re: Testing tracer wakeup_rt: .. no entries found ..FAILED!

On Tue, 2012-07-31 at 15:50 +0300, Avi Kivity wrote: On 07/31/2012 03:43 PM, Steven Rostedt wrote: That would be better. A hypervisor might be real-time capable (with some effort kvm can do this), so we don't want to turn off real time features just based on that. It would only turn off

Re: Testing tracer wakeup_rt: .. no entries found ..FAILED!

On Wed, 2012-08-01 at 07:43 +0800, Fengguang Wu wrote: On Tue, Jul 31, 2012 at 09:13:39AM -0400, Steven Rostedt wrote: On Tue, 2012-07-31 at 15:50 +0300, Avi Kivity wrote: On 07/31/2012 03:43 PM, Steven Rostedt wrote: That would be better. A hypervisor might be real-time capable

Re: Testing tracer wakeup_rt: .. no entries found ..FAILED!

On Tue, 2012-07-31 at 16:57 -0700, Paul E. McKenney wrote: What was the next lines? I bet you it was PASSED. Which means it did not fail. This is the second bug you found that has to do with RCU being called in 'idle'. The one that Paul posted a patch for. Though it needs another patch

Re: [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

On Tue, Nov 08, 2011 at 10:32:25AM +0100, Ingo Molnar wrote: None of the perf developers with whom i'm working complained about the shared repo so far - publicly or privately. By all means they are enjoying it and if you look at the stats and results you'll agree that they are highly

Re: [PATCH] KVM guest: prevent tracing recursion with kvmclock

was thinking it may be better to have a get_cpu_var_notrace() than to have to open code this stuff. Maybe there's not that many users that open code is not an issue. I'll still want to add that recursion protection with the warn on though. Acked-by: Steven Rostedt rost...@goodmis.org -- Steve

Re: [PATCH] KVM guest: prevent tracing recursion with kvmclock

On Tue, 2011-11-15 at 15:45 +0200, Avi Kivity wrote: What about function traces? Will any noninlined calls cause the same problem? Both function_graph and function tracing have recursion protection around the users of the call. function tracing is much lighter weight than function_graph

Re: trace-cmd errors on kvm events

On Fri, Apr 08, 2011 at 11:07:23PM +0200, Jan Kiszka wrote: On 2011-04-08 20:53, David Ahern wrote: 2.6.38.2 kernel with trace-cmd git pulled this morning: trace-cmd record -e kvm trace-cmd report 21 | less trace-cmd: No such file or directory Does this error come from

Re: [PATCH] kvm: log directly from the guest to the host kvm buffer

On Thu, 2011-05-12 at 17:39 +0200, Dhaval Giani wrote: +int kvm_pv_ftrace(struct kvm_vcpu *vcpu, unsigned long ip, gpa_t addr) +{ + int ret; + char *fmt = (char *) kzalloc(PAGE_SIZE, GFP_KERNEL); + + ret = kvm_read_guest(vcpu-kvm, addr, fmt, PAGE_SIZE); + +

Re: [PATCHv2] trace-cmd: add kvm_mmu_prepare_zap_page even and fix kvm_mmu_get_page event output in kvm plugin

On Mon, 2013-01-28 at 13:12 +0200, Gleb Natapov wrote: Ping. Please send email (especially patches) to my rost...@goodmis.org account. I don't always read my RH email, except to skim it for RH related work. I may miss a patch in my goodmis account, but I will periodically purge it (go through

Re: [PATCHv2] trace-cmd: add kvm_mmu_prepare_zap_page even and fix kvm_mmu_get_page event output in kvm plugin

On Mon, 2013-01-28 at 13:12 +0200, Gleb Natapov wrote: Ping. On Thu, Dec 27, 2012 at 01:34:15PM +0200, Gleb Natapov wrote: kvm_mmu_zap_page event was renamed to kvm_mmu_prepare_zap_page. Add new even, but leave the old one to parse older traces. Print out created field for

Re: [PATCHv2] trace-cmd: add kvm_mmu_prepare_zap_page even and fix kvm_mmu_get_page event output in kvm plugin

On Mon, 2013-01-28 at 19:00 +0200, Gleb Natapov wrote: Is created a new field? Or is it something that has always been there but never displayed? Always been there, but for some reason, was not displayed. OK, I'll apply it then. Thanks! -- Steve If it is new, then instead of

Re: [PATCH v2 10/10] kernel: might_fault does not imply might_sleep

On Sun, 2013-05-19 at 12:35 +0300, Michael S. Tsirkin wrote: No, I was not assuming that. What I'm trying to say is that a caller that does something like this under a spinlock: preempt_disable pagefault_disable error = copy_to_user pagefault_enable

Re: [PATCH v2 10/10] kernel: might_fault does not imply might_sleep

On Sun, 2013-05-19 at 16:34 +0300, Michael S. Tsirkin wrote: Right but we need to keep it working on upstream as well. If I do preempt_enable under a spinlock upstream won't it try to sleep under spinlock? No it wont. A spinlock calls preempt_disable implicitly, and a preempt_enable() will

Re: [PATCH v2 10/10] kernel: might_fault does not imply might_sleep

On Sun, 2013-05-19 at 19:40 +0300, Michael S. Tsirkin wrote: OK I get it. So let me correct myself. The simple code that does something like this under a spinlock: preempt_disable pagefault_disable error = copy_to_user pagefault_enable preempt_enable

Re: [PATCH 2/2] KVM: PPC: Book3E: Emulate MCSRR0/1 SPR and rfmci instruction

On Wed, 2013-07-10 at 00:00 +0200, Alexander Graf wrote: Then don't overflow the buffer. Make it large enough. IIRC ftrace improved recently to dynamically increase the buffer size too. Steven, do I remember correctly here? Not really. Ftrace only dynamically increases the buffer when the

Re: [PATCH 2/2] KVM: PPC: Book3E: Emulate MCSRR0/1 SPR and rfmci instruction

On Tue, 2013-07-09 at 17:26 -0500, Scott Wood wrote: On 07/09/2013 05:00:26 PM, Alexander Graf wrote: On 09.07.2013, at 23:54, Scott Wood wrote: On 07/09/2013 04:49:32 PM, Alexander Graf wrote: Not sure I understand. What the timing stats do is that they measure the time between

Re: [PATCH] trace-cmd: Report unknown VMX exit reasons with code

On Fri, 04 Oct 2013 15:40:29 +0200 Jan Kiszka jan.kis...@web.de wrote: Ping. While my other patch of that time was merged, this one didn't make it yet. Any open issues? Hmm, no. Not sure how I missed this one. Probably because it didn't have the 2/2 patch format and I thought there was only

Re: [PATCH] kvm fix: Enable pvspinlock after jump_label_init() to avoid VM hang

executed) This patch splits kvm_spinlock_init to separate jump label changes with pvops patching and also make jump label enabling after jump_label_init(). Signed-off-by: Raghavendra K T raghavendra...@linux.vnet.ibm.com Reviewed-by: Steven Rostedt rost...@goodmis.org -- Steve --- Thanks

Re: [PATCH] x86: fix page fault tracing when KVM guest support enabled

://lkml.kernel.org/r/20140508194508.561ed...@gandalf.local.home is worth it, expecially considering that the KVM code is already making page fault entry slower here. This solution is dirt-simple. I just threw it out there as a suggestion. I don't care either way. Acked-by: Steven Rostedt rost

Re: [PATCH] KVM: PPC: Book3S HV: Tracepoints for KVM HV guest interactions

On Thu, 20 Nov 2014 13:10:12 +0100 Alexander Graf ag...@suse.de wrote: On 20.11.14 11:40, Aneesh Kumar K.V wrote: Suresh E. Warrier warr...@linux.vnet.ibm.com writes: This patch adds trace points in the guest entry and exit code and also for exceptions handled by the host in kernel

Re: Another Obsolete Fix me in trace.h?

On Mon, 24 Nov 2014 22:00:01 +0100 Radim Krčmář rkrc...@redhat.com wrote: 2014-11-24 11:40+0100, Jan Kiszka: On 2014-11-24 11:12, Paolo Bonzini wrote: On 24/11/2014 05:36, nick wrote: Greetings Again Gleb and others, I am assuming in the code I am pasting below the fix me is obsolete

Re: Another Obsolete Fix me in trace.h?

On Wed, 26 Nov 2014 13:40:26 +0100 Radim Krčmář rkrc...@redhat.com wrote: 2014-11-24 22:49+0100, Radim Krčmář: 2014-11-24 16:19-0500, Steven Rostedt: That wouldn't be too hard to implement. I'll look at the patch tommorrow. The kernel part is trivial. Most of the code is going

Re: Another Obsolete Fix me in trace.h?

On Wed, 26 Nov 2014 15:49:34 +0100 Radim Krčmář rkrc...@redhat.com wrote: (It just seemed weird that we have an infrastructure that could allow a generic plugin to cover this functionality.) Maybe in the future we may do something like that. But for now, think of these as optimized ;-) --

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

On Thu, 22 Jan 2015 11:50:10 + Andrew Cooper andrew.coop...@citrix.com wrote: On 22/01/15 02:17, Luis R. Rodriguez wrote: --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -32,6 +32,8 @@ #include linux/slab.h #include linux/irqnr.h #include

Re: [patch -rt 1/2] KVM: use simple waitqueue for vcpu-wq

On Tue, 20 Jan 2015 16:46:53 +1100 Paul Mackerras pau...@samba.org wrote: On Mon, Jan 19, 2015 at 12:41:00PM -0200, Marcelo Tosatti wrote: On Fri, Jan 16, 2015 at 11:48:46AM -0500, Steven Rostedt wrote: static void kvmppc_vcore_blocked(struct kvmppc_vcore *vc

Re: [patch -rt 1/2] KVM: use simple waitqueue for vcpu-wq

On Fri, 16 Jan 2015 11:48:46 -0500 Steven Rostedt rost...@goodmis.org wrote: static void kvmppc_vcore_blocked(struct kvmppc_vcore *vc) { - DEFINE_WAIT(wait); + DEFINE_SWAITER(wait); - prepare_to_wait(vc-wq, wait, TASK_INTERRUPTIBLE); + swait_prepare(vc-wq, wait

Re: [patch -rt 1/2] KVM: use simple waitqueue for vcpu-wq

On Fri, 16 Jan 2015 11:40:45 -0500 Marcelo Tosatti mtosa...@redhat.com wrote: The problem: On -RT, an emulated LAPIC timer instances has the following path: 1) hard interrupt 2) ksoftirqd is scheduled 3) ksoftirqd wakes up vcpu thread 4) vcpu thread is scheduled This extra context

Re: [RFC v4 2/2] x86/xen: allow privcmd hypercalls to be preempted

On Thu, 22 Jan 2015 17:40:27 -0800 Andy Lutomirski l...@amacapital.net wrote: +/* + * CONFIG_PREEMPT=n kernels can end up triggering the softlock + * TASK_UNINTERRUPTIBLE hanger check (default 120 seconds) + * when certain multicalls are used [0] on large systems, in + * that case we

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

[ Added Paul McKenney ] On Thu, 22 Jan 2015 19:39:13 +0100 Luis R. Rodriguez mcg...@suse.com wrote: Why not make this a tracepoint? Then you can enable it only when you want to. As tracepoints are also hooks, you could add you own code that hooks to it and does a printk as well. The

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

On Thu, 22 Jan 2015 12:24:47 -0800 Andy Lutomirski l...@amacapital.net wrote: Also, please remove the notrace, because function tracing goes an extra step to not require RCU being visible. The only thing you get with notrace is not being able to trace an otherwise traceable function.

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

On Thu, 22 Jan 2015 12:58:00 -0800 Andy Lutomirski l...@amacapital.net wrote: On Thu, Jan 22, 2015 at 12:37 PM, Steven Rostedt rost...@goodmis.org wrote: On Thu, 22 Jan 2015 12:24:47 -0800 Andy Lutomirski l...@amacapital.net wrote: Also, please remove the notrace, because function

Re: [PATCH] MIPS: KVM: Fix trace event to save PC directly

: Paolo Bonzini pbonz...@redhat.com Cc: Ralf Baechle r...@linux-mips.org Cc: Marcelo Tosatti mtosa...@redhat.com Cc: Gleb Natapov g...@kernel.org Cc: Steven Rostedt rost...@goodmis.org Acked-by: Steven Rostedt rost...@goodmis.org -- Steve Cc: Ingo Molnar mi...@redhat.com Cc: linux-m...@linux

Re: [PATCH] tools lib traceevent: update KVM plugin

On Tue, 20 Oct 2015 17:19:12 +0200 Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 20/10/2015 16:44, Steven Rostedt wrote: > > What happens if you run new perf on an older kernel. Is this new plugin > > going to be screwed up? Plugins should be backward compatibl

Re: [PATCH] tools lib traceevent: update KVM plugin

On Tue, 20 Oct 2015 12:50:26 -0300 Arnaldo Carvalho de Melo <a...@redhat.com> wrote: > Cool, Steven, can I take that as an Acked-by for this patch? > Acked-by: Steven Rostedt <rost...@goodmis.org> -- Steve -- To unsubscribe from this list: send the line "unsub

Re: [PATCH] tools lib traceevent: update KVM plugin

On Tue, 20 Oct 2015 17:37:43 +0200 Paolo Bonzini wrote: > However, it frankly seems a bit academic. The parsing _will_ work, > apart from printing a nonsensical role just like it has always done for > the past four years. I'm not going to be too picky about it. But things

Re: [PATCH] tools lib traceevent: update KVM plugin

On Tue, 20 Oct 2015 12:32:44 -0200 Arnaldo Carvalho de Melo <a...@redhat.com> wrote: > > Ping? Arnaldo, ok to include this patch in my tree? > > Applying, I saw it before, but lost track, perhaps was waiting for > Steven Rostedt to chime in, but now I noticed he wasn't C

Re: [PATCH 2/2] KVM: PPC: Book3E: Emulate MCSRR0/1 SPR and rfmci instruction

On Wed, 2013-07-10 at 00:00 +0200, Alexander Graf wrote: Then don't overflow the buffer. Make it large enough. IIRC ftrace improved recently to dynamically increase the buffer size too. Steven, do I remember correctly here? Not really. Ftrace only dynamically increases the buffer when the

Re: [PATCH 2/2] KVM: PPC: Book3E: Emulate MCSRR0/1 SPR and rfmci instruction

On Tue, 2013-07-09 at 17:26 -0500, Scott Wood wrote: On 07/09/2013 05:00:26 PM, Alexander Graf wrote: On 09.07.2013, at 23:54, Scott Wood wrote: On 07/09/2013 04:49:32 PM, Alexander Graf wrote: Not sure I understand. What the timing stats do is that they measure the time between

Re: [PATCH] KVM: PPC: Book3S HV: Tracepoints for KVM HV guest interactions

On Thu, 20 Nov 2014 13:10:12 +0100 Alexander Graf ag...@suse.de wrote: On 20.11.14 11:40, Aneesh Kumar K.V wrote: Suresh E. Warrier warr...@linux.vnet.ibm.com writes: This patch adds trace points in the guest entry and exit code and also for exceptions handled by the host in kernel