Re: [PATCH 1/2] kvm/e500v2: Remove shadow tlb

2010-09-09 Thread Hollis Blanchard
On 09/09/2010 04:26 PM, Alexander Graf wrote: On 09.09.2010, at 20:13, Hollis Blanchard wrote: On 09/09/2010 04:16 AM, Liu Yu-B13201 wrote: Yes, it's hard to resume TLB0. We only resume TLB1 in previous code. But TLB1 is even more smaller (13 free entries) than 440, So that it

Re: [PATCH 1/2] kvm/e500v2: Remove shadow tlb

2010-09-09 Thread Hollis Blanchard
pages, and must split the guest mapping into multiple large host pages. When will you have hugetlbfs for e500? That's going to make such a dramatic difference, I'm not sure it's worth investing time in optimizing the MMU code until then. Hollis Blanchard Mentor Graphics, Embedded

Re: [PATCH 0/2] kvm/e500v2: MMU optimization

2010-09-09 Thread Hollis Blanchard
On 09/09/2010 04:03 AM, Liu Yu-B13201 wrote: -Original Message- From: kvm-ppc-ow...@vger.kernel.org [mailto:kvm-ppc-ow...@vger.kernel.org] On Behalf Of Hollis Blanchard Sent: Thursday, September 09, 2010 12:07 AM To: Liu Yu-B13201 Cc: kvm@vger.kernel.org; kvm-...@vger.kernel.org; ag

Re: [PATCH 0/2] kvm/e500v2: MMU optimization

2010-09-08 Thread Hollis Blanchard
demand-faulted rather than swapped wholesale. To do that, you would need to track the host PID in KVM data structures, I guess in the tlbe_ref structure. -- Hollis Blanchard Mentor Graphics, Embedded Systems Division -- To unsubscribe from this list: send the line "unsubscribe kvm" in

Re: [PATCH 1/2] kvm/e500v2: Remove shadow tlb

2010-09-08 Thread Hollis Blanchard
to restore a full guest TLB working set, but maybe it's not really possible to use all 1024 TLB0 entries in one timeslice anyways). -- Hollis Blanchard Mentor Graphics, Embedded Systems Division -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a me

Re: KVM on MIPS?

2010-08-12 Thread Hollis Blanchard
#x27;t run an unmodified guest. It should be possible to build the guest kernel to run in supervisor or user mode/address space. I'm new to MIPS, so I'm still looking for other challenges in virtualizing the instruction set. Hi Dale, how is this going? Hollis Blanchard Mentor Graphics

Re: [PATCH 01/27] KVM: PPC: Introduce shared page

2010-08-05 Thread Hollis Blanchard
function like kvm_arch_vcpu_init()? There are layers of shared code inside arch/powerpc/kvm: e.g. powerpc.c -> booke.c -> 44x.c... Hollis Blanchard Mentor Graphics, Embedded Systems Division -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message

Re: [PATCH 17/27] KVM: PPC: KVM PV guest stubs

2010-08-05 Thread Hollis Blanchard
of places to patch itself at runtime in fast paths... see Documentation/powerpc/cpu_features.txt for some background. Since we already know (at build time) the location of code that needs patching, we don't need to scan at all. (I also shudder to think of the number of page faults

Re: [PATCH 27/27] KVM: PPC: Add Documentation about PV interface

2010-07-02 Thread Hollis Blanchard
[Resending...] Please reconcile this with http://www.linux-kvm.org/page/PowerPC_Hypercall_ABI, which has been discussed in the (admittedly closed) Power.org embedded hypervisor working group. Bear in mind that other hypervisors are already implementing the documented ABI, so if you have concerns,

Re: Keep index within boundaries in kvmppc_44x_emul_tlbwe()

2010-05-10 Thread Hollis Blanchard
On Sun, May 9, 2010 at 8:26 AM, Roel Kluin wrote: > An index of KVM44x_GUEST_TLB_SIZE is already one too large. > > Signed-off-by: Roel Kluin Acked-by: Hollis Blanchard Thanks Roel. -Hollis -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of

Re: [PATCH v3] kvmppc/booke: Set ESR and DEAR when inject interrupt to guest

2010-02-03 Thread Hollis Blanchard
On Tue, Feb 2, 2010 at 3:44 AM, Liu Yu wrote: > Old method prematurely sets ESR and DEAR. > Move this part after we decide to inject interrupt, > which is more like hardware behave. > > Signed-off-by: Liu Yu Acked-by: Hollis Blanchard -- To unsubscribe from this list

Re: [PATCH] kvmppc/booke: Set ESR and DEAR when inject interrupt to guest

2010-01-26 Thread Hollis Blanchard
On Mon, Jan 25, 2010 at 3:32 AM, Liu Yu-B13201 wrote: > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Friday, January 22, 2010 7:33 PM >> To: Liu Yu-B13201 >> Cc: hol...@penguinppc.org; kvm-...@vger.kernel.org; >> kvm@vger.kernel.org >> Subject: Re: [PATCH]

Re: [PATCH 7/9] KVM: PPC: Emulate trap SRR1 flags properly

2010-01-08 Thread Hollis Blanchard
On Fri, Jan 8, 2010 at 11:32 AM, Alexander Graf wrote: > > On 08.01.2010, at 20:29, Hollis Blanchard wrote: > >> On Thu, Jan 7, 2010 at 5:58 PM, Alexander Graf wrote: >>> Book3S needs some flags in SRR1 to get to know details about an interrupt. >>> >>>

Re: [PATCH 7/9] KVM: PPC: Emulate trap SRR1 flags properly

2010-01-08 Thread Hollis Blanchard
On Thu, Jan 7, 2010 at 5:58 PM, Alexander Graf wrote: > Book3S needs some flags in SRR1 to get to know details about an interrupt. > > One such example is the trap instruction. It tells the guest kernel that > a program interrupt is due to a trap using a bit in SRR1. > > This patch implements abov

Re: [PATCH 0/3] Improve Decrementor Implementation v2

2009-12-21 Thread Hollis Blanchard
arch/powerpc/include/asm/kvm_ppc.h |    1 + >  arch/powerpc/kvm/book3s.c          |   45 --- >  arch/powerpc/kvm/booke.c           |    5 >  arch/powerpc/kvm/emulate.c         |    3 ++ >  4 files changed, 35 insertions(+), 19 deletions(-) Acked-by: Hollis

Re: [PATCH 2/3] Improve DEC handling

2009-12-21 Thread Hollis Blanchard
For the record, we've discussed more by IRC, and I think revised patches will be forthcoming. -Hollis -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] Improve DEC handling

2009-12-21 Thread Hollis Blanchard
On Mon, Dec 21, 2009 at 10:13 AM, Hollis Blanchard wrote: >  void kvmppc_emulate_dec(struct kvm_vcpu *vcpu) >  { >        unsigned long dec_nsec; > >        pr_debug("mtDEC: %x\n", vcpu->arch.dec); >  #ifdef CONFIG_PPC64 >        /* POWER4+ triggers a

Re: [PATCH 2/3] Improve DEC handling

2009-12-21 Thread Hollis Blanchard
On Mon, Dec 21, 2009 at 6:22 AM, Alexander Graf wrote: > We treated the DEC interrupt like an edge based one. This is not true for > Book3s. The DEC keeps firing until mtdec is issued again and thus clears > the interrupt line. That's not quite right. The decrementer keeps firing until the top bi

Re: [PATCH] Change PowerPC KVM maintainer

2009-12-20 Thread Hollis Blanchard
demand Acks from Hollis for code that changes BookE parts when I > can't say for sure if the change is ok. > > Signed-off-by: Alexander Graf Acked-by: Hollis Blanchard -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to ma

Re: [PATCH] KVM-PPC: Fix mtsrin in book3s_64 mmu

2009-12-19 Thread Hollis Blanchard
KVM. > > Signed-off-by: Alexander Graf Acked-by: Hollis Blanchard -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/27] Add KVM support for Book3s_64 (PPC64) hosts v5

2009-10-26 Thread Hollis Blanchard
nclude > #include > #include > +#include > > #include > #include For some reason, I'm not seeing this build break, but the patch is obviously correct. Acked-by: Hollis Blanchard -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from this list: send t

Re: [PATCH 00/27] Add KVM support for Book3s_64 (PPC64) hosts v5

2009-10-26 Thread Hollis Blanchard
On Sun, 2009-10-25 at 15:01 +0200, Avi Kivity wrote: > On 10/23/2009 02:33 AM, Hollis Blanchard wrote: > > On Wed, 2009-10-21 at 17:03 +0200, Alexander Graf wrote: > > > >> KVM for PowerPC only supports embedded cores at the moment. > >> > >> W

Re: [PATCH 00/27] Add KVM support for Book3s_64 (PPC64) hosts v5

2009-10-22 Thread Hollis Blanchard
gt; > This patchset implements KVM support for Book3s_64 hosts and guest support > for Book3s_64 and G3/G4. Acked-by: Hollis Blanchard Avi, please apply these patches, and one more (unrelated) to fix the Book E build that I will send in just a moment. -- Hollis Blanchard IBM Linux Technology Cent

Re: [PATCH] Use Little Endian for Dirty Bitmap

2009-09-28 Thread Hollis Blanchard
set_bit(rel_gfn, memslot->dirty_bitmap); > + if (!generic_test_le_bit(rel_gfn, memslot->dirty_bitmap)) > + generic___set_le_bit(rel_gfn, memslot->dirty_bitmap); > } > } I don't think I've ever exercised the dirty bitmap code, and I don't really hav

Re: [Alacrityvm-devel] [PATCH v3 3/6] vbus: add a "vbus-proxy" bus model for vbus_driver objects

2009-08-19 Thread Hollis Blanchard
I am just stating a problem with virtio-net that I > > noticed. This is just so someone more knowledgeable can be aware of the > > problem. > > > > > > Ah, it certainly doesn't byteswap. Maybe nobody tried it. Hollis? I've never tried it. I've onl

Re: [PATCH] remove ppc functions from callbacks

2009-06-16 Thread Hollis Blanchard
he fact that powerpc now relies on a totally > qemu upstream implementation of kvm, and does not need it anymore. > > Anyway, I'm providing this patch separatedly, so that if it breaks > for whenever reason, we can identify a bisection point easily > > Signed-off-by: Glauber

Re: [PATCH 1/4] Introduce kvm_vcpu_is_bsp() function.

2009-06-08 Thread Hollis Blanchard
_KVM_IRQCHIP (which is a close approximation). I don't know about that... I've definitely thought about implementing an in-kernel PIC for PowerPC. (That will make more sense as an optimization once the processors with hypervisor support start hitting the market.) -- Hollis Blanchard

Re: [PATCH 2/6] kvm-s390: use hrtimer for clock wakeup from idle

2009-05-20 Thread Hollis Blanchard
flag and fires and scheduled handlers > > Now these operations are pretty cheap on x86, but maybe that can apply > to s390. I don't know how the cycle counts compare, but FWIW normal ppc64 Linux does almost exactly this (and calls it "lazy irq disabling"). The only diffe

Re: PowerPC page faults

2009-05-12 Thread Hollis Blanchard
On Monday 11 May 2009 17:17:53 Anthony Liguori wrote: > Hollis Blanchard wrote: > > On Mon, 2009-05-11 at 12:54 -0500, Anthony Liguori wrote: > > > >> For future ppcemb's, do you know if there is an equivalent of a PF exit > >> type? Does the hardw

Re: PowerPC page faults

2009-05-11 Thread Hollis Blanchard
knowledge, they also don't do IO emulation, so they avoid both conditionals in the above psuedocode. -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 0/3] generic hypercall support

2009-05-11 Thread Hollis Blanchard
on instructions. > Page faults are going to have tremendously different performance > characteristics on PPC too because it's a software managed TLB. There's > no page table lookup like there is on x86. To clarify, software-managed TLBs are only found in embedded PowerPC.

Re: [RFC PATCH 0/3] generic hypercall support

2009-05-11 Thread Hollis Blanchard
(at least not without tunneling them over > HCs) I haven't been following this conversation at all. With that in mind... AFAICS, a hypercall is clearly the higher-performing option, since you don't need the additional memory load (which could even cause a page fault in some circumsta

Re: [RFC PATCH 1/3] add generic hypercall support

2009-05-05 Thread Hollis Blanchard
ure that implements instructions for a separate IO space (not even ia64 does). -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/04] qemu-kvm: other archs should maintain memory mappingalso.

2009-05-04 Thread Hollis Blanchard
n just cut it out if you don't think it should be > added. I don't understand the code being moved, but I guess I don't want it, so your patch is fine with me. (Wtf are those magic addresses? And not a single comment?? Aren't we better than this?) -- Hollis Blan

Re: qemu-kvm.git now live

2009-05-04 Thread Hollis Blanchard
On Sat, 2009-05-02 at 10:52 +0300, Avi Kivity wrote: > Hollis Blanchard wrote: > >> In that case it's sufficient to have the build system use the upstream > >> kvm integration (CONFIG_KVM) rather than the qemu-kvm integration > >> (USE_KVM). > >&g

RE: [PATCH] Revert "Sync idcache after emualted DMA operations foria64"

2009-05-04 Thread Hollis Blanchard
ined reference to `qemu_cache_conf' However, to restate my point: the build error is not the biggest problem with this patch. The bigger problems are all the other issues I've repeatedly described. The build break is the icing on the cake. -- Hollis Blanchard IBM Linux Technology Center --

[PATCH 5/5] patch add_powerpc_kvm_headers.diff

2009-05-01 Thread Hollis Blanchard
Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + * + * Copyright IBM Corp. 2007 + * + * Authors: Hollis Blanchard + */ + +#ifndef __LINUX_KVM_POWERPC_H +#define __LINUX_KVM_POWERPC_H + +#include + +struct kvm_regs { + __u64 pc; + __u64 cr; + __u64 ctr; + __u64 lr

[PATCH 4/5] [qemu-kvm] Use CAP_IRQ_ROUTING in kvm_get_irq_route_gsi()

2009-05-01 Thread Hollis Blanchard
This fixes a build break when KVM_IOAPIC_NUM_PINS is not defined. Signed-off-by: Hollis Blanchard --- kvm/libkvm/libkvm.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/kvm/libkvm/libkvm.c b/kvm/libkvm/libkvm.c index 0610e3f..ba0a5d1 100644 --- a/kvm/libkvm/libkvm.c

[PATCH 3/5] [qemu-kvm] Fix "missing prototype" warning.

2009-05-01 Thread Hollis Blanchard
As far as I can see, kvm_destroy_memory_region_works() has nothing to do with KVM_CAP_DEVICE_ASSIGNMENT, so move the prototype outside that ifdef block. Signed-off-by: Hollis Blanchard --- kvm/libkvm/libkvm.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kvm/libkvm

[PATCH 2/5] [qemu-kvm] Fix warning when__ia64__ is not defined.

2009-05-01 Thread Hollis Blanchard
Signed-off-by: Hollis Blanchard --- kvm/libkvm/kvm-common.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kvm/libkvm/kvm-common.h b/kvm/libkvm/kvm-common.h index 96361e8..591fb53 100644 --- a/kvm/libkvm/kvm-common.h +++ b/kvm/libkvm/kvm-common.h @@ -22,7 +22,7

PPC support for qemu-kvm

2009-05-01 Thread Hollis Blanchard
These patches fix a number of issues with PowerPC builds of qemu-kvm.git. However, even after applying these patches it still doesn't build, due to confusion with KVM_UPSTREAM and CONFIG_KVM. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@v

[PATCH 1/5] [libkvm] Rename config-powerpc to config-ppc

2009-05-01 Thread Hollis Blanchard
Apparently $(ARCH) now holds the qemu meaning, rather than the KVM meaning. Signed-off-by: Hollis Blanchard --- kvm/libkvm/config-powerpc.mak |4 kvm/libkvm/config-ppc.mak |4 2 files changed, 4 insertions(+), 4 deletions(-) delete mode 100644 kvm/libkvm/config

Re: qemu-kvm.git now live

2009-05-01 Thread Hollis Blanchard
On Wed, 2009-04-29 at 11:31 +0300, Avi Kivity wrote: > Hollis Blanchard wrote: > >> Since PPC is now supported in upstream QEMU, does it really matter if it > >> works in qemu-kvm.git? > >> > > > > I was going to take that position too, except Av

Re: qemu-kvm.git now live

2009-05-01 Thread Hollis Blanchard
7; for now, but obviously that doesn't help with future changes to these headers. Defining a process for updating those headers would be useful. I'll send patches separately. -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] Revert "Sync idcache after emualted DMA operations for ia64"

2009-05-01 Thread Hollis Blanchard
This reverts commit 9dc99a28236161a5a1b4c58f1e9c4ec6179cb976. Aside from the other issues discussed on kvm-devel, this commit breaks the PowerPC build. Signed-off-by: Hollis Blanchard --- Bad mailing list address on my previous mail. cache-utils.h | 14 -- cutils.c |3

Re: [PATCH 16/21] Remove clean rule change

2009-04-30 Thread Hollis Blanchard
> > clean: > > - rm -f $(TARGETS) *.o *~ *.dtb > > + rm -f $(TARGETS) *.o *~ > > > > Hollis? dtb is the compiled (binary) form of dts (source) device tree files. Think of it like bios.bin: if make clean doesn't delete bios.bin (and it looks like it doesn

Re: [PATCH 10/21] Remove IBM copyright in unmodified file in upstream

2009-04-29 Thread Hollis Blanchard
7 Jocelyn Mayer > * > - * Copyright 2008 IBM Corp. > - * Authors: Hollis Blanchard > - * > * Permission is hereby granted, free of charge, to any person obtaining a > copy > * of this software and associated documentation files (the "Software"), to > deal

Re: qemu-kvm.git now live

2009-04-28 Thread Hollis Blanchard
ckage a KVM enabled qemu-system-ppcemb, do they? The more people who notice when the PowerPC build breaks, the better. -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.or

Re: qemu-kvm.git now live

2009-04-28 Thread Hollis Blanchard
On Tue, 2009-04-28 at 17:20 -0500, Anthony Liguori wrote: > Hollis Blanchard wrote: > > On Thu, 2009-04-23 at 18:40 +0300, Avi Kivity wrote: > > > >> Still missing: > >> - I have not tested powerpc or ia64. Patches welcome! > >> > > > >

Re: qemu-kvm.git now live

2009-04-28 Thread Hollis Blanchard
st cp from a Linux tree, or must I add funny ifdefs somehow? Here's one patch that I think will be needed: Set kvm_arch=powerpc for PPC builds. The name of the Linux arch directory is "powerpc", not "ppc". Signed-off-by: Hollis Blanchard diff --git a/configure b/co

RE: [PATCH] kvm: qemu: Sync idcache after emualted DMA operations for ia64

2009-04-24 Thread Hollis Blanchard
ures (e.g. PowerPC) *don't* implement qemu_sync_idcache(). Are you starting to understand my objections to this patch? -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] kvm: qemu: Sync idcache after emualted DMA operations for ia64

2009-04-22 Thread Hollis Blanchard
On Wed, 2009-04-22 at 09:59 +0800, Zhang, Xiantao wrote: > Hollis Blanchard wrote: > > On Tue, 2009-04-21 at 20:21 +0300, Avi Kivity wrote: > >> Hollis Blanchard wrote: > >>> On Tue, 2009-04-21 at 10:08 +, Avi Kivity wrote: > >>> > >>>

Re: [PATCH] kvm: qemu: Sync idcache after emualted DMA operations for ia64

2009-04-21 Thread Hollis Blanchard
On Tue, 2009-04-21 at 20:21 +0300, Avi Kivity wrote: > Hollis Blanchard wrote: > > On Tue, 2009-04-21 at 10:08 +, Avi Kivity wrote: > > > >> From: Xiantao Zhang > >> > >> ia64 depends on platform provides synced idcache after DMA operation. > &

Re: [PATCH] kvm: qemu: Sync idcache after emualted DMA operations for ia64

2009-04-21 Thread Hollis Blanchard
igned-off-by: Avi Kivity I pointed out some problems with this patch a couple weeks ago: http://article.gmane.org/gmane.comp.emulators.kvm.devel/30475 Why was it still applied? -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe kvm

Re: KVM Port

2009-04-06 Thread Hollis Blanchard
re the processor expert... :) Qemu calls into KVM via an ioctl, and processor-specific KVM code (that's you) somehow jumps into guest mode. -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message t

Re: [PATCH] KVM: Qemu: Flush i-cache after ide-dma operation in IA64

2009-04-06 Thread Hollis Blanchard
gt; +qemu_sync_idcache((unsigned long)qiov->iov[i].iov_base, > +(unsigned long)(qiov->iov[i].iov_base + copy)); > p += copy; > count -= copy; > } This is way too generic a call for this location. Other architectures also ne

Re: new wiki missing pages?

2009-03-11 Thread Hollis Blanchard
On Wednesday 11 March 2009 04:05:10 Avi Kivity wrote: > Hollis Blanchard wrote: > > Hi, I notice the old wiki has been replaced with > > http://www.linux-kvm.org/ ... unfortunately it seems to be missing *all* > > PowerPC information. Can this be recovered please? > > &g

Re: new wiki missing pages? / new wiki for kvm

2009-03-10 Thread Hollis Blanchard
eventually we'll have a shared userspace executable. That would be great! First we'll need a working qemu wiki though... maybe you can solve that problem at the same time. What timeframe are we talking about? Next week? 6 months? Just a brainstorm? -- Hollis Blanchard IBM Linux Technology

new wiki missing pages?

2009-03-10 Thread Hollis Blanchard
Hi, I notice the old wiki has been replaced with http://www.linux-kvm.org/ ... unfortunately it seems to be missing *all* PowerPC information. Can this be recovered please? I have no idea what other pages may be missing. -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from

Re: kvm-userspace build break (linux/types.h)

2009-02-20 Thread Hollis Blanchard
On Fri, 2009-02-20 at 09:44 -0600, Hollis Blanchard wrote: > > Avi, would you pull kvm-userspace > 05acb1ae99a8b55c9745f2e566010213cf52a819 into maint/2.6.29 branch > please? Also needed in maint/2.6.29: commit 3f7cba35281a5b2dba008179a4979d737105574d Author: Avi Kivity Date: T

Re: kvm-userspace build break (linux/types.h)

2009-02-20 Thread Hollis Blanchard
On Fri, 2009-02-20 at 10:42 +0530, Jaswinder Singh Rajput wrote: > On Thu, 2009-02-19 at 15:50 -0600, Hollis Blanchard wrote: > > A recent kernel merge breaks kvm-userspace build: > > make[1]: Entering directory `/root/hollisb/kvm-userspace.git/libkvm' > >

kvm-userspace build break (linux/types.h)

2009-02-19 Thread Hollis Blanchard
ended ../kernel/include/linux/types.h. Avi, suggestions? More "make sync" hacks? -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info a

Re: [PATCH] use KVM_UPSTREAM for ppc.

2009-02-13 Thread Hollis Blanchard
kvm.h and qemu-kvm.h, > and would break compilation. > > Signed-off-by: Glauber Costa I actually haven't tried to build kvm-userspace for PPC since we got upstream qemu working... I'm a little confused though, because it doesn't look like even x86 is using this? -- Holli

Re: e500 KVM build fixes for 2.6.29

2009-01-15 Thread Hollis Blanchard
On Thu, 2009-01-15 at 11:36 +0200, Avi Kivity wrote: > Hollis Blanchard wrote: > > Avi, these patches fix build issues in the new e500 code. Please apply for > > 2.6.29. Thanks! > > > > Applied for 2.6.30, but e500 isn't in 2.6.29? My mistake. Thanks!

[PATCH 2/3] Subject: kvm: ppc: Fix e500 warnings and some spelling problems

2009-01-14 Thread Hollis Blanchard
From: Liu Yu --- arch/powerpc/kvm/e500_emulate.c |2 -- arch/powerpc/kvm/e500_tlb.c |6 +++--- arch/powerpc/kvm/e500_tlb.h |2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/kvm/e500_emulate.c b/arch/powerpc/kvm/e500_emulate.c index d3c0c7c..7a

[PATCH 3/3] Subject: kvm: ppc: Move to new TLB invalidate interface

2009-01-14 Thread Hollis Blanchard
From: Liu Yu Commit 2a4aca1144394653269720ffbb5a325a77abd5fa removed old method _tlbia(). Signed-off-by: Liu Yu Signed-off-by: Hollis Blanchard --- arch/powerpc/kvm/e500_tlb.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/kvm/e500_tlb.c b/arch

[PATCH 1/3] Subject: powerpc/fsl-booke: declare tlbcam_index for use in c

2009-01-14 Thread Hollis Blanchard
From: Liu Yu So, KVM needs to read tlbcam_index to know exactly which TLB1 entry is unused by host. Signed-off-by: Liu Yu Acked-by: Kumar Gala Signed-off-by: Hollis Blanchard --- arch/powerpc/include/asm/mmu-fsl-booke.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

e500 KVM build fixes for 2.6.29

2009-01-14 Thread Hollis Blanchard
Avi, these patches fix build issues in the new e500 code. Please apply for 2.6.29. Thanks! -Hollis -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] [v2] KVM: PowerPC: Disarm old guest debug interface

2009-01-04 Thread Hollis Blanchard
ode doesn't even build any more. Signed-off-by: Hollis Blanchard diff --git a/arch/powerpc/include/asm/kvm_host.h b/arch/powerpc/include/asm/kvm_host.h index 1c61876..dfdf13c 100644 --- a/arch/powerpc/include/asm/kvm_host.h +++ b/arch/powerpc/include/asm/kvm_host.h @@ -111,11 +111,6 @@ stru

Re: [PATCH] KVM: PowerPC: Disarm old guest debug interface

2009-01-03 Thread Hollis Blanchard
ite After the rewrite of KVM's debug support, this code doesn't even build any more. Signed-off-by: Hollis Blanchard diff --git a/arch/powerpc/include/asm/kvm_host.h b/arch/powerpc/include/asm/kvm_host.h --- a/arch/powerpc/include/asm/kvm_host.h +++ b/arch/powerpc/include/asm/kvm_h

[PATCH] avoid kvm-userspace merge conflict with PowerPC KVM support in qemu

2008-12-16 Thread Hollis Blanchard
PowerPC KVM support was accepted into upstream qemu. To ease the merge conflicts, you should apply this patch to remove all traces of PowerPC KVM code from kvm-userspace before the next qemu pull. Signed-off-by: Hollis Blanchard --- You'll also want to remove qemu/pc-bios/bamboo.dtb, wh

Re: kvm-userspace requires kvm capable kernel headers in default search path of the compiler

2008-12-11 Thread Hollis Blanchard
This seems wrong to me, and also contradicts the "building an external module with older kernels" directions at http://kvm.qumranet.com/kvmwiki/Code . Avi, did something in the build procedure break recently? -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from th

Re: [PATCH] [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu gdbstub

2008-12-11 Thread Hollis Blanchard
On Thu, 2008-12-11 at 17:05 +0100, Jan Kiszka wrote: > Hollis Blanchard wrote: > > On Thu, 2008-12-11 at 13:53 +0100, Christian Ehrhardt wrote: > >> This is v2 as version one had a type in it occured when splitting patches. > >> Mercurial somehow lost my changes to the p

Re: [PATCH] KVM: use modern cpumask primitives, no cpumask_t on stack

2008-12-11 Thread Hollis Blanchard
s); > return called; > } This patch breaks uniprocessor builds, because smp_call_function_many() is only defined for CONFIG_SMP. Avi, I think you should be able to build a PowerPC KVM kernel at this point? That would have caught this error. Rusty, could you ack the following: cpumask:

Re: [PATCH] [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu gdbstub

2008-12-11 Thread Hollis Blanchard
KVM PowerPC support for qemu gdbstub > > > > From: Hollis Blanchard <[EMAIL PROTECTED]> > > > > Add basic KVM PowerPC support to qemu's gdbstub introducing a kvm ppc style > > mmu implementation that uses the kvm_translate ioctl. > > This also requires to save

Re: Fwd: how to compile kvm 64 bit

2008-12-05 Thread Hollis Blanchard
rch=i686-mcpu=i686-malign-functions=4 -O2 -m64 > >> -D__x86_64__ -MMD -MF ./.libkvm-x86.d -g -fomit-frame-pointer -Wall > >> -fno-stack-protector -I /usr/src/kvm-79/kernel/include -c -o > >> libkvm-x86.o libkvm-x86.c > > but the Makefile is wrong I don't

Re: [Qemu-devel] [5874] Add virtio-balloon support

2008-12-04 Thread Hollis Blanchard
nd use that size instead of alloc_page() in the guest? -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0 of 6] PowerPC KVM patches for 2.6.29

2008-12-03 Thread Hollis Blanchard
On Wed, 2008-12-03 at 13:22 -0600, Hollis Blanchard wrote: > On Wed, 2008-12-03 at 19:06 +0200, Avi Kivity wrote: > > Hollis Blanchard wrote: > > > > > >> I'm not thrilled about the private exit timing statistics gathering, > > >> hopefully it

Re: [PATCH 0 of 6] PowerPC KVM patches for 2.6.29

2008-12-03 Thread Hollis Blanchard
On Wed, 2008-12-03 at 19:06 +0200, Avi Kivity wrote: > Hollis Blanchard wrote: > > > >> I'm not thrilled about the private exit timing statistics gathering, > >> hopefully it can be morphed into the more general framework. > >> > > > >

[PATCH 5/5] user: ppc: Add "hello world" test for libcflat

2008-12-03 Thread Hollis Blanchard
From: Deepa Srinivasan <[EMAIL PROTECTED]> Add a test program ("hello world") to exercise printf() in libcflat. Signed-off-by: Deepa Srinivasan <[EMAIL PROTECTED]> Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> --- user/config-powerpc.mak|3 ++- us

kvm-userspace ppc fixes

2008-12-03 Thread Hollis Blanchard
Hi Avi, among these patches are fixes for a number of bugs in kvm-userspace, including the qemu build break and bugs in the "user" directory. Please apply. -Hollis -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH 1/5] qemu: add dyngen dependency from upstream

2008-12-03 Thread Hollis Blanchard
Fixes PowerPC kvm-userspace build. Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> --- qemu/Makefile.target |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/qemu/Makefile.target b/qemu/Makefile.target index 05ace8e..bb24cc0 100644 --- a/qemu/Makefile.target +++

[PATCH 3/5] user: ppc: Fix guest load address

2008-12-03 Thread Hollis Blanchard
From: Deepa Srinivasan <[EMAIL PROTECTED]> Test cases must be loaded at 1 MB, their link address. Signed-off-by: Deepa Srinivasan <[EMAIL PROTECTED]> Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> --- user/main-ppc.c | 13 +++-- 1 files changed, 11 insertio

[PATCH 2/5] user: ppc: fix build break caused by changes to kvm_callbacks

2008-12-03 Thread Hollis Blanchard
Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> --- user/main-ppc.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/user/main-ppc.c b/user/main-ppc.c index c4ddcef..5fdf28e 100644 --- a/user/main-ppc.c +++ b/user/main-ppc.c @@ -69,7 +69,7 @@ stat

[PATCH 4/5] user: ppc: Move -ffreestanding to the right location

2008-12-03 Thread Hollis Blanchard
From: Deepa Srinivasan <[EMAIL PROTECTED]> Move the "-ffreestanding" compiler option (to avoid built-in functions) to the correct place in the Makefile. Signed-off-by: Deepa Srinivasan <[EMAIL PROTECTED]> Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> --- us

Re: powerpc kvm-userspace build fixes

2008-12-03 Thread Hollis Blanchard
On Wed, 2008-12-03 at 13:05 +0200, Avi Kivity wrote: > Hollis Blanchard wrote: > > I'm also seeing a build dependency issue with dyngen-opc.h that I don't see > > upstream. I haven't sorted that out yet, but "make > > qemu/ppcemb-softmmu/dyn

Re: [PATCH 0 of 6] PowerPC KVM patches for 2.6.29

2008-12-03 Thread Hollis Blanchard
On Wed, 2008-12-03 at 13:32 +0200, Avi Kivity wrote: > Hollis Blanchard wrote: > > Hi Avi, here's the latest batch of PowerPC kernel patches. > > > > The first set dramatically improve performance. Most importantly, we add > > support for large host pages with KV

Re: [BUG] virtio-pci queue allocation not page-aligned

2008-12-02 Thread Hollis Blanchard
On Wed, 2008-12-03 at 08:35 +1030, Rusty Russell wrote: > On Wednesday 03 December 2008 05:38:21 Hollis Blanchard wrote: > > I just spent a number of hours tracking this one down, and I'm not too > > thrilled about it. vp_find_vq() does the memory allocation for virtio > &

[PATCH 5 of 6] kvm: ppc: Implement in-kernel exit timing statistics

2008-12-02 Thread Hollis Blanchard
tian Ehrhardt <[EMAIL PROTECTED]> Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> diff --git a/arch/powerpc/include/asm/kvm_host.h b/arch/powerpc/include/asm/kvm_host.h --- a/arch/powerpc/include/asm/kvm_host.h +++ b/arch/powerpc/include/asm/kvm_host.h @@ -71,6 +71,49 @@ struct

[PATCH 0 of 6] PowerPC KVM patches for 2.6.29

2008-12-02 Thread Hollis Blanchard
Hi Avi, here's the latest batch of PowerPC kernel patches. The first set dramatically improve performance. Most importantly, we add support for large host pages with KVM (i.e. PAGE_SHIFT > 12). (Large *guest* pages have already been supported since day 1, since the guest kernel uses them for the l

[PATCH 6 of 6] kvm: ppc: mostly cosmetic updates to the exit timing accounting code

2008-12-02 Thread Hollis Blanchard
The only significant changes were to kvmppc_exit_timing_write() and kvmppc_exit_timing_show(), both of which were dramatically simplified. Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> diff --git a/arch/powerpc/include/asm/kvm_host.h b/arch/powerpc/include/asm/kvm_host.h ---

[PATCH 1 of 6] kvm: ppc: support large host pages

2008-12-02 Thread Hollis Blanchard
KVM on 440 has always been able to handle large guest mappings with 4K host pages -- we must, since the guest kernel uses 256MB mappings. This patch makes KVM work when the host has large pages too (tested with 64K). Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> diff --git a/arch/p

[PATCH 2 of 6] powerpc/44x: declare tlb_44x_index for use in C code

2008-12-02 Thread Hollis Blanchard
mance improvement, since that processing currently must be done on *every* guest exit. Accordingly, KVM needs to be able to access and increment tlb_44x_index. (KVM on 440 cannot be a module, so there is no need to export this symbol.) Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> Acked-by:

[PATCH 4 of 6] kvm: ppc: save and restore guest mappings on context switch

2008-12-02 Thread Hollis Blanchard
Store shadow TLB entries in memory, but only use it on host context switch (instead of every guest entry). This improves performance for most workloads on 440 by reducing the guest TLB miss rate. Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> diff --git a/arch/powerpc/include/asm/kvm

[PATCH 3 of 6] kvm: ppc: directly insert shadow mappings into the hardware TLB

2008-12-02 Thread Hollis Blanchard
that and to the code simplification, we have a greater chance of leaving other host userspace mappings in the TLB, instead of forcing all subsequent tasks to re-fault all their mappings. Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> diff --git a/arch/powerpc/include/asm/kvm_44x.h

[BUG] virtio-pci queue allocation not page-aligned

2008-12-02 Thread Hollis Blanchard
existing allocator could mean that "ordinary" allocations also become non-page-aligned. Finally, we could use the interface intended for exactly this purpose: the page allocator. If there's some problem with high memory, don't allocate it with GFP_HIGHMEM. -- Hollis Blanc

[PATCH 1/2] qemu: ppc: fix build after qemu upstream changes

2008-12-02 Thread Hollis Blanchard
Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> --- qemu/hw/ppc440_bamboo.c | 37 + 1 files changed, 21 insertions(+), 16 deletions(-) diff --git a/qemu/hw/ppc440_bamboo.c b/qemu/hw/ppc440_bamboo.c index bf42245..79e4ea8 100644 --- a/q

powerpc kvm-userspace build fixes

2008-12-02 Thread Hollis Blanchard
These patches fix the kvm-userspace qemu build after a recent merge with upstream qemu. I'm also seeing a build dependency issue with dyngen-opc.h that I don't see upstream. I haven't sorted that out yet, but "make qemu/ppcemb-softmmu/dyngen-opc.h" first works around the problem. -Hollis -- To

[PATCH 2/2] qemu: ppc: fix build warnings

2008-12-02 Thread Hollis Blanchard
Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> --- qemu/hw/device_tree.c | 14 +++--- qemu/hw/device_tree.h | 12 ++-- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/qemu/hw/device_tree.c b/qemu/hw/device_tree.c index e73129d..2621ff1 100644 ---

Re: [PATCH] KVM: Qemu: push_nmi should be only used by I386 Arch.

2008-12-01 Thread Hollis Blanchard
would get his PPC box working so he could catch build breaks like these. Cross-compilers would do as well. I would also like a pony. > > Avi, could you revert a8d12f98755be9330fcde055134511f76ecaa538 please? > > > > Here is a patch that reverts change and fixes the root of

  1   2   3   >