On 2015年12月30日 00:46, Michael S. Tsirkin wrote:
> Interesting. So you sare saying merely ifdown/ifup is 100ms?
> This does not sound reasonable.
> Is there a chance you are e.g. getting IP from dhcp?
>
> If so that is wrong - clearly should reconfigure the old IP
> back without playing with dhcp.
On 12/25/2015 8:11 PM, Michael S. Tsirkin wrote:
As long as you keep up this vague talk about performance during
migration, without even bothering with any measurements, this patchset
will keep going nowhere.
I measured network service downtime for "keep device alive"(RFC patch V1
Merry Christmas.
Sorry for later response due to personal affair.
On 2015年12月14日 03:30, Alexander Duyck wrote:
>> > These sounds we need to add a faked bridge for migration and adding a
>> > driver in the guest for it. It also needs to extend PCI bus/hotplug
>> > driver to do pause/resume other
On 12/11/2015 1:16 AM, Alexander Duyck wrote:
On Thu, Dec 10, 2015 at 6:38 AM, Lan, Tianyu <tianyu@intel.com> wrote:
On 12/10/2015 7:41 PM, Dr. David Alan Gilbert wrote:
Ideally, it is able to leave guest driver unmodified but it requires the
hypervisor or qemu to aware the
On 12/11/2015 12:11 AM, Michael S. Tsirkin wrote:
On Thu, Dec 10, 2015 at 10:38:32PM +0800, Lan, Tianyu wrote:
On 12/10/2015 7:41 PM, Dr. David Alan Gilbert wrote:
Ideally, it is able to leave guest driver unmodified but it requires the
hypervisor or qemu to aware the device which means
On 12/10/2015 4:38 PM, Michael S. Tsirkin wrote:
Let's assume you do save state and do have a way to detect
whether state matches a given hardware. For example,
driver could store firmware and hardware versions
in the state, and then on destination, retrieve them
and compare. It will be pretty
On 12/10/2015 7:41 PM, Dr. David Alan Gilbert wrote:
Ideally, it is able to leave guest driver unmodified but it requires the
>hypervisor or qemu to aware the device which means we may need a driver in
>hypervisor or qemu to handle the device on behalf of guest driver.
Can you answer the
On 12/8/2015 1:12 AM, Alexander Duyck wrote:
On Mon, Dec 7, 2015 at 7:40 AM, Lan, Tianyu <tianyu@intel.com> wrote:
On 12/5/2015 1:07 AM, Alexander Duyck wrote:
We still need to support Windows guest for migration and this is why our
patches keep all changes in the driver sinc
On 12/9/2015 6:37 PM, Michael S. Tsirkin wrote:
On Sat, Dec 05, 2015 at 12:32:00AM +0800, Lan, Tianyu wrote:
Hi Michael & Alexander:
Thanks a lot for your comments and suggestions.
It's nice that it's appreciated, but you then go on and ignore
all that I have written here:
https://www.
On 12/9/2015 7:28 PM, Michael S. Tsirkin wrote:
I remember reading that it's possible to implement a bus driver
on windows if required. But basically I don't see how windows can be
relevant to discussing guest driver patches. That discussion
probably belongs on the qemu maling list, not on
On 12/8/2015 12:50 AM, Michael S. Tsirkin wrote:
I thought about what this is doing at the high level, and I do have some
value in what you are trying to do, but I also think we need to clarify
the motivation a bit more. What you are saying is not really what the
patches are doing.
And with
On 12/10/2015 1:14 AM, Alexander Duyck wrote:
On Wed, Dec 9, 2015 at 8:26 AM, Lan, Tianyu <tianyu@intel.com> wrote:
For other kind of devices, it's hard to work.
We are also adding migration support for QAT(QuickAssist Technology) device.
QAT device user case introduction.
On 12/10/2015 4:07 AM, Michael S. Tsirkin wrote:
On Thu, Dec 10, 2015 at 12:26:25AM +0800, Lan, Tianyu wrote:
On 12/8/2015 12:50 AM, Michael S. Tsirkin wrote:
I thought about what this is doing at the high level, and I do have some
value in what you are trying to do, but I also think we need
On 12/5/2015 1:07 AM, Alexander Duyck wrote:
We still need to support Windows guest for migration and this is why our
patches keep all changes in the driver since it's impossible to change
Windows kernel.
That is a poor argument. I highly doubt Microsoft is interested in
having to modify all
On 12/4/2015 4:05 PM, Michael S. Tsirkin wrote:
I haven't read it, but I would like to note you can't rely on research
papers. If you propose a patch to be merged you need to measure what is
its actual effect on modern linux at the end of 2015.
Sure. Will do that.
--
To unsubscribe from this
Hi Michael & Alexander:
Thanks a lot for your comments and suggestions.
We still need to support Windows guest for migration and this is why our
patches keep all changes in the driver since it's impossible to change
Windows kernel.
Following is my idea to do DMA tracking.
Inject event to VF
On 12/2/2015 10:31 PM, Michael S. Tsirkin wrote:
>We hope
>to find a better way to make SRIOV NIC work in these cases and this is
>worth to do since SRIOV NIC provides better network performance compared
>with PV NIC.
If this is a performance optimization as the above implies,
you need to
On 12/3/2015 6:25 AM, Alex Williamson wrote:
On Tue, 2015-11-24 at 21:35 +0800, Lan Tianyu wrote:
This patch is to add SRIOV VF migration support.
Create new device type "vfio-sriov" and add faked PCI migration capability
to the type device.
The purpose of the new capabili
On 12/3/2015 6:25 AM, Alex Williamson wrote:
This will of course break if the PCI SIG defines that capability index.
Couldn't this be done within a vendor defined capability? Thanks,
Yes, it should work and thanks for suggestion.
--
To unsubscribe from this list: send the line "unsubscribe
On 12/3/2015 6:25 AM, Alex Williamson wrote:
I didn't seen a matching kernel patch series for this, but why is the
kernel more capable of doing this than userspace is already?
The following link is the kernel patch.
http://marc.info/?l=kvm=144837328920989=2
These seem
like pointless ioctls,
On 12/2/2015 10:31 PM, Michael S. Tsirkin wrote:
>We hope
>to find a better way to make SRIOV NIC work in these cases and this is
>worth to do since SRIOV NIC provides better network performance compared
>with PV NIC.
If this is a performance optimization as the above implies,
you need to
On 12/1/2015 11:02 PM, Michael S. Tsirkin wrote:
But
it requires guest OS to do specific configurations inside and rely on
bonding driver which blocks it work on Windows.
From performance side,
putting VF and virtio NIC under bonded interface will affect their
performance even when not do
On 12/1/2015 12:07 AM, Alexander Duyck wrote:
They can only be corrected if the underlying assumptions are correct
and they aren't. Your solution would have never worked correctly.
The problem is you assume you can keep the device running when you are
migrating and you simply cannot. At some
On 11/30/2015 4:01 PM, Michael S. Tsirkin wrote:
It is still not very clear what it is you are trying to achieve, and
whether your patchset achieves it. You merely say "adding live
migration" but it seems pretty clear this isn't about being able to
migrate a guest transparently, since you are
On 11/26/2015 11:56 AM, Alexander Duyck wrote:
> I am not saying you cannot modify the drivers, however what you are
doing is far too invasive. Do you seriously plan on modifying all of
the PCI device drivers out there in order to allow any device that
might be direct assigned to a port to
On 11/25/2015 8:28 PM, Michael S. Tsirkin wrote:
Frankly, I don't really see what this short term hack buys us,
and if it goes in, we'll have to maintain it forever.
The framework of how to notify VF about migration status won't be
changed regardless of stopping VF or not before doing
On 11/25/2015 5:03 AM, Michael S. Tsirkin wrote:
>+void vfio_migration_cap_handle(PCIDevice *pdev, uint32_t addr,
>+ uint32_t val, int len)
>+{
>+VFIOPCIDevice *vdev = DO_UPCAST(VFIOPCIDevice, pdev, pdev);
>+
>+if (addr == vdev->migration_cap +
On 2015年11月25日 13:30, Alexander Duyck wrote:
> No, what I am getting at is that you can't go around and modify the
> configuration space for every possible device out there. This
> solution won't scale.
PCI config space regs are emulation by Qemu and so We can find the free
PCI config space
On 2015年11月24日 22:20, Alexander Duyck wrote:
> I'm still not a fan of this approach. I really feel like this is
> something that should be resolved by extending the existing PCI hot-plug
> rather than trying to instrument this per driver. Then you will get the
> goodness for multiple drivers and
On 2015年11月25日 05:20, Michael S. Tsirkin wrote:
> I have to say, I was much more interested in the idea
> of tracking dirty memory. I have some thoughts about
> that one - did you give up on it then?
No, our finial target is to keep VF active before doing
migration and tracking dirty memory is
irq won't be
triggered and VF driver will disable it via PCI_VF_MIGRATION_CAP
reg. These case will be resolved later.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 ++
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
This patch is to add new ioctl cmd VFIO_GET_PCI_CAP_INFO to get
PCI cap table size and get free PCI config space regs according
pos and size.
Qemu will add faked PCI capability for migration and need such
info.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
drivers/vfio/pci/vfio
migration status in the reg
*PCI_VF_MIGRATION_VF_STATUS
VF driver tells Qemu ready for migration
*PCI_VF_MIGRATION_IRQ
VF driver stores mailbox interrupt vector in the reg for Qemu to trigger during
migration.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
include/uapi/linux/pci_regs.
_VF_STATUS in the new cap table
to tell Qemu.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
hw/vfio/Makefile.objs | 2 +-
hw/vfio/pci.c | 6 ++
hw/vfio/pci.h | 4 ++
hw/vfio/sriov.c | 178 ++
4 files changed, 189
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
hw/vfio/pci.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index e7583b5..404a5cd 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3625,11 +3625,6 @@ static Property vfio_pci_dev_prop
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
hw/vfio/pci.c | 137 +-
hw/vfio/pci.h | 158 ++
2 files changed, 159 insertions(+), 136 deletions(-)
create mode 100644 hw/vfio/pci.h
before migration and put up again on
the target machine.
Lan Tianyu (10):
Qemu/VFIO: Create head file pci.h to share data struct.
Qemu/VFIO: Add new VFIO_GET_PCI_CAP_INFO ioctl cmd definition
Qemu/VFIO: Rework vfio_std_cap_max_size() function
Qemu/VFIO: Add vfio_find_free_cfg_reg() to find
capability and occupy some free PCI config space
regs.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
hw/vfio/pci.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 5c3f8a7..29845e3 100644
--- a/hw/vfio/pci.c
++
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
linux-headers/linux/vfio.h | 16
1 file changed, 16 insertions(+)
diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h
index 0508d0b..732b0bd 100644
--- a/linux-headers/linux/vfio.h
+++ b/linux-headers
-by: Lan Tianyu <tianyu@intel.com>
---
include/migration/vmstate.h | 2 ++
migration/savevm.c | 15 +++
2 files changed, 17 insertions(+)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 0695d7c..dc681a6 100644
--- a/include/migration/vmstate.h
before migration and put up again on
the target machine.
Lan Tianyu (3):
VFIO: Add new ioctl cmd VFIO_GET_PCI_CAP_INFO
PCI: Add macros for faked PCI migration capability
Ixgbevf: Add migration support for ixgbevf driver
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 ++
drivers/net
This patch is to add a callback which is called just before stopping VCPU.
It's for VF migration to trigger mailbox irq as later as possible to
decrease service downtime.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
include/migration/vmstate.h | 3 +++
include/sysemu/sysemu.h
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
hw/vfio/pci.c | 6 +++---
hw/vfio/pci.h | 4
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index d0354a0..7c43fc1 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -613,7 +613,7 @@ stati
This patch is to add ioctl wrap to find free PCI config sapce regs.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
hw/vfio/pci.c | 19 +++
hw/vfio/pci.h | 2 ++
2 files changed, 21 insertions(+)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 29845e3..d0354a0
migration status in the reg
*PCI_VF_MIGRATION_VF_STATUS
VF driver tells Qemu ready for migration
*PCI_VF_MIGRATION_IRQ
VF driver stores mailbox interrupt vector in the reg for Qemu to trigger during
migration.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
include/hw/pci/pci_regs.
On 2015年10月26日 23:03, Alexander Duyck wrote:
> No. I think you are missing the fact that there are 256 descriptors per
> page. As such if you dirty just 1 you will be pulling in 255 more, of
> which you may or may not have pulled in the receive buffer for.
>
> So for example if you have the
On 2015年10月29日 14:58, Alexander Duyck wrote:
>
> Your code was having to do a bunch of shuffling in order to get things
> set up so that you could bring the interface back up. I would argue
> that it may actually be faster at least on the bring-up to just drop the
> old rings and start over
On 2015年10月30日 00:17, Alexander Duyck wrote:
> On 10/29/2015 01:33 AM, Lan Tianyu wrote:
>> On 2015年10月29日 14:58, Alexander Duyck wrote:
>>> Your code was having to do a bunch of shuffling in order to get things
>>> set up so that you could bring the interf
On 10/22/2015 4:45 AM, Alexander Duyck wrote:
+/* Record states hold by PF */
+memcpy(>vf_data, >vfinfo[vfn], sizeof(struct
vf_data_storage));
+
+vf_shift = vfn % 32;
+reg_offset = vfn / 32;
+
+reg = IXGBE_READ_REG(hw, IXGBE_VFTE(reg_offset));
+reg &= ~(1 << vf_shift);
On 10/25/2015 2:03 PM, Alexander Duyck wrote:
On 10/24/2015 08:43 AM, Lan, Tianyu wrote:
On 10/22/2015 4:52 AM, Alexander Duyck wrote:
Also have you even considered the MSI-X configuration on the VF? I
haven't seen anything anywhere that would have migrated the VF's MSI-X
configuration
On 2015年10月24日 02:36, Alexander Duyck wrote:
> I was thinking about it and I am pretty sure the dummy write approach is
> problematic at best. Specifically the issue is that while you are
> performing a dummy write you risk pulling in descriptors for data that
> hasn't been dummy written to yet.
On 10/22/2015 4:52 AM, Alexander Duyck wrote:
Also have you even considered the MSI-X configuration on the VF? I
haven't seen anything anywhere that would have migrated the VF's MSI-X
configuration from BAR 3 on one system to the new system.
MSI-X migration is done by Hypervisor(Qemu).
On 10/22/2015 5:14 AM, Alexander Duyck wrote:
Where is i being initialized? It was here but you removed it. Are you
using i without initializing it?
Sorry, the initialization was put into patch 10 by mistake. "i" is
assigned with "tx_ring->next_to_clean".
--
To unsubscribe from this list:
On 10/22/2015 2:07 AM, Alexander Duyck wrote:
On 10/21/2015 09:37 AM, Lan Tianyu wrote:
Add "virtfn_index" member in the struct pci_device to record VF sequence
of PF. This will be used in the VF sysfs node handle.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
d
On 10/22/2015 8:58 PM, Michael S. Tsirkin wrote:
Do you really need to play the shifting games?
Can't you just reset everything and re-initialize the rings?
It's slower but way less intrusive.
Also removes the need to track writes into rings.
Shift ring is to avoid losing those packets in
erface is up or open.
Call existed function to update base and saved_reset data to keep statistic
data continual during migration.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/
Add "virtfn_index" member in the struct pci_device to record VF sequence
of PF. This will be used in the VF sysfs node handle.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
drivers/pci/iov.c | 1 +
include/linux/pci.h | 1 +
2 files changed, 2 insertions(+)
diff --g
===
So far, the patchset isn't perfect. VF net interface can't be open, closed,
down
and up during migration. Will prevent such operation during migration in the
future job.
Very appreciate for your comments.
Lan Tianyu (12):
PCI: Add virtfn_index for struct pci_device
IXGBE: Add new mail
is to replace recording
pointer with recording the desc number of the package and find
the end decs via the first desc and desc number.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 1 +
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.
of the ring and then enable tx/rx rings. VF restarts to
receive and transmit from original head desc.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
drivers/net/ethernet/intel/ixgbevf/defines.h | 6 ++
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 7 +-
drivers/ne
This patch is to add ixgbe_ping_vf() to notify a specified VF. When
migration status is changed, it's necessary to notify VF the change.
VF driver will check the migrate status when it gets mailbox msg.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
drivers/net/ethernet/intel
VF status in the PF driver needs to be restored after migration and reset
VF hardware. This patch is to add a new event for VF driver to notify PF
driver to restore status.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
drivers/net/ethernet/intel/ixgbevf/mbx.h | 3 +++
drive
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
hw/i386/kvm/pci-assign.c | 111 ++-
hw/i386/kvm/pci-assign.h | 109 ++
2 files changed, 112 insertions(+), 108 deletions(-)
create mode 100644 hw/i3
This patchset is Qemu part for live migration support for SRIOV NIC.
kernel part patch information is in the following link.
http://marc.info/?l=kvm=144544635330193=2
Lan Tianyu (3):
Qemu: Add pci-assign.h to share functions and struct definition with
new file
Qemu: Add post_load_state
In order to restore VF function after migration, add self emulation layer
to record regs' values during accessing regs.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
drivers/net/ethernet/intel/ixgbevf/Makefile| 3 ++-
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
-by: Lan Tianyu <tianyu@intel.com>
---
include/migration/vmstate.h | 2 ++
migration/savevm.c | 15 +++
2 files changed, 17 insertions(+)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 0695d7c..dc681a6 100644
--- a/include/migration/vmstate.h
Ring shifting during restoring VF function maybe race with original
ring operation(transmit/receive package). This patch is to add tx/rx
lock to protect ring related data.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 2 ++
drive
and write it back) during receive
and transmit data.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
b/d
This patch is to restore VF status in the PF driver when get event
from VF.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 +
drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 1 +
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.
This patch is to add sysfs interface state_in_pf under sysfs directory
of VF PCI device for Qemu to get and put VF status in the PF driver during
migration.
Signed-off-by: Lan Tianyu <tianyu@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 156 -
[ 95.096218] [81b6a72e] system_call_fastpath+0x12/0x76
[ 95.102974] ---[ end trace 08ade884081d9dd7 ]---
Link: https://bugzilla.kernel.org/show_bug.cgi?id=99861
Signed-off-by: Lan Tianyu tianyu@intel.com
---
arch/x86/kvm/x86.c | 16
1 file changed, 16 insertions
Add compiler.h file to support using kernel error check funciotns(e.g
ERR_PTR, PTR_ERR and so on).
Signed-off-by: Lan Tianyu tianyu@intel.com
---
tools/kvm/include/linux/compiler.h | 16
1 files changed, 16 insertions(+), 0 deletions(-)
create mode 100644 tools/kvm
This patch enables allocating new refcount blocks and so then kvm tools
could expand qcow2 image much larger.
Signed-off-by: Lan Tianyu tianyu@intel.com
---
tools/kvm/disk/qcow.c | 111 +---
1 files changed, 94 insertions(+), 17 deletions(-)
diff
oh，yeah. Thanks for your reply. It's a good lesson for me. :)
I will update soon.
On 二, 2011-12-13 at 16:57 +0800, Kevin Wolf wrote:
Am 13.12.2011 04:41, schrieb lan,Tianyu:
On 一, 2011-12-12 at 19:15 +0800, Kevin Wolf wrote:
Am 12.12.2011 11:58, schrieb Pekka Enberg:
On Mon, 12 Dec 2011
Thanks for your review.
On 一, 2011-12-12 at 17:55 +0800, Kevin Wolf wrote:
Am 12.12.2011 03:03, schrieb Lan Tianyu:
This patch enables allocating new refcount blocks and so then kvm tools
could expand qcow2 image much larger.
Signed-off-by: Lan Tianyu tianyu@intel.com
---
tools
On 一, 2011-12-12 at 18:58 +0800, Pekka Enberg wrote:
On Mon, 12 Dec 2011, Kevin Wolf wrote:
@@ -667,14 +722,11 @@ static struct qcow_refcount_block
*qcow_read_refcount_block(struct qcow *q, u64
rft_idx = clust_idx (header-cluster_bits -
QCOW_REFCOUNT_BLOCK_SHIFT);
if (rft_idx
On 一, 2011-12-12 at 19:15 +0800, Kevin Wolf wrote:
Am 12.12.2011 11:58, schrieb Pekka Enberg:
On Mon, 12 Dec 2011, Kevin Wolf wrote:
@@ -667,14 +722,11 @@ static struct qcow_refcount_block
*qcow_read_refcount_block(struct qcow *q, u64
rft_idx = clust_idx (header-cluster_bits -
This patch enables allocating new refcount blocks and so then kvm tools
could expand qcow2 image much larger.
Signed-off-by: Lan Tianyu tianyu@intel.com
---
tools/kvm/disk/qcow.c | 105 +---
1 files changed, 89 insertions(+), 16 deletions(-)
diff
. The performance is needed to be improved.
Signed-off-by: Lan Tianyu tianyu@intel.com
---
tools/kvm/disk/qcow.c| 454 ++
tools/kvm/include/kvm/qcow.h |2 +
2 files changed, 289 insertions(+), 167 deletions(-)
diff --git a/tools/kvm/disk/qcow.c b/tools
. The performance is needed to be improved.
Signed-off-by: Lan Tianyu tianyu@intel.com
---
tools/kvm/disk/qcow.c| 456 +++---
tools/kvm/include/kvm/qcow.h |2 +
2 files changed, 292 insertions(+), 166 deletions(-)
diff --git a/tools/kvm/disk/qcow.c b/tools
. The performance is needed to be improved.
Signed-off-by: Lan Tianyu tianyu@intel.com
---
tools/kvm/disk/qcow.c| 456 +++---
tools/kvm/include/kvm/qcow.h |2 +
2 files changed, 292 insertions(+), 166 deletions(-)
diff --git a/tools/kvm/disk/qcow.c b/tools
Yeah. I will fix them in the next version.
-Original Message-
From: penb...@gmail.com [mailto:penb...@gmail.com] On Behalf Of Pekka Enberg
Sent: Monday, November 21, 2011 5:06 PM
To: Lan, Tianyu
Cc: kvm@vger.kernel.org; asias.he...@gmail.com; levinsasha...@gmail.com;
prasadjoshi
. The performance is needed to be improved.
Signed-off-by: Lan Tianyu tianyu@intel.com
---
tools/kvm/disk/qcow.c| 421 +-
tools/kvm/include/kvm/qcow.h |2 +
2 files changed, 292 insertions(+), 131 deletions(-)
diff --git a/tools/kvm/disk/qcow.c b/tools
. The performance is needed to be improved.
Signed-off-by: Lan Tianyu tianyu@intel.com
---
tools/kvm/disk/qcow.c| 411 +-
tools/kvm/include/kvm/qcow.h |2 +
2 files changed, 285 insertions(+), 128 deletions(-)
diff --git a/tools/kvm/disk/qcow.c b/tools
How about using the sync_file_range to sync the metadata?
-Original Message-
From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf Of
Lan, Tianyu
Sent: Saturday, November 19, 2011 10:09 AM
To: Kevin Wolf
Cc: penb...@kernel.org; kvm@vger.kernel.org; asias.he
OK. Thx.
But fsync is too slow. I try to find a way to sync a range of file.
Are there any solutions to meet my purpose?
Thanks
Tianyu Lan
-Original Message-
From: Sasha Levin [mailto:levinsasha...@gmail.com]
Sent: Sunday, November 20, 2011 12:27 AM
To: Lan, Tianyu
Cc: Kevin Wolf; penb
Yeah. That will make the work quite simple.
After testing, fdatasync is better than fsync.
-Original Message-
From: Sasha Levin [mailto:levinsasha...@gmail.com]
Sent: Sunday, November 20, 2011 2:23 PM
To: Lan, Tianyu
Cc: Kevin Wolf; penb...@kernel.org; kvm@vger.kernel.org; asias.he
enter the commit message for your changes. Lines starting
Signed-off-by: Lan Tianyu tianyu@intel.com
---
tools/kvm/disk/qcow.c| 366 +-
tools/kvm/include/kvm/qcow.h |2 +
2 files changed, 255 insertions(+), 113 deletions(-)
diff --git a/tools
Hi Kevin:
Thanks for your review. The following means that there should be a
fsync after updating
metadata(refcunt block, l1 table and l2 table).
Thanks
Tianyu Lan
-Original Message-
+ /*write l2 table*/
+ l2t-dirty = 1;
+ if
When meeting request to write the cluster without copied flag,
allocate a new cluster and write original data with modification
to the new cluster. This also can add support for the writing
operation of the qcow2 compressed image.
Signed-off-by: Lan Tianyu tianyu@intel.com
---
tools/kvm/disk
-by: Lan Tianyu tianyu@intel.com
---
tools/kvm/Makefile |1 +
tools/kvm/disk/qcow.c| 315 ++
tools/kvm/include/kvm/qcow.h | 33 +++--
3 files changed, 276 insertions(+), 73 deletions(-)
diff --git a/tools/kvm/Makefile b/tools/kvm
91 matches
Mail list logo
