Re: [KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close()

2009-06-04 Thread Avi Kivity
Michael S. Tsirkin wrote: On Tue, Jun 02, 2009 at 01:41:05PM -0400, Gregory Haskins wrote: And having close not clean up the state unless you do an ioctl first is very messy IMO - I don't think you'll find any such examples in kernel. I agree, and that is why I am advocating this

Re: [KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close()

2009-06-04 Thread Gregory Haskins
Avi Kivity wrote: Michael S. Tsirkin wrote: On Tue, Jun 02, 2009 at 01:41:05PM -0400, Gregory Haskins wrote: And having close not clean up the state unless you do an ioctl first is very messy IMO - I don't think you'll find any such examples in kernel. I agree, and that is why

Re: [KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close()

2009-06-04 Thread Gregory Haskins
Avi Kivity wrote: Gregory Haskins wrote: I agree that deassign is needed for reasons of symmetry, and that it can be added later. Cool. FYI: Davide's patch has been accepted into -mm (Andrew CC'd). I am not sure of the protocol here, but I assume this means you can now safely pull

Re: [KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close()

2009-06-04 Thread Avi Kivity
Gregory Haskins wrote: Since Paul ok'd (I think?) the srcu design, and the only other feedback was the key-bitmap thing from Davide, I will go ahead and push a v2 with just that one fix (unless there is any other feedback?) I'll do a detailed review on your next posting. When I see a long

Re: [KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close()

2009-06-03 Thread Michael S. Tsirkin
On Tue, Jun 02, 2009 at 01:41:05PM -0400, Gregory Haskins wrote: And having close not clean up the state unless you do an ioctl first is very messy IMO - I don't think you'll find any such examples in kernel. I agree, and that is why I am advocating this POLLHUP solution. It was

Re: [KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close()

2009-06-03 Thread Gregory Haskins
Michael S. Tsirkin wrote: On Tue, Jun 02, 2009 at 01:41:05PM -0400, Gregory Haskins wrote: And having close not clean up the state unless you do an ioctl first is very messy IMO - I don't think you'll find any such examples in kernel. I agree, and that is why I am advocating

[KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close()

2009-06-02 Thread Gregory Haskins
(Applies to kvm.git/master:25deed73) Please see the header for 2/2 for a description. This patch series has been fully tested and appears to be working correctly. I have it as an RFC for now because it needs Davide's official submission/SOB for patch 1/2, and it should get some eyeballs/acks on

Re: [KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close()

2009-06-02 Thread Michael S. Tsirkin
On Tue, Jun 02, 2009 at 11:15:28AM -0400, Gregory Haskins wrote: (Applies to kvm.git/master:25deed73) Please see the header for 2/2 for a description. This patch series has been fully tested and appears to be working correctly. I have it as an RFC for now because it needs Davide's official

Re: [KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close()

2009-06-02 Thread Gregory Haskins
Michael S. Tsirkin wrote: On Tue, Jun 02, 2009 at 11:15:28AM -0400, Gregory Haskins wrote: (Applies to kvm.git/master:25deed73) Please see the header for 2/2 for a description. This patch series has been fully tested and appears to be working correctly. I have it as an RFC for now

Re: [KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close()

2009-06-02 Thread Michael S. Tsirkin
On Tue, Jun 02, 2009 at 12:14:15PM -0400, Gregory Haskins wrote: Michael S. Tsirkin wrote: On Tue, Jun 02, 2009 at 11:15:28AM -0400, Gregory Haskins wrote: (Applies to kvm.git/master:25deed73) Please see the header for 2/2 for a description. This patch series has been fully tested

Re: [KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close()

2009-06-02 Thread Gregory Haskins
Michael S. Tsirkin wrote: On Tue, Jun 02, 2009 at 12:14:15PM -0400, Gregory Haskins wrote: Michael S. Tsirkin wrote: On Tue, Jun 02, 2009 at 11:15:28AM -0400, Gregory Haskins wrote: (Applies to kvm.git/master:25deed73) Please see the header for 2/2 for a description.

Re: [KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close()

2009-06-02 Thread Michael S. Tsirkin
On Tue, Jun 02, 2009 at 12:34:12PM -0400, Gregory Haskins wrote: Michael S. Tsirkin wrote: On Tue, Jun 02, 2009 at 12:14:15PM -0400, Gregory Haskins wrote: Michael S. Tsirkin wrote: On Tue, Jun 02, 2009 at 11:15:28AM -0400, Gregory Haskins wrote: (Applies to

Re: [KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close()

2009-06-02 Thread Michael S. Tsirkin
On Tue, Jun 02, 2009 at 07:59:49PM +0300, Michael S. Tsirkin wrote: On Tue, Jun 02, 2009 at 12:34:12PM -0400, Gregory Haskins wrote: Michael S. Tsirkin wrote: On Tue, Jun 02, 2009 at 12:14:15PM -0400, Gregory Haskins wrote: Michael S. Tsirkin wrote: On Tue, Jun 02, 2009

Re: [KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close()

2009-06-02 Thread Gregory Haskins
Michael S. Tsirkin wrote: On Tue, Jun 02, 2009 at 12:34:12PM -0400, Gregory Haskins wrote: Michael S. Tsirkin wrote: On Tue, Jun 02, 2009 at 12:14:15PM -0400, Gregory Haskins wrote: Michael S. Tsirkin wrote: On Tue, Jun 02, 2009 at 11:15:28AM -0400,