The option looks like, -incoming kemari:protocol:address:port
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp
---
migration.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/migration.c b/migration.c
index 9d2abff..4dc02a2 100644
--- a/migration.c
+++
2011/1/29 Paolo Bonzini pbonz...@redhat.com:
On 01/28/2011 04:31 PM, Yoshiaki Tamura wrote:
That's the hack I was imaging:)
So your original patch is also a hack? :)
TBH, yeah :) I didn't came up better idea that is not over
engineered.
Maybe this is just an issue of preference, but I'm
On 01/29/2011 10:31 AM, Yoshiaki Tamura wrote:
OK, then while keeping -incoming kemari:tcp:host:port as a
strong solution, could you please explain why placing the original
parser under tcp handler wasn't a good idea? With that,
-incoming exec .*,ft_mode shouldn't be a problem.
But a
2011/1/29 Paolo Bonzini pbonz...@redhat.com:
On 01/29/2011 10:31 AM, Yoshiaki Tamura wrote:
OK, then while keeping -incoming kemari:tcp:host:port as a
strong solution, could you please explain why placing the original
parser under tcp handler wasn't a good idea? With that,
-incoming exec
On 01/29/2011 12:32 PM, Yoshiaki Tamura wrote:
But a hypothetical -incoming unix.*,ft_mode would have to be implemented
twice.
You mean Kemari should be able to use with unix domain sockets,
or other local communication patch? Since Kemari needs two
remote hosts, I don't see why need to
2011/1/29 Paolo Bonzini pbonz...@redhat.com:
On 01/29/2011 12:32 PM, Yoshiaki Tamura wrote:
But a hypothetical -incoming unix.*,ft_mode would have to be
implemented
twice.
You mean Kemari should be able to use with unix domain sockets,
or other local communication patch? Since Kemari
On 01/28/2011 08:21 AM, Yoshiaki Tamura wrote:
+/* check ft_mode option */
+p = strstr(uri, ft_mode);
+if (p !strcmp(p, ft_mode)) {
+ft_mode = FT_INIT;
+}
+
This works for TCP mode, but:
1) I am not sure what would happen with -incoming exec;
2) it is tricky! :)
2011/1/28 Paolo Bonzini pbonz...@redhat.com:
On 01/28/2011 08:21 AM, Yoshiaki Tamura wrote:
+ /* check ft_mode option */
+ p = strstr(uri, ft_mode);
+ if (p !strcmp(p, ft_mode)) {
+ ft_mode = FT_INIT;
+ }
+
This works for TCP mode, but:
1) I am not sure what would
On 01/28/2011 02:53 PM, Yoshiaki Tamura wrote:
1) I am not sure what would happen with -incoming exec;
Nothing happens if used with other protocols, but I assume you're
mentioning that it's not clear from the code, which makes sense.
I assume nothing just because the code for other
2011/1/28 Paolo Bonzini pbonz...@redhat.com:
On 01/28/2011 02:53 PM, Yoshiaki Tamura wrote:
1) I am not sure what would happen with -incoming exec;
Nothing happens if used with other protocols, but I assume you're
mentioning that it's not clear from the code, which makes sense.
I assume
On 01/28/2011 04:05 PM, Yoshiaki Tamura wrote:
Having a scheme like kemari:tcp:host:port looks quite
challenging to me. We can of course add some quick hacks for it,
but adding a nice layered architecture should be more
appropriate. Similar to protocols and formats in block layer?
At the same
2011/1/29 Paolo Bonzini pbonz...@redhat.com:
On 01/28/2011 04:05 PM, Yoshiaki Tamura wrote:
Having a scheme like kemari:tcp:host:port looks quite
challenging to me. We can of course add some quick hacks for it,
but adding a nice layered architecture should be more
appropriate. Similar to
On 01/28/2011 04:31 PM, Yoshiaki Tamura wrote:
That's the hack I was imaging:)
So your original patch is also a hack? :)
Maybe this is just an issue of preference, but I'm not sure
adding kemari: to be intuitive. If there were similar
extensions having the same problem, I would have agreed
The option looks like, -incoming protocol:address:port,ft_mode
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp
---
migration.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/migration.c b/migration.c
index 1752cf4..29d4fb1 100644
--- a/migration.c
+++
The option looks like, -incoming protocol:address:port,ft_mode
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp
---
migration.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/migration.c b/migration.c
index 1752cf4..29d4fb1 100644
--- a/migration.c
+++
The option looks like, -incoming protocol:address:port,ft_mode
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp
---
migration.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/migration.c b/migration.c
index 11bbdf8..7275f02 100644
--- a/migration.c
+++
The option looks like, -incoming protocol:address:port,ft_mode
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp
---
migration.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/migration.c b/migration.c
index d4922ce..1822e97 100644
--- a/migration.c
The option looks like, -incoming protocol:address:port,ft_mode
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp
---
migration.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/migration.c b/migration.c
index 6e22d2a..4aa7fdf 100644
--- a/migration.c
The option looks like, -incoming protocol:address:port,ft_mode
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp
---
migration.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/migration.c b/migration.c
index a4a39eb..14d7089 100644
--- a/migration.c
The option looks like, -incoming protocol:address:port,ft_mode
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp
---
migration.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/migration.c b/migration.c
index 730af12..32fef86 100644
--- a/migration.c
20 matches
Mail list logo
