Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-04-03 Thread Paolo Bonzini
Considering the following when the same seabios code snippet: pci_config_writeb(0x31): bdf: 0x pam: 0x005b is executed to mark an pc.ram area 0xc as readonly: Entering vhost_begin Entering vhost_region_del section: 0x7fd037a4bb60 offset_within_region: 0xc

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-04-02 Thread Michael S. Tsirkin
On Mon, Apr 01, 2013 at 06:05:47PM -0700, Nicholas A. Bellinger wrote: On Fri, 2013-03-29 at 09:14 +0100, Paolo Bonzini wrote: Il 29/03/2013 03:53, Nicholas A. Bellinger ha scritto: On Thu, 2013-03-28 at 06:13 -0400, Paolo Bonzini wrote: I think it's the right thing to do, but maybe not

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-04-02 Thread Nicholas A. Bellinger
On Tue, 2013-04-02 at 16:27 +0300, Michael S. Tsirkin wrote: On Mon, Apr 01, 2013 at 06:05:47PM -0700, Nicholas A. Bellinger wrote: On Fri, 2013-03-29 at 09:14 +0100, Paolo Bonzini wrote: Il 29/03/2013 03:53, Nicholas A. Bellinger ha scritto: On Thu, 2013-03-28 at 06:13 -0400, Paolo

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-04-02 Thread Nicholas A. Bellinger
On Tue, 2013-04-02 at 21:04 -0700, Nicholas A. Bellinger wrote: On Tue, 2013-04-02 at 16:27 +0300, Michael S. Tsirkin wrote: On Mon, Apr 01, 2013 at 06:05:47PM -0700, Nicholas A. Bellinger wrote: On Fri, 2013-03-29 at 09:14 +0100, Paolo Bonzini wrote: Il 29/03/2013 03:53, Nicholas A.

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-04-01 Thread Nicholas A. Bellinger
On Fri, 2013-03-29 at 09:14 +0100, Paolo Bonzini wrote: Il 29/03/2013 03:53, Nicholas A. Bellinger ha scritto: On Thu, 2013-03-28 at 06:13 -0400, Paolo Bonzini wrote: I think it's the right thing to do, but maybe not the right place to do this, need to reset after all IO is done, before

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-29 Thread Paolo Bonzini
Il 29/03/2013 03:53, Nicholas A. Bellinger ha scritto: On Thu, 2013-03-28 at 06:13 -0400, Paolo Bonzini wrote: I think it's the right thing to do, but maybe not the right place to do this, need to reset after all IO is done, before ring memory is write protected. Our emails are crossing each

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-28 Thread Nicholas A. Bellinger
On Wed, 2013-03-27 at 15:33 -0700, Nicholas A. Bellinger wrote: On Wed, 2013-03-27 at 23:56 +0200, Michael S. Tsirkin wrote: On Wed, Mar 27, 2013 at 02:31:27PM -0700, Nicholas A. Bellinger wrote: On Wed, 2013-03-20 at 11:51 +0200, Michael S. Tsirkin wrote: On Tue, Mar 19, 2013 at

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-28 Thread Nicholas A. Bellinger
On Wed, 2013-03-27 at 23:45 -0700, Nicholas A. Bellinger wrote: On Wed, 2013-03-27 at 15:33 -0700, Nicholas A. Bellinger wrote: On Wed, 2013-03-27 at 23:56 +0200, Michael S. Tsirkin wrote: On Wed, Mar 27, 2013 at 02:31:27PM -0700, Nicholas A. Bellinger wrote: SNIP Adding a bit more

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-28 Thread Michael S. Tsirkin
On Thu, Mar 28, 2013 at 12:35:42AM -0700, Nicholas A. Bellinger wrote: On Wed, 2013-03-27 at 23:45 -0700, Nicholas A. Bellinger wrote: On Wed, 2013-03-27 at 15:33 -0700, Nicholas A. Bellinger wrote: On Wed, 2013-03-27 at 23:56 +0200, Michael S. Tsirkin wrote: On Wed, Mar 27, 2013 at

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-28 Thread Paolo Bonzini
Il 28/03/2013 10:04, Michael S. Tsirkin ha scritto: Got ranges_overlap for vq: 0 ring_phys: 0 ring_size: 1028 Checking vq: 1 ring_phys: 0 ring_size: 1028 . Got ranges_overlap for vq: 1 ring_phys: 0 ring_size: 1028 Checking vq: 2 ring_phys: ed000 ring_size: 5124 . Calling l: 5124 for

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-28 Thread Paolo Bonzini
I think it's the right thing to do, but maybe not the right place to do this, need to reset after all IO is done, before ring memory is write protected. Our emails are crossing each other unfortunately, but I want to reinforce this: ring memory is not write protected. Remember that SeaBIOS

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-28 Thread Nicholas A. Bellinger
On Thu, 2013-03-28 at 11:03 +0100, Paolo Bonzini wrote: Il 28/03/2013 10:04, Michael S. Tsirkin ha scritto: Got ranges_overlap for vq: 0 ring_phys: 0 ring_size: 1028 Checking vq: 1 ring_phys: 0 ring_size: 1028 . Got ranges_overlap for vq: 1 ring_phys: 0 ring_size: 1028 Checking

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-28 Thread Nicholas A. Bellinger
On Thu, 2013-03-28 at 06:13 -0400, Paolo Bonzini wrote: I think it's the right thing to do, but maybe not the right place to do this, need to reset after all IO is done, before ring memory is write protected. Our emails are crossing each other unfortunately, but I want to reinforce this:

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-28 Thread Nicholas A. Bellinger
On Thu, 2013-03-28 at 11:04 +0200, Michael S. Tsirkin wrote: On Thu, Mar 28, 2013 at 12:35:42AM -0700, Nicholas A. Bellinger wrote: On Wed, 2013-03-27 at 23:45 -0700, Nicholas A. Bellinger wrote: On Wed, 2013-03-27 at 15:33 -0700, Nicholas A. Bellinger wrote: On Wed, 2013-03-27 at 23:56

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-27 Thread Nicholas A. Bellinger
On Wed, 2013-03-20 at 11:51 +0200, Michael S. Tsirkin wrote: On Tue, Mar 19, 2013 at 06:57:08PM -0700, Nicholas A. Bellinger wrote: On Tue, 2013-03-19 at 09:40 +0100, Stefan Hajnoczi wrote: On Tue, Mar 19, 2013 at 08:34:45AM +0800, Asias He wrote: --- hw/vhost.c | 2 ++ 1 file

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-27 Thread Michael S. Tsirkin
On Wed, Mar 27, 2013 at 02:31:27PM -0700, Nicholas A. Bellinger wrote: On Wed, 2013-03-20 at 11:51 +0200, Michael S. Tsirkin wrote: On Tue, Mar 19, 2013 at 06:57:08PM -0700, Nicholas A. Bellinger wrote: On Tue, 2013-03-19 at 09:40 +0100, Stefan Hajnoczi wrote: On Tue, Mar 19, 2013 at

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-27 Thread Nicholas A. Bellinger
On Wed, 2013-03-27 at 23:56 +0200, Michael S. Tsirkin wrote: On Wed, Mar 27, 2013 at 02:31:27PM -0700, Nicholas A. Bellinger wrote: On Wed, 2013-03-20 at 11:51 +0200, Michael S. Tsirkin wrote: On Tue, Mar 19, 2013 at 06:57:08PM -0700, Nicholas A. Bellinger wrote: On Tue, 2013-03-19 at

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-20 Thread Michael S. Tsirkin
On Tue, Mar 19, 2013 at 06:57:08PM -0700, Nicholas A. Bellinger wrote: On Tue, 2013-03-19 at 09:40 +0100, Stefan Hajnoczi wrote: On Tue, Mar 19, 2013 at 08:34:45AM +0800, Asias He wrote: --- hw/vhost.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vhost.c b/hw/vhost.c

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-19 Thread Stefan Hajnoczi
On Tue, Mar 19, 2013 at 08:34:45AM +0800, Asias He wrote: --- hw/vhost.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vhost.c b/hw/vhost.c index 4d6aee3..0c52ec4 100644 --- a/hw/vhost.c +++ b/hw/vhost.c @@ -421,10 +421,12 @@ static void vhost_set_memory(MemoryListener

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-19 Thread Asias He
On Tue, Mar 19, 2013 at 09:40:57AM +0100, Stefan Hajnoczi wrote: On Tue, Mar 19, 2013 at 08:34:45AM +0800, Asias He wrote: --- hw/vhost.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vhost.c b/hw/vhost.c index 4d6aee3..0c52ec4 100644 --- a/hw/vhost.c +++ b/hw/vhost.c

Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-19 Thread Nicholas A. Bellinger
On Tue, 2013-03-19 at 09:40 +0100, Stefan Hajnoczi wrote: On Tue, Mar 19, 2013 at 08:34:45AM +0800, Asias He wrote: --- hw/vhost.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vhost.c b/hw/vhost.c index 4d6aee3..0c52ec4 100644 --- a/hw/vhost.c +++ b/hw/vhost.c @@

[PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-18 Thread Asias He
--- hw/vhost.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vhost.c b/hw/vhost.c index 4d6aee3..0c52ec4 100644 --- a/hw/vhost.c +++ b/hw/vhost.c @@ -421,10 +421,12 @@ static void vhost_set_memory(MemoryListener *listener, return; } +#if 0 if (dev-started) {