Re: [kvm-devel] [PATCH] KVM: emulator: Only allow VMCALL/VMMCALL trapped by #UD

2008-01-06 Thread Avi Kivity
Yang, Sheng wrote: From 9743b5299bae1779c2b893cbeb86122bcccb9b2d Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Wed, 2 Jan 2008 14:49:22 +0800 Subject: [PATCH] KVM: emulator: Only allow VMCALL/VMMCALL trapped by #UD When executing a test program called crashme, we found

Re: [kvm-devel] remove redundant VM Exit for non-aligned guest pte write or part of pte write.

2008-01-06 Thread Avi Kivity
Dong, Eddie wrote: Avi Kivity wrote: Dong, Eddie wrote: I observed 1-2 seconds faster in Windows XPSP2 ACPI bootup with total of 23 seconds. I can;t say it is exactly caused by this patch, but anyway it simplifies the logic and code w/o any additional complexity. thx,eddie

Re: [kvm-devel] kvm-59 missing resolution 1280x800

2008-01-06 Thread Avi Kivity
Benjamin Drung wrote: Hi, the change-log for kvm-59 listed wide-screen-support. I found resolution like 1680x1050, but the resolution 1280x800 for my 12-sub-notebook is missing. It would be nice, if you add this resolution. Sure thing, will be in kvm-60. -- error compiling

Re: [kvm-devel] [PATCH 20/52] KVM: Add missing #include asm/pgtable.h

2008-01-06 Thread Avi Kivity
Adrian Bunk wrote: On Sun, Dec 30, 2007 at 09:10:06AM +0200, Avi Kivity wrote: Needed for empty_zero_page. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/kvm_main.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/kvm_main.c

Re: [kvm-devel] acpi sci polarity

2008-01-06 Thread Avi Kivity
Guido Guenther wrote: Hi Avi, On Thu, Jan 03, 2008 at 11:17:50PM +0200, Avi Kivity wrote: While pci interrupts are documented as active high, the documentation for the piix4 pic elcr registers suggests piix4 level-triggered interrupts are active high. So there is some inconsistency

Re: [kvm-devel] [PATCH] Moving tpr-patch routine to x86 arch.

2008-01-06 Thread Avi Kivity
Zhang, Xiantao wrote: From: Zhang Xiantao [EMAIL PROTECTED] Date: Sat, 5 Jan 2008 20:20:14 +0800 Subject: [PATCH] kvm: qemu: Moving tpr-patch routine to qemu-kvm-x86.c Since tpr patching routine only needed in x86 side, moving it qemu-kvm-arch. Applied, thanks. -- error compiling

Re: [kvm-devel] [PATCH] Moving tpr-patch routine to x86 arch.

2008-01-06 Thread Avi Kivity
Avi Kivity wrote: Zhang, Xiantao wrote: From: Zhang Xiantao [EMAIL PROTECTED] Date: Sat, 5 Jan 2008 20:20:14 +0800 Subject: [PATCH] kvm: qemu: Moving tpr-patch routine to qemu-kvm-x86.c Since tpr patching routine only needed in x86 side, moving it qemu-kvm-arch. Applied, thanks. It

Re: [kvm-devel] remove redundant VM Exit for non-aligned guest pte write or part of pte write.

2008-01-06 Thread Dong, Eddie
Wrong patch attached... Sorry for the wrong attachment :( Eddie tlb-clean3.patch2 Description: tlb-clean3.patch2 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005.

[kvm-devel] [PATCH 07/33] KVM: Portability: Expand the KVM_VCPU_COMM in kvm_vcpu structure.

2008-01-06 Thread Avi Kivity
From: Zhang Xiantao [EMAIL PROTECTED] This patches removes KVM_COMM macro, original it is hold kvm_vcpu common fields. Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Acked-by: Carsten Otte [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/kvm.h | 53

[kvm-devel] [PATCH 08/33] KVM: Portability: Move kvm_vcpu_stat to x86.h

2008-01-06 Thread Avi Kivity
From: Zhang Xiantao [EMAIL PROTECTED] This patches moves kvm_vcpu_stat to x86.h, so every arch can define its own kvm_vcpu_stat structure. Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Acked-by: Carsten Otte [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/kvm.h |

[kvm-devel] [PATCH 09/33] KVM: Portability: Move memslot aliases to new struct kvm_arch

2008-01-06 Thread Avi Kivity
From: Zhang Xiantao [EMAIL PROTECTED] This patches create kvm_arch to hold arch-specific kvm fileds and moves fields naliases and aliases to kvm_arch. Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Acked-by: Carsten Otte [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] ---

[kvm-devel] [PATCH 05/33] KVM: Portability: Split mmu-related static inline functions to mmu.h

2008-01-06 Thread Avi Kivity
From: Zhang Xiantao [EMAIL PROTECTED] Since these functions need to know the details of kvm or kvm_vcpu structure, it can't be put in x86.h. Create mmu.h to hold them. Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Acked-by: Carsten Otte [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL

[kvm-devel] [PATCH 11/33] KVM: Portability: move vpic and vioapic to kvm_arch

2008-01-06 Thread Avi Kivity
From: Zhang Xiantao [EMAIL PROTECTED] This patches moves two fields vpid and vioapic to kvm_arch Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Acked-by: Carsten Otte [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/ioapic.c |4 ++-- drivers/kvm/irq.h|4

[kvm-devel] [PATCH 12/33] KVM: Portability: Move round_robin_prev_vcpu and tss_addr to kvm_arch

2008-01-06 Thread Avi Kivity
From: Zhang Xiantao [EMAIL PROTECTED] This patches moves two fields round_robin_prev_vcpu and tss to kvm_arch. Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Acked-by: Carsten Otte [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/kvm.h |3 ---

[kvm-devel] [PATCH 16/33] KVM: Move drivers/kvm/* to virt/kvm/

2008-01-06 Thread Avi Kivity
Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/Makefile|4 ++-- {drivers = virt}/kvm/iodev.h|0 {drivers = virt}/kvm/kvm_main.c |0 3 files changed, 2 insertions(+), 2 deletions(-) rename {drivers = virt}/kvm/iodev.h (100%) rename {drivers =

[kvm-devel] [PATCH 22/33] KVM: MMU: Add cache miss statistic

2008-01-06 Thread Avi Kivity
Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/mmu.c |1 + arch/x86/kvm/x86.c |1 + include/asm-x86/kvm_host.h |1 + 3 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 9a57e1a..8f12ec5 100644 ---

[kvm-devel] [PATCH 14/33] KVM: VMX: Add printk_ratelimit in vmx_intr_assist

2008-01-06 Thread Avi Kivity
From: Ryan Harper [EMAIL PROTECTED] Add printk_ratelimit check in front of printk. This prevents spamming of the message during 32-bit ubuntu 6.06server install. Previously, it would hang during the partition formatting stage. Signed-off-by: Ryan Harper [EMAIL PROTECTED] Signed-off-by: Avi

[kvm-devel] [PATCH 13/33] KVM: Portability: Move kvm_vm_stat to x86.h

2008-01-06 Thread Avi Kivity
From: Zhang Xiantao [EMAIL PROTECTED] This patch moves kvm_vm_stat to x86.h, and every arch can define its own kvm_vm_stat in $arch.h Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Acked-by: Carsten Otte [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/kvm.h | 10

[kvm-devel] [PATCH 06/33] KVM: Portability: Move kvm_vcpu definition back to kvm.h

2008-01-06 Thread Avi Kivity
From: Zhang Xiantao [EMAIL PROTECTED] This patches moves kvm_vcpu definition to kvm.h, and finally kvm.h includes x86.h. Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Acked-by: Carsten Otte [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/irq.h |2 +-

[kvm-devel] [PATCH 15/33] KVM: Move arch dependent files to new directory arch/x86/kvm/

2008-01-06 Thread Avi Kivity
This paves the way for multiple architecture support. Note that while ioapic.c could potentially be shared with ia64, it is also moved. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/Kconfig |2 ++ arch/x86/Makefile

[kvm-devel] [PATCH 18/33] KVM: Move ioapic code to common directory.

2008-01-06 Thread Avi Kivity
From: Zhang Xiantao [EMAIL PROTECTED] Move ioapic code to common, since IA64 also needs it. Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/Makefile |7 +++ {arch/x86 = virt}/kvm/ioapic.c |2 +- {arch/x86 =

[kvm-devel] [PATCH 20/33] KVM: Expose ioapic to ia64 save/restore APIs

2008-01-06 Thread Avi Kivity
From: Zhang Xiantao [EMAIL PROTECTED] IA64 also needs to see ioapic structure in irqchip. Signed-off-by: [EMAIL PROTECTED] [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- include/linux/kvm.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[kvm-devel] [PATCH 17/33] KVM: Move irqchip declarations into new ioapic.h and lapic.h

2008-01-06 Thread Avi Kivity
From: Zhang Xiantao [EMAIL PROTECTED] This allows reuse of ioapic in ia64. Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/ioapic.c |5 ++- arch/x86/kvm/ioapic.h | 95 arch/x86/kvm/irq.h

[kvm-devel] [PATCH 10/33] KVM: Portability: Move mmu-related fields to kvm_arch

2008-01-06 Thread Avi Kivity
From: Zhang Xiantao [EMAIL PROTECTED] This patches moves mmu-related fields to kvm_arch. Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Acked-by: Carsten Otte [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/kvm.h |8 --- drivers/kvm/mmu.c | 58

[kvm-devel] [PATCH 19/33] KVM: Move kvm_vcpu_kick() to x86.c

2008-01-06 Thread Avi Kivity
From: Zhang Xiantao [EMAIL PROTECTED] Moving kvm_vcpu_kick() to x86.c. Since it should be common for all archs, put its declarations in linux/kvm_host.h Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/irq.c | 20

[kvm-devel] [PATCH 26/33] KVM: Disable vapic support on Intel machines with FlexPriority

2008-01-06 Thread Avi Kivity
FlexPriority accelerates the tpr without any patching. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/svm.c |6 ++ arch/x86/kvm/vmx.c |3 ++- arch/x86/kvm/x86.c |4 +++- include/asm-x86/kvm_host.h |1 + 4 files changed, 12 insertions(+),

[kvm-devel] [PATCH 33/33] KVM: x86 emulator: Only allow VMCALL/VMMCALL trapped by #UD

2008-01-06 Thread Avi Kivity
From: Sheng Yang [EMAIL PROTECTED] When executing a test program called crashme, we found the KVM guest cannot survive more than ten seconds, then encounterd kernel panic. The basic concept of crashme is generating random assembly code and trying to execute it. After some fixes on emulator insn

[kvm-devel] [PATCH 21/33] KVM: MMU: Coalesce remote tlb flushes

2008-01-06 Thread Avi Kivity
From: Eddie Dong [EMAIL PROTECTED] Host side TLB flush can be merged together if multiple spte need to be write-protected. Signed-off-by: Yaozu (Eddie) Dong [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/mmu.c |8 ++-- 1 files changed, 6 insertions(+), 2

[kvm-devel] [PATCH 28/33] KVM: Add kvm_read_guest_atomic()

2008-01-06 Thread Avi Kivity
From: Marcelo Tosatti [EMAIL PROTECTED] In preparation for a mmu spinlock, add kvm_read_guest_atomic() and use it in fetch() and prefetch_page(). Signed-off-by: Marcelo Tosatti [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/paging_tmpl.h | 28

[kvm-devel] [PATCH 31/33] KVM: MMU: Move kvm_free_some_pages() into critical section

2008-01-06 Thread Avi Kivity
If some other cpu steals mmu pages between our check and an attempt to allocate, we can run out of mmu pages. Fix by moving the check into the same critical section as the allocation. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/mmu.c |9 +++--

[kvm-devel] [PATCH 32/33] KVM: MMU: Merge shadow level check in FNAME(fetch)

2008-01-06 Thread Avi Kivity
From: Dong, Eddie [EMAIL PROTECTED] Remove the redundant level check when fetching shadow pte for present non-present spte. Signed-off-by: Yaozu (Eddie) Dong [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/paging_tmpl.h |7 ++- 1 files changed, 2

[kvm-devel] [PATCH 24/33] KVM: local APIC TPR access reporting facility

2008-01-06 Thread Avi Kivity
Add a facility to report on accesses to the local apic tpr even if the local apic is emulated in the kernel. This is basically a hack that allows userspace to patch Windows which tends to bang on the tpr a lot. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/lapic.c | 21

[kvm-devel] [PATCH 25/33] KVM: Accelerated apic support

2008-01-06 Thread Avi Kivity
This adds a mechanism for exposing the virtual apic tpr to the guest, and a protocol for letting the guest update the tpr without causing a vmexit if conditions allow (e.g. there is no interrupt pending with a higher priority than the new tpr). Signed-off-by: Avi Kivity [EMAIL PROTECTED] ---

[kvm-devel] [PATCH 29/33] KVM: MMU: Avoid calling gfn_to_page() in mmu_set_spte()

2008-01-06 Thread Avi Kivity
Since gfn_to_page() is a sleeping function, and we want to make the core mmu spinlocked, we need to pass the page from the walker context (which can sleep) to the shadow context (which cannot). [marcelo: avoid recursive locking of mmap_sem] Signed-off-by: Avi Kivity [EMAIL PROTECTED] ---

[kvm-devel] [PATCH 27/33] KVM: MMU: Concurrent guest walkers

2008-01-06 Thread Avi Kivity
From: Marcelo Tosatti [EMAIL PROTECTED] Do not hold kvm-lock mutex across the entire pagefault code, only acquire it in places where it is necessary, such as mmu hash list, active list, rmap and parent pte handling. Allow concurrent guest walkers by switching walk_addr() to use mmap_sem in

[kvm-devel] [PATCH 30/33] KVM: MMU: Switch to mmu spinlock

2008-01-06 Thread Avi Kivity
From: Marcelo Tosatti [EMAIL PROTECTED] Convert the synchronization of the shadow handling to a separate mmu_lock spinlock. Also guard fetch() by mmap_sem in read-mode to protect against alias and memslot changes. Signed-off-by: Marcelo Tosatti [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL

[kvm-devel] [PATCH 03/33] KVM: Portability: Move kvm{pic, ioapic} accesors to x86 specific code

2008-01-06 Thread Avi Kivity
From: Zhang Xiantao [EMAIL PROTECTED] Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/irq.h | 18 -- drivers/kvm/kvm.h | 18 +++--- drivers/kvm/x86.h |1 - 3 files changed, 19 insertions(+), 18

[kvm-devel] [PATCH 02/33] KVM: MMU: emulated cmpxchg8b should be atomic on i386

2008-01-06 Thread Avi Kivity
From: Marcelo Tosatti [EMAIL PROTECTED] Emulate cmpxchg8b atomically on i386. This is required to avoid a guest pte walker from seeing a splitted write. [avi: make it compile] Signed-off-by: Marcelo Tosatti [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/x86.c |

[kvm-devel] [PATCH 01/33] KVM: SVM: support writing 0 to K8 performance counter control registers

2008-01-06 Thread Avi Kivity
From: Joerg Roedel [EMAIL PROTECTED] This lets SVM ignore writes of the value 0 to the performance counter control registers. Thus enabling them will still fail in the guest, but a write of 0 which keeps them disabled is accepted. This is required to boot Windows Vista 64bit. [avi: avoid

[kvm-devel] [PATCH 00/33] KVM patch queue review for 2.6.25 merge window (part V)

2008-01-06 Thread Avi Kivity
Fifth set of kvm updates scheduled for the 2.6.25 merge window. Please review. Diffstat below is for this batch only. I haven't yet implemented the previous comments, so code that is copied from previous patches may have the same issue. arch/x86/Kconfig |

[kvm-devel] kvm with usb slow

2008-01-06 Thread Norbert Preining
Hi all, (please Cc, thanks) I am running kernel 2.6.24-rc6 and kvm-56 (or was it 55) and as soon as I plug an usb device with usb enabled it is getting terrible slow. I have searched a bit and it seems to be related to async i/o not being implemented. Is this expected behaviour, and if yes,

Re: [kvm-devel] [PATCH 02/33] KVM: MMU: emulated cmpxchg8b should be atomic on i386

2008-01-06 Thread Carlo Marcelo Arenas Belon
On Sun, Jan 06, 2008 at 04:39:08PM +0200, Avi Kivity wrote: From: Marcelo Tosatti [EMAIL PROTECTED] Emulate cmpxchg8b atomically on i386. This is required to avoid a guest pte walker from seeing a splitted write. [avi: make it compile] Signed-off-by: Marcelo Tosatti [EMAIL PROTECTED]

[kvm-devel] boot stops after console handover?

2008-01-06 Thread Antoine Martin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Trying to boot KVM on a Core2Duo system, kvm-59 + linux-2.6.23.12 Booting with: qemu-system-x86_64 -hda /home/uml/BusyBox-1.5.0-amd64-root_fs -m 384 - -nographic -cpu qemu64 -kernel /boot/vmlinuz-2.6.23.12 -append

Re: [kvm-devel] boot stops after console handover?

2008-01-06 Thread Izik Eidus
Antoine Martin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Trying to boot KVM on a Core2Duo system, kvm-59 + linux-2.6.23.12 Booting with: qemu-system-x86_64 -hda /home/uml/BusyBox-1.5.0-amd64-root_fs -m 384 - -nographic -cpu qemu64 -kernel /boot/vmlinuz-2.6.23.12 -append

Re: [kvm-devel] boot stops after console handover?

2008-01-06 Thread Antoine Martin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Izik Eidus wrote: Antoine Martin wrote: Hi, Trying to boot KVM on a Core2Duo system, kvm-59 + linux-2.6.23.12 Booting with: qemu-system-x86_64 -hda /home/uml/BusyBox-1.5.0-amd64-root_fs -m 384 -nographic -cpu qemu64 -kernel

Re: [kvm-devel] kvm with usb slow

2008-01-06 Thread Dor Laor
Norbert Preining wrote: Hi all, (please Cc, thanks) I am running kernel 2.6.24-rc6 and kvm-56 (or was it 55) and as soon as I plug an usb device with usb enabled it is getting terrible slow. I have searched a bit and it seems to be related to async i/o not being implemented. Can you please

Re: [kvm-devel] boot stops after console handover?

2008-01-06 Thread Antoine Martin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Antoine Martin wrote: Izik Eidus wrote: Antoine Martin wrote: Hi, Trying to boot KVM on a Core2Duo system, kvm-59 + linux-2.6.23.12 Booting with: qemu-system-x86_64 -hda /home/uml/BusyBox-1.5.0-amd64-root_fs -m 384 -nographic -cpu qemu64

[kvm-devel] [PATCH] vgabios: include string.h in biossums.c for memset declaration

2008-01-06 Thread Carlo Marcelo Arenas Belon
Fixes : biossums.c: In function 'main': biossums.c:62: warning: incompatible implicit declaration of built-in function 'memset Signed-off-by: Carlo Marcelo Arenas Belon [EMAIL PROTECTED] --- vgabios/biossums.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

Re: [kvm-devel] [PATCH] KVM: emulator: Only allow VMCALL/VMMCALL trapped by #UD

2008-01-06 Thread Yang, Sheng
On Sunday 06 January 2008 16:40:16 Avi Kivity wrote: Yang, Sheng wrote: From 9743b5299bae1779c2b893cbeb86122bcccb9b2d Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Wed, 2 Jan 2008 14:49:22 +0800 Subject: [PATCH] KVM: emulator: Only allow VMCALL/VMMCALL trapped by #UD