Re: [kvm-devel] [PATCH]Add TR insert/purge interface for add-on component

2008-01-21 Thread Xu, Anthony
Xu, Anthony wrote: > Thanks for your comments > > > Luck, Tony wrote: >> Looks pretty good. >> >> Stylistically it would be nicer to initialize ia64_max_tr_num to 8 >> (with a comment that this is the least smallest allowed value >> allowed by the architecture - SDM p.2:44 section 4.1.1.1) and >

Re: [kvm-devel] [PATCH]Add TR insert/purge interface for add-on component

2008-01-21 Thread Xu, Anthony
Thanks for your comments Luck, Tony wrote: > Looks pretty good. > > Stylistically it would be nicer to initialize ia64_max_tr_num to 8 > (with > a comment that this is the least smallest allowed value allowed by the > architecture - SDM p.2:44 section 4.1.1.1) and increase this if > PAL_VM_SUMM

[kvm-devel] kvm-devel新《劳动合同法》

2008-01-21 Thread weskypp11
新《劳动合同法》实施细则从解读到企业应对与运用技巧及审理劳动争议案件司法解释 主办单位:深圳众人行 深.圳.时.间:2008年1月19-20 (星期六日) 深 圳 参.会.费.用:1800元 【学-员-对-象】各企业董事长、总经理、副总经理、人力资源部经理/总监、人事主管、薪酬专 员、绩效主管、培训经理、培训主管、招聘主管,企业法律顾问,劳资、工会、行政及各部门经 理、主管等相关人员参加。 -

Re: [kvm-devel] [PATCH/RFC 0/2] CPU hotplug virtio driver

2008-01-21 Thread Dong, Eddie
Avi Kivity wrote: > Glauber de Oliveira Costa wrote: >> >> That said, if acpi is really the preference here, and this patches >> have chance, no problem. But it will take me a little more time to >> implement them ;-) > > The power button support that was recently added at least proves that > the

Re: [kvm-devel] [PATCH] mmu notifiers #v3

2008-01-21 Thread Rik van Riel
On Mon, 21 Jan 2008 13:52:04 +0100 Andrea Arcangeli <[EMAIL PROTECTED]> wrote: > Signed-off-by: Andrea Arcangeli <[EMAIL PROTECTED]> Reviewed-by: Rik van Riel <[EMAIL PROTECTED]> -- All rights reversed. - This SF.net email

Re: [kvm-devel] [RFC][PATCH 1/2] KVM: In-kernel PIT model

2008-01-21 Thread Yang, Sheng
On Monday 21 January 2008 18:28:32 Carsten Otte wrote: > Jan Kiszka wrote: > > The PIT may not be limited to x86 platforms. So I would propose to make > > the setup more generic and flexible. And I would move the code out of > > arch/x86, just the speaker support should remain there. > > It should

Re: [kvm-devel] [RFC][PATCH 0/2]In-kernel PIT model

2008-01-21 Thread Yang, Sheng
On Monday 21 January 2008 19:17:08 Carlo Marcelo Arenas Belon wrote: > On Mon, Jan 21, 2008 at 05:18:21PM +0800, Yang, Sheng wrote: > > The patch works well on IA32e host(passed 2.6.22, 2.6.20, 2.6.18, 2.6.16 > > with hpet=disable, 2.6.9 with clock=pit), > > slightly off-topic but how you got aroun

Re: [kvm-devel] qemu_mutex deadlock with -smp 2

2008-01-21 Thread Darrick J. Wong
On Sun, Jan 20, 2008 at 05:15:07PM +0200, Avi Kivity wrote: > Is this immediately after reboot, or during the boot process? After reboot. --D - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R)

[kvm-devel] [ kvm-Bugs-1876714 ] core dump

2008-01-21 Thread SourceForge.net
Bugs item #1876714, was opened at 2008-01-21 12:59 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1876714&group_id=180599 Please note that this message will contain a full copy

[kvm-devel] kvm crash

2008-01-21 Thread Roger Critchlow
Hi all -- I have kvm 1:28-4ubuntu2 installed under ubuntu 7.10 running 2.6.22-14-generic Attempting to install plan9 I get the following crash: $ kvm -nographic --cdrom ISO/plan9.iso -boot d KVM/plan9-qcow.img (q

Re: [kvm-devel] [PATCH]Add TR insert/purge interface for add-on component

2008-01-21 Thread Luck, Tony
Looks pretty good. Stylistically it would be nicer to initialize ia64_max_tr_num to 8 (with a comment that this is the least smallest allowed value allowed by the architecture - SDM p.2:44 section 4.1.1.1) and increase this if PAL_VM_SUMMARY indicates that the current processor model supports a la

Re: [kvm-devel] [PATCH] SVM: fix lazy FPU switching

2008-01-21 Thread Avi Kivity
Joerg Roedel wrote: > If the guest writes to cr0 and leaves the TS flag at 0 while vcpu->fpu_active > is also 0, the TS flag in the guests cr0 gets lost. This leads to corrupt FPU > state an causes Windows Vista 64bit to crash very soon after boot. This patch > fixes this bug. > > Applied, than

Re: [kvm-devel] KVM swapping with mmu notifiers

2008-01-21 Thread Avi Kivity
Andrea Arcangeli wrote: > On Sun, Jan 20, 2008 at 05:16:03PM +0200, Avi Kivity wrote: > >> Yes, it's supposed to work (we can't prevent userspace from doing it). >> > > Hmm, I think we already prevent it, so I don't think I need to update > my swap code until the below is removed. > >

[kvm-devel] [RFC][PATCH 4/5] example for userspace scanner

2008-01-21 Thread Izik Eidus
-- woof. #include #include #include #include #include #include #include #include #include "linux/ksm.h" int main() { int fd; int fd_scan; int r; fd = open("/dev/ksm", O_RDWR | O_TRUNC, (mode_t)0600); if (fd == -1) { fprintf(stderr, "couldnt even open it\n"); exit(1); } fd_s

[kvm-devel] [RFC][PATCH 5/5] example of userspace application register it memory in ksm

2008-01-21 Thread Izik Eidus
(this is the modification for qemu to make it work with ksm) -- woof. >From 813266c7d59acb64c104448c255cc2c9d4f0187e Mon Sep 17 00:00:00 2001 From: Izik Eidus <[EMAIL PROTECTED]> Date: Mon, 21 Jan 2008 17:41:09 +0200 Subject: [PATCH] qemu: register the memory of qemu with ksm, so it can be shar

Re: [kvm-devel] [PATCH] add acpi powerbutton support

2008-01-21 Thread Avi Kivity
Jan Kiszka wrote: > Avi Kivity wrote: > >> Jan Kiszka wrote: >> >>> Guido Guenther wrote: >>> >>> Hi Jan, On Sat, Jan 19, 2008 at 04:40:06PM +0100, Jan Kiszka wrote: > What about additionally listening on signals? If you run qemu from the

[kvm-devel] [RFC][PATCH 3/5] ksm source code

2008-01-21 Thread Izik Eidus
-- woof. /* * Memory merging driver for Linux * * This module enables dynamic sharing of identical pages found in different * memory areas, even if they are not shared by fork() * * Copyright (C) 2008 Qumranet, Inc. * * This work is licensed under the terms of the GNU GPL, version 2. *

[kvm-devel] [RFC][PATCH 0/5] Memory merging driver for Linux

2008-01-21 Thread Izik Eidus
when kvm is used in production servers, many times it run the same guests operation systems more than once the idea of this module is to find the identical pages in diffrent guests and to share them so we can save memory, due to the fact that many guests run identical operation systems, alot of

[kvm-devel] [RFC][PATCH 1/5] rmap: add new exported function: page_wrprotect()

2008-01-21 Thread Izik Eidus
>From 45e5a255b004e0d578007576304a6b1e272fcb67 Mon Sep 17 00:00:00 2001 From: Izik Eidus <[EMAIL PROTECTED]> Date: Mon, 21 Jan 2008 16:59:35 +0200 Subject: [PATCH] rmap: add new exported function: page_wrprotect(), page_wrprotect() make the page as read only by setting the ptes point to it as r

[kvm-devel] [RFC][PATCH 2/5] add new exported function replace_page()

2008-01-21 Thread Izik Eidus
-- woof. >From c6fc21397e37481696723115cb1680f42661be48 Mon Sep 17 00:00:00 2001 From: Izik Eidus <[EMAIL PROTECTED]> Date: Mon, 21 Jan 2008 17:04:45 +0200 Subject: [PATCH] memory.c: add new exported function replace_page() replace_page() - replace the pte mapping related to vm area between two

Re: [kvm-devel] [PATCH] qemu: fix some warnings

2008-01-21 Thread Carlo Marcelo Arenas Belon
On Mon, Jan 21, 2008 at 01:46:11PM +0100, Jan Kiszka wrote: > Here are 4 more warnings fixes (actually, I should sent 2 of them to > qemu...). Nothing critical, just less noise during compilation. probably a good idea having them in independent patches as they are unrelated (other by the fact that

Re: [kvm-devel] [PATCH] qemu: fix some warnings

2008-01-21 Thread Carlo Marcelo Arenas Belon
On Mon, Jan 21, 2008 at 02:06:01PM +0100, Jan Kiszka wrote: > Jan Kiszka wrote: > > At this chance, can anyone comment on these uint32_t types? > > > > static int subpage_register (subpage_t *mmio, uint32_t start, uint32_t end, > > int memory); > > static void *subpage

Re: [kvm-devel] [PATCH] janitor: revert accidental type change

2008-01-21 Thread Carlo Marcelo Arenas Belon
On Mon, Jan 21, 2008 at 01:23:40PM +0100, Jan Kiszka wrote: > While trying to reduce the warning noise (to identify warnings of > homebrewed patches), I also came across this bogus but fortunately > harmless type change in bdrv_commit. Fix below the same fix was proposed before in : http://www.

Re: [kvm-devel] [PATCH] qemu: fix some warnings

2008-01-21 Thread Jan Kiszka
Jan Kiszka wrote: > At this chance, can anyone comment on these uint32_t types? > > static int subpage_register (subpage_t *mmio, uint32_t start, uint32_t end, > int memory); > static void *subpage_init (target_phys_addr_t base, uint32_t *phys, >

Re: [kvm-devel] [PATCH] janitor: revert accidental type change

2008-01-21 Thread Laurent Vivier
Le lundi 21 janvier 2008 à 13:23 +0100, Jan Kiszka a écrit : > While trying to reduce the warning noise (to identify warnings of > homebrewed patches), I also came across this bogus but fortunately > harmless type change in bdrv_commit. Fix below. > > Jan This has already been reported. Please a

[kvm-devel] [PATCH] mmu notifiers #v3

2008-01-21 Thread Andrea Arcangeli
On Thu, Jan 17, 2008 at 08:32:52PM +0100, Andrea Arcangeli wrote: > To make this work we still need notification from the VM about memory > pressure [..] Ok I thought some more at the aging issue of the hot kvm pages (to prevent the guest-OS very-hot working set to be swapped out). So I now hooked

[kvm-devel] [PATCH] qemu: fix some warnings

2008-01-21 Thread Jan Kiszka
Here are 4 more warnings fixes (actually, I should sent 2 of them to qemu...). Nothing critical, just less noise during compilation. At this chance, can anyone comment on these uint32_t types? static int subpage_register (subpage_t *mmio, uint32_t start, uint32_t end,

[kvm-devel] [PATCH] kvm-userland mm count skew

2008-01-21 Thread Andrea Arcangeli
I still can't see how it could be possibly make a difference for the mm_count if the kvm module is compiled inside the kernel or as an external module, the reference counting there hasn't changed since ages. The mmdrop fires only in the first overflow so even if I'm right it probably wasn't much de

[kvm-devel] [PATCH] kvm-userland swapping compat

2008-01-21 Thread Andrea Arcangeli
This is the kvm-userland patch needed to compile kvm.git as an external module on a kernel w/ MMU_NOTIFIER=n with the kvm swapping patch applied to kvm.git. Signed-off-by: Andrea Arcangeli <[EMAIL PROTECTED]> diff --git a/kernel/external-module-compat.h b/kernel/external-module-compat.h index 67b

[kvm-devel] [PATCH] kvm swapping with mmu notifiers + age_page

2008-01-21 Thread Andrea Arcangeli
This is the same as before but it uses the age_page callback to prevent the guest OS working set to be swapped out. It works well here so far. This depends on the memslot locking with mmu lock patch and on the mmu notifiers #v3 patch that I'll post in CC with linux-mm shortly that implements the ag

[kvm-devel] [PATCH] kvm memslot read-locking with mmu_lock

2008-01-21 Thread Andrea Arcangeli
This adds locking to the memslots so they can be looked up with only the mmu_lock. Entries with memslot->userspace_addr have to be ignored because they're not fully inserted yet. Signed-off-by: Andrea Arcangeli <[EMAIL PROTECTED]> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 8a90403

[kvm-devel] [PATCH] janitor: revert accidental type change

2008-01-21 Thread Jan Kiszka
While trying to reduce the warning noise (to identify warnings of homebrewed patches), I also came across this bogus but fortunately harmless type change in bdrv_commit. Fix below. Jan Index: kvm-userspace/qemu/block.c === --- kvm-u

[kvm-devel] [PATCH] SVM: fix lazy FPU switching

2008-01-21 Thread Joerg Roedel
If the guest writes to cr0 and leaves the TS flag at 0 while vcpu->fpu_active is also 0, the TS flag in the guests cr0 gets lost. This leads to corrupt FPU state an causes Windows Vista 64bit to crash very soon after boot. This patch fixes this bug. Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]>

[kvm-devel] fix a potential issue

2008-01-21 Thread Liu, Eric E
>From ab229d437b59317a322ca0efd2b0d239b74e Mon Sep 17 00:00:00 2001 From: Feng(Eric) Liu <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 17:01:29 -0500 Subject: [PATCH] kvm: mmu: fix a potential issue Since the type of gpa is u64, so extend pte_size to u64. Otherwise, a potential issue may happen.

Re: [kvm-devel] KVM swapping with mmu notifiers

2008-01-21 Thread Andrea Arcangeli
On Sun, Jan 20, 2008 at 05:16:03PM +0200, Avi Kivity wrote: > Yes, it's supposed to work (we can't prevent userspace from doing it). Hmm, I think we already prevent it, so I don't think I need to update my swap code until the below is removed. /* Check for overlaps */ r = -EEXIST;

Re: [kvm-devel] [PATCH] add acpi powerbutton support

2008-01-21 Thread Jan Kiszka
Avi Kivity wrote: > Jan Kiszka wrote: >> Guido Guenther wrote: >> >>> Hi Jan, >>> On Sat, Jan 19, 2008 at 04:40:06PM +0100, Jan Kiszka wrote: >>> What about additionally listening on signals? If you run qemu from the console, you can then just press ctrl-c to shut the guest down (

Re: [kvm-devel] [PATCH] fix reading from character devices

2008-01-21 Thread Jan Kiszka
Avi Kivity wrote: > Dor Laor wrote: >> On Mon, 2008-01-21 at 12:13 +0200, Avi Kivity wrote: >> >>> Jan Kiszka wrote: >>> Hi Avi, commit "kvm: qemu: consume all pending I/O in I/O loop" (8ab8bb09f1115b9bf733f885cc92b6c63d83f420) broke reading data bursts from serial de

Re: [kvm-devel] [PATCH] fix reading from character devices

2008-01-21 Thread Dor Laor
On Mon, 2008-01-21 at 12:50 +0200, Avi Kivity wrote: > Dor Laor wrote: > > On Mon, 2008-01-21 at 12:13 +0200, Avi Kivity wrote: > > > >> Jan Kiszka wrote: > >> > >>> Hi Avi, > >>> > >>> commit "kvm: qemu: consume all pending I/O in I/O loop" > >>> (8ab8bb09f1115b9bf733f885cc92b6c63d83f420)

Re: [kvm-devel] [PATCH] virtio: remove explicit pci ids from virtio_pci.c

2008-01-21 Thread Rusty Russell
On Monday 21 January 2008 20:12:46 Avi Kivity wrote: > Anthony Liguori wrote: > > Rusty Russell wrote: > >> Qumranet let us use their PCI vendor ID, with device ids >= 0x1000. > >> We can specify that we accept all of them in the device ID table, and > >> then return -ENODEV in the probe routine. >

Re: [kvm-devel] [RFC][PATCH 0/2]In-kernel PIT model

2008-01-21 Thread Carlo Marcelo Arenas Belon
On Mon, Jan 21, 2008 at 05:18:21PM +0800, Yang, Sheng wrote: > > The patch works well on IA32e host(passed 2.6.22, 2.6.20, 2.6.18, 2.6.16 with > hpet=disable, 2.6.9 with clock=pit), slightly off-topic but how you got around on building KVM and loading it with the undefined symbols from hpet (hrt

Re: [kvm-devel] [PATCH] fix reading from character devices

2008-01-21 Thread Avi Kivity
Dor Laor wrote: > On Mon, 2008-01-21 at 12:13 +0200, Avi Kivity wrote: > >> Jan Kiszka wrote: >> >>> Hi Avi, >>> >>> commit "kvm: qemu: consume all pending I/O in I/O loop" >>> (8ab8bb09f1115b9bf733f885cc92b6c63d83f420) broke reading data bursts >>> from serial devices (and maybe from other

Re: [kvm-devel] [PATCH] add acpi powerbutton support

2008-01-21 Thread Avi Kivity
Jan Kiszka wrote: > Hi Guido, > > [posting via gmane sucks, just re-enabled mail delivery in this account...] > > Much appreciated. > Guido Guenther wrote: > >> Hi Jan, >> On Sat, Jan 19, 2008 at 04:40:06PM +0100, Jan Kiszka wrote: >> >>> What about additionally listening on signals? I

Re: [kvm-devel] [RFC][PATCH 1/2] KVM: In-kernel PIT model

2008-01-21 Thread Avi Kivity
Jan Kiszka wrote: > I would rather stuff these parameters into KVM_CREATE_PIT right from the > beginning than later breaking the kernel/user ABI or adding a clumsy > KVM_CREATE_PIT_SPECIAL_EXTENDED_VERSION. :-> > Binary compatibility is only guaranteed between released kernel versions; develop

Re: [kvm-devel] [PATCH] fix reading from character devices

2008-01-21 Thread Dor Laor
On Mon, 2008-01-21 at 12:13 +0200, Avi Kivity wrote: > Jan Kiszka wrote: > > Hi Avi, > > > > commit "kvm: qemu: consume all pending I/O in I/O loop" > > (8ab8bb09f1115b9bf733f885cc92b6c63d83f420) broke reading data bursts > > from serial devices (and maybe from other character devices as well) by

Re: [kvm-devel] [RFC][PATCH 1/2] KVM: In-kernel PIT model

2008-01-21 Thread Carsten Otte
Jan Kiszka wrote: > The PIT may not be limited to x86 platforms. So I would propose to make > the setup more generic and flexible. And I would move the code out of > arch/x86, just the speaker support should remain there. It should also not be common among all archs. On s390 we have CPU timer, whi

Re: [kvm-devel] [RFC][PATCH 1/2] KVM: In-kernel PIT model

2008-01-21 Thread Jan Kiszka
Avi Kivity wrote: > Jan Kiszka wrote: >> The PIT may not be limited to x86 platforms. So I would propose to make >> the setup more generic and flexible. And I would move the code out of >> arch/x86, just the speaker support should remain there. >> >> I'm currently struggling with emulating a propri

Re: [kvm-devel] [RFC][PATCH 1/2] KVM: In-kernel PIT model

2008-01-21 Thread Avi Kivity
Jan Kiszka wrote: > The PIT may not be limited to x86 platforms. So I would propose to make > the setup more generic and flexible. And I would move the code out of > arch/x86, just the speaker support should remain there. > > I'm currently struggling with emulating a proprietary platform that has >

Re: [kvm-devel] [PATCH] fix reading from character devices

2008-01-21 Thread Avi Kivity
Jan Kiszka wrote: > Hi Avi, > > commit "kvm: qemu: consume all pending I/O in I/O loop" > (8ab8bb09f1115b9bf733f885cc92b6c63d83f420) broke reading data bursts > from serial devices (and maybe from other character devices as well) by > guests. Reason: serial devices do input flow control via fd_read

Re: [kvm-devel] [PATCH] add acpi powerbutton support

2008-01-21 Thread Jan Kiszka
Hi Guido, [posting via gmane sucks, just re-enabled mail delivery in this account...] Guido Guenther wrote: > Hi Jan, > On Sat, Jan 19, 2008 at 04:40:06PM +0100, Jan Kiszka wrote: >> What about additionally listening on signals? If you run qemu from the >> console, you can then just press ctrl-c

Re: [kvm-devel] [RFC][PATCH 1/2] KVM: In-kernel PIT model

2008-01-21 Thread Jan Kiszka
Yang, Sheng wrote: > --- /dev/null > +++ b/arch/x86/kvm/i8254.h ... > +#define PIT_BASE_ADDRESS 0x40 > +#define SPEAKER_BASE_ADDRESS 0x61 > +#define PIT_MEM_LENGTH 4 > +#define PIT_FREQ 1193181 The PIT may not be limited to x86 platforms. So I would propose to make th

[kvm-devel] [PATCH] fix reading from character devices

2008-01-21 Thread Jan Kiszka
Hi Avi, commit "kvm: qemu: consume all pending I/O in I/O loop" (8ab8bb09f1115b9bf733f885cc92b6c63d83f420) broke reading data bursts from serial devices (and maybe from other character devices as well) by guests. Reason: serial devices do input flow control via fd_read_poll, but qemu now ignores t

[kvm-devel] [RFC][PATCH 2/2] kvm: libkvm: In-kernel PIT model

2008-01-21 Thread Yang, Sheng
From 5f7e9bf8856602cf8ffcb50ff744ee1d0058a850 Mon Sep 17 00:00:00 2001 From: Sheng Yang <[EMAIL PROTECTED]> Date: Mon, 21 Jan 2008 16:41:47 +0800 Subject: [PATCH] kvm: libkvm: In-kernel PIT model Signed-off-by: Sheng Yang <[EMAIL PROTECTED]> --- kernel/Kbuild |2 +- libkvm/kvm-common.h

[kvm-devel] [RFC][PATCH 1/2] KVM: In-kernel PIT model

2008-01-21 Thread Yang, Sheng
From 56a50952929f9a7e78fc3ec812dd4550c623b956 Mon Sep 17 00:00:00 2001 From: Sheng Yang <[EMAIL PROTECTED]> Date: Mon, 21 Jan 2008 16:42:37 +0800 Subject: [PATCH] KVM: In-kernel PIT model Signed-off-by: Sheng Yang <[EMAIL PROTECTED]> --- arch/x86/kvm/Makefile |3 +- arch/x86/kvm/i8254.c

[kvm-devel] [RFC][PATCH 0/2]In-kernel PIT model

2008-01-21 Thread Yang, Sheng
Hi, The patch have moved PIT from QEMU to kernel, which greatly increase the accuracy of KVM guest timer. The code mostly based on QEMU and Xen's code. The patch works well on IA32e host(passed 2.6.22, 2.6.20, 2.6.18, 2.6.16 with hpet=disable, 2.6.9 with clock=pit), mostly OK on pae host(passed

Re: [kvm-devel] [PATCH] virtio: remove explicit pci ids from virtio_pci.c

2008-01-21 Thread Avi Kivity
Anthony Liguori wrote: > Rusty Russell wrote: >> Qumranet let us use their PCI vendor ID, with device ids >= 0x1000. >> We can specify that we accept all of them in the device ID table, and >> then return -ENODEV in the probe routine. >> > > I thought the device id range was smaller. Avi? > Ye