Re: [kvm-devel] [PATCH 4/8] KVM: MMU: hypercall based pte updates and TLB flushes

2008-03-04 Thread Avi Kivity
Marcelo Tosatti wrote: Hi Avi, Looks nice. On Sun, Mar 02, 2008 at 06:31:17PM +0200, Avi Kivity wrote: +int kvm_pv_mmu_op(struct kvm_vcpu *vcpu, unsigned long bytes, + gpa_t addr, unsigned long *ret) +{ +int r; +struct kvm_pv_mmu_op_buffer buffer; Perhaps

Re: [kvm-devel] [PATCH 4/8] KVM: MMU: hypercall based pte updates and TLB flushes

2008-03-04 Thread Avi Kivity
Avi Kivity wrote: As the patchset (less cr3 caching) passed the regression tests I'll apply it. Forgot about the unresolved CONFIG_HIGHPTE problem, so not applying for now. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] [PATCH 4/8] KVM: MMU: hypercall based pte updates and TLB flushes

2008-03-03 Thread Marcelo Tosatti
Hi Avi, Looks nice. On Sun, Mar 02, 2008 at 06:31:17PM +0200, Avi Kivity wrote: +int kvm_pv_mmu_op(struct kvm_vcpu *vcpu, unsigned long bytes, + gpa_t addr, unsigned long *ret) +{ + int r; + struct kvm_pv_mmu_op_buffer buffer; Perhaps this structure is a little large

[kvm-devel] [PATCH 4/8] KVM: MMU: hypercall based pte updates and TLB flushes

2008-03-02 Thread Avi Kivity
From: Marcelo Tosatti [EMAIL PROTECTED] Hypercall based pte updates are faster than faults, and also allow use of the lazy MMU mode to batch operations. Don't report the feature if two dimensional paging is enabled. v1-v2: - guest passes physical destination addr, which is cheaper than doing