Re: [kvm-devel] [PATCH 3/3] KVM: SVM: enable LBRV virtualization

2008-02-13 Thread Avi Kivity
Joerg Roedel wrote: >>> >>> >> This still has the same issue as the previous patchset: if the guest >> enables some other bit >> in MSR_IA32_DEBUCTLMSR, we silently ignore it. We should either pr_unimpl() >> on such bits or >> not handle them (ultimately injecting a #GP). >> > >

Re: [kvm-devel] [PATCH 3/3] KVM: SVM: enable LBRV virtualization

2008-02-13 Thread Joerg Roedel
On Wed, Feb 13, 2008 at 11:50:58AM +0200, Avi Kivity wrote: > Joerg Roedel wrote: > >@@ -1224,6 +1261,15 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, > >unsigned ecx, u64 data) > > if (data != 0) > > goto unhandled; > > break; > >+case MSR_IA32_D

Re: [kvm-devel] [PATCH 3/3] KVM: SVM: enable LBRV virtualization

2008-02-13 Thread Avi Kivity
Joerg Roedel wrote: > @@ -1224,6 +1261,15 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, unsigned > ecx, u64 data) > if (data != 0) > goto unhandled; > break; > + case MSR_IA32_DEBUGCTLMSR: > + svm->vmcb->save.dbgctl = data; > +