Re: [kvm-devel] virtio implementation?

2007-07-18 Thread Rusty Russell
On Tue, 2007-07-17 at 23:49 -0700, Dor Laor wrote: > >On Tue, 2007-07-17 at 06:31 -0700, Dor Laor wrote: > >> btw: Rusty - what do you think of virtio for the host? > > > >You mean backend? For networking it makes a great deal of sense. For > >block it makes far less sense (COW, weird formats, et

[kvm-devel] [PATCH 1/3] Standardize x86_64's desc_defs.h in preparation for exposure to i386.

2007-07-18 Thread Rusty Russell
KVM has independent definitions of these structures, which is bad. However, the currently (i386-derived) x86-64 ones are suboptimal. The first step is to clean them up, especially by making desc_struct a union. Additional changes: 1) s/ldttss_desc/ldttss_desc_64/ to clearly indicate it's x86-64 o

[kvm-devel] [PATCH 3/3] i386: Replace struct Xgt_desc_struct with struct desc_ptr

2007-07-18 Thread Rusty Russell
Remove i386's Xgt_desc_struct definition and use desc_def.h's desc_ptr. The offsets in asm-offsets.c do not seem to be used anywhere, so I simply removed them. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 0b03f449c0b3 arch/i386/kernel/asm-offsets.c --- a/arch/i386/kernel/asm-offsets.

[kvm-devel] [PATCH 2/3] i386: use x86_64's desc_def.h

2007-07-18 Thread Rusty Russell
The main effect is to change the definition of "struct desc_struct" to a union of more complex types. I kept the old 32-bit comparisons, but many could be changed to use the 64-bit "desc->raw". Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 656f3ff2c9ce arch/i386/kernel/cpu/common.c --

Re: [kvm-devel] KVM 29: Page fault in kernel mode while booting GNU/kFreeBSD

2007-07-18 Thread Aurelien Jarno
On Sat, Jul 14, 2007 at 07:06:18PM +0200, Aurelien Jarno wrote: > Hi, > > I have just updated my system from kvm 28 to kvm 29, and a GNU/kFreeBSD > amd64 system fails to boot with the following error: > > Fatal trap 12 with interrupts disabled > > > Fatal trap 12: page fault while in kernel

Re: [kvm-devel] virtio implementation?

2007-07-18 Thread Gerd Hoffmann
Rusty Russell wrote: > You mean backend? For networking it makes a great deal of sense. For > block it makes far less sense (COW, weird formats, etc). For block you probably want both: userspace driver which can handle all sorts of funny image files, and a kernel driver doing a 1:1 mapping to a

Re: [kvm-devel] apic+ioapiuc patch

2007-07-18 Thread Avi Kivity
Dong, Eddie wrote: > This patch is to wrap APIC base register and CR8 operation which can > provide a unique API for user level irqchip and kernel irqchip. > This is a preparation of merging lapic/ioapic patch. > > Applied and pushed, thanks. -- Do not meddle in the internals of kernels, for

Re: [kvm-devel] virtio implementation?

2007-07-18 Thread Avi Kivity
Rusty Russell wrote: > On Tue, 2007-07-17 at 23:49 -0700, Dor Laor wrote: > >>> On Tue, 2007-07-17 at 06:31 -0700, Dor Laor wrote: >>> btw: Rusty - what do you think of virtio for the host? >>> You mean backend? For networking it makes a great deal of sense. For >>> b

Re: [kvm-devel] apic+ioapiuc patch

2007-07-18 Thread Avi Kivity
Dong, Eddie wrote: > Avi: > This is the cleaned and branch check-in ready candidate patch > for lapic based on previous cr8 patch. > It needs the later ioapic patch to fully function. > > Applied. It misses a description and sign-off line. I invented a description, but please supp

Re: [kvm-devel] [PATCH 1/3] Standardize x86_64's desc_defs.h in preparation for exposure to i386.

2007-07-18 Thread Andi Kleen
On Wed, Jul 18, 2007 at 05:22:34PM +1000, Rusty Russell wrote: > However, the currently (i386-derived) x86-64 ones are suboptimal. The In what way are they suboptimal? They seem to work just fine. -Andi - This SF.net ema

Re: [kvm-devel] apic+ioapiuc patch

2007-07-18 Thread Avi Kivity
Dong, Eddie wrote: > Missed attachment. Here it is. > Applied & pushed, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. - This SF.net email is sponsored by DB2 Express Down

Re: [kvm-devel] apic+ioapiuc patch

2007-07-18 Thread Avi Kivity
Dong, Eddie wrote: > Avi: > This is the cleaned and branch check-in ready candidate patch > for lapic based on previous cr8 patch. > It needs the later ioapic patch to fully function. > > Most of userspace part is missing. -- Do not meddle in the internals of kernels, for they are

Re: [kvm-devel] apic+ioapiuc patch

2007-07-18 Thread Avi Kivity
Dong, Eddie wrote: > Missed attachment. Here it is. > The userspace part doesn't apply, it needs the missing lapic userspace patch. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.

Re: [kvm-devel] [PATCH 2/10] Trivial: Remove KVM_IRQ_BITMAP macro

2007-07-18 Thread Avi Kivity
Rusty Russell wrote: > On Tue, 2007-07-17 at 16:25 +0300, Avi Kivity wrote: > >> Rusty Russell wrote: >> >>> Creating one's own BITMAP macro seems suboptimal: if we use manual >>> arithmetic in the one place exposed to userspace, we can use standard >>> macros elsewhere. >>> >>> The - 7 + 8

Re: [kvm-devel] hlt emulation for in kernel apic/ioapic

2007-07-18 Thread Avi Kivity
Dong, Eddie wrote: > Rebased hlt emulation for in kernel APIC/PIC/IOAPIC base on Greg's > original V09. > > > Applied the kernel side. Please resend the missing user side patchset. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. --

Re: [kvm-devel] [PATCH 1/10] Trivial: /dev/kvm interface is no longer experimental.

2007-07-18 Thread Avi Kivity
Rusty Russell wrote: > On Tue, 2007-07-17 at 18:35 +0200, Arnd Bergmann wrote: > >> On Tuesday 17 July 2007, Rusty Russell wrote: >> >>> KVM interface is no longer experimental. >>> >>> Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> >>> >>> diff -r 4e57f5c6d4a9 include/linux/kvm.h >>> ---

Re: [kvm-devel] [PATCH 1/10] Trivial: /dev/kvm interface is no longer experimental.

2007-07-18 Thread Avi Kivity
Arnd Bergmann wrote: > The equivalent of the current set of ioctls comes down to roughtly this > set of syscalls: > > int kvm_create_vm(void); > int kvm_get_msr_index_list(int fd, sttuct kvm_msr_list); > size_t kvm_get_vcpu_mmap_size(int fd); > int kvm_set_memory_region(int fd, unsigned slot, unsig

Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi; 18 Tem 2007 Çar tarihinde, Anthony Liguori şunları yazmıştı: > Can you reproduce without the appArmor patchset? If needed http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole is the appArmor patchset included kernel's output captured with netconsole and yes i'll try to reproduce same with

Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread Avi Kivity
S.Çağlar Onur wrote: > Hi; > > 18 Tem 2007 Çar tarihinde, Anthony Liguori şunları yazmıştı: > >> Can you reproduce without the appArmor patchset? >> > > If needed http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole is the > appArmor > patchset included kernel's output captured with netc

Re: [kvm-devel] apic+ioapiuc patch

2007-07-18 Thread Dong, Eddie
Avi Kivity wrote: > Dong, Eddie wrote: >> Avi: >> This is the cleaned and branch check-in ready candidate patch >> for lapic based on previous cr8 patch. >> It needs the later ioapic patch to fully function. >> >> > > Most of userspace part is missing. > ??? I don't need the user side

Re: [kvm-devel] apic+ioapiuc patch

2007-07-18 Thread Avi Kivity
Dong, Eddie wrote: > Avi Kivity wrote: > >> Dong, Eddie wrote: >> >>> Avi: >>> This is the cleaned and branch check-in ready candidate patch >>> for lapic based on previous cr8 patch. >>> It needs the later ioapic patch to fully function. >>> >>> >>> >> Most of userspace part

Re: [kvm-devel] apic+ioapiuc patch

2007-07-18 Thread Dong, Eddie
> Well, the ioapic userspace patch removes some nonexistent code that I > assume the lapic userspace patch should have added. > O, this is a temp hack added by in kernel PIC. Maybe the branch mismatch. Here is the resent one. The sequence is: lapic ioapic hlt thx,eddie

[kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Or Sagi
Gentlepeople, We're currently working on PCI device pass-through support for KVM. In this model all physical hardware access to specific devices will be performed by the VM, and not by the host. In particular, this requires interrupt handling to be done by the guest -- The host shouldn't load the

Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi; 18 Tem 2007 Çar tarihinde, Avi Kivity şunları yazmıştı: > S.Çağlar Onur wrote: > > Hi; > > > > 18 Tem 2007 Çar tarihinde, Anthony Liguori şunları yazmıştı: > >> Can you reproduce without the appArmor patchset? > > > > If needed http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole is the > > a

Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi; 18 Tem 2007 Çar tarihinde, S.Çağlar Onur şunları yazmıştı: > http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole_wo_apparmor is the > vanilla one's netconsole output, by the way without apparmor patchset > system not hard freezes. Ahhh netconsole cannot grab whole output, full log from kern

Re: [kvm-devel] [PATCH 1/3] KVM - Add missing kvm_run initializations

2007-07-18 Thread Avi Kivity
Jeff Dike wrote: > On Tue, Jul 17, 2007 at 11:12:53AM +0300, Avi Kivity wrote: > >> I believe that emulate_instruction will set run->mmio if it returns >> EMULATE_DO_MMIO. >> > > Righto, forgot to check that. How about this patch instead? > > Set exit_reason to KVM_EXIT_MMIO where run->mm

Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi; 18 Tem 2007 Çar tarihinde, Avi Kivity şunları yazmıştı: > > http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole_wo_apparmor is the > > vanilla one's netconsole output, by the way without apparmor patchset > > system not hard freezes. > > This trace is certainly a kvm bug. What guest are you

Re: [kvm-devel] apic+ioapiuc patch

2007-07-18 Thread Avi Kivity
Dong, Eddie wrote: >> Well, the ioapic userspace patch removes some nonexistent code that I >> assume the lapic userspace patch should have added. >> >> > O, this is a temp hack added by in kernel PIC. Maybe the branch > mismatch. > > Here is the resent one. The sequence is: > lapic >

Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread Avi Kivity
S.Çağlar Onur wrote: > Hi; > > 18 Tem 2007 Çar tarihinde, Avi Kivity şunları yazmıştı: > >> S.Çağlar Onur wrote: >> >>> Hi; >>> >>> 18 Tem 2007 Çar tarihinde, Anthony Liguori şunları yazmıştı: >>> Can you reproduce without the appArmor patchset? >>> If needed http

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Alan Cox
> In particular, this requires interrupt handling to be done by the guest -- > The host shouldn't load the corresponding device driver or otherwise access > the device. Since the host kernel is not aware of the device semantics it > cannot acknowledge the interrupt at the device level. Tricky inde

Re: [kvm-devel] [PATCH 1/3] Standardize x86_64's desc_defs.h in preparation for exposure to i386.

2007-07-18 Thread Rusty Russell
On Wed, 2007-07-18 at 11:03 +0200, Andi Kleen wrote: > On Wed, Jul 18, 2007 at 05:22:34PM +1000, Rusty Russell wrote: > > However, the currently (i386-derived) x86-64 ones are suboptimal. The > > In what way are they suboptimal? This was badly worded. They're "suboptimal" for use by i386 (ie.

Re: [kvm-devel] [kvm-commits] Revert "kvm: qemu: initialize ata ports as enabled"

2007-07-18 Thread Gregory Haskins
On Wed, 2007-07-18 at 12:20 +0300, Avi Kivity wrote: > repository: /home/avi/kvm > branch: master > commit a4d8dd22718d59fbdbaddaaed0b0e0c4664f397d > Author: Avi Kivity <[EMAIL PROTECTED]> > Date: Wed Jul 18 12:20:41 2007 +0300 > > Revert "kvm: qemu: initialize ata ports as enabled" > >

Re: [kvm-devel] [kvm-commits] Revert "kvm: qemu: initialize ata ports as enabled"

2007-07-18 Thread Avi Kivity
Gregory Haskins wrote: > On Wed, 2007-07-18 at 12:20 +0300, Avi Kivity wrote: > >> repository: /home/avi/kvm >> branch: master >> commit a4d8dd22718d59fbdbaddaaed0b0e0c4664f397d >> Author: Avi Kivity <[EMAIL PROTECTED]> >> Date: Wed Jul 18 12:20:41 2007 +0300 >> >> Revert "kvm: qemu: initi

Re: [kvm-devel] [kvm-commits] Revert "kvm: qemu: initialize ata ports as enabled"

2007-07-18 Thread Gregory Haskins
On Wed, 2007-07-18 at 15:42 +0300, Avi Kivity wrote: > > > Good question. I initially guessed that when the bios turns them on, it > does other things as well, but that's not the case. Ah, I was wondering that myself. I noticed from Dave's diffed dmesg output that you do see the PIIX driver

Re: [kvm-devel] kvm developers' forum 2007

2007-07-18 Thread Rami Tamir
Following the invitation below, you can now find the updated agenda for 'kvm developres' forum 2007' at: http://www.qumranet.com/agenda.php. See you all at Tucson! Rami -Original Message- From: Rami Tamir Sent: Wednesday, July 04, 2007 10:14 PM To: kvm-devel@lists.sourceforge.net; '[EMAI

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Lennart Sorensen
On Wed, Jul 18, 2007 at 12:53:19PM +0300, Or Sagi wrote: > Gentlepeople, > > We're currently working on PCI device pass-through support for KVM. In this > model all physical hardware access to specific devices will be performed by > the VM, and not by the host. > > In particular, this requires in

Re: [kvm-devel] [PATCH 3/3] KVM - add hypercall nr to kvm_run

2007-07-18 Thread Anthony Liguori
Jeff Dike wrote: > On Tue, Jul 17, 2007 at 09:15:51AM -0500, Anthony Liguori wrote: > >> I'm planning on breaking this interface again since the new hypercall >> API only takes 4 arguments instead of 6. >> > > Is anything written anywhere about this hypercall interface? > I've posted p

Re: [kvm-devel] [PATCH 2/3] i386: use x86_64's desc_def.h

2007-07-18 Thread Zachary Amsden
Rusty Russell wrote: > The main effect is to change the definition of "struct desc_struct" to > a union of more complex types. > Yay! Someone finally killed it. Every time I tried to kill it, I ended up off in the weeds chasing some bug. > > diff -r 656f3ff2c9ce arch/i386/kernel/process.c

[kvm-devel] [PATCH] i386: Decouple PAE from CONFIG_CMPXCHG64

2007-07-18 Thread Avi Kivity
Commit 9d9bbd4d247a674deb43565582151acdc22e90d1 makes CONFIG_CMPXCHG64 dependent on CONFIG_HIGHMEM64G, but KVM guest SMP support now also requires CMPXCHG64 while not being tied to PAE. So the effect of that patch is to disable KVM on non-PAE configs. Untangle those dependencies by: - having KVM

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Dor Laor
>> In particular, this requires interrupt handling to be done by the >guest -- >> The host shouldn't load the corresponding device driver or otherwise >access >> the device. Since the host kernel is not aware of the device semantics >it >> cannot acknowledge the interrupt at the device level. > >Tr

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Alan Cox
> What if we will force the specific device to the end of the list. Once > IRQ_NONE was returned by the other devices, we will mask the irq, > forward the irq to the guest, issue a timer for 1msec. Motivation: > 1msec is long enough for the guest to ack the irq + host unmask the irq It makes no di

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Avi Kivity
Alan Cox wrote: >> What if we will force the specific device to the end of the list. Once >> IRQ_NONE was returned by the other devices, we will mask the irq, >> forward the irq to the guest, issue a timer for 1msec. Motivation: >> 1msec is long enough for the guest to ack the irq + host unmask the

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Alan Cox
> IMO the only reasonable solution is to disallow interrupt forwarding > with shared irqs. If someone later comes up with a bright idea, we can Which means you are back to ISA bus devices. Even checking if an IRQ is currently unshared isn't simple as with hotplug this may change. > implement it.

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Avi Kivity
Alan Cox wrote: >> IMO the only reasonable solution is to disallow interrupt forwarding >> with shared irqs. If someone later comes up with a bright idea, we can >> > > Which means you are back to ISA bus devices. Even checking if an IRQ is > currently unshared isn't simple as with hotplug th

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Alan Cox
> Hotplug is user-controllable, so if the user refrains from adding pci > devices after assigning a device to the guest, it should work. I think > that USB interrupts are assigned to the controller, not the device, so > USB hotplug can be ruled out. Cardbus is more problematic. Alan ---

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Dor Laor
>Alan Cox wrote: >>> What if we will force the specific device to the end of the list. >Once >>> IRQ_NONE was returned by the other devices, we will mask the irq, >>> forward the irq to the guest, issue a timer for 1msec. Motivation: >>> 1msec is long enough for the guest to ack the irq + host unma

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Alan Cox
> >>Guest0 - blocked on I/O > >> > >>IRQ14 from your hardware > >>Block IRQ14 > >>Sent to guest (guest is blocked) > >> > >>IRQ14 from hard disk > >>Ignored (as blocked) > >> > > > But now the timer will pop and the hard disk will get its irq

Re: [kvm-devel] [PATCH 3/3] KVM - add hypercall nr to kvm_run

2007-07-18 Thread Jeff Dike
On Wed, Jul 18, 2007 at 11:28:18AM -0500, Anthony Liguori wrote: > Within the kernel right (VMCALL is only usable in ring 1). Yup. > Is it > terribly important to be able to pass through the syscall arguments in > registers verses packing them in a data structure and passing a pointer > to t

Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi Avi; 18 Tem 2007 Çar tarihinde, Avi Kivity şunları yazmıştı: > This trace is certainly a kvm bug. What guest are you running? If it > is free (and does not contain private information), can you post it > somewhere for me to download? After seeing your "[PATCH] i386: Decouple PAE from CONFIG

Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread Avi Kivity
S.Çağlar Onur wrote: > Hi Avi; > > 18 Tem 2007 Çar tarihinde, Avi Kivity şunları yazmıştı: > >> This trace is certainly a kvm bug. What guest are you running? If it >> is free (and does not contain private information), can you post it >> somewhere for me to download? >> > > After seeing

Re: [kvm-devel] [PATCH 10/10] Use standard CR8 flags, and fix TPR definition

2007-07-18 Thread Avi Kivity
H. Peter Anvin wrote: > Rusty Russell wrote: > >> Intel manual (and KVM definition) say it's TPR is 4 bits wide. Also fix >> CR8_RESEVED_BITS typo. >> >> Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> >> > > Indeed it is. > > Acked-by: H. Peter Anvin <[EMAIL PROTECTED]> > > Applied-b

Re: [kvm-devel] [PATCH] i386: Decouple PAE from CONFIG_CMPXCHG64

2007-07-18 Thread Andi Kleen
On Wed, Jul 18, 2007 at 07:34:47PM +0300, Avi Kivity wrote: > Commit 9d9bbd4d247a674deb43565582151acdc22e90d1 makes CONFIG_CMPXCHG64 > dependent on CONFIG_HIGHMEM64G, but KVM guest SMP support now also > requires CMPXCHG64 while not being tied to PAE. So the effect of that patch > is to disable KV

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Lennart Sorensen
On Wed, Jul 18, 2007 at 07:46:13PM +0300, Avi Kivity wrote: > IMO the only reasonable solution is to disallow interrupt forwarding > with shared irqs. If someone later comes up with a bright idea, we can > implement it. Otherwise the problem will solve itself with hardware > moving to msi. Disal

Re: [kvm-devel] [PATCH 3/3] KVM - add hypercall nr to kvm_run

2007-07-18 Thread Anthony Liguori
Jeff Dike wrote: > On Wed, Jul 18, 2007 at 11:28:18AM -0500, Anthony Liguori wrote: > >> Within the kernel right (VMCALL is only usable in ring 1). >> > > Yup. > > >> Is it >> terribly important to be able to pass through the syscall arguments in >> registers verses packing them in a

Re: [kvm-devel] accessing USB disk-on-key from windows (under KVM)

2007-07-18 Thread Ian Brown
Hello, Thanks, Anthony. I tried both #2 and #3. It does not say any error, but still I cannot access the USB disk on key. Maybe I miss something ? Here are few more details. When I ran: /usr/local/kvm/bin/qemu-system-x86_64 -usbdevice disk:/dev/sdb /work/kvm/win2003/vdisk.img -m 384 OR /usr/loc

Re: [kvm-devel] accessing USB disk-on-key from windows (under KVM)

2007-07-18 Thread Anthony Liguori
Ian Brown wrote: > Hello, > > Thanks, Anthony. > > I tried both #2 and #3. > > It does not say any error, but still I cannot access the USB disk on key. > Maybe I miss something ? > Here are few more details. > > When I ran: > /usr/local/kvm/bin/qemu-system-x86_64 -usbdevice disk:/dev/sdb > /work/k

Re: [kvm-devel] accessing USB disk-on-key from windows (under KVM)

2007-07-18 Thread Daniel P. Berrange
On Wed, Jul 18, 2007 at 10:32:06PM +0300, Ian Brown wrote: > Hello, > > Thanks, Anthony. > > I tried both #2 and #3. > > It does not say any error, but still I cannot access the USB disk on key. > Maybe I miss something ? > Here are few more details. > > When I ran: > /usr/local/kvm/bin/qemu-sy

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Dor Laor
>> >> Guest0 - blocked on I/O >> >> >> >> IRQ14 from your hardware >> >> Block IRQ14 >> >> Sent to guest (guest is blocked) >> >> >> >> IRQ14 from hard disk >> >> Ignored (as blocked) >> >> >> >> >> But now the timer will pop and the hard disk will get its

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Alan Cox
> - Make the device the last irqaction in the list > - Our dummy handler will always return IRQ_HANDLED in case any other > previous > irqaction did not return such. It will also issue the timer and mask > the irq in this case. Ok > btw, if I'm not mistaken only after bad 99900/10 the irq

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Or Sagi
> Hope it should work like the following [Please correct me if I'm > wrong]: > - Make the device the last irqaction in the list > - Our dummy handler will always return IRQ_HANDLED in case any other > previous > irqaction did not return such. It will also issue the timer and mask > the irq in th

Re: [kvm-devel] [PATCH 2/3] i386: use x86_64's desc_def.h

2007-07-18 Thread Rusty Russell
On Wed, 2007-07-18 at 09:19 -0700, Zachary Amsden wrote: > > +#define GET_CONTENTS(desc) (((desc)->raw32.b >> 10) & 3) > > +#define GET_WRITABLE(desc) (((desc)->raw32.b >> 9) & 1) > > You got rid of the duplicate definitions here, but then added new > duplicates (GET_CONTENTS / WRITABLE). Can y

Re: [kvm-devel] [PATCH 2/3] i386: use x86_64's desc_def.h

2007-07-18 Thread Rusty Russell
On Thu, 2007-07-19 at 09:27 +1000, Rusty Russell wrote: > On Wed, 2007-07-18 at 09:19 -0700, Zachary Amsden wrote: > > > +#define GET_CONTENTS(desc) (((desc)->raw32.b >> 10) & 3) > > > +#define GET_WRITABLE(desc) (((desc)->raw32.b >> 9) & 1) > > > > You got rid of the duplicate defini

Re: [kvm-devel] [PATCH 1/10] Trivial: /dev/kvm interface is no longer experimental.

2007-07-18 Thread Arnd Bergmann
On Wednesday 18 July 2007, Avi Kivity wrote: > > Once we're back to using fds, we might as well use ioctls.  If anything, > an ioctl has an explicit mention of the structure it manipulates in its > definition.  I don't care that it came in last in the last 15 annual > kernel beauty contests. > >

Re: [kvm-devel] virtio implementation?

2007-07-18 Thread Arnd Bergmann
On Wednesday 18 July 2007, Gerd Hoffmann wrote: > Rusty Russell wrote: > > You mean backend?  For networking it makes a great deal of sense.  For > > block it makes far less sense (COW, weird formats, etc). > > For block you probably want both:  userspace driver which can handle all > sorts of fun

Re: [kvm-devel] virtio implementation?

2007-07-18 Thread Anthony Liguori
Arnd Bergmann wrote: > On Wednesday 18 July 2007, Gerd Hoffmann wrote: > >> Rusty Russell wrote: >> >>> You mean backend? For networking it makes a great deal of sense. For >>> block it makes far less sense (COW, weird formats, etc). >>> >> For block you probably want both: usersp

[kvm-devel] [PATCH] move structures to svm/vmx.c, use untyped arch_data in independent code

2007-07-18 Thread Paul Turner
From: Paul Turner <[EMAIL PROTECTED]> Since gcc can't handle [0]-sized arrays without type information we have to use a generic type and then cast to remove arch dependencies from the vcpu struct; this patch moves the structures (and the associated include dependency) from kvm.h into svm/vmx.c

Re: [kvm-devel] [PATCH] move structures to svm/vmx.c, use untyped arch_data in independent code

2007-07-18 Thread Anthony Liguori
Paul Turner wrote: > From: Paul Turner <[EMAIL PROTECTED]> > > Since gcc can't handle [0]-sized arrays without type information we have > to use a generic type and then cast to remove arch dependencies from the > vcpu struct; this patch moves the structures (and the associated > include dependen

Re: [kvm-devel] virtio implementation?

2007-07-18 Thread Arnd Bergmann
On Thursday 19 July 2007, Anthony Liguori wrote: > > Interestingly, once you have the kernel driver that maps a block device, > > you can do most of the useful user scenarios by means of /dev/loop > > and/or device mapper. > > Not quite.  Using device mapper to implement something like qcow turns

Re: [kvm-devel] [PATCH] move structures to svm/vmx.c, use untyped arch_data in independent code

2007-07-18 Thread Paul Turner
< fixing avi's email address in headers, woops > - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.

[kvm-devel] rename KVM_CAP_PIC to KVM_CAP_IRQCHIP

2007-07-18 Thread Dong, Eddie
Rename KVM_CREATE_PIC to KVM_CREATE_IRQCHIP KVM_CAP_PIC to KVM_PIC_IRQCHIP since now it is not only PIC. Signed-off-by: Yaozu (Eddie) Dong <[EMAIL PROTECTED]> against lapic2 branch. diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h index d7e16ba..3ce3e48 10

Re: [kvm-devel] [PATCH 2/3] i386: use x86_64's desc_def.h

2007-07-18 Thread Andi Kleen
On Thu, Jul 19, 2007 at 09:27:41AM +1000, Rusty Russell wrote: > On Wed, 2007-07-18 at 09:19 -0700, Zachary Amsden wrote: > > > +#define GET_CONTENTS(desc) (((desc)->raw32.b >> 10) & 3) > > > +#define GET_WRITABLE(desc) (((desc)->raw32.b >> 9) & 1) > > > > You got rid of the duplicate

Re: [kvm-devel] [PATCH] i386: Decouple PAE from CONFIG_CMPXCHG64

2007-07-18 Thread H. Peter Anvin
Andi Kleen wrote: >> >> No processors that support KVM exist that also do not support CMPXCHG64, >> so no additional check is necessary. This setup allows for a single kernel >> that will boot on i486 and also support KVM if available. > > The CONFIG should only control the early CPUID checks, wh

Re: [kvm-devel] virtio implementation?

2007-07-18 Thread Anthony Liguori
Arnd Bergmann wrote: > On Thursday 19 July 2007, Anthony Liguori wrote: > >>> Interestingly, once you have the kernel driver that maps a block device, >>> you can do most of the useful user scenarios by means of /dev/loop >>> and/or device mapper. >>> >> Not quite. Using device mapper to

Re: [kvm-devel] virtio implementation?

2007-07-18 Thread Daniel P. Berrange
On Thu, Jul 19, 2007 at 01:48:21AM +0200, Arnd Bergmann wrote: > On Wednesday 18 July 2007, Gerd Hoffmann wrote: > > Rusty Russell wrote: > > > You mean backend?  For networking it makes a great deal of sense.  For > > > block it makes far less sense (COW, weird formats, etc). > > > > For block yo

Re: [kvm-devel] [PATCH] move structures to svm/vmx.c, use untyped arch_data in independent code

2007-07-18 Thread Anthony Liguori
Paul Turner wrote: >> >> > + struct vmcs *vmcs; >> >> + struct kvm_vcpu vcpu; >> > > In this approach you might as well embed that at the start so that the > arch independent code can still allocate/free, that or move the memory > alloc/dealloc entirely to the arch specific code. Although

Re: [kvm-devel] virtio implementation?

2007-07-18 Thread Avi Kivity
Arnd Bergmann wrote: > On Thursday 19 July 2007, Anthony Liguori wrote: > >>> Interestingly, once you have the kernel driver that maps a block device, >>> you can do most of the useful user scenarios by means of /dev/loop >>> and/or device mapper. >>> >> Not quite. Using device mapper to