Re: [kvm-devel] [PATCH] Re: CodingStyle cleanup (Resubmit - fixed DSO)

2007-10-07 Thread Avi Kivity
Mike Day wrote: CodingStyle cleanup for kvm.h Signed-off-by: Mike D. Day [EMAIL PROTECTED] Please resend, the replies got me confused as to which patches are valid and which aren't. This should be done as one patch; there's no need to split a code style cleanup per file.

Re: [kvm-devel] [PATCH 2/2] Use getopt() for kvmctl

2007-10-07 Thread Avi Kivity
Anthony Liguori wrote: kvmctl does its own parsing of argc/argv. Other than being hard to maintain, the recent --smp addition seems to have broken -32. This patch switches kvmctl to use getopt(). This changes the -32 option to --protected-mode (or -p). This patch also adds a --help

Re: [kvm-devel] [PATCH] remove duplicate code

2007-10-07 Thread Avi Kivity
Glauber de Oliveira Costa wrote: This patch removes duplicate code at vl.c. Once the KVM-only part defines how much physicall memory it wants, the rest should be the same for everybody. Signed-off-by: Glauber de Oliveira Costa [EMAIL PROTECTED] --- qemu/vl.c | 23 +--

Re: [kvm-devel] [PATCH] [2/2] Split arch specific makefile code out

2007-10-07 Thread Avi Kivity
Jerone Young wrote: This patch makes things better for cross compiling. It also makes adding a new architecture to the current make system much easier. +CFLAGS += -I $(KERNELDIR)/include $(autodepend-flags) -g -fomit-frame-pointer \ + -Wall +CFLAGS += -m32 +CFLAGS += -m64

Re: [kvm-devel] [PATCH] [1/2] Update user configure script

2007-10-07 Thread Avi Kivity
Jerone Young wrote: This adds the ability to change CC, ARCH, LD variables with configure script in user directory. Applied, thanks. -- Any sufficiently difficult bug is indistinguishable from a feature. - This

Re: [kvm-devel] User feedback

2007-10-07 Thread Wolfram Gloger
Anthony Liguori writes: http://kvm.qumranet.com/kvmwiki/AnthonyLiguori/Networking This is for Ubuntu but it probably works in Debian too. It uses NAT instead of bridging and it is what I use on my desktop. Good advice, but why use a bridge interface _at all_ in this case? I have the following

[kvm-devel] Good project!

2007-10-07 Thread www . qqywj . com
Dear friends, Sorry to bother you.We are a large-scale merchandise wholesaler in China, Our merchandise such as,Tv,notebooks,phones,psp,projectors,motorcycles,musical instruments ect.Our products are in good quality,but low price,it will interest you.At the same time,we can supple you the direct

[kvm-devel] x86 -cpu option: Take 4

2007-10-07 Thread Dan Kenigsberg
Hi, Due to comments on Take 3, I rewrote the feature name list according to Intel's and AMD's specs in order not to contaminate target-i386 with GPL code. More importantly - the host cpu type is dropped. It will be added, as a kvm-specific code, in a future patch. I'd be happy to hear if patch

Re: [kvm-devel] User feedback

2007-10-07 Thread Anthony Liguori
Wolfram Gloger wrote: Anthony Liguori writes: http://kvm.qumranet.com/kvmwiki/AnthonyLiguori/Networking This is for Ubuntu but it probably works in Debian too. It uses NAT instead of bridging and it is what I use on my desktop. Good advice, but why use a bridge interface _at all_

[kvm-devel] [ kvm-Bugs-1808970 ] CDROM eject doesn't work via Qemu Monitor

2007-10-07 Thread SourceForge.net
Bugs item #1808970, was opened at 2007-10-07 16:42 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=1808970group_id=180599 Please note that this message will contain a full copy of

Re: [kvm-devel] out of memory page request

2007-10-07 Thread David Brown
Can you run 'gdb /path/to/kvm.ko' and post the output of 'disassemble ioapic_mmio_write' please? Sorry for not getting back sooner. (gdb) disassemble ioapic_mmio_write Dump of assembler code for function ioapic_mmio_write: 0xf540 ioapic_mmio_write+0: mov%edx,%r8d

[kvm-devel] Virtual Samba server using kvm

2007-10-07 Thread Franco Spinelli
Is KVM the correct choice for using in a virtual Samba server? Virtual server read from an ISCSI storage (2xGb network) and serve a LAN on a 100 Mb network I am not a list subscriber Regards Franco Spinelli - This SF.net

[kvm-devel] [RFC] let kvm be compiled with gcc4 and prevent users to shoot themselves in the foot while doing so (was Re: [ kvm-Bugs-1807620 ] KVM's --disable-gcc-check doesn't work)

2007-10-07 Thread Carlo Marcelo Arenas Belon
On Thu, Oct 04, 2007 at 04:39:30PM -0400, Gregory Haskins wrote: On Thu, 2007-10-04 at 21:49 +0200, Farkas Levente wrote: here i mean that packaging kvm for fedora/redhat/centos using gcc-4.x in stead of gcc-3.x. if currently there is no reason to use gcc-3.x than i change all of my spec

Re: [kvm-devel] [RFC] let kvm be compiled with gcc4 and prevent users to shoot themselves in the foot while doing so (was Re: [ kvm-Bugs-1807620 ] KVM's --disable-gcc-check doesn't work)

2007-10-07 Thread Jim Paris
Carlo Marcelo Arenas Belon wrote: And considering also there might be other yet unknown bugs because of gcc4, it is most likely better to stick to use gcc-3.x, unless there is really no other option. For cases where no compat-gcc package is provided (like in OpenSUSE) then the following is

[kvm-devel] [PATCH 1/3] kvm_free_lapic() to pair with kvm_create_lapic()

2007-10-07 Thread Rusty Russell
Instead of the asymetry of kvm_free_apic, implement kvm_free_lapic(). And guess what? I found a minor bug: we don't need to hrtimer_cancel() from kvm_main.c, because we do that in kvm_free_apic(). Also: 1) kvm_vcpu_uninit should be the reverse order from kvm_vcpu_init. 2) Don't set

[kvm-devel] [PATCH 2/3] Hoist kvm_create_lapic() into kvm_vcpu_init()

2007-10-07 Thread Rusty Russell
Move kvm_create_lapic() into kvm_vcpu_init(), rather than having svm and vmx do it. And make it return the error rather than a fairly random -ENOMEM. This also solves the problem that neither svm.c nor vmx.c actually handles the error path properly. Signed-off-by: Rusty Russell [EMAIL

[kvm-devel] [PATCH 3/3] Remove gratuitous casts from lapic.c

2007-10-07 Thread Rusty Russell
Since vcpu-apic is of the correct type, there's not need to cast. Perhaps this will be required in future? Signed-off-by: Rusty Russell [EMAIL PROTECTED] diff --git a/drivers/kvm/lapic.c b/drivers/kvm/lapic.c index 27e6249..68aa9e4 100644 --- a/drivers/kvm/lapic.c +++ b/drivers/kvm/lapic.c @@

Re: [kvm-devel] [PATCH] [2/2] Split arch specific makefile code out

2007-10-07 Thread Jerone Young
On Sun, 2007-10-07 at 13:50 +0200, Avi Kivity wrote: Jerone Young wrote: This patch makes things better for cross compiling. It also makes adding a new architecture to the current make system much easier. +CFLAGS += -I $(KERNELDIR)/include $(autodepend-flags) -g

Re: [kvm-devel] [RFC] KVM Source layout Proposal to accommodate new CPU architecture

2007-10-07 Thread Zhang, Xiantao
Avi Kivity wrote: Zhang, Xiantao wrote: Avi Kivity wrote: Zhang, Xiantao wrote: Zhang, Xiantao wrote: Hi Avi, So you mean IA64 can adopt the similar method as well? What method do you mean exactly? Put all arch-specific files into arch/ia64/kvm as you described in

Re: [kvm-devel] [RFC] KVM Source layout Proposal to accommodate new CPU architecture

2007-10-07 Thread Hollis Blanchard
On Mon, 2007-10-08 at 10:36 +0800, Zhang, Xiantao wrote: Avi Kivity wrote: Zhang, Xiantao wrote: Avi Kivity wrote: Zhang, Xiantao wrote: Zhang, Xiantao wrote: Hi Avi, So you mean IA64 can adopt the similar method as well? What method do you mean exactly?

Re: [kvm-devel] [RFC] KVM Source layout Proposal to accommodate newCPU architecture

2007-10-07 Thread Zhang, Xiantao
Hollis Blanchard wrote: On Mon, 2007-10-08 at 10:36 +0800, Zhang, Xiantao wrote: Avi Kivity wrote: Zhang, Xiantao wrote: Avi Kivity wrote: Zhang, Xiantao wrote: Zhang, Xiantao wrote: Hi Avi, So you mean IA64 can adopt the similar method as well? What method do you

[kvm-devel] [PATCH 2/5] Enable configure script in user directory for cross compile

2007-10-07 Thread Jerone Young
This patch enables configure script in user directory fro cross compile. Signed-off-by: Jerone Young [EMAIL PROTECTED] diff -r 7c1e3915d77c configure --- a/configure Thu Oct 04 14:33:18 2007 -0500 +++ b/configure Thu Oct 04 14:34:26 2007 -0500 @@ -20,6 +20,7 @@ usage() {

[kvm-devel] [PATCH 1/5] Enable top level configure script for cross compile

2007-10-07 Thread Jerone Young
This patch adds cross compile capability to the top level configure script. Signed-off-by: Jerone Young [EMAIL PROTECTED] diff -r f48e521e0add configure --- a/configure Wed Oct 03 21:00:03 2007 -0500 +++ b/configure Thu Oct 04 14:59:16 2007 -0500 @@ -5,13 +5,17 @@ want_module=1 want_module=1

[kvm-devel] [PATCH 5/5] Add user/config-x86-64.mak

2007-10-07 Thread Jerone Young
This patch adds file user/config-x86-64.mak. This file contains x86-64 specific make rules. Signed-off-by: Jerone Young [EMAIL PROTECTED] diff -r cd1ff95ab7c4 user/config-x86_64.mak --- /dev/null Thu Jan 01 00:00:00 1970 + +++ b/user/config-x86_64.mak Thu Oct 04 08:35:56 2007 -0500 @@ -0,0

[kvm-devel] [PATCH 3/5] Enable Makefile in user directory for cross compile

2007-10-07 Thread Jerone Young
This patch enables the Makefile in user directory for cross compile. It also adds new feature of having architecture specific make rules split into their own respective files. Signed-off-by: Jerone Young [EMAIL PROTECTED] diff -r dc203848af90 user/Makefile --- a/user/Makefile Sun Oct 07 23:11:14

[kvm-devel] [PATCH 4/5] Add user/config-i386.mak

2007-10-07 Thread Jerone Young
This patch adds file user/config-i386.mak. This file contains i386 specific make rules. Signed-off-by: Jerone Young [EMAIL PROTECTED] diff -r 1ec77d7c5e51 user/config-i386.mak --- /dev/null Thu Jan 01 00:00:00 1970 + +++ b/user/config-i386.mak Thu Oct 04 08:33:37 2007 -0500 @@ -0,0 +1,7 @@