Re: [kvm-devel] What should I do for kvm development first?

2007-11-18 Thread Izik Eidus
On Sat, 2007-11-17 at 23:02 -0800, Neo Jia wrote: > On Nov 17, 2007 7:47 AM, Izik Eidus <[EMAIL PROTECTED]> wrote: > > > > Dan Kenigsberg wrote: > > > On Fri, Nov 16, 2007 at 09:46:03PM -0800, Neo Jia wrote: > > > > > >> I synced with kvm.git and kvm-userspace.git. Do I have to rebuild and > > >>

Re: [kvm-devel] [PATCH] Split kvm_create_vm and kvm_destory_vm to support arch

2007-11-18 Thread Avi Kivity
Zhang, Xiantao wrote: > KVM Portability: Add two arch hooks to handle kvm_create_vm and > kvm destroy_vm. Now, just put io_bus init and destory in common. > 1. kvm_arch_create_vm > 2. kvm_arch_destroy_vm > This doesn't apply. Is it against some older codebase? -- error compiling committee.c

Re: [kvm-devel] [PATCH] Move kvm_vcpu_ioctl_translation implementation to arch

2007-11-18 Thread Avi Kivity
Zhang, Xiantao wrote: > This is the preparation for moving mmu code to arch. Since mmu code in > arch, translation functionality should be implemented for every arch. > Xiantao > > Applied, thanks. -- error compiling committee.c: too many arguments to function --

Re: [kvm-devel] Unhandled vm exit with old protected mode test

2007-11-18 Thread Avi Kivity
Jan Kiszka wrote: > Hi, > > running some oldish 286 protected mode demo in kvm, I came across this > bug of kvm-52: > > unhandled vm exit: 0x8021 vcpu_id 0 > ds (0010/ p 1 dpl 3 db 0 s 1 type 3 l 0 g 0 avl 0) > > ds.base must equal ds.sel<<4 when entering real-mode on Intel

Re: [kvm-devel] [PATCH] KVM: x86 emulator: Discard CR2 in x86 emulator

2007-11-18 Thread Avi Kivity
Sheng Yang wrote: > From f8aca5afbc018e71dc37d2e6001bcec376499939 Mon Sep 17 00:00:00 2001 > From: Sheng Yang <[EMAIL PROTECTED]> > Date: Fri, 16 Nov 2007 16:29:15 +0800 > Subject: [PATCH] KVM: x86 emulator: Discard CR2 in x86 emulator > > For CR2 is unreliable and unavailable in many condition, th

[kvm-devel] [ kvm-Bugs-1833976 ] Network Emulation Model Incompele

2007-11-18 Thread SourceForge.net
Bugs item #1833976, was opened at 2007-11-18 12:48 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1833976&group_id=180599 Please note that this message will contain a full copy

Re: [kvm-devel] [PATCH] Split kvm_create_vm and kvm_destory_vm to support arch

2007-11-18 Thread Zhang, Xiantao
Avi Kivity wrote: > Zhang, Xiantao wrote: >> KVM Portability: Add two arch hooks to handle kvm_create_vm and >> kvm destroy_vm. Now, just put io_bus init and destory in common. >> 1. kvm_arch_create_vm >> 2. kvm_arch_destroy_vm >> > > This doesn't apply. Is it against some older codebase? Maybe

Re: [kvm-devel] What should I do for kvm development first?

2007-11-18 Thread Neo Jia
On Nov 18, 2007 2:47 AM, Avi Kivity <[EMAIL PROTECTED]> wrote: > Neo Jia wrote: > > > > Thank you for your response! Now, I can build modules from kvm.git > > instead of build the whole kernel. > > > > Any comments for the TODO item or bug I need to pick up first? > > > > It depends on your knowle

Re: [kvm-devel] [PATCH] check shadow_pte == NULL in FNAME(page_fault); drivers/kvm/paging_tmpl.h

2007-11-18 Thread Avi Kivity
Roel Kluin wrote: > #--# > in function FNAME(page_fault), drivers/kvm/paging_tmpl.h, line 450, (linus' > git) > > I think a check is in place. I am not sure whether this is how it should be > done, nor was the patch below

Re: [kvm-devel] What should I do for kvm development first?

2007-11-18 Thread Avi Kivity
Neo Jia wrote: > Another question is about the architecture, I found it seems that the > 32-bit platform is much more stable than 64-bit. Should I switch my > system to 64-bit for later work? > Where do you get this impression? I do almost all of my development on 64-bit, and I don't recall a

Re: [kvm-devel] [PATCH] - drivers/kvm/* - remove ptr comparisons to 0

2007-11-18 Thread Avi Kivity
Joe Perches wrote: > fix sparse warnings "Using plain integer as NULL pointer" > > Applied, thanks. -- error compiling committee.c: too many arguments to function - This SF.net email is sponsored by: Microsoft Defy all

Re: [kvm-devel] [PATCH] [RESEND] qemu: simulate edge-triggered interrupt in master PIC for time-drift-fix

2007-11-18 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > The following patch fixes 1a483ef4040ed380bf69d684783d06a617073256 so that the > parent PIC pointer is used to send the edge irq0 instead of the PIC pair and > that is an incompatible pointer type as reported in : > > qemu/hw/i8259.c: In function `pic_read_irq'

Re: [kvm-devel] What should I do for kvm development first?

2007-11-18 Thread Avi Kivity
Neo Jia wrote: > hi, > > I am trying to contribute some (just starting some bug fix first) for > KVM development. > > But, I want know first what those experienced kvm developer do > everyday for the development work. > > I synced with kvm.git and kvm-userspace.git. Do I have to rebuild and > insta

Re: [kvm-devel] [PATCH] Split kvm_create_vm and kvm_destory_vm to support arch

2007-11-18 Thread Avi Kivity
Zhang, Xiantao wrote: > Avi Kivity wrote: > >> Zhang, Xiantao wrote: >> >>> KVM Portability: Add two arch hooks to handle kvm_create_vm and >>> kvm destroy_vm. Now, just put io_bus init and destory in common. >>> 1. kvm_arch_create_vm >>> 2. kvm_arch_destroy_vm >>> >>> >> This doesn'

Re: [kvm-devel] What should I do for kvm development first?

2007-11-18 Thread Neo Jia
On Nov 18, 2007 3:04 AM, Avi Kivity <[EMAIL PROTECTED]> wrote: > Neo Jia wrote: > > Another question is about the architecture, I found it seems that the > > 32-bit platform is much more stable than 64-bit. Should I switch my > > system to 64-bit for later work? > > > > Where do you get this impres

Re: [kvm-devel] [PATCH] Remove __init attribute for two functions.

2007-11-18 Thread Avi Kivity
Zhang, Xiantao wrote: > Remove __init attributes for kvm_init_debug and kvm_init_msr_list, since > their callers are not declared with __init. It maybe introduce prolems, > once kvm is built-in while kvm-intel or kvm-amd is built as module. > Applied, thanks. We will want to redo __init and _

Re: [kvm-devel] What should I do for kvm development first?

2007-11-18 Thread Avi Kivity
Neo Jia wrote: > On Nov 18, 2007 3:04 AM, Avi Kivity <[EMAIL PROTECTED]> wrote: > >> Neo Jia wrote: >> >>> Another question is about the architecture, I found it seems that the >>> 32-bit platform is much more stable than 64-bit. Should I switch my >>> system to 64-bit for later work? >>> >

Re: [kvm-devel] What should I do for kvm development first?

2007-11-18 Thread Avi Kivity
Neo Jia wrote: > > Thank you for your response! Now, I can build modules from kvm.git > instead of build the whole kernel. > > Any comments for the TODO item or bug I need to pick up first? > It depends on your knowledge of the x86 architecture and experience in virtualization. If you have l

Re: [kvm-devel] [PATCH] KVM portability split : move mmu code to arch

2007-11-18 Thread Avi Kivity
Zhang, Xiantao wrote: > According to privious decisions, mmu code should be moved to arch. > > >From 43a629932b6babcbf2af75299192c1d77c2393d5 Mon Sep 17 00:00:00 2001 > From: Zhang Xiantao <[EMAIL PROTECTED]> > Date: Fri, 16 Nov 2007 13:16:40 +0800 > Subject: [PATCH] KVM: MMU split for portabilit

Re: [kvm-devel] [PATCH] Split kvm_create_vm and kvm_destory_vm to support arch

2007-11-18 Thread Zhang, Xiantao
Avi Kivity wrote: > Zhang, Xiantao wrote: >> Avi Kivity wrote: >> >>> Zhang, Xiantao wrote: >>> KVM Portability: Add two arch hooks to handle kvm_create_vm and kvm destroy_vm. Now, just put io_bus init and destory in common. 1. kvm_arch_create_vm 2. kvm_arch_destroy_vm >

[kvm-devel] para virtualized kvm virtio drivers and performance comparing to Xen

2007-11-18 Thread Mark Ryden
Hello, I saw in this mailing list (kvm-devel) that there is a git tree which uses Rusty Russel virtio API. The intention that this tree will be integrated inot mainstream in the near future. (for example, http://www.mail-archive.com/kvm-devel@lists.sourceforge.net/msg08854.html). My question is

[kvm-devel] [RFT] embedded kvm distribution: endemics

2007-11-18 Thread Gildas
Hello all, 2 months ago, I had a discussion [1] on this Mailing-List with Haydn Solomon and Wes Felter about KVM and the raging competition on the hypervisor market. I am perfectly aware that this is a technical Mailing-List so I'll try to cut the business crap short, but still I think every comp

Re: [kvm-devel] [PATCH] KVM: x86 emulator: Discard CR2 in x86 emulator

2007-11-18 Thread Sheng Yang
On Sunday 18 November 2007 18:35:22 Avi Kivity wrote: > Sheng Yang wrote: > > From f8aca5afbc018e71dc37d2e6001bcec376499939 Mon Sep 17 00:00:00 2001 > > From: Sheng Yang <[EMAIL PROTECTED]> > > Date: Fri, 16 Nov 2007 16:29:15 +0800 > > Subject: [PATCH] KVM: x86 emulator: Discard CR2 in x86 emulator

Re: [kvm-devel] para virtualized kvm virtio drivers and performance comparing to Xen

2007-11-18 Thread Anthony Liguori
Mark Ryden wrote: > Hello, > > I saw in this mailing list (kvm-devel) that there is a git tree > which uses Rusty Russel virtio API. The intention that this tree will be > integrated inot mainstream in the near future. > > (for example, > http://www.mail-archive.com/kvm-devel@lists.sourceforge.net/

Re: [kvm-devel] KVM: SVM: Disable Lazy FPU optimization because of regressions

2007-11-18 Thread Avi Kivity
Amit Shah wrote: > >From 76204eda7e03035c16702105e78724137ecad24b Mon Sep 17 00:00:00 2001 > From: Amit Shah <[EMAIL PROTECTED]> > Date: Sun, 18 Nov 2007 22:42:47 +0530 > Subject: [PATCH] KVM: SVM: Disable Lazy FPU optimization because of > regressions > > Host FPU state is leaked into the guest F

Re: [kvm-devel] KVM: SVM: Disable Lazy FPU optimization because of regressions

2007-11-18 Thread Amit Shah
On Sunday 18 November 2007 22:58:56 Avi Kivity wrote: > Amit Shah wrote: > > diff --git a/drivers/kvm/svm.c b/drivers/kvm/svm.c > > index ea2cb83..d7c9b92 100644 > > --- a/drivers/kvm/svm.c > > +++ b/drivers/kvm/svm.c > > @@ -1600,11 +1600,11 @@ static void svm_set_cr3(struct kvm_vcpu *vcpu, > > u

Re: [kvm-devel] KVM: Use write_emulated and not write_std, which is not implemented

2007-11-18 Thread Avi Kivity
Amit Shah wrote: > From 554315592b05eabf0355ac63145c28e11358af1f Mon Sep 17 00:00:00 2001 > From: Amit Shah <[EMAIL PROTECTED]> > Date: Sun, 18 Nov 2007 00:03:27 +0530 > Subject: [PATCH] KVM: Use write_emulated and not write_std, which is not > implemented > > ... and calling write_emulated should

[kvm-devel] KVM: SVM: Disable Lazy FPU optimization because of regressions

2007-11-18 Thread Amit Shah
>From 76204eda7e03035c16702105e78724137ecad24b Mon Sep 17 00:00:00 2001 From: Amit Shah <[EMAIL PROTECTED]> Date: Sun, 18 Nov 2007 22:42:47 +0530 Subject: [PATCH] KVM: SVM: Disable Lazy FPU optimization because of regressions Host FPU state is leaked into the guest FPU state. This happens because

[kvm-devel] KVM: Use write_emulated and not write_std, which is not implemented

2007-11-18 Thread Amit Shah
>From 554315592b05eabf0355ac63145c28e11358af1f Mon Sep 17 00:00:00 2001 From: Amit Shah <[EMAIL PROTECTED]> Date: Sun, 18 Nov 2007 00:03:27 +0530 Subject: [PATCH] KVM: Use write_emulated and not write_std, which is not implemented ... and calling write_emulated should work just as well in place o

[kvm-devel] [PATCH] KVM: Make unloading of FPU state when putting vcpu arch-independent

2007-11-18 Thread Amit Shah
Instead of having each architecture do it individually, we do this in the arch-independent code (just x86 as of now). Turns out SVM did not do this at all. Signed-off-by: Amit Shah <[EMAIL PROTECTED]> --- drivers/kvm/vmx.c |1 - drivers/kvm/x86.c |1 + 2 files changed, 1 insertions(+), 1

Re: [kvm-devel] [PATCH] KVM: Make unloading of FPU state when putting vcpu arch-independent

2007-11-18 Thread Avi Kivity
Amit Shah wrote: > Instead of having each architecture do it individually, we > do this in the arch-independent code (just x86 as of now). > Turns out SVM did not do this at all. > > Applied, thanks. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] KVM: SVM: Disable Lazy FPU optimization because of regressions

2007-11-18 Thread Mike Lampard
On Mon, 19 Nov 2007 03:44:51 am Amit Shah wrote: > >From 76204eda7e03035c16702105e78724137ecad24b Mon Sep 17 00:00:00 2001 > > From: Amit Shah <[EMAIL PROTECTED]> > Date: Sun, 18 Nov 2007 22:42:47 +0530 > Subject: [PATCH] KVM: SVM: Disable Lazy FPU optimization because of > regressions > > Host FPU

Re: [kvm-devel] KVM: SVM: Disable Lazy FPU optimization because of regressions

2007-11-18 Thread Amit Shah
On Sunday 18 November 2007 23:49:38 Mike Lampard wrote: > This patch didnt resolve the font issues for me, however the other patch > (unload FPU state) did fix it.  I didnt run the test app (no compiler on > the (32bit ubuntu) guest atm) but reverting this patch on my tree didnt > appear to adverse

Re: [kvm-devel] What should I do for kvm development first?

2007-11-18 Thread Neo Jia
Avi Kivity wrote: > Neo Jia wrote: >> On Nov 18, 2007 3:04 AM, Avi Kivity <[EMAIL PROTECTED]> wrote: >> >>> Neo Jia wrote: >>> Another question is about the architecture, I found it seems that the 32-bit platform is much more stable than 64-bit. Should I switch my system to 64-

[kvm-devel] FW: [PATCH] KVM portability split : move mmu code to arch

2007-11-18 Thread Zhang, Xiantao
Avi Kivity wrote: > Zhang, Xiantao wrote: >> According to privious decisions, mmu code should be moved to arch. >> >>> From 43a629932b6babcbf2af75299192c1d77c2393d5 Mon Sep 17 00:00:00 >>> 2001 >> From: Zhang Xiantao <[EMAIL PROTECTED]> >> +kvm_arch_set_memory_region(kvm, mem, user_a

[kvm-devel] [PATCH][1/3] Move kvm_vcpu_iotcl_get_dirty_log to arch

2007-11-18 Thread Zhang, Xiantao
Move kvm_vcpu_ioctl_get_dirty_log to arch, and still keep the interface in common. 0001-KVM-portability-Move-kvm_vcpu_ioctl_get_dirty_log-t.patch Description: 0001-KVM-portability-Move-kvm_vcpu_ioctl_get_dirty_log-t.patch - T

[kvm-devel] [PATCH] 0/3 MMU code split

2007-11-18 Thread Zhang, Xiantao
Hi Avi, Considering your comments,I refined the patch, and use kvm->memslots to caculate the nr_mmu_pagas every time. Patch [1/3] Move kvm_vcpu_iotcl_get_dirty_log implementation into arch, and still keep the interface in common. Patch [2/3] Move kvm_mmu init and exit functionality to arch. Pat

[kvm-devel] Add the hook kvm_arch_set_memory region to hold mmu-specific changes

2007-11-18 Thread Zhang, Xiantao
Patch [3/3] Add the hook kvm_arch_set_memory_region. In this patch, introduce a function kvm_caculate_mmu_pages to compute mmu pages in total, once memory region changes. Xiantao 0003-KVM-Portability-Split-kvm_set_memory_region.patch Description: 0003-KVM-Portability-Split-kvm_set_memory_region

[kvm-devel] [Patch][2/3] Move kvm_mmu init and exit functionality to arch.

2007-11-18 Thread Zhang, Xiantao
Move kvm_mmu init and exit functionality to arch. Xiantao 0002-KVM-Portability-MMU-split.patch Description: 0002-KVM-Portability-MMU-split.patch - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft

Re: [kvm-devel] What should I do for kvm development first?

2007-11-18 Thread Avi Kivity
Neo Jia wrote: > Another question is about the architecture, I found it seems that the > 32-bit platform is much more stable than 64-bit. Should I switch my > system to 64-bit for later work? > > > Where do you get this impression? I do almost al