Re: [kvm-devel] kvm-userspace fails to compile

2008-01-15 Thread Christoph Hellwig
On Mon, Jan 07, 2008 at 03:25:50PM +0100, Laurent Vivier wrote: > > Perhaps a ./configure is needed. > > > > What's your HEAD? I have a5b3d2c9b4d4ca3e02f294d14c7df016e070bda7, > > which compiles fine. > > OK, I found where is the problem: my KERNELDIR is not the good one. > > Thank you for the

Re: [kvm-devel] kvm-userspace fails to compile

2008-01-15 Thread Christoph Hellwig
On Tue, Jan 15, 2008 at 05:55:20PM +0200, Avi Kivity wrote: > That's the plan, but since things work for most people that area is not > seeing much attention. The problem areas are compiling userspace against > older kernels, and that's not something we do often. Well, the point is there should

Re: [kvm-devel] current kvm userspace git doesn't compile on i386

2008-01-15 Thread Christoph Hellwig
On Sun, Jan 13, 2008 at 01:37:11PM +0200, Uri Lublin wrote: > Try to build the kernel modules too (remove '--with-patched-kernel' from > ./configure arguments ): > ./configure --prefix=/opt/kvm --qemu-cc=/usr/bin/gcc-3.4 ; make -C > kernel LINUX= sync; make > You will have to rmmod current kvm mo

Re: [kvm-devel] kvm-userspace fails to compile

2008-01-15 Thread Christoph Hellwig
On Tue, Jan 15, 2008 at 07:44:09PM +0200, Avi Kivity wrote: > Yes, you're right. My confusion arose because we have two distinct needs > for a "kernel directory": > > 1. A build directory for the external module (which really needs to be a > kernel directory) > 2. A directory with the exported u

Re: [kvm-devel] [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd()

2008-03-06 Thread Christoph Hellwig
On Wed, Feb 27, 2008 at 03:42:42PM -0800, Roland Dreier wrote: > > > http://git.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=commit;h=49be4f8114e6ff0efdab10ebba2493fb67bc3034 > > Actually, looking closer at the kvm changes here, I think that > create_vcpu_fd() needs the same treatment as kv

Re: [kvm-devel] [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd()

2008-03-17 Thread Christoph Hellwig
On Sat, Mar 08, 2008 at 06:45:34PM -0800, Roland Dreier wrote: > >spin_lock(&kvm_lock); > > + if (--kvm->refcount) { > > + spin_lock(&kvm_lock); > > obvious typo here... Indeed. Any comments from the kvm developers in this approach? The current multi-level file refcounting seem

Re: [kvm-devel] [RFC/PATCH 14/15] guest: detect when running on kvm

2008-03-20 Thread Christoph Hellwig
On Thu, Mar 20, 2008 at 05:25:26PM +0100, Carsten Otte wrote: > @@ -143,6 +143,10 @@ static noinline __init void detect_machi > /* Running on a P/390 ? */ > if (cpuinfo->cpu_id.machine == 0x7490) > machine_flags |= 4; > + > + /* Running under KVM ? */ > + if (cpuin

Re: [kvm-devel] [RFC/PATCH 14/15] guest: detect when running on kvm

2008-03-20 Thread Christoph Hellwig
On Thu, Mar 20, 2008 at 09:37:19PM +0100, Carsten Otte wrote: > Christoph Hellwig wrote: >> On Thu, Mar 20, 2008 at 05:25:26PM +0100, Carsten Otte wrote: >>> @@ -143,6 +143,10 @@ static noinline __init void detect_machi >>> /* Running on a P/390 ? */ >>

Re: [kvm-devel] [PATCH 1 of 4] Add "make sync" to sync need kernel headers to kvm-userspace

2008-04-14 Thread Christoph Hellwig
On Mon, Apr 14, 2008 at 03:37:04AM -0500, Jerone Young wrote: > 2 files changed, 25 insertions(+), 4 deletions(-) > Makefile | 21 - > configure |8 +--- > > > This patch adds ability for kvm-userspace build system to sync needed kernel > headers locally without the

Re: [kvm-devel] [PATCH 1 of 4] Add "make sync" to sync need kernel headers to kvm-userspace

2008-04-14 Thread Christoph Hellwig
On Mon, Apr 14, 2008 at 02:47:16PM +0300, Avi Kivity wrote: >> Please just keep a copy of the kernel headers in the userspace tree so >> it can be built standalone. >> >> > > The tarballs do contain a copy of the kernel headers; the 'make sync' > mechanism is for developers to generate the tarb

Re: [kvm-devel] [PATCH] Export three symbols for kvm use.

2007-12-20 Thread Christoph Hellwig
On Thu, Dec 20, 2007 at 01:57:01PM +0800, Zhang, Xiantao wrote: > Hi Tony, > In order to build kvm source successfully, we need to export > three symbols for kvm use. Please review. Maybe Avi can check-in to > kvm.git upstream first. > > Thanks > Xiantao > From: Zhang Xiantao <[EMAIL PROTE

Re: [kvm-devel] [Qemu-devel] Re: [PATCH] e1000 emulation code

2008-01-10 Thread Christoph Hellwig
On Thu, Jan 10, 2008 at 03:36:19PM +, Paul Brook wrote: > > the next step would be to emulate LSI SCSI chips, eh? > > Qemu already does. Quite a different one from vmware, though :) - Check out the new SourceForge.net M

[kvm-devel] current kvm userspace git doesn't compile on i386

2008-01-12 Thread Christoph Hellwig
Current kvm userspace git configured with ./configure --prefix=/opt/kvm --with-patched-kernel --qemu-cc=/usr/bin/gcc-3.4 gives: /usr/bin/gcc-3.4 -L /home/hch/work/kvm-userspace/qemu/../libkvm -g -o qemu-system-x86_64 vl.o osdep.o monitor.o pci.o loader.o isa_mmio.o migration.o block-raw-posix

Re: [kvm-devel] current kvm userspace git doesn't compile on i386

2008-01-13 Thread Christoph Hellwig
On Sun, Jan 13, 2008 at 01:37:11PM +0200, Uri Lublin wrote: > Try to build the kernel modules too (remove '--with-patched-kernel' from > ./configure arguments ): > ./configure --prefix=/opt/kvm --qemu-cc=/usr/bin/gcc-3.4 ; make -C > kernel LINUX= sync; make > You will have to rmmod current kvm mo

Re: [kvm-devel] [PATCH/RFC 7/9] Virtual network guest device driver

2007-05-23 Thread Christoph Hellwig
On Wed, May 23, 2007 at 03:16:50PM +0300, Avi Kivity wrote: > Christoph Hellwig wrote: > > On Tue, May 22, 2007 at 10:00:42AM -0700, ron minnich wrote: > > > >> On 5/22/07, Eric Van Hensbergen <[EMAIL PROTECTED]> wrote: > >> > >> > >&

Re: [kvm-devel] [PATCH RFC 2/3] Virtio draft III: example net driver

2007-06-25 Thread Christoph Hellwig
On Mon, Jun 25, 2007 at 10:26:37AM -0500, Brian King wrote: > 1. The add_inbuf interface passes an sg list. This causes problems for >ibmveth since its rx buffers cannot be scatterlists. > 2. The user of this API does not have access to the sk_buf. This causes >issues for ibmveth since it n

Re: [kvm-devel] [RFC 0/8]KVM: swap out guest pages

2007-07-23 Thread Christoph Hellwig
On Mon, Jul 23, 2007 at 01:27:40PM +0300, Avi Kivity wrote: > Having an address_space (like your patch does) is remarkably simple, and > requires few hooks from the current vm. However using existing vmas > mapped by the user has many advantages: Actually it requires lots of deep down VM intern

Re: [kvm-devel] [RFC 0/8]KVM: swap out guest pages

2007-07-23 Thread Christoph Hellwig
On Mon, Jul 23, 2007 at 03:29:36PM +0300, Avi Kivity wrote: > >Actually it requires lots of deep down VM internals symbols that'll never > >get exported. > > > > > > What's "it" here? kvm-specific address space or generic vmas. The patches in this thread. > Generic vmas will be more intrusive

Re: [kvm-devel] [RFC] 9p: add KVM/QEMU pci transport

2007-08-28 Thread Christoph Hellwig
On Tue, Aug 28, 2007 at 01:52:38PM -0500, Eric Van Hensbergen wrote: > +config NET_9P_PCI > + depends on NET_9P > + tristate "9p PCI Shared Memory Transport (Experimental)" shouldn't this depend on CONFIG_PCI? - This

Re: [kvm-devel] [PATCH 001/104] KVM: Fix *nopage() in kvm_main.c

2007-09-17 Thread Christoph Hellwig
On Mon, Sep 17, 2007 at 10:30:43AM +0200, Avi Kivity wrote: > From: Nguyen Anh Quynh <[EMAIL PROTECTED]> > > *nopage() in kvm_main.c should only store the type of mmap() fault if > the pointers are not NULL. This patch fixes the problem. Care to convert it to ->faul while you're at it? -

Re: [kvm-devel] [PATCH 3/3] KVM: Expose MSRs to userspace

2006-11-17 Thread Christoph Hellwig
On Thu, Nov 16, 2006 at 09:17:18PM +0200, Avi Kivity wrote: > Heh. That was the original implementation by Uri. I felt that was > wrong because _IOW() encodes the size in the ioctl number, bit the > actual size is different. That really shouldn't be a problem. After all the pointer approach d

Re: [kvm-devel] [PATCH 19/38] KVM: Make __set_efer() an arch operation

2006-11-27 Thread Christoph Hellwig
On Mon, Nov 27, 2006 at 12:29:38PM -, Avi Kivity wrote: > #ifdef __x86_64__ > - __set_efer(vcpu, sregs->efer); > + kvm_arch_ops->set_efer(vcpu, sregs->efer); > #endif I think it would be much better to make ->set_efer a noop for 32bit, and have different operation vectors for 32 vs 6

Re: [kvm-devel] [PATCH 1/38] KVM: Create kvm-intel.ko module

2006-11-30 Thread Christoph Hellwig
On Mon, Nov 27, 2006 at 01:36:06PM +0100, Ingo Molnar wrote: > > * Avi Kivity <[EMAIL PROTECTED]> wrote: > > > --- linux-2.6.orig/drivers/kvm/kvm.h > > +++ linux-2.6/drivers/kvm/kvm.h > > please move this from drivers/kvm/ to kernel/kvm/ [or even into a > toplevel kvm/ directory] - KVM is not a

Re: [kvm-devel] [PATCH 1/38] KVM: Create kvm-intel.ko module

2006-11-30 Thread Christoph Hellwig
On Thu, Nov 30, 2006 at 09:19:35PM +0100, Ingo Molnar wrote: > > I get the feeling we'd be best off if we were to revisit this in a > > year or so. > > yeah. I'd suggest merging it as-is into v2.6.20. In a year we'll have > some real APIs to think about. Agreed. And because of that I think kee

Re: [kvm-devel] [announce] [patch] KVM paravirtualization for Linux

2007-01-07 Thread Christoph Hellwig
On Sat, Jan 06, 2007 at 01:08:18PM +, Pavel Machek wrote: > Does this make Xen obsolete? I mean... we have xen patches in suse > kernels, should we keep updating them, or just drop them in favour of > KVM? After all the Novell Marketing Hype you'll probably have to keep Xen ;-) Except for that

Re: [kvm-devel] [PATCH] Add irqdevice interface + userint implementation

2007-04-08 Thread Christoph Hellwig
> diff --git a/drivers/kvm/kvm_irqdevice.h b/drivers/kvm/kvm_irqdevice.h > new file mode 100644 > index 000..9c91d15 > --- /dev/null > +++ b/drivers/kvm/kvm_irqdevice.h > @@ -0,0 +1,206 @@ > +/* > + * kvm_irqdevice.h No need to mention the file name in the top of file comment. Quite contrary,

Re: [kvm-devel] [PATCH] Add irqdevice interface + userint implementation

2007-04-08 Thread Christoph Hellwig
On Sun, Apr 08, 2007 at 01:23:15PM +0300, Avi Kivity wrote: > Christoph Hellwig wrote: > >>+/*-- > >>+ * optimized bitarray object - works like bitarrays in bitops, but uses > >>+ * a summary field t

Re: [kvm-devel] [PATCH] Add irqdevice interface + userint implementation

2007-04-10 Thread Christoph Hellwig
On Mon, Apr 09, 2007 at 04:27:54PM -0400, Gregory Haskins wrote: > Here is the next pass of the patch with changes based on feedback. > > I still have not converted over to kerneldoc format as I cannot find an > example anywhere yet, and the documentation under > Documentation/kernel-doc-nano-HO

Re: [kvm-devel] irqdevice INTR example

2007-04-12 Thread Christoph Hellwig
On Thu, Apr 12, 2007 at 11:02:25AM +0300, Avi Kivity wrote: > If you want condition variables, activate your cryogenically-cooled suit > and post on it on lkml. This cannot be added to the kernel via kvm. Better just rip it out. The code would be a lot simpler with opencoded waitqueue use, and

Re: [kvm-devel] [PATCH/RFC 2/2] s390 virtualization interface.

2007-05-02 Thread Christoph Hellwig
On Tue, May 01, 2007 at 11:12:11PM +0200, Arnd Bergmann wrote: > Not sure about that point. If you need to do atomic operations on the > first 32 bits, you shouldn't need to invent your own abstractions for > those, and it's highly unlikely that the implementation of atomic_t changes. I disagree.

Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-14 Thread Christoph Hellwig
On Mon, May 14, 2007 at 06:14:31PM +0300, Avi Kivity wrote: > Dong, Eddie wrote: > > OK, how about this patch which further reduce the light weight VM Exit > > MSR save/restore? > > > > > > diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c > > index 1288cff..ef96fae 100644 > > --- a/driv

Re: [kvm-devel] [PATCH 5/9] KVM: Adds ability to signal userspace using a file-descriptor

2007-05-15 Thread Christoph Hellwig
On Tue, May 15, 2007 at 12:18:17PM -0400, Gregory Haskins wrote: > >>> On Tue, May 15, 2007 at 11:40 AM, in message > <[EMAIL PROTECTED]>, Davide Libenzi > <[EMAIL PROTECTED]> wrote: > > > > I don't know how critical is the path where you will be doing check. The > > eventfd_fget() is pretty fast

Re: [kvm-devel] [RFC]kvm: swapout guest page

2007-05-21 Thread Christoph Hellwig
On Mon, May 21, 2007 at 11:17:06AM +0200, Carsten Otte wrote: > Shaohua Li wrote: > > +EXPORT_SYMBOL(delete_from_swap_cache); > > +EXPORT_SYMBOL(move_to_swap_cache); > > +EXPORT_SYMBOL(lookup_swap_cache); > > +EXPORT_SYMBOL(read_swap_cache_async); > > +EXPORT_SYMBOL(get_swap_page); > > +EXPORT_SYMB

Re: [kvm-devel] [PATCH/RFC 7/9] Virtual network guest device driver

2007-05-22 Thread Christoph Hellwig
On Tue, May 22, 2007 at 07:49:51AM -0500, Eric Van Hensbergen wrote: > > In the general case, you can't pass a command line argument to Linux > > either. kvm doesn't boot Linux; it boots the bios, which boots the boot > > sector, which boots grub, which boots Linux. Relying on the user to > > edi

Re: [kvm-devel] [PATCH/RFC 7/9] Virtual network guest device driver

2007-05-22 Thread Christoph Hellwig
On Tue, May 22, 2007 at 10:00:42AM -0700, ron minnich wrote: > On 5/22/07, Eric Van Hensbergen <[EMAIL PROTECTED]> wrote: > > >I'm not opposed to supporting emulation environments, just don't make > >a large pile of crap the default like Xen -- and having to integrate > >PCI probing code in my gue