API changes:
- __virtio_config_val() just becomes a striaght vdev->config_get() call.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/block/virtio_blk.c |4 +--
drivers/virtio/virtio_balloon.c |6 ++---
include/linux/virtio_con
On Wednesday 09 April 2008 01:44:04 Andrea Arcangeli wrote:
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -1050,6 +1050,15 @@
> unsigned long addr, unsigned long len,
> unsigned long flags, struct page **pages);
>
> +str
On Tuesday 22 April 2008 21:22:48 Avi Kivity wrote:
> > The virtio config space was originally chosen to be little-endian,
> > because we thought the config might be part of the PCI config space
> > for virtio_pci. It's actually a separate mmio region, so that
> > argument holds little water; as o
On Tuesday 22 April 2008 17:44:08 Christian Borntraeger wrote:
> Am Dienstag, 22. April 2008 schrieb Rusty Russell:
> > [Christian, Hollis, how much is this ABI breakage going to hurt you?]
>
> It is ok for s390 at the moment. We are still working on making userspace
> ready an
On Wednesday 23 April 2008 06:29:14 Hollis Blanchard wrote:
> On Tuesday 22 April 2008 09:31:35 Rusty Russell wrote:
> > We may still regret not doing *everything* little-endian, but this
> > doesn't make it worse.
>
> Hmm, why *don't* we just do everything LE, incl
On Wednesday 23 April 2008 20:55:50 Christian Borntraeger wrote:
> Am Dienstag, 22. April 2008 schrieb Rusty Russell:
> [...]
>
> > diff -r a098f19a6da5 include/linux/virtio_config.h
> > --- a/include/linux/virtio_config.h Sun Apr 20 14:41:02 2008 +1000
> > +++ b/includ
On Wednesday 23 April 2008 20:57:00 Christian Borntraeger wrote:
> Rusty,
>
> is there a reason why we dont export the virtio headers for
> 9p, balloon, console, pci, and virtio_ring? kvm uses make sync,
> but I think it is still useful to heave these headers exported
> as they might be useful for
te callbacks.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
diff -r 219d6c116996 drivers/s390/kvm/kvm_virtio.c
--- a/drivers/s390/kvm/kvm_virtio.c Mon May 05 10:03:16 2008 +1000
+++ b/drivers/s390/kvm/kvm_virtio.c Mon May 05 10:17:25 2008 +1000
@@ -78,27 +78,34 @@ static un
On Thursday 08 May 2008 23:20:38 Christian Borntraeger wrote:
> Changing stop_machine to yield the cpu to the hypervisor when yielding
> inside the guest fixed the problem for me. While I am not completely happy
> with this patch, I think it causes no harm and it really improves the
> situation for
On Friday 16 May 2008 19:17:03 Christian Borntraeger wrote:
> Hello Rusty,
>
> sometimes it is useful to share a disk (e.g. usr). To avoid file system
> corruption, the disk should be mounted read-only in that case. This patch
> adds a new feature flag, that allows the host to specify, if the disk
On Friday 16 May 2008 19:28:27 Tomasz Chmielewski wrote:
> Christian Borntraeger schrieb:
> > Hello Rusty,
> >
> > sometimes it is useful to share a disk (e.g. usr). To avoid file system
> > corruption, the disk should be mounted read-only in that case.
>
> Although it is done at a different level
eover, the target is best expressed in balloon size, since there is
no portable way of getting the total RAM in the system. The host can
do the math.
Tested with a (fairly hacky) lguest patch.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/virtio/Kconfig | 10 +
dri
On Thursday 17 January 2008 13:14:58 Anthony Liguori wrote:
> Rusty Russell wrote:
> > +static struct virtio_device_id id_table[] = {
> > + { VIRTIO_ID_BALLOON, VIRTIO_DEV_ANY_ID},
>
> Could use a space after VIRTIO_DEV_ANY_ID
Thanks, fixed.
> > +
On Thursday 17 January 2008 15:01:46 Anthony Liguori wrote:
> Rusty Russell wrote:
> > OTOH it's currently pretty obvious (and usually fatal) if the guest has
> > trouble meeting the balloon requirements. A serious host needs a way of
> > detecting stress in the guest
t that's the worst that can
happen.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/virtio/virtio_pci.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff -r 4edff5e24614 drivers/virtio/virtio_pci.c
--- a/drivers/virtio/virtio_pci.c Sun Jan 20
On Monday 21 January 2008 20:12:46 Avi Kivity wrote:
> Anthony Liguori wrote:
> > Rusty Russell wrote:
> >> Qumranet let us use their PCI vendor ID, with device ids >= 0x1000.
> >> We can specify that we accept all of them in the device ID table, and
> >> t
Since we want to reset the device to remove them, this is simpler
(device is reset for us on driver remove).
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/net/virtio_net.c | 44 +---
1 file changed, 25 insertions(+), 19 deletions(-)
t the buffers won't be used by the guest, and
3) It helps the guest recover from messed-up drivers.
So we remove the ->shutdown hook, and the only way we now remove
feature bits is via reset.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/char/hw_random/virtio-rng.
On Saturday 22 December 2007 02:27:04 Dor Laor wrote:
> From 20a01e0c24f47e9805a88bebc9310163f99b5e99 Mon Sep 17 00:00:00 2001
> From: Dor Laor <[EMAIL PROTECTED]>
> Date: Sun, 16 Dec 2007 23:35:35 +0200
> Subject: [PATCH] Handle module unload Add the device release function.
Hi Dor,
It look
On Thursday 03 January 2008 08:01:32 Anthony Liguori wrote:
> The virtio modules do not advertise themselves as GPL but rely on exported
> GPL symbols. This makes them unloadable as modules.
>
> This patch adds the appropriate MODULE_LICENSE().
Hmm, this is already at the bottom of virtio_blk and
Here's the latest. Hope this works for everyone (putting in a oom handler or
shrinker requires a lock, but can be done quite easily).
Untested.
===
After discussions with Anthony Liguori, it seems that the virtio
balloon can be made even simpler. Here's my attempt.
Signed-off-by: Rus
On Friday 25 January 2008 00:09:07 Dor Laor wrote:
> The patches really fix/simplify things :)
Yes, that's why I like reset, it solves multiple problems.
> Did you test device open->close->open? It was broken in my last test,
Well, it's not really fair, since I moved the buffer allocation and
d
On Saturday 26 January 2008 03:08:57 Marcelo Tosatti wrote:
> On Thu, Jan 24, 2008 at 04:29:51PM -0600, Anthony Liguori wrote:
> > I'm inclined to think that we should have a capability check for MM
> > notifiers and just not do madvise if they aren't present. I don't think
> > the ioctl approach
On Friday 01 February 2008 19:05:00 Christian Borntraeger wrote:
> Am Freitag, 1. Februar 2008 schrieb Christian Borntraeger:
> > Right. I will fix that with an additional patch.
>
> This patch goes on top of the minor number patch. Please let me know if
> you want a merged patch:
>
> Currently vir
On Thursday 21 February 2008 10:24:57 Fabio Checconi wrote:
> Hi,
> what's the status of kvm-lite? Has anybody worked on it since
> the last september posting[1]?
Hi Fabio,
No, not really. I'll have to drag it up to date again and submit it for
merging so it doesn't keep bitrotting.
Thank
On Monday 03 March 2008 09:37:48 Anthony Liguori wrote:
> virtio-pci acquires its spin lock in an interrupt context so it's necessary
> to use spin_lock_irqsave/restore variants. This patch fixes guest SMP when
> using virtio devices in KVM.
>
> Signed-off-by: Anthony Liguori <[EMAIL PROTECTED]>
On Thursday 06 March 2008 03:28:32 Marcelo Tosatti wrote:
> Handle the case where the balloon target is larger than total ram size.
>
> BUG: unable to handle kernel paging request at 00100100
> IP: [] :virtio_balloon:leak__balloon+0x2e/0xbe
>
> Signed-off-by: Marcelo Tosatti <[EMAIL PROTECT
On Sunday 09 March 2008 06:06:38 Marcelo Tosatti wrote:
> But making the driver robust against it seems sensate. I agree that
> zeroing num_pages is hackish. What do you suggest?
OK, after more discussion on IRC, this seems like the correct thing to do.
1) Allow more than 2G of pages. It doesn't
On Tuesday 11 March 2008 11:52:46 Anthony Liguori wrote:
> Rusty Russell wrote:
> > 2) Handle the case where we get nonsense from the host, which causes us
> > to wrap around.
>
> Here's my neither compiled nor tested version which should fix this
> problem without bre
On Thursday 20 March 2008 12:35:04 Anthony Liguori wrote:
> Make sure to call unregister_virtio_device() when a virtio device is
> removed. Otherwise, virtio_pci.ko cannot be rmmod'd.
>
> This was spotted by Marcelo Tosatti.
>
> Signed-off-by: Anthony Liguori <[EMAIL PROTECTED]>
Thanks, applied.
Hi all,
Just finished my prototype of inter-guest virtio, using networking as an
example. Each guest mmaps the other's address space and uses a FIFO for
notifications.
There are two issues with this approach. The first is that neither guest
can change its mappings. See patch 1. The s
From: Paul TBBle Hampson <[EMAIL PROTECTED]>
This creates a file in $HOME/.lguest/ to directly back the RAM and DMA memory
mappings created by map_zeroed_pages.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
Documentation/lguest/lgu
We currently keep Guest memory pointer and size in globals. We move
this into a structure and explicitly hand that to to_guest_phys() and
from_guest_phys() so we can deal with other Guests' memory.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
Documentation/lguest/lgue
To deal with other Guest's virtqueue, we need to separate out the
parts of the structure which deal with the actual virtqueue from
configuration information and the device. Then we can change the
virtqueue descriptor handling functions to take that smaller
structure.
Signed-off-by: Rusty Ru
Currently the lguest Launcher aborts when a Guest puts something bogus
in a virtio queue. If we want to deal with other (untrusted) Guests'
queues, that's a bad idea: simply print a warning and ignore it from
now on.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
Docu
ed on the flags in the other Guest's
virtqueue).
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
Documentation/lguest/lguest.c | 257 ++
1 file changed, 235 insertions(+), 22 deletions(-)
diff -r d803a2208052 Documentation/lguest/lguest.c
On Friday 21 March 2008 01:04:17 Anthony Liguori wrote:
> Rusty Russell wrote:
> > From: Paul TBBle Hampson <[EMAIL PROTECTED]>
> >
> > This creates a file in $HOME/.lguest/ to directly back the RAM and DMA
> > memory mappings created by map_zeroed_pages.
>
>
On Thursday 20 March 2008 17:54:45 Avi Kivity wrote:
> Rusty Russell wrote:
> > Hi all,
> >
> >Just finished my prototype of inter-guest virtio, using networking as
> > an example. Each guest mmaps the other's address space and uses a FIFO
> > for notific
On Friday 21 March 2008 03:25:28 Carsten Otte wrote:
> +static void kvm_set_status(struct virtio_device *vdev, u8 status)
> +{
> + BUG_ON(!status);
> + to_kvmdev(vdev)->desc->status = status;
> +}
> +
> +/*
> + * To reset the device, we (ab)use the NOTIFY hypercall, with the descriptor
> +
On Thursday 20 March 2008 19:16:00 Tim Post wrote:
> On Thu, 2008-03-20 at 17:05 +1100, Rusty Russell wrote:
> > + snprintf(memfile_path, PATH_MAX, "%s/.lguest",
> > getenv("HOME") ?: "");
>
> Hi Rusty,
>
> Is that safe if being run vi
On Friday 21 March 2008 19:15:47 Christian Borntraeger wrote:
> Am Freitag, 21. März 2008 schrieb Rusty Russell:
> > Hmm, panic on device_register fail, but -ENOMEM on add_shared_memory
> > fail? My theory was that since this is boot time, panic() is the right
> > thing.
>
On Friday 21 March 2008 01:11:35 Anthony Liguori wrote:
> Rusty Russell wrote:
> >There are three possible solutions:
> > 1) Just offer the lowest common denominator to both sides (ie. no
> > features). This is what I do with lguest in these patches.
> > 2) Offer so
On Friday 28 March 2008 03:29:48 Marcelo Tosatti wrote:
> Allow more than one in-flight request in the virtio ring. This allows
> the host driver to submit requests in parallel.
>
> Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]>
For a moment, I thought this was true and felt very stupid :)
Fo
On Sunday 06 April 2008 00:53:39 Balaji Rao wrote:
> On Friday 04 April 2008 01:46:21 pm Balaji Rao wrote:
> > Hi Rusty,
> >
> > I hit a bug in virtio_ring.c:218 when I was stressing virtio_net using
> > kvm with -smp 4.
> >
> > static void vring_disable_cb(struct virtqueue *_vq)
> > {
> >
try feature
Date: Wed, 16 Apr 2008 13:56:37 -0500
From: Ryan Harper <[EMAIL PROTECTED]>
Rather than faking up some geometry, allow the backend to push the disk
geometry via virtio pci config option. Keep the old geo code around for
compatibility.
Signed-off-by: Ryan Harper <[EMAIL PROT
On Thu, 2007-09-27 at 11:18 +0200, Avi Kivity wrote:
> The whole drivers/kvm/ thing was just a trick to get merged quickly. I
> think the new layout should be something like
>
> virt/kvm/, include/linux/kvm*.h -> common code
> virt/lguest/ -> the other hypervisor
> virt/virtio/ -> shared I/
On Tue, 2007-10-02 at 01:19 +, Hollis Blanchard wrote:
> On Sun, 30 Sep 2007 15:56:16 +0200, Avi Kivity wrote:
> >
> > Eventually I'd like to see the code in arch/*/kvm. That's probably not
> > easily doable right now because modules cannot span directories, but
> > once that's solved, we'l
This was committed in 1d55c096cce99f069d9ac8e3b2195d45adce9549 on Feb 7,
and clearly never actually compiled.
---
kernel/external-module-compat.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/external-module-compat.h b/kernel/external-module-compat.h
index 2e
On Tue, 2007-10-02 at 01:01 -0500, Hollis Blanchard wrote:
> On Tue, 2007-10-02 at 14:11 +1000, Rusty Russell wrote:
> > On Tue, 2007-10-02 at 01:19 +, Hollis Blanchard wrote:
> > > On Sun, 30 Sep 2007 15:56:16 +0200, Avi Kivity wrote:
> > > >
> > > &
Hi all,
The lapic code uses ktime_t and hrtimers, which means we no longer
build for kernels 2.6.15 and below. Is it worth trying to fake this
infrastructure up, building without lapic, or abandoning < 2.6.16?
Thanks,
Rusty.
-
This makes it easier to check kvm-userspace compatibility layer.
---
check-compat.sh | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
create mode 100755 check-compat.sh
diff --git a/check-compat.sh b/check-compat.sh
new file mode 100755
index 000..c07be4
t set apic->regs_page to zero before freeing apic.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
diff --git a/drivers/kvm/irq.h b/drivers/kvm/irq.h
index 11fc014..508280e 100644
--- a/drivers/kvm/irq.h
+++ b/drivers/kvm/irq.h
@@ -139,7 +139,7 @@ int kvm_apic_accept_pic_intr(struct kv
Move kvm_create_lapic() into kvm_vcpu_init(), rather than having svm
and vmx do it. And make it return the error rather than a fairly
random -ENOMEM.
This also solves the problem that neither svm.c nor vmx.c actually
handles the error path properly.
Signed-off-by: Rusty Russell <[EM
Since vcpu->apic is of the correct type, there's not need to cast.
Perhaps this will be required in future?
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
diff --git a/drivers/kvm/lapic.c b/drivers/kvm/lapic.c
index 27e6249..68aa9e4 100644
--- a/drivers/kvm/lapic.c
+++ b/drive
On Tuesday 30 October 2007 09:17:38 Thomas Gleixner wrote:
> On Mon, 29 Oct 2007, Glauber de Oliveira Costa wrote:
>
> CC'ed John and removed [EMAIL PROTECTED] :)
>
> > From: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
> >
> > tsc is very good time source (when it does not have drifts, does not
>
On Tuesday 30 October 2007 18:37:36 Ingo Molnar wrote:
> * Rusty Russell <[EMAIL PROTECTED]> wrote:
> > No. tsc is very good, it's not perfect. If a paravirt clock
> > registers 400 it really means "pick me over the tsc".
>
> often the TSC is not
On Tuesday 13 November 2007 10:25:54 Anthony Liguori wrote:
> Dor Laor wrote:
> > Anthony Liguori wrote:
> >> Dor Laor wrote:
> >>> In general I think we need to add another feature or even version
> >>> number ( I know you guys hate it).
> >>> The reason is - Let's say you dont change functionalit
On Tuesday 20 November 2007 17:16:45 Steven Rostedt wrote:
> On Tue, 20 Nov 2007, Ingo Molnar wrote:
> > i dont think there's ever any true need (and good cause) to force
> > integer type casts like that at the callee site.
>
> Unless you mean we should do something like this:
>
> static inline voi
EMAIL PROTECTED]>
Acked-by: Rusty Russell <[EMAIL PROTECTED]>
Can you send straight to akpm or davem? I'm supposed to be on vacation at the
moment (and not doing a very good job :)
Thanks,
Rusty.
-
SF.Net em
On Wednesday 12 December 2007 00:16:12 Christian Borntraeger wrote:
> That would also work. We already have VRING_AVAIL_F_NO_INTERRUPT in
> virtio_ring.c - maybe we can use that. Its hidden in callback and
> restart handling, what about adding an explicit startup?
Yes, I debated whether to make th
On Wednesday 12 December 2007 23:54:00 Dor Laor wrote:
> commit 763769621d271d92204ed27552d75448587c1ac0
> Author: Dor Laor <[EMAIL PROTECTED]>
> Date: Wed Dec 12 14:52:00 2007 +0200
>
> [virtio-net][PATCH] Don't arm tx hrtimer with a constant 50us each
> transmit
>
> The current start_xm
rn.
It seems that virtio_net wants to disable callbacks (interrupts) before
calling netif_rx_schedule(), so we can't use the return value to do so.
Rename "restart" to "cb_enable" and introduce "cb_disable" hook: callback
now returns void, rather than a bool
process the input queue once
on open.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
diff -r 1dd61213039c drivers/net/virtio_net.c
--- a/drivers/net/virtio_net.c Tue Dec 18 17:34:18 2007 +1100
+++ b/drivers/net/virtio_net.c Tue Dec 18 17:47:39 2007 +1100
@@ -326,6 +326,13 @@ static int
On Tuesday 18 December 2007 16:30:08 Avi Kivity wrote:
> Rusty Russell wrote:
> > Yes, I pondered this when I wrote the code. On the one hand, it's a
> > low-probability pathological corner case, on the other, your patch
> > reduces the number of timer reprograms i
On Saturday 22 December 2007 02:27:33 Dor Laor wrote:
> From 9f5a551d7e2a00eb019b158f8f3130e8176ec27c Mon Sep 17 00:00:00 2001
> From: Dor Laor <[EMAIL PROTECTED]>
> Date: Mon, 17 Dec 2007 01:40:15 +0200
> Subject: [PATCH] Update all status fields on driver unload
OK, looks like I missed the last
On Monday 24 December 2007 10:19:19 Dor Laor wrote:
> Rusty Russell wrote:
> Looks good to me. The only thing is the naming.. Maybe one can find
> better name than [dis|en]able_cb since
> it is more like disable interrupts than disable_cb and enable_cb is more
> like run_callba
On Tuesday 25 December 2007 23:22:37 Dor Laor wrote:
> btw: I checked your Linux tree and found it a bit old, there was no tx
> coalescing timer, it's probably good
> for 2.6.24. Do you plan to post patchset for 25 windows?
> Thanks,
> Dor
Hmm, should be updated now. Will be pushing all these vir
On Thursday 03 January 2008 08:01:34 Anthony Liguori wrote:
> Qumranet was kind enough to donate a set of vendor/device IDs for virtio
> devices. This patch switches over to using them instead of an unreserved
> vendor ID.
>
> Signed-off-by: Anthony Liguori <[EMAIL PROTECTED]>
All applied, thanks
On Friday 04 January 2008 02:57:14 Anthony Liguori wrote:
> hrtimer's only have a cb_mode if CONFIG_HIGH_RES_TIMER is enabled. This
> patch memset()s the tx_timer structure to 0 which has the same effect as
> setting cb_mode to HRTIMER_CB_SOFTIRQ without requiring
> CONFIG_HIGH_RES_TIMER to be set
On Saturday 05 January 2008 09:24:40 Anthony Liguori wrote:
> @@ -215,17 +231,40 @@
> struct virtnet_info *vi = rvq->vdev->priv;
> /* Suppress further interrupts. */
> rvq->vq_ops->disable_cb(rvq);
> +#ifdef COMPAT_napi
> + vi->rvq->vq_ops->enable_cb(vi->rvq);
> +
On Saturday 05 January 2008 09:24:40 Anthony Liguori wrote:
> Hey Rusty et al,
>
> I've got automatic backports of the virtio modules[1] working back to
> 2.6.18. Everything seems okay except that for any kernel with the older
> NAPI api, performance is extremely bad. I get about 1gbit on TX with
On Tuesday 08 January 2008 07:36:45 Anthony Liguori wrote:
> Avi and I were talking this afternoon and he suggested that we should
> remove the tx_timer from the virtio_net front-end and replace it with a
> tx_timer in the backend.
>
> Since the backend can suppress notifications, this is appealing
river may one day have a "carrier" status as well.
This introduces that callback, and adds it to the virtio PCI
implementation.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/virtio/virtio_pci.c | 10 ++
include/linux/virtio.h |3 +++
include/linux/vir
On Friday 11 January 2008 02:51:58 Christian Borntraeger wrote:
> What about the following patch:
Looks correct and in fact pretty orthodox.
I've folded this in, thanks!
Rusty.
-
Check out the new SourceForge.net Marketplac
On Mon, 2007-05-28 at 20:54 -0500, Anthony Liguori wrote:
> Howdy,
>
> Does anyone know what the state of a pv_ops backend for KVM is? I know
> Ingo has an implementation that implements CR3 caching but I don't see
> any branches in Avi's git tree.
>
> Perhaps we should try for a simple pv_ops
On Tue, 2007-05-29 at 17:00 +0300, Avi Kivity wrote:
> Anthony Liguori wrote:
> > Avi Kivity wrote:
> >> I think we should aim for a full direct paging implementation, where
> >> the cr3 cache is just the cherry on top that makes context switches
> >> proceed at native speed. Jun has a paper on
On Wed, 2007-05-30 at 08:01 +0300, Avi Kivity wrote:
> Rusty Russell wrote:
> > but it's not clear to me that verifying PTEs is that
> > much faster than shadowing them if you're prepared to be that invasive
> > in the guest anyway.
> >
> This can prob
On Wed, 2007-05-30 at 09:52 -0500, Anthony Liguori wrote:
> This patch adds the basic infrastructure for paravirtualizing a KVM
> guest.
Hi Anthony!
Nice patch, comments below.
> Discovery of running under KVM is done by sharing a page of memory
> between
> the guest and host (initially
On Wed, 2007-05-30 at 14:22 -0500, Anthony Liguori wrote:
> I was actually thinking about adding a hypercall to set/clear a bit in a
> control register. The thought here is that it would be useful not just
> for the global bit but also for CR0.TS although we would need another
> paravirt_op hoo
On Thu, 2007-05-31 at 12:40 +0200, Andi Kleen wrote:
> On Thursday 31 May 2007 12:11:16 Ingo Molnar wrote:
> >
> > * Andi Kleen <[EMAIL PROTECTED]> wrote:
> >
> > >
> > > > > + if (wrmsr_safe(MSR_KVM_API_MAGIC, __pa(para_state), 0)) {
> > > > > + printk(KERN_INFO "KVM guest:
(net and block) and two
virtio implementations (for lguest): a read-write socket-style
implementation, and a more efficient descriptor-based implementation).
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
include/linux/virtio.h | 69
1 fil
Example net driver using virtio
TODO:
1) Locking (see #2).
2) NAPI.
3) GSO.
4) Checksum options.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/net/Makefile |2
drivers/net/virtio_net.c
virtio_blk_inhdr). For a read, the rest of the sg points to the input
buffer.
TODO:
1) Ordered tag support.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/block/Makefile |1
drivers/block/virtio_blk.c | 269
include
On Thu, 2007-05-31 at 14:57 +0200, Carsten Otte wrote:
> Rusty Russell wrote:
> > Example block driver using virtio.
> >
> > The block driver uses outbufs with sg[0] being the request information
> > (struct virtio_blk_outhdr) with the type, sector and inbuf id. For a
On Fri, 2007-06-01 at 09:10 +0200, Carsten Otte wrote:
> Rusty Russell wrote:
> > What's the overhead in doing both?
> With regard to compute power needed, almost none. The penalty is
> latency, not overhead: A small request may sit on the request queue to
> wait for oth
On Sat, 2007-06-02 at 09:30 +0300, Avi Kivity wrote:
> Rusty Russell wrote:
> > + * virtio_ops - virtio abstraction layer
> > + * @add_outbuf: prepare to send data to the other end:
> > + * vdev: the virtio_device
> > + * sg: the description of the buffer(s).
> >
On Fri, 2007-06-01 at 23:35 +, Santos, Jose Renato G wrote:
>
> > -Original Message-
> > From: [EMAIL PROTECTED]
> > [mailto:[EMAIL PROTECTED] On Behalf Of
> > Rusty Russell
> > Sent: Thursday, May 31, 2007 5:19 AM
> > To: kvm-devel; Xen Ma
On Sun, 2007-06-03 at 08:28 +0300, Avi Kivity wrote:
> Sure, 'used' is important (how else do you get the packet size on
> receive?)
Well, the sender can prepend the length, or for networking just leave
Linux to trim packets. It's the trust issue which bugs me.
> , I'm just bitching about the l
On Sun, 2007-06-03 at 14:39 +0300, Avi Kivity wrote:
> Rusty Russell wrote:
> > Hmm... Perhaps I should move the used arrays into the "struct
> > virtio_device" and guarantee that the id (returned by add_*buf) is an
> > index into that. Then we can triviall
On Mon, 2007-06-04 at 12:55 +0300, Avi Kivity wrote:
> Rusty Russell wrote:
> > On Sun, 2007-06-03 at 14:39 +0300, Avi Kivity wrote:
> >
> >> Rusty Russell wrote:
> >>
> >>> Hmm... Perhaps I should move the used arrays into the "str
On Mon, 2007-06-04 at 14:25 +0300, Avi Kivity wrote:
> Rusty Russell wrote:
> >
> >> Networking hardware generally services descriptors in a FIFO manner.
> >>
> >
> > Well, ethernet guarantees order. Not sure about others tho...
>
> OT: Does t
On Mon, 2007-06-04 at 15:43 +0200, Jens Axboe wrote:
> On Mon, Jun 04 2007, Carsten Otte wrote:
> > Jens Axboe wrote:
> > >On Fri, Jun 01 2007, Carsten Otte wrote:
> > >>With regard to compute power needed, almost none. The penalty is
> > >>latency, not overhead: A small request may sit on the req
On Mon, 2007-06-04 at 21:14 +, Santos, Jose Renato G wrote:
> Thanks for clarifying your thinking. This helped me understand
> your goals better.
> I agree it would be nice to reduce the number of drivers as it
> improves mantainability. However I am not convinced that
> adding an IO
On Tue, 2007-06-05 at 02:05 +, Santos, Jose Renato G wrote:
> > From: Jeremy Fitzhardinge [mailto:[EMAIL PROTECTED]
> > The hope is that the Xen-specific elements of the driver will
> > be restricted to Xen-specific things like grant tables, and
> > the bulk of the driver and its logic can
On Wed, 2007-06-06 at 19:17 +0300, Avi Kivity wrote:
> Carsten Otte wrote:
> > The best approach into this direction I have seen so far is not our
> > own vdev thing but Rusty's virtio infrastructure. That's what I think
> > I would start with.
> >
> >
>
> I agree. We need a Lego set contain
Hi again all,
It turns out that networking really wants ordered requests, which the
previous patches didn't allow. This patch changes it to a callback
mechanism; kudos to Avi.
The downside is that locking is more complicated, and after a few dead
ends I implemented the simplest s
lock) and two
virtio implementations (for lguest): a read-write socket-style
implementation, and a more efficient descriptor-based implementation.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
include/linux/virtio.h | 75
1 f
rest of the sg points to the input
buffer.
TODO:
1) Ordered tag support.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/block/Makefile |1
drivers/block/virtio_blk.c | 299
include/linux/virtio_blk.h | 28
3
TODO:
1) NAPI (will require way of suppressing virtio callbacks)
2) GSO.
3) Checksum options.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/net/Makefile |2
drivers/net/virtio_net.c | 243
i
On Thu, 2007-06-07 at 15:19 +0300, Avi Kivity wrote:
> Rusty Russell wrote:
> > + sprintf(vblk->disk->disk_name, "vb%c", virtblk_index++);
> >
>
> vd%c, in keeping with hd%c and sd%c?
Should work, since iSeries' devices are /dev/iseries/vd%c. Is
1 - 100 of 296 matches
Mail list logo
