On Sun, 2007-01-07 at 14:20 +0200, Avi Kivity wrote:
Well, you did say it was ad-hoc. For reference, this is how I see the
hypercall API:
[snip]
- Guest/host communications is by guest physical addressed, as the
virtual-physical translation is much cheaper on the guest (__pa() vs
a page
On Sun, 2007-02-25 at 10:58 +0200, Avi Kivity wrote:
I'm changing the kvm userspace interface to be more friendly to other
archs. One issue is the PIO port size. x86 uses 16 bits to hold the
port size (64K ports). Is that an issue for other archs?
I guess I could change it to __u32, but
This may just be my unfamiliarity with x86, but I can't see where the
floating point state is being saved, and it doesn't seem to be part of
the KVM_GET_REGS or KVM_GET_SREGS interfaces.
It's being saved and restored fine, but since it's not part of the
userspace interface I guess that would mean
On Wed, 2007-03-14 at 23:02 -0500, Hollis Blanchard wrote:
I don't see where MMX state is being handled at all. Does that work?
Oops, forgot that MMX uses the floating point registers. I was just
trying to think of any other extra register state that might have been
overlooked.
-Hollis
On Sun, 2007-03-11 at 15:53 +0200, Avi Kivity wrote:
Instead of passing a 'struct kvm_run' back and forth between the
kernel and userspace, allocate a page and allow the user to mmap() it.
This reduces needless copying and makes the interface expandable by
providing lots of free space.
Do you
On Wed, 2007-03-14 at 21:38 -0500, Hollis Blanchard wrote:
On Sun, 2007-03-11 at 15:53 +0200, Avi Kivity wrote:
Instead of passing a 'struct kvm_run' back and forth between the
kernel and userspace, allocate a page and allow the user to mmap() it.
This reduces needless copying and makes
What is the distinction between kvm_regs and kvm_sregs? As far as I can
see, kvm_regs is only used when emulating IO, emulating MMIO, and
emulating CPUID, where guest GPRs are directly modified. kvm_sregs is
only used for full CPU state save (for later restore).
When the kernel had to use
On Sun, 2007-03-18 at 07:13 +0200, Avi Kivity wrote:
Hollis Blanchard wrote:
What is the distinction between kvm_regs and kvm_sregs? As far as I can
see, kvm_regs is only used when emulating IO, emulating MMIO, and
emulating CPUID, where guest GPRs are directly modified. kvm_sregs is
only
Hi Avi, I was wondering what you think is the right abstraction layer to
target for porting KVM to non-x86 architectures? To me it looks like
libkvm is the answer.
The kernel/userland interface is heavily x86-specific, including things
like struct kvm_run. So it looks like the higher-level API of
On Tue, 2007-03-27 at 08:57 +0200, Avi Kivity wrote:
Hollis Blanchard wrote:
Hi Avi, I was wondering what you think is the right abstraction layer to
target for porting KVM to non-x86 architectures? To me it looks like
libkvm is the answer.
The kernel/userland interface is heavily x86
On Wed, 2007-03-28 at 17:48 +0200, Avi Kivity wrote:
Hollis Blanchard wrote:
On Tue, 2007-03-27 at 08:57 +0200, Avi Kivity wrote:
I don't think we should be aiming at full source portability.
Virtualization is inherently nonportable, and as it is mostly done in
hardware, software
.
To investigate PowerPC support I did some work to refactor the KVM code
into x86 vs shared bits. It was based on the in-kernel KVM code, so I need
to rebase that work on kvm.git. I guess you guys have the same
problem; have you done any work in that area?
--
Hollis Blanchard
IBM Linux Technology Center
, but since we're dropping
it then I'm glad I haven't put too much time into it. :)
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version
, or net? :)
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX
://lkml.org/lkml/2007/1/7/60 (in
particular http://lkml.org/lkml/2007/1/7/126 ;) .
In short, please do *not* pass guest virtual addresses through a
paravirtual API.
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net
also agree with.)
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using
you need.
Hmm, that's a good point. Is that something you think can reasonably be
accomplished with qemu today?
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping
by actually using
small pages on the host, and handle the extra faults in KVM without
notifying the guest.
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through
.
What is the spanning directories issue? Can't I build
arch/powerpc/kvm/kvm-powerpc.ko and drivers/kvm/kvm.ko and let modprobe
sort out the dependency?
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email
On Tue, 2007-10-02 at 14:11 +1000, Rusty Russell wrote:
On Tue, 2007-10-02 at 01:19 +, Hollis Blanchard wrote:
On Sun, 30 Sep 2007 15:56:16 +0200, Avi Kivity wrote:
Eventually I'd like to see the code in arch/*/kvm. That's probably not
easily doable right now because modules
are
very willing to contribute to it:)
Do you really need a new branch? Why not just submit patches?
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through
fine, but it's only one
function so I guess I can't complain much.
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop
I'm left
wondering... what's the point? What's wrong with PIT (et al) emulation?
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find
On Fri, 2007-10-12 at 15:02 -0500, Anthony Liguori wrote:
Hollis Blanchard wrote:
On Fri, 2007-10-12 at 13:08 -0300, Glauber de Oliveira Costa wrote:
+config KVM_CLOCK
+ bool KVM paravirtualized clock
+ depends on PARAVIRT GENERIC_CLOCKEVENTS
+ help
the HPET?
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX
On Mon, 2007-10-15 at 18:47 +0200, Avi Kivity wrote:
Hollis Blanchard wrote:
I'd think there is no reason for virtual timer to be PIT like, which
is mostly due to historic reason.
If we need to make it close to native timer device, HPET is much
better than PIT for virtual time to look
, we can share code between multiple
architectures without using ifdefs...
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems
On Thu, 2007-10-18 at 16:04 -0500, Anthony Liguori wrote:
Hollis Blanchard wrote:
What is the problem with
embedding an architecture-specific sub-structure, i.e.
struct kvm_vcpu {
...
struct arch_kvm_vcpu arch_vcpu;
};
I think
On Sat, 2007-10-20 at 00:15 +0200, Dor Laor wrote:
Hollis Blanchard wrote:
This patch can now execute guest userspace (I'm not saying it's
complete
or stable or anything though). I need to put together a more
full-featured ramdisk to test userspace more completely.
That reminds me
kvm_guest_exit() be calling
account_user_vtime() (instead of account_system_vtime())?
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems
, e.g. modprobe kvm-powerpc-440
kvm-powerpc-e500. (This will require some additional kvm_ppc_ops
support not shown here.)
Personally I think common is too much typing, but I've left the name
as you suggested for now. :)
--
Hollis Blanchard
IBM Linux Technology Center
confusing that there is a
variable *and* a target named flatfiles...
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop
Avi, what do you think about breaking the kvm-userspace repository into
separate kvm-qemu, kvmctl, and libkvm repositories?
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc
On Thu, 2007-10-25 at 20:40 +0200, Avi Kivity wrote:
Hollis Blanchard wrote:
Avi, what do you think about breaking the kvm-userspace repository into
separate kvm-qemu, kvmctl, and libkvm repositories?
Firstly, I think kvmctl and libkvm should stay together.
Why? As far as I can see
, how would you create a sparse (guest physical)
memory map in userspace? I guess you would need to use repeated
mmap(MAP_FIXED), and that's starting to look very brittle.
--
Hollis Blanchard
IBM Linux Technology Center
fields as arch-specific. So, I think, we should keep common
fields in kvmctl.h.
Are you suggesting that kvm_callbacks should be the union of all
callbacks used on all architectures, and for any given architecture only
a subset are actually used?
--
Hollis Blanchard
IBM Linux Technology Center
On Mon, 2007-10-29 at 10:41 +0800, Zhang, Xiantao wrote:
Anthony Liguori wrote:
Hollis Blanchard wrote:
I don't know the privious story about this thread, but now I can't
understand the move. Why do we move all the structure to
arch-specific ? For IA64 side, almostly we can reuse them
cb(...);
printk(error);
return -EINVAL;
}
Sounds fine to me.
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find
(), which would call
it multiple times.
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events
content, therefore I'd like to ask for
integration of that one.
The other three patches require peer review. They move entire functions
blocks from kvm_main.c to x86.c. Xiantao and Hollis please make sure I
am not moving anything of interrest for your ports.
Patches 1-4:
Acked-by: Hollis Blanchard
Move libkvm into its own directory. No functional changes.
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
---
I've build-tested this pretty thoroughly on x86(32).
Changes from v1: update libkvm.h #include guard macro.
diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -5,16
On Tue, 2007-10-30 at 05:40 +0200, Avi Kivity wrote:
While mercurial is easier to use than git, using git would make it
easier for more kvm developers to contribute.
Anybody who manages to use git can figure out Mercurial in minutes.
--
Hollis Blanchard
IBM Linux Technology Center
anything was missing.
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using
for PowerPC.
I'm fine with the patch as-is; I just want to point out that future work
will be needed in this area.
Acked-by: Hollis Blanchard [EMAIL PROTECTED]
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email
The function inject_gp, which was duplicated by yesterday's patch
series, is removed from kvm_main.c now because it is not needed
anymore.
Signed-off-by: Carsten Otte [EMAIL PROTECTED]
Acked-by: Hollis Blanchard [EMAIL PROTECTED]
--
Hollis Blanchard
IBM Linux Technology Center
the only in-kernel
device is an APIC. That won't even build for anybody who doesn't have
vcpu-apic... that's why I say go ahead and move them, and we can worry
about it later.
--
Hollis Blanchard
IBM Linux Technology Center
On Wed, 2007-10-31 at 02:39 +0200, Avi Kivity wrote:
Hollis Blanchard wrote:
On Tue, 2007-10-30 at 13:59 +0200, Avi Kivity wrote:
-/usr/kvm
+%dir /usr/kvm
+%dir /usr/kvm/bin
+/usr/kvm/bin/qemu-img
+/usr/kvm/bin/qemu-system-x86_64
[...]
Why is this change
.
Is the second type also useful for ppc?
Actually yes. At least OpenPIC (one of a variety of interrupt
controllers used on PowerPC systems) has per-CPU registers:
A copy of each of these registers will be available to each CPU
at the same physical address.
--
Hollis Blanchard
IBM
@@ -1,2 +1,5 @@
LIBDIR := /lib64
+
+CFLAGS += -m64
+CFLAGS += -D__x86_64__
--
Hollis Blanchard
IBM Linux Technology Center
On Wed, 2007-10-31 at 10:09 -0600, Cam Macdonell wrote:
Hi Hollis and Avi,
I run into a compile problem with libkvm when compiling kvm-49. It
caused the compile
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
---
It might be preferable to handle these by defining a kvm_arch_vcpu_ioctl()
rather creating lots of new functions. I could go either way.
diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h
--- a/drivers/kvm/kvm.h
+++ b/drivers/kvm/kvm.h
More straightforward code movement from kvm_main.c to x86.c.
These patches have been build-tested on x86-32, but not run.
kvm.h | 23 +
kvm_main.c | 757 -
x86.c | 734
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
---
Each architecture can export its own data via the same kvm debugfs directory.
diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h
--- a/drivers/kvm/kvm.h
+++ b/drivers/kvm/kvm.h
@@ -759,4 +759,11 @@ static inline u32 get_rdx_init_val(void
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h
--- a/drivers/kvm/kvm.h
+++ b/drivers/kvm/kvm.h
@@ -631,6 +631,9 @@ long kvm_arch_vm_ioctl(struct file *filp
unsigned int ioctl, unsigned long arg);
void
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h
--- a/drivers/kvm/kvm.h
+++ b/drivers/kvm/kvm.h
@@ -589,6 +589,7 @@ int kvm_set_msr_common(struct kvm_vcpu *
void fx_init(struct kvm_vcpu *vcpu);
+void kvm_vcpu_block(struct kvm_vcpu *vcpu
()
kvm_vcpu_init()
Only build-tested! Comments?
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h
--- a/drivers/kvm/kvm.h
+++ b/drivers/kvm/kvm.h
@@ -490,6 +490,9 @@ int kvm_vcpu_init(struct kvm_vcpu *vcpu,
int kvm_vcpu_init(struct kvm_vcpu *vcpu, struct
These patches are not simple code movement, and I haven't yet tested them so
I'm just putting them out for comment.
Basically we're expanding the VCPU creation path to add an arch layer between
main.c and svm/vmx.c. Since there is one call in each direction (main.c -
svm/vmx.c, svm/vmx.c -
3 files changed, 450 insertions(+), 442 deletions(-)
drivers/kvm/kvm.h | 10 +
drivers/kvm/kvm_main.c | 448
drivers/kvm/x86.c | 434 ++
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED
that would be OK since the init functionality will be executed as
needed by the arch modules.
Does this make sense?
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping
))
+
+#endif
Userspace should never do this, and should always use getpagesize(2)
instead. (I know it's not your fault.)
Once you change those two things, kvm-x86.h disappears (unless you need
to create it later in the series).
--
Hollis Blanchard
IBM Linux Technology Center
* Remove the config-*.mak changes
* Update the patch description
* Supply a copyright notice in all new files
--
Hollis Blanchard
IBM Linux Technology Center
On Fri, 2007-11-02 at 13:24 -0500, Jerone Young wrote:
# HG changeset patch
# User Jerone Young [EMAIL PROTECTED
[KVM_MAX_NUM_MEM_REGIONS];
-static void init_slots()
+void init_slots()
{
int i;
As long as you're here could you please add a void? That bugs me every
time I see it.
--
Hollis Blanchard
IBM Linux Technology Center
Yes, everybody should be doing userspace memory allocation now, and we
just need to support kernel allocation for compatibility on x86.
--
Hollis Blanchard
IBM Linux Technology Center
On Fri, 2007-11-02 at 02:49 -0500, Jerone Young wrote:
Hmm,
The problem here is in the case
libkvm.h is simpler and therefore
better.
--
Hollis Blanchard
IBM Linux Technology Center
On Fri, 2007-11-02 at 13:25 -0500, Jerone Young wrote:
# HG changeset patch
# User Jerone Young [EMAIL PROTECTED]
# Date 1194027873 18000
# Node ID ab3e5d875c37bf36db4e73331fd3234523598c6e
# Parent
Again, exported function - keep declarations in libkvm.h. (Please check
your other patches for this issue.)
--
Hollis Blanchard
IBM Linux Technology Center
On Fri, 2007-11-02 at 13:25 -0500, Jerone Young wrote:
# HG changeset patch
# User Jerone Young [EMAIL PROTECTED]
# Date 1194027874
Your mailer, which I'm guessing is Microsoft Outlook, is wrapping lines
and so this patch does not apply.
You might try using git-send-email or equivalent to avoid this issue.
--
Hollis Blanchard
IBM Linux Technology Center
On Thu, 2007-11-08 at 16:17 +0800, Zhang, Xiantao wrote:
Hi Avi
. And to the #ifdef
purists I say: deorbit.
Re-entry is looking rough; things are much better up here. ;)
Anyways, you don't need to ifdef a prototype; just don't call it.
Also, naming them kvm_x86_get_msrs() and kvm_x86_set_msrs() would be a
much better warning sign for callers.
--
Hollis Blanchard
IBM
hardware virtualization, and there's nothing to enable - it just
works.
Sounds fine to me: you're just proposing to move the abstraction one
level higher in some places.
--
Hollis Blanchard
IBM Linux Technology Center
at the patch I posted on Wednesday: [PATCH 2 of 2] RFC:
Create kvm_arch_vcpu_create(). kvm_arch_vcpu_create() will actually
encompass more logic from kvm_vm_ioctl_create_vcpu(), and once you do
that, kvm_arch_vcpu_reset() doesn't need to exist (which will also make
Carsten happy).
--
Hollis Blanchard
. apic_access_page, mmio_bus,
pio_bus) should be moved, but if this split works for IA64 then it's
fine to leave those changes for other architectures.
In general I like it.
Acked-by: Hollis Blanchard [EMAIL PROTECTED]
--
Hollis Blanchard
IBM Linux Technology Center
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
---
1 file changed, 1 deletion(-)
drivers/kvm/kvm.h |1 -
diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h
--- a/drivers/kvm/kvm.h
+++ b/drivers/kvm/kvm.h
@@ -318,7 +318,6 @@ struct kvm {
unsigned int n_alloc_mmu_pages
These are a few fixes to minor/cosmetic issues I've stumbled across recently.
3 files changed, 7 insertions(+), 8 deletions(-)
drivers/kvm/kvm.h | 11 +--
drivers/kvm/kvm_main.c |2 +-
drivers/kvm/x86.c |2 +-
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
---
1 file changed, 4 insertions(+), 4 deletions(-)
drivers/kvm/kvm.h |8
diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h
--- a/drivers/kvm/kvm.h
+++ b/drivers/kvm/kvm.h
@@ -135,15 +135,15 @@ struct kvm_mmu {
#define
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
---
3 files changed, 3 insertions(+), 3 deletions(-)
drivers/kvm/kvm.h |2 +-
drivers/kvm/kvm_main.c |2 +-
drivers/kvm/x86.c |2 +-
diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h
--- a/drivers/kvm/kvm.h
+++ b/drivers/kvm
NAK. I sent you a patch queue yesterday that replaces this patch.
(Unfortunately I didn't copy kvm-devel due to technical error; resending
in a moment.)
--
Hollis Blanchard
IBM Linux Technology Center
On Tue, 2007-11-20 at 10:29 +0800, Zhang, Xiantao wrote:
From: Zhang xiantao [EMAIL PROTECTED
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
---
5 files changed, 18 insertions(+), 13 deletions(-)
drivers/kvm/kvm.h |2 --
drivers/kvm/mmu.c | 14 --
drivers/kvm/vmx.c | 11 +++
drivers/kvm/x86.c |2 +-
drivers/kvm/x86.h |2 ++
diff --git a/drivers/kvm
These patches are based on Xiantao's work to create struct kvm_x86. Patch 1
replaces his KVM Portability split: Splitting kvm structure (V2), and patches
2 and 3 build on it.
9 files changed, 180 insertions(+), 116 deletions(-)
drivers/kvm/i8259.c|1
drivers/kvm/ioapic.c | 16
Signed-off-by: Zhang xiantao [EMAIL PROTECTED]
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
---
Changes from Xiantao's patch:
- Fix whitespace
- Reorder variables to avoid stack padding
- Leave descriptor_table relocation for another patch
8 files changed, 132 insertions(+), 85 deletions
wish you could
figure out a way to solve this problem. If you use a standard mailing
script, the mails will also be threaded correctly for ease of reading.
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net email
On Wed, 2007-11-21 at 11:18 +0200, Avi Kivity wrote:
Carsten Otte wrote:
Hollis Blanchard wrote:
These patches are based on Xiantao's work to create struct kvm_x86. Patch
1 replaces his KVM Portability split: Splitting kvm structure (V2), and
patches 2 and 3 build
On Fri, 2007-11-30 at 15:43 -0600, Anthony Liguori wrote:
Hollis Blanchard wrote:
On Fri, 2007-11-30 at 22:31 +0200, Avi Kivity wrote:
These cannot use the same method, since we need to support both vmx and
svm in the same binary. The arch specific members aren't the same size
On Fri, 2007-11-30 at 22:31 +0200, Avi Kivity wrote:
Hollis Blanchard wrote:
On Fri, 2007-11-30 at 11:04 +0200, Avi Kivity wrote:
Zhang, Xiantao wrote:
The nicer one:
struct kvm {
struct kvm_arch arch;
// common fields
:)
I agree, kvm_vcpu should use the same method.
And we will convert vcpu_vmx/vcpu_svm as well?
--
Hollis Blanchard
IBM Linux Technology Center
-
SF.Net email is sponsored by: The Future of Linux Business White
that
actually *uses* the cache (and the only code that knows what size the
vcpu actually is!), isn't the code creating it.
--
Hollis Blanchard
IBM Linux Technology Center
-
SF.Net email is sponsored by: The Future of Linux Business
of the exception
handlers, plus the real vcpu data structure at a higher offset. Since
our exception handlers can't span 64KB regions, we allocate a full 64KB
for each vcpu. I'm not sure what benefit a kmem_cache would have in this
situation...
--
Hollis Blanchard
IBM Linux Technology Center
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
---
5 files changed, 19 insertions(+), 9 deletions(-)
drivers/kvm/i8259.c|1 +
drivers/kvm/irq.h |7 ++-
drivers/kvm/kvm.h |9 -
drivers/kvm/kvm_main.c |3 ---
drivers/kvm/x86.h |8
diff
These patches allow us to stop unconditionally including x86 headers, which
allows us to provide alternative definitions. The first two just split things
out to avoid circular header dependencies.
In fact, with just a couple additional hacks, I was finally able to get a stub
PowerPC
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
---
2 files changed, 43 insertions(+), 19 deletions(-)
drivers/kvm/kvm.h | 21 ++---
drivers/kvm/types.h | 41 +
diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h
--- a/drivers/kvm
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
---
vcpu-mp_state looks like an arch-specific field, so what do we think about
this patch? It might make sense to fold the kvm_cpu_has_interrupt() test inside
kvm_arch_vcpu_runnable() as well.
2 files changed, 9 insertions(+), 3 deletions
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
---
pio_data is obviously arch-specific, but we might be able to get by with an
ifdef in kvm_vcpu_nopage() rather than needing an arch hook. Thoughts?
1 file changed, 2 insertions(+)
drivers/kvm/kvm_main.c |2 ++
diff --git a/drivers/kvm
On Tue, 2007-12-04 at 12:39 +0800, Zhang, Xiantao wrote:
Hollis Blanchard wrote:
Actually, (now that I try to build with it :) this doesn't work for
PowerPC, which defines (or rather, doesn't not define)
CONFIG_HAS_IOPORT.
You mean ppc has ioport , but you don't use current kvm io
On Tue, 2007-12-04 at 14:41 +0100, Carsten Otte wrote:
Hollis Blanchard wrote:
diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
--- a/drivers/kvm/kvm_main.c
+++ b/drivers/kvm/kvm_main.c
@@ -18,6 +18,7 @@
#include kvm.h
#include x86.h
#include irq.h
+#include iodev.h
into drivers/Kconfig at this point... maybe a task
for Rusty.
--
Hollis Blanchard
IBM Linux Technology Center
-
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell. From the desktop to the data
/ to form kvm.ko, while others will generate kvm-intel.ko and
kvm-amd.ko.
Also, asm-offsets is a major sticking point. Either we create a
dependency on arch/*/kernel/asm-offsets.c, or we find a way to create a
new arch/*/virt/asm-offsets.c file.
--
Hollis Blanchard
IBM Linux Technology Center
than that I'm fine with it.
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
--
Hollis Blanchard
IBM Linux Technology Center
-
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best
On Fri, 2007-12-14 at 10:07 +0100, Christian Ehrhardt wrote:
Hollis Blanchard wrote:
A comment to explain why the icache needs flushing only in the KVM
case
would be useful. Other than that I'm fine with it.
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
AFAIK Plain qemu does
you have easy instructions for
setting up a cross-build environment?
http://kernelnewbies.org/FAQ/KernelCrossCompilation has some info. It's
surprisingly easy.
--
Hollis Blanchard
IBM Linux Technology Center
-
This SF.net
What is the plan here, to ifdef the arch-specific callbacks? If so,
'tpr_access' is an obvious candidate...
--
Hollis Blanchard
IBM Linux Technology Center
On Wed, 2008-01-02 at 14:29 -0600, Jerone Young wrote:
# HG changeset patch
# User Jerone Young [EMAIL PROTECTED]
# Date 1199305658
or directory
because the source directory doesn't contain an include/asm symlink.
How can this work?
--
Hollis Blanchard
IBM Linux Technology Center
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy
Create an asm symlink from libkvm into the kernel source directory.
This allows one to use kernel trees built with the O= option.
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]
---
This is all I can come up with... it should work by accident for user/
and qemu/ directories too, since they use
I'm having a hard time parsing this.
Basically this patch is duplicating what Kbuild does: it is creating the
appropriate asm symlink. The original problem was that kvm-userspace
didn't have an asm symlink, so the patch does fix it.
--
Hollis Blanchard
IBM Linux Technology Center
On Mon, 2008
1 - 100 of 203 matches
Mail list logo
