Aaron Bentley has proposed merging lp:~abentley/lp-dev-utils/testr-remote into
lp:lp-dev-utils.
Commit message:
Add testr-remote.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~abentley/lp-dev-utils/testr-remote/+merge
Aaron Bentley has proposed merging
lp:~abentley/launchpad/no-private-translations into lp:launchpad.
Commit message:
Prevent translations for private products.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1083199 in Launchpad itself: translations can
The proposal to merge lp:~rharding/launchpad/nonpublic_1052659 into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/nonpublic_1052659/+merge/136479
--
Review: Approve
--
https://code.launchpad.net/~rharding/launchpad/nonpublic_1052659/+merge/136479
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
Review: Approve
--
https://code.launchpad.net/~jcsackett/launchpad/private-blueprint-dependencies/+merge/136756
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post
The proposal to merge lp:~jcsackett/launchpad/private-blueprint-dependencies
into lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/private-blueprint-dependencies/+merge/136756
--
#31
How do the errors look when joined?
I think they look fine. It's basically a one or two line paragraph.
Since we're just joining with a space I
wonder if we need to find a way to get into the rendering and force a
break/new line between errors for display?
I wanted to do that too,
The proposal to merge lp:~abentley/launchpad/more-transition-checks into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/more-transition-checks/+merge/136284
--
Aaron Bentley has proposed merging
lp:~abentley/launchpad/more-transition-checks into lp:launchpad.
Commit message:
Add more checks transitioning product to Proprietary.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1082422 in Launchpad itself: Product
Aaron Bentley has proposed merging
lp:~abentley/launchpad/transitive-confidential into lp:launchpad.
Requested reviews:
Abel Deuring (adeuring)
Aaron Bentley (abentley)
Related bugs:
Bug #1079785 in Launchpad itself: public artifacts are permitted on
confidential projects
https
I have a plan to show all validation error at form validation time, which I'll
pursue in a follow-up branch.
--
https://code.launchpad.net/~abentley/launchpad/transitive-confidential/+merge/135926
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
The proposal to merge lp:~abentley/launchpad/transitive-confidential into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/transitive-confidential/+merge/135926
--
The proposal to merge lp:~abentley/launchpad/transitive-confidential into
lp:launchpad has been updated.
Commit Message changed to:
Forbid non-proprietary artifacts when transitioning product to Proprietary
For more details, see:
The proposal to merge lp:~abentley/launchpad/productset-updates into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/productset-updates/+merge/135737
--
Translations must not exist at all, not just be disabled. Answers must also
not exist.
I know this, and I've already started work on addressing that. See bug
#1082422 and branch lp:~abentley/launchpad/more-transition-checks. Please add
any checks that I've missed to that bug.
There's
Aaron Bentley has proposed merging lp:~abentley/launchpad/productset-updates
into lp:launchpad.
Commit message:
Fix ProductSet privacy handling.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1082094 in Launchpad itself: Productset does not honour
The proposal to merge lp:~abentley/launchpad/transitive-confidential into
lp:launchpad has been updated.
Status: Approved = Work in progress
For more details, see:
https://code.launchpad.net/~abentley/launchpad/transitive-confidential/+merge/134995
--
Review: Approve
This is definitely an improvement. Please ensure a bug is filed about the lack
of a subscribed_by field in SpecificationSubscription, and reference it in the
security adapter and test comments. Please fix the too-long lines. You can do
this by assigning the enum to a local
Review: Approve
In getRequestTargets and list_product_request_targets, having the user default
to None means that calling code can accidentally omit it. I think it should be
a non-optional parameter, even though this means changing parameter order.
Other than that, this looks good to land.
--
Review: Approve
--
https://code.launchpad.net/~jcsackett/launchpad/blueprints-in-ui-not-specification/+merge/135503
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
The proposal to merge
lp:~jcsackett/launchpad/blueprints-in-ui-not-specification into lp:launchpad
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/blueprints-in-ui-not-specification/+merge/135503
--
The proposal to merge lp:~abentley/launchpad/proprietary-karma into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/proprietary-karma/+merge/135188
--
Review: Approve
Thanks!
--
https://code.launchpad.net/~rharding/launchpad/filter_more_products/+merge/135164
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to
Aaron Bentley has proposed merging
lp:~abentley/launchpad/transitive-confidential into lp:launchpad.
Commit message:
Forbid public artifacts on confidential products.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~abentley
The proposal to merge lp:~abentley/launchpad/transitive-confidential into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/transitive-confidential/+merge/134995
--
Aaron Bentley has proposed merging lp:~abentley/launchpad/fix-bp-timeouts into
lp:launchpad.
Commit message:
Fix timeouts checking blueprint visiblity
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1075569 in Launchpad itself: Timeout loading milestone
Review: Approve
--
https://code.launchpad.net/~deryck/launchpad/bugs-embargoed-or-proprietary-1079352/+merge/134746
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
The proposal to merge
lp:~deryck/launchpad/bugs-embargoed-or-proprietary-1079352 into lp:launchpad
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~deryck/launchpad/bugs-embargoed-or-proprietary-1079352/+merge/134746
--
Aaron Bentley has proposed merging
lp:~abentley/launchpad/proprietary-project-policies into lp:launchpad.
Commit message:
Fix policies for proprietary products.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1076412 in Launchpad itself: Proprietary
It would be safer to force them to convert all artifacts, and that was my
original approach (see r16253), but stakeholders have given us a requirement
that they can have a proprietary product with non-proprietary artifacts. This
is what I was talking about in the stand-up. So we can't do that.
Review: Approve
--
https://code.launchpad.net/~jcsackett/launchpad/filter-private-products-vocabulary/+merge/134542
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
The proposal to merge
lp:~jcsackett/launchpad/filter-private-products-vocabulary into lp:launchpad
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/filter-private-products-vocabulary/+merge/134542
--
Aaron Bentley has proposed merging lp:~abentley/lp-dev-utils/cs-test into
lp:lp-dev-utils.
Commit message:
Add cs-test script that creates a test env on Canonistack.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~abentley
Aaron Bentley has proposed merging lp:~abentley/launchpad/optimize-spec-query
into lp:launchpad.
Commit message:
Optimise specification-for-sprint queries.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~abentley/launchpad
As discussed on IRC, the obsolete code currently has other call sites. I do
plan to remove it, but that will involve more changes.
--
https://code.launchpad.net/~abentley/launchpad/optimize-spec-query/+merge/133716
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
The proposal to merge lp:~abentley/launchpad/optimize-spec-query into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/optimize-spec-query/+merge/133716
--
Curtis, I started off with the assumption that making a public project
proprietary could cause this bug, but I was unable to write a test case
demonstrating this, because Product._set_information_type ensures that the
appropriate access policy exists for the product's information type. That's
The proposal to merge lp:~abentley/launchpad/info-type-adds-policy into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/info-type-adds-policy/+merge/132749
--
The proposal to merge lp:~abentley/launchpad/no-proprietary-packagings into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/no-proprietary-packagings/+merge/132960
--
Aaron Bentley has proposed merging lp:~abentley/launchpad/info-type-adds-policy
into lp:launchpad.
Commit message:
Product information_type access policy is retained.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1074139 in Launchpad itself: Setting
Aaron Bentley has proposed merging lp:~abentley/launchpad/releasefinder-perms
into lp:launchpad.
Commit message:
Update permissions for productreleasefinder
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1072729 in Launchpad itself: private projects
Aaron Bentley has proposed merging lp:~abentley/launchpad/fix-assignment-list
into lp:launchpad.
Commit message:
Fix person page assigned spec listings.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1072981 in Launchpad itself: Blueprints showing up
The proposal to merge lp:~abentley/launchpad/person-assigned-specs-in-progress
into lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/person-assigned-specs-in-progress/+merge/130888
--
Aaron Bentley has proposed merging
lp:~abentley/launchpad/milestone-spec-privacy into lp:launchpad.
Commit message:
Milestone.getSpecifications respects spec privacy.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1067531 in Launchpad itself: private
The proposal to merge lp:~abentley/launchpad/milestone-spec-privacy into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/milestone-spec-privacy/+merge/131560
--
Review: Approve
--
https://code.launchpad.net/~rharding/launchpad/remove_assigned_specs_1068817/+merge/131558
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post
The proposal to merge lp:~rharding/launchpad/remove_assigned_specs_1068817 into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/remove_assigned_specs_1068817/+merge/131558
--
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 12-10-25 12:29 AM, Steve Kowalik wrote:
AND ( Specification.information_type IN (NULL, 1)
This, however, I will block on. You can't use NULL inside an IN, it
will compile as SQL, but youI are likely getting results you don't
expect.
That SQL
Aaron Bentley has proposed merging lp:~abentley/launchpad/beta-banner into
lp:launchpad.
Commit message:
Enable showing the beta banner.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1071207 in Launchpad itself: Project creation doesn't display beta
The proposal to merge lp:~abentley/launchpad/beta-banner into lp:launchpad has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/beta-banner/+merge/131346
--
Review: Approve
--
https://code.launchpad.net/~adeuring/launchpad/sec-adapter-projectgroup-milestone/+merge/130800
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
The proposal to merge lp:~adeuring/launchpad/sec-adapter-projectgroup-milestone
into lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~adeuring/launchpad/sec-adapter-projectgroup-milestone/+merge/130800
--
Aaron Bentley has proposed merging
lp:~abentley/launchpad/person-assigned-specs-in-progress into lp:launchpad.
Commit message:
Fix +portlet-currentfocus with proprietary specs.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1068719 in Launchpad itself
Aaron Bentley has proposed merging
lp:~abentley/launchpad/projectgroup-private-projects into lp:launchpad.
Commit message:
Fix milestone and projectgroup privacy bugs.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1063291 in Launchpad itself: Project
Review: Approve
abentley You're aware you're making it possible for interactive jobs to
starve mass jobs, right?
cjwatson Yes.
cjwatson The volume of interactive jobs is a couple of orders of magnitude
below capacity, and hardly ever goes over maybe a couple of dozen at a time.
--
The proposal to merge lp:~cjwatson/launchpad/pcj-queue-ordering into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/pcj-queue-ordering/+merge/130108
--
Aaron Bentley has proposed merging
lp:~abentley/launchpad/flag-enables-privacy-checks into lp:launchpad.
Commit message:
Provide disclosure.private_project.traversal_override.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1067771 in Launchpad itself
The proposal to merge lp:~abentley/launchpad/flag-enables-privacy-checks into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/flag-enables-privacy-checks/+merge/130185
--
The proposal to merge lp:~abentley/launchpad/product-specifications-privacy
into lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/product-specifications-privacy/+merge/130003
--
The proposal to merge lp:~abentley/launchpad/private-product-listings into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/private-product-listings/+merge/128800
--
Aaron Bentley has proposed merging lp:~abentley/launchpad/user-blueprints-tests
into lp:launchpad.
Commit message:
Add tests for Person.specifications.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~abentley/launchpad/user
Aaron Bentley has proposed merging lp:~abentley/launchpad/user-blueprints into
lp:launchpad with lp:~abentley/launchpad/user-blueprints-tests as a
prerequisite.
Commit message:
Re-implement Person.specifications using Storm expressions.
Requested reviews:
Launchpad code reviewers (launchpad
#34 The comments in here should be complete sentences ending in . per PEP8
http://www.python.org/dev/peps/pep-0008/#comments
Okay. I was copying them verbatim to make it easier to see how the new code
matched the old behaviour. That way, the diff matches up on the comments,
since it can't
The proposal to merge lp:~abentley/launchpad/user-blueprints into lp:launchpad
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/user-blueprints/+merge/129945
--
Aaron Bentley has proposed merging
lp:~abentley/launchpad/user-blueprints-privacy into lp:launchpad with
lp:~abentley/launchpad/user-blueprints as a prerequisite.
Commit message:
Use privacy filter for Person.specifications.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers
The proposal to merge lp:~abentley/launchpad/user-blueprints-privacy into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/user-blueprints-privacy/+merge/129967
--
Aaron Bentley has proposed merging
lp:~abentley/launchpad/product-specifications-tests into lp:launchpad with
lp:~abentley/launchpad/user-blueprints-privacy as a prerequisite.
Commit message:
Add unit tests for Product.specifications.
Requested reviews:
Launchpad code reviewers (launchpad
Aaron Bentley has proposed merging
lp:~abentley/launchpad/product-specifications-storm into lp:launchpad with
lp:~abentley/launchpad/product-specifications-tests as a prerequisite.
Commit message:
Reimplement Product.specifications.
Requested reviews:
Launchpad code reviewers (launchpad
Aaron Bentley has proposed merging
lp:~abentley/launchpad/product-specifications-privacy into lp:launchpad with
lp:~abentley/launchpad/product-specifications-storm as a prerequisite.
Commit message:
Enable privacy for Product.specifications.
Requested reviews:
Launchpad code reviewers
Aaron Bentley has proposed merging
lp:~abentley/launchpad/workitems-for-private-blueprints into lp:launchpad.
Commit message:
Filter non-Public blueprints for +upcomingwork.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1056891 in Launchpad itself
The proposal to merge lp:~abentley/launchpad/workitems-for-private-blueprints
into lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/workitems-for-private-blueprints/+merge/129736
--
Aaron Bentley has proposed merging
lp:~abentley/launchpad/private-product-listings into lp:launchpad.
Commit message:
Do not attempt to list Products for users who cannot view them.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1063264 in Launchpad
Aaron Bentley has proposed merging
lp:~abentley/launchpad/no-proprietary-linked-products into lp:launchpad.
Commit message:
No packaging links for Proprietary products.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1063297 in Launchpad itself: Linking
The proposal to merge lp:~abentley/launchpad/no-proprietary-linked-products
into lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/no-proprietary-linked-products/+merge/129507
--
Aaron Bentley has proposed merging lp:~abentley/launchpad/specification-policy
into lp:launchpad.
Commit message:
Specification sharing policy creates information types.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1061621 in Launchpad itself: Setting
Review: Approve
At first, I thought that this would always set the value to PUBLIC, but it only
does so if the context is not a Product, or the Product's default is PUBLIC.
So this is a good change.
--
https://code.launchpad.net/~rharding/launchpad/bp_default_1062207/+merge/129001
Your team
The proposal to merge lp:~abentley/launchpad/specification-policy into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/specification-policy/+merge/128998
--
Aaron Bentley has proposed merging
lp:~abentley/launchpad/private-product-listings into lp:launchpad.
Commit message:
Do not attempt to list Products for users who cannot view them.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
The proposal to merge lp:~abentley/launchpad/private-product-listings into
lp:launchpad has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~abentley/launchpad/private-product-listings/+merge/128800
--
Nice.
--
https://code.launchpad.net/~deryck/launchpad/actually-save-info-type-on-project-create/+merge/127863
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to
Aaron Bentley has proposed merging
lp:~abentley/launchpad/product-from-project-info-type into lp:launchpad.
Commit message:
Allow selecting information type when creating via Project Group.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Aaron Bentley has proposed merging
lp:~abentley/launchpad/limit-product-info-types into lp:launchpad.
Commit message:
Ensure only valid Product.information_type values are used.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Review: Approve
This looks reasonable.
Setting information_type to PUBLIC is a bit of a DRY violation, since
createProject takes care of that when unspecified or None. It's not the only
DRY violation in this regard, as the EnumCol declares a default (but I can't
figure out how to access it).
Aaron Bentley has proposed merging
lp:~abentley/launchpad/model-product-info-type into lp:launchpad.
Commit message:
Implement Product.information_type in Storm
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~abentley
The proposal to merge lp:~abentley/launchpad/model-product-info-type into
lp:launchpad has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~abentley/launchpad/model-product-info-type/+merge/127558
--
Aaron Bentley has proposed merging
lp:~abentley/launchpad/model-product-info-type into lp:launchpad.
Commit message:
Implement Product.information_type in Storm
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1060384 in Launchpad itself
Aaron Bentley has proposed merging
lp:~abentley/launchpad/product-info-type-garbo into lp:launchpad with
lp:~abentley/launchpad/model-product-info-type as a prerequisite.
Commit message:
Garbo job defaults Product.information_type to PUBLIC.
Requested reviews:
Launchpad code reviewers
The proposal to merge lp:~abentley/launchpad/model-product-info-type into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/model-product-info-type/+merge/127558
--
Aaron Bentley has proposed merging lp:~abentley/launchpad/new-tests into
lp:launchpad.
Commit message:
Add tests for Sprint.specifications.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~abentley/launchpad/new-tests/+merge
Aaron Bentley has proposed merging lp:~abentley/launchpad/storm-sprint-queries
into lp:launchpad with lp:~abentley/launchpad/new-tests as a prerequisite.
Commit message:
Convert Sprint.specifications to use storm expressions.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers
The proposal to merge lp:~abentley/launchpad/storm-sprint-queries into
lp:launchpad has been updated.
Description changed to:
= Summary =
Update Sprint.specifications to use storm expressions
== Pre-implementation notes ==
None
== LOC Rationale ==
Part of private projects
== Implementation
Aaron Bentley has proposed merging
lp:~abentley/launchpad/hide-sprint-blueprints into lp:launchpad with
lp:~abentley/launchpad/specification-cleanup as a prerequisite.
Commit message:
Respect privacy listing specifications for sprints.
Requested reviews:
Launchpad code reviewers (launchpad
This looks alright, but I'm not sure I see the value in the completeness
expression being a class method on the Specification class--it seems like
something that could just be defined as a clause separately in that code
Which code? Sprint.specification_filter? It should not be defined there,
As one minor point, it might be cleaner to set the default argument for user
in `specifications` to None, rather than passing in None everytime you need
it. But I don't see that as a blocker to approval--it's just a thought.
I don't think it would be cleaner to set a default, because it would
Review: Approve
--
https://code.launchpad.net/~rharding/launchpad/info_type_events/+merge/126317
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
The proposal to merge lp:~rharding/launchpad/info_type_events into lp:launchpad
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/info_type_events/+merge/126317
--
Aaron Bentley has proposed merging lp:~abentley/launchpad/spec-creation-js into
lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1052661 in Launchpad itself: Blueprint creation should use the same
information_type widget as editing.
https
Aaron Bentley has proposed merging
lp:~abentley/launchpad/fix-blueprints-home-with-proprietary into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1050960 in Launchpad itself: embargoed (or proprietary) specifications
break the blueprints
The proposal to merge
lp:~abentley/launchpad/fix-blueprints-home-with-proprietary into lp:launchpad
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/fix-blueprints-home-with-proprietary/+merge/124485
--
The proposal to merge lp:~abentley/launchpad/spec-creation-info-type into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~abentley/launchpad/spec-creation-info-type/+merge/123821
--
1 - 100 of 333 matches
Mail list logo
