Review: Approve
--
https://code.launchpad.net/~adeuring/launchpad/bug-1086057/+merge/138086
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
Richard Harding has proposed merging
lp:~rharding/launchpad/changing_maintainer_1077841 into lp:launchpad.
Commit message:
Add private property to Product so that it has LP.cache.context.private for the
JS pickers to determine context.
Requested reviews:
Launchpad code reviewers (launchpad
Review: Approve
--
https://code.launchpad.net/~sinzui/launchpad/cleanup-merged-people-1/+merge/137700
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
Review: Approve
#132
Shouldn't displayname also be moved to the interface like name? It seems
#221
The comment has a duped launchpad.View, I assume one is meant to be LimitedView
--
https://code.launchpad.net/~adeuring/launchpad/bug-1086043/+merge/137882
Your team Launchpad code reviewers is
The proposal to merge lp:~rharding/launchpad/changing_maintainer_1077841 into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/changing_maintainer_1077841/+merge/137849
--
Review: Approve
--
https://code.launchpad.net/~sinzui/launchpad/revision-karma-2/+merge/137906
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
Richard Harding has proposed merging
lp:~rharding/launchpad/blueprints_not_specs into lp:launchpad.
Commit message:
Change specifications to blueprints in the pillar sharing details UI.
Requested reviews:
Richard Harding (rharding)
For more details, see:
https://code.launchpad.net/~rharding
Review: Approve
Self reviewing one word change.
--
https://code.launchpad.net/~rharding/launchpad/blueprints_not_specs/+merge/137548
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list:
The proposal to merge lp:~rharding/launchpad/blueprints_not_specs into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/blueprints_not_specs/+merge/137548
--
The proposal to merge lp:~rharding/launchpad/shared_with_blueprints_1078751-2
into lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/shared_with_blueprints_1078751-2/+merge/137410
--
Review: Approve
Looks ok to me. As someone not familiar, is there something that tests that if
you try to pull up where the root itself is non-public?
--
https://code.launchpad.net/~jcsackett/launchpad/blueprint-private-traversal-deptree/+merge/137390
Your team Launchpad code reviewers is
Richard Harding has proposed merging
lp:~rharding/launchpad/shared_with_blueprints_1078751-2 into lp:launchpad.
Commit message:
Add specifications to the list of shared items in the person details sharing UI.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs
Richard Harding has proposed merging lp:~rharding/launchpad/nonpublic_1052659
into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~rharding/launchpad/nonpublic_1052659/+merge/136479
= Summary =
The code
The proposal to merge lp:~rharding/launchpad/nonpublic_1052659 into
lp:launchpad has been updated.
Description changed to:
= Summary =
The code was changed to only pull public specifications. In order to change
the method to be privacy aware it needed to be storm-ified and in the end much
of
The proposal to merge lp:~rharding/launchpad/nonpublic_1052659 into
lp:launchpad has been updated.
Commit Message changed to:
Make SpecificationSet.specifications privacy aware for the user in question.
For more details, see:
Richard Harding has proposed merging
lp:~rharding/launchpad/limit_sharing_infotype_1083761 into lp:launchpad.
Commit message:
Limit the policy options for get(Bug|Branch|Specification)SharingPolicies based
on the project information type.
Requested reviews:
Launchpad code reviewers
Review: Approve
--
https://code.launchpad.net/~adeuring/launchpad/lp-view-for-timelneproductseries/+merge/136374
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Review: Approve
--
https://code.launchpad.net/~adeuring/launchpad/bug-1056881-2/+merge/136194
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
Richard Harding has proposed merging lp:~rharding/launchpad/rollback_16295 into
lp:launchpad.
Commit message:
Rollback r16295 that added private project filters to queries around
translations since private projects cannot have translations.
Requested reviews:
Launchpad code reviewers
Review: Approve
Self approving rollback.
--
https://code.launchpad.net/~rharding/launchpad/rollback_16295/+merge/136216
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list:
The proposal to merge lp:~rharding/launchpad/rollback_16295 into lp:launchpad
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/rollback_16295/+merge/136216
--
Richard Harding has proposed merging lp:~rharding/launchpad/translatables into
lp:launchpad.
Commit message:
Update projectgroup.translatables to take information type into account to
prevent access.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see
The proposal to merge lp:~rharding/launchpad/translatables into lp:launchpad
has been updated.
Description changed to:
= Summary =
The .translations property and then getTranslatable methods it calls do not
take the privacy filter into account when querying.
== Pre Implementation ==
Talked
The proposal to merge lp:~rharding/launchpad/translatables into lp:launchpad
has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~rharding/launchpad/translatables/+merge/135492
--
Richard Harding has proposed merging
lp:~rharding/launchpad/filter_more_products into lp:launchpad.
Commit message:
Update product filters to prevent leaking non-public products in the
translationgroup code.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details
Review: Approve
#208
Multiple imports on the one line.
--
https://code.launchpad.net/~abentley/launchpad/proprietary-karma/+merge/135188
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list:
I've updated the one method that was changed to take a user argument and
updated the template and view to provide the user so that it doesn't use the
launchbag. However, changing the other ones, which are properties, will cascade
into a larger change that I'd prefer was done as a second branch.
The proposal to merge lp:~rharding/launchpad/filter_more_products into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/filter_more_products/+merge/135164
--
Review: Approve
I was the reviwer of the original MP and this is just to help fix the test and
land. Self approving this copy of the MP for landing the change.
--
https://code.launchpad.net/~rharding/launchpad/coc2/+merge/134645
Your team Launchpad code reviewers is subscribed to branch
This is merged and QA'd. It should go out in the first deploy of next week
since no one wants to deploy on a Friday. Let me know if there's any issue or
anything else that needs a hand.
--
https://code.launchpad.net/~dholbach/launchpad/coc-2.0/+merge/133702
Your team Launchpad code reviewers is
Review: Approve
--
https://code.launchpad.net/~jcsackett/launchpad/productseries-branch-infotype-mismatch/+merge/134250
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list:
Review: Needs Information
I did not manage to update the signed code of conduct, because I didn't know
how exactly it was generated. So with this piece I need some help.
Hey Daniel, I *think* you're referring to the signed CoC in the test suite? If
so, the tests are using the GPG keys in
Daniel, I've managed to get the tests passing I think. I've pushed my branch
over @
https://code.launchpad.net/~rharding/launchpad/coc2
To sign the coc correctly I had to import the t...@canonical.com.sec key from
lib/lp/testing/gpgkeys. Then signed --cleansign --default-key X. The
testing
Review: Approve
#64 typo: Unaut[h]orized
--
https://code.launchpad.net/~adeuring/launchpad/product-lp-limitedview-branch-view/+merge/134315
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list:
Richard Harding has proposed merging lp:~rharding/launchpad/private_sprites
into lp:launchpad.
Commit message:
Add new dual wide privacy sprites for use in branches, blueprints, and products.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1056893
Review: Approve
--
https://code.launchpad.net/~sinzui/launchpad/unicode-project-group-bug/+merge/134154
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to
The proposal to merge lp:~sinzui/launchpad/unicode-project-group-bug into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~sinzui/launchpad/unicode-project-group-bug/+merge/134154
--
Review: Approve
#58/59
Do you mean to be asserting that the factory is working by checking the
information type/title on bug?
I thought in the stand up it was brought that the the query counts should be
exact so that you can know when you changed/broke something that reduced the
query count
Richard Harding has proposed merging
lp:~rharding/launchpad/security_banner_107842 into lp:launchpad.
Commit message:
Update information type javascript to not count public security as a private
event.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug
The proposal to merge lp:~rharding/launchpad/security_banner_107842 into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/security_banner_107842/+merge/134187
--
The proposal to merge lp:~rharding/launchpad/security_banner_107842 into
lp:launchpad has been updated.
Description changed to:
Small fix to make sure we don't count public security as worthy of having the
privacy banner showing with the warning.
To fix this we just update the event filters
The proposal to merge lp:~rharding/launchpad/add_new_banner into lp:launchpad
has been updated.
Description changed to:
= Summary =
We need to add banner support to projects and blueprints now that they support
privacy. As these features are also in beta we really wanted to enable the
display
Richard Harding has proposed merging lp:~rharding/launchpad/add_new_banner into
lp:launchpad.
Commit message:
Add a new set of JS code for handling Banner UI and a new global Y.View as a
controller for the logic.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more
Richard Harding has proposed merging lp:~rharding/launchpad/fix_flash_1066898
into lp:launchpad.
Commit message:
Disable green flash animation when changing the information type on project
new/edit.
Requested reviews:
Richard Harding (rharding)
Related bugs:
Bug #1066898 in Launchpad
Review: Approve
Self approving one liner.
--
https://code.launchpad.net/~rharding/launchpad/fix_flash_1066898/+merge/131529
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list:
The proposal to merge lp:~rharding/launchpad/fix_flash_1066898 into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/fix_flash_1066898/+merge/131529
--
Richard Harding has proposed merging
lp:~rharding/launchpad/remove_assigned_specs_1068817 into lp:launchpad with
lp:~rharding/launchpad/fix_flash_1066898 as a prerequisite.
Commit message:
Remove person.assigned_specs due to limited use and to prevent possible leakage.
Requested reviews
The proposal to merge lp:~rharding/launchpad/remove_assigned_specs_1068817 into
lp:launchpad has been updated.
Commit Message changed to:
Remove person.assigned_specs due to limited use and to prevent possible leakage.
For more details, see:
Review: Approve
--
https://code.launchpad.net/~abentley/launchpad/milestone-spec-privacy/+merge/131560
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
The proposal to merge lp:~rharding/launchpad/remove_assigned_specs_1068817 into
lp:launchpad has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~rharding/launchpad/remove_assigned_specs_1068817/+merge/131558
--
The proposal to merge lp:~rharding/launchpad/update_js_testconsole into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/update_js_testconsole/+merge/131583
--
The proposal to merge lp:~rharding/launchpad/update_js_testconsole into
lp:launchpad has been updated.
Commit Message changed to:
Change the YUI tests to use the 3.5 test-console vs the older console for
better test pages.
For more details, see:
Review: Approve
Self approving a mechanical change.
--
https://code.launchpad.net/~rharding/launchpad/update_js_testconsole/+merge/131583
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list:
Richard Harding has proposed merging
lp:~rharding/launchpad/remove_assigned_specs_1068817 into lp:launchpad with
lp:~rharding/launchpad/fix_flash_1066898 as a prerequisite.
Commit message:
Remove person.assigned_specs due to limited use and to prevent possible leakage.
Requested reviews
Richard Harding has proposed merging
lp:~rharding/launchpad/limit_product_types_1066904 into lp:launchpad.
Commit message:
Limit the information type widget vocabulary on project modifications.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1066904
Hi Rick,
Some comments on your branch:
* In genAffiliatedProductSql there is a lot of repetition in the queries that
could be factored out so you DRY as the first query you return is a the same
as the final one minus one clause. Give a shot at refactoring if you don't
mind.
Thanks for
The proposal to merge lp:~rharding/launchpad/related_projects_1063272 into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/related_projects_1063272/+merge/130414
--
Review: Approve
--
https://code.launchpad.net/~adeuring/launchpad/bug-1063287/+merge/130540
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
Richard Harding has proposed merging
lp:~rharding/launchpad/related_projects_1063272 into lp:launchpad.
Commit message:
Filter affiliatedPillars based on access grants to hide non-visible products.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1063272
Review: Approve
--
https://code.launchpad.net/~abentley/launchpad/flag-enables-privacy-checks/+merge/130185
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to
Review: Approve
--
https://code.launchpad.net/~abentley/launchpad/private-product-listings/+merge/128800
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to
Review: Approve
Thanks Abel, looks good with some typo nitpicks and one question for you.
#155 Should the check here be against distributions directed instead of
indirectly using product?
#260 Typo in assertAccessAuthorzized (Authorized) [ok, find and repeat
throughout here]
#264 Typo
Review: Approve
--
https://code.launchpad.net/~abentley/launchpad/user-blueprints-tests/+merge/129944
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
Review: Approve
#34 The comments in here should be complete sentences ending in . per PEP8
http://www.python.org/dev/peps/pep-0008/#comments
#204 extra blank line?
--
https://code.launchpad.net/~abentley/launchpad/user-blueprints/+merge/129945
Your team Launchpad code reviewers is subscribed
Richard Harding has proposed merging
lp:~rharding/launchpad/info_portlet_1052551 into lp:launchpad.
Commit message:
Update the JS initialization for the blueprint information type portlet.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1052551
The proposal to merge lp:~rharding/launchpad/info_portlet_1052551 into
lp:launchpad has been updated.
Description changed to:
= Summary =
See the bug for details on how users are unable to change the InformationType
on the bluesprints from the portlet.
== Implementation Notes ==
This fixes a
Looks good. A couple of minor points:
It would be nice to fix the long line on line 26 of the diff.
Doh, thanks for the heads up on that.
Would it be possible to put the explicit style attributes on line 31 and 79
into a stylesheet?
If there was a true widget with CSS properties I'd
The proposal to merge lp:~rharding/launchpad/info_portlet_1052551 into
lp:launchpad has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/info_portlet_1052551/+merge/129706
--
Richard Harding has proposed merging
lp:~rharding/launchpad/bp_validate_type_1062198 into lp:launchpad.
Commit message:
Add validation of the information type to addspec views.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1062198 in Launchpad itself
Richard Harding has proposed merging lp:~rharding/launchpad/fix_buildbot_tests
into lp:launchpad.
Commit message:
Correct broken tests from adding private product enabling.
Requested reviews:
Richard Harding (rharding)
For more details, see:
https://code.launchpad.net/~rharding/launchpad
Richard Harding has proposed merging lp:~rharding/launchpad/bp_default_1062207
into lp:launchpad.
Commit message:
Add initial value date for the information_type and default to PUBLIC vs None
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1062207
Review: Approve
--
https://code.launchpad.net/~sinzui/launchpad/moderated-messages-0/+merge/129013
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
The proposal to merge lp:~rharding/launchpad/bp_default_1062207 into
lp:launchpad has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~rharding/launchpad/bp_default_1062207/+merge/129001
--
Per chat with Aaron in irc. We should be using the
getDefaultSpecificationInformationType of the various pillars vs hard coding
the default to being InformationType.PUBLIC.
--
https://code.launchpad.net/~rharding/launchpad/bp_default_1062207/+merge/129001
Your team Launchpad code reviewers is
Review: Approve
Thanks for the update Aaron. I think I follow along.
The comment in #49 implies there's some filtering after the fact around
bug/branch policies. I just bring it up to verify there's nothing there to be
added for the additional specification policy code.
Edit: never mind, but
The proposal to merge lp:~rharding/launchpad/store_edit_product_info_type into
lp:launchpad has been updated.
Status: Approved = Work in progress
For more details, see:
https://code.launchpad.net/~rharding/launchpad/store_edit_product_info_type/+merge/128288
--
Richard Harding has proposed merging lp:~rharding/launchpad/info_type_events
into lp:launchpad.
Commit message:
Add events to information_type and privacy banner to drive usage.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Review: Approve
--
https://code.launchpad.net/~wallyworld/launchpad/getBranches-dsp-579602/+merge/126149
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to
Review: Approve
--
https://code.launchpad.net/~cjwatson/launchpad/pabj-remove-feature-flag/+merge/126090
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to
I've added the notes and description about the copied html output. See #272 and
#353 for the comment and the note on the start of the pasted html.
There's a specific note because copying the html causes a script block to get
copied. We're putting this inside of a mustache template (a script
Review: Approve
Thanks Abel, just one typo in #164 of the diff. Subscibing...
--
https://code.launchpad.net/~adeuring/launchpad/revokeAccessGrants_specs/+merge/126261
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Much improved.
I would still like to see more step-by-step instructions on how to update the
code. In particular, how do I find the page the code is on?
Thanks, added a note in the comment that it's copied from the dev tools during
project registration step two view.
--
The proposal to merge lp:~rharding/launchpad/regjs into lp:launchpad has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/regjs/+merge/125780
--
https://code.launchpad.net/~rharding/launchpad/regjs/+merge/125780
Your team
Richard Harding has proposed merging lp:~rharding/launchpad/yui3-5-1-dammit
into lp:launchpad.
Commit message:
Update to using YUI 3.5.1 as the default JS library target.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
The proposal to merge lp:~rharding/launchpad/yui3-5-1-dammit into lp:launchpad
has been updated.
Description changed to:
Make YUI 3.5.1 the default for all purposes. This means that all JS tests will
run under the 3.5.1 version of the library.
YAY!
Once this change is complete, we can
The proposal to merge lp:~rharding/launchpad/yui3-5-1-dammit into lp:launchpad
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/yui3-5-1-dammit/+merge/126015
--
Review: Approve
Self approve rollback.
--
https://code.launchpad.net/~rharding/launchpad/yui3-5-1-dammit-rollback/+merge/126050
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list:
The proposal to merge lp:~rharding/launchpad/yui3-5-1-dammit into lp:launchpad
has been updated.
Status: Merged = Work in progress
For more details, see:
https://code.launchpad.net/~rharding/launchpad/yui3-5-1-dammit/+merge/126015
--
Review: Approve
Updated tests to not have timeout issues on ec2, should make them work for
buildbot solving issue there as well.
--
https://code.launchpad.net/~rharding/launchpad/yui3-5-1-dammit/+merge/126015
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
The proposal to merge lp:~rharding/launchpad/yui3-5-1-dammit into lp:launchpad
has been updated.
Status: Merged = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/yui3-5-1-dammit/+merge/126015
--
The proposal to merge lp:~rharding/launchpad/yui3-5-1-dammit into lp:launchpad
has been updated.
Commit Message changed to:
Update to using YUI 3.5.1 as the default JS library target. Update tests to run
along and pass buildbot. 3rd pass.
For more details, see:
Richard Harding has proposed merging
lp:~rharding/launchpad/clean_information_type into lp:launchpad.
Commit message:
Clean naming in information_type js.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~rharding/launchpad
Richard Harding has proposed merging lp:~rharding/launchpad/fix_productjs into
lp:launchpad.
Requested reviews:
Richard Harding (rharding)
Related bugs:
Bug #1049880 in Launchpad itself: Project registration JS is in .pt without
tests.
https://bugs.launchpad.net/launchpad/+bug/1049880
The proposal to merge lp:~rharding/launchpad/fix_productjs into lp:launchpad
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rharding/launchpad/fix_productjs/+merge/125159
--
Review: Approve
Self reviwing small change.
--
https://code.launchpad.net/~rharding/launchpad/fix_productjs/+merge/125159
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list:
The proposal to merge lp:~rharding/launchpad/move_into_utils into lp:launchpad
has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~rharding/launchpad/move_into_utils/+merge/125224
--
Review: Approve
Got the ok to self-review this large mechanical change.
--
https://code.launchpad.net/~rharding/launchpad/move_into_utils/+merge/125224
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list:
The proposal to merge lp:~rharding/launchpad/fix_productjs into lp:launchpad
has been updated.
Commit Message changed to:
[rollback=15975] Correct calling of new product view JS code.
For more details, see:
https://code.launchpad.net/~rharding/launchpad/fix_productjs/+merge/125159
--
Review: Approve
Thanks for clearing up in irc that the karma changes are needed to get the user
to not be probationary. For devs not totally aware of the distinction a comment
to that effect would be helpful. Thanks for the change.
--
Review: Approve
Per IRC there's some code aroud #96 and on that reference Branches vs
specfications that needs cleaning up.
I also wonder, if we know the query will need to be replaced by some flattened
table, if we should have a bug and an XXX on the current query to make can find
it easily
1 - 100 of 271 matches
Mail list logo
