[Launchpad-reviewers] [Merge] ~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master

2021-04-06 Thread noreply
The proposal to merge ~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/399987 -- Your team Launchpad code reviewers is subscribed

[Launchpad-reviewers] [Merge] ~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master

2021-04-06 Thread Thiago F. Pappacena
The proposal to merge ~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/399987 -- Your team Launchpad code reviewers is

Re: [Launchpad-reviewers] [Merge] ~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master

2021-04-06 Thread Thiago F. Pappacena
Diff comments: > diff --git a/lib/lp/oci/interfaces/ocirecipe.py > b/lib/lp/oci/interfaces/ocirecipe.py > index 5ed23a7..ecc90c8 100644 > --- a/lib/lp/oci/interfaces/ocirecipe.py > +++ b/lib/lp/oci/interfaces/ocirecipe.py > @@ -241,6 +241,11 @@ class IOCIRecipeView(Interface): >

Re: [Launchpad-reviewers] [Merge] ~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master

2021-04-06 Thread Colin Watson
Review: Approve Diff comments: > diff --git a/lib/lp/oci/interfaces/ocirecipe.py > b/lib/lp/oci/interfaces/ocirecipe.py > index 5ed23a7..ecc90c8 100644 > --- a/lib/lp/oci/interfaces/ocirecipe.py > +++ b/lib/lp/oci/interfaces/ocirecipe.py > @@ -241,6 +241,11 @@ class IOCIRecipeView(Interface):

[Launchpad-reviewers] [Merge] ~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master

2021-03-22 Thread Thiago F. Pappacena
Thiago F. Pappacena has proposed merging ~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master with ~pappacena/launchpad:ocirecipe-subscribe-removal-job as a prerequisite. Commit message: Showing private top banner on private OCI recipes pages Requested reviews: Launchpad