Re: [Launchpad-reviewers] [Merge] ~artivis/lpcraft:feature/ros-plugins into lpcraft:main

2023-01-10 Thread jeremie
Hello, I've already tackled the missed lines in coverage and the CI is happy as far as I can tell. We are indeed planning on using those plugins in Launchpad CI. This MP is stand-alone and totally independent of https://code.launchpad.net/~artivis/lpcraft/+git/lpcraft/+merge/435370 . Looking

[Launchpad-reviewers] [Merge] ~artivis/lpcraft:feature/yaml-include into lpcraft:main

2023-01-10 Thread jeremie
jeremie has proposed merging ~artivis/lpcraft:feature/yaml-include into lpcraft:main with ~artivis/lpcraft:feature/yaml-alias-filter as a prerequisite. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see:

Re: [Launchpad-reviewers] [Merge] ~artivis/lpcraft:feature/yaml-alias into lpcraft:main

2023-01-10 Thread Jürgen Gmach
Some more info about this topic: https://medium.com/@kinghuang/docker-compose-anchors-aliases-extensions-a1e4105d70bd -- https://code.launchpad.net/~artivis/lpcraft/+git/lpcraft/+merge/435370 Your team Launchpad code reviewers is requested to review the proposed merge of

Re: [Launchpad-reviewers] [Merge] ~artivis/lpcraft:feature/ros-plugins into lpcraft:main

2023-01-10 Thread Jürgen Gmach
Jeremie, thanks for the merge proposal. CI currently fails as there are two uncovered lines, see buildlog below (below `unmerged commits`): ``` :: lpcraft/plugins/plugins.py 284 2 64 1 99% 482, 491 ``` Could you please fix these? As lpcraft is both

[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:apidoc-git-repositories-url into launchpad:master

2023-01-10 Thread Colin Watson
Colin Watson has proposed merging ~cjwatson/launchpad:apidoc-git-repositories-url into launchpad:master. Commit message: apidoc: Fix URL of top-level git_repositories collection Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see:

[Launchpad-reviewers] [Merge] ~artivis/lpcraft:feature/yaml-include into lpcraft:main

2023-01-10 Thread jeremie
The proposal to merge ~artivis/lpcraft:feature/yaml-include into lpcraft:main has been updated. Description changed to: [Do Not Merge Yet] Note: This is based on top of another branch (https://git.launchpad.net/~artivis/lpcraft/tree/?h=feature/yaml-alias-filter) which may replace MP