Re: [Launchpad-reviewers] [Merge] lp:~mbp/launchpad/dkim into lp:launchpad

2010-10-19 Thread Jonathan Lange
Review: Approve -- https://code.launchpad.net/~mbp/launchpad/dkim/+merge/35985 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/dkim into lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~mbp/launchpad/dkim into lp:launchpad

2010-10-19 Thread Martin Pool
Looking at it again, I'm not sure if the handling of new@ is really correct, but the tests should tell us. - Martin On 19/10/2010 7:38 PM, Jonathan Lange j...@mumak.net wrote: Review: Approve -- https://code.launchpad.net/~mbp/launchpad/dkim/+merge/35985 You are the owner of

Re: [Launchpad-reviewers] [Merge] lp:~lifeless/launchpad/uniqueconfig into lp:launchpad/devel

2010-10-19 Thread Brad Crittenden
On Oct 19, 2010, at 02:15 , Robert Collins wrote: On Tue, Oct 19, 2010 at 5:42 AM, Henning Eggers Please talk to Brad about both issues and see what he says. I'm not sure why Brad specifically - the review team was always a democracy ever since it was formulated : we really want broad

Re: [Launchpad-reviewers] [Merge] lp:~lifeless/launchpad/uniqueconfig into lp:launchpad/devel

2010-10-19 Thread Robert Collins
On Tue, Oct 19, 2010 at 11:32 PM, Brad Crittenden brad.critten...@canonical.com wrote: As to the fear that people will be unwilling to wander into the dark corners of the code base for fear they will be accountable for cleaning it all up, I'm not convinced that will be the way most of us

[Launchpad-reviewers] [Merge] lp:~jtv/launchpad/recife-pofile-owner-privs into lp:~launchpad/launchpad/recife

2010-10-19 Thread Jeroen T. Vermeulen
Jeroen T. Vermeulen has proposed merging lp:~jtv/launchpad/recife-pofile-owner-privs into lp:~launchpad/launchpad/recife. Requested reviews: Launchpad code reviewers (launchpad-reviewers): code Strip POFile.owner of its privileges For the Recife feature

[Launchpad-reviewers] [Merge] lp:~leonardr/launchpad/temporary-integration into lp:launchpad

2010-10-19 Thread Leonard Richardson
Leonard Richardson has proposed merging lp:~leonardr/launchpad/temporary-integration into lp:launchpad with lp:~leonardr/launchpad/oauth-doctest-to-unit-test as a prerequisite. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For the first time, this branch makes it

[Launchpad-reviewers] [Merge] lp:~jml/launchpad/codebrowse-config-cp into lp:~launchpad-pqm/launchpad/production-devel

2010-10-19 Thread Jonathan Lange
Jonathan Lange has proposed merging lp:~jml/launchpad/codebrowse-config-cp into lp:~launchpad-pqm/launchpad/production-devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers) This branch cherry picks in a recent change that allows codebrowse's port and IP to be configured,

Re: [Launchpad-reviewers] [Merge] lp:~bryce/launchpad/lp-617691-retrieve into lp:launchpad

2010-10-19 Thread Bryce Harrington
I've just lp-landed lp-617699-api, which this branch depends on. -- https://code.launchpad.net/~bryce/launchpad/lp-617691-retrieve/+merge/38804 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bryce/launchpad/lp-617691-retrieve into lp:launchpad.

[Launchpad-reviewers] [Merge] lp:~adeuring/launchpad/bug-594247-unittests-for-searchtasks into lp:launchpad/devel

2010-10-19 Thread Abel Deuring
Abel Deuring has proposed merging lp:~adeuring/launchpad/bug-594247-unittests-for-searchtasks into lp:launchpad/devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers) This branch is the start of a sort of testing madness for the methods BugTaskSet.search() and

[Launchpad-reviewers] [Merge] lp:~abentley/launchpad/detect-xen into lp:launchpad/devel

2010-10-19 Thread LaMont Jones
LaMont Jones has proposed merging lp:~abentley/launchpad/detect-xen into lp:launchpad/devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: #662664 recipe builds should ensure they run only under xen https://bugs.launchpad.net/bugs/662664 launchpad-buildd

[Launchpad-reviewers] [Merge] lp:~rockstar/launchpad/fix-kill-test-services into lp:launchpad/devel

2010-10-19 Thread Paul Hummer
Paul Hummer has proposed merging lp:~rockstar/launchpad/fix-kill-test-services into lp:launchpad/devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers) The Launchpad librarian can get wedged in some pretty fantastic ways. Today, I learned about a bunch of them. My

[Launchpad-reviewers] [Merge] lp:~lamont/launchpad/lp-buildd-71 into lp:launchpad

2010-10-19 Thread LaMont Jones
LaMont Jones has proposed merging lp:~lamont/launchpad/lp-buildd-71 into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) As released -- https://code.launchpad.net/~lamont/launchpad/lp-buildd-71/+merge/38882 Your team Launchpad code reviewers is requested to

Re: [Launchpad-reviewers] [Merge] lp:~lamont/launchpad/lp-buildd-71 into lp:launchpad

2010-10-19 Thread Tim Penhey
Probably should go into devel? rather than db-devel? -- https://code.launchpad.net/~lamont/launchpad/lp-buildd-71/+merge/38882 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~lamont/launchpad/lp-buildd-71 into lp:launchpad.

[Launchpad-reviewers] [Merge] lp:~mwhudson/launchpad/testtools into lp:launchpad/devel

2010-10-19 Thread Michael Hudson-Doyle
Michael Hudson-Doyle has proposed merging lp:~mwhudson/launchpad/testtools into lp:launchpad/devel with lp:~lifeless/launchpad/testtools as a prerequisite. Requested reviews: Launchpad code reviewers (launchpad-reviewers) I fixed some fallout from the prerequisite branch. --

[Launchpad-reviewers] [Merge] lp:~mwhudson/launchpad/testtools into lp:launchpad/devel

2010-10-19 Thread Michael Hudson-Doyle
The proposal to merge lp:~mwhudson/launchpad/testtools into lp:launchpad/devel has been updated. Commit Message changed to: Update to to testtools 0.9.7. -- https://code.launchpad.net/~mwhudson/launchpad/testtools/+merge/38896 Your team Launchpad code reviewers is requested to review the

[Launchpad-reviewers] [Merge] lp:~mwhudson/launchpad/testtools into lp:launchpad/devel

2010-10-19 Thread Michael Hudson-Doyle
The proposal to merge lp:~mwhudson/launchpad/testtools into lp:launchpad/devel has been updated. Description changed to: I fixed some fallout from the prerequisite branch. -- https://code.launchpad.net/~mwhudson/launchpad/testtools/+merge/38896 Your team Launchpad code reviewers is requested

[Launchpad-reviewers] [Merge] lp:~thumper/launchpad/needs-review-event into lp:launchpad/devel

2010-10-19 Thread noreply
The proposal to merge lp:~thumper/launchpad/needs-review-event into lp:launchpad/devel has been updated. Status: Approved = Merged -- https://code.launchpad.net/~thumper/launchpad/needs-review-event/+merge/38686 Your team Launchpad code reviewers is requested to review the proposed merge of

Re: [Launchpad-reviewers] [Merge] lp:~thumper/launchpad/kill-bad-form-preloads into lp:launchpad/devel

2010-10-19 Thread Tim Penhey
We can't easily trigger the login from the ajax calls. By not hooking up the link bug, we are leaving the link there, but not connected to ajax. That way they do get sent to the login page, even though they then go to an icky non-js version for linking a bug. The edit button just shouldn't

[Launchpad-reviewers] [Merge] lp:~wallyworld/launchpad/improved-broken-link-handling into lp:launchpad/devel

2010-10-19 Thread Ian Booth
You have been requested to review the proposed merge of lp:~wallyworld/launchpad/improved-broken-link-handling into lp:launchpad/devel. Summary Render lp: shortcuts such that any invalid ones are shown as grey and their onclick() is suppressed. This branch supports processing