Re: [Launchpad-reviewers] [Merge] ~artivis/lpcraft:feature/ros-plugins into lpcraft:main

2023-01-10 Thread jeremie
Hello, I've already tackled the missed lines in coverage and the CI is happy as far as I can tell. We are indeed planning on using those plugins in Launchpad CI. This MP is stand-alone and totally independent of https://code.launchpad.net/~artivis/lpcraft/+git/lpcraft/+merge/435370 . Looking

[Launchpad-reviewers] [Merge] ~artivis/lpcraft:feature/yaml-include into lpcraft:main

2023-01-10 Thread jeremie
jeremie has proposed merging ~artivis/lpcraft:feature/yaml-include into lpcraft:main with ~artivis/lpcraft:feature/yaml-alias-filter as a prerequisite. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~artivis/lpcraft/+git

[Launchpad-reviewers] [Merge] ~artivis/lpcraft:feature/yaml-include into lpcraft:main

2023-01-10 Thread jeremie
The proposal to merge ~artivis/lpcraft:feature/yaml-include into lpcraft:main has been updated. Description changed to: [Do Not Merge Yet] Note: This is based on top of another branch (https://git.launchpad.net/~artivis/lpcraft/tree/?h=feature/yaml-alias-filter) which may replace MP

[Launchpad-reviewers] [Merge] ~artivis/lpcraft:feature/ros-plugins into lpcraft:main

2023-01-09 Thread jeremie
jeremie has proposed merging ~artivis/lpcraft:feature/ros-plugins into lpcraft:main. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~artivis/lpcraft/+git/lpcraft/+merge/435371 This implements three new plugins for building

[Launchpad-reviewers] [Merge] ~artivis/lpcraft:feature/yaml-alias into lpcraft:main

2023-01-09 Thread jeremie
jeremie has proposed merging ~artivis/lpcraft:feature/yaml-alias into lpcraft:main. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~artivis/lpcraft/+git/lpcraft/+merge/435370 Changes pydantic configuration for extra fields

Re: [Launchpad-reviewers] [Merge] ~artivis/lpcraft:feature/yaml-alias into lpcraft:main

2023-01-09 Thread jeremie
> Is there some way that we could at least confine field names used for anchors > to some kind of namespace? Thanks for the prompt review. Another option would be to implement a pydantic root_validator that simply filters out entries at the root level based on a prefix - see here