[Launchpad-reviewers] [Merge] ~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master

2021-04-06 Thread noreply 
The proposal to merge ~pappacena/launchpad:ocirecipe-privacy-banners-ui into 
launchpad:master has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/399987
-- 
Your team Launchpad code reviewers is subscribed to branch 
~pappacena/launchpad:ocirecipe-subscribe-removal-job.

___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

[Launchpad-reviewers] [Merge] ~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master

2021-04-06 Thread Thiago F. Pappacena 
The proposal to merge ~pappacena/launchpad:ocirecipe-privacy-banners-ui into 
launchpad:master has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/399987
-- 
Your team Launchpad code reviewers is subscribed to branch 
~pappacena/launchpad:ocirecipe-subscribe-removal-job.

___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Launchpad-reviewers] [Merge] ~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master

2021-04-06 Thread Thiago F. Pappacena 



Diff comments:

> diff --git a/lib/lp/oci/interfaces/ocirecipe.py 
> b/lib/lp/oci/interfaces/ocirecipe.py
> index 5ed23a7..ecc90c8 100644
> --- a/lib/lp/oci/interfaces/ocirecipe.py
> +++ b/lib/lp/oci/interfaces/ocirecipe.py
> @@ -241,6 +241,11 @@ class IOCIRecipeView(Interface):
>  description=_("True if this recipe is official for its OCI 
> project."),
>  readonly=True)
>  
> +private = Bool(
> +title=_("Is this OCI recipe private?"),
> +required=False, readonly=True,

Ok!

> +description=_("True if this recipe is private. False otherwise."))
> +
>  pillar = Attribute('The pillar of this OCI recipe.')
>  
>  @call_with(check_permissions=True, user=REQUEST_USER)


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/399987
Your team Launchpad code reviewers is subscribed to branch 
~pappacena/launchpad:ocirecipe-subscribe-removal-job.

___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Launchpad-reviewers] [Merge] ~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master

2021-04-06 Thread Colin Watson 
Review: Approve



Diff comments:

> diff --git a/lib/lp/oci/interfaces/ocirecipe.py 
> b/lib/lp/oci/interfaces/ocirecipe.py
> index 5ed23a7..ecc90c8 100644
> --- a/lib/lp/oci/interfaces/ocirecipe.py
> +++ b/lib/lp/oci/interfaces/ocirecipe.py
> @@ -241,6 +241,11 @@ class IOCIRecipeView(Interface):
>  description=_("True if this recipe is official for its OCI 
> project."),
>  readonly=True)
>  
> +private = Bool(
> +title=_("Is this OCI recipe private?"),
> +required=False, readonly=True,

This is never None, so can be `required=True`.

> +description=_("True if this recipe is private. False otherwise."))
> +
>  pillar = Attribute('The pillar of this OCI recipe.')
>  
>  @call_with(check_permissions=True, user=REQUEST_USER)


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/399987
Your team Launchpad code reviewers is subscribed to branch 
~pappacena/launchpad:ocirecipe-subscribe-removal-job.

___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

[Launchpad-reviewers] [Merge] ~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master

2021-03-22 Thread Thiago F. Pappacena 
Thiago F. Pappacena has proposed merging 
~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master with 
~pappacena/launchpad:ocirecipe-subscribe-removal-job as a prerequisite.

Commit message:
Showing private top banner on private OCI recipes pages

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/399987
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of 
~pappacena/launchpad:ocirecipe-privacy-banners-ui into launchpad:master.
diff --git a/lib/lp/oci/browser/configure.zcml b/lib/lp/oci/browser/configure.zcml
index 53db0d2..31dcbc9 100644
--- a/lib/lp/oci/browser/configure.zcml
+++ b/lib/lp/oci/browser/configure.zcml
@@ -27,6 +27,12 @@
 for="lp.oci.interfaces.ocirecipe.IOCIRecipe"
 class="lp.oci.browser.ocirecipe.OCIRecipeView"
 permission="launchpad.View"
+name="+portlet-privacy"
+template="../templates/ocirecipe-portlet-privacy.pt"/>
+
 
 
   
+
 
 
   
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp