+def runGerminate(self, override_file, series_name, arch, flavours,
+ structures):
Rightly or wrongly, the “run” in that name led me to expect that this method
would fire up a separate process. Maybe a very short docstring to dispel that
notion?
+germinator =
Getting a better feel for the structure of runGerminate now. Which makes me
wonder:
+# Generate apt-ftparchive extra overrides for Build-Essential
+# fields.
+if ('build-essential' in structure.names and
+flavour == flavours[0]):
+
I think you're right that the file shouldn't be put in place if the
context exits with an exception. If I were writing this without context
managers, then rather than:
with AtomicFile('foo') as handle:
print handle, 'bar'
... I'd probably write:
handle = open('foo.new', 'w')
Ah, I see now why you can't do that: writeOverrides is a closure. It picks up
“structure” and “arch” from the surrounding method at its point of definition.
There's another easy thing to break by accident! The structure should again be
structures[flavours[0]], I guess.
Might it be
On Wed, Dec 07, 2011 at 07:20:29AM -, Jeroen T. Vermeulen wrote:
The part from “series = None” onward seems to be an isolated unit of
work. I think it looks for the first distroseries in development
state, or failing that, the first in frozen state. But the structure
of the code makes
Some very nice tests there! To continue:
=== added file 'lib/lp/archivepublisher/tests/test_generate_extra_overrides.py'
+def file_contents(path):
+Return the contents of the file at path.
+with open(path) as handle:
+return handle.read()
Since you're only reading the file,
[I've not responded to your entire review point-by-point, but I believe
I've addressed all points where I haven't given an explicit response.]
On Wed, Dec 07, 2011 at 09:22:24AM -, Jeroen T. Vermeulen wrote:
+def runGerminate(self, override_file, series_name, arch, flavours,
+
Colin Watson has proposed merging lp:~cjwatson/meta-lp-deps/python-germinate
into lp:meta-lp-deps.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #899972 in Launchpad itself: cron.germinate is very slow
https://bugs.launchpad.net/launchpad/+bug/899972
Aaron Bentley has proposed merging lp:~abentley/launchpad/fix-reset-to-default
into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #892211 in Launchpad itself: reset to default in bug listing visibility
widget doesn't work
Curtis Hovey has proposed merging
lp:~sinzui/launchpad/nomminate-driver-permissions-1 into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #901332 in Launchpad itself: AttributeError: 'SourcePackage' object has
no attribute
The proposal to merge lp:~sinzui/launchpad/nomminate-driver-permissions-1 into
lp:launchpad has been updated.
Description changed to:
Allow driver permission checks on source packages.
Launchpad bug: https://bugs.launchpad.net/bugs/901332
Pre-implementation: No one
SourcePackage does
Martin Pool has proposed merging lp:~mbp/launchpad/featurefixture-from-request
into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~mbp/launchpad/featurefixture-from-request/+merge/84887
At the moment the test
William Grant has proposed merging lp:~wgrant/launchpad/drop-unused-views into
lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~wgrant/launchpad/drop-unused-views/+merge/84888
There are lots of unused views and
The proposal to merge lp:~wgrant/launchpad/drop-unused-views into lp:launchpad
has been updated.
Commit Message changed to:
Delete various unused views and templates.
For more details, see:
https://code.launchpad.net/~wgrant/launchpad/drop-unused-views/+merge/84888
--
Robert Collins has proposed merging lp:~lifeless/python-oops-tools/prune into
lp:python-oops-tools.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~lifeless/python-oops-tools/prune/+merge/84892
Pruning too many oopses at
The proposal to merge lp:~mbp/launchpad/show-timeline into lp:launchpad has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~mbp/launchpad/show-timeline/+merge/80166
--
https://code.launchpad.net/~mbp/launchpad/show-timeline/+merge/80166
Your
16 matches
Mail list logo
