[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/gSCFPS-optimise into lp:launchpad

2016-09-19 Thread William Grant
William Grant has proposed merging lp:~wgrant/launchpad/gSCFPS-optimise into lp:launchpad. Commit message: Optimise SpecificationSet.getStatusCountsForProductSeries, fixing Product:+series timeouts. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: http

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-push-remove-old-status into lp:launchpad

2016-09-19 Thread William Grant
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-push-remove-old-status/+merge/305927 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

Re: [Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/gSCFPS-optimise into lp:launchpad

2016-09-19 Thread Colin Watson
Review: Approve -- https://code.launchpad.net/~wgrant/launchpad/gSCFPS-optimise/+merge/306070 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/git-version-info into lp:launchpad

2016-09-19 Thread William Grant
Review: Approve code Diff comments: > > === renamed file 'scripts/update-bzr-version-info.sh' => > 'scripts/update-version-info.sh' > --- scripts/update-bzr-version-info.sh2009-10-16 01:54:41 + > +++ scripts/update-version-info.sh2016-09-14 11:56:46 + > @@ -1,35 +1,57 @@ >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/picker-truncate-large-results into lp:launchpad

2016-09-19 Thread William Grant
Review: Approve code wtf this was client-side all along? -- https://code.launchpad.net/~cjwatson/launchpad/picker-truncate-large-results/+merge/305528 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://la

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/gSCFPS-optimise into lp:launchpad

2016-09-19 Thread noreply
The proposal to merge lp:~wgrant/launchpad/gSCFPS-optimise into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~wgrant/launchpad/gSCFPS-optimise/+merge/306070 -- Your team Launchpad code reviewers is subscribed to branch lp:la

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/dsp-vocab-distinct-dspc-name into lp:launchpad

2016-09-19 Thread William Grant
Review: Approve code The unindexed sort already makes the plan as terrible as it can get. -- https://code.launchpad.net/~cjwatson/launchpad/dsp-vocab-distinct-dspc-name/+merge/305601 Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/picker-truncate-large-results into lp:launchpad

2016-09-19 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/picker-truncate-large-results into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/picker-truncate-large-results/+merge/305528 -- Your team Launchpad code reviewe

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/translation-import-queue-entry-dsp-vocab into lp:launchpad

2016-09-19 Thread William Grant
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/translation-import-queue-entry-dsp-vocab/+merge/305509 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-r

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/distribution-filebug-dsp-vocab into lp:launchpad

2016-09-19 Thread William Grant
Review: Approve code Diff comments: > > === modified file 'lib/lp/registry/vocabularies.py' > --- lib/lp/registry/vocabularies.py 2016-07-27 17:19:20 + > +++ lib/lp/registry/vocabularies.py 2016-09-07 22:41:38 + > @@ -2089,18 +2089,38 @@ > dsp = spn_or_dsp > e

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/productseries-ubuntupkg-dsp-vocab into lp:launchpad

2016-09-19 Thread William Grant
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/productseries-ubuntupkg-dsp-vocab/+merge/305367 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewer

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-push-remove-old-status into lp:launchpad

2016-09-19 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/snap-push-remove-old-status into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/snap-push-remove-old-status/+merge/305927 -- Your team Launchpad code reviewers i

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/dsp-vocab-distinct-dspc-name into lp:launchpad

2016-09-19 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/dsp-vocab-distinct-dspc-name into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/dsp-vocab-distinct-dspc-name/+merge/305601 -- Your team Launchpad code reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/potemplate-dsp-vocab into lp:launchpad

2016-09-19 Thread William Grant
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/potemplate-dsp-vocab/+merge/305490 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/smaller-publisher-oopses into lp:launchpad

2016-09-19 Thread William Grant
William Grant has proposed merging lp:~wgrant/launchpad/smaller-publisher-oopses into lp:launchpad. Commit message: Use a per-archive OOPS timeline in archivepublisher scripts. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/

Re: [Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/smaller-publisher-oopses into lp:launchpad

2016-09-19 Thread Colin Watson
Review: Approve Diff comments: > > === modified file 'lib/lp/archivepublisher/scripts/processdeathrow.py' > --- lib/lp/archivepublisher/scripts/processdeathrow.py2014-08-09 > 19:45:00 + > +++ lib/lp/archivepublisher/scripts/processdeathrow.py2016-09-19 > 10:57:46 + >

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/smaller-publisher-oopses into lp:launchpad

2016-09-19 Thread noreply
The proposal to merge lp:~wgrant/launchpad/smaller-publisher-oopses into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~wgrant/launchpad/smaller-publisher-oopses/+merge/306074 -- Your team Launchpad code reviewers is subscrib

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/product-index-git into lp:launchpad

2016-09-19 Thread William Grant
William Grant has proposed merging lp:~wgrant/launchpad/product-index-git into lp:launchpad. Commit message: Link to the default git repository on Product:+index. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1576494 in Launchpad itself: "Product:+index

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/unicode-sql-log into lp:launchpad

2016-09-19 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/unicode-sql-log into lp:launchpad. Commit message: Log SQL statements as Unicode to avoid confusing page rendering when the visible_render_time flag is on. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/unicode-sql-log into lp:launchpad

2016-09-19 Thread William Grant
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/unicode-sql-log/+merge/306089 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : la

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/unicode-sql-log into lp:launchpad

2016-09-19 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/unicode-sql-log into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/unicode-sql-log/+merge/306089 -- Your team Launchpad code reviewers is subscribed to branch l

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/distribution-filebug-dsp-vocab into lp:launchpad

2016-09-19 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/distribution-filebug-dsp-vocab into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/distribution-filebug-dsp-vocab/+merge/305150 -- Your team Launchpad code revie

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/productseries-ubuntupkg-dsp-vocab into lp:launchpad

2016-09-19 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/productseries-ubuntupkg-dsp-vocab into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/productseries-ubuntupkg-dsp-vocab/+merge/305367 -- Your team Launchpad code

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/librarian-fsync into lp:launchpad

2016-09-19 Thread William Grant
William Grant has proposed merging lp:~wgrant/launchpad/librarian-fsync into lp:launchpad. Commit message: Fix the librarian to fsync new files and their parent directories. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~wg

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-store-upload-selective into lp:launchpad

2016-09-19 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/snap-store-upload-selective into lp:launchpad. Commit message: Only upload *.snap files to the store, not e.g. manifests. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1625117 in Launchpad itself:

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/avoid-createPersonAndEmail into lp:launchpad

2016-09-19 Thread William Grant
William Grant has proposed merging lp:~wgrant/launchpad/avoid-createPersonAndEmail into lp:launchpad. Commit message: Avoid direct Person.createPersonAndEmail calls. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~wgrant/lau

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-store-upload-selective into lp:launchpad

2016-09-19 Thread William Grant
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-store-upload-selective/+merge/306100 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/librarian-fsync into lp:launchpad

2016-09-19 Thread noreply
The proposal to merge lp:~wgrant/launchpad/librarian-fsync into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~wgrant/launchpad/librarian-fsync/+merge/306099 -- Your team Launchpad code reviewers is subscribed to branch lp:la

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-store-upload-selective into lp:launchpad

2016-09-19 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/snap-store-upload-selective into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/snap-store-upload-selective/+merge/306100 -- Your team Launchpad code reviewers i

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/git-version-info into lp:launchpad

2016-09-19 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/git-version-info into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/git-version-info/+merge/305701 -- Your team Launchpad code reviewers is subscribed to branch

Re: [Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/librarian-fsync into lp:launchpad

2016-09-19 Thread Colin Watson
Review: Approve Diff comments: > === modified file 'lib/lp/services/librarianserver/storage.py' > --- lib/lp/services/librarianserver/storage.py2015-12-27 04:00:36 > + > +++ lib/lp/services/librarianserver/storage.py2016-09-19 13:43:37 > + > @@ -37,6 +37,34 @@ > ]

Re: [Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/product-index-git into lp:launchpad

2016-09-19 Thread Colin Watson
Review: Approve -- https://code.launchpad.net/~wgrant/launchpad/product-index-git/+merge/306086 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchp

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/potemplate-dsp-vocab into lp:launchpad

2016-09-19 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/potemplate-dsp-vocab into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/potemplate-dsp-vocab/+merge/305490 -- Your team Launchpad code reviewers is subscribed t

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/translation-import-queue-entry-dsp-vocab into lp:launchpad

2016-09-19 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/translation-import-queue-entry-dsp-vocab into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/translation-import-queue-entry-dsp-vocab/+merge/305509 -- Your team

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/product-index-git into lp:launchpad

2016-09-19 Thread noreply
The proposal to merge lp:~wgrant/launchpad/product-index-git into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~wgrant/launchpad/product-index-git/+merge/306086 -- Your team Launchpad code reviewers is subscribed to branch l

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/bug-1083709-again into lp:launchpad

2016-09-19 Thread William Grant
William Grant has proposed merging lp:~wgrant/launchpad/bug-1083709-again into lp:launchpad. Commit message: Let project drivers edit series and productreleases, as series drivers can. Project drivers should have series driver power over all series. Requested reviews: Launchpad code reviewers