Maximiliano Bertacchini has proposed merging
lp:~maxiberta/canonical-mojo-specs/fix-builddeps into
lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk.
Commit message:
Add missing turnip builddep.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/git-get-blob into lp:launchpad.
Commit message:
Implement GitRepository.getBlob.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/git
Sorry about that. Already uncommited and re-commited my change into r18008. But
I'm afraid this MP is now marked as 'Merged'. Any suggestion? Thanks!
--
https://code.launchpad.net/~maxiberta/launchpad/git-get-blob/+merge/293337
Your team Launchpad code reviewers is subscribed to branch lp:launchp
Addressed all comments. GitHostingClient now uses `requests.Request`'s `params`
to automatically quote query parameters; and select path components are now
escaped with `urllib.quote()`. Added unit test accordingly.
--
https://code.launchpad.net/~maxiberta/launchpad/git-get-blob/+merge/293337
Yo
Just a quick reply to the previous comment.
Diff comments:
>
> === modified file 'lib/lp/code/model/githosting.py'
> --- lib/lp/code/model/githosting.py 2016-04-19 17:18:39 +
> +++ lib/lp/code/model/githosting.py 2016-04-29 22:08:19 +
> @@ -114,10 +115,9 @@
> logger.
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/git-get-blob-unexport-api into lp:launchpad.
Commit message:
Unexport GitRepository.getBlob(); return a binary blob instead of dict.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see
Review: Approve
LGTM. A quick `ag Pocket.RELEASE lib/lp/snappy/` shows no matches.
--
https://code.launchpad.net/~cjwatson/launchpad/snap-build-default-updates/+merge/294007
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~cjwatson/launchpad/snap-build-default-
Diff comments:
>
> === modified file 'lib/lp/snappy/model/snap.py'
> --- lib/lp/snappy/model/snap.py 2016-05-06 12:46:46 +
> +++ lib/lp/snappy/model/snap.py 2016-05-11 16:40:19 +
> @@ -326,6 +329,36 @@
> result.order_by(order_by)
> return result
>
> +
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/snap-update-build-status-ui into lp:launchpad.
Commit message:
Update latest snap builds table via AJAX.
Requested reviews:
Colin Watson (cjwatson)
Launchpad code reviewers (launchpad-reviewers)
For more details, see
The proposal to merge lp:~maxiberta/launchpad/snap-update-build-status-ui into
lp:launchpad has been updated.
Description changed to:
Update latest snap builds table via AJAX.
See https://pastebin.canonical.com/156265/ for example of API usage.
For more details, see:
https://code.launchpad.net
Should mark
https://code.launchpad.net/~cjwatson/launchpad/snap-store-add-edit-views/+merge/294524
as prerequisite? Will probably conflict (just a little); but I thought maybe
this change is small enough to be merged directly to devel first.
--
https://code.launchpad.net/~maxiberta/launchpad/s
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/snap-name-extraction into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/snap-name-extraction/+merge/294964
Extract
The proposal to merge lp:~maxiberta/launchpad/snap-name-extraction into
lp:launchpad has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/snap-name-extraction/+merge/294964
--
Your team Launchpad code reviewers is
The proposal to merge lp:~maxiberta/launchpad/snap-name-extraction into
lp:launchpad has been updated.
Status: Work in progress => Superseded
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/snap-name-extraction/+merge/294964
--
Your team Launchpad code reviewers is su
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/snap-name-extraction into lp:launchpad with
lp:~cjwatson/launchpad/snap-store-add-edit-views as a prerequisite.
Commit message:
Extract Snap.store_name from snapcraft.yaml (Git only).
Requested reviews:
Colin Watson
Replied to inline comment. Thanks
Diff comments:
> === modified file 'lib/lp/snappy/browser/snap.py'
> --- lib/lp/snappy/browser/snap.py 2016-05-18 18:02:43 +
> +++ lib/lp/snappy/browser/snap.py 2016-05-18 18:02:43 +
> @@ -357,12 +360,28 @@
>
> @property
> def initial_
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/garbo-snapbuildjob-pruner into lp:launchpad.
Commit message:
New garbo job for pruning old SnapBuildJobs.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/snap-refresh-macaroon into lp:launchpad.
Commit message:
Refresh discharge macaroon (if needed) on snap upload.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Diff comments:
> === modified file 'lib/lp/snappy/browser/snap.py'
> --- lib/lp/snappy/browser/snap.py 2016-05-23 19:44:07 +
> +++ lib/lp/snappy/browser/snap.py 2016-05-23 19:44:08 +
> @@ -357,12 +360,32 @@
>
> @property
> def initial_values(self):
> +store_na
Review: Approve
LGTM.
--
https://code.launchpad.net/~cjwatson/launchpad/snap-upload-content-type/+merge/295983
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~cjwatson/launchpad/snap-upload-content-type into lp:launchpad.
_
All comments addressed. Thanks.
--
https://code.launchpad.net/~maxiberta/launchpad/snap-refresh-macaroon/+merge/295881
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
> There's a merge conflict with devel in
> lib/lp/snappy/tests/test_snapstoreclient.py, presumably due to the Content-
> Type fix. Could you merge and resolve?
Done.
--
https://code.launchpad.net/~maxiberta/launchpad/snap-refresh-macaroon/+merge/295881
Your team Launchpad code reviewers is subsc
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/snappy-sampledata into lp:launchpad.
Commit message:
Add SnappySeries and SnappyDistroSeries sample data for development.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
The proposal to merge lp:~maxiberta/launchpad/snappy-sampledata into
lp:launchpad has been updated.
Description changed to:
Enable snappy unconditionally; add snappy sample data for development.
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/snappy-sampledata/+merge/2985
The proposal to merge lp:~maxiberta/launchpad/snappy-sampledata into
lp:launchpad has been updated.
Commit Message changed to:
Enable snappy unconditionally; add snappy sample data for development.
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/snappy-sampledata/+merge/2
* Dropped the snap.allow_new feature flag and fixed lp.snappy tests accordingly.
* Synced snappyseries names with production.
* Updated snappydistroseries rows to not be full cross product.
* Applied changes to current.sql.
Thanks!
--
https://code.launchpad.net/~maxiberta/launchpad/snappy-sampled
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/new-snap-select-processors into lp:launchpad.
Commit message:
Add processor selection in new Snap form.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Updated with some extra code cleanup based on code review feedback.
--
https://code.launchpad.net/~maxiberta/launchpad/snappy-sampledata/+merge/298562
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://lau
* Check all available processors by default.
* Dropped `SnapSet.availableProcessors()` for populating the processors widget,
in favor of `getUtility(IProcessorSet).getAll()` to keep the same logic as
`SnapSet.new()`.
* Indent processor checkboxes to keep them aligned with the series selector.
* F
* Also, moved the processors selector up, between series and upload to store.
--
https://code.launchpad.net/~maxiberta/launchpad/new-snap-select-processors/+merge/298242
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailin
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/fix-git-merge-editstatus into lp:launchpad.
Commit message:
Fix +edit-status for Git merge proposals.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1538355 in Launchpad itself: "
Updated CSS to be a little less specific. Thanks!
--
https://code.launchpad.net/~maxiberta/launchpad/new-snap-select-processors/+merge/298242
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.ne
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/named-auth-tokens into lp:launchpad.
Commit message:
Add new named ArchiveAuthToken API.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~maxiberta
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/db-named-auth-tokens into lp:launchpad/db-devel.
Commit message:
Add ArchiveAuthToken.name; make ArchiveAuthToken.person nullable.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers): db
For more details, see
The proposal to merge lp:~maxiberta/launchpad/named-auth-tokens into
lp:launchpad has been updated.
Description changed to:
Add new named ArchiveAuthToken API. This is required for UA customer delivery
of kernel livepatches. See required DB changes in
https://code.launchpad.net/~maxiberta/laun
The proposal to merge lp:~maxiberta/launchpad/named-auth-tokens into
lp:launchpad has been updated.
Description changed to:
Add new named ArchiveAuthToken API. This is required for UA customer delivery
of kernel livepatches. See required DB changes in
https://code.launchpad.net/~maxiberta/laun
Will fix asap. Thanks!
Diff comments:
>
> === modified file 'lib/lp/soyuz/model/archive.py'
> --- lib/lp/soyuz/model/archive.py 2016-03-14 23:42:45 +
> +++ lib/lp/soyuz/model/archive.py 2016-07-07 14:30:49 +
> @@ -1948,6 +1950,53 @@
> IStore(ArchiveAuthToken).add(archive
Diff comments:
> === modified file 'lib/lp/soyuz/interfaces/archive.py'
> --- lib/lp/soyuz/interfaces/archive.py2016-01-26 15:47:37 +
> +++ lib/lp/soyuz/interfaces/archive.py2016-07-07 14:30:49 +
> @@ -2074,6 +2087,57 @@
> :param dependency: is an `IArchive` obje
Fixed the new ArchiveAuthToken index based on analysis of query execution plan.
Thanks!
--
https://code.launchpad.net/~maxiberta/launchpad/db-named-auth-tokens/+merge/299433
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~maxiberta/launchpad/db-named-auth-toke
Updated with feature flag + fixes and improvements.
--
https://code.launchpad.net/~maxiberta/launchpad/named-auth-tokens/+merge/299432
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~laun
Added unique constraint on ArchiveAuthToken(archive,name).
--
https://code.launchpad.net/~maxiberta/launchpad/db-named-auth-tokens/+merge/299433
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~maxiberta/launchpad/db-named-auth-tokens into lp:launchpad/db-devel.
Review: Approve
Looks good to me! Thanks
--
https://code.launchpad.net/~cjwatson/launchpad/reduce-mp-timeouts/+merge/298967
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~cjwatson/launchpad/reduce-mp-timeouts into lp:launchpad.
__
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/named-auth-tokens-htaccess into lp:launchpad with
lp:~maxiberta/launchpad/named-auth-tokens as a prerequisite.
Commit message:
Add support for named auth tokens in ppa htpasswd creation.
Requested reviews:
Maximiliano
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/named-auth-tokens-bulk-api into lp:launchpad with
lp:~maxiberta/launchpad/named-auth-tokens-htaccess as a prerequisite.
Commit message:
Add API for bulk creation and revocation of named auth tokens.
Requested reviews
Diff comments:
>
> === modified file 'lib/lp/soyuz/model/archive.py'
> --- lib/lp/soyuz/model/archive.py 2016-07-14 00:25:14 +
> +++ lib/lp/soyuz/model/archive.py 2016-07-14 00:25:14 +
> @@ -1985,20 +1986,57 @@
> else:
> return archive_auth_token
>
> -
Diff comments:
>
> === modified file 'lib/lp/archivepublisher/scripts/generate_ppa_htaccess.py'
> --- lib/lp/archivepublisher/scripts/generate_ppa_htaccess.py 2014-10-29
> 06:04:09 +
> +++ lib/lp/archivepublisher/scripts/generate_ppa_htaccess.py 2016-07-13
> 20:42:37 +
> @@ -274,6 +
Review: Approve
Looks good, thanks.
--
https://code.launchpad.net/~cjwatson/launchpad/fix-snap-job-refresh-perms/+merge/300077
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~cjwatson/launchpad/fix-snap-job-refresh-perms into lp:launchpad.
___
Review: Approve
+1!
--
https://code.launchpad.net/~cjwatson/launchpad/fix-snap-store-upload-status/+merge/300091
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~cjwatson/launchpad/fix-snap-store-upload-status into lp:launchpad.
___
Updated branch with fixes and improvements based on code review.
--
https://code.launchpad.net/~maxiberta/launchpad/named-auth-tokens-bulk-api/+merge/300016
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https
Updated branch with fixes and improvements based on code review.
--
https://code.launchpad.net/~maxiberta/launchpad/named-auth-tokens-htaccess/+merge/32
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https
Also, added an optional `names` parameter to `Archive.getNamedAuthTokens()` to
keep uniformity with `Archive.newNamedAuthTokens()` and
`Archive.revokeNamedAuthTokens()`.
--
https://code.launchpad.net/~maxiberta/launchpad/named-auth-tokens-bulk-api/+merge/300016
Your team Launchpad code reviewers
Review: Approve
Looks good to me.
--
https://code.launchpad.net/~cjwatson/launchpad/fix-snap-job-mailer-perms/+merge/300103
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~cjwatson/launchpad/fix-snap-job-mailer-perms into lp:launchpad.
___
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/named-auth-tokens-fix-apidoc into lp:launchpad.
Commit message:
Fix wrong apidoc format.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~maxiberta
Review: Approve
+1! The usage of testscenarios makes tests much cleaner. Thanks.
--
https://code.launchpad.net/~cjwatson/launchpad/restore-new-snap-links/+merge/300326
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~cjwatson/launchpad/restore-new-snap-links in
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/snap-pocket-help into lp:launchpad.
Commit message:
Make pocket selection for snap builds less unclear.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Granted, the default help link icon placement is somewhat awkward. It could be
improved I guess? (in a different branch).
--
https://code.launchpad.net/~maxiberta/launchpad/snap-pocket-help/+merge/300626
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~maxibert
Updated with improved wording.
Diff comments:
> === modified file 'lib/lp/snappy/browser/snap.py'
> --- lib/lp/snappy/browser/snap.py 2016-07-16 07:46:23 +
> +++ lib/lp/snappy/browser/snap.py 2016-07-20 15:26:47 +
> @@ -242,11 +242,17 @@
> Choice(vocabulary='SnapDistr
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/snap-pocket-fix-tests into lp:launchpad.
Commit message:
Fix broken Snap test.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/snap
Removed ugly string concatenation in snap pocket unit test.
--
https://code.launchpad.net/~maxiberta/launchpad/snap-pocket-fix-tests/+merge/300895
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~maxiberta/launchpad/snap-pocket-fix-tests into lp:launchpad.
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/snap-pocket-help-icon-placement into lp:launchpad.
Commit message:
Improve placement of Snap build pocket help icon.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Review: Approve
Looks good!
--
https://code.launchpad.net/~cjwatson/launchpad/github-bugtracker-uppercase-in-names/+merge/301053
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~cjwatson/launchpad/github-bugtracker-uppercase-in-names into lp:launchpad.
___
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/bug-feed-fix-private-team into lp:launchpad.
Commit message:
Prevent rendering of private team names in bugs feed.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1592186 in Launchpad
Review: Approve
Looks good to me. Thanks
--
https://code.launchpad.net/~cjwatson/launchpad/limit-faq-editing/+merge/303658
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~cjwatson/launchpad/limit-faq-editing into lp:launchpad.
Looks good. One question inline.
Diff comments:
>
> === modified file 'lib/lp/archiveuploader/tests/test_snapupload.py'
> --- lib/lp/archiveuploader/tests/test_snapupload.py 2016-06-28 21:10:18
> +
> +++ lib/lp/archiveuploader/tests/test_snapupload.py 2016-08-30 12:36:14
> +
> @@ -
Review: Approve
Looks good to me.
--
https://code.launchpad.net/~cjwatson/launchpad/snap-delete-with-builds/+merge/308767
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~cjwatson/launchpad/snap-delete-with-builds into lp:launchpad.
___
Maximiliano Bertacchini has proposed merging lp:~maxiberta/launchpad/lp-1729580
into lp:launchpad.
Commit message:
Expose extended error messages (with external link) for snap build jobs (LP:
#1729580).
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see
Diff comments:
> === modified file 'lib/lp/snappy/browser/tests/test_snapbuild.py'
> --- lib/lp/snappy/browser/tests/test_snapbuild.py 2017-10-20 13:35:42
> +
> +++ lib/lp/snappy/browser/tests/test_snapbuild.py 2018-02-16 21:53:15
> +
> @@ -130,6 +130,38 @@
> t
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/lp-1729580-2 into lp:launchpad.
Commit message:
Use target="_blank" in extended snap build error links.
Requested reviews:
Colin Watson (cjwatson)
For more details, see:
https://code.launchpad.net/~maxiberta/la
Review: Approve
Looks good to me. One question though: why move those @properties from
`PackageTranslationsUploadJob` to its parent class
`PackageTranslationsUploadJobDerived`?
--
https://code.launchpad.net/~cjwatson/launchpad/ptuj-repr/+merge/338559
Your team Launchpad code reviewers is reques
Makes sense, thanks.
--
https://code.launchpad.net/~cjwatson/launchpad/ptuj-repr/+merge/338559
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~cjwatson/launchpad/ptuj-repr into lp:launchpad.
___
Mailing list: https:/
Review: Approve
Wow, a 10 year old issue! Thanks!
--
https://code.launchpad.net/~cjwatson/launchpad/reject-bad-ssh-keys/+merge/339445
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~cjwatson/launchpad/reject-bad-ssh-keys into lp:launchpad.
___
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/rename-googlesearch-as-sitesearch into lp:launchpad.
Commit message:
Rename lp.services.googlesearch as lp.services.sitesearch.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/bing-search into lp:launchpad.
Commit message:
Add basic Bing Custom Search support.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad
The proposal to merge lp:~maxiberta/launchpad/bing-search into lp:launchpad has
been updated.
Description changed to:
Add basic Bing Custom Search support.
Should be pretty unobtrusive, while adding a basic implementation around Bing
Custom Search. Might need some more testing; and could use s
The proposal to merge lp:~maxiberta/launchpad/bing-search into lp:launchpad has
been updated.
Description changed to:
Add basic Bing Custom Search support.
Should be pretty unobtrusive, while adding a basic site search implementation
around Bing Custom Search (shamelessly copied from the Googl
The proposal to merge lp:~maxiberta/launchpad/bing-search into lp:launchpad has
been updated.
Commit Message changed to:
Add basic Bing Custom Search site search support.
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/bing-search/+merge/341549
--
Your team Launchpad cod
The proposal to merge lp:~maxiberta/launchpad/bing-search into lp:launchpad has
been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/bing-search/+merge/341549
--
Your team Launchpad code reviewers is subscribed to bran
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/googlesearchservice-improvements into lp:launchpad.
Commit message:
A few improvements on GoogleSearchService.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/rename-google-as-sitesearch-extra into lp:launchpad.
Commit message:
A few extra renamed classes from Google* to SiteSearch*.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/deduplicate-process_exists into lp:launchpad.
Commit message:
Deduplicate code into lp.services.osutils.process_exists().
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https
Replied each comment inline. Most issues are now fixed. Still missing:
- Add feature flag to switch search engine.
- Code deduplication.
- Turn doctests into proper unit tests.
- Run tests on search page with both Google and Bing.
Diff comments:
>
> === modified file 'configs/development/launchp
Also, see a number of preparatory branches:
https://code.launchpad.net/~maxiberta/launchpad/googlesearchservice-improvements/+merge/342146
https://code.launchpad.net/~maxiberta/launchpad/rename-google-as-sitesearch-extra/+merge/342148
https://code.launchpad.net/~maxiberta/launchpad/dedupl
Updated branch:
- Register ISearchService implementations with name="google" and name="bing"
(defaults to "google" for now; will add a feature flag next).
- Add extra doctests (sorry, copied from google implementation as we are in a
rush; will migrate to proper unit tests later).
--
https://code
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/generalized-sitesearch-testservice into lp:launchpad.
Commit message:
Generalize googletestservice.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
I believe most issues from feedback are fixed now. Still pending: turn related
doctests into unittests (and deduplicate lots of doctests, btw), which I'll
work on in a following branch to unlock and hopefully land/deploy this branch
ASAP.
Note this branch depends on
https://code.launchpad.net/
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/bing-search into lp:launchpad.
Commit message:
Add basic Bing Custom Search site search support.
Requested reviews:
Colin Watson (cjwatson)
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/bing-search
The proposal to merge lp:~maxiberta/launchpad/bing-search into lp:launchpad has
been updated.
Description changed to:
Add basic Bing Custom Search support.
Should be pretty unobtrusive, while adding a basic site search implementation
around Bing Custom Search (shamelessly copied from the Googl
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/sitesearch-default-bing into lp:launchpad.
Commit message:
Make Bing the default site search engine.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/sitesearch-cleanup into lp:launchpad.
Commit message:
Sitesearch code cleanup.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad
The proposal to merge lp:~maxiberta/launchpad/sitesearch-cleanup into
lp:launchpad has been updated.
Description changed to:
Sitesearch code cleanup:
- Add unittests based on sitesearch doctests.
- These doctests are still tested; unsure of removing as they're still useful
documentation.
- A
The proposal to merge lp:~maxiberta/launchpad/sitesearch-cleanup into
lp:launchpad has been updated.
Description changed to:
Sitesearch code cleanup:
- Add unittests based on sitesearch doctests.
- These doctests are still tested; unsure of removing as they're still useful
documentation.
- A
The proposal to merge lp:~maxiberta/launchpad/sitesearch-cleanup into
lp:launchpad has been updated.
Description changed to:
Sitesearch code cleanup:
- Add unittests based on sitesearch doctests.
- These doctests are still tested; unsure of removing as they're still useful
documentation.
- A
Review: Approve
LGTM. An extra test in sitesearch/tests/test_bing.py would be great though.
--
https://code.launchpad.net/~cjwatson/launchpad/bing-xss/+merge/342950
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~cjwatson/launchpad/bing-xss into lp:launchpad.
Thanks!
--
https://code.launchpad.net/~cjwatson/launchpad/bing-xss/+merge/342950
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~cjwatson/launchpad/bing-xss into lp:launchpad.
___
Mailing list: https://launchpad.net/
The proposal to merge lp:~maxiberta/launchpad/sitesearch-cleanup into
lp:launchpad has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/sitesearch-cleanup/+merge/342472
--
Your team Launchpad code reviewers is requ
Review: Resubmit
I'm splitting this into more manageable MP's. The first one:
https://code.launchpad.net/~maxiberta/launchpad/sitesearch-cleanup-1/+merge/343131.
--
https://code.launchpad.net/~maxiberta/launchpad/sitesearch-cleanup/+merge/342472
Your team Launchpad code reviewers is requested to
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/sitesearch-cleanup-1 into lp:launchpad.
Commit message:
Assorted sitesearch fixes and improvements.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net
The proposal to merge lp:~maxiberta/launchpad/sitesearch-cleanup-2 into
lp:launchpad has been updated.
Status: Work in progress => Superseded
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/sitesearch-cleanup-2/+merge/343235
--
Your team Launchpad code reviewers is re
Maximiliano Bertacchini has proposed merging
lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad with
lp:~maxiberta/launchpad/sitesearch-cleanup-1 as a prerequisite.
Commit message:
Assorted sitesearch fixes and improvements (part 2).
Requested reviews:
Launchpad code reviewers
The proposal to merge lp:~maxiberta/launchpad/sitesearch-cleanup-2 into
lp:launchpad has been updated.
Commit message changed to:
Add sitesearch tests based on doctests.
For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/sitesearch-cleanup-2/+merge/343236
--
Your team Launc
1 - 100 of 129 matches
Mail list logo
