Re: [Lcms-user] Beta for lcms-1.18 available on site

2009-03-13 Thread Marti.Maria
Bob, in the INSTALL file there is a paragraph on that: " There is a utility on root called 'filter.c' If your compiler doesn't support C++-style comments, apply this filter to all source & headers. Probably you would need to make your own compilation script too. I will love! to know any exoti

Re: [Lcms-user] Beta for lcms-1.18 available on site

2009-03-13 Thread Marti.Maria
Fixed, thank you. Marti. Kai-Uwe Behrmann wrote: > It seems that cmsAllocMatShaper() in cmsmatsh.c:180 blindly accesses a > NULL pointer for false gamma type tags. An example is attached. A fix > might be as simple as checking in cmsBuildOutputMatrixShaper()? > > > best regards > Kai-Uwe Behrma

Re: [Lcms-user] Beta for lcms-1.18 available on site

2009-03-13 Thread Marti.Maria
Oh, I see. This comes from one guy trying to fix "vulnerabilities". I have spent many time on those "hotfixes", many of them breaking functionality like that one you have discovered.. Many thanks for let me know, Regards Marti. Kai-Uwe Behrmann wrote: > In cmsio1.c:292 lcms checks for size co

Re: [Lcms-user] Beta for lcms-1.18 available on site

2009-03-13 Thread Marti.Maria
Both are fixed now, thanks Ignacio! Marti Ignacio Ruiz-de-Conejo wrote: > Marti: > > Just for for tracking purposes, in lcms.h > #define LCMS_VERSION117// <--should be updated > > Ignacio > > > Ignacio Ruiz-de-Conejo wrote: > >> Marti: >> >> Good to hear about the release

Re: [Lcms-user] Beta for lcms-1.18 available on site

2009-03-10 Thread Ignacio Ruiz-de-Conejo
Marti: Just for for tracking purposes, in lcms.h #define LCMS_VERSION117// <--should be updated Ignacio Ignacio Ruiz-de-Conejo wrote: > Marti: > > Good to hear about the release of lcms 1.18. Thanks a lot for the Beta! > > I think, though, that it would be nice to have a c

Re: [Lcms-user] Beta for lcms-1.18 available on site

2009-03-10 Thread Dirck Blaskey
Daniel Bünzli wrote: > > Le 10 mars 09 à 20:51, Dirck Blaskey a écrit : >> * Not to be pedantic, but // comments are not C and don't compile on >> some platforms (unfortunately). > Depends on which C you are talking about, one line comments are > allowed by C99. > One line comments are accepted by

Re: [Lcms-user] Beta for lcms-1.18 available on site

2009-03-10 Thread Dirck Blaskey
Graeme Gill wrote: > Dirck Blaskey wrote: > >> * use of strcat, strcpy, sprintf are all problematic - fortunately most >> of this is in code that I'm not using. >> > > Contrary to what some people would have you believe, > strcat, strcpy, sprintf are not inherently unsafe > in all usage, a

Re: [Lcms-user] Beta for lcms-1.18 available on site

2009-03-10 Thread Ignacio Ruiz-de-Conejo
Marti: Good to hear about the release of lcms 1.18. Thanks a lot for the Beta! I think, though, that it would be nice to have a couple of small glitches fixed in the code before it gets released: 1) in tifficc.c, in the PackTIFFLab8 () function, the command (line 949) wOut[2] = (wOut[2]

Re: [Lcms-user] Beta for lcms-1.18 available on site

2009-03-10 Thread Graeme Gill
Dirck Blaskey wrote: > * use of strcat, strcpy, sprintf are all problematic - fortunately most > of this is in code that I'm not using. Contrary to what some people would have you believe, strcat, strcpy, sprintf are not inherently unsafe in all usage, anymore than the "n" versions are inherentl

Re: [Lcms-user] Beta for lcms-1.18 available on site

2009-03-10 Thread Bob Friesenhahn
On Wed, 11 Mar 2009, Daniel Bünzli wrote: Depends on which C you are talking about, one line comments are allowed by C99. I perform test builds on some old systems which don't have new C compilers and reject C++ style comments. Bob -- Bob Friesenhahn bfrie...@simple.dallas.tx.us, http://www

Re: [Lcms-user] Beta for lcms-1.18 available on site

2009-03-10 Thread Daniel Bünzli
Le 10 mars 09 à 20:51, Dirck Blaskey a écrit : > * Not to be pedantic, but // comments are not C and don't compile on > some platforms (unfortunately). Depends on which C you are talking about, one line comments are allowed by C99. Best, Daniel -

Re: [Lcms-user] Beta for lcms-1.18 available on site

2009-03-10 Thread Dirck Blaskey
There are a few minor issues with the lcms sources that I'd like to point out for the betas: * Not to be pedantic, but // comments are not C and don't compile on some platforms (unfortunately). * 1.18 cmsio1.c has unchecked reads, some of which can cause problems with defective inputs; one is

Re: [Lcms-user] Beta for lcms-1.18 available on site

2009-03-10 Thread Kai-Uwe Behrmann
In cmsio1.c:292 lcms checks for size correctness. Nethertheless one of the lcms provided profiles, I do not know if it is a actual one, misses this criteria for 1 byte and fails. The file size is one number higher than the header claims. The reason why not even SampleICC is so narrow might be,

Re: [Lcms-user] Beta for lcms-1.18 available on site

2009-03-09 Thread Kai-Uwe Behrmann
It seems that cmsAllocMatShaper() in cmsmatsh.c:180 blindly accesses a NULL pointer for false gamma type tags. An example is attached. A fix might be as simple as checking in cmsBuildOutputMatrixShaper()? best regards Kai-Uwe Behrmann -- developing for colour management www.behrmann.name + ww

[Lcms-user] Beta for lcms-1.18 available on site

2009-03-09 Thread marti . maria
Hi, I've uploaded a beta of lcms-1.18 at http://www.littlecms.com/downloads.htm This is a maintenance release, which fixes some known bugs and has no new functionality. I would appreciate if you can check all is ok. Final 1.18 release will be in a couple of weeks. Best regards Marti Maria The