[LEDE-DEV] WPQ864 PCIe card on PCIe3 does not work when there is no PCIe card on PCIe1
I have a WPQ864 board, which is based on AP148. When I enable the PCIe3, some thing strange happened. PCIe card on PCIe3(0x1b90) does not work when there is no PCIe card on PCIe1(0x1b50). But QSDK works good. DTS file I make: https://raw.githubusercontent.com/tinnnysu/source/add-support-for-wpq864/target/linux/ipq806x/files-4.9/arch/arm/boot/dts/qcom-ipq8064-wpq864-1g.dts When PCIe card on PCIe1 and PCIe3, dmesg output: [0.149782] 1b50.pci supply vdda not found, using dummy regulator [0.149884] 1b50.pci supply vdda_phy not found, using dummy regulator [0.149980] 1b50.pci supply vdda_refclk not found, using dummy regulator [0.150623] OF: PCI: host bridge /soc/pci@1b50 ranges: [0.150662] OF: PCI:IO 0x0fe0..0x0fef -> 0x0fe0 [0.150687] OF: PCI: MEM 0x0800..0x0fdf -> 0x0800 [0.260563] qcom-pcie 1b50.pci: link up [0.262633] qcom-pcie 1b50.pci: PCI host bridge to bus :00 [0.262655] pci_bus :00: root bus resource [bus 00-ff] [0.262674] pci_bus :00: root bus resource [io 0x-0xf] (bus address [0xfe0-0xfef]) [0.262688] pci_bus :00: root bus resource [mem 0x0800-0x0fdf] [0.263217] PCI: bus0: Fast back to back transfers disabled [0.265467] PCI: bus1: Fast back to back transfers disabled [0.265807] pci :00:00.0: BAR 8: assigned [mem 0x0800-0x081f] [0.265831] pci :01:00.0: BAR 0: assigned [mem 0x0800-0x081f 64bit] [0.265965] pci :00:00.0: PCI bridge to [bus 01] [0.265989] pci :00:00.0: bridge window [mem 0x0800-0x081f] [0.266741] 1b70.pci supply vdda not found, using dummy regulator [0.266845] 1b70.pci supply vdda_phy not found, using dummy regulator [0.266933] 1b70.pci supply vdda_refclk not found, using dummy regulator [0.267541] OF: PCI: host bridge /soc/pci@1b70 ranges: [0.267580] OF: PCI:IO 0x31e0..0x31ef -> 0x31e0 [0.267600] OF: PCI: MEM 0x2e00..0x31df -> 0x2e00 [1.299852] qcom-pcie 1b70.pci: phy link never came up [1.302148] [ cut here ] [1.302171] WARNING: CPU: 0 PID: 1 at drivers/clk/qcom/clk-branch.c:97 clk_branch_toggle+0x118/0x140 [1.302182] pcie1_phy_clk status stuck at 'on' [1.302190] Modules linked in: [1.302212] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.9.20 #0 [1.30] Hardware name: Generic DT based system [1.302270] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [1.302294] [] (show_stack) from [] (dump_stack+0x7c/0x9c) [1.302320] [] (dump_stack) from [] (__warn+0xbc/0xec) [1.302343] [] (__warn) from [] (warn_slowpath_fmt+0x34/0x44) [1.302364] [] (warn_slowpath_fmt) from [] (clk_branch_toggle+0x118/0x140) [1.302387] [] (clk_branch_toggle) from [] (clk_core_disable+0x6c/0x7c) [1.302409] [] (clk_core_disable) from [] (clk_core_disable_lock+0x18/0x24) [1.302439] [] (clk_core_disable_lock) from [] (qcom_pcie_deinit_v0+0x6c/0xb8) [1.302460] [] (qcom_pcie_deinit_v0) from [] (dw_pcie_host_init+0x3a0/0x4b4) [1.302482] [] (dw_pcie_host_init) from [] (qcom_pcie_probe+0x178/0x1d0) [1.302511] [] (qcom_pcie_probe) from [] (platform_drv_probe+0x38/0x6c) [1.302535] [] (platform_drv_probe) from [] (driver_probe_device+0x10c/0x254) [1.302553] [] (driver_probe_device) from [] (__driver_attach+0x80/0xa4) [1.302572] [] (__driver_attach) from [] (bus_for_each_dev+0x68/0x8c) [1.302593] [] (bus_for_each_dev) from [] (bus_add_driver+0xc8/0x1e4) [1.302612] [] (bus_add_driver) from [] (driver_register+0x9c/0xe0) [1.302632] [] (driver_register) from [] (do_one_initcall+0xb8/0x174) [1.302661] [] (do_one_initcall) from [] (kernel_init_freeable+0x120/0x1e8) [1.302692] [] (kernel_init_freeable) from [] (kernel_init+0xc/0xf4) [1.302718] [] (kernel_init) from [] (ret_from_fork+0x14/0x3c) [1.302737] ---[ end trace 23593370cb814e5a ]--- [1.302991] qcom-pcie 1b70.pci: PCI host bridge to bus 0001:00 [1.303010] pci_bus 0001:00: root bus resource [bus 00-ff] [1.303025] pci_bus 0001:00: root bus resource [mem 0x2e00-0x31df] [1.303090] PCI: bus0: Fast back to back transfers enabled [1.303394] ipq8064-pinctrl 80.pinmux: invalid group "gpio16" for function "pcie3_rst" [1.303594] 1b90.pci supply vdda not found, using dummy regulator [1.303693] 1b90.pci supply vdda_phy not found, using dummy regulator [1.303780] 1b90.pci supply vdda_refclk not found, using dummy regulator [1.304422] OF: PCI: host bridge /soc/pci@1b90 ranges: [1.304459] OF: PCI:IO 0x35e0..0x35ef -> 0x35e0 [1.304482] OF: PCI: MEM 0x3200..0x35df -> 0x3200 [1.414379] qcom-pcie 1b90.pci: link up [1.416332] qcom-pcie 1b90.pci: PCI host bridge to bus 0002:00 [1.416351] pci_bus 0002:00: root bus resource [bus 00-ff] [1.416365]
Re: [LEDE-DEV] [OpenWrt-Devel] openwrt and lede - remerge proposal
On 05/08/2017 06:19 AM, John Crispin wrote: > Hi, > > Felix, Imre and myself had 2 calls last week lasting several hours and > discussed the following proposal of conditions for a remerge that we > would like to propose and have people vote on. > > *) branding > - the owrt side sees no option of using the lede brand > > - a (minor) majority voted for openwrt as a name over lede whilst most > people said they did not care > > - as the last vote had a 100% ACK for a remerge using the owrt brand is > the only feasible option > > *) domain > - transfer owner ship to SPI for openwrt.org and lede-project.org > - add them to the pool of urls at digital ocean > - post remerge build a setup where we have several DNS servers in > various locations > - point git.openwrt.org at the lede git server > - point bugs.openwrt.org to the lede flyspray instance > - keep both wikis and forums as is (we should decide post remerge how to > proceed to avoid these issues blocking the progress) > - update the lede domain entries for build/download/rsync/... servers so > that the openwrt domain also points at them > > *) SPI > - TBD post remerge > > *) github > - stop pushing to lede-project organisation > - start pushing to the openwrt organisation > - cleanup the list of owners in the openwrt organisation > - obsolete all issues on the openwrt organisation and close the issue > tracker > - go through the open openwrt and lede PRs, pickup whats useful and > close the rest, asking people to repost (things wont be rebasable anyhow) > - close the lede PR tracker > - keep the lede organisation in its current state so that forked trees > dont get obsoleted > > - obsolete the lede github org after a grace period of 3-6 months > > *) landing page > - update the lede landing page to represent the openwrt name > - update the landing page to have the same look & feel as the current > openwrt landing page > - point openwrt.org at the lede landing page > > *) trac > - trac is already readonly, keep content so that search engines can > still find the it > - edit the trac html templates, adding a note pointing at the > bug.openwrt.org instance > > *) email accounts > - currently there are around ~20 active openwrt.org mail accounts > - turn all the webmaster@, hostmaster@, ... accounts into aliases that > anyone with voting rights can be subscribed to > - ask those people that are no longer active to voluntarily give up > their accounts > - mail addresses may under no conditions be used for any personal > business, consultancy, applying for jobs, ... purposes > > - any mail sent from an openwrt.org account needs to adhere the > trademark policy and should only be used for FOSS purposes > > > *) wiki / forum > - TBD > - asking in either forum/wiki will get a biased vote so keep them both > around > - start a separate discussion regarding these post remerge > > *) LF > - find out what doubts folks have about LF > - find out benefits - we would have their hosting and sponsorship ?! > - start a separate discussion regarding these post remerge > > *) git trees > - rebrand the lede tree to openwrt > - work out what has happened inside the openwrt tree since the reboot > and pick up the useful bits (zoltan has done some prior work on this > already) > > *) mailing list > - ask david to add the openwrt-adm and openwrt lists > - announce the switch to the infradead serves, asking people to > unsubscribe if they have privacy issues with this > - import the user DB from the current openwrt and lede ML into the 2 new > mailing lists > - find out if we can redirect/auto-reply the existing lists to the new > ones > > *) trademark/sponsorship policy > - review/ack imres trademark policy > - review/ack jows sponsorship policy > > *) timeline > - refine / vote / agree on the proposal withing the next 2 week > - work on the action items in the 4 weeks after that All of this sounds good me, and thanks for taking the time to talk to each other and come to an agreement. How can we help? -- Florian ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH v2 1/9] firewall3: check the return value of fw3_parse_options()
Hi Pierre, I merged the whole series into firewall3.git now, thank you! ~ Jo signature.asc Description: OpenPGP digital signature ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] Merged: make_ext4fs: Remove off64_t in favor of standard off_t
Merged into project/make_ext4fs.git, branch master with http://git.lede-project.org/?p=project/make_ext4fs.git;a=commitdiff;h=bb9cf91. Thank you! ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] Merged: dnsmasq: don't propagate DUID from one host to another
Merged into my staging tree with http://git.lede-project.org/?p=lede/jow/staging.git;a=commitdiff;h=6e433148a2. Thank you! ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH v2 1/3] base-files: add/convert generic board detection scripts
On 9 May 2017 at 12:51, Piotr Dymaczwrote: > Hello Roman, Hi > Your mail addresses in from header and in SoB line don't match. is that a problem? > Also, some questions inline, below. > > > On 09.05.2017 11:16, Roman Yeryomin wrote: >> >> Signed-off-by: Roman Yeryomin >> --- >> package/base-files/files/lib/board_detect.sh | 9 >> + >> package/base-files/files/lib/preinit/03_preinit_board_detect | 11 >> +++ >> package/base-files/files/lib/preinit/10_sysinfo | 10 >> -- >> 3 files changed, 20 insertions(+), 10 deletions(-) >> create mode 100644 package/base-files/files/lib/board_detect.sh >> create mode 100644 >> package/base-files/files/lib/preinit/03_preinit_board_detect >> delete mode 100644 package/base-files/files/lib/preinit/10_sysinfo >> >> diff --git a/package/base-files/files/lib/board_detect.sh >> b/package/base-files/files/lib/board_detect.sh >> new file mode 100644 >> index 000..e2f0f89 >> --- /dev/null >> +++ b/package/base-files/files/lib/board_detect.sh >> @@ -0,0 +1,9 @@ >> +board_detect() >> +{ >> + [ -d /proc/device-tree ] || return >> + mkdir -p /tmp/sysinfo >> + [ -e /tmp/sysinfo/board_name ] || \ >> + echo "$(strings /proc/device-tree/compatible | head -1)" > >> /tmp/sysinfo/board_name >> + [ ! -e /tmp/sysinfo/model -a -e /proc/device-tree/model ] && \ >> + echo "$(cat /proc/device-tree/model)" > /tmp/sysinfo/model >> +} >> diff --git a/package/base-files/files/lib/preinit/03_preinit_board_detect >> b/package/base-files/files/lib/preinit/03_preinit_board_detect >> new file mode 100644 >> index 000..739ab02 >> --- /dev/null >> +++ b/package/base-files/files/lib/preinit/03_preinit_board_detect >> @@ -0,0 +1,11 @@ >> +#!/bin/sh >> +# >> +# Copyright (c) 2017 The Linux Foundation. All rights reserved. > > > Why LF? Shouldn't you use here your own copyright or none at all? Probably because that script is actually just a copy from ipq target. Also I would ask the same question -- why LF? Maybe there is an answer buried somewhere in the mail list... > What's more, does it really make sense for you to copyright shell code which > length is almost the same as the copyright line? I don't care much about that but technically you are right. And still, I would make it consistent. So, you can propose a patch which removes all copyrights from scripts. That could even increase performance by some us. > -- > Cheers, > Piotr > > >> +# >> + >> +do_board_detect() >> +{ >> + . /lib/board_detect.sh && board_detect >> +} >> + >> +boot_hook_add preinit_main do_board_detect >> diff --git a/package/base-files/files/lib/preinit/10_sysinfo >> b/package/base-files/files/lib/preinit/10_sysinfo >> deleted file mode 100644 >> index 65b5096..000 >> --- a/package/base-files/files/lib/preinit/10_sysinfo >> +++ /dev/null >> @@ -1,10 +0,0 @@ >> -do_sysinfo_generic() { >> - [ -d /proc/device-tree ] || return >> - mkdir -p /tmp/sysinfo >> - [ -e /tmp/sysinfo/board_name ] || \ >> - echo "$(strings /proc/device-tree/compatible | head -1)" > >> /tmp/sysinfo/board_name >> - [ ! -e /tmp/sysinfo/model -a -e /proc/device-tree/model ] && \ >> - echo "$(cat /proc/device-tree/model)" > /tmp/sysinfo/model >> -} >> - >> -boot_hook_add preinit_main do_sysinfo_generic >> > ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] openwrt and lede - remerge proposal
On 2017-05-09 18:29, Philip Prindeville wrote: > I’d like to suggest one more action item to this list if I can. It > would be handy to have a single database for user > authentication/identification for submitting bugs, editing the Wiki, etc. > > Previously there were too many places where you had to create an > account. If we can’t do “single sign-on”, can we at least do “single > sign-up”? > > And part of a user’s profile should include their IRC handle > (assuming they have one). The todo list for the merge is already quite long, and we need to avoid any unnecessary delay in getting it done. Stuff like this will have to wait... - Felix ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] ath10k-firmware: Update QCA988X firmware to latest version
Please forget about my email below. I've seen this crash again even with the older firmware, so I guess it's unrelated to the firmware verison. I'm currently testing if it might have to do with an option I enabled a few months back: management frame protection. So, I disabled that for now and will see if that changes anything. Thanks, Timo Timo Sigurdsson schrieb am 19.04.2017 10:22: > Hi, > > I'm recommending to revert this commit at least in the 17.01 stable > branch, since there have been reports on the forum about ath10k driver > crashes [1][2]. While I have not been able to reproduce the exact > described behaviour of the driver crashing at an early stage or in > short time, I did in fact experience a crash of the driver after about > 3 weeks uptime. > > I then went on to test the latest build > firmware-5.bin_10.2.4-1.0-00029 from kvalo's firmware repository and > after 2 weeks it crashed again. I suspect my issue is different from > the ones reported (I saved a crash log but can't find it right now, > unfortunately). Nevertheless, I think it's safer to revert this commit > at least on the 17.01 branch. > > Regards, > > Timo > > [1] > https://forum.lede-project.org/t/17-07-1-qca988x-ath10k-5ghz-firmware-crashed-zyxel-nbg6716/1911 > [2] https://forum.lede-project.org/t/5ghz-replacement-for-ath10k-card/3131 > > > Timo Sigurdsson schrieb am 11.01.2017 22:49: > >> This patch updates the QCA988X firmware to the latest revision >> firmware-5.bin_10.2.4-1.0-00016 >> found in the official ath10k-firmware repository. >> >> Tested on TP-Link Archer C7 v2. >> >> Signed-off-by: Timo Sigurdsson>> --- >> package/firmware/ath10k-firmware/Makefile | 8 >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/package/firmware/ath10k-firmware/Makefile >> b/package/firmware/ath10k-firmware/Makefile >> index 5091663..e441700 100644 >> --- a/package/firmware/ath10k-firmware/Makefile >> +++ b/package/firmware/ath10k-firmware/Makefile >> @@ -8,9 +8,9 @@ >> include $(TOPDIR)/rules.mk >> >> PKG_NAME:=ath10k-firmware >> -PKG_SOURCE_DATE:=2016-12-15 >> -PKG_SOURCE_VERSION:=fead2ed867af4e107265059b9f578179d7409867 >> -PKG_MIRROR_HASH:=87fb1998a728b3182d208b978185232decf49d1c72d1ec37c529fa9139354dcb >> +PKG_SOURCE_DATE:=2017-01-11 >> +PKG_SOURCE_VERSION:=ab432c60437931a165f0aff1a6e3371f358b75dd >> +PKG_MIRROR_HASH:=e3188ecd4d7470d3cdde89fefa6258f9ec4f404b23558d1474e5014679b28101 >> PKG_RELEASE:=1 >> >> PKG_SOURCE_PROTO:=git >> @@ -220,7 +220,7 @@ define Package/ath10k-firmware-qca988x/install >> $(PKG_BUILD_DIR)/QCA988X/hw2.0/board.bin \ >> $(1)/lib/firmware/ath10k/QCA988X/hw2.0/ >> $(INSTALL_DATA) \ >> - >> $(PKG_BUILD_DIR)/QCA988X/hw2.0/10.2.4.70/firmware-5.bin_10.2.4.70.59-2 \ >> + >> $(PKG_BUILD_DIR)/QCA988X/hw2.0/10.2.4-1.0/firmware-5.bin_10.2.4-1.0-00016 \ >> $(1)/lib/firmware/ath10k/QCA988X/hw2.0/firmware-5.bin >> endef >> >> -- >> 2.1.4 >> > ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] openwrt and lede - remerge proposal
> On May 8, 2017, at 7:19 AM, John Crispinwrote: > > Hi, > > Felix, Imre and myself had 2 calls last week lasting several hours and > discussed the following proposal of conditions for a remerge that we would > like to propose and have people vote on. > > *) branding > - the owrt side sees no option of using the lede brand > > - a (minor) majority voted for openwrt as a name over lede whilst most people > said they did not care > > - as the last vote had a 100% ACK for a remerge using the owrt brand is the > only feasible option > > *) domain > - transfer owner ship to SPI for openwrt.org and lede-project.org > - add them to the pool of urls at digital ocean > - post remerge build a setup where we have several DNS servers in various > locations > - point git.openwrt.org at the lede git server > - point bugs.openwrt.org to the lede flyspray instance > - keep both wikis and forums as is (we should decide post remerge how to > proceed to avoid these issues blocking the progress) > - update the lede domain entries for build/download/rsync/... servers so that > the openwrt domain also points at them > > *) SPI > - TBD post remerge > > *) github > - stop pushing to lede-project organisation > - start pushing to the openwrt organisation > - cleanup the list of owners in the openwrt organisation > - obsolete all issues on the openwrt organisation and close the issue tracker > - go through the open openwrt and lede PRs, pickup whats useful and close the > rest, asking people to repost (things wont be rebasable anyhow) > - close the lede PR tracker > - keep the lede organisation in its current state so that forked trees dont > get obsoleted > > - obsolete the lede github org after a grace period of 3-6 months > > *) landing page > - update the lede landing page to represent the openwrt name > - update the landing page to have the same look & feel as the current openwrt > landing page > - point openwrt.org at the lede landing page > > *) trac > - trac is already readonly, keep content so that search engines can still > find the it > - edit the trac html templates, adding a note pointing at the bug.openwrt.org > instance > > *) email accounts > - currently there are around ~20 active openwrt.org mail accounts > - turn all the webmaster@, hostmaster@, ... accounts into aliases that anyone > with voting rights can be subscribed to > - ask those people that are no longer active to voluntarily give up their > accounts > - mail addresses may under no conditions be used for any personal business, > consultancy, applying for jobs, ... purposes > > - any mail sent from an openwrt.org account needs to adhere the trademark > policy and should only be used for FOSS purposes > > > *) wiki / forum > - TBD > - asking in either forum/wiki will get a biased vote so keep them both around > - start a separate discussion regarding these post remerge > > *) LF > - find out what doubts folks have about LF > - find out benefits - we would have their hosting and sponsorship ?! > - start a separate discussion regarding these post remerge > > *) git trees > - rebrand the lede tree to openwrt > - work out what has happened inside the openwrt tree since the reboot and > pick up the useful bits (zoltan has done some prior work on this already) > > *) mailing list > - ask david to add the openwrt-adm and openwrt lists > - announce the switch to the infradead serves, asking people to unsubscribe > if they have privacy issues with this > - import the user DB from the current openwrt and lede ML into the 2 new > mailing lists > - find out if we can redirect/auto-reply the existing lists to the new ones > > *) trademark/sponsorship policy > - review/ack imres trademark policy > - review/ack jows sponsorship policy > > *) timeline > - refine / vote / agree on the proposal withing the next 2 week > - work on the action items in the 4 weeks after that > >John I’d like to suggest one more action item to this list if I can. It would be handy to have a single database for user authentication/identification for submitting bugs, editing the Wiki, etc. Previously there were too many places where you had to create an account. If we can’t do “single sign-on”, can we at least do “single sign-up”? And part of a user’s profile should include their IRC handle (assuming they have one). Thanks. -Philip ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] openwrt and lede - remerge proposal
> On May 8, 2017, at 7:29 AM, David Woodhousewrote: > > On Mon, 2017-05-08 at 15:19 +0200, John Crispin wrote: >> >> *) mailing list >> - ask david to add the openwrt-adm and openwrt lists >> - announce the switch to the infradead serves, asking people to >> unsubscribe if they have privacy issues with this >> - import the user DB from the current openwrt and lede ML into the 2 new >> mailing lists >> - find out if we can redirect/auto-reply the existing lists to the new ones > > Yes, we can redirect the existing lists to the new ones — so for > example, mail sent to lede-dev will just turn up on the openwrt-dev > list instead. Assuming that's what you meant. > > For importing subscribers, if that's what you want to do, I'd be > inclined to send *invitations* not just subscribe people. So each > person will get the 'someone has requested that your address be > subscribed; click here to actually do it' message. We can write our own > blurb to go out at the top of those invitations. I think that would be better. I whitelist all of my mailing list subscriptions, so the reminder that I need to add a new one (when I’m not actually subscribing myself) is always helpful. -Philip ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH v2 1/3] base-files: add/convert generic board detection scripts
Hello Roman, Your mail addresses in from header and in SoB line don't match. Also, some questions inline, below. On 09.05.2017 11:16, Roman Yeryomin wrote: Signed-off-by: Roman Yeryomin--- package/base-files/files/lib/board_detect.sh | 9 + package/base-files/files/lib/preinit/03_preinit_board_detect | 11 +++ package/base-files/files/lib/preinit/10_sysinfo | 10 -- 3 files changed, 20 insertions(+), 10 deletions(-) create mode 100644 package/base-files/files/lib/board_detect.sh create mode 100644 package/base-files/files/lib/preinit/03_preinit_board_detect delete mode 100644 package/base-files/files/lib/preinit/10_sysinfo diff --git a/package/base-files/files/lib/board_detect.sh b/package/base-files/files/lib/board_detect.sh new file mode 100644 index 000..e2f0f89 --- /dev/null +++ b/package/base-files/files/lib/board_detect.sh @@ -0,0 +1,9 @@ +board_detect() +{ + [ -d /proc/device-tree ] || return + mkdir -p /tmp/sysinfo + [ -e /tmp/sysinfo/board_name ] || \ + echo "$(strings /proc/device-tree/compatible | head -1)" > /tmp/sysinfo/board_name + [ ! -e /tmp/sysinfo/model -a -e /proc/device-tree/model ] && \ + echo "$(cat /proc/device-tree/model)" > /tmp/sysinfo/model +} diff --git a/package/base-files/files/lib/preinit/03_preinit_board_detect b/package/base-files/files/lib/preinit/03_preinit_board_detect new file mode 100644 index 000..739ab02 --- /dev/null +++ b/package/base-files/files/lib/preinit/03_preinit_board_detect @@ -0,0 +1,11 @@ +#!/bin/sh +# +# Copyright (c) 2017 The Linux Foundation. All rights reserved. Why LF? Shouldn't you use here your own copyright or none at all? What's more, does it really make sense for you to copyright shell code which length is almost the same as the copyright line? -- Cheers, Piotr +# + +do_board_detect() +{ + . /lib/board_detect.sh && board_detect +} + +boot_hook_add preinit_main do_board_detect diff --git a/package/base-files/files/lib/preinit/10_sysinfo b/package/base-files/files/lib/preinit/10_sysinfo deleted file mode 100644 index 65b5096..000 --- a/package/base-files/files/lib/preinit/10_sysinfo +++ /dev/null @@ -1,10 +0,0 @@ -do_sysinfo_generic() { - [ -d /proc/device-tree ] || return - mkdir -p /tmp/sysinfo - [ -e /tmp/sysinfo/board_name ] || \ - echo "$(strings /proc/device-tree/compatible | head -1)" > /tmp/sysinfo/board_name - [ ! -e /tmp/sysinfo/model -a -e /proc/device-tree/model ] && \ - echo "$(cat /proc/device-tree/model)" > /tmp/sysinfo/model -} - -boot_hook_add preinit_main do_sysinfo_generic ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] [PATCH v2 2/3] base-files: put board_name into separate file
Signed-off-by: Roman Yeryomin--- package/base-files/files/lib/functions.sh | 4 +--- package/base-files/files/lib/functions/board.sh | 6 ++ 2 files changed, 7 insertions(+), 3 deletions(-) create mode 100644 package/base-files/files/lib/functions/board.sh diff --git a/package/base-files/files/lib/functions.sh b/package/base-files/files/lib/functions.sh index 2b6415a..2aaafcf 100755 --- a/package/base-files/files/lib/functions.sh +++ b/package/base-files/files/lib/functions.sh @@ -353,8 +353,6 @@ user_exists() { grep -qs "^${1}:" ${IPKG_INSTROOT}/etc/passwd } -board_name() { - [ -e /tmp/sysinfo/board_name ] && cat /tmp/sysinfo/board_name || echo "generic" -} +. /lib/functions/board.sh [ -z "$IPKG_INSTROOT" -a -f /lib/config/uci.sh ] && . /lib/config/uci.sh diff --git a/package/base-files/files/lib/functions/board.sh b/package/base-files/files/lib/functions/board.sh new file mode 100644 index 000..d33edc8 --- /dev/null +++ b/package/base-files/files/lib/functions/board.sh @@ -0,0 +1,6 @@ +#!/bin/sh + +board_name() +{ + [ -e /tmp/sysinfo/board_name ] && cat /tmp/sysinfo/board_name || echo "generic" +} -- 2.7.4 ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] [PATCH v2 1/3] base-files: add/convert generic board detection scripts
Signed-off-by: Roman Yeryomin--- package/base-files/files/lib/board_detect.sh | 9 + package/base-files/files/lib/preinit/03_preinit_board_detect | 11 +++ package/base-files/files/lib/preinit/10_sysinfo | 10 -- 3 files changed, 20 insertions(+), 10 deletions(-) create mode 100644 package/base-files/files/lib/board_detect.sh create mode 100644 package/base-files/files/lib/preinit/03_preinit_board_detect delete mode 100644 package/base-files/files/lib/preinit/10_sysinfo diff --git a/package/base-files/files/lib/board_detect.sh b/package/base-files/files/lib/board_detect.sh new file mode 100644 index 000..e2f0f89 --- /dev/null +++ b/package/base-files/files/lib/board_detect.sh @@ -0,0 +1,9 @@ +board_detect() +{ + [ -d /proc/device-tree ] || return + mkdir -p /tmp/sysinfo + [ -e /tmp/sysinfo/board_name ] || \ + echo "$(strings /proc/device-tree/compatible | head -1)" > /tmp/sysinfo/board_name + [ ! -e /tmp/sysinfo/model -a -e /proc/device-tree/model ] && \ + echo "$(cat /proc/device-tree/model)" > /tmp/sysinfo/model +} diff --git a/package/base-files/files/lib/preinit/03_preinit_board_detect b/package/base-files/files/lib/preinit/03_preinit_board_detect new file mode 100644 index 000..739ab02 --- /dev/null +++ b/package/base-files/files/lib/preinit/03_preinit_board_detect @@ -0,0 +1,11 @@ +#!/bin/sh +# +# Copyright (c) 2017 The Linux Foundation. All rights reserved. +# + +do_board_detect() +{ + . /lib/board_detect.sh && board_detect +} + +boot_hook_add preinit_main do_board_detect diff --git a/package/base-files/files/lib/preinit/10_sysinfo b/package/base-files/files/lib/preinit/10_sysinfo deleted file mode 100644 index 65b5096..000 --- a/package/base-files/files/lib/preinit/10_sysinfo +++ /dev/null @@ -1,10 +0,0 @@ -do_sysinfo_generic() { - [ -d /proc/device-tree ] || return - mkdir -p /tmp/sysinfo - [ -e /tmp/sysinfo/board_name ] || \ - echo "$(strings /proc/device-tree/compatible | head -1)" > /tmp/sysinfo/board_name - [ ! -e /tmp/sysinfo/model -a -e /proc/device-tree/model ] && \ - echo "$(cat /proc/device-tree/model)" > /tmp/sysinfo/model -} - -boot_hook_add preinit_main do_sysinfo_generic -- 2.7.4 ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] [PATCH v2 3/3] ipq806x: migrate to generic board detect infrastructure
Signed-off-by: Roman Yeryomin--- .../linux/ipq806x/base-files/etc/board.d/01_leds | 4 +- .../ipq806x/base-files/etc/board.d/02_network | 4 +- target/linux/ipq806x/base-files/etc/diag.sh| 13 +++- .../etc/hotplug.d/firmware/11-ath10k-caldata | 3 +- .../etc/hotplug.d/ieee80211/10_fix_wifi_mac| 4 +- .../ipq806x/base-files/etc/init.d/linksys_recovery | 3 +- .../linux/ipq806x/base-files/lib/board_detect.sh | 60 target/linux/ipq806x/base-files/lib/ipq806x.sh | 82 -- .../lib/preinit/03_preinit_do_ipq806x.sh | 12 .../ipq806x/base-files/lib/upgrade/platform.sh | 8 +-- 10 files changed, 84 insertions(+), 109 deletions(-) create mode 100644 target/linux/ipq806x/base-files/lib/board_detect.sh delete mode 100644 target/linux/ipq806x/base-files/lib/ipq806x.sh delete mode 100644 target/linux/ipq806x/base-files/lib/preinit/03_preinit_do_ipq806x.sh diff --git a/target/linux/ipq806x/base-files/etc/board.d/01_leds b/target/linux/ipq806x/base-files/etc/board.d/01_leds index 1371767..85c94f0 100755 --- a/target/linux/ipq806x/base-files/etc/board.d/01_leds +++ b/target/linux/ipq806x/base-files/etc/board.d/01_leds @@ -4,11 +4,11 @@ # . /lib/functions/uci-defaults.sh -. /lib/ipq806x.sh +. /lib/functions/board.sh board_config_update -board=$(ipq806x_board_name) +board=$(board_name) case "$board" in c2600) diff --git a/target/linux/ipq806x/base-files/etc/board.d/02_network b/target/linux/ipq806x/base-files/etc/board.d/02_network index bd81a1e..fdcc7e7 100755 --- a/target/linux/ipq806x/base-files/etc/board.d/02_network +++ b/target/linux/ipq806x/base-files/etc/board.d/02_network @@ -5,12 +5,12 @@ # . /lib/functions/uci-defaults.sh -. /lib/ipq806x.sh +. /lib/functions/board.sh . /lib/functions/system.sh board_config_update -board=$(ipq806x_board_name) +board=$(board_name) case "$board" in ap148 |\ diff --git a/target/linux/ipq806x/base-files/etc/diag.sh b/target/linux/ipq806x/base-files/etc/diag.sh index 7c9a9d0..0d3c6b0 100755 --- a/target/linux/ipq806x/base-files/etc/diag.sh +++ b/target/linux/ipq806x/base-files/etc/diag.sh @@ -2,7 +2,18 @@ # Copyright (C) 2016 Henryk Heisig hy...@o2.pl . /lib/functions/leds.sh -. /lib/ipq806x.sh + +ipq806x_get_dt_led() { + local label + local ledpath + local basepath="/sys/firmware/devicetree/base" + local nodepath="$basepath/aliases/led-$1" + + [ -f "$nodepath" ] && ledpath=$(cat "$nodepath") + [ -n "$ledpath" ] && label=$(cat "$basepath$ledpath/label") + + echo "$label" +} boot="$(ipq806x_get_dt_led boot)" failsafe="$(ipq806x_get_dt_led failsafe)" diff --git a/target/linux/ipq806x/base-files/etc/hotplug.d/firmware/11-ath10k-caldata b/target/linux/ipq806x/base-files/etc/hotplug.d/firmware/11-ath10k-caldata index 6526212..9d9e21d 100644 --- a/target/linux/ipq806x/base-files/etc/hotplug.d/firmware/11-ath10k-caldata +++ b/target/linux/ipq806x/base-files/etc/hotplug.d/firmware/11-ath10k-caldata @@ -38,11 +38,10 @@ ath10kcal_patch_mac() { [ -e /lib/firmware/$FIRMWARE ] && exit 0 -. /lib/ipq806x.sh . /lib/functions.sh . /lib/functions/system.sh -board=$(ipq806x_board_name) +board=$(board_name) case "$FIRMWARE" in diff --git a/target/linux/ipq806x/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac b/target/linux/ipq806x/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac index 2ea408d..c24a18f 100644 --- a/target/linux/ipq806x/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac +++ b/target/linux/ipq806x/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac @@ -6,10 +6,10 @@ PHYNBR=${DEVPATH##*/phy} [ -n $PHYNBR ] || exit 0 -. /lib/ipq806x.sh +. /lib/functions/board.sh . /lib/functions/system.sh -board=$(ipq806x_board_name) +board=$(board_name) case "$board" in c2600) diff --git a/target/linux/ipq806x/base-files/etc/init.d/linksys_recovery b/target/linux/ipq806x/base-files/etc/init.d/linksys_recovery index b9ea004..4d94f1f 100755 --- a/target/linux/ipq806x/base-files/etc/init.d/linksys_recovery +++ b/target/linux/ipq806x/base-files/etc/init.d/linksys_recovery @@ -4,9 +4,8 @@ START=97 boot() { . /lib/functions.sh -. /lib/ipq806x.sh -case $(ipq806x_board_name) in +case $(board_name) in ea8500) # make sure auto_recovery in uboot is always on AUTO_RECOVERY_ENA="`fw_printenv -n auto_recovery`" diff --git a/target/linux/ipq806x/base-files/lib/board_detect.sh b/target/linux/ipq806x/base-files/lib/board_detect.sh new file mode 100644 index 000..eb4100e --- /dev/null +++ b/target/linux/ipq806x/base-files/lib/board_detect.sh @@ -0,0 +1,60 @@ +#!/bin/sh +# +# Copyright (c) 2014-2017 The Linux Foundation. All rights reserved. +# Copyright (C) 2011-2017 OpenWrt.org +# + +board_detect() { + local IPQ806X_BOARD_NAME= + local IPQ806X_MODEL= + local machine + local name + + machine=$(cat
[LEDE-DEV] [PATCH v2 0/3] generalize board detection
This provides non intrusive way to generalize board detection. ipq806x target is migrated as example (tested on Netgear R7800). Changes from v1: - convert /lib/preinit/10_sysinfo into default /lib/board_detect.sh - nuke include_file, sysinfo and board_model functions Roman Yeryomin (3): base-files: add/convert generic board detection scripts base-files: put board_name into separate file ipq806x: migrate to generic board detect infrastructure package/base-files/files/lib/board_detect.sh | 9 +++ package/base-files/files/lib/functions.sh | 4 +- package/base-files/files/lib/functions/board.sh| 6 ++ .../files/lib/preinit/03_preinit_board_detect | 11 +++ package/base-files/files/lib/preinit/10_sysinfo| 10 --- .../linux/ipq806x/base-files/etc/board.d/01_leds | 4 +- .../ipq806x/base-files/etc/board.d/02_network | 4 +- target/linux/ipq806x/base-files/etc/diag.sh| 13 +++- .../etc/hotplug.d/firmware/11-ath10k-caldata | 3 +- .../etc/hotplug.d/ieee80211/10_fix_wifi_mac| 4 +- .../ipq806x/base-files/etc/init.d/linksys_recovery | 3 +- .../linux/ipq806x/base-files/lib/board_detect.sh | 60 target/linux/ipq806x/base-files/lib/ipq806x.sh | 82 -- .../lib/preinit/03_preinit_do_ipq806x.sh | 12 .../ipq806x/base-files/lib/upgrade/platform.sh | 8 +-- 15 files changed, 111 insertions(+), 122 deletions(-) create mode 100644 package/base-files/files/lib/board_detect.sh create mode 100644 package/base-files/files/lib/functions/board.sh create mode 100644 package/base-files/files/lib/preinit/03_preinit_board_detect delete mode 100644 package/base-files/files/lib/preinit/10_sysinfo create mode 100644 target/linux/ipq806x/base-files/lib/board_detect.sh delete mode 100644 target/linux/ipq806x/base-files/lib/ipq806x.sh delete mode 100644 target/linux/ipq806x/base-files/lib/preinit/03_preinit_do_ipq806x.sh -- 2.7.4 ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] lantiq: dsl_notify: also restart pppoe interfaces
Hi, On 09/05/17 08:47, Felix Fietkau wrote: > On 2017-05-09 08:46, Mathias Kresin wrote: >> 09.05.2017 00:44, Valentin Spreckels: >>> Signed-off-by: Valentin Spreckels >>>>>> --- >> >> Thanks a lot for your patch. Would you please add a commit message which >> describes the issue you are trying to fix. At the moment I fail to see >> why this change is required. >> >> I rather suspect that the whole pppoa interface handling can be removed >> from dsl_notify.sh. Isn't it handled by netifd now days? > pppoa needs special treatment, because it connects to ATM directly > without going through a netdev. May I suggest to add this information as comment in the script? > For pppoe, this makes no sense, so this patch should be unnecessary. I withdraw the patch. Valentin ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] [PATCH 17.01] fstools: backport regression fix for volume_identify
From: Rafał MiłeckiThis fixes regression when volume_identify didn't identify volume on subsequent calls. Signed-off-by: Rafał Miłecki --- package/system/fstools/Makefile| 1 + ...fix-multiple-volume_identify-usages-with-.patch | 56 ++ 2 files changed, 57 insertions(+) create mode 100644 package/system/fstools/patches/0001-libfstools-fix-multiple-volume_identify-usages-with-.patch diff --git a/package/system/fstools/Makefile b/package/system/fstools/Makefile index cf9bd2119d..28f68b57d6 100644 --- a/package/system/fstools/Makefile +++ b/package/system/fstools/Makefile @@ -15,6 +15,7 @@ PKG_SOURCE_URL=$(LEDE_GIT)/project/fstools.git PKG_SOURCE_DATE:=2016-12-04 PKG_SOURCE_VERSION:=84b530a732b12cca1cd5ee9ba163b7ead7a83de3 PKG_MIRROR_HASH:=b607138de1adbb7f49e53daebe28ac1352910fa2b29278365edeabafc5b46a91 +PKG_RELEASE:=2 CMAKE_INSTALL:=1 PKG_LICENSE:=GPL-2.0 diff --git a/package/system/fstools/patches/0001-libfstools-fix-multiple-volume_identify-usages-with-.patch b/package/system/fstools/patches/0001-libfstools-fix-multiple-volume_identify-usages-with-.patch new file mode 100644 index 00..4a3809a276 --- /dev/null +++ b/package/system/fstools/patches/0001-libfstools-fix-multiple-volume_identify-usages-with-.patch @@ -0,0 +1,56 @@ +From 633a8d0981fed0c90f6d16ee2257858b04514dc8 Mon Sep 17 00:00:00 2001 +From: Pieter Smith +Date: Wed, 29 Mar 2017 18:21:56 +0200 +Subject: [PATCH] libfstools: fix multiple volume_identify usages with the same + volume +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +This fixes e.g. factory-flashed startup issue with jffs2 on ubi overlay + +Commit ba019965 ("libfstools: accept volume as argument in most calls") +broke startup for factory-flashed jffs2 on ubi systems, causing substantial +slowdown in factory environments. + +When starting up with a factory-flashed jffs2 on ubi system, the "rootfs_data" +volume contains a deadcode marker. In the start phase, mount_root then mounts a +tmpfs overlay, and postpones remounting of the jffs2 overlay until the done +phase of the startup. + +The refactoring in ba019965 eliminated an unneeded call to volume_find() when +done() called jffs2_switch(). Unfortunately the refactoring did not take into +account that volume_identify() does not function correctly when called twice in +a row on the same struct volume when using an mtd driver. + +mtd_volume_identify() uses mtd_volume_load() to open an fd to the mtd device +and reads a potential deadcode marker from the fd. The first time this works, +and FS_DEADCODE is returned. + +When volume_identify() is called a second time however, mtd_volume_load() +notices that we already have an open fd, does nothing further and returns 0 +without resetting the file offset to 0. mtd_volume_identify() now reads past +the deadcode marker and now returns FS_JFFS2 if the mtd device is a UBIVOLUME. + +jffs2_switch() then handles the wrong case, either pulling the root out from +under user-space in Chaos Calmer, or indefinitely sticking to a tmpfs overlay +in later OpenWRT builds. + +Signed-off-by: Pieter Smith +Signed-off-by: Rafał Miłecki +--- + +--- a/libfstools/mtd.c b/libfstools/mtd.c +@@ -76,8 +76,10 @@ static int mtd_volume_load(struct mtd_vo + struct mtd_info_user mtdInfo; + struct erase_info_user mtdLockInfo; + +- if (p->fd) ++ if (p->fd) { ++ lseek(p->fd, 0, SEEK_SET); + return 0; ++ } + + if (!p->chr) + return -1; -- 2.11.0 ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [OpenWrt-Devel] openwrt and lede - remerge proposal
On Tue, May 9, 2017 at 9:50 AM, John Crispinwrote: > > > On 09/05/17 09:49, Rafał Miłecki wrote: >> >> On 8 May 2017 at 15:19, John Crispin wrote: >>> >>> *) domain >>> - transfer owner ship to SPI for openwrt.org and lede-project.org >>> (...) >>> >>> *) SPI >>> - TBD post remerge >> >> This is unclear to me. Are we postponing setting rules with SPI on how >> they should manage domains? I guess it should be handled at the same >> time: specifying rules (majority of votes?) and handling domains. > > SPi will need a new liaison officer (team). we need to vote on who this will > be. apart from that SPI will be pointed at the wiki page listing voters and > rules. domains will be handed over to them SPI offers different services to projects like accepting donations and holding funds, legal assistance, technical services, etc ... Apart from handing over the domains do we want to make use of any of the services offered by SPI ? Further nice to read we convergence again; thx for the effort ! Hans > > John > > ___ > openwrt-devel mailing list > openwrt-de...@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [OpenWrt-Devel] openwrt and lede - remerge proposal
On 09/05/17 09:49, Rafał Miłecki wrote: On 8 May 2017 at 15:19, John Crispinwrote: *) domain - transfer owner ship to SPI for openwrt.org and lede-project.org (...) *) SPI - TBD post remerge This is unclear to me. Are we postponing setting rules with SPI on how they should manage domains? I guess it should be handled at the same time: specifying rules (majority of votes?) and handling domains. SPi will need a new liaison officer (team). we need to vote on who this will be. apart from that SPI will be pointed at the wiki page listing voters and rules. domains will be handed over to them John ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [OpenWrt-Devel] openwrt and lede - remerge proposal
On 8 May 2017 at 15:19, John Crispinwrote: > *) domain > - transfer owner ship to SPI for openwrt.org and lede-project.org > (...) > > *) SPI > - TBD post remerge This is unclear to me. Are we postponing setting rules with SPI on how they should manage domains? I guess it should be handled at the same time: specifying rules (majority of votes?) and handling domains. ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] ramips: Add support for GL-MT300N-V2
Hello Thomas, On 04.05.2017 21:30, Thomas Endt wrote: -Ursprüngliche Nachricht- von Piotr Dymacz Gesendet: Donnerstag, 4. Mai 2017 10:30 Hello, Please, make sure to add a proper SoB line as described in "Submitting patches": [1]. Also, could you please include in your commit message short description about the hardware and how to install LEDE on it? Have a look at the recent ramips board additions for some examples: [2]. [1] https://lede-project.org/submitting-patches [2] https://github.com/lede- project/source/search?=ramips+add+support+for=Commits I think it would make sense to add a note to [1] regarding hardware description and install instructions. This is really helpful information for adding devices to the Table of Hardware, especially for devices where not much if any information can be found on the net. Hopefully it will also save you from having to repeat that note with each new "add support for..." commit. Thomas I just saw that you already did it 2 days ago: https://lede-project.org/submitting-patches?rev=1494176457 Thank you! -- Cheers, Piotr ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] lantiq: dsl_notify: also restart pppoe interfaces
On 2017-05-09 08:46, Mathias Kresin wrote: > 09.05.2017 00:44, Valentin Spreckels: >> Signed-off-by: Valentin Spreckels >>>> --- > > Thanks a lot for your patch. Would you please add a commit message which > describes the issue you are trying to fix. At the moment I fail to see > why this change is required. > > I rather suspect that the whole pppoa interface handling can be removed > from dsl_notify.sh. Isn't it handled by netifd now days? pppoa needs special treatment, because it connects to ATM directly without going through a netdev. For pppoe, this makes no sense, so this patch should be unnecessary. - Felix ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] lantiq: dsl_notify: also restart pppoe interfaces
09.05.2017 00:44, Valentin Spreckels: Signed-off-by: Valentin Spreckels--- Thanks a lot for your patch. Would you please add a commit message which describes the issue you are trying to fix. At the moment I fail to see why this change is required. I rather suspect that the whole pppoa interface handling can be removed from dsl_notify.sh. Isn't it handled by netifd now days? Mathias target/linux/lantiq/base-files/sbin/dsl_notify.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/lantiq/base-files/sbin/dsl_notify.sh b/target/linux/lantiq/base-files/sbin/dsl_notify.sh index 11ada92..8503ab4 100755 --- a/target/linux/lantiq/base-files/sbin/dsl_notify.sh +++ b/target/linux/lantiq/base-files/sbin/dsl_notify.sh @@ -33,7 +33,7 @@ for ifc in $interfaces; do json_load "$(ifstatus $ifc)" json_get_var proto proto - if [ "$proto" != "pppoa" ]; then + if [ "$proto" != "pppoa" -a "$proto" != "pppoe" ]; then continue fi ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] openwrt and lede - remerge proposal
I, too, look forward to putting energy where it matters. However in reply to your point, how could it? When the first stable release was made mere months ago. The last patch that was submitted by QCA to add support for IPQ40XX, was submitted to LEDE. I simply hoped, that since there was a shake-off that catapulted all the great things which resulted in LEDE, that this new name made more sense to what the project hopes to represent as a whole, regardless of this perceived "brand value" and all that. Regards, A. Benz On 05/09/17 14:05, David Lang wrote: On Tue, 9 May 2017, A. Benz via Lede-dev wrote: Likewise, OpenWRT while more recognizable than LEDE, is not worth as much as people here paint it, and will only remain relevant as long as people keep using it. Market/brand concept (in retail) doesn't really apply. I'll point out that just last week we had an official contact from the Open Compute project to OpenWRT looking to integrate OpenWRT for dealing with wifi devices in Open Compute. Open Compute is a pretty significant project that's expected to keep up with technology. If they do not know of LEDE and think of OpenWRT for the purpose, it shows that LEDE has not make the progress that you think it has in name recognition. But in any case, the decision has been made, it doesn't really help to keep arguing the name issue. There's enough other work to be done. I'm glad to see this progress and look forward to the remerge happening. David Lang ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] openwrt and lede - remerge proposal
On Tue, 9 May 2017, A. Benz via Lede-dev wrote: Likewise, OpenWRT while more recognizable than LEDE, is not worth as much as people here paint it, and will only remain relevant as long as people keep using it. Market/brand concept (in retail) doesn't really apply. I'll point out that just last week we had an official contact from the Open Compute project to OpenWRT looking to integrate OpenWRT for dealing with wifi devices in Open Compute. Open Compute is a pretty significant project that's expected to keep up with technology. If they do not know of LEDE and think of OpenWRT for the purpose, it shows that LEDE has not make the progress that you think it has in name recognition. But in any case, the decision has been made, it doesn't really help to keep arguing the name issue. There's enough other work to be done. I'm glad to see this progress and look forward to the remerge happening. David Lang ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev